Re: [PATCH] nilfs2: Fix typos in comments

Hi Andrew, Please also queue this typo fix patch that came separately. Thanks, Ryusuke Konishi On Fri, Apr 9, 2021 at 1:35 PM Ryusuke Konishi wrote: > > From: Lu Jialin > > numer -> number in fs/nilfs2/cpfile.c > Decription -> Description in fs/nilfs2/ioctl.c > is

[PATCH] nilfs2: Fix typos in comments

From: Lu Jialin numer -> number in fs/nilfs2/cpfile.c Decription -> Description in fs/nilfs2/ioctl.c isntance -> instance in fs/nilfs2/the_nilfs.c Signed-off-by: Lu Jialin Link: https://lore.kernel.org/r/20210409022519.176988-1-lujial...@huawei.com Signed-off-by: Ryusuke Konishi

Re: [PATCH v2 -next] nilfs2: Fix typos in comments

Thank you. Will apply this. Ryusuke Konishi On Fri, Apr 9, 2021 at 11:25 AM Lu Jialin wrote: > > numer -> number in fs/nilfs2/cpfile.c > Decription -> Description in fs/nilfs2/ioctl.c > isntance -> instance in fs/nilfs2/the_nilfs.c > > Signed-off-by: Lu Jialin >

Re: [PATCH -next] nilfs2: Fix typos in comments

Hi, This patch partially overlaps the following fix that I previously sent to Andrew: https://lkml.org/lkml/2021/4/8/114 Can you exclude two typo fixes of "retured -> returned" from yours ? Thanks, Ryusuke Konishi On Thu, Apr 8, 2021 at 11:08 PM Lu Jialin wrote: > > nu

Re: [PATCH] fs/nilfs2: fix misspellings using codespell tool

Hi Andrew, Please queue this typo fix for the next merge window. Thank you, Ryusuke Konishi On Thu, Apr 8, 2021 at 3:41 PM Ryusuke Konishi wrote: > > From: Liu xuzhi > > Two typos are found out by codespell tool \ > in 2217th and 2254th lines of segment.c: > > $

[PATCH] fs/nilfs2: fix misspellings using codespell tool

From: Liu xuzhi Two typos are found out by codespell tool \ in 2217th and 2254th lines of segment.c: $ codespell ./fs/nilfs2/ ./segment.c:2217 :retured ==> returned ./segment.c:2254: retured ==> returned Fix two typos found by codespell. Signed-off-by: Liu xuzhi Signed-off-by: R

Re: KASAN: use-after-free in nilfs_mdt_destroy

Hi, I haven't yet succeeded to reproduce the issue with the attached program. How reproducible is it in your environment? (Does it take a long time to reproduce ?) Regards, Ryusuke Konishi On Mon, Mar 22, 2021 at 6:05 PM butt3rflyh4ck wrote: > > Hi, guy, I reported a bug found b

Re: [PATCH] fs/nilfs2: fix misspellings using codespell tool

Applied, thank you. Ryusuke Konishi On Thu, Mar 18, 2021 at 8:32 PM wrote: > > From: Liu xuzhi > > Two typos are found out by codespell tool \ > in 2217th and 2254th lines of segment.c: > > $ codespell ./fs/nilfs2/ > ./segment.c:2217 :retured ==> returned

Re: [PATCH] nilfs2: make splice write available again

Hi Andrew, Please send this to upstream. This fixes a regression of splice() on nilfs2. Thanks, Ryusuke Konishi On Mon, Feb 8, 2021 at 8:35 PM Ryusuke Konishi wrote: > > From: Joachim Henke > > Since 5.10, splice() or sendfile() to NILFS2 return EINVAL. This was > c

[PATCH] nilfs2: make splice write available again

to restore the functionality. Signed-off-by: Joachim Henke Signed-off-by: Ryusuke Konishi Tested-by: Ryusuke Konishi Cc: sta...@vger.kernel.org # 5.10+ --- fs/nilfs2/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nilfs2/file.c b/fs/nilfs2/file.c index 64bc81363c6c..e1bd592ce700 100644

Re: [PATCH] fs/nilfs2: remove some unused macros to tame gcc

Hi Andrew, Please queue this, a gcc warning fix, for the next merge window. Thanks, Ryusuke Konishi On Thu, Dec 10, 2020 at 7:25 AM Ryusuke Konishi wrote: > > From: Alex Shi > > There some macros are unused and cause gcc warning. Remove them. > > fs/nilfs2/segment.c:137

[PATCH] fs/nilfs2: remove some unused macros to tame gcc

ent.c:143:0: warning: macro "nilfs_cnt32_lt" is not used [-Wunused-macros] Signed-off-by: Alex Shi Signed-off-by: Ryusuke Konishi --- fs/nilfs2/segment.c | 5 - 1 file changed, 5 deletions(-) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index e3726aca28ed..cd4da9535aed 10

Re: [PATCH] nilfs2: Fix some kernel-doc warnings for nilfs2

Hi Andrew, Please queue this, kernel-doc warnings fix, for the next merge window. Thanks, Ryusuke Konishi On Tue, Sep 29, 2020 at 10:31 PM Ryusuke Konishi wrote: > > From: Wang Hai > > Fixes the following W=1 kernel build warning(s): > > fs/nilfs2/bmap.c:378: warnin

[PATCH] nilfs2: Fix some kernel-doc warnings for nilfs2

warning: Excess function parameter 'stat' description in 'nilfs_sufile_get_stat' Signed-off-by: Wang Hai Signed-off-by: Ryusuke Konishi --- fs/nilfs2/bmap.c | 2 +- fs/nilfs2/cpfile.c | 6 +++--- fs/nilfs2/page.c | 1 - fs/nilfs2/sufile.c | 4 ++-- 4 files changed,

Re: [PATCH -next] nilfs2: Fix some kernel-doc warnings for nilfs2

Hi Wang, The patch looks correct. Will apply, thank you. Ryusuke Konishi On Fri, Sep 18, 2020 at 9:40 PM Wang Hai wrote: > > Fixes the following W=1 kernel build warning(s): > > fs/nilfs2/bmap.c:378: warning: Excess function parameter 'bhp' description in > '

Re: [PATCH] nilfs2: only call unlock_new_inode() if I_NEW

Yeah, I sent this to Andrew a little while ago: https://lkml.org/lkml/2020/7/27/976 Thanks, Ryusuke Konishi On Tue, Jul 28, 2020 at 1:50 AM Eric Biggers wrote: > > On Sun, Jun 28, 2020 at 12:01:52AM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > unlock_n

[PATCH 2/3] nilfs2: Convert __nilfs_msg to integrate the level and format

: $ size -t fs/nilfs2/built-in.a | tail -1 1909718676 44 199691 30c0b (TOTALS) Signed-off-by: Joe Perches Signed-off-by: Ryusuke Konishi --- fs/nilfs2/nilfs.h | 9 - fs/nilfs2/super.c | 16 +++- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/fs

[PATCH 0/3] nilfs2 updates

use more common kernel logging styles. Thanks, Ryusuke Konishi -- fs/nilfs2/alloc.c | 38 +++ fs/nilfs2/btree.c | 42 - fs/nilfs2/cpfile.c| 10 +++--- fs/nilfs2/dat.c | 14 - fs/nilfs2/direct.c| 14 + fs/nilfs2/gcinode

[PATCH 3/3] nilfs2: Use a more common logging style

rches Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.c | 38 +++ fs/nilfs2/btree.c | 42 - fs/nilfs2/cpfile.c| 10 +++--- fs/nilfs2/dat.c | 14 - fs/nilfs2/direct.c| 14 + fs/nilfs2/gcinode.c | 2 +- fs/nil

[PATCH 1/3] nilfs2: only call unlock_new_inode() if I_NEW

() if the inode has the I_NEW flag set, indicating that it's in the table. Signed-off-by: Eric Biggers Signed-off-by: Ryusuke Konishi --- fs/nilfs2/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c index 28009ec54420..3318dd1

[PATCH] nilfs2: fix null pointer dereference at nilfs_segctor_do_construct()

off-by: Ryusuke Konishi Tested-by: Ryusuke Konishi Cc: sta...@vger.kernel.org # v5.4+ --- fs/nilfs2/segment.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 445eef4..91b58c8 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -2780,6

Re: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8 in nilfs_segctor_do_co

> Wondering if it can be reproduced on mainline with c3aab9a0bd91 > ("mm/filemap.c: dont initiate writeback if mapping has no dirty pages") > reverted? For mainline kernels with that commit reverted, this oops actually doesn't occur. Regards, Ryusuke Konishi On Mon,

Re: BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8 in nilfs_segctor_do_co

advance. To ensure inode_attach_wb() is called, mark_buffer_dirty() should be called for those buffers. The following patch fixes this issue, but I got another oops at nilfs_segctor_complete_write() during a stress test. So, I'm still investigating. Regards, Ryusuke Konishi === diff --git

Re: [PATCH V2] nilfs2: Fix reference count leak in nilfs_sysfs_create_device_group

Hi Andrew, This v2 patch was not CC'ed to you. Could you please pick it up from LKML? Regards, Ryusuke Konishi On Thu, May 28, 2020 at 8:23 AM Ryusuke Konishi wrote: > > Hi Andrew, > > Please pick this up as well. > > Acked-by: Ryusuke Konishi > > On Thu, M

Re: [PATCH V2] nilfs2: Fix reference count leak in nilfs_sysfs_create_device_group

Hi Andrew, Please pick this up as well. Acked-by: Ryusuke Konishi On Thu, May 28, 2020 at 8:04 AM wrote: > > From: Qiushi Wu > > kobject_init_and_add() takes reference even when it fails. > In nilfs_sysfs_create_device_group(), the memory allocated by > kobject_init_and_

Re: [PATCH] nilfs2: Fix reference count leak in nilfs_sysfs_create_device_group

Qiushi Wu, Can we call kobject_del() instead of kobject_put() when kobject_init_and_add() failed ? If it's unclear, I think we should fix this by calling kobject_put() when kobject_init_and_add() fails, and goto free_dev_subgroups. Regards, On Thu, May 28, 2020 at 5:10 AM wrote: > > Fro

Re: [PATCH] nilfs2: Fix reference count leak in nilfs_sysfs_create_snapshot_group.

Andrew, Apply this, please. Acked-by: Ryusuke Konishi On Thu, May 28, 2020 at 4:55 AM wrote: > > From: Qiushi Wu > > kobject_init_and_add() takes reference even when it fails. > If this function returns an error, kobject_put() must be called to > properly clean up the memo

[PATCH] MAINTAINERS: nilfs2: update email address

Change my email since lab.ntt.co.jp email domain has been deprecated due to company policy. Signed-off-by: Ryusuke Konishi --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 01a52fc..b8eadb3 100644 --- a/MAINTAINERS +++ b

Re: [PATCH] nilfs2: do not use unexported cpu_to_le32()/le32_to_cpu() in uapi header

yusuke Konishi Regards, Ryusuke Konishi 2019年7月7日(日) 15:42 Masahiro Yamada : > > Konishi-san, > > > On Sun, Jul 7, 2019 at 3:11 PM Ryusuke Konishi > wrote: > > > > Yamada-san, > > > > I'm sorry for not being able to follow. > > > >

Re: [PATCH] nilfs2: do not use unexported cpu_to_le32()/le32_to_cpu() in uapi header

the change and modify nilfs utilities to comply with the guideline. Thanks, Ryusuke Konishi 2019年7月7日(日) 13:31 Masahiro Yamada : > > Hi Andrew, > > On Sun, Jul 7, 2019 at 12:38 PM Andrew Morton > wrote: > > > > > Seems fairly serious. I'm thinking this need

Re: [PATCH] nilfs2: fix potential use after free

Hi, Pan Bian Thank you for feeding back this patch. I reviewed this and am thinking this must be sent to upstream. Did you see any kernel oops on this bug ? Regards, Ryusuke Konishi On Mon, 26 Nov 2018 11:08:29 +0800, Pan Bian wrote: > brelse(bh) is called to drop the reference count of

Re: [PATCH v2] fs: Convert return type int to vm_fault_t

-new-return-type-vm_fault_t.patch. Looks like a simple > fix. In the first patch in this thread, this return type change was excluded correctly for nilfs_page_mkwrite() though the changelog was inaccurate in that sense. Please confirm your base point of the revised patch. Regards, Ryusuke Konishi > > I'm beginning to feel vm_fault_t exhaustion. Please remind me what > benefit we're going to get out of all this churn? > >> >> ... >>

[PATCH] nilfs2: convert to SPDX license tags

Remove the verbose license text from NILFS2 files and replace them with SPDX tags. This does not change the license of any of the code. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.c | 11 +-- fs/nilfs2/alloc.h | 11 +-- fs/nilfs2/bmap.c | 11 +-- fs

Re: [PATCH] fs: Convert return type int to vm_fault_t

lfs_near_disk_full(inode->i_sb->s_fs_info))) > return VM_FAULT_SIGBUS; /* -ENOSPC */ > @@ -67,7 +68,7 @@ static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf) > if (page->mapping != inode->i_mapping || > page_offset(page) >= i_size_rea

[PATCH] fs: nilfs2: Adding new return type vm_fault_t

From: Souptick Joarder Use new return type vm_fault_t for page_mkwrite handler. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Signed-off-by: Ryusuke Konishi --- fs/nilfs2/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/file.c b/fs/nilfs2

Re: [PATCH] nilfs2: use time64_t internally

tent and correct on both 32-bit > and 64-bit machines. > > The on-disk format already uses 64-bit timestamps, so nothing changes > there. > > Signed-off-by: Arnd Bergmann Thank you for this patch. Acked-by: Ryusuke Konishi > --- > fs/nilfs2/segbuf.c| 2 +- >

[PATCH] MAINTAINERS, nilfs2: change project home URLs

ttps. Signed-off-by: Ryusuke Konishi --- Documentation/filesystems/nilfs2.txt | 4 ++-- MAINTAINERS | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/filesystems/nilfs2.txt b/Documentation/filesystems/nilfs2.txt index c0727dc..f2f3f85 100644

[PATCH 1/1] nilfs2: remove inode->i_version initialization

From: Jeff Layton It's never used in nilfs2. Signed-off-by: Jeff Layton Signed-off-by: Ryusuke Konishi --- fs/nilfs2/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 4fc018d..3ce20cd 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/su

[PATCH 0/1] nilfs2 additional change

Hi Andrew, Please add the following change to the queue of next merge window: Jeff Layton (1): nilfs2: remove inode->i_version initialization Thanks, Ryusuke Konishi -- fs/nilfs2/super.c | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH] fs/nilfs2: Convert timers to use timer_setup()

x27;s target task, as the lifetime of sc_task doesn't appear to > match the timer's task. > > Cc: Ryusuke Konishi > Cc: linux-ni...@vger.kernel.org > Signed-off-by: Kees Cook Looks good. Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi > --- > fs/nilfs2/segmen

Re: [PATCH] nilfs2: remove inode->i_version initialization

On Mon, 30 Oct 2017 11:17:02 -0400, Jeff Layton wrote: > From: Jeff Layton > > It's never used in nilfs2. > > Signed-off-by: Jeff Layton > --- Applied, thank you. Ryusuke Konishi > fs/nilfs2/super.c | 1 - > 1 file changed, 1 deletion(-) > > diff --

[PATCH 3/4] nilfs2: align block comments of nilfs_sufile_truncate_range() at *

Fix the following checkpatch warning: WARNING: Block comments should align the * on each line #633: FILE: sufile.c:633: +/** + * nilfs_sufile_truncate_range - truncate range of segment array Signed-off-by: Ryusuke Konishi --- fs/nilfs2/sufile.c | 32 1

[PATCH 0/4] nilfs2 updates

Hi Andrew, Please queue the following changes for the next merge window: Andreas Rohner (1): nilfs2: Fix race condition that causes file system corruption Elena Reshetova (1): fs, nilfs: convert nilfs_root.count from atomic_t to refcount_t Ryusuke Konishi (2): nilfs2: align

[PATCH 2/4] fs, nilfs: convert nilfs_root.count from atomic_t to refcount_t

ff-by: Ryusuke Konishi --- fs/nilfs2/the_nilfs.c | 8 fs/nilfs2/the_nilfs.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c index 2dd75bf..afebb50 100644 --- a/fs/nilfs2/the_nilfs.c +++ b/fs/nilfs2/the_nilfs.c @@ -737,7 +

[PATCH 4/4] nilfs2: use octal for unreadable permission macro

Replace S_IRWXUGO with 0777 because symbolic permissions are considered harmful: https://lwn.net/Articles/696229/ Signed-off-by: Ryusuke Konishi --- fs/nilfs2/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index 515d13c

[PATCH 1/4] nilfs2: Fix race condition that causes file system corruption

overwrites millions of 4k files. Signed-off-by: Andreas Rohner Signed-off-by: Ryusuke Konishi Tested-by: Andreas Rohner Tested-by: Ryusuke Konishi Cc: sta...@vger.kernel.org --- fs/nilfs2/segment.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/nilfs2/segment.c b

Re: [PATCH] fs, nilfs: convert nilfs_root.count from atomic_t to refcount_t

Elena Reshetova Applied, thank you. Ryusuke Konishi --- fs/nilfs2/the_nilfs.c | 8 fs/nilfs2/the_nilfs.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2/the_nilfs.c index 2dd75bf..afebb50 100644 --- a/fs/nilfs2/the_nilfs.c

Re: [PATCH 1/3] nilfs2: set the mapping error when calling SetPageError on writeback

> Signed-off-by: Jeff Layton Acked-by: Ryusuke Konishi Agreed that nilfs2 needs this if the successive patch is applied. Thanks, Ryusuke Konishi > --- > fs/nilfs2/segment.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c &

Re: + nilfs2-use-i_blocksize.patch added to -mm tree

d-i_blocksize.patch and will break build without it. Thanks, Ryusuke Konishi > > Before you just go and hit "reply", please: >a) Consider who else should be cc'ed >b) Prefer to cc a suitable mailing list as well >c) Ideally: find the original patch on t

[PATCH -mm 2/2] nilfs2: use i_blocksize()

From: Geliang Tang Since i_blocksize() helper has been defined in fs.h, use it instead of open-coding. Signed-off-by: Geliang Tang Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.c | 2 +- fs/nilfs2/btree.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nilfs2

[PATCH -mm 0/2] nilfs2 minor changes

anwhile "nilfs2: use nilfs_btree_node_size()" is applicable independently. Thanks, Ryusuke Konishi -- fs/nilfs2/alloc.c | 2 +- fs/nilfs2/btree.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH -mm 1/2] nilfs2: use nilfs_btree_node_size()

From: Geliang Tang Use nilfs_btree_node_size() instead of open-coding. Signed-off-by: Geliang Tang Signed-off-by: Ryusuke Konishi --- fs/nilfs2/btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c index 2e315f9..9c7ea17 100644

Re: [PATCH 1/2] nilfs2: use i_blocksize()

i_blocksize()" which I found in the latest -mm tree. I will send this to the -mm tree along with this dependency. Regards, Ryusuke Konishi > --- > fs/nilfs2/alloc.c | 2 +- > fs/nilfs2/btree.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/

Re: [PATCH 2/2] nilfs2: use nilfs_btree_node_size()

On Fri, 20 Jan 2017 22:34:58 +0800, Geliang Tang wrote: > Use nilfs_btree_node_size() instead of open-coding. > > Signed-off-by: Geliang Tang Applied, thanks. Ryusuke Konishi > --- > fs/nilfs2/btree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

[PATCH 1/1] fs/nilfs2: Fix potential underflow in call to crc32_le

[201699.218595] [] entry_SYSCALL_64_fastpath+0x16/0x71 Signed-off-by: Torsten Hilbrich Tested-by: Torsten Hilbrich Signed-off-by: Ryusuke Konishi Cc: sta...@vger.kernel.org --- fs/nilfs2/the_nilfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/the_nilfs.c b/fs/nilfs2

[PATCH 0/1] fs/nilfs2: Fix potential underflow in call to crc32_le

through nilfs2. The patch is applicable to the mainline as well as -mm tree. Thanks, Ryusuke Konishi -- Torsten Hilbrich (1): fs/nilfs2: Fix potential underflow in call to crc32_le fs/nilfs2/the_nilfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] nilfs: avoid warning about unused variables

lfs_warning() with nilfs_msg()") Thanks for the catch! Regards, Ryusuke Konishi > --- > fs/nilfs2/nilfs.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/nilfs2/nilfs.h b/fs/nilfs2/nilfs.h > index b7064faef217..46fbd4e00315 100644 > --- a/fs

Re: [PATCH 3/3] nilfs2: move ioctl interface and disk layout to uapi separately

On Tue, 14 Jun 2016 15:29:52 -0700, Andrew Morton wrote: > On Mon, 13 Jun 2016 22:45:07 +0900 Ryusuke Konishi > wrote: > >> The header file "include/linux/nilfs2_fs.h" is composed of parts for >> ioctl and disk format, and both are intended to be shared with user

[PATCH 0/3] nilfs2 additional updates

Hi Andrew, please add the following changes for the next merge window: Ryusuke Konishi (3): nilfs2: fix misuse of a semaphore in sysfs code nilfs2: use BIT() macro nilfs2: move ioctl interface and disk layout to uapi separately In this series, > nilfs2: fix misuse o

[PATCH 2/3] nilfs2: use BIT() macro

Replace bit shifts by BIT macro for clarity. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/btnode.c | 4 ++-- fs/nilfs2/inode.c | 4 ++-- fs/nilfs2/nilfs.h | 15 +++ fs/nilfs2/page.c| 26 +- fs/nilfs2/segment.c | 14 +++--- fs/nilfs2

[PATCH 3/3] nilfs2: move ioctl interface and disk layout to uapi separately

fs2_ondisk.h". The following minor changes are accompanied by this migration: - nilfs_direct_node struct in nilfs2/direct.h is converged to nilfs2_ondisk.h because it's an on-disk structure. - inline functions nilfs_rec_len_from_disk() and nilfs_rec_len_to_disk() are moved to

[PATCH 1/3] nilfs2: fix misuse of a semaphore in sysfs code

the comment of the_nilfs struct. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/sysfs.c | 44 ++-- fs/nilfs2/the_nilfs.h | 7 ++- 2 files changed, 24 insertions(+), 27 deletions(-) diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c index 8e57bb9

[PATCH 8/8] nilfs2: refactor parser of snapshot mount option

Move parser of snapshot mount option to a separate function nilfs_parse_snapshot_option(), replace simple_strtoull() with kstrtoull() to avoid checkpatch.pl warning "WARNING: simple_strtoull is obsolete, use kstrtoull instead", and refine the error message of the parser. Signed-off-b

[PATCH 1/8] nilfs2: hide function name argument from nilfs_error()

__func__ argument except nilfs_bmap_convert_error(); nilfs_bmap_convert_error() directly calls __nilfs_error() because it inherits caller's function name. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/bmap.c | 4 ++-- fs/nilfs2/dir.c | 38 +- fs/nilfs2/if

[PATCH 3/8] nilfs2: embed a back pointer to super block instance in nilfs object

Insert a back pointer to super block instance in nilfs object so that functions of nilfs2 easily refer to the super block instance. This simplifies replacement of printk() in the successive change. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/super.c | 2 +- fs/nilfs2/the_nilfs.c | 7

[PATCH 5/8] nilfs2: replace nilfs_warning() with nilfs_msg()

Use nilfs_msg() to output warning messages and get rid of nilfs_warning() function. This also removes function names from the messages unless we embed them explicitly in format strings. Instead, some messages are revised to clarify the context. Signed-off-by: Ryusuke Konishi --- fs/nilfs2

[PATCH 0/8] nilfs2 updates

Hi Andrew, Please queue the following changes for the next merge window: Ryusuke Konishi (8): nilfs2: hide function name argument from nilfs_error() nilfs2: add nilfs_msg() message interface nilfs2: embed a back pointer to super block instance in nilfs object nilfs2

[PATCH 6/8] nilfs2: emit error message when I/O error is detected

When nilfs returned -EIO as an error code, it's not always clear if it came from the underlying block device or not. This will mend the issue by having low level I/O routines of nilfs output an error message when they detected an I/O error. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/bt

[PATCH 4/8] nilfs2: reduce bare use of printk() with nilfs_msg()

checkpatch warning "WARNING: quoted string split across lines" that often accompanies the prior warning, and amends message format as needed. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/btree.c | 58 +-- fs/nilfs2/cpfile.c| 22 - fs/nilf

[PATCH 7/8] nilfs2: do not use yield()

ld() kernel-doc (sched/core.c)" Signed-off-by: Ryusuke Konishi --- fs/nilfs2/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 7e1864c..5a97282 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -373,7 +

[PATCH 2/8] nilfs2: add nilfs_msg() message interface

level, and terminates the statement with a newline. The "device-name" is optional to make it available in early stages; it will be omitted if a NULL pointer is passed to super block instance argument. nilfs_msg() wraps __nilfs_msg() and is removed if CONFIG_PRINTK is not set. Signed-off

[PATCH 2/7] nilfs2: remove space before semicolon

This fixes the checkpatch.pl warning "WARNING: space prohibited before semicolon" at nilfs_store_magic_and_option(). Signed-off-by: Ryusuke Konishi --- fs/nilfs2/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c ind

[PATCH 3/7] nilfs2: fix code indent coding style issue

This fixes checkpatch.pl warning "WARNING: suspect code indent for conditional statements". Signed-off-by: Ryusuke Konishi --- fs/nilfs2/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 0271784..666107a 10064

[PATCH 1/7] nilfs2: do not emit extra newline on nilfs_warning() and nilfs_error()

This updates call sites of nilfs_warning() and nilfs_error() so that they don't add a duplicate newline. These output functions are already designed to add a trailing newline to the message. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.c | 10 +- fs/nilfs2/bmap.c| 2 +

[PATCH 0/7] nilfs2 additional fixes

Hi Andrew, Please append the following changes for the upcoming merge window: Ryusuke Konishi (7): nilfs2: do not emit extra newline on nilfs_warning() and nilfs_error() nilfs2: remove space before semicolon nilfs2: fix code indent coding style issue nilfs2: avoid bare

[PATCH 7/7] nilfs2: fix block comments

This fixes block comments with proper formatting to eliminate the following checkpatch.pl warnings: "WARNING: Block comments use * on subsequent lines" "WARNING: Block comments use a trailing */ on a separate line" Signed-off-by: Ryusuke Konishi --- fs/nilfs2/

[PATCH 4/7] nilfs2: avoid bare use of 'unsigned'

This fixes checkpatch.pl warning "WARNING: Prefer 'unsigned int' to bare use of 'unsigned'". Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.c | 8 fs/nilfs2/alloc.h | 2 +- fs/nilfs2/bmap.c | 2 +- fs/nilfs2/bmap.h

[PATCH 6/7] nilfs2: remove loops of single statement macros

This fixes checkpatch.pl warning "WARNING: Single statement macros should not use a do {} while (0) loop". Signed-off-by: Ryusuke Konishi --- fs/nilfs2/the_nilfs.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/nilfs2/the_nilfs.h b/fs/nilfs2/the_nil

[PATCH 5/7] nilfs2: remove unnecessary else after return or break

This fixes the checkpatch.pl warning that suggests else is not generally useful after a break or return. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/btree.c | 12 ++-- fs/nilfs2/direct.c | 6 +++--- fs/nilfs2/segment.c | 26 -- 3 files changed, 21 insertions

Re: [PATCH 11/11] nilfs2: clean trailing semicolons in macros

Hi Andrew, On Fri, 29 Apr 2016 22:15:47 +0900, Ryusuke Konishi wrote: > Remove trailing semicolons from macros, as suggested by checkpatch.pl. > > Signed-off-by: Ryusuke Konishi > --- > diff --git a/fs/nilfs2/sysfs.h b/fs/nilfs2/sysfs.h > index 677e3a1..648cedf 100644 > --

[PATCH 05/11] MAINTAINERS: add web link for nilfs project

Add nilfs.osdn.jp as the second web site of nilfs project. Signed-off-by: Ryusuke Konishi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1d5b4be..1c4f5fa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7794,6 +7794,7 @@ NILFS2 FILESYSTEM M

[PATCH 02/11] nilfs2: remove space before comma

Fix checkpatch.pl error "ERROR: space prohibited before that ',' (ctx:WxW)" at nilfs_sufile_set_suinfo(). This also fixes checkpatch.pl warning "WARNING: Prefer 'unsigned int' to bare use of 'unsigned'" at nilfs_sufile_set_suinfo() and nilfs_su

[PATCH 08/11] nilfs2: move cleanup code of metadata file from inode routines

Refactor nilfs_clear_inode() and nilfs_i_callback() so that cleanup code or resource deallocation related to metadata file will be moved out to mdt.c. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/inode.c | 5 ++--- fs/nilfs2/mdt.c | 25 + fs/nilfs2/mdt.h | 8

[PATCH 01/11] nilfs2: fix white space issue in nilfs_mount()

#1317: FILE: super.c:1317: + ^I^Is_new = true;$ Signed-off-by: Ryusuke Konishi --- fs/nilfs2/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 7f5d3d9..e05d184 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c @@ -1316,7

[PATCH 00/11] nilfs2 updates

Hi Andrew, Please queue the following changes for the next merge window: Ryusuke Konishi (11): nilfs2: fix white space issue in nilfs_mount() nilfs2: remove space before comma nilfs2: remove FSF mailing address from GPL notices nilfs2: clean up old e-mail addresses

[PATCH 04/11] nilfs2: clean up old e-mail addresses

E-mail addresses of osrg.net domain are no longer available. This removes them from authorship notices and prevents reporters from being confused. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.c | 5 ++--- fs/nilfs2/alloc.h | 5 ++--- fs/nilfs2/bmap.c | 2 +- fs

[PATCH 09/11] nilfs2: replace __attribute__((packed)) with __packed

This fixes the following checkpatch.pl warning: WARNING: __packed is preferred over __attribute__((packed)) #23: FILE: export.h:23: +} __attribute__ ((packed)); Signed-off-by: Ryusuke Konishi --- fs/nilfs2/export.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs

[PATCH 07/11] nilfs2: get rid of nilfs_mdt_mark_block_dirty()

nilfs_mdt_mark_block_dirty() can be replaced with primary functions like nilfs_mdt_get_block() and mark_buffer_dirty(), and it's used only by nilfs_ioctl_mark_blocks_dirty(). This gets rid of the function to simplify the interface of metadata file. Signed-off-by: Ryusuke Konishi --- fs/n

[PATCH 10/11] nilfs2: add missing line spacing

Clean up checkpatch.pl warnings "WARNING: Missing a blank line after declarations" from nilfs2. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/cpfile.c| 2 ++ fs/nilfs2/dir.c | 2 ++ fs/nilfs2/ifile.h | 1 + fs/nilfs2/inode.c | 1 + fs/nilfs2/namei.c | 1 +

[PATCH 06/11] nilfs2: clarify permission to replicate the design

To respond to a certain developer's request, this explicitly state that developers can reimplement the nilfs2 design for other operating systems to share data stored in that format. Signed-off-by: Ryusuke Konishi --- Documentation/filesystems/nilfs2.txt | 5 + 1 file changed, 5 inser

[PATCH 03/11] nilfs2: remove FSF mailing address from GPL notices

This removes the extra paragraph which mentions FSF address in GPL notices from source code of nilfs2 and avoids the checkpatch.pl error related to it. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/alloc.c | 4 fs/nilfs2/alloc.h | 4 fs/nilfs2/bmap.c | 4

[PATCH 11/11] nilfs2: clean trailing semicolons in macros

Remove trailing semicolons from macros, as suggested by checkpatch.pl. Signed-off-by: Ryusuke Konishi --- fs/nilfs2/sysfs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nilfs2/sysfs.h b/fs/nilfs2/sysfs.h index 677e3a1..648cedf 100644 --- a/fs/nilfs2/sysfs.h +++ b

[PATCH 0/1] nilfs2: constify nilfs_sc_operations structures

Hi Andrew, please queue the following change for the next merge window. Thanks, Ryusuke Konishi -- Julia Lawall (1): nilfs2: constify nilfs_sc_operations structures fs/nilfs2/segment.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[PATCH 1/1] nilfs2: constify nilfs_sc_operations structures

From: Julia Lawall The nilfs_sc_operations structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Ryusuke Konishi --- fs/nilfs2/segment.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [dm-devel] [PATCH 04/42] fs: have submit_bh users pass in op and flags separately

Christie > Reviewed-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke > --- Looks good with regard to nilfs2. Acked-by: Ryusuke Konishi > drivers/md/bitmap.c | 4 ++-- > fs/btrfs/check-integrity.c | 24 ++-- > fs/btrfs/check-integrity.h |

Re: [PATCH 16/42] nilfs: set bi_op to REQ_OP

s Reinecke > --- > fs/nilfs2/segbuf.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) Looks good to me. Acked-by: Ryusuke Konishi Thanks, Ryuske Konishi > > diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c > index 7666f1d..7b13e14 100644 >

Re: [PATCH] nilfs2: constify nilfs_sc_operations structures

On Sat, 9 Apr 2016 10:28:23 +0200, Julia Lawall wrote: > The nilfs_sc_operations structures are never modified, so declare them > as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Applied, thanks. Ryusuke Konishi > --- >

Re: [PATCH v2] vfs: remove unused wrapper block_page_mkwrite()

> block_page_mkwrite() and update the comment above block_page_mkwrite(). > > Signed-off-by: Ross Zwisler > Reviewed-by: Jan Kara > Cc: Jan Kara > Cc: Christoph Hellwig > Cc: Al Viro Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi > --- > fs/buffer.c

[PATCH 1/2] nilfs2: fix gcc unused-but-set-variable warnings

fs2/alloc.o fs/nilfs2/alloc.c: In function 'nilfs_palloc_prepare_alloc_entry': fs/nilfs2/alloc.c:478:38: warning: variable 'groups_per_desc_block' set but not used [-Wunused-but-set-variable] unsigned long n, entries_per_group, groups_per_desc_block;

[PATCH 2/2] nilfs2: fix gcc uninitialized-variable warnings in powerpc build

may be used uninitialized in this function [-Wuninitialized] fs/nilfs2/btree.c:1859:22: note: 'bh' was declared here This cleans out these warnings by forcing the variables to be initialized. Signed-off-by: Ryusuke Konishi Reported-by: Geert Uytterhoeven --- fs/nilfs2/btree.c

  1   2   3   >