Re: [PATCH 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-08-28 Thread Sören Brinkmann
On Mon, 2017-08-28 at 14:22:03 -0400, Nicolas Dufresne wrote: > Le lundi 28 août 2017 à 08:15 -0700, Soren Brinkmann a écrit : [...] > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 94153895fcd4..4e8b64575b2a 100644 > > --- a/drivers/media/i2c/Kconfig > > +++ b/drive

Re: [RFC PATCH 1/4] serial: uartps: Remove console_initcall from the driver

2017-07-21 Thread Sören Brinkmann
On Fri, 2017-07-21 at 11:32:24 +0200, Michal Simek wrote: > register_console() is called from > uart_add_one_port()->uart_configure_port() > that's why register_console() is called twice. > > This patch remove console_initcall to call register_console() only from > one location. > > Also based on

Re: [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe()

2017-06-30 Thread Sören Brinkmann
On Fri, 2017-06-30 at 02:42:47 -0500, Gustavo A. R. Silva wrote: > Print error message and propagate the return value of > platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Sören Brinkmann Sören

Re: [PATCH] usb: gadget: udc-xilinx: remove useless variable assignment in xudc_read_fifo()

2017-06-27 Thread Sören Brinkmann
ustavo A. R. Silva Reviewed-by: Sören Brinkmann Sören

Re: [PATCH] gpio: zynq: remove unneeded (void *) casts in of_match_table

2017-05-12 Thread Sören Brinkmann
On Sat, 2017-05-13 at 01:18:45 +0900, Masahiro Yamada wrote: > of_device_id::data is an opaque pointer. No explicit cast is needed. > > Signed-off-by: Masahiro Yamada Acked-by: Sören Brinkmann Sören

Re: [PATCH] usb: gadget: udc-xilinx: clean up a variable name

2017-04-27 Thread Sören Brinkmann
On Thu, 2017-04-27 at 12:11:18 +0300, Dan Carpenter wrote: > "ep->udc->lock" and "udc->lock" are the same thing. It confuses Smatch > if we don't use the same name consistently. > > Signed-off-by: Dan Carpenter Reviewed-by: Sören Brinkmann Sören

Re: [PATCH v2] ARM64: zynqmp: Fix i2c node's compatible string

2016-12-22 Thread Sören Brinkmann
Signed-off-by: Moritz Fischer > Cc: Michal Simek > Cc: Sören Brinkmann > Cc: Rob Herring Acked-by: Sören Brinkmann Sören

Re: [PATCH 3/4] fpga mgr: zynq: Add support for encrypted bitstreams

2016-11-08 Thread Sören Brinkmann
p; HMAC units > are disabled by the boot ROM, therefore the capability > is not available. > > Signed-off-by: Moritz Fischer > Cc: Alan Tull > Cc: Michal Simek > Cc: Sören Brinkmann > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.o

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

2016-10-25 Thread Sören Brinkmann
On Tue, 2016-10-25 at 12:49:33 +0200, Thomas Gleixner wrote: > On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote: > > On 10/21/2016 10:48 AM, Marc Zyngier wrote: > > > Shouldn't you return an error if irq is zero? > > > > > > > I'll add the following for the error case > > > > pr_err("%s:

Re: [PATCH] Adding Support for Coresight Components on Zynq 7000.

2016-10-03 Thread Sören Brinkmann
Hi Muhammad, On Mon, 2016-10-03 at 14:56:16 +0200, Muhammad Abdul WAHAB wrote: > Hi Sören, > > > I tried to refresh my Zynq knowledge a bit. The clkc provides the > > dbg_trc clock, and that is the clock you need (not fclk). I couldn't > > find it in the binding (I guess I messed that up), but ap

Re: [PATCH] Adding Support for Coresight Components on Zynq 7000.

2016-09-30 Thread Sören Brinkmann
Hi Muhammad, On Fri, 2016-09-30 at 09:39:51 +0200, Muhammad Abdul WAHAB wrote: > Hi Sören, > > Thank you for your remarks. I corrected a few things as you suggested. > [...] > >> +tpiu@F8803000 { > >>> > >>> +compatible = "arm,coresight-tpiu", "arm,primecell"; > >>> +

Re: [PATCH 2/2] mmc: sdhci-of-arasan: mark sdhci_arasan_reset() static

2016-09-29 Thread Sören Brinkmann
On Fri, 2016-09-30 at 09:37:39 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/mmc/host/sdhci-of-arasan.c:253:6: warning: no previous prototype for > 'sdhci_arasan_reset' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is

Re: [PATCH] Adding Support for Coresight Components on Zynq 7000.

2016-09-29 Thread Sören Brinkmann
Hi Muhammad, On Thu, 2016-09-29 at 12:26:13 +0200, Muhammad Abdul WAHAB wrote: > The Coresight components are present on the Zynq SoC but the corresponding > device tree entries are missing. This patch adds device tree entries for > coresight components while explaining how it was done in order to

Re: [PATCH v2] arm: dts: zynq: Add MicroZed board support

2016-09-22 Thread Sören Brinkmann
On Thu, 2016-09-22 at 18:51:29 +0530, Jagan Teki wrote: > From: Jagan Teki > > Added basic dts support for MicroZed board. > > - UART > - SDHCI > - Ethernet > > Cc: Soren Brinkmann > Cc: Michal Simek > Signed-off-by: Jagan Teki > --- > Changes for v2: > - Add SDHCI > - Add Ethern

Re: [PATCH] gpio: Added zynq specific check for special pins on bank zero

2016-09-20 Thread Sören Brinkmann
@@ > /* GPIO upper 16 bit mask */ > #define ZYNQ_GPIO_UPPER_MASK 0x > > +/* For GPIO quirks */ > +#define ZYNQ_GPIOBIT(0) > +#define ZYNQMP_GPIO BIT(1) I'd make sure all quirks are easily identifiable and call them something like 'ZYNQ_GPIO_QUIRK_FOO' Apart from that: Acked-by: Sören Brinkmann Sören

Re: [PATCH v5] Axi-usb: Add support for 64-bit addressing.

2016-09-01 Thread Sören Brinkmann
On Thu, 2016-09-01 at 14:22:56 +0530, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA addressing. > > Signed-off-by: Nava kishore Manne > Acked-by: Rob Herring > --- > Changes for v5: > -None. > > Changes for v4: > -Used boolen pro

Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

2016-08-25 Thread Sören Brinkmann
On Thu, 2016-08-25 at 17:23:47 +0200, Lars-Peter Clausen wrote: > On 08/25/2016 05:10 PM, Sören Brinkmann wrote: > > On Wed, 2016-08-24 at 18:23:03 -0500, Zach Brown wrote: > >> The sdhci controller on xilinx zynq devices will not function unless > >> the cd bit is prov

Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

2016-08-25 Thread Sören Brinkmann
On Wed, 2016-08-24 at 18:23:03 -0500, Zach Brown wrote: > The sdhci controller on xilinx zynq devices will not function unless > the cd bit is provided. http://www.xilinx.com/support/answers/61064.html > In cases where it is impossible to provide the cd bit in hardware, > setting the controller to

Re: SOC-specific action for irq_set_wake

2016-07-20 Thread Sören Brinkmann
On Wed, 2016-07-20 at 14:36:12 +0100, Marc Zyngier wrote: > Hi Sören, > > On 20/07/16 14:16, Sören Brinkmann wrote: > > Hi Marc, > > >>>>> Does anybody have similar problems and probably already solved it? > >>>>> Any other suggestions for a

Re: SOC-specific action for irq_set_wake

2016-07-20 Thread Sören Brinkmann
Hi Thomas, On Wed, 2016-07-20 at 08:28:35 +0200, Thomas Gleixner wrote: > On Tue, 19 Jul 2016, Sören Brinkmann wrote: > > we are working on the PM solution for Zynq MPSOC and ran into some > > problem when setting the wake source. > > > > The situation is that when the

Re: SOC-specific action for irq_set_wake

2016-07-20 Thread Sören Brinkmann
Hi Marc, On Wed, 2016-07-20 at 09:17:16 +0100, Marc Zyngier wrote: > On 20/07/16 00:34, Sören Brinkmann wrote: > > Hi Andy, > > > > On Tue, 2016-07-19 at 17:47:13 -0500, Andy Gross wrote: > >> On Tue, Jul 19, 2016 at 11:18:04AM -0700, Sören Brinkmann wrote: > &

Re: SOC-specific action for irq_set_wake

2016-07-19 Thread Sören Brinkmann
Hi Andy, On Tue, 2016-07-19 at 17:47:13 -0500, Andy Gross wrote: > On Tue, Jul 19, 2016 at 11:18:04AM -0700, Sören Brinkmann wrote: > > Hi, > > > > we are working on the PM solution for Zynq MPSOC and ran into some > > problem when setting the wake source. > > &

SOC-specific action for irq_set_wake

2016-07-19 Thread Sören Brinkmann
Hi, we are working on the PM solution for Zynq MPSOC and ran into some problem when setting the wake source. The situation is that when the A53 is in suspend, the GIC(v2) may be powered down. In that state a companion core is handling wake events/IRQs, but we expect the OS/Linux to notify the com

Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property

2016-07-18 Thread Sören Brinkmann
On Sun, 2016-07-17 at 09:11:10 -0700, Sören Brinkmann wrote: > On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > > The "clock-output-names" property is useful for generic clock > > providers such as fixed-clock, fixed-factor-clock, etc. > > > >

Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property

2016-07-17 Thread Sören Brinkmann
On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > The "clock-output-names" property is useful for generic clock > providers such as fixed-clock, fixed-factor-clock, etc. > > On the other hand, it should not be used for really SoC-specific > clock providers like this one. As you see i

Re: [PATCH] PCI: xilinx: Fix return value in case of error

2016-07-14 Thread Sören Brinkmann
e in case of error is always 0, which means 'success'. > Change it to return -ENODEV instead. > > Signed-off-by: Christophe JAILLET Acked-by: Sören Brinkmann Sören

Re: [PATCH] clocksource: cadence_ttc: fix a return value in case of error

2016-07-06 Thread Sören Brinkmann
On Wed, 2016-07-06 at 07:35:23 +0200, Christophe JAILLET wrote: > IS_ERR and PTR_ERR should use the same variable, clk_ce in this case. > > Fixes: 4de1eb07c47f (Convert init function to return error) > > Signed-off-by: Christophe JAILLET Acked-by: Sören Brinkmann Sören

Re: [PATCH V2 07/63] clocksource/drivers/cadence_ttc: Convert init function to return error

2016-06-16 Thread Sören Brinkmann
s this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano Acked-by: Sören Brinkmann Sören

Re: [PATCH 7/9] pinctrl: zynq: make it explicitly non-modular

2016-06-06 Thread Sören Brinkmann
hanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij > Cc: Michal Simek

Re: [PATCH 7/9] clocksource/drivers/cadence_ttc: Convert init function to return error

2016-06-01 Thread Sören Brinkmann
Hi Daniel, On Wed, 2016-06-01 at 10:34:50 +0200, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and >make the system boot up correctly > > or > > - print an error a

Re: [PATCH 2/5] dmaengine: vdma: Use dma_pool_zalloc

2016-04-29 Thread Sören Brinkmann
; > @@ > > d = > -dma_pool_alloc > +dma_pool_zalloc > (...); > if (!d) S > - memset(d, 0, sizeof(*d)); > // > > Signed-off-by: Julia Lawall Acked-by: Sören Brinkmann Sören

Re: [PATCH v2 6/6] mmc: sdhci-of-arasan: overwrite enhanced strobe callback

2016-04-29 Thread Sören Brinkmann
st as a note: This register doesn't seem to exist in the IP version Zynq is using. So, as long as we exclude that version from accessing it, things should be fine (IIUC, that is the case). Acked-by: Sören Brinkmann Sören

Re: [PATCH v3 3/3] dmaengine: vdma: Add clock support

2016-04-21 Thread Sören Brinkmann
On Thu, 2016-04-21 at 09:32:44 -0700, Appana Durga Kedareswara Rao wrote: > Hi Soren, > > > -Original Message- > > From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] > > Sent: Thursday, April 21, 2016 9:52 PM > > To: Appana Durga Kedareswara Rao >

Re: [PATCH v3 3/3] dmaengine: vdma: Add clock support

2016-04-21 Thread Sören Brinkmann
On Thu, 2016-04-21 at 16:08:38 +0530, Kedareswara rao Appana wrote: > Added basic clock support for axi dma's. > The clocks are requested at probe and released at remove. > > Reviewed-by: Shubhrajyoti Datta > Signed-off-by: Kedareswara rao Appana > --- > Changes for v3: > ---> Added clock suppor

Re: [PATCH v2 2/2] dmaengine: vdma: Add clock support

2016-04-20 Thread Sören Brinkmann
On Wed, 2016-04-20 at 07:55:27 -0700, Appana Durga Kedareswara Rao wrote: > Hi Soren, > > > -Original Message- > > From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] > > Sent: Wednesday, April 20, 2016 8:06 PM > > To: Appana Durga Kedareswara R

Re: [PATCH v2 2/2] dmaengine: vdma: Add clock support

2016-04-20 Thread Sören Brinkmann
On Wed, 2016-04-20 at 17:13:19 +0530, Kedareswara rao Appana wrote: > Added basic clock support. The clocks are requested at probe > and released at remove. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v2: > --> None. > > drivers/dma/xilinx/xilinx_vdma.c | 56 > +++

Re: [PATCH v2 1/2] Documentation: DT: vdma: Add clock support for vdma

2016-04-20 Thread Sören Brinkmann
> +- clock-names: List of input clocks "s_axi_lite_aclk", "m_axi_mm2s_aclk" > +"m_axi_s2mm_aclk", "m_axis_mm2s_aclk", "s_axis_s2mm_aclk" > +(list of input cloks may vary based on the ip configuration. s/cloks/clocks Acked-by: Sören Brinkmann Sören

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

2016-04-06 Thread Sören Brinkmann
On Wed, 2016-04-06 at 22:13:59 +, Koul, Vinod wrote: > On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > > +++ > > > > > b/Documentation/device

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

2016-04-06 Thread Sören Brinkmann
On Wed, 2016-04-06 at 21:45:31 +0530, Kedareswara rao Appana wrote: > This patch renames the vdma-mm2s-channel/vdma-s2mm-channel > property with dma-mm2s-channel/dma-s2mm-channel to sync with > the driver. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v3: > ---> New patch. > > D

Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for AXI CDMA

2016-03-27 Thread Sören Brinkmann
On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote: > This patch updates the device-tree binding doc for > adding support for AXI CDMA. > > Signed-off-by: Kedareswara rao Appana > --- > ---> Modified commit message as suggested by Vinod. > ---> Moved the patch to forward in the se

Re: [PATCH v2 3/6] Documentation: DT: vdma: update binding doc for AXI DMA

2016-03-27 Thread Sören Brinkmann
On Sun, 2016-03-27 at 23:36:05 +0530, Kedareswara rao Appana wrote: > This patch updates the device-tree binding doc for > adding support for AXI DMA. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v2: > ---> Modified commit message as suggested by Vinod. > ---> Moved the patch to

Re: [PATCH 38/41] clk: si5{14,351,70}: Remove CLK_IS_ROOT

2016-03-01 Thread Sören Brinkmann
On Tue, 2016-03-01 at 11:00:23 -0800, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Sebastian Hesselbarth > Cc: Guenter Roeck > Cc: Sören Brinkmann > Cc: Mike Looijmans > Signed-off-by: Stephen Boyd Reviewed-by: Sören Brink

Re: [PATCH 24/41] clk: zynq: Remove CLK_IS_ROOT

2016-03-01 Thread Sören Brinkmann
On Tue, 2016-03-01 at 11:00:09 -0800, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Sören Brinkmann > Signed-off-by: Stephen Boyd Reviewed-by: Sören Brinkmann Thanks, Sören

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

2016-02-26 Thread Sören Brinkmann
On Fri, 2016-02-26 at 15:03:19 +0200, Grygorii Strashko wrote: > On 02/05/2016 01:39 AM, Sören Brinkmann wrote: > > On Thu, 2016-02-04 at 15:14:47 -0800, Moritz Fischer wrote: > >> Hi Soeren, > >> > >> On Thu, Feb 4, 2016 at 2:41 PM, Sören Brinkmann > >>

Re: [PATCH 50/50] pinctrl: zynq: Use devm_pinctrl_register() for pinctrl registration

2016-02-25 Thread Sören Brinkmann
On Wed, 2016-02-24 at 18:46:15 +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and > remove the need of .remove callback. > > Signed-off-by: Laxman Dewangan > Cc: Michal Simek > Cc: Sören Brinkmann > Cc: linux-g...@vger.kernel.or

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

2016-02-04 Thread Sören Brinkmann
On Thu, 2016-02-04 at 15:14:47 -0800, Moritz Fischer wrote: > Hi Soeren, > > On Thu, Feb 4, 2016 at 2:41 PM, Sören Brinkmann > wrote: > > > But with this change the 'if !CPU_FREQ' becomes obsolete. > I'm confused, could you explain that statement? You d

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

2016-02-04 Thread Sören Brinkmann
> > Cc: Florian Fainelli > Cc: Russell King > Cc: Wei Xu > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Srinivas Kandagatla > Cc: Maxime Coquelin > Cc: Masahiro Yamada > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Jun Nie > Cc: Michal Simek > Cc: &quo

Re: [PATCH LINUX 0/6] Second part of xuartps fixes

2016-02-01 Thread Sören Brinkmann
nds on the patches mentioned above. It > includes several minor improvements and refactoring and the refactoring > of the IRQ management, which prevents lock ups that could happen when > RX-related IRQs fired while the receiver was disabled. > > Thanks, > Sören > > S

Re: [PATCH v4 05/13] mmc: sdhci-of-arasan: fix clk issue in sdhci_arasan_remove()

2016-01-26 Thread Sören Brinkmann
. > > Signed-off-by: Jisheng Zhang Acked-by: Sören Brinkmann Sören

Re: [RFC LINUX PATCH] dt: xilinx: xadc: provision to control clock frequency

2015-12-23 Thread Sören Brinkmann
On Wed, 2015-12-23 at 03:58PM +0530, Ranjit Waghmode wrote: > This patch adds parameter to the xilinx-xadc node for controlling > clock frequency. > > Following are the possible options for user to control the frequency: > * 00 : 1/2 of clock frequency > * 01 : 1/4 of clock frequency >

Re: [PATCH LINUX v4 06/13] tty: xuartps: Move request_irq to after setting up the HW

2015-12-17 Thread Sören Brinkmann
On Wed, 2015-12-16 at 06:37AM -0800, Peter Hurley wrote: > On 12/16/2015 01:03 AM, Sören Brinkmann wrote: > > On Tue, 2015-12-15 at 03:26PM -0800, Peter Hurley wrote: > >> On 12/15/2015 07:41 AM, Sören Brinkmann wrote: > >>> On Thu, 2015-12-10 at 01:41PM -0800, Peter

Re: [PATCH LINUX v4 06/13] tty: xuartps: Move request_irq to after setting up the HW

2015-12-16 Thread Sören Brinkmann
On Tue, 2015-12-15 at 03:26PM -0800, Peter Hurley wrote: > On 12/15/2015 07:41 AM, Sören Brinkmann wrote: > > On Thu, 2015-12-10 at 01:41PM -0800, Peter Hurley wrote: > >> On 12/05/2015 08:39 PM, Soren Brinkmann wrote: > >>> Request_irq() should be _after_

Re: [PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property

2015-12-16 Thread Sören Brinkmann
On Tue, 2015-12-15 at 04:01PM +0100, Michal Simek wrote: > Hi, > > On 15.12.2015 10:14, Sören Brinkmann wrote: > > On Mon, 2015-12-14 at 05:01PM +, Marc Zyngier wrote: > >> Mark, > >> > >> On 14/12/15 16:46, Mark Rutland wrote: > >>> On

Re: [PATCH LINUX v4 06/13] tty: xuartps: Move request_irq to after setting up the HW

2015-12-15 Thread Sören Brinkmann
On Thu, 2015-12-10 at 01:41PM -0800, Peter Hurley wrote: > On 12/05/2015 08:39 PM, Soren Brinkmann wrote: > > Request_irq() should be _after_ h/w programming, otherwise an > > interrupt could be triggered and in-progress before the h/w has been > > setup. > > Slight misunderstanding. My fault; I s

Re: [PATCH] ARM64: ZynqMP: DT: Fix GIC's 'reg' property

2015-12-15 Thread Sören Brinkmann
On Mon, 2015-12-14 at 05:01PM +, Marc Zyngier wrote: > Mark, > > On 14/12/15 16:46, Mark Rutland wrote: > > On Mon, Dec 14, 2015 at 08:31:40AM -0800, Soren Brinkmann wrote: > >> Signed-off-by: Soren Brinkmann > >> --- > >> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 6 +++--- > >> 1 file change

Re: [PATH TRIVIAL] Documentation: cpu-hotplug: Fix sysfs mount instructions

2015-12-10 Thread Sören Brinkmann
On Thu, 2015-12-10 at 11:36AM -0700, Jonathan Corbet wrote: > On Mon, 7 Dec 2015 23:26:58 -0800 > Soren Brinkmann wrote: > > > The instructions for mounting sysfs are inconsistent in instructing to > > create the directory '/sysfs' but then mounting sysfs to /sys. > > Also, indentation is slightl

Re: [PATCH LINUX v3 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled

2015-12-05 Thread Sören Brinkmann
On Sat, 2015-12-05 at 12:43PM -0500, Peter Hurley wrote: > On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > > Ignore RX-related interrupts if RX is not enabled. > > This doesn't look like a safe approach; fast-forward a couple of years and > some is trying to add some feature but can't figure out

Re: [PATCH LINUX v3 00/10] tty: xuartps: Fix lock ups

2015-12-05 Thread Sören Brinkmann
On Sat, 2015-12-05 at 12:49PM -0500, Peter Hurley wrote: > On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > > Hi, > > > > here is v3 of this series. It's largely the same as before, but I > > adjusted 'tty: xuartps: Don't consider circular buffer when enabling > > transmitter' according to Peter's

Re: [PATCH LINUX v3 08/10] tty: xuartps: Move RX path into helper function

2015-12-05 Thread Sören Brinkmann
On Sat, 2015-12-05 at 12:40PM -0500, Peter Hurley wrote: > On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > > Move RX-related IRQ handling into a helper function. > Fixes a problem where every char received after a parity or frame error > in the current isr will also be tagged as a parity or frame

Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function

2015-12-05 Thread Sören Brinkmann
On Sat, 2015-12-05 at 12:21PM -0500, Peter Hurley wrote: > On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > > The startup function is supposed to initialize the UART for receiving. > > Hence, don't enable the TX part. Also, protect HW accesses with the port > > lock. > > Reviewed-by: Peter Hurley

Re: [PATCH] staging: clocking-wizard: add blank line after struct declaration.

2015-12-01 Thread Sören Brinkmann
On Tue, 2015-12-01 at 01:56PM +0100, Christian Colic wrote: > Add blank line after struct declaration to fix checkpatch check. > > Signed-off-by: Christian Colic Reviewed-by: Sören Brinkmann Thanks, Sören -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v2] i2c: cadence: Move to sensible power management

2015-11-23 Thread Sören Brinkmann
On Sat, 2015-11-21 at 07:00PM +0530, Shubhrajyoti Datta wrote: > On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta > wrote: > > On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann > > wrote: > >> Hi Shubhrajyoti, > >> > >> > >> On Wed,

Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in start_tx

2015-11-20 Thread Sören Brinkmann
On Fri, 2015-11-20 at 12:16PM -0500, Peter Hurley wrote: > On 11/20/2015 11:58 AM, Sören Brinkmann wrote: > > On Fri, 2015-11-20 at 11:30AM -0500, Peter Hurley wrote: > >> On 11/20/2015 10:28 AM, Sören Brinkmann wrote: > >>> On Fri, 2015-11-20 at 07:13AM -0500, Peter

Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in start_tx

2015-11-20 Thread Sören Brinkmann
On Fri, 2015-11-20 at 07:13AM -0500, Peter Hurley wrote: > > > On 11/19/2015 03:02 PM, Soren Brinkmann wrote: > > start_tx must start transmitting characters. Regardless of the state of > > the circular buffer, always enable the transmitter hardware. > > Why? > > Does cdns_uart_stop_tx() actual

Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in start_tx

2015-11-20 Thread Sören Brinkmann
Hi Peter, On Fri, 2015-11-20 at 11:30AM -0500, Peter Hurley wrote: > Hi Sören, > > On 11/20/2015 10:28 AM, Sören Brinkmann wrote: > > On Fri, 2015-11-20 at 07:13AM -0500, Peter Hurley wrote: > >> On 11/19/2015 03:02 PM, Soren Brinkmann wrote: > >>> start_t

Re: [PATH RESEND v2 03/10] tty: xuartps: Always enable transmitter in start_tx

2015-11-20 Thread Sören Brinkmann
Hi Peter, On Fri, 2015-11-20 at 07:13AM -0500, Peter Hurley wrote: > > > On 11/19/2015 03:02 PM, Soren Brinkmann wrote: > > start_tx must start transmitting characters. Regardless of the state of > > the circular buffer, always enable the transmitter hardware. > > Why? > > Does cdns_uart_stop_

Re: [PATCH v2 1/3] serial: xuartps: Spliting the ISR into smaller routines.

2015-11-20 Thread Sören Brinkmann
On Fri, 2015-11-20 at 07:04PM +0530, Nava kishore Manne wrote: > Breaking the single big ISR that has both Rx and Tx > in a single function into smaller ones > > Signed-off-by: Nava kishore Manne > --- > Changes for v2: > --Splits up the ISR without any functional changes as suggested >

Re: [RFC PATCH 1/2] genirq: Add runtime resume/suspend support for IRQ chips

2015-11-12 Thread Sören Brinkmann
Hi Jon, On Tue, 2015-11-10 at 03:58PM +, Jon Hunter wrote: > Hi Thomas, > > On 10/11/15 15:26, Thomas Gleixner wrote: [...] > > Can you folks please agree on something which is correct and complete? > > Soren I am happy to defer to your patch and drop this. My only comment > would be what ab

Re: [PATCH] ARM: dt: zynq: Add labels to cpu nodes to allow overriding OPPs.

2015-11-09 Thread Sören Brinkmann
On Mon, 2015-11-09 at 10:51AM -0800, Moritz Fischer wrote: > By adding labels to the cpu nodes in the dtsi, a dts that > includes it can change the OPPs by referencing the cpu0 > through the label. > > Signed-off-by: Moritz Fischer Reviewed-by: Sören Brinkmann Sören --

Re: [PATCH] reset: check return value of reset_controller_register()

2015-11-04 Thread Sören Brinkmann
On Thu, 2015-11-05 at 02:54PM +0900, Masahiro Yamada wrote: > Currently, reset_controller_register() always return 0, but it would > be better to check its return code. > > Signed-off-by: Masahiro Yamada Acked-by: Sören Brinkmann Sören -- To unsubscribe from this list: s

Re: [PATCH] rtc: Group Kconfig entries by vendor

2015-11-04 Thread Sören Brinkmann
Hi Alexandre, On Wed, 2015-11-04 at 10:25AM +0100, Alexandre Belloni wrote: > On 03/11/2015 at 23:13:46 -0800, Soren Brinkmann wrote : > > The RTC entries are mostly grouped by vendor. Move the few outliers in > > place. > > Also, change the one occurrence of 'nxp' to 'NXP' to make all NXP > > ent

Re: [PATCH] pinctrl: zynq: fix UTF-8 errors

2015-10-30 Thread Sören Brinkmann
On Fri, 2015-10-30 at 10:03AM -0700, Sören Brinkmann wrote: > Hi Linux, Linus, of course... > > On Fri, 2015-10-30 at 03:06PM +0100, Linus Walleij wrote: > > Fix up Sören's name in the Zynq driver. I caused this. I fix it. > > > > Cc: Sören Brinkmann > >

Re: [PATCH] pinctrl: zynq: fix UTF-8 errors

2015-10-30 Thread Sören Brinkmann
Hi Linux, On Fri, 2015-10-30 at 03:06PM +0100, Linus Walleij wrote: > Fix up Sören's name in the Zynq driver. I caused this. I fix it. > > Cc: Sören Brinkmann > Signed-off-by: Linus Walleij Acked-by: Sören Brinkmann Thank you! Sören -- To unsubscribe from this li

Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources

2015-10-29 Thread Sören Brinkmann
On Tue, 2015-10-27 at 05:37PM +0100, Lars-Peter Clausen wrote: > On 10/27/2015 04:53 PM, Linus Walleij wrote: > > On Fri, Oct 23, 2015 at 3:36 PM, Soren Brinkmann > > wrote: > > > >> The driver uses runtime PM to leverage low power techniques. For > >> use-cases using GPIO as interrupt the device

Re: [PATCH v2] i2c: cadence: Move to sensible power management

2015-10-28 Thread Sören Brinkmann
Hi Shubhrajyoti, On Wed, 2015-10-28 at 12:56PM +0530, Shubhrajyoti Datta wrote: > Currently the clocks are enabled at probe and disabled at remove. > Which keeps the clocks enabled even if no transaction is going on. > This patch enables the clocks at the start of transfer and disables > after it

Re: [PATCH] pinctrl-zynq: Initialize early

2015-10-22 Thread Sören Brinkmann
On Fri, 2015-10-23 at 07:43AM +0200, Mike Looijmans wrote: > On 23-10-15 07:31, Mike Looijmans wrote: > >On 22-10-15 18:07, Sören Brinkmann wrote: > >>Hi Mike, > >> > >>On Thu, 2015-10-22 at 01:30PM +0200, Mike Looijmans wrote: > >>>Supplying

Re: [PATCH] pinctrl-zynq: Initialize early

2015-10-22 Thread Sören Brinkmann
On Fri, 2015-10-23 at 07:31AM +0200, Mike Looijmans wrote: > On 22-10-15 18:07, Sören Brinkmann wrote: > >Hi Mike, > > > >On Thu, 2015-10-22 at 01:30PM +0200, Mike Looijmans wrote: > >>Supplying pinmux configuration for e.g. gpio pins leads to deferred > >&

Re: [PATCH v6] can: xilinx: Convert to runtime_pm

2015-10-22 Thread Sören Brinkmann
Hi Kedar, On Thu, 2015-10-22 at 10:15AM +0530, Kedareswara rao Appana wrote: > Instead of enabling/disabling clocks at several locations in the driver, > Use the runtime_pm framework. This consolidates the actions for runtime PM > In the appropriate callbacks and makes the driver more readable and

Re: [PATCH 2/2] can: xilinx: fix bug in bus error handling

2015-10-22 Thread Sören Brinkmann
On Thu, 2015-10-22 at 10:16AM +0530, Kedareswara rao Appana wrote: > Simply resetting the peripheral on bus off condition is not enough, > Because we also need to re-initialize the whole device. > This patch fixes this issue. > > Signed-off-by: Kedareswara rao Appana > --- > drivers/net/can/xili

Re: [PATCH] pinctrl-zynq: Initialize early

2015-10-22 Thread Sören Brinkmann
io: could not find pctldev for node /amba/slcr@f800/pinctrl@700/gpio0-default, deferring probe root@zynq:~# If you have a case this patch improves things though, feel free to add my Tested-by: Sören Brinkmann Thanks, Sören -- To unsubscribe from this list: send the line

Re: [PATCHv2 1/3] ARM: dt: fpga: Added binding docs for Xilinx Zynq FPGA manager.

2015-10-18 Thread Sören Brinkmann
for memory mapped io > > +- interrupts: interrupt for the FPGA manager device If we are that picky, this is technically an interrupt specifier :) > > +- clocks: phandle for clocks required operation > > Technically a "clock specifier", but oth

Re: [PATCH 2/5] gpio/xilinx: enable for MIPS

2015-10-14 Thread Sören Brinkmann
On Wed, 2015-10-14 at 07:24PM +0200, Lars-Peter Clausen wrote: > On 10/14/2015 06:54 PM, Sören Brinkmann wrote: > > On Wed, 2015-10-14 at 05:57PM +0200, Lars-Peter Clausen wrote: > >> On 10/14/2015 05:18 PM, Sören Brinkmann wrote: > >>> On Wed, 2015-10-14 at 0

Re: [PATCH 2/5] gpio/xilinx: enable for MIPS

2015-10-14 Thread Sören Brinkmann
On Wed, 2015-10-14 at 05:57PM +0200, Lars-Peter Clausen wrote: > On 10/14/2015 05:18 PM, Sören Brinkmann wrote: > > On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrote: > >> MIPSfpga uses the axi gpio controller. Enable the driver for MIPS. > >>

Re: [PATCH 2/5] gpio/xilinx: enable for MIPS

2015-10-14 Thread Sören Brinkmann
On Wed, 2015-10-14 at 01:51PM +0100, Zubair Lutfullah Kakakhel wrote: > MIPSfpga uses the axi gpio controller. Enable the driver for MIPS. > > Signed-off-by: Zubair Lutfullah Kakakhel > --- > drivers/gpio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/g

Re: [PATCH 1/3] doc: dt: fpga: Added Documentation for Xilinx Zynq FPGA manager.

2015-10-12 Thread Sören Brinkmann
On Fri, 2015-10-09 at 12:45AM +0200, Moritz Fischer wrote: > Signed-off-by: Moritz Fischer > --- > .../bindings/fpga/xilinx-zynq-fpga-mgr.txt | 26 > ++ > 1 file changed, 26 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/fpga/xilinx-zynq-fpga

Re: [PATCH 2/3] dts: Updated devicetree bindings for Zynq 7000 platform

2015-10-12 Thread Sören Brinkmann
On Fri, 2015-10-09 at 12:45AM +0200, Moritz Fischer wrote: > Added addtional bindings required for FPGA Manager operation > of the Xilinx Zynq Devc configuration interface. > > Signed-off-by: Moritz Fischer Reviewed-by: Sören Brinkmann Sören -- To unsubscribe from this li

Re: [PATCH v2 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

2015-09-25 Thread Sören Brinkmann
On Tue, 2015-09-15 at 09:07AM +0800, Shawn Lin wrote: > On 2015/9/14 23:07, Sören Brinkmann wrote: > >Hi Shawn, > > > >overall, it looks good to me. I have some questions though. > > > >On Mon, 2015-09-14 at 02:29PM +0800, Shawn Lin wrote: > > [...] >

Re: [PATCH] net: axinet: Use of_property_read_u32 instead of open-coding it

2015-09-22 Thread Sören Brinkmann
On Tue, 2015-09-22 at 01:45PM +0200, Tobias Klauser wrote: > Use of_property_read_u32 instead of of_get_property with return value > checks and endianness conversion. > > Signed-off-by: Tobias Klauser Reviewed-by: Sören Brinkmann Sören -- To unsubscribe from this list: s

Re: [PATCH] net: ll_temac: Use of_property_read_u32 instead of open-coding it

2015-09-22 Thread Sören Brinkmann
On Tue, 2015-09-22 at 01:41PM +0200, Tobias Klauser wrote: > Use of_property_read_u32 to read the "clock-frequency" property instead > of using of_get_property with return value checks. > > Signed-off-by: Tobias Klauser Reviewed-by: Sören Brinkmann Sören -- To

Re: [PATCH 0/7] Phy and mdiobus fixes

2015-09-18 Thread Sören Brinkmann
Hi Russell, On Fri, 2015-09-18 at 10:56AM +0100, Russell King - ARM Linux wrote: > Sorry guys, some of you will get the patches twice, as Sören's name > in the header caused vger to reject all the patches. That is the first time I hear about an issue like that. I've been receiving patches fine th

Re: [PATCH v2 2/2] Documentation: bindings: add description of phy for sdhci-of-arasan

2015-09-14 Thread Sören Brinkmann
On Mon, 2015-09-14 at 02:29PM +0800, Shawn Lin wrote: > This patch adds phys and phy-names for sdhci-of-arasan as required > properties for arasan,sdhci-5.1, and details the example as well. > > Signed-off-by: Shawn Lin Acked-by: Sören Brinkmann Sören -- To unsubscribe fr

Re: [PATCH v2 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

2015-09-14 Thread Sören Brinkmann
(sdhci_arasan->phy); > + goto clk_dis_ahb; > + } > + > + ret = phy_init(sdhci_arasan->phy); > + if (ret < 0) { > + dev_err(&pdev->dev, "phy_init err.\n"); > +

Re: [RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk

2015-09-14 Thread Sören Brinkmann
On Mon, 2015-09-14 at 09:58AM +0200, Boris Brezillon wrote: > Hi Harini, > > On Mon, 14 Sep 2015 09:39:05 +0530 > Harini Katakam wrote: > > > On Fri, Sep 11, 2015 at 10:22 PM, Sören Brinkmann > > wrote: > > > Hi Harini, > > > > > > On

Re: [PATCH 2/2] Documentation: bindings: add description of phy for sdhci-of-arasan

2015-09-13 Thread Sören Brinkmann
Hi Shawn, On Fri, 2015-09-11 at 04:55PM +0800, Shawn Lin wrote: > This patch adds phys and phy-names for sdhci-of-arasan as optional > properties, and details the example as well. > > Signed-off-by: Shawn Lin > --- > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 10 -- > 1

Re: [RFC PATCH 3/3] devicetree: macb: Add optional property tsu-clk

2015-09-11 Thread Sören Brinkmann
Hi Harini, On Fri, 2015-09-11 at 01:27PM +0530, Harini Katakam wrote: > Add TSU clock frequency to be used for 1588 support in macb driver. > > Signed-off-by: Harini Katakam > --- > Documentation/devicetree/bindings/net/macb.txt |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Do

Re: [RFCv3 4/4] ARM: zynq: Select ARCH_HAS_RESET_CONTROLLER

2015-08-04 Thread Sören Brinkmann
Hi Philipp, On Tue, 2015-08-04 at 10:38AM +0200, Philipp Zabel wrote: > Hi, > > Am Freitag, den 31.07.2015, 09:47 -0700 schrieb Sören Brinkmann: > > On Fri, 2015-07-31 at 10:09AM +0200, Michal Simek wrote: > [...] > > > Reviewed-by: Michal Simek > > Acked-by:

Re: [RFCv3 4/4] ARM: zynq: Select ARCH_HAS_RESET_CONTROLLER

2015-07-31 Thread Sören Brinkmann
I_V7 > > + select ARCH_HAS_RESET_CONTROLLER > > select ARCH_SUPPORTS_BIG_ENDIAN > > select ARM_AMBA > > select ARM_GIC > > > > Reviewed-by: Michal Simek Acked-by: Sören Brinkmann I personally, would prefer to decouple the logical outputs of the

Re: [RFCv2 1/3] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings.

2015-07-29 Thread Sören Brinkmann
On Tue, 2015-07-28 at 11:14PM -0700, Moritz Fischer wrote: > Hi Sören, > > On Tue, Jul 28, 2015 at 3:53 PM, Sören Brinkmann > wrote: > > On Mon, 2015-07-27 at 09:52PM -0700, Moritz Fischer wrote: > >> Hi Sören, > >> > >> thanks for your feedback. >

Re: [RFCv2 1/3] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings.

2015-07-28 Thread Sören Brinkmann
On Mon, 2015-07-27 at 09:52PM -0700, Moritz Fischer wrote: > Hi Sören, > > thanks for your feedback. > > On Mon, Jul 27, 2015 at 7:58 PM, Sören Brinkmann > wrote: > > Hi Moritz, > > > > On Fri, 2015-07-24 at 05:21PM -0700, Moritz Fischer wrote

Re: [RFCv2 3/3] reset: reset-zynq: Adding support for Xilinx Zynq reset controller.

2015-07-28 Thread Sören Brinkmann
On Tue, 2015-07-28 at 07:05AM -0700, Moritz Fischer wrote: > Philip, > > thanks for your review :) > > On Tue, Jul 28, 2015 at 1:38 AM, Philipp Zabel wrote: > > Hi Moritz, > > > > Am Freitag, den 24.07.2015, 17:21 -0700 schrieb Moritz Fischer: > >> This adds a reset controller driver to control

  1   2   3   4   5   6   >