Re: [PATCH] accessibility: speakup: refactor deprecated strncpy

just copy/pasted Kees' suggestion here [1] and rebased it against > 6.5-rc7. > > This patch needs testing as it refactors behavior in synth_direct_store. > > [1]: https://lore.kernel.org/all/202308251439.36BC33ADB2@keescook/ > > Signed-off-by: Justin Stitt Tested-by: Samue

[PATCH 0/2] speakup update

Samuel Thibault (2): speakup ABI: Advertise synth parameters for all synths speakup: Make dectlk flush timeout configurable Documentation/ABI/stable/sysfs-driver-speakup | 37 +++ .../accessibility/speakup/speakup_dectlk.c| 11 +- drivers/accessibility/speakup

[PATCH 1/2] speakup ABI: Advertise synth parameters for all synths

The parameters were advertised for the "soft" synth, but they are available for all synths. Signed-off-by: Samuel Thibault --- Documentation/ABI/stable/sysfs-driver-speakup | 30 +-- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/Documentation/ABI/st

[PATCH 2/2] speakup: Make dectlk flush timeout configurable

In case the serial port or cable got faulty, we may not be getting acknowledgements any more. The driver then currently waits for 4s to avoid jamming the device. This makes this delay configurable. Signed-off-by: Samuel Thibault --- Documentation/ABI/stable/sysfs-driver-speakup | 7

Re: [PATCH] speakup: Make dectlk flush timeout configurable

Greg KH, le jeu. 28 janv. 2021 08:54:16 +0100, a ecrit: > On Thu, Jan 28, 2021 at 12:44:44AM +0100, Samuel Thibault wrote: > > static struct kobj_attribute full_time_attribute = > > __ATTR(full_time, 0644, spk_var_show, spk_var_store); > > +static struct kobj_attribute

[PATCH] speakup: Make dectlk flush timeout configurable

In case the serial port or cable got faulty, we may not be getting acknowledgements any more. The driver then currently waits for 4s to avoid jamming the device. This makes this delay configurable. Signed-off-by: Samuel Thibault --- drivers/accessibility/speakup/speakup_dectlk.c | 11

Re: [PATCH 1/4] This merely adds the missing synth parameter to all io functions.

Greg KH, le mar. 26 janv. 2021 19:37:53 +0100, a ecrit: > Can you fix this up and resend the series? Yep! done so. Samuel

[PATCH 3/4] speakup: Simplify spk_ttyio_out error handling.

This avoids most code indentation Signed-off-by: Samuel Thibault --- drivers/accessibility/speakup/spk_ttyio.c | 38 --- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/drivers/accessibility/speakup/spk_ttyio.c b/drivers/accessibility/speakup/spk_ttyio.c

[PATCH 2/4] speakup: Reference synth from tty and tty from synth

. Even if the device disappears (e.g. USB unplug), the tty structure will still be there, and we automatically stop speakup in the spk_ttyio_out error handler but keep tty until the user cleans things up. As a result, this simplifies locking a lot. Signed-off-by: Samuel Thibault --- drivers

[PATCH 4/4] speakup: Add documentation on changing the speakup messages language

This documents how to use speakup_setlocale to set the speakup messages language. Signed-off-by: Samuel Thibault --- Documentation/admin-guide/spkguide.txt | 48 -- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/spkguide.txt b

[PATCH 1/4] speakup: add the missing synth parameter to all io functions

So that we can avoid the spk_ttyio_synth global variable in the next commit. Signed-off-by: Samuel Thibault --- drivers/accessibility/speakup/serialio.c | 22 ++-- .../accessibility/speakup/speakup_acntpc.c| 4 +-- .../accessibility/speakup/speakup_apollo.c| 4

[PATCH 0/4] speakup update

Samuel Thibault (4): speakup: add the missing synth parameter to all io functions speakup: Reference synth from tty and tty from synth speakup: Simplify spk_ttyio_out error handling. speakup: Add documentation on changing the speakup messages language Documentation/admin-guide

[PATCH 0/4] speakup update

Samuel Thibault (4): This merely adds the missing synth parameter to all io functions. speakup: Reference synth from tty and tty from synth speakup: Simplify spk_ttyio_out error handling. speakup: Add documentation on changing the speakup messages language Documentation/admin-guide

[PATCH 2/4] speakup: Reference synth from tty and tty from synth

. Even if the device disappears (e.g. USB unplug), the tty structure will still be there, and we automatically stop speakup in the spk_ttyio_out error handler but keep tty until the user cleans things up. As a result, this simplifies locking a lot. Signed-off-by: Samuel Thibault --- drivers

[PATCH 3/4] speakup: Simplify spk_ttyio_out error handling.

This avoids most code indentation Signed-off-by: Samuel Thibault --- drivers/accessibility/speakup/spk_ttyio.c | 38 --- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/drivers/accessibility/speakup/spk_ttyio.c b/drivers/accessibility/speakup/spk_ttyio.c

[PATCH 4/4] speakup: Add documentation on changing the speakup messages language

Signed-off-by: Samuel Thibault --- Documentation/admin-guide/spkguide.txt | 48 -- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/spkguide.txt b/Documentation/admin-guide/spkguide.txt index 5ff6a0f..96d4c87 100644

[PATCH 1/4] This merely adds the missing synth parameter to all io functions.

Signed-off-by: Samuel Thibault --- drivers/accessibility/speakup/serialio.c | 22 ++-- .../accessibility/speakup/speakup_acntpc.c| 4 +-- .../accessibility/speakup/speakup_apollo.c| 4 +-- .../accessibility/speakup/speakup_audptr.c| 8 ++--- .../accessibility/speakup

Re: [patch 1/3] speakup: Add synth parameter to io functions

Greg KH, le mar. 05 janv. 2021 14:39:47 +0100, a ecrit: > On Thu, Dec 10, 2020 at 09:03:00PM +0100, Samuel Thibault wrote: > > Greg KH, le jeu. 10 déc. 2020 16:23:11 +0100, a ecrit: > > > The build still breaks when this patch is applied: > > > > > drivers/accessi

[PATCH] speakup: Add github repository URL and bug tracker

We have set up a repository for users to try newer releases more easily, and keep records of known bugs. Signed-off-by: Samuel Thibault Index: linux-5.10/MAINTAINERS === --- linux-5.10.orig/MAINTAINERS +++ linux-5.10/MAINTAINERS

[patch 0/3] speakup: simplify relation between line disc and synth

This series reworks the relation between the speakup line discipline and the speakup synthesizers. This is probably fixing a few minor issues, but since it is invasive it'll better wait for 5.11.

[patch 3/3] speakup: Simplify spk_ttyio_out error handling.

This avoids most code indentation Signed-off-by: Samuel Thibault Index: linux-5.9/drivers/accessibility/speakup/spk_ttyio.c === --- linux-5.9.orig/drivers/accessibility/speakup/spk_ttyio.c +++ linux-5.9/drivers/accessibility

Re: [patch 1/3] speakup: Add synth parameter to io functions

Greg KH, le jeu. 10 déc. 2020 16:23:11 +0100, a ecrit: > The build still breaks when this patch is applied: > drivers/accessibility/speakup/spk_ttyio.c:344:18: note: in expansion of macro > ‘SPK_SYNTH_TIMEOUT’ > 344 | return ttyio_in(SPK_SYNTH_TIMEOUT); Sorry, I had a refresh missing. I

[patch 1/3] speakup: Add synth parameter to io functions

This merely adds the missing synth parameter to all io functions. Signed-off-by: Samuel Thibault Index: linux-5.9/drivers/accessibility/speakup/spk_ttyio.c === --- linux-5.9.orig/drivers/accessibility/speakup/spk_ttyio.c +++ linux

[patch 2/3] speakup: Reference synth from tty and tty from synth

. Even if the device disappears (e.g. USB unplug), the tty structure will still be there, and we automatically stop speakup in the spk_ttyio_out error handler but keep tty until the user cleans things up. As a result, this simplifies locking a lot. Signed-off-by: Samuel Thibault Index: linux-5.9

Re: [patch 1/3] speakup: Add synth parameter to io functions

Greg KH, le jeu. 10 déc. 2020 16:23:11 +0100, a ecrit: > On Wed, Dec 09, 2020 at 09:58:30PM +0100, samuel.thiba...@ens-lyon.org wrote: > > This merely adds the missing synth parameter to all io functions. > > > > Signed-off-by: Samuel Thibault > > > > The b

[patch 3/3] speakup: Simplify spk_ttyio_out error handling.

This avoids most code indentation Signed-off-by: Samuel Thibault Index: linux-5.10/drivers/accessibility/speakup/spk_ttyio.c === --- linux-5.10.orig/drivers/accessibility/speakup/spk_ttyio.c +++ linux-5.10/drivers/accessibility

Re: [patch 1/3] speakup: Add synth parameter to io functions

Greg KH, le mer. 09 déc. 2020 15:40:29 +0100, a ecrit: > On Mon, Nov 30, 2020 at 11:26:41PM +0100, Samuel Thibault wrote: > > This merely adds the missing synth parameter to all io functions. > > > > Signed-off-by: Samuel Thibault > > This patch breaks the b

[patch 2/3] speakup: Reference synth from tty and tty from synth

. Even if the device disappears (e.g. USB unplug), the tty structure will still be there, and we automatically stop speakup in the spk_ttyio_out error handler but keep tty until the user cleans things up. As a result, this simplifies locking a lot. Signed-off-by: Samuel Thibault Index: linux-5.10

[patch 1/3] speakup: Add synth parameter to io functions

This merely adds the missing synth parameter to all io functions. Signed-off-by: Samuel Thibault Index: linux-5.10/drivers/accessibility/speakup/spk_ttyio.c === --- linux-5.10.orig/drivers/accessibility/speakup/spk_ttyio.c

[patch 0/3] speakup: simplify relation between line disc and synth

This series reworks the relation between the speakup line discipline and the speakup synthesizers. This is probably fixing a few minor issues, but since it is invasive it'll better wait for 5.11.

[patch 3/3] speakup: Simplify spk_ttyio_out error handling.

This avoids most code indentation Signed-off-by: Samuel Thibault Index: linux-5.9/drivers/accessibility/speakup/spk_ttyio.c === --- linux-5.9.orig/drivers/accessibility/speakup/spk_ttyio.c +++ linux-5.9/drivers/accessibility

[patch 1/3] speakup: Add synth parameter to io functions

This merely adds the missing synth parameter to all io functions. Signed-off-by: Samuel Thibault Index: linux-5.9/drivers/accessibility/speakup/spk_ttyio.c === --- linux-5.9.orig/drivers/accessibility/speakup/spk_ttyio.c +++ linux

[patch 2/3] speakup: Reference synth from tty and tty from synth

. Even if the device disappears (e.g. USB unplug), the tty structure will still be there, and we automatically stop speakup in the spk_ttyio_out error handler but keep tty until the user cleans things up. As a result, this simplifies locking a lot. Signed-off-by: Samuel Thibault Index: linux-5.9

[patch 0/3] speakup: simplify relation between line disc and synth

This series reworks the relation between the speakup line discipline and the speakup synthesizers. This is probably fixing a few minor issues, but since it is invasive it'll better wait for 5.11.

[PATCH] speakup: Reject setting the speakup line discipline outside of speakup

. This change restricts the use of the speakup line discipline to speakup drivers, thus avoiding such kind of issues altogether. Cc: sta...@vger.kernel.org Reported-by: Shisong Qin Signed-off-by: Samuel Thibault Tested-by: Shisong Qin Index: linux-5.9/drivers/accessibility/speakup/spk_ttyio.c

Re: [PATCH] speakup: fix uninitialized flush_lock

igned-off-by: Yang Yingliang Reviewed-by: Samuel Thibault > --- > drivers/accessibility/speakup/speakup_dectlk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/accessibility/speakup/speakup_dectlk.c > b/drivers/accessibility/speakup/speakup_dect

Re: drivers/accessibility/speakup/serialio.c:48:19: warning: variable 'quot' set but not used

Ben Hutchings, le lun. 16 nov. 2020 19:51:23 +, a ecrit: > On Mon, 2020-11-16 at 20:01 +0100, Samuel Thibault wrote: > > Perhaps we should rather use > > > > depends on ISA || (X86 && COMPILE_TEST) > > > > ? > > so that we have compile

Re: drivers/accessibility/speakup/serialio.c:48:19: warning: variable 'quot' set but not used

d = 9600, quot = 0; > c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs > 2010-10-07 49 unsigned int cval = 0; > c6e3fd22cd5383 drivers/staging/speakup/serialio.c William Hubbs > 2010-10-07 50 int cflag = CREAD | HUPCL | CLOCAL | B960

[PATCH] speakup: Document read_all_doc shortcut

This was implemented a long time ago, but never actually added to the documentation. Signed-off-by: Samuel Thibault --- Documentation/admin-guide/spkguide.txt |1 + 1 file changed, 1 insertion(+) --- a/Documentation/admin-guide/spkguide.txt +++ b/Documentation/admin-guide/spkguide.txt

[PATCH] speakup ttyio: Do not schedule() in ttyio_in_nowait

not schedule() at all, even with timeout == 0, this crashes the kernel. We can however use try_wait_for_completion() instead of wait_for_completion_timeout(0). Cc: sta...@vger.kernel.org Signed-off-by: Samuel Thibault Reported-by: John Covici Tested-by: John Covici --- drivers/accessibility/speakup

[PATCH] speakup: Fix clearing selection in safe context

handle_edge_irq+0x233/0xa90 do_IRQ+0x10b/0x310 common_interrupt+0xf/0xf Cc: sta...@vger.kernel.org Signed-off-by: Samuel Thibault Reported-by: Jookia --- Note for stable: this driver was previously in drivers/staging/speakup drivers/accessibility/speakup/main.c |1 - drivers

Re: Crash when specifying non-existent serial port in speakup / tty_kopen

Matthias Reichl, le mer. 04 nov. 2020 22:15:05 +0100, a ecrit: > > This looks like only a warning, did it actually crash? > > Yes, scroll down a bit, the null pointer oops followed almost > immediately after that > > [ 49.979043] BUG: kernel NULL pointer dereference, address: 0090

Re: Crash when specifying non-existent serial port in speakup / tty_kopen

Hello, Matthias Reichl, le mer. 04 nov. 2020 15:57:37 +0100, a ecrit: > I initially noticed this oops on x86_64 running kernel 5.4.59 when > I accidentally mistyped "ttyS0" as "ttyS9": > > modprobe speakup_dummy dev=ttyS9 > [ 49.978481] tty_init_dev: ttyS driver does not set tty->port. This

Re: [PATCH] speakup: Fix var_id_t values and thus keymap

Greg KH, le mar. 03 nov. 2020 15:41:19 +0100, a ecrit: > On Tue, Nov 03, 2020 at 03:31:42PM +0100, Samuel Thibault wrote: > > This is a change that should got into 5.10, in the meanwhile the bug > > (appeared in 5.8) is very inconvenient for users. > > It's in my to-app

Re: [PATCH] speakup: Fix var_id_t values and thus keymap

Ping? This is a change that should got into 5.10, in the meanwhile the bug (appeared in 5.8) is very inconvenient for users. Samuel Samuel Thibault, le lun. 12 oct. 2020 18:06:46 +0200, a ecrit: > commit d97a9d7aea04 ("staging/speakup: Add inflection synth parameter") >

[PATCH] speakup: document the usage of enum values

-by: Samuel Thibault --- drivers/accessibility/speakup/i18n.h |6 +++ drivers/accessibility/speakup/main.c | 64 ++- 2 files changed, 39 insertions(+), 31 deletions(-) --- a/drivers/accessibility/speakup/i18n.h +++ b/drivers/accessibility/speakup/i18n.h @@ -23,12

[PATCH] speakup_dummy: log about characters received by the dummy driver

The dummy speakup driver is used to check that speakup is working properly, without the need for actually owning the hardware. Some drivers require receiving characters, so we need a way to check that this is working properly. Signed-off-by: Samuel Thibault Index: linux-5.9/drivers

[PATCH] speakup: Fix var_id_t values and thus keymap

ly the volume control shortcut (speakup-1 or 2) was actually changing the inflection. This moves the INFLECTION value at the end of the var_id_t enum to fix back the enum values. This also adds a warning about it. Cc: sta...@vger.kernel.org Reported-by: Kirk Reiser Reported-by: Gregory Nowak

Re: drivers/accessibility/speakup/serialio.c:139:9: sparse: sparse: cast removes address space '__iomem' of expression

kernel test robot, le dim. 16 août 2020 19:25:17 +0800, a ecrit: > First bad commit (maybe != root cause): > >> drivers/accessibility/speakup/serialio.c:139:9: sparse: sparse: cast > >> removes address space '__iomem' of expression This will also be fixed by the patches I already sent to gregkh

Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled

Greg KH, le mar. 04 août 2020 17:49:52 +0200, a ecrit: > > #define inb(c) ({ u8 __v; __io_pbr(); __v = > > readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) > > > > and thus yes it's arithmetic over a (void*) pointer, the caller cannot > > do anything about it. > > And

[PATCHv2 2/2] speakup: only build serialio when ISA is enabled

Drivers using serialio were already made available in Kconfig only under the ISA condition. Signed-off-by: Samuel Thibault Index: linux-2.6/drivers/accessibility/speakup/Makefile === --- linux-2.6.orig/drivers/accessibility/speakup

[PATCHv2 1/2] speakup: Fix wait_for_xmitr for ttyio case

yes. Signed-off-by: Samuel Thibault Index: linux-2.6/drivers/accessibility/speakup/serialio.c === --- linux-2.6.orig/drivers/accessibility/speakup/serialio.c +++ linux-2.6/drivers/accessibility/speakup/serialio.c @@ -32,6 +32,7

Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled

Greg KH, le mar. 04 août 2020 13:58:17 +0200, a ecrit: > ERROR: modpost: "spk_serial_io_ops" > [drivers/accessibility/speakup/speakup_keypc.ko] undefined! > ERROR: modpost: "spk_stop_serial_interrupt" > [drivers/accessibility/speakup/speakup_keypc.ko] undefined! Oh, indeed, these

Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled

Greg KH, le mar. 04 août 2020 13:34:13 +0200, a ecrit: > On Tue, Aug 04, 2020 at 01:13:32PM +0200, Samuel Thibault wrote: > > Drivers using serialio are already made available in Kconfig only under > > the ISA condition. > > > > This solves warnings in inb/outb macros o

[PATCH 1/2] speakup: Fix wait_for_xmitr for ttyio case

yes. Signed-off-by: Samuel Thibault Index: linux-2.6/drivers/accessibility/speakup/serialio.c === --- linux-2.6.orig/drivers/accessibility/speakup/serialio.c +++ linux-2.6/drivers/accessibility/speakup/serialio.c @@ -32,6 +32,7

[PATCH 2/2] speakup: only build serialio when ISA is enabled

Drivers using serialio are already made available in Kconfig only under the ISA condition. This solves warnings in inb/outb macros on platform that do not have support for ISA. Signed-off-by: Samuel Thibault Index: linux-2.6/drivers/accessibility/speakup/Makefile

Re: [PATCHv2] staging/speakup: Move out of staging

Greg KH, le mer. 29 juil. 2020 14:05:33 +0200, a ecrit: > On Wed, Jul 29, 2020 at 02:35:31AM +0200, Samuel Thibault wrote: > > The nasty TODO items are done. > > > > Signed-off-by: Samuel Thibault > > Now applied, thanks for all of the work so far. > >

Re: [PATCH] staging/speakup: Move out of staging

Joe Perches, le mar. 28 juil. 2020 17:24:47 -0700, a ecrit: > On Tue, 2020-07-28 at 23:12 +0200, Samuel Thibault wrote: > > diff --git a/MAINTAINERS b/MAINTAINERS > [] > > @@ -16077,6 +16077,15 @@ Q: > > https://patchwork.kernel.org/project/linux-sparse/list/ > >

[PATCHv2] staging/speakup: Move out of staging

The nasty TODO items are done. Signed-off-by: Samuel Thibault --- v2: keep S: line in MAINTAINERS .../ABI/stable}/sysfs-driver-speakup | 0 .../admin-guide}/spkguide.txt | 0 MAINTAINERS | 20 +-- drivers

Re: [PATCH] staging/speakup: Update TODO list

Greg KH, le mar. 28 juil. 2020 10:18:42 +0200, a ecrit: > On Sun, Jul 26, 2020 at 06:54:52PM +0200, Samuel Thibault wrote: > > Thanks to Okash's latest work, the TODO list is essentially empty, so > > the way out from staging now seems open. > > > > The status of th

[PATCH] staging/speakup: Move out of staging

The nasty TODO items are done. Signed-off-by: Samuel Thibault --- .../ABI/stable}/sysfs-driver-speakup | 0 .../admin-guide}/spkguide.txt | 0 MAINTAINERS | 19 +-- drivers/accessibility/Kconfig | 2

[PATCH] staging/speakup: Update TODO list

istinguish the symptoms mentioned in TODO from the symptoms of the bug fixed by 9d32c0cde4e2. Signed-off-by: Samuel Thibault diff --git a/drivers/staging/speakup/TODO b/drivers/staging/speakup/TODO index 993410c3e531..d4ca093bf0bd 100644 --- a/drivers/staging/speakup/TODO +++ b/drivers/staging/speakup/TOD

Re: [PATCH] Staging: speakup: Replace HTTP links with HTTPS ones

> Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov Reviewed-by: Samuel Thibault Thanks! > --- > Continuing my work started at 93431e0607e5. > See also: git log --oneline '--author=Alexander A. Klimov > ' v5.7..master >

Re: [PATCH] taging: speakup: remove volatile

Joe Perches, le ven. 22 mai 2020 10:22:03 -0700, a ecrit: > > Put another way: I don't think putting any hint here would help, on the > > contrary, somebody has to really look at what protection is needed, > > without getting influenced by rules-of-thumb. > > checkpatch newbies/robots will submit

Re: [PATCH] taging: speakup: remove volatile

Joe Perches, le ven. 22 mai 2020 09:36:05 -0700, a ecrit: > On Fri, 2020-05-22 at 13:34 +0300, Dan Carpenter wrote: > > On Fri, May 22, 2020 at 02:46:28PM +0530, MugilRaj wrote: > > > fix checkpatch.pl warning, which is Use of volatile is usually wrong: see > > >

Re: [PATCH] taging: speakup: remove volatile

Hello, MugilRaj, le ven. 22 mai 2020 14:46:28 +0530, a ecrit: > fix checkpatch.pl warning, which is Use of volatile is usually wrong: see > Documentation/process/volatile-considered-harmful.rst Yes, but the proper fix is usually not to just remove the volatile qualifier, which will not fix

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

Okash Khawaja, le dim. 15 sept. 2019 19:41:30 +0100, a ecrit: > I have attached the descriptions. Attachment is missing :) Samuel

Re: [HELP REQUESTED from the community] Was: Staging status of speakup

Hello, Okash Khawaja, le sam. 14 sept. 2019 22:08:35 +0100, a ecrit: > 2. We are still missing descriptions for i18n/ directory. I have added > filenames below. can someone can add description please: There are some descriptions in the "14.1. Files Under the i18n Subdirectory" section of

[PATCHv2] hda: Fix 1-minute detection delay when i915 module is not available

, in which case i915 is already compiled-in anyway). Signed-off-by: Samuel Thibault --- sound/hda/hdac_i915.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) --- a/sound/hda/hdac_i915.c +++ b/sound/hda/hdac_i915.c @@ -136,10 +136,13 @@ int snd_hdac_i915_init(struct hdac_bus

hda: Fix 1-minute detection delay when i915 module is not available

, in which case i915 is already compiled-in anyway). Signed-off-by: Samuel Thibault --- sound/hda/hdac_i915.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) --- a/sound/hda/hdac_i915.c +++ b/sound/hda/hdac_i915.c @@ -143,10 +143,14 @@ int snd_hdac_i915_init(struct hdac_bus

[HELP REQUESTED from the community] Was: Staging status of speakup

Hello, To readers of the linux-speakup: could you help on this so we can get Speakup in mainline? Neither Okash or I completely know what user consequences the files in /sys/accessibility/speakup/ have, so could people give brief explanations for each file (something like 3-6 lines of

Re: [PATCH] staging: speakup: One function call less in speakup_win_enable()

e Coccinelle software. > > Signed-off-by: Markus Elfring Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/main.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c

Re: [PATCH] drivers: staging: speakup: serialio: fix warning linux/serial.h is included more than once

indeed the result of f79b0d9c223ca09cefffc72304a7bcbc401a1c6f ("staging: speakup: Fixed warning instead of ") which didn't take care of the inclusion above. I believe only is fine, the important part is in drivers/staging/speakup/serialio.c which really needs to include asm/serial.h to get SERIAL_PORT_DFNS

Re: [PATCH] Staging: speakup: Replace return type

Hello, Madhumitha Prabakaran, le dim. 05 mai 2019 02:26:45 -0500, a ecrit: > Replace return type and remove the respective assignment. I prefer to keep it the way it was, it looks more straightforward for the reader. Samuel > Issue found by Coccinelle. > > Signed-off-by: Madhumitha Prabakaran

Re: [PATCH 1/2] vt: selection: allow functions to be called from inside kernel

Greg KH, le jeu. 04 avril 2019 22:35:49 +0200, a ecrit: > On Thu, Apr 04, 2019 at 08:45:29PM +0100, Okash Khawaja wrote: > > diff --git a/include/linux/selection.h b/include/linux/selection.h > > index a8f5b97b216f..171d77dfc825 100644 > > --- a/include/linux/selection.h > > +++

Re: Staging status of speakup

Alan Cox, le mar. 19 mars 2019 16:31:21 +, a ecrit: > On Sat, 16 Mar 2019 10:35:43 +0100 > Samuel Thibault wrote: > > Chris Brannon, le ven. 15 mars 2019 18:19:39 -0700, a ecrit: > > > Okash Khawaja writes: > > > > Finally there is an issue where tex

Re: Staging status of speakup

Hello, Please keep the lists in Cc, so that not only I have the information (in particular since I will probably *not* have the time to investigate myself). Samuel Thibault, le sam. 16 mars 2019 10:35:43 +0100, a ecrit: > The problem is that neither Okash nor I are even casual users of > s

Re: Staging status of speakup

Chris Brannon, le ven. 15 mars 2019 18:19:39 -0700, a ecrit: > Okash Khawaja writes: > > Finally there is an issue where text in output buffer sometimes gets > > garbled on SMP systems, but we can continue working on it after the > > driver is moved out of staging, if that's okay. Basically we

staging/speakup_soft: Fix alternate speech with other synths

alive, otherwise the switch would let it remain silent. Signed-off-by: Samuel Thibault --- drivers/staging/speakup/speakup_soft.c | 16 +++- drivers/staging/speakup/spk_priv.h |1 + drivers/staging/speakup/synth.c|6 ++ 3 files changed, 18 insertions(+), 5

Re: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"

k from the speakup mailing list, I guess fixing the typo is fine. Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/i18n.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c > ind

Re: [PATCH v2] staging : speakup: Fix format issues in Kconfig

Bharath Vedartham, le dim. 24 févr. 2019 18:41:42 +0530, a ecrit: > Fix the checkpatch.pl warning to replace ---help--- with help in > Kconfig. > > Signed-off-by: Bharath Vedartham Reviewed-by: Samuel Thibault Thanks! > --- > Changes since v1: > - Allign help

Re: [PATCH] staging: Note that simple_strtoul can't simply be replaced by kstrtoul

Greg KH, le dim. 24 févr. 2019 08:59:21 +0100, a ecrit: > On Sat, Feb 23, 2019 at 08:42:19PM +0100, Samuel Thibault wrote: > > We often receive patches which erroneously try to use kstrtoul in these > > places. > > > > Signed-off-by: Samuel Thibault > > Awe,

Re: [PATCH] staging : speakup: replace ---help--- with help in Kconfig

Hello, and thanks for your patch, Bharath Vedartham, le dim. 24 févr. 2019 01:51:17 +0530, a ecrit: > @@ -148,7 +148,7 @@ config SPEAKUP_SYNTH_KEYPC > > config SPEAKUP_SYNTH_LTLK > tristate "DoubleTalk LT/LiteTalk synthesizer support" > help--- > +help I'd say while at it, align it

Re: [PATCH] staging: speakup: Replace simple_strtoul with kstrtoul

Bharath Vedartham, le dim. 24 févr. 2019 01:01:21 +0530, a ecrit: > simple_strtoul is obsolete. Change it to kstrtoul. Kernel is building > and booting successfully. Please recheck your patch, temp is used after the simple_strtoul call. Samuel

[PATCH] staging: Note that simple_strtoul can't simply be replaced by kstrtoul

We often receive patches which erroneously try to use kstrtoul in these places. Signed-off-by: Samuel Thibault --- drivers/staging/speakup/kobjects.c|2 ++ drivers/staging/speakup/main.c|1 + drivers/staging/speakup/varhandlers.c |1 + 3 files changed, 4 insertions

Re: [PATCH] staging: speakup: fix tty-operation NULL derefs

, tiocmset and input > functionality for tty") > Cc: stable # 4.13 > Cc: Okash Khawaja > Cc: Samuel Thibault > Signed-off-by: Johan Hovold Indeed. Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/spk_ttyio.c | 6 -- > 1 file changed

Re: general protection fault in spk_ttyio_ldisc_close

Greg KH, le mar. 08 janv. 2019 15:25:07 +0100, a ecrit: > On Tue, Jan 08, 2019 at 09:15:02AM -0500, Kyungtae Kim wrote: > > On Tue, Jan 8, 2019 at 8:50 AM Greg KH wrote: > > > > > > On Tue, Jan 08, 2019 at 08:37:37AM -0500, Kyungtae Kim wrote: > > > > We report a bug in linux-4.20: "general

Re: [PATCH] staging: speakup: Fix coding style

Daniel Smith, le lun. 24 déc. 2018 10:12:23 +, a ecrit: > Replaced text ---help--- with help as per style check patch recommendation > > Signed-off-by: Daniel Acked-by: Samuel Thibault

Re: [PATCH] staging: speakup: change semaphore to completion

Arnd Bergmann, le lun. 10 déc. 2018 22:41:50 +0100, a ecrit: > In this driver, both function the same way, but we want to eventually > kill off semaphores, so a completion is the better choice here. > > Signed-off-by: Arnd Bergmann Reviewed-by: Samuel Thibault > --- > drive

Re: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"

Hello, Colin King, le mer. 28 nov. 2018 16:12:32 +, a ecrit: > - [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phoneticly", > + [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phonetically", Mmm, clearly an english typo. Speakup people, do you think there might be any

Re: [PATCH] staging: speakup: i18n: fix spelling mistake "phoneticly" -> "phonetically"

Hello, Colin King, le mer. 28 nov. 2018 16:12:32 +, a ecrit: > - [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phoneticly", > + [MSG_FUNCNAME_SPELL_WORD_PHONETICALLY] = "spell word phonetically", Mmm, clearly an english typo. Speakup people, do you think there might be any

staging/speakup_soft: Fix alternate speech with other synths

alive, otherwise the switch would let it remain silent. Signed-off-by: Samuel Thibault --- drivers/staging/speakup/speakup_soft.c | 16 +++- drivers/staging/speakup/spk_priv.h |1 + drivers/staging/speakup/synth.c|6 ++ 3 files changed, 18 insertions(+), 5

staging/speakup_soft: Fix alternate speech with other synths

alive, otherwise the switch would let it remain silent. Signed-off-by: Samuel Thibault --- drivers/staging/speakup/speakup_soft.c | 16 +++- drivers/staging/speakup/spk_priv.h |1 + drivers/staging/speakup/synth.c|6 ++ 3 files changed, 18 insertions(+), 5

Re: [PATCH] staging: speakup: clean up few indentation issues

Colin King, le mar. 30 oct. 2018 11:09:59 +, a ecrit: > From: Colin Ian King > > Trivial fix to clean up indentation issues across the driver > > Signed-off-by: Colin Ian King Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/kobjects.c | 2 +- >

Re: [PATCH] staging: speakup: clean up few indentation issues

Colin King, le mar. 30 oct. 2018 11:09:59 +, a ecrit: > From: Colin Ian King > > Trivial fix to clean up indentation issues across the driver > > Signed-off-by: Colin Ian King Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/kobjects.c | 2 +- >

staging/speakup_soft: Fix alternate speech with other synths

alive, otherwise the switch would let it remain silent. Signed-off-by: Samuel Thibault --- drivers/staging/speakup/speakup_soft.c | 16 +++- drivers/staging/speakup/spk_priv.h |1 + drivers/staging/speakup/synth.c|6 ++ 3 files changed, 18 insertions(+), 5

staging/speakup_soft: Fix alternate speech with other synths

alive, otherwise the switch would let it remain silent. Signed-off-by: Samuel Thibault --- drivers/staging/speakup/speakup_soft.c | 16 +++- drivers/staging/speakup/spk_priv.h |1 + drivers/staging/speakup/synth.c|6 ++ 3 files changed, 18 insertions(+), 5

Re: [PATCH] staging: speakup: remove redundant variable l

iable > > Signed-off-by: Colin Ian King Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/varhandlers.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/speakup/varhandlers.c > b/drivers/staging/speakup/varhandler

Re: [PATCH] staging: speakup: remove redundant variable l

iable > > Signed-off-by: Colin Ian King Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/varhandlers.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/speakup/varhandlers.c > b/drivers/staging/speakup/varhandler

Re: [PATCH] staging: speakup: fix wraparound in uaccess length check

Hello, Jann Horn, le mar. 10 juil. 2018 13:34:33 -0700, a ecrit: > On Sat, Jul 7, 2018 at 1:29 AM Samuel Thibault > wrote: > > Could you review, test, and resubmit the patch below instead? > > Er... you mean, you want me to take your patch, add my Signed-off-by > below

  1   2   3   4   5   6   7   8   >