Re: Kernel 3.16.0 USB crash

Adding Mathias Nyman. He is now the USB 3.0 maintainer. Sarah Sharp On Thu, Aug 14, 2014 at 11:46:33AM +0200, Hans de Goede wrote: > Hi, > > On 08/14/2014 10:39 AM, Claudio Bizzarri wrote: > > Ciao, > > > > thank you very much for replay, you are right: it'

Re: Kernel Debugging Support

mation. I known > where the file is I will > add the information then. You may be looking at an older version of MAINTAINERS. Mathias has only been marked as the maintainer since 3.15. Which kernel version are you working on? Sarah Sharp -- To unsubscribe from this list: send the l

Re: Kernel Debugging Support

e in from mainline, if no that's OK too. I don't understand what the above sentence means. What commit message are you referencing? What do you mean by "remove in from mainline"? Try again? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH v2] usb: xhci: Correct last context entry calculation for Configure Endpoint

Script is attached now. Sarah On Wed, Apr 30, 2014 at 04:04:24PM -0700, Sarah Sharp wrote: > Hi Mathias, > > I tested both this patch and your global command queue patches on top of > your for-usb-linus branch. After reverting commit 400362f1d8dc "ALSA: > usb-audio:

Re: [PATCH v2] usb: xhci: Correct last context entry calculation for Configure Endpoint

s expected. In short, I think it's fine to merge Julius' patch to usb-linus and your command queue patches to usb-next. Sarah Sharp [1] https://lkml.org/lkml/2014/4/19/117 On Tue, Apr 29, 2014 at 10:38:17AM -0700, Julius Werner wrote: > The current XHCI driver recalculates the Conte

Re: [PATCH v2 0/4] xhci: fixes for 3.15-rc usb-linus

to the longer version. (I've deliberately misspelled it here, so it doesn't get expanded.) Sometimes it takes a couple of round of `git blame` to figure out when the bug was introduced. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

ently set in add_flags throughout > the lifetime of a device. This means that when all endpoints are > dropped, the Context Entries field can be set to 0 (which is invalid and > may cause a Parameter Error) or -1 (which is interpreted as 31 and > causes the driver to keep using the

Re: [PATCH] #CleanUp non-gender-neutral README

http://knowyourmeme.com/memes/events/c-plus-equality-c Don't feed the trolls. > From: Feminist-Software-Foundation > > > This patch started as an effort inspired by EthicalCode's #CleanUpGitHub > project to find and replace > either hateful, hurtful or

Re: [PATCH v2 RESEND 4/4] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix()

t cleaning up how they look? Either way, this should really be two patches. Sarah Sharp > Signed-off-by: Alexander Gordeev > Cc: Sarah Sharp > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: linux-...@vger.kernel.org > --- > drivers/usb/host/xhci.c |7 ---

Re: [RFCv3 4/4] xhci: rework command timeout and cancellation,

ee(cur_cmd); } You should probably also audit all xHCI functions that submit commands, and make them not submit if the host is dying. I don't see anything stopping the USB core from causing command submission to a dead xHCI host. This needs to get fixed before the

Re: [RFCv3 1/4] xhci: Use command structures when queuing commands on the command ring

6 12:03:22 xanatos kernel: [ 1450.881990] [] ? kthread_create_on_node+0x230/0x230 Mar 6 12:03:22 xanatos kernel: [ 1450.881999] [] ret_from_fork+0x7c/0xb0 Mar 6 12:03:22 xanatos kernel: [ 1450.882005] [] ? kthread_create_on_node+0x230/0x230 Can you fix this in a second revision? (Note, this does not take

Re: xHCI regression in stable 3.13.5 with USB3 card reader (Bisected)

f those is the cause. I can try current git if there's > >anything in there that's likely to fix it. But it does seem like a > >regression got into the stable kernel in this respect. > > Bisecting between 3.13.4 and 3.13.5 gives me this: > > c8f44f98901994832ccecb8

Re: [PATCH v3 1/1] xhci: Prevent runtime pm from autosuspending during initialization

> USB: set hub's default autosuspend delay as 0 > > > > But nobody else than the reporter is able to trigger it. > > Then it can wait for 3.15-rc1, and then go back to the stable trees at > that time, right? I'd prefer that as it's not a regression

Re: [PATCH] usb: xhci: Prefer endpoint context dequeue pointer over stopped_trb

ship in 3.15. He's currently handling queuing bug fix patches for 3.14 while I finish queueing feature patches for 3.15. Mathias, will you test and queue this up for 3.14? Signed-off-by: Sarah Sharp > This patch removes the stopped_trb variable that had been used to store > the TRB Point

Re: [RFC PATCH v2] xhci: Prevent runtime pm from autosuspending during initialization

ntil USB-3 is initialized. */ > > + pm_runtime_get_noresume(&dev->dev); > > Strictly speaking, this prevents the _controller_ from going into > runtime suspend -- not the root hub. Signed-off-by: Sarah Sharp Mathias, want to fix this comment and queue this up to Greg? It sho

Re: [3.14-rc4 xHCI] Regression haswell B85 with xHCI on

ontroller: Intel Corporation 8 Series/C220 Series Chipset > Family 6-port SATA Controller 1 [AHCI mode] (rev 05) > 00:1f.3 SMBus: Intel Corporation 8 Series/C220 Series Chipset Family > SMBus Controller (rev 05) > 02:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. > RTL8111/8168/8411

Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.

Sorry for the delay in reviewing this. It helps me if you don't make the patch in-reply-to a months old thread. :) I'll take a look at this shortly. Sarah Sharp On Tue, Feb 18, 2014 at 09:42:39AM +0200, Denis Turischev wrote: > The same issue like with Panther Point chipsets. If

Re: [RFCv2 08/10] xhci: Add a global command queue

hat case. If the host won't halt, I'm not sure it will be able to, say, respond to the request to cancel the current command. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFCv2 00/10] xhci: re-work command queue management

t; transfers > and the code paths for aborting isoch transfers are badly broken. > > Adding another list that will have its own set of bugs seems retrograde top > me. I do not have a problem with it. The shadow ring is an optimization we can look at later. Sarah Sharp -- To unsub

Re: latest git usb3.0 ports not working

On Tue, Jan 21, 2014 at 02:17:06PM -0800, Sarah Sharp wrote: > On Tue, Jan 21, 2014 at 07:47:22PM +0100, Branimir Maksimovic wrote: > > asus maximus v gene motherboard, > > this is from dmesg: > > > > [ 75.576160] xhci_hcd :03:00.0: Timeout while waiting f

Re: [RFC 00/10] xhci: re-work command queue management

ainst 3.13 here: https://git.kernel.org/cgit/linux/kernel/git/sarah/xhci.git/log/?h=for-usb-next-command-queue Thanks, Sarah Sharp On Mon, Jan 13, 2014 at 05:05:49PM +0200, Mathias Nyman wrote: > This is an attempt to re-work and solve the issues in xhci command > queue management th

Re: latest git usb3.0 ports not working

:03:00.0: Abort the command ring, but > the xHCI is dead. By latest git, do you mean linus/master, or 3.13.0? If it's linus/master, please provide the commit ID. Which kernel version worked for you? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [BUGREPORT] Linux USB 3.0

880fd2de 880fd2c497b0 > >>> Dec 24 14:30:39 homenas kernel: [ 1469.822450] Call Trace: > >>> Dec 24 14:30:39 homenas kernel: [ 1469.822450] > >>> Dec 24 14:30:39 homenas kernel: [ 1469.822450] [] > >>> process_bulk_intr_td+0x116/

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

ainder() instead > of xhci_td_remainder(). Why? Walt has a 0.96 xHCI host controller, and the format for how to calculate the TD remainder changed between the 0.96 and the 1.0 spec. That's why we have xhci_v1_0_td_remainder() and xhci_td_remainder(). Sarah Sharp -- To unsubscribe from this l

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

On Tue, Jan 14, 2014 at 01:27:25PM -0800, walt wrote: > On 01/14/2014 09:20 AM, Sarah Sharp wrote: > > On Mon, Jan 13, 2014 at 03:39:07PM -0800, walt wrote: > > >> Sarah, I just fixed my xhci bug for US$19.99 :) > >> > >> #lspci | tail -1 > >> 04:00

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

On Mon, Jan 13, 2014 at 03:39:07PM -0800, walt wrote: > On 01/09/2014 03:50 PM, Sarah Sharp wrote: > > >>> On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote: > >> > >> I've wondered if my xhci problems might be caused by hardware quirks, and > >&g

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

[Walt, please use reply-all to keep the list in the loop, thanks.] On Wed, Jan 08, 2014 at 04:09:14PM +, David Laight wrote: > > From: Sarah Sharp > > On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote: > > > On 01/07/2014 01:21 PM, Sarah Sharp wrote: > > >

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

if (udev || (portstatus & > > > USB_PORT_STAT_CONNECTION) || > > > + (portstatus & USB_PORT_STAT_OVERCURRENT)) > > > set_bit(port1, hub->change_bits); > > > > > >

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote: > On 01/07/2014 01:21 PM, Sarah Sharp wrote: > > > Can you please try the attached patch, on top of the previous three > > patches, and send me dmesg? > > Hi Sarah, I just now finished running 0001-More-debugging.pa

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

On Tue, Jan 07, 2014 at 12:00:00PM -0800, walt wrote: > Okay, I used log_buf_len to make dmesg bigger and now I think I have > the whole thing. It's attached. Walt, can you make sure the patch I sent you was applied? The output doesn't look like it is. Sarah Sharp -- To unsub

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

On Tue, Jan 07, 2014 at 11:03:00AM +0100, Takashi Iwai wrote: > At Mon, 06 Jan 2014 14:34:28 +0200, > Denis Turischev wrote: > > > > Hi Sarah, > > > > On 01/03/2014 02:03 AM, Sarah Sharp wrote: > > > Denis, do all of Compulab's Haswell systems reboo

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

size to 120 KB. In any case, I added more debugging in the last patch to print the number of TRBs necessary. That way we can verify the patch to limit the number of scatter-gather list entries is working. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

On Tue, Jan 07, 2014 at 05:29:48AM -0800, walt wrote: > On 01/06/2014 04:31 PM, Sarah Sharp wrote: > > Hi Walt, > > > > I have a couple of patches for you to test. > > > Please only apply the first patch (which is diagnostic only), trigger > > your issue, an

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

On Fri, Jan 03, 2014 at 03:29:29PM -0800, Sarah Sharp wrote: > On Fri, Jan 03, 2014 at 01:21:18PM -0800, walt wrote: > > I'm so sorry Sarah, that was another mistake. The mistake is so stupid I'm > > not > > going to publish it here :( > > > > O

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

p TRBs did indeed cause the host to hang. Either way, I'll have to look into it. I'll let you know when I have some diagnostic patches ready. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

On Fri, Jan 03, 2014 at 07:40:33AM -0800, walt wrote: > On 01/02/2014 11:15 AM, Sarah Sharp wrote: > > On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote: > >> On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote: > >>> 3.12-stable review patch. If anyone has

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

On Sun, Dec 22, 2013 at 09:47:49AM +0200, Denis Turischev wrote: > On 12/21/2013 01:45 AM, Sarah Sharp wrote: > > On Fri, Dec 20, 2013 at 12:41:11PM +0200, Denis Turischev wrote: > >>> Also, which kernel are you experiencing this issue on? In 3.12, I > >>> que

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

On Thu, Jan 02, 2014 at 04:01:29PM -0500, Mark Lord wrote: > On 14-01-02 02:15 PM, Sarah Sharp wrote: > > On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote: > .. > >> Unfortunately this patch causes a regression when copying large files to my > >> outboard USB3 dri

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

ly turn off scatter-gather all together under xHCI until this gets fixed. It could mean a big performance hit for USB storage devices, but that means we get correct behavior for both USB ethernet and USB storage. > BTW, please tell me if I've cc'd too many people. No

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

c2c4ab41b016 > Sorry, I indeed tested not on the latest kernel version, Ubuntu 3.13-rc3 has > this patch and it works > for me. What does "Ubuntu 3.13-rc3" mean? Where did you get your kernel from? Also, do you have an HP system, or is this a different vendor? Sarah Shar

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

This patch should be backported to kernels as old as 3.0, that contain the commit 1c12443ab8eba71a658fae4572147e56d1f84f66 "xhci: Add Lynx Point to list of Intel switchable hosts." Cc: Oliver Neukum Signed-off-by: Takashi Iwai Signed-off-by: Sarah Sharp C

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

arm reset broadly. It seems like it wouldn't hurt to issue a warm reset on the USB 3.0 ports if they're in compliance, poll, or rx.detect. So, let's enable this broadly in xhci_resume, mark the patch for stable, but ask for the backport to be delayed until 3.13.3 is out, to allow for more testing. If anyone complains of xHCI behavior changes, we'll change the code to add a quirk. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

connected to them > before suspend. This seems to be the only way to ensure the devices' > state machines get back to a well-defined state that the host can work > with. I don't think this is a specific hardware bug, it's just an > unfortunate design flaw that the USB 3.0 spe

Re: [PATCH] USB: core: Add warm reset while reset-resuming SuperSpeed HUBs

ctly attached to roothubs? You can also change this code to get the port status and only do the warm reset if the port link state is USB_SS_PORT_LS_POLLING, USB_SS_PORT_LS_RX_DETECT, or USB_SS_PORT_LS_SS_INACTIVE. > Shouldn't you pass udev as the third argument? If not, please explain >

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

you with an answer as soon as I have it. Ping, Alexis: any info on this question? Sarah Sharp > -----Original Message- > From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > Sent: Thursday, November 14, 2013 5:31 PM > To: Alan Stern > Cc: Julius Werner; Greg K

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

On Thu, Nov 07, 2013 at 10:32:33AM -0500, Alan Stern wrote: > On Wed, 6 Nov 2013, Julius Werner wrote: > > > > What if the device is in USB_STATE_SUSPENDED? > > > > I'm not sure that is possible at that point in hub_events(), I don't > > know of a way that could lead to this situation. I could st

Standing for the Technical Advisory Board - Sarah Sharp

[Resending, since the Tech-board-discuss mailing list is subscriber-only, and my original email didn't make it through.] I'm running for The Linux Foundation Technical Advisory Board (TAB), and I would appreciate your vote! I will be at the joint Kernel Summit and LinuxCon party tomorrow, where y

[PATCH] xhci: Remove segments from radix tree on failed insert.

cated segment), but before the new ring segments are linked into the old ring. If insert fails on any one segment, remove each segment from the radix tree, deallocate the new segments, and return. Otherwise, link the new segments into the tree. Signed-off-by: Sarah Sharp --- Something like this.

Re: [PATCH v2] xhci: fix usb3 streams

orking on a patch to fix this, but may not get it done today. Sarah Sharp On Mon, Oct 14, 2013 at 06:54:24PM -0700, Gerd Hoffmann wrote: > Gerd, Hans, any objections to this updated patch? The warning is fixed > with it. > > The patch probably still needs to address the case where the r

Re: [PATCH v2] usb: hub: Clear Port Reset Change during init/resume

On Tue, Oct 15, 2013 at 05:45:00PM -0700, Julius Werner wrote: > This patch adds the Port Reset Change flag to the set of bits that are > preemptively cleared on init/resume of a hub. In theory this bit should > never be set unexpectedly... in practice it can still happen if BIOS, > SMM or ACPI cod

Re: [PATCH v2] xhci: fix usb3 streams

eeply into the code to see what exactly > > should be done there. > > > > I would like that issue fixed before I merge these patches, so if you > > want to take a stab at fixing it, please do. > > > > Sarah Sharp > > Sarah, how did you manage to send an

Re: Warning when calling radix_tree_insert on 3.12-rc4

On Mon, Oct 14, 2013 at 02:30:34PM +0200, Jan Kara wrote: > Hello Sarah, > > On Fri 11-10-13 15:13:15, Sarah Sharp wrote: > > I'm testing out some changes to the xHCI USB host controller driver > > (which uses a radix tree when a UAS device is attached to the ho

Warning when calling radix_tree_insert on 3.12-rc4

correctly within interrupt". I'll revert the commit, and see if the warning disappears. In the meantime, can you look into fixing this? Thanks, Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ker

Re: [PATCH] xhci: Ensure a command structure points to the correct trb on the command ring

On Fri, Oct 11, 2013 at 10:25:23AM -0700, Sarah Sharp wrote: > Hi Xiao, > > I think you did something odd when you tried to send me the latest > revision of your patch "xhci: correct the usage of > USB_CTRL_SET_TIMEOUT". You sent this patch instead. On the plus side,

Re: [PATCH] xhci: Ensure a command structure points to the correct trb on the command ring

Hi Xiao, I think you did something odd when you tried to send me the latest revision of your patch "xhci: correct the usage of USB_CTRL_SET_TIMEOUT". You sent this patch instead. On the plus side, it looks like git-send-email works. Can you try again? Sarah Sharp On Fri, Oct 11,

Re: [PATCH] xhci: correct the usage of USB_CTRL_SET_TIMEOUT

so concerned about *why* your host controller is taking so long to respond to the Stop Endpoint command. Was it because of the bug fixed by the other patch you sent? Thanks, Sarah Sharp > Signed-off-by: xiao jin > --- > drivers/usb/host/xhci-hub.c |2 +- > drivers/usb/host/xhci.c

Re: [PATCH] xhci-hub.c: handle command_trb that may be link TRB

NK_LE32(ring->enqueue->link.control)) return ring->enq_seg->next->trbs; return ring->enqueue; } That was added in commit ec7e43e2d98173483866fe2e4e690143626b659c "xhci: Ensure a command structure points to the correct trb on the command rin

Re: [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call

08&w=2 I hate to do this to you, but her patch is a better improvement, so I'll be taking that series instead of your patch. I hope you can still find other clean up work to do in the xHCI driver and USB core. :) Sarah Sharp On Wed, Sep 04, 2013 at 11:42:33AM +0530, Kumar Gaurav wrot

Re: [PATCH] checkpatch: Extend CamelCase types and ignore existing CamelCase uses in a patch

On Wed, Sep 04, 2013 at 04:08:06PM -0700, Joe Perches wrote: > (sending for 3rd time, odd dns problems today, apologies for dupes) > > On Wed, 2013-09-04 at 08:58 -0700, Sarah Sharp wrote: > > On Tue, Sep 03, 2013 at 10:25:21AM -0700, Joe Perches wrote: > > > Extend the

Re: [PATCH] checkpatch: Extend CamelCase types and ignore existing CamelCase uses in a patch

On Tue, Sep 03, 2013 at 10:25:21AM -0700, Joe Perches wrote: > Extend the CamelCase words found to include structure members. > > In https://lkml.org/lkml/2013/9/3/318 Sarah Sharp (mostly) wrote: > > "In general, if checkpatch.pl complains about a variable a patch > intr

Re: [PATCH 4/5] uas: add dead request list

code is full of BUG_ON(), which is not friendly to users, and doesn't increase my confidence that the driver is ready to have CONFIG_BROKEN removed. Sarah Sharp On Mon, Sep 02, 2013 at 01:25:28PM +0200, Gerd Hoffmann wrote: > This patch adds a new list where all requests which are cancele

Re: [PATCH v4:No Change] xHCI:Fixing xhci_readl definition and function call

git format-patch`, edit the patch manually (in whatever directory it was created it), and then send it by passing the file to `git send-email`. Sarah Sharp > drivers/usb/host/xhci-dbg.c | 36 - > drivers/usb/host/xhci-hub.c | 72 - > dri

Re: [v4:No,Change] xHCI:Fixing xhci_readl definition and function call

27;s CamelCase, you should pay attention to it. If it's a variable that already present in USB code, it's probably used to match the spec. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

On Wed, Aug 28, 2013 at 10:15:34PM +, Paul Zimmerman wrote: > > From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > > Sent: Wednesday, August 28, 2013 2:52 PM > > > > On Mon, Aug 26, 2013 at 07:37:56PM +, Paul Zimmerman wrote: > > > >

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

in bits 13:10 that means something different than what the driver thinks it means. This could lead to issues with USB 2.0 devices that support Link PM. Yes, this is broken. Distros that want to run on hosts that have BESL support need to have the BESL patches from Mathias. Sarah Sharp -- To unsubscri

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

/git/gregkh/usb.git/commit/?h=usb-next&id=ff49896aa45de286f3cbfda800fc92665374546a As for the non-credit tokens of appreciation, I don't have any gold bars handy, and I don't do bitcoins, sorry. :) Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

On Mon, Aug 26, 2013 at 07:37:56PM +, Paul Zimmerman wrote: > > From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > > Sent: Monday, August 26, 2013 12:14 PM > > > > On Thu, Aug 22, 2013 at 05:11:49AM +, Paul Zimmerman wrote: > > > > From: J

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

ludes device.h instead. drivers/usb/host/xhci/xhci-ring.c includes drivers/usb/host/xhci.h which includes include/linux/usb.h which includes include/linux/device.h All USB host controllers depend on including usb.h, so I don't think there's a need for the driver to explicitly include devic

[PATCH v3 1/1] dev-core: fix build break when DEBUG is enabled

Any objections to queuing this patch through Greg's usb-next tree? I've already sent the 2/2 patch, which will cause build breakage without this patch. Changes since v2: - Fixed a checkpatch warning caused by a comment in a macro. Sarah

Re: [PATCHv2 1/2] dev-core: fix build break when DEBUG is enabled

ase run your patches through checkpatch.pl. Sarah Sharp On Tue, Aug 27, 2013 at 05:47:34PM +0300, Dmitry Kasatkin wrote: > When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data > structures even when CONFIG_DYNAMIC_DEBUG is not defined. > It leads to build break. >

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

On Wed, Aug 28, 2013 at 10:18:24AM -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2013 at 09:59:38AM -0700, Sarah Sharp wrote: > > Please trim your replies. > > > > On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: > > > >>>

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

On Wed, Aug 28, 2013 at 10:45:48PM +0530, Kumar Gaurav wrote: > On Wednesday 28 August 2013 10:31 PM, Sarah Sharp wrote: > >On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: > >>On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: > >>>On Mon, Au

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

Please trim your replies. On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: > >>> That change seems to cause the problems: > >>> > >>> commit 0730d52a86919300a39a2be37f6c140997dfb82f > >>> "xhci:prevent "callbacks suppressed" when debug is not enabled" > >>> > >>> - Sedat - > >>> >

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

l try it on linux-next (once i cloned it) and will > send again. Yeah, this doesn't apply against Greg's usb-next tree, so I can't take it. If you're sending non-bug fixes in, you need to base your patches against that tree, or linux-next. Sarah Sharp -- To unsubscribe fr

Re: [PATCHv2 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

Hi Dmitry, This patch looks fine, and applies ok. I'll send it off to Greg with a couple more bug fixes shortly. Sarah Sharp On Tue, Aug 27, 2013 at 05:52:33PM +0300, Dmitry Kasatkin wrote: > Used vim "=" as Sarah suggested. > > - Dmitry > > On Tue, Aug 27, 20

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

SL been added, around > version 2.41a or so. And the 2.41a version that supports BESL properly sets the BLC flag in the USB 2.0 Protocol extended capabilities for all the USB 2.0 ports? Has this functionality been well-tested? Sarah Sharp -- To unsubscribe from this list: send the line "unsu

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

final].pdf files in this zip file: http://www.usb.org/developers/docs/usb_20_070113.zip I agree though, it's all a confusing mess for documentation on USB 2.0 Link PM. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

Hi Julius, Thanks for the patch! Did you test with a USB analyzer to see if the device was actually going into USB 2.0 Link PM? I'd like to confirm we really aren't breaking anything for DW3 hosts by enabling this. Sarah Sharp On Tue, Aug 20, 2013 at 04:21:49PM -0700, Julius We

Re: [PATCH] xHCI:Fixing xhci_readl definition and function call

Hi Kumar, This patch is much better, but it still needs a few improvements. :) Please make sure there's a space between xHCI: and the rest of your subject line. Also, when you revise a patch, you typically want to change the subject line to have a version. So in this case, your subject line sho

Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

On Fri, Aug 16, 2013 at 10:45:16AM -0700, Greg KH wrote: > On Fri, Aug 16, 2013 at 08:38:12PM +0300, Dmitry Kasatkin wrote: > > On Fri, Aug 16, 2013 at 8:30 PM, Sarah Sharp > > wrote: > > > On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote: > > >>

Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

On Fri, Aug 16, 2013 at 10:30:35AM -0700, Greg KH wrote: > On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote: > > On Thu, Aug 15, 2013 at 05:17:16PM -0700, Greg KH wrote: > > > On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote: > > > > When de

Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote: > On Thu, Aug 15, 2013 at 05:17:16PM -0700, Greg KH wrote: > > On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote: > > > When debug is not enabled and dev_dbg() will expand to nothing, > > >

Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled

debug patches being > worked on? I'll hold off on applying it for now, let me know if it's ok > or not. It doesn't conflict with the trace debug patches, because those only effect debugging with xhci_dbg with the host device, not dev_dbg with the USB device. This

Re: Dynamic debug on by default?

On Wed, Aug 14, 2013 at 10:04:10AM -0700, Greg KH wrote: > On Wed, Aug 14, 2013 at 09:51:54AM -0700, Joe Perches wrote: > > On Wed, 2013-08-14 at 09:40 -0700, Sarah Sharp wrote: > > > Hi Xenia, > > > > > > I'm a bit confused. I thought that debugging mess

Re: [PATCH] usb: xhci: Disable runtime PM suspend for quirky controllers.

ose changes, you could get that patch upstream. I would like the ChromeOS kernel to be as close to upstream as possible, so please resubmit this patch with those changes. Thanks, Sarah Sharp > > On Sat, May 25, 2013 at 7:11 AM, Alan Stern wrote: > > > On Fri, 24 May 2013, Sarah Sh

Re: [PATCH v2] usb: core: don't try to reset_device() a port that got just disconnected

e valid. > > > > Signed-off-by: Julius Werner > This version looks better. > > Acked-by: Alan Stern Thanks Alan, I'll send this off to Greg shortly. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] usb: core: don't try to reset_device() a port that got just disconnected

ommand timeout. Could the driver be possibly issuing either a Reset Device or Address Device command that simply times out? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] usb: xhci: add missing dma-mapping.h includes

Thanks for the patch James! I'll send it off to Greg in a couple days. Sarah Sharp On Fri, Jul 26, 2013 at 01:34:43PM +0100, James Hogan wrote: > A randconfig build hit the following build errors because xhci.c and > xhci-mem.c use dma mapping functions but don't include >

Re: Checkpatch error on trace events macros

On Mon, Jul 29, 2013 at 01:02:44PM -0700, Joe Perches wrote: > On Mon, 2013-07-29 at 12:52 -0700, Sarah Sharp wrote: > > Hi Andy and Joe, > > Hi Sarah. > > > Checkpatch is complaining when code adds new trace events macros: > > > > sarah@xanatos:~/git/kernels

Checkpatch error on trace events macros

: drivers/usb/host/xhci-trace.h:47: +#define TRACE_INCLUDE_FILE xhci-trace total: 3 errors, 0 warnings, 169 lines checked The macros have to be defined that way for trace events to work. Can you fix checkpatch not to complain about trace event macros? Thanks, Sarah Sharp -- To unsubscribe from

Re: NULL pointer dereference in xhci_free_dev

Heinz and Frantisek, I believe your issue should be fixed by this patch: http://marc.info/?l=linux-usb&m=137476546506888&w=2 Please let me know if it doesn't. Sarah Sharp On Sat, May 11, 2013 at 04:09:25PM +0200, Heinz Diehl wrote: > On 11.05.2013, Frantisek Hrbata wrote:

Re: [PATCH] usb: xhci: Mark two functions __maybe_unused

differ on ifdef vs __maybe_unused, let me know this > is not to your liking. __maybe_unused is fine, I will queue this up shortly. Sarah Sharp > > Thanks, > > -Olof > > drivers/usb/host/xhci.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > dif

Re: [PATCH v2] usb: host: xhci: Enable XHCI_SPURIOUS_SUCCESS for all controllers with xhci 1.0

a hub, have you tried connecting it directly to the computer's roothub? If it's attached to the roothub, have you tried putting it behind an external hub? If none of that works, I can look at your logs, and try to figure out if there's anything software can do. Can you recompile you

Re: Maybe it's time to shut this thread down (Was: Re: [ 00/19] 3.10.1-stable review)

On Fri, Jul 19, 2013 at 04:03:24PM -0400, Kurt H Maier wrote: > On Fri, Jul 19, 2013 at 12:01:27PM -0700, Sarah Sharp wrote: > > > > I'm not trying to shut down this discussion. But please, let's continue > > this discussion at KS, away from the court of public

Re: mistakes in code vs. maintainer flow mistakes (was: [ 00/19] 3.10.1-stable review)

On Fri, Jul 19, 2013 at 11:22:56AM +0200, Ingo Molnar wrote: > > * Sarah Sharp wrote: > > > On Thu, Jul 18, 2013 at 12:39:07PM +0200, Ingo Molnar wrote: > > > > > > * Linus Torvalds wrote: > > > > > > > On Mon, Jul 15, 2013 at 1:41 PM, S

Re: [PATCH 1/2] Revert "Revert "HID: Fix logitech-dj: missing Unifying device issue""

On Thu, Jul 18, 2013 at 04:28:01PM -0400, Peter Hurley wrote: > [ +cc Sarah Sharp, linux-usb ] > > On 07/18/2013 09:21 AM, Nestor Lopez Casado wrote: > >This reverts commit 8af6c08830b1ae114d1a8b548b1f8b056e068887. > > > >This patch re-adds the workaround introduced

Re: [ 00/19] 3.10.1-stable review

On Thu, Jul 18, 2013 at 12:39:07PM +0200, Ingo Molnar wrote: > > * Linus Torvalds wrote: > > > On Mon, Jul 15, 2013 at 1:41 PM, Sarah Sharp > > wrote: > > > > > > Oh, FFS, I just called out on private email for "playing the victim > > >

Re: Maybe it's time to shut this thread down (Was: Re: [ 00/19] 3.10.1-stable review)

g Linus an abuser is not conducive to moving this conversation forward. I agree not to use f*ck in my emails anymore, and, as Ted suggests, we'll see how polite requests get handled. > May I make the polite suggestion (and we'll see how well polite > requests get honored via e-m

Re: [ 00/19] 3.10.1-stable review

http://stumptownsyndicate.org/2013/04/09/goodbye-igal/ I personally don't want to be responsible for anyone else contemplating suicide, even because of an obviously sarcastic "joke". I don't joke about suicide. I would appreciate it if other developers refrained from joking ab

Re: [Ksummit-2013-discuss] [ATTEND] How to act on LKML

pful to look at a dictionary definition of verbal abuse, because it's much too short. Here's a much longer description of verbally abusive behaviors: http://outofthefog.net/CommonBehaviors/VerbalAbuse.html Key ones that apply to LKML communications: belittlement, demeaning statements

  1   2   3   >