[PATCH v2 00/17] Refactor fw_devlink to significantly improve boot time

2020-11-20 Thread Saravana Kannan
by Greg. - Added Tested-by: tags from Laurent and Grygorii. New Patch 17: - New patch to delete useless input to add_links() Saravana Kannan (17): Revert "driver core: Avoid deferred probe due to fw_devlink_pause/resume()" Revert "driver core: Rename dev_links_info.defer_syn

[PATCH v2 01/17] Revert "driver core: Avoid deferred probe due to fw_devlink_pause/resume()"

2020-11-20 Thread Saravana Kannan
for that can also go away. Signed-off-by: Saravana Kannan --- drivers/base/core.c| 21 - include/linux/device.h | 3 +-- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index d661ada1518f..b202fe54f46a 100644 --- a/drivers

Re: [PATCH v1 17/18] driver core: Add helper functions to convert fwnode links to device links

2020-11-20 Thread Saravana Kannan
On Mon, Nov 16, 2020 at 8:57 AM Rafael J. Wysocki wrote: > > On Thu, Nov 5, 2020 at 12:24 AM Saravana Kannan wrote: > > > > Add helper functions __fw_devlink_link_to_consumers() and > > __fw_devlink_link_to_suppliers() that convert fwnode l

Re: [PATCH v1 14/18] driver core: Use device's fwnode to check if it is waiting for suppliers

2020-11-20 Thread Saravana Kannan
On Mon, Nov 16, 2020 at 8:34 AM Rafael J. Wysocki wrote: > > On Thu, Nov 5, 2020 at 12:24 AM Saravana Kannan wrote: > > > > To check if a device is still waiting for its supplier devices to be > > added, we used to check if the devices is in a global > > wai

Re: [PATCH v1 13/18] driver core: Add fwnode_get_next_parent_dev() helper function

2020-11-20 Thread Saravana Kannan
On Mon, Nov 16, 2020 at 8:27 AM Rafael J. Wysocki wrote: > > On Thu, Nov 5, 2020 at 12:24 AM Saravana Kannan wrote: > > > > Given a fwnode, this function finds the closest ancestor fwnode that has > > a corresponding struct device. The function returns this struct d

Re: [PATCH v1 12/18] driver core: Add fw_devlink_parse_fwtree()

2020-11-20 Thread Saravana Kannan
On Mon, Nov 16, 2020 at 8:25 AM Rafael J. Wysocki wrote: > > On Thu, Nov 5, 2020 at 12:24 AM Saravana Kannan wrote: > > > > This function is a wrapper around fwnode_operations.add_links(). > > > > This function parses each node in a fwnode tree and create fwnode lin

Re: [PATCH v1 11/18] driver core: Redefine the meaning of fwnode_operations.add_links()

2020-11-20 Thread Saravana Kannan
On Mon, Nov 16, 2020 at 8:16 AM Rafael J. Wysocki wrote: > > On Thu, Nov 5, 2020 at 12:24 AM Saravana Kannan wrote: > > > > Change the meaning of fwnode_operations.add_links() to just create > > fwnode links by parsing the properties of a given fwnode. > > > &

Re: [PATCH v1 09/18] driver core: Allow only unprobed consumers for SYNC_STATE_ONLY device links

2020-11-20 Thread Saravana Kannan
On Mon, Nov 16, 2020 at 7:57 AM Rafael J. Wysocki wrote: > > On Thu, Nov 5, 2020 at 12:24 AM Saravana Kannan wrote: > > > > SYNC_STATE_ONLY device links only affect the behavior of sync_state() > > callbacks. Specifically, they prevent sync_state() only callbac

Re: [PATCH v1 08/18] driver core: Add fwnode link support

2020-11-20 Thread Saravana Kannan
On Mon, Nov 16, 2020 at 7:51 AM Rafael J. Wysocki wrote: > > On Thu, Nov 5, 2020 at 12:24 AM Saravana Kannan wrote: > > > > This patch adds support for creating supplier-consumer links between > > Generally speaking the "This patch" part is redundant. It

Re: [PATCH 3/3] of: property: fix document of of_get_next_parent_dev

2020-11-19 Thread Saravana Kannan
On Thu, Nov 19, 2020 at 3:18 AM Dong Aisheng wrote: > > Fix document of of_get_next_parent_dev. > > Cc: devicet...@vger.kernel.org > Cc: Saravana Kannan > Cc: Rob Herring > Cc: Greg Kroah-Hartman > Signed-off-by: Dong Aisheng > --- > drivers/of/property

Re: [PATCH 2/3] of: property: add debug info for supplier devices still unavailable

2020-11-19 Thread Saravana Kannan
On Thu, Nov 19, 2020 at 3:18 AM Dong Aisheng wrote: > > It's normal that supplier devices may still unavaiable when parse DT to > create dependency. e.g. supplier devices populated by drivers. > Add debug info for this case. > > Cc: devicet...@vger.kernel.org > Cc: Sarav

Re: [PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-18 Thread Saravana Kannan
On Wed, Nov 18, 2020 at 7:40 AM Aisheng Dong wrote: > > > From: Greg Kroah-Hartman > > Sent: Wednesday, November 18, 2020 6:46 PM > > > > On Wed, Nov 18, 2020 at 10:23:42AM +, Aisheng Dong wrote: > > > Hi Greg, > > > > > > > From: Greg Kroah-Hartman > > > > Sent: Monday, November 9, 2020

Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-06 Thread Saravana Kannan
On Fri, Nov 6, 2020 at 11:23 AM Mark Brown wrote: > > On Fri, Nov 06, 2020 at 11:09:17AM -0800, Saravana Kannan wrote: > > > If you want to do this in "one common place", then I think the way to > > do this is have include/linux/of.h provide something like: >

Re: [PATCH v1 2/2] spi: Populate fwnode in of_register_spi_device()

2020-11-06 Thread Saravana Kannan
On Fri, Nov 6, 2020 at 7:10 AM Mark Brown wrote: > > On Thu, Nov 05, 2020 at 11:26:44AM -0800, Saravana Kannan wrote: > > On Thu, Nov 5, 2020 at 9:12 AM Mark Brown wrote: > > > > > of_node_get(nc); > > > > spi->dev.of_node = nc; > >

Re: [PATCH RFC] driver core: Ensure DT devices always have fwnode set

2020-11-06 Thread Saravana Kannan
o setting > dev->of_node, currently a number of subsystems don't do so. Ensure that > this can't get missed by setting fwnode from of_node if it's not > previously been set by the subsystem. > > Reported-by: Saravana Kannan > Signed-off-by: Mark Brown > --- > > *Ver

Re: [PATCH v1 00/18] Refactor fw_devlink to significantly improve boot time

2020-11-06 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 9:09 PM Laurent Pinchart wrote: > > Hi Saravana, > > Thank you for working on this ! > > On Wed, Nov 04, 2020 at 03:23:37PM -0800, Saravana Kannan wrote: > > The current implementation of fw_devlink is very inefficient because it > > trie

Re: [PATCH v1 15/18] of: property: Update implementation of add_links() to create fwnode links

2020-11-06 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 11:51 PM Greg Kroah-Hartman wrote: > > On Thu, Nov 05, 2020 at 11:41:20PM -0800, Saravana Kannan wrote: > > On Thu, Nov 5, 2020 at 11:22 PM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Nov 05, 2020 at 03:25:56PM -0800, Saravana

Re: [PATCH v1 17/18] driver core: Add helper functions to convert fwnode links to device links

2020-11-05 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 11:23 PM Greg Kroah-Hartman wrote: > > On Thu, Nov 05, 2020 at 03:32:05PM -0800, Saravana Kannan wrote: > > On Thu, Nov 5, 2020 at 1:43 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Nov 04, 2020 at 03:23:54PM -0800, Sarav

Re: [PATCH v1 15/18] of: property: Update implementation of add_links() to create fwnode links

2020-11-05 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 11:22 PM Greg Kroah-Hartman wrote: > > On Thu, Nov 05, 2020 at 03:25:56PM -0800, Saravana Kannan wrote: > > On Thu, Nov 5, 2020 at 1:41 AM Greg Kroah-Hartman > > wrote: > > > > > > On Wed, Nov 04, 2020 at 03:23:52PM -0800, Saravana

Re: [PATCH v1 15/18] of: property: Update implementation of add_links() to create fwnode links

2020-11-05 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 3:25 PM Saravana Kannan wrote: > > On Thu, Nov 5, 2020 at 1:41 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Nov 04, 2020 at 03:23:52PM -0800, Saravana Kannan wrote: > > > The semantics of add_links() has changed from creating device link >

Re: [PATCH v1 17/18] driver core: Add helper functions to convert fwnode links to device links

2020-11-05 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 1:43 AM Greg Kroah-Hartman wrote: > > On Wed, Nov 04, 2020 at 03:23:54PM -0800, Saravana Kannan wrote: > > Add helper functions __fw_devlink_link_to_consumers() and > > __fw_devlink_link_to_suppliers() that convert fwnode links t

Re: [PATCH v1 16/18] efi: Update implementation of add_links() to create fwnode links

2020-11-05 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 1:42 AM Greg Kroah-Hartman wrote: > > On Wed, Nov 04, 2020 at 03:23:53PM -0800, Saravana Kannan wrote: > > The semantics of add_links() has changed from creating device link > > between devices to creating fwnode links between fwnodes. So, update the

Re: [PATCH v1 15/18] of: property: Update implementation of add_links() to create fwnode links

2020-11-05 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 1:41 AM Greg Kroah-Hartman wrote: > > On Wed, Nov 04, 2020 at 03:23:52PM -0800, Saravana Kannan wrote: > > The semantics of add_links() has changed from creating device link > > between devices to creating fwnode links between fwnodes. So, update the

Re: [PATCH v1 07/18] driver core: Add fwnode_init()

2020-11-05 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 1:35 AM Greg Kroah-Hartman wrote: > > On Wed, Nov 04, 2020 at 03:23:44PM -0800, Saravana Kannan wrote: > > There are multiple locations in the kernel where a struct fwnode_handle > > is initialized. Add fwnode_init() so that we have one way o

Re: [PATCH v1 01/18] Revert "driver core: Avoid deferred probe due to fw_devlink_pause/resume()"

2020-11-05 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 1:33 AM Greg Kroah-Hartman wrote: > > On Wed, Nov 04, 2020 at 03:23:38PM -0800, Saravana Kannan wrote: > > This reverts commit 2451e746478a6a6e981cfa66b62b791ca93b90c8. > > > > Signed-off-by: Saravana Kannan > > You need to say _why_ you are d

Re: [PATCH v1 2/2] spi: Populate fwnode in of_register_spi_device()

2020-11-05 Thread Saravana Kannan
On Thu, Nov 5, 2020 at 9:12 AM Mark Brown wrote: > > On Wed, Nov 04, 2020 at 12:54:31PM -0800, Saravana Kannan wrote: > > From: Daniel Mentz > > > > This allows the fw_devlink feature to work for spi devices > > too. This avoids unnecessary probe de

Re: [PATCH v1 00/18] Refactor fw_devlink to significantly improve boot time

2020-11-04 Thread Saravana Kannan
On Wed, Nov 4, 2020 at 3:23 PM Saravana Kannan wrote: > > The current implementation of fw_devlink is very inefficient because it > tries to get away without creating fwnode links in the name of saving > memory usage. Past attempts to optimize runtime at the cost of memory > usa

[PATCH v1 00/18] Refactor fw_devlink to significantly improve boot time

2020-11-04 Thread Saravana Kannan
that done. Tomi/Laurent/Grygorii, If you can test this series, that'd be great! Thanks, Saravana [1] - https://lore.kernel.org/linux-pm/CAGETcx-aiW251dhEXT1GNb9bi6YcX8W=jlbrro5cnpuejgl...@mail.gmail.com/ Saravana Kannan (18): Revert "driver core: Avoid deferred probe due to fw_devlink_

[PATCH v1 03/18] Revert "driver core: Don't do deferred probe in parallel with kernel_init thread"

2020-11-04 Thread Saravana Kannan
This reverts commit cec72f3efc6272420c2c2c699607f03d09b93e41. Signed-off-by: Saravana Kannan --- drivers/base/base.h | 1 + drivers/base/core.c | 1 + drivers/base/dd.c | 5 + 3 files changed, 7 insertions(+) diff --git a/drivers/base/base.h b/drivers/base/base.h index 91cfb8405abd

[PATCH v1 09/18] driver core: Allow only unprobed consumers for SYNC_STATE_ONLY device links

2020-11-04 Thread Saravana Kannan
is useless. So, don't allow creating such device links. Signed-off-by: Saravana Kannan --- drivers/base/core.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 1a1d9a55645c..4a0907574646 100644 --- a/drivers/base/core.c +++ b/drivers/base

[PATCH v1 01/18] Revert "driver core: Avoid deferred probe due to fw_devlink_pause/resume()"

2020-11-04 Thread Saravana Kannan
This reverts commit 2451e746478a6a6e981cfa66b62b791ca93b90c8. Signed-off-by: Saravana Kannan --- drivers/base/core.c| 21 - include/linux/device.h | 3 +-- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index

[PATCH v1 11/18] driver core: Redefine the meaning of fwnode_operations.add_links()

2020-11-04 Thread Saravana Kannan
-by: Saravana Kannan --- include/linux/fwnode.h | 42 +++--- 1 file changed, 3 insertions(+), 39 deletions(-) diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index afde643f37a2..ec02e1e939cc 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h

[PATCH v1 10/18] device property: Add fwnode_is_ancestor_of()

2020-11-04 Thread Saravana Kannan
Add a helper function to check if a fwnode is an ancestor of another fwnode. This will be useful for fw_devlink feature. Signed-off-by: Saravana Kannan --- drivers/base/property.c | 27 +++ include/linux/property.h | 2 ++ 2 files changed, 29 insertions(+) diff --git

[PATCH v1 02/18] Revert "driver core: Rename dev_links_info.defer_sync to defer_hook"

2020-11-04 Thread Saravana Kannan
This reverts commit ec7bd78498f29680f536451fbdf9464e851273ed. Signed-off-by: Saravana Kannan --- drivers/base/core.c| 22 +++--- include/linux/device.h | 4 ++-- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index

[PATCH v1 12/18] driver core: Add fw_devlink_parse_fwtree()

2020-11-04 Thread Saravana Kannan
of the fwnodes. This function also ensures that no fwnode is parsed more than once by marking the fwnodes as parsed. Signed-off-by: Saravana Kannan --- drivers/base/core.c| 19 +++ include/linux/fwnode.h | 3 +++ 2 files changed, 22 insertions(+) diff --git a/drivers/base/core.c b

[PATCH v1 07/18] driver core: Add fwnode_init()

2020-11-04 Thread Saravana Kannan
There are multiple locations in the kernel where a struct fwnode_handle is initialized. Add fwnode_init() so that we have one way of initializing a fwnode_handle. Signed-off-by: Saravana Kannan --- drivers/acpi/property.c | 2 +- drivers/acpi/scan.c | 2 +- drivers/base

[PATCH v1 15/18] of: property: Update implementation of add_links() to create fwnode links

2020-11-04 Thread Saravana Kannan
The semantics of add_links() has changed from creating device link between devices to creating fwnode links between fwnodes. So, update the implementation of add_links() to match the new semantics. Signed-off-by: Saravana Kannan --- drivers/of/property.c | 150

[PATCH v1 16/18] efi: Update implementation of add_links() to create fwnode links

2020-11-04 Thread Saravana Kannan
The semantics of add_links() has changed from creating device link between devices to creating fwnode links between fwnodes. So, update the implementation of add_links() to match the new semantics. Signed-off-by: Saravana Kannan --- drivers/firmware/efi/efi-init.c | 23

[PATCH v1 13/18] driver core: Add fwnode_get_next_parent_dev() helper function

2020-11-04 Thread Saravana Kannan
Given a fwnode, this function finds the closest ancestor fwnode that has a corresponding struct device. The function returns this struct device. This function will be used in a subsequent patch in this series. Signed-off-by: Saravana Kannan --- drivers/base/core.c | 25

[PATCH v1 06/18] Revert "driver core: fw_devlink: Add support for batching fwnode parsing"

2020-11-04 Thread Saravana Kannan
This reverts commit 716a7a25969003d82ab738179c3f1068a120ed11. Signed-off-by: Saravana Kannan --- drivers/base/base.h| 1 - drivers/base/core.c| 116 +++-- drivers/base/dd.c | 8 --- include/linux/fwnode.h | 2 - 4 files changed, 7

[PATCH v1 08/18] driver core: Add fwnode link support

2020-11-04 Thread Saravana Kannan
/frameworks to start using them. Signed-off-by: Saravana Kannan --- drivers/base/core.c| 95 ++ drivers/of/dynamic.c | 1 + include/linux/fwnode.h | 14 +++ 3 files changed, 110 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index

[PATCH v1 14/18] driver core: Use device's fwnode to check if it is waiting for suppliers

2020-11-04 Thread Saravana Kannan
check. It checks if the device's fwnode has any fwnode links that haven't been converted to device links yet. Signed-off-by: Saravana Kannan --- drivers/base/core.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c

[PATCH v1 18/18] driver core: Refactor fw_devlink feature

2020-11-04 Thread Saravana Kannan
-by: Saravana Kannan --- drivers/base/core.c| 98 +- include/linux/device.h | 5 --- 2 files changed, 11 insertions(+), 92 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 0c87ff949d81..d76ca59252fb 100644 --- a/drivers/base/core.c +++ b

[PATCH v1 04/18] Revert "driver core: Remove check in driver_deferred_probe_force_trigger()"

2020-11-04 Thread Saravana Kannan
This reverts commit fefcfc968723caf93318613a08e1f3ad07a6154f. Signed-off-by: Saravana Kannan --- drivers/base/dd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 008724f8edf1..ec67b5ffa06d 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c

[PATCH v1 17/18] driver core: Add helper functions to convert fwnode links to device links

2020-11-04 Thread Saravana Kannan
SYNC_STATE_ONLY device links between the newly added device and all the supplier devices of its child device nodes. Signed-off-by: Saravana Kannan --- drivers/base/core.c | 228 1 file changed, 228 insertions(+) diff --git a/drivers/base/core.c b/drivers

[PATCH v1 05/18] Revert "of: platform: Batch fwnode parsing when adding all top level devices"

2020-11-04 Thread Saravana Kannan
This reverts commit 93d2e4322aa74c1ad1e8c2160608eb9a960d69ff. Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index b557a0fcd4ba..79bd5f5a1bf1 100644 --- a/drivers/of/platform.c +++ b

[PATCH v1 2/2] spi: Populate fwnode in of_register_spi_device()

2020-11-04 Thread Saravana Kannan
-off-by: Saravana Kannan --- drivers/spi/spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 0cab239d8e7f..d533aa939cca 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2037,6 +2037,7 @@ of_register_spi_device(struct spi_controller *ctlr

[PATCH v1 1/2] driver core: Fix lockdep warning on wfs_lock

2020-11-04 Thread Saravana Kannan
kn->count); [ 48.847902] lock(wfs_lock); [ 48.848276] [ 48.848276] *** DEADLOCK *** Reported-by: cheng-jui.w...@mediatek.com Signed-off-by: Saravana Kannan --- drivers/base/core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 78114ddac75

Re: Re: [RFC PATCH 0/3] Fix errors on DT overlay removal with devlinks

2020-10-28 Thread Saravana Kannan
On Wed, Oct 28, 2020 at 9:25 AM Michael Auchter wrote: > > Hey Saravana, > > Thanks for taking the time to look into this! > > On Mon, Oct 26, 2020 at 12:10:33PM -0700, Saravana Kannan wrote: > > On Wed, Oct 21, 2020 at 2:02 PM Frank Rowand wrote: > > > >

Re: [PATCH v1] scripts/dev-needs: Add script to list device dependencies

2020-10-27 Thread Saravana Kannan
On Tue, Oct 27, 2020 at 11:09 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Tue, Oct 27, 2020 at 6:31 PM Saravana Kannan wrote: > > On Tue, Oct 27, 2020 at 3:12 AM Geert Uytterhoeven > > wrote: > > > On Wed, Sep 2, 2020 at 12:51 AM Saravana Kannan >

Re: [PATCH v1] scripts/dev-needs: Add script to list device dependencies

2020-10-27 Thread Saravana Kannan
On Tue, Oct 27, 2020 at 3:12 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Wed, Sep 2, 2020 at 12:51 AM Saravana Kannan wrote: > > This script can be useful for: > > - Figuring out the list of modules you need to pack in initrd > > - Figuring out the list of

Re: [PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path

2020-10-26 Thread Saravana Kannan
On Fri, Oct 2, 2020 at 5:14 PM Laurent Pinchart wrote: > > Hi Saravana, > > On Fri, Oct 02, 2020 at 12:56:30PM -0700, Saravana Kannan wrote: > > On Fri, Oct 2, 2020 at 11:35 AM 'Grygorii Strashko' via kernel-team wrote: > > > On 02/10/2020 21:27, Laurent Pinchart wr

Re: [RFC PATCH 0/3] Fix errors on DT overlay removal with devlinks

2020-10-26 Thread Saravana Kannan
On Wed, Oct 21, 2020 at 2:02 PM Frank Rowand wrote: > > Hi Saravana, > > Michael found an issue related to the removal of a devicetree node > which involves devlinks: > > On 10/14/20 2:36 PM, Michael Auchter wrote: > > After updating to v5.9, I've started seeing errors in the kernel log > > when

Re: fw_devlink on will break all snps,dw-apb-gpio users

2020-10-16 Thread Saravana Kannan
On Thu, Oct 15, 2020 at 8:39 PM Jisheng Zhang wrote: > > On Thu, 15 Oct 2020 15:08:33 +0100 > Robin Murphy wrote: > > > > > > > On 2020-10-15 10:52, Jisheng Zhang wrote: > > > On Thu, 15 Oct 2020 01:48:13 -0700 > > > Saravana Kannan wrote: >

Re: [RFC] of/platform: Create device link between simple-mfd and its children

2020-10-15 Thread Saravana Kannan
On Thu, Oct 15, 2020 at 4:43 AM Nicolas Saenz Julienne wrote: > > 'simple-mfd' usage implies there might be some kind of resource sharing > between the parent device and its children. By creating a device link > with DL_FLAG_AUTOREMOVE_CONSUMER we make sure that at no point in time > the parent

Re: fw_devlink on will break all snps,dw-apb-gpio users

2020-10-15 Thread Saravana Kannan
On Thu, Oct 15, 2020 at 1:15 AM Jisheng Zhang wrote: > > On Wed, 14 Oct 2020 22:04:24 -0700 Saravana Kannan wrote: > > > > > > > On Wed, Oct 14, 2020 at 9:02 PM Jisheng Zhang > > wrote: > > > > > > On Wed, 14 O

Re: fw_devlink on will break all snps,dw-apb-gpio users

2020-10-14 Thread Saravana Kannan
On Wed, Oct 14, 2020 at 9:02 PM Jisheng Zhang wrote: > > On Wed, 14 Oct 2020 10:29:36 -0700 > Saravana Kannan wrote: > > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. &g

Re: fw_devlink on will break all snps,dw-apb-gpio users

2020-10-14 Thread Saravana Kannan
On Wed, Oct 14, 2020 at 4:12 AM Jisheng Zhang wrote: > > Hi, > > If set fw_devlink as on, any consumers of dw apb gpio won't probe. > > The related dts looks like: > > gpio0: gpio@2400 { >compatible = "snps,dw-apb-gpio"; >#address-cells = <1>; >#size-cells = <0>; > >

Re: [PATCH 3/3] interconnect: qcom: sc7180: Init BCMs before creating the nodes

2020-10-13 Thread Saravana Kannan
_device *pdev) > } > data->num_nodes = num_nodes; > > - for (i = 0; i < qp->num_bcms; i++) > - qcom_icc_bcm_init(qp->bcms[i], >dev); > - > platform_set_drvdata(pdev, qp); > > return 0; Acked-by: Saravana Kannan -Saravana

Re: [PATCH 2/3] interconnect: qcom: sdm845: Init BCMs before creating the nodes

2020-10-13 Thread Saravana Kannan
_device *pdev) > } > data->num_nodes = num_nodes; > > - for (i = 0; i < qp->num_bcms; i++) > - qcom_icc_bcm_init(qp->bcms[i], >dev); > - > platform_set_drvdata(pdev, qp); > > return 0; Acked-by: Saravana Kannan -Saravana

Re: [PATCH 1/3] interconnect: Aggregate before setting initial bandwidth

2020-10-13 Thread Saravana Kannan
+ if (provider->aggregate) > + provider->aggregate(node, 0, node->init_avg, node->init_peak, > + >avg_bw, >peak_bw); > provider->set(node, node); > node->avg_bw = 0; > node->peak_bw = 0; Acked-by: Saravana Kannan -Saravana

Re: [PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path

2020-10-02 Thread Saravana Kannan
On Fri, Oct 2, 2020 at 11:35 AM 'Grygorii Strashko' via kernel-team wrote: > > hi Saravana, > > On 02/10/2020 21:27, Laurent Pinchart wrote: > > Hi Saravana, > > > > On Fri, Oct 02, 2020 at 10:58:55AM -0700, Saravana Kannan wrote: > >> On Fri, Oct 2,

Re: [PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path

2020-10-02 Thread Saravana Kannan
On Fri, Oct 2, 2020 at 10:55 AM Laurent Pinchart wrote: > > Hi Saravana, > > On Fri, Oct 02, 2020 at 10:51:51AM -0700, Saravana Kannan wrote: > > On Fri, Oct 2, 2020 at 7:08 AM Rob Herring wrote: > > > On Thu, Oct 1, 2020 at 5:59 PM Saravana Kannan > > >

Re: [PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path

2020-10-02 Thread Saravana Kannan
On Fri, Oct 2, 2020 at 7:08 AM Rob Herring wrote: > > On Thu, Oct 1, 2020 at 5:59 PM Saravana Kannan wrote: > > > > When commit 93d2e4322aa7 ("of: platform: Batch fwnode parsing when > > adding all top level devices") optimized the fwnode parsing when a

Re: [PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path

2020-10-02 Thread Saravana Kannan
patch. > >> > >> On Thu, Oct 01, 2020 at 03:59:51PM -0700, Saravana Kannan wrote: > >>> When commit 93d2e4322aa7 ("of: platform: Batch fwnode parsing when > >>> adding all top level devices") optimized the fwnode parsing when all top > >>>

[PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path

2020-10-01 Thread Saravana Kannan
ommit does the optimization for all paths by simply moving the fw_devlink_pause/resume() inside of_platform_default_populate(). Reported-by: Tomi Valkeinen Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-)

Re: [PATCH v4 31/52] docs: device_link.rst: remove duplicated kernel-doc include

2020-09-30 Thread Saravana Kannan
On Wed, Sep 30, 2020 at 6:25 AM Mauro Carvalho Chehab wrote: > > The infrastructure.rst file already includes the external > symbols from drivers/base/core.c. > > Duplicating 3 functions there causes namespace collisions: > > Documentation/driver-api/device_link.rst: WARNING: Duplicate C

Re: [PATCH v3 0/3] Add interconnect sync state support

2020-09-17 Thread Saravana Kannan
Reviewed-by: Saravana Kannan to all 3 patches in the series. -Saravana On Tue, Aug 25, 2020 at 10:01 AM Georgi Djakov wrote: > > Bootloaders often leave some system resources enabled such as clocks, > regulators, interconnects etc. We want to keep these resources enabled &g

[PATCH v1] scripts/dev-needs: Add script to list device dependencies

2020-09-01 Thread Saravana Kannan
king probe dependencies. Signed-off-by: Saravana Kannan --- MAINTAINERS | 6 + scripts/dev-needs.sh | 315 +++ 2 files changed, 321 insertions(+) create mode 100755 scripts/dev-needs.sh diff --git a/MAINTAINERS b/MAINTAI

[PATCH v2] driver core: Fix device_pm_lock() locking for device links

2020-09-01 Thread Saravana Kannan
ckdep splat. Fixes: 843e600b8a2b ("driver core: Fix sleeping in invalid context during device link deletion") [1] - https://lore.kernel.org/lkml/CAA+hA=S4eAreb7vo69LAXSk2t5=deknxhaiy1wspk4xtp9u...@mail.gmail.com/ Reported-by: Dong Aisheng Signed-off-by: Saravana Kannan --- Cc'ing everyon

Re: Lockdep warning caused by "driver core: Fix sleeping in invalid context during device link deletion"

2020-09-01 Thread Saravana Kannan
On Mon, Aug 31, 2020 at 11:07 PM Peng Fan wrote: > > > Subject: Re: Lockdep warning caused by "driver core: Fix sleeping in invalid > > context during device link deletion" > > > > On Wed, Aug 26, 2020 at 10:17 PM Saravana Kannan > > wrote: >

Re: Lockdep warning caused by "driver core: Fix sleeping in invalid context during device link deletion"

2020-08-31 Thread Saravana Kannan
On Wed, Aug 26, 2020 at 10:17 PM Saravana Kannan wrote: > > On Thu, Aug 20, 2020 at 8:50 PM Dong Aisheng wrote: > > > > Hi ALL, > > > > We met the below WARNING during system suspend on an iMX6Q SDB board > > with the latest linus/master branch (v5.9-rc1+

[PATCH v1] driver core: Fix device_pm_lock() locking for device links

2020-08-31 Thread Saravana Kannan
://lore.kernel.org/lkml/CAA+hA=S4eAreb7vo69LAXSk2t5=deknxhaiy1wspk4xtp9u...@mail.gmail.com/ Reported-by: Dong Aisheng Signed-off-by: Saravana Kannan --- Rafael, A bigger question I had is why we need to grab device_pm_lock() around device_link_del() in the first place. I understand the need to

Re: Lockdep warning caused by "driver core: Fix sleeping in invalid context during device link deletion"

2020-08-26 Thread Saravana Kannan
On Thu, Aug 20, 2020 at 8:50 PM Dong Aisheng wrote: > > Hi ALL, > > We met the below WARNING during system suspend on an iMX6Q SDB board > with the latest linus/master branch (v5.9-rc1+) and next-20200820. > v5.8 kernel is ok. So i did bisect and finally found it's caused by > the patch below. >

Re: Lockdep warning caused by "driver core: Fix sleeping in invalid context during device link deletion"

2020-08-21 Thread Saravana Kannan
e() code path. If anyone has a fix, I'd be happy to review. -Saravana > Defconfig used is: imx_v6_v7_defconfig > > commit 843e600b8a2b01463c4d873a90b2c2ea8033f1f6 > Author: Saravana Kannan > Date: Thu Jul 16 14:45:23 2020 -0700 > > driver core: Fix sleeping in invalid

Re: [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver"

2020-08-20 Thread Saravana Kannan
On Thu, Aug 20, 2020 at 7:53 AM Marc Zyngier wrote: > > On 2020-08-20 09:07, Saravana Kannan wrote: > > On Thu, Aug 20, 2020 at 12:56 AM Marc Zyngier wrote: > >> > >> On 2020-08-19 19:51, Saravana Kannan wrote: > >> > On Wed, Aug 19, 2020

Re: [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver"

2020-08-20 Thread Saravana Kannan
On Thu, Aug 20, 2020 at 12:56 AM Marc Zyngier wrote: > > On 2020-08-19 19:51, Saravana Kannan wrote: > > On Wed, Aug 19, 2020 at 9:52 AM Frank Wunderlich > > wrote: > >> > >> hi, > >> > >> does the fix you've linked to my

Re: [driver core] e2ae9bcc4a: unixbench.score -2.2% regression

2020-08-19 Thread Saravana Kannan
On Wed, Aug 19, 2020 at 12:06 AM kernel test robot wrote: > > Greeting, > > FYI, we noticed a -2.2% regression of unixbench.score due to commit: > > > commit: e2ae9bcc4aaacda04edb75c4eea93384719efaa5 ("driver core: Add support > for linking devices during device addition") >

Re: [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver"

2020-08-19 Thread Saravana Kannan
On Wed, Aug 19, 2020 at 9:52 AM Frank Wunderlich wrote: > > hi, > > does the fix you've linked to my revert [1] not work in your case? > > [1] https://patchwork.kernel.org/patch/11718481/ Thanks for pointing it out Frank. Also, might want to avoid top posting in the future. Enric, Can you

Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-18 Thread Saravana Kannan
On Tue, Aug 18, 2020 at 10:34 AM Marc Zyngier wrote: > > On 2020-08-18 15:23, Rob Herring wrote: > > On Tue, Aug 18, 2020 at 1:35 AM Marc Zyngier wrote: > >> > >> On 2020-08-17 17:12, Rob Herring wrote: > >> > On Sun, Aug 16, 2020 at 4:40 AM Marc Zyngier wrote: > >> >> > >> >> On Sun, 16 Aug

Re: [RFC][PATCH] tty: serial: qcom_geni_serial: Drop __init from qcom_geni_console_setup

2020-08-11 Thread Saravana Kannan
gt; [7.216432] ret_from_fork+0x10/0x18 > [7.220049] Code: bad PC value > [7.223139] ---[ end trace 73f3b21e251d5a70 ]--- > > Thus this patch removes the __init avoiding crash in such > configs. > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Greg Kroah-Hartman

Re: Regression: serial crash on db845c using modular config w/ 5.9-rc

2020-08-10 Thread Saravana Kannan
On Mon, Aug 10, 2020 at 5:31 PM John Stultz wrote: > > When testing with modular configs w/ mainline on db845c, I've been > running into an early boot crash (nothing on the console - but serial > drivers as built as modules - so not surprising). After setting the > CONFIG_SERIAL_QCOM_GENI=y

Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-07 Thread Saravana Kannan
at 5:43 PM Bjorn Andersson > > > > wrote: > > > > > On Wed 05 Aug 14:57 PDT 2020, John Stultz wrote: > > > > > > On Wed, Aug 5, 2020 at 2:47 PM Steev Klimaszewski > > > > > > wrote: > > > > > > > On 8/5/20 4:1

Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-06 Thread Saravana Kannan
On Thu, Aug 6, 2020 at 8:09 PM John Stultz wrote: > > On Thu, Aug 6, 2020 at 8:02 PM Saravana Kannan wrote: > > On Thu, Aug 6, 2020 at 7:49 PM John Stultz wrote: > > > On Thu, Aug 6, 2020 at 6:42 PM Bjorn Andersson > > > wrote: > > > > With all

Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-06 Thread Saravana Kannan
Wed 05 Aug 14:57 PDT 2020, John Stultz wrote: > > > > > On Wed, Aug 5, 2020 at 2:47 PM Steev Klimaszewski > > > > > wrote: > > > > > > On 8/5/20 4:16 PM, Steev Klimaszewski wrote: > > > > > > > On 8/5/20

Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-06 Thread Saravana Kannan
On Thu, Aug 6, 2020 at 1:31 PM Marc Zyngier wrote: > > On 2020-08-06 21:09, John Stultz wrote: > > On Thu, Aug 6, 2020 at 12:59 PM Marc Zyngier wrote: > >> OK, thanks for confirming. It would have been good if these patches > >> had seen a bit more testing. > > > > Yes, again, my apologies for

Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-06 Thread Saravana Kannan
On Thu, Aug 6, 2020 at 5:12 AM Marc Zyngier wrote: > > On 2020-08-06 02:24, John Stultz wrote: > > On Wed, Aug 5, 2020 at 1:19 PM Saravana Kannan > > wrote: > >> On Wed, Aug 5, 2020 at 12:44 AM John Stultz > >> wrote: > >> > On Fri, Jul 17

Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros

2020-08-05 Thread Saravana Kannan
On Wed, Aug 5, 2020 at 12:44 AM John Stultz wrote: > > On Fri, Jul 17, 2020 at 5:06 PM Saravana Kannan wrote: > > > > Switch the driver to use the helper macros. In addition to reducing the > > number of lines, this also adds module unload protection (if the driver >

Re: [PATCH v2 1/2] interconnect: Add sync state support

2020-07-30 Thread Saravana Kannan
On Mon, Jul 27, 2020 at 11:18 PM Mike Tipton wrote: > > On 7/22/2020 10:07 AM, Saravana Kannan wrote: > > On Wed, Jul 22, 2020 at 4:01 AM Georgi Djakov > > wrote: > >> > >> The bootloaders often do some initial configuration of the interconnects &g

Re: [PATCH v1 2/2] timer: mt6873: porting Mediatek timer driver to loadable module

2020-07-29 Thread Saravana Kannan
On Wed, Jul 29, 2020 at 6:02 AM Thomas Gleixner wrote: > > Freddy, > > Freddy Hsin writes: > > again, please be more careful with subject lines. git log $FILE will > give you a hint. > > > porting Mediatek timer driver to loadable module > > Repeating the sentence in the subject line is not

Re: [PATCH v3 3/4] regulator: core: Add basic enable/disable support for sync_state() callbacks

2020-07-28 Thread Saravana Kannan
On Tue, Jul 21, 2020 at 1:18 PM Mark Brown wrote: > Hi Mark, It *might* be easier if you jump to the bottom and read the reasoning for the current design. The stuff in between is just me trying to clarify some misunderstandings. > On Mon, Jul 20, 2020 at 08:22:15PM -0700, Saravana Kannan

Re: [PATCH v1] driver core: Change delimiter in devlink device's name to "--"

2020-07-27 Thread Saravana Kannan
On Mon, Jul 27, 2020 at 7:21 AM Rafael J. Wysocki wrote: > > On Fri, Jul 24, 2020 at 8:05 PM Saravana Kannan wrote: > > > > The devlink device name is of the form "supplier:consumer". But ":" is > > fairly common in device names and makes it visually h

Re: [PATCH v3 0/4] irqchip: Add IRQCHIP_PLATFORM_DRIVER helper macros

2020-07-25 Thread Saravana Kannan
On Sat, Jul 25, 2020 at 7:23 AM Marc Zyngier wrote: > > On Fri, 17 Jul 2020 17:06:33 -0700, Saravana Kannan wrote: > > Made a series out of the previous v2 patch + some example uses of the > > macros. > > > > Not sure if the MTK changes work (just compile t

[PATCH v2 1/2] of: property: Add device link support for multiple DT bindings

2020-07-24 Thread Saravana Kannan
Add support for creating device links out of the following DT bindings: - interrupts-extended - nvmem-cells - phys - wakeup-parent Signed-off-by: Saravana Kannan --- v1->v2: No changes. Just sending again because v2 has changes in Patch 2/2. drivers/of/property.c | 9 + 1 file chan

[PATCH v2 2/2] of: property: Add device link support for pinctrl-0 through pinctrl-8

2020-07-24 Thread Saravana Kannan
-by: Saravana Kannan --- v1->v2: - Clarified in commit text that pinctrl-8 is the max found in the dts files. drivers/of/property.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index b06edeb1f88b..d40d923ffeaf 100644 --- a/driv

[PATCH v1] driver core: Change delimiter in devlink device's name to "--"

2020-07-24 Thread Saravana Kannan
The devlink device name is of the form "supplier:consumer". But ":" is fairly common in device names and makes it visually hard to distinguish supplier and consumer. So, replace it with "--" to make it easier. Signed-off-by: Saravana Kannan --- Documentation/ABI/t

Re: [PATCH v3 4/4] irqchip/mtk-cirq: Convert to a platform driver

2020-07-23 Thread Saravana Kannan
On Thu, Jul 23, 2020 at 4:46 AM Hanks Chen wrote: > > On Fri, 2020-07-17 at 17:06 -0700, Saravana Kannan wrote: > > This driver can work as a platform driver. So covert it to a platform > > driver. > > > > Signed-off-by: Saravana Kannan > > --- > > driv

Re: [PATCH v1 2/2] of: property: Add device link support for pinctrl-0 through pinctrl-8

2020-07-22 Thread Saravana Kannan
On Wed, Jul 22, 2020 at 2:09 PM Rob Herring wrote: > > On Wed, Jul 22, 2020 at 2:13 PM Saravana Kannan wrote: > > > > Add support for pinctrl-0 through pinctrl-8 explicitly instead of trying > > to add support for pinctrl-%d properties. > > > > Of all the pinc

Re: [PATCH v1 2/2] of: property: Add device link support for pinctrl-0 through pinctrl-8

2020-07-22 Thread Saravana Kannan
On Wed, Jul 22, 2020 at 1:56 PM Frank Rowand wrote: > > On 2020-07-22 15:13, Saravana Kannan wrote: > > Add support for pinctrl-0 through pinctrl-8 explicitly instead of trying > > to add support for pinctrl-%d properties. > > > > Of all the pinctrl-* properties

[PATCH v1 2/2] of: property: Add device link support for pinctrl-0 through pinctrl-8

2020-07-22 Thread Saravana Kannan
to parse all pinctrl-* properties and checking for pinctrl-%d is unnecessarily complicated. So, just add support for pinctrl-[0-8] for now. In the unlikely event we ever exceed pinctrl-8, we can come back and improve this. Signed-off-by: Saravana Kannan --- drivers/of/property.c | 18

<    1   2   3   4   5   6   7   8   9   10   >