[PATCH v2 1/4] driver core: Remove unnecessary is_fwnode_dev variable in device_add()

2020-05-19 Thread Saravana Kannan
That variable is no longer necessary. Remove it and also fix a minor typo in comments. Signed-off-by: Saravana Kannan --- drivers/base/core.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index f804e561e0a2

[PATCH v2 3/4] driver core: Add state_synced sysfs file for devices that support it

2020-05-19 Thread Saravana Kannan
enabled because they were left enabled by the bootloader and all its consumers haven't probed yet. Signed-off-by: Saravana Kannan --- .../ABI/testing/sysfs-devices-state_synced| 24 +++ drivers/base/dd.c | 22 + 2 files changed, 46

[PATCH v2 0/4] driver core: Add device link related sysfs files

2020-05-19 Thread Saravana Kannan
ore. Patch 4/4 - New patch Saravana Kannan (4): driver core: Remove unnecessary is_fwnode_dev variable in device_add() driver core: Expose device link details in sysfs driver core: Add state_synced sysfs file for devices that support it driver core: Add waiting_for_supplier sysfs f

Re: [PATCH v8 09/10] dt-bindings: interconnect: Add interconnect-tags bindings

2020-05-19 Thread Saravana Kannan
On Tue, May 19, 2020 at 11:58 AM Rob Herring wrote: > > On Tue, May 12, 2020 at 03:53:26PM +0300, Georgi Djakov wrote: > > From: Sibi Sankar > > > > Add interconnect-tags bindings to enable passing of optional > > tag information to the interconnect framework. > > > > Signed-off-by: Sibi Sankar

Re: [PATCH v1 4/4] of: platform: Batch fwnode parsing when adding all top level devices

2020-05-19 Thread Saravana Kannan
On Tue, May 19, 2020 at 3:32 AM Marek Szyprowski wrote: > > Hi > > On 19.05.2020 09:11, Marek Szyprowski wrote: > > On 19.05.2020 08:48, Saravana Kannan wrote: > >> On Mon, May 18, 2020 at 11:25 PM Marek Szyprowski > >> wrote: > >>

Re: [PATCH v1 4/4] of: platform: Batch fwnode parsing when adding all top level devices

2020-05-19 Thread Saravana Kannan
On Mon, May 18, 2020 at 11:25 PM Marek Szyprowski wrote: > > Hi Saravana, > > On 15.05.2020 07:35, Saravana Kannan wrote: > > The fw_devlink_pause() and fw_devlink_resume() APIs allow batching the > > parsing of the device tree nodes when a lot of devices are added. Thi

[PATCH v3] driver core: Fix SYNC_STATE_ONLY device link implementation

2020-05-19 Thread Saravana Kannan
device link support for SYNC_STATE_ONLY flag") Signed-off-by: Saravana Kannan --- v3: - Added this changelog text v2: - Delete DL_FLAG_SYNC_STATE_ONLY device links on consumer probe - Set DL_FLAG_STATELESS correct when added to an existing DL_FLAG_SYNC_STATE_ONLY device link. v1: - Add

[PATCH v2] driver core: Fix SYNC_STATE_ONLY device link implementation

2020-05-18 Thread Saravana Kannan
device link support for SYNC_STATE_ONLY flag") Signed-off-by: Saravana Kannan --- drivers/base/core.c | 61 + 1 file changed, 39 insertions(+), 22 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 84c569726d75..f804e561e0a

Re: [PATCH v1] driver core: Fix memory leak when adding SYNC_STATE_ONLY device links

2020-05-18 Thread Saravana Kannan
On Mon, May 18, 2020 at 1:03 AM Greg Kroah-Hartman wrote: > > On Mon, May 18, 2020 at 12:48:42AM -0700, Saravana Kannan wrote: > > On Sat, May 16, 2020 at 1:07 AM Saravana Kannan > > wrote: > > > > > > When SYNC_STATE_ONLY support was added in commit 05ef983e

Re: [PATCH v1] driver core: Fix memory leak when adding SYNC_STATE_ONLY device links

2020-05-18 Thread Saravana Kannan
On Sat, May 16, 2020 at 1:07 AM Saravana Kannan wrote: > > When SYNC_STATE_ONLY support was added in commit 05ef983e0d65 ("driver > core: Add device link support for SYNC_STATE_ONLY flag"), > device_link_add() incorrectly skipped adding the new SYNC_STATE_ONLY > devi

[RFC PATCH v1] driver core: Expose device link details in sysfs

2020-05-18 Thread Saravana Kannan
to expand it to "state", etc once the overall idea is accepted. Signed-off-by: Saravana Kannan --- Greg/Rafael, Wanted to check if both of you are okay with the overall idea of exporting device link details through sysfs and if using a "struct device" is how you'd like to do it.

[PATCH v1] driver core: Remove check in driver_deferred_probe_force_trigger()

2020-05-17 Thread Saravana Kannan
6a7a259690 ("driver core: fw_devlink: Add support for batching fwnode parsing") Signed-off-by: Saravana Kannan --- drivers/base/dd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 63991d97adcc..9a1d940342ac 100644 --- a/drivers/base/dd.c +++

[PATCH v1] driver core: Fix memory leak when adding SYNC_STATE_ONLY device links

2020-05-16 Thread Saravana Kannan
d and returned. This can cause memory leaks in conjunction with fw_devlinks. Cc: sta...@vger.kernel.org Fixes: 05ef983e0d65 ("driver core: Add device link support for SYNC_STATE_ONLY flag") Signed-off-by: Saravana Kannan --- drivers/base/core.c | 9 + 1 file changed, 5 i

Re: [PATCH v1 0/4] Optimize fw_devlink parsing

2020-05-15 Thread Saravana Kannan
On Thu, May 14, 2020 at 10:35 PM Saravana Kannan wrote: > > When fw_devlink is enabled on hardware with a large number of device > tree nodes, the initial device addition done in > of_platform_default_populate_init() can be very inefficient. This is > because most devices will f

[PATCH v1 3/4] driver core: fw_devlink: Add support for batching fwnode parsing

2020-05-14 Thread Saravana Kannan
adds fw_devlink_pause() and fw_devlink_resume() to allow doing this. Signed-off-by: Saravana Kannan --- drivers/base/base.h| 1 + drivers/base/core.c| 116 ++--- drivers/base/dd.c | 8 +++ include/linux/fwnode.h | 2 + 4 files changed, 120

[PATCH v1 2/4] driver core: Look for waiting consumers only for a fwnode's primary device

2020-05-14 Thread Saravana Kannan
ing to see if devices waiting for suppliers might want to link to a fwnode's secondary device. This commit removes that unnecessary step for devices that aren't a fwnode's primary device and also moves the code to a more appropriate part of the file. Signed-off-by: Saravana Kannan --- drivers/b

[PATCH v1 4/4] of: platform: Batch fwnode parsing when adding all top level devices

2020-05-14 Thread Saravana Kannan
in a system. Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 3371e4a06248..55d719347810 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -538,7 +538,9 @@ static int

[PATCH v1 1/4] driver core: Move code to the right part of the file

2020-05-14 Thread Saravana Kannan
This commit just moves around code to match the general organization of the file. Signed-off-by: Saravana Kannan --- drivers/base/core.c | 60 ++--- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c

[PATCH v1 0/4] Optimize fw_devlink parsing

2020-05-14 Thread Saravana Kannan
second. Thanks, Saravana P.S: It took me longer to write the comments than the code! Saravana Kannan (4): driver core: Move code to the right part of the file driver core: Look for waiting consumers only for a fwnode's primary device driver core: fw_devlink: Add support for batching

Re: [PATCH v1] driver core: Add state_synced sysfs file for devices that support it

2020-05-13 Thread Saravana Kannan
On Wed, May 13, 2020 at 1:34 AM Saravana Kannan wrote: > > On Wed, May 13, 2020 at 1:22 AM Greg Kroah-Hartman > wrote: > > > > On Tue, May 12, 2020 at 06:34:15PM -0700, Saravana Kannan wrote: > > > This can be used to check if a device supports sync_state() callb

Re: [PATCH v1] driver core: Add state_synced sysfs file for devices that support it

2020-05-13 Thread Saravana Kannan
On Wed, May 13, 2020 at 1:22 AM Greg Kroah-Hartman wrote: > > On Tue, May 12, 2020 at 06:34:15PM -0700, Saravana Kannan wrote: > > This can be used to check if a device supports sync_state() callbacks > > and therefore keeps resources left on by the bootloader enabled till all

[PATCH v1] driver core: Add state_synced sysfs file for devices that support it

2020-05-12 Thread Saravana Kannan
enabled because they were left enabled by the bootloader and all its consumers haven't probed yet. Signed-off-by: Saravana Kannan --- .../ABI/testing/sysfs-devices-state_synced| 24 +++ drivers/base/dd.c | 16 + 2 files changed, 40

Re: [PATCH 1/2] slimbus: core: Set fwnode for a device when setting of_node

2020-05-11 Thread Saravana Kannan
On Mon, May 11, 2020 at 8:13 AM Srinivas Kandagatla wrote: > > From: Saravana Kannan > > When setting the of_node for a newly created device, also set the > fwnode. This allows fw_devlink feature to work for slimbus devices. > > Also, remove some unnecessary NULL

Re: [PATCH 2/2] slimbus: core: Fix mismatch in of_node_get/put

2020-05-11 Thread Saravana Kannan
On Mon, May 11, 2020 at 8:13 AM Srinivas Kandagatla wrote: > > From: Saravana Kannan > > Adding missing corresponding of_node_put > > Fixes: 7588a511bdb4 ("slimbus: core: add support to device tree helper") > Signed-off-by: Saravana Kannan > [Srini: a

Re: [PATCH v4 07/12] OPP: Add and export helper to get icc path count

2020-05-04 Thread Saravana Kannan
On Mon, May 4, 2020 at 1:24 PM Sibi Sankar wrote: > > Add and export 'dev_pm_opp_get_path_count' to get the icc path count > associated with the device. This is not related to OPP. You should add this helper function to ICC framework? -Saravana

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-05-04 Thread Saravana Kannan
On Sun, May 3, 2020 at 10:00 PM Viresh Kumar wrote: > > On 30-04-20, 09:32, Saravana Kannan wrote: > > You are missing the point. This is not about aggregation. This is > > about OPP voting for bandwidth on a path when the vote can/should be > > 0. > > > >

Re: [RFC PATCH v1] irqchip: Add IRQCHIP_MODULE_BEGIN/END helper macros

2020-05-01 Thread Saravana Kannan
On Fri, May 1, 2020 at 1:48 AM Marc Zyngier wrote: > > On 2020-04-29 20:04, Saravana Kannan wrote: > > On Wed, Apr 29, 2020 at 2:28 AM Marc Zyngier wrote: > > [...] > > >> One thing though: this seems to be exclusively DT driven. Have you > >> looked

Re: [PATCH 1/2] drivers/clocksource/timer-of: Remove __init markings

2020-04-30 Thread Saravana Kannan
On Thu, Apr 30, 2020 at 5:57 AM Ulf Hansson wrote: > > On Tue, 28 Apr 2020 at 20:55, Daniel Lezcano > wrote: > > > > On 28/04/2020 20:23, Saravana Kannan wrote: > > > On Tue, Apr 28, 2020 at 12:02 AM Daniel Lezcano > > > wrote: > > >> >

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-04-30 Thread Saravana Kannan
On Thu, Apr 30, 2020 at 12:54 AM Viresh Kumar wrote: > > On 30-04-20, 00:35, Saravana Kannan wrote: > > On Wed, Apr 29, 2020 at 11:09 PM Viresh Kumar > > wrote: > > > > > > On 24-04-20, 14:18, Saravana Kannan wrote: > > > > My only comment is -

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-04-30 Thread Saravana Kannan
On Wed, Apr 29, 2020 at 11:09 PM Viresh Kumar wrote: > > On 24-04-20, 14:18, Saravana Kannan wrote: > > My only comment is -- can we drop this patch please? I'd like to use > > devfreq governors for voting on bandwidth and this will effectively > > override whatever band

Re: [RFC PATCH v1] irqchip: Add IRQCHIP_MODULE_BEGIN/END helper macros

2020-04-29 Thread Saravana Kannan
On Wed, Apr 29, 2020 at 2:28 AM Marc Zyngier wrote: > > Hi Saravana, > > Sorry for the delay replying. No worries. > On Mon, 13 Apr 2020 15:43:31 -0700 > Saravana Kannan wrote: > > > On Mon, Apr 13, 2020 at 3:13 PM John Stultz wrote: > > > > > >

[PATCH v1] Revert "Revert "driver core: Set fw_devlink to "permissive" behavior by default""

2020-04-28 Thread Saravana Kannan
mail.com/T/#m2408a6ce098b2ebf583ca8534329695923ae57fe Tested-by: Marek Szyprowski Signed-off-by: Saravana Kannan --- Greg, Can you please queue this for 5.8? Thanks, Saravana drivers/base/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/core.c b/drivers/b

Re: [PATCH v1] driver core: Fix handling of fw_devlink=permissive

2020-04-28 Thread Saravana Kannan
On Tue, Apr 28, 2020 at 8:52 AM Greg Kroah-Hartman wrote: > > On Thu, Apr 16, 2020 at 11:25:47AM -0700, Saravana Kannan wrote: > > On Tue, Mar 31, 2020 at 12:29 AM Greg Kroah-Hartman > > wrote: > > > > > > On Mon, Mar 30, 2020 at 11:18:01PM -0700, Saravana

Re: [PATCH 1/2] drivers/clocksource/timer-of: Remove __init markings

2020-04-28 Thread Saravana Kannan
On Tue, Apr 28, 2020 at 12:02 AM Daniel Lezcano wrote: > > > Hi Saravana, You were replying to Sandeep :) > On 28/04/2020 00:17, Sandeep Patil wrote: > > Hi Daniel, > > > > On Mon, Apr 27, 2020 at 10:50:24PM +0200, Daniel Lezcano wrote: > >> On

[RFC PATCH] interconnect: Replace of_icc_get() with icc_get() and reduce DT binding

2019-10-08 Thread Saravana Kannan
Quoting Stephen Boyd: > Quoting David Dai (2019-09-27 10:16:07) > > On 9/25/2019 6:28 AM, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2019-09-24 22:59:33) > > >> On Tue 24 Sep 22:41 PDT 2019, Stephen Boyd wrote: > > >> > > >>> The DT binding could also be simplified somewhat. Currently a

[PATCH v11 5/6] of/platform: Pause/resume sync state during init and of_platform_populate()

2019-09-04 Thread Saravana Kannan
called prematurely, pause and resume sync_state() callbacks across of_platform_populate(). Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index b47a2292fe8e..d93891a05f60 100644

[PATCH v11 3/6] of: property: Add functional dependency link from DT bindings

2019-09-04 Thread Saravana Kannan
d test robot Signed-off-by: Saravana Kannan --- .../admin-guide/kernel-parameters.rst | 1 + .../admin-guide/kernel-parameters.txt | 6 + drivers/of/property.c | 241 ++ 3 files changed, 248 insertions(+) diff --git a/Documentatio

[PATCH v11 4/6] driver core: Add sync_state driver/bus callback

2019-09-04 Thread Saravana Kannan
reported missing documentation for device.state_synced Reported-by: kbuild test robot Signed-off-by: Saravana Kannan --- drivers/base/core.c| 72 ++ include/linux/device.h | 24 ++ 2 files changed, 96 insertions(+) diff --git a/drivers

Re: Adding depends-on DT binding to break cyclic dependencies

2019-08-30 Thread Saravana Kannan
On Fri, Aug 30, 2019 at 5:32 PM Saravana Kannan wrote: > > On Fri, Aug 30, 2019 at 7:35 AM Rob Herring wrote: > > > > On Thu, Aug 29, 2019 at 11:58 PM Saravana Kannan > > wrote: > > > > > > On Thu, Aug 29, 2019 at 9:28 AM Rob Herring wrote: >

Re: Adding depends-on DT binding to break cyclic dependencies

2019-08-30 Thread Saravana Kannan
On Fri, Aug 30, 2019 at 7:35 AM Rob Herring wrote: > > On Thu, Aug 29, 2019 at 11:58 PM Saravana Kannan wrote: > > > > On Thu, Aug 29, 2019 at 9:28 AM Rob Herring wrote: > > > > > > On Thu, Aug 22, 2019 at 1:55 AM Saravana Kannan > > > wrote:

Re: Adding depends-on DT binding to break cyclic dependencies

2019-08-29 Thread Saravana Kannan
On Thu, Aug 29, 2019 at 9:28 AM Rob Herring wrote: > > On Thu, Aug 22, 2019 at 1:55 AM Saravana Kannan wrote: > > > > Hi Rob, > > > > Frank, Greg and I got together during ELC and had an extensive and > > very productive discussion about my "postboot su

Re: Adding depends-on DT binding to break cyclic dependencies

2019-08-27 Thread Saravana Kannan
On Wed, Aug 21, 2019 at 11:54 PM Saravana Kannan wrote: > > Hi Rob, > > Frank, Greg and I got together during ELC and had an extensive and > very productive discussion about my "postboot supplier state cleanup" > patch series [1]. The three of us are on the s

Re: [PATCH v5 1/3] dt-bindings: opp: Introduce opp-peak-kBps and opp-avg-kBps bindings

2019-08-26 Thread Saravana Kannan
On Wed, Aug 21, 2019 at 1:33 PM Rob Herring wrote: > > On Wed, 7 Aug 2019 15:31:09 -0700, Saravana Kannan wrote: > > Interconnects often quantify their performance points in terms of > > bandwidth. So, add opp-peak-kBps (required) and opp-avg-kBps (optional) to > > allow

Adding depends-on DT binding to break cyclic dependencies

2019-08-22 Thread Saravana Kannan
Hi Rob, Frank, Greg and I got together during ELC and had an extensive and very productive discussion about my "postboot supplier state cleanup" patch series [1]. The three of us are on the same page now -- the series as it stands is the direction we want to go in, with some minor refactoring,

Re: [PATCH v7 1/7] driver core: Add support for linking devices during device addition

2019-08-20 Thread Saravana Kannan
On Tue, Aug 20, 2019 at 6:07 PM Frank Rowand wrote: > > On 8/20/19 3:10 PM, Saravana Kannan wrote: > > On Mon, Aug 19, 2019 at 9:25 PM Frank Rowand wrote: > >> > >> On 8/19/19 5:00 PM, Saravana Kannan wrote: > >>> On Sun, Aug 18, 2019 at 8:38 PM Frank R

Re: [PATCH v7 1/7] driver core: Add support for linking devices during device addition

2019-08-20 Thread Saravana Kannan
On Tue, Aug 20, 2019 at 6:56 PM Greg Kroah-Hartman wrote: > > On Tue, Aug 20, 2019 at 06:06:55PM -0700, Frank Rowand wrote: > > On 8/20/19 3:10 PM, Saravana Kannan wrote: > > > On Mon, Aug 19, 2019 at 9:25 PM Frank Rowand > > > wrote: > > >> > &

Re: [PATCH v5 2/3] OPP: Add support for bandwidth OPP tables

2019-08-20 Thread Saravana Kannan
On Tue, Aug 20, 2019 at 3:27 PM Saravana Kannan wrote: > > On Mon, Aug 19, 2019 at 11:13 PM Viresh Kumar wrote: > > > > On 07-08-19, 15:31, Saravana Kannan wrote: > > > + ret = of_property_read_u32(np, "opp-peak-kBps", ); > > >

Re: [PATCH v5 2/3] OPP: Add support for bandwidth OPP tables

2019-08-20 Thread Saravana Kannan
On Fri, Aug 16, 2019 at 11:21 AM Stephen Boyd wrote: > > Quoting Saravana Kannan (2019-08-07 15:31:10) > > diff --git a/drivers/opp/of.c b/drivers/opp/of.c > > index 1813f5ad5fa2..e1750033fef9 100644 > > --- a/drivers/opp/of.c > > +++ b/drivers/opp/of.c

Re: [PATCH v5 2/3] OPP: Add support for bandwidth OPP tables

2019-08-20 Thread Saravana Kannan
On Mon, Aug 19, 2019 at 11:13 PM Viresh Kumar wrote: > > On 07-08-19, 15:31, Saravana Kannan wrote: > > Not all devices quantify their performance points in terms of frequency. > > Devices like interconnects quantify their performance points in terms of > > bandwidth. We

Re: [PATCH v7 1/7] driver core: Add support for linking devices during device addition

2019-08-20 Thread Saravana Kannan
On Mon, Aug 19, 2019 at 9:25 PM Frank Rowand wrote: > > On 8/19/19 5:00 PM, Saravana Kannan wrote: > > On Sun, Aug 18, 2019 at 8:38 PM Frank Rowand wrote: > >> > >> On 8/15/19 6:50 PM, Saravana Kannan wrote: > >>> On Wed, Aug 7, 2019 at 7:04 PM Frank

Re: [PATCH v7 3/7] of/platform: Add functional dependency link from DT bindings

2019-08-19 Thread Saravana Kannan
On Mon, Aug 19, 2019 at 2:30 PM Frank Rowand wrote: > > On 8/19/19 1:49 PM, Saravana Kannan wrote: > > On Mon, Aug 19, 2019 at 10:16 AM Frank Rowand > > wrote: > >> > >> On 8/15/19 6:50 PM, Saravana Kannan wrote: > >>> On Wed, A

Re: [PATCH v7 1/7] driver core: Add support for linking devices during device addition

2019-08-19 Thread Saravana Kannan
On Sun, Aug 18, 2019 at 8:38 PM Frank Rowand wrote: > > On 8/15/19 6:50 PM, Saravana Kannan wrote: > > On Wed, Aug 7, 2019 at 7:04 PM Frank Rowand wrote: > >> > >>> Date: Tue, 23 Jul 2019 17:10:54 -0700 > >>> Subject: [PATCH v7 1/7] driver core:

Re: [PATCH v7 3/7] of/platform: Add functional dependency link from DT bindings

2019-08-19 Thread Saravana Kannan
On Mon, Aug 19, 2019 at 10:16 AM Frank Rowand wrote: > > On 8/15/19 6:50 PM, Saravana Kannan wrote: > > On Wed, Aug 7, 2019 at 7:06 PM Frank Rowand wrote: > >> > >> On 7/23/19 5:10 PM, Saravana Kannan wrote: > >>> Add device-links after the devices are

Re: [PATCH 2/2] of/platform: Disable generic device linking code for PowerPC

2019-08-15 Thread Saravana Kannan
On Wed, Aug 14, 2019 at 4:41 PM Rob Herring wrote: > > On Tue, Aug 6, 2019 at 4:04 PM Saravana Kannan wrote: > > > > On Tue, Aug 6, 2019 at 2:27 PM Rob Herring wrote: > > > > > > On Tue, Aug 6, 2019 at 1:27 PM Saravana Kannan > > > wrote

Re: [PATCH v5 0/3] Introduce Bandwidth OPPs for interconnects

2019-08-15 Thread Saravana Kannan
On Thu, Aug 15, 2019 at 9:19 AM Georgi Djakov wrote: > > Hi, > > On 8/8/19 01:31, Saravana Kannan wrote: > > Interconnects and interconnect paths quantify their performance levels in > > terms of bandwidth and not in terms of frequency. So similar to how we have > &

Re: [PATCH v7 1/7] driver core: Add support for linking devices during device addition

2019-08-15 Thread Saravana Kannan
On Wed, Aug 7, 2019 at 7:04 PM Frank Rowand wrote: > > > Date: Tue, 23 Jul 2019 17:10:54 -0700 > > Subject: [PATCH v7 1/7] driver core: Add support for linking devices during > > device addition > > From: Saravana Kannan > > > > When devices are added, th

Re: [PATCH v7 2/7] driver core: Add edit_links() callback for drivers

2019-08-15 Thread Saravana Kannan
On Wed, Aug 7, 2019 at 7:05 PM Frank Rowand wrote: > > > Date: Tue, 23 Jul 2019 17:10:55 -0700 > > Subject: [PATCH v7 2/7] driver core: Add edit_links() callback for drivers > > From: Saravana Kannan > > > > The driver core/bus adding supplier-consumer depe

Re: [PATCH v7 3/7] of/platform: Add functional dependency link from DT bindings

2019-08-15 Thread Saravana Kannan
On Wed, Aug 7, 2019 at 7:06 PM Frank Rowand wrote: > > On 7/23/19 5:10 PM, Saravana Kannan wrote: > > Add device-links after the devices are created (but before they are > > probed) by looking at common DT bindings like clocks and > > interconnects. > > > &g

Re: [PATCH v9 0/7] Solve postboot supplier cleanup and optimize probe ordering

2019-08-15 Thread Saravana Kannan
On Fri, Aug 9, 2019 at 10:20 PM Frank Rowand wrote: > > On 8/9/19 10:00 PM, Saravana Kannan wrote: > > On Fri, Aug 9, 2019 at 7:57 PM Frank Rowand wrote: > >> > >> Hi Saravana, > >> > >> On 7/31/19 3:17 PM, Saravana Kannan wrote: > >>&g

Re: [PATCH 2/2] of/platform: Disable generic device linking code for PowerPC

2019-08-14 Thread Saravana Kannan
On Tue, Aug 6, 2019 at 3:04 PM Saravana Kannan wrote: > > On Tue, Aug 6, 2019 at 2:27 PM Rob Herring wrote: > > > > On Tue, Aug 6, 2019 at 1:27 PM Saravana Kannan wrote: > > > > > > PowerPC platforms don't use the generic of/platform code to populate th

Re: [PATCH v2 05/10] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS

2019-08-14 Thread Saravana Kannan
On Wed, Aug 14, 2019 at 5:54 AM 'Matthias Maennich' via kernel-team wrote: > > On Tue, Aug 13, 2019 at 01:15:44PM -0700, Saravana Kannan wrote: > >On Tue, Aug 13, 2019 at 5:19 AM 'Matthias Maennich' via kernel-team > > wrote: > >> > >> If MODULE_ALLOW_MISSING_N

Re: [PATCH 2/2] interconnect: qcom: Add OSM L3 interconnect provider support

2019-08-13 Thread Saravana Kannan
On Thu, Aug 8, 2019 at 10:37 AM Sibi Sankar wrote: > > Hey Saravana, > > Thanks for the review! > > On 8/8/19 2:51 AM, Saravana Kannan wrote: > > On Wed, Aug 7, 2019 at 4:24 AM Sibi Sankar wrote: > >> > >> On some Qualcomm SoCs, Operating State

Re: [PATCH v9 0/7] Solve postboot supplier cleanup and optimize probe ordering

2019-08-09 Thread Saravana Kannan
On Fri, Aug 9, 2019 at 7:57 PM Frank Rowand wrote: > > Hi Saravana, > > On 7/31/19 3:17 PM, Saravana Kannan wrote: > > Add device-links to track functional dependencies between devices > > after they are created (but before they are probed) by looking at > > their

Re: 21871a99b3 ("of/platform: Pause/resume sync state during init .."): WARNING: CPU: 0 PID: 1 at drivers/base/core.c:691 device_links_supplier_sync_state_resume

2019-08-08 Thread Saravana Kannan
re-testing > > commit 21871a99b34c65c56a24193c277a4981529c306f > Author: Saravana Kannan > AuthorDate: Wed Jul 31 15:17:18 2019 -0700 > Commit: Greg Kroah-Hartman > CommitDate: Thu Aug 1 16:04:14 2019 +0200 > > of/platform: Pause/resume sync state during init and > of_platform_p

[PATCH v5 1/3] dt-bindings: opp: Introduce opp-peak-kBps and opp-avg-kBps bindings

2019-08-07 Thread Saravana Kannan
is an optional property that can be used in Bandwidth OPP tables. Signed-off-by: Saravana Kannan --- Documentation/devicetree/bindings/opp/opp.txt | 15 --- .../devicetree/bindings/property-units.txt| 4 2 files changed, 16 insertions(+), 3 deletions(-) diff --git

[PATCH v5 2/3] OPP: Add support for bandwidth OPP tables

2019-08-07 Thread Saravana Kannan
Not all devices quantify their performance points in terms of frequency. Devices like interconnects quantify their performance points in terms of bandwidth. We need a way to represent these bandwidth levels in OPP. So, add support for parsing bandwidth OPPs from DT. Signed-off-by: Saravana Kannan

[PATCH v5 3/3] OPP: Add helper function for bandwidth OPP tables

2019-08-07 Thread Saravana Kannan
the peak and average bandwidth for a given (or suspend) OPP entry. Signed-off-by: Saravana Kannan --- drivers/opp/core.c | 51 ++ include/linux/pm_opp.h | 19 2 files changed, 70 insertions(+) diff --git a/drivers/opp/core.c b/drivers/opp

[PATCH v5 0/3] Introduce Bandwidth OPPs for interconnects

2019-08-07 Thread Saravana Kannan
e time - Added units documentation - Dropped interconnect-opp-table property and related changes v4->v5: - Replaced KBps with kBps - Minor documentation fix Cheers, Saravana Saravana Kannan (3): dt-bindings: opp: Introduce opp-peak-kBps and opp-avg-kBps bindings OPP: Add support for bandwidth OPP ta

Re: [PATCH 2/2] interconnect: qcom: Add OSM L3 interconnect provider support

2019-08-07 Thread Saravana Kannan
On Wed, Aug 7, 2019 at 4:24 AM Sibi Sankar wrote: > > On some Qualcomm SoCs, Operating State Manager (OSM) controls the > resources of scaling L3 caches. Add a driver to handle bandwidth > requests to OSM L3 from CPU/GPU. > > Signed-off-by: Sibi Sankar > --- > drivers/interconnect/qcom/Kconfig

Re: [PATCH v4 2/3] OPP: Add support for bandwidth OPP tables

2019-08-07 Thread Saravana Kannan
On Wed, Aug 7, 2019 at 5:53 AM Georgi Djakov wrote: > > Hi Saravana, > > On 7/27/19 02:15, Saravana Kannan wrote: > > Not all devices quantify their performance points in terms of frequency. > > Devices like interconnects quantify their performance points in terms of >

[PATCH] of/platform: Fix device_links_supplier_sync_state_resume() warning

2019-08-06 Thread Saravana Kannan
even in that case. Reported-by: Qian Cai Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index a2a4e4b79d43..e5f7e40df439 100644 --- a/drivers/of/platform.c +++ b/drivers

Re: "of/platform: Pause/resume sync state during init and of_platform_populate()" with a warning on arm64

2019-08-06 Thread Saravana Kannan
Thanks for confirming. I didn't think ARM64 could even boot without DT. I'll send a fix right away. Any chance you can let us know what device this was tested on? -Saravana -Saravana On Tue, Aug 6, 2019 at 6:46 PM Qian Cai wrote: > > > > > On Aug 6, 2019, at 9:22 PM, Saravan

Re: "of/platform: Pause/resume sync state during init and of_platform_populate()" with a warning on arm64

2019-08-06 Thread Saravana Kannan
On Tue, Aug 6, 2019 at 5:46 PM Qian Cai wrote: > > It looks like the linux-next commit “of/platform: Pause/resume sync state > during init and of_platform_populate()” [1] > Introduced a warning while booting arm64. > > [1]

Re: [PATCH 2/2] of/platform: Disable generic device linking code for PowerPC

2019-08-06 Thread Saravana Kannan
On Tue, Aug 6, 2019 at 2:27 PM Rob Herring wrote: > > On Tue, Aug 6, 2019 at 1:27 PM Saravana Kannan wrote: > > > > PowerPC platforms don't use the generic of/platform code to populate the > > devices from DT. > > Yes, they do. No they don't. My wording could

[PATCH 2/2] of/platform: Disable generic device linking code for PowerPC

2019-08-06 Thread Saravana Kannan
this back for PowerPC would be trivial. We'll just need to export of_link_to_suppliers() and then let the machine specific files do the linking as they populate the devices from DT. Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/2] of/platform: Fix fn definitons for of_link_is_valid() and of_link_property()

2019-08-06 Thread Saravana Kannan
of_link_is_valid() can be static since it's not used anywhere else. of_link_property() return type should have been int instead of bool. Reported-by: Stephen Rothwell Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: linux-next: build warning after merge of the driver-core tree

2019-08-05 Thread Saravana Kannan
On Sun, Aug 4, 2019 at 9:56 PM Stephen Rothwell wrote: > > Hi all, > > On Mon, 5 Aug 2019 13:04:03 +1000 Stephen Rothwell > wrote: > > > > After merging the driver-core tree, today's linux-next build (powerpc > > ppc64_defconfig) produced this warning: > > > > drivers/of/platform.c:674:12:

Re: [PATCH v3 0/6] Introduce Bandwidth OPPs for interconnect paths

2019-08-03 Thread Saravana Kannan
Resending due to HTML. On Mon, Jul 29, 2019 at 8:02 PM Viresh Kumar wrote: > > On 29-07-19, 13:12, Saravana Kannan wrote: > > On Mon, Jul 29, 2019 at 2:24 AM Viresh Kumar > > wrote: > > > > > > On 18-07-19, 21:12, Saravana Kannan wrote: > > > &g

[PATCH v9 1/7] driver core: Add support for linking devices during device addition

2019-07-31 Thread Saravana Kannan
new devices get added. Signed-off-by: Saravana Kannan --- drivers/base/core.c| 83 ++ include/linux/device.h | 14 +++ 2 files changed, 97 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 950e3bd0f45c..62d416e667bd 100644

[PATCH v9 2/7] driver core: Add edit_links() callback for drivers

2019-07-31 Thread Saravana Kannan
Device-S probes. 14. Device-C probes. kbuild test robot reported missing documentation for device.has_edit_links Reported-by: kbuild test robot Signed-off-by: Saravana Kannan --- drivers/base/core.c| 24 ++-- drivers/base/dd.c | 29 + include

[PATCH v9 4/7] driver core: Add sync_state driver/bus callback

2019-07-31 Thread Saravana Kannan
reported missing documentation for device.state_synced Reported-by: kbuild test robot Signed-off-by: Saravana Kannan --- drivers/base/core.c| 65 ++ include/linux/device.h | 26 + 2 files changed, 91 insertions(+) diff --git a/drivers

[PATCH v9 6/7] of/platform: Create device links for all child-supplier depencencies

2019-07-31 Thread Saravana Kannan
consumers have probed. 9. None of the devices malfunction. Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 6c9c8dcee912..36e25136e8

[PATCH v9 7/7] of/platform: Don't create device links for default busses

2019-07-31 Thread Saravana Kannan
for default busses and skip trying to create device links for them. Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 36e25136e807..33cac801e50b 100644 --- a/drivers/of/platform.c +++ b

[PATCH v9 5/7] of/platform: Pause/resume sync state during init and of_platform_populate()

2019-07-31 Thread Saravana Kannan
called prematurely, pause and resume sync_state() callbacks across of_platform_populate(). Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 64c4b91988f2..6c9c8dcee912

[PATCH v9 0/7] Solve postboot supplier cleanup and optimize probe ordering

2019-07-31 Thread Saravana Kannan
p of linux-next to handle device link changes in [1] v8 -> v9: - Fixed kbuild test bot reported errors (docs and const) [1] - https://lore.kernel.org/lkml/2305283.AStDPdUUnE@kreacher/ -Saravana Saravana Kannan (7): driver core: Add support for linking devices during device additio

Re: [PATCH v3 2/6] OPP: Add support for bandwidth OPP tables

2019-07-30 Thread Saravana Kannan
On Tue, Jul 30, 2019 at 3:57 AM Amit Kucheria wrote: > > On Wed, Jul 3, 2019 at 6:40 AM Saravana Kannan wrote: > > > > Not all devices quantify their performance points in terms of frequency. > > Devices like interconnects quantify their performance points in terms o

Re: [PATCH v3 3/5] OPP: Improve require-opps linking

2019-07-30 Thread Saravana Kannan
On Tue, Jul 30, 2019 at 4:03 PM Hsin-Yi Wang wrote: > > On Wed, Jul 17, 2019 at 10:23 PM Saravana Kannan wrote: > > > -free_required_tables: > > - _opp_table_free_required_tables(opp_table); > > -put_np: > > - of_node_put(np); > > + for

Re: [PATCH v4 0/3] Introduce Bandwidth OPPs for interconnects

2019-07-29 Thread Saravana Kannan
On Mon, Jul 29, 2019 at 10:28 PM Sibi Sankar wrote: > > Hey Viresh, > > On 7/30/19 8:16 AM, Viresh Kumar wrote: > > On 29-07-19, 13:16, Saravana Kannan wrote: > >> Sibi might be working on doing that for the SDM845 CPUfreq driver. > >> Georgi could also c

Re: [PATCH v2] driver core: Remove device link creation limitation

2019-07-29 Thread Saravana Kannan
On Mon, Jul 29, 2019 at 3:03 PM Rafael J. Wysocki wrote: > > On Mon, Jul 29, 2019 at 11:43 PM Saravana Kannan wrote: > > > > On Mon, Jul 29, 2019 at 2:25 PM Rafael J. Wysocki wrote: > > > > > > On Mon, Jul 29, 2019 at 10:47 PM Saravana Kannan

[PATCH v8 6/7] of/platform: Create device links for all child-supplier depencencies

2019-07-29 Thread Saravana Kannan
consumers have probed. 9. None of the devices malfunction. Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 71d6138698ec..41499ddc8d

[PATCH v8 7/7] of/platform: Don't create device links for default busses

2019-07-29 Thread Saravana Kannan
for default busses and skip trying to create device links for them. Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 41499ddc8d95..676b2f730d1b 100644 --- a/drivers/of/platform.c +++ b

[PATCH v8 5/7] of/platform: Pause/resume sync state during init and of_platform_populate()

2019-07-29 Thread Saravana Kannan
called prematurely, pause and resume sync_state() callbacks across of_platform_populate(). Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index 4344419a26fc..71d6138698ec

[PATCH v8 2/7] driver core: Add edit_links() callback for drivers

2019-07-29 Thread Saravana Kannan
Device-S probes. 14. Device-C probes. Signed-off-by: Saravana Kannan --- drivers/base/core.c| 24 ++-- drivers/base/dd.c | 29 + include/linux/device.h | 18 ++ 3 files changed, 69 insertions(+), 2 deletions(-) diff --git a/d

[PATCH v8 4/7] driver core: Add sync_state driver/bus callback

2019-07-29 Thread Saravana Kannan
-by: Saravana Kannan --- drivers/base/core.c| 65 ++ include/linux/device.h | 23 +++ 2 files changed, 88 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index fec2e8ae75fe..8528b5298e14 100644 --- a/drivers/base/core.c +++ b

[PATCH v8 3/7] of/platform: Add functional dependency link from DT bindings

2019-07-29 Thread Saravana Kannan
s to track "driver presence" (probe succeeded) of the supplier device. If any other functionality provided by device-links are needed, it is left to the consumer/supplier devices to change the link when they probe. Signed-off-by: Saravana Kannan --- .../admin-guide/kernel-paramete

[PATCH v8 0/7] Solve postboot supplier cleanup and optimize probe ordering

2019-07-29 Thread Saravana Kannan
p of linux-next to handle device link changes in [1] [1] - https://lore.kernel.org/lkml/2305283.AStDPdUUnE@kreacher/ -Saravana Saravana Kannan (7): driver core: Add support for linking devices during device addition driver core: Add edit_links() callback for drivers of/platform: Add functi

[PATCH v8 1/7] driver core: Add support for linking devices during device addition

2019-07-29 Thread Saravana Kannan
new devices get added. Signed-off-by: Saravana Kannan --- drivers/base/core.c| 83 ++ include/linux/device.h | 14 +++ 2 files changed, 97 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 950e3bd0f45c..62d416e667bd 100644

Re: [PATCH v2] driver core: Remove device link creation limitation

2019-07-29 Thread Saravana Kannan
On Mon, Jul 29, 2019 at 2:25 PM Rafael J. Wysocki wrote: > > On Mon, Jul 29, 2019 at 10:47 PM Saravana Kannan wrote: > > > > Rafael, > > > > This is the fix you need. Or something link this. > > > > I had asked you to reject DL_FLAG_MANAGED as an input

Re: [PATCH v2] driver core: Remove device link creation limitation

2019-07-29 Thread Saravana Kannan
y more, replace all of the > > status-tracking checks against DL_FLAG_STATELESS with analogous > > checks against DL_FLAG_MANAGED and update the documentation to > > reflect these changes. > > > > While at it, make device_link_add() reject flags that it does not &g

Re: [PATCH v4 0/3] Introduce Bandwidth OPPs for interconnects

2019-07-29 Thread Saravana Kannan
On Mon, Jul 29, 2019 at 2:35 AM Viresh Kumar wrote: > > On 26-07-19, 16:15, Saravana Kannan wrote: > > Interconnects and interconnect paths quantify their performance levels in > > terms of bandwidth and not in terms of frequency. So similar to how we have > > frequenc

<    1   2   3   4   5   6   7   8   9   10   >