On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
Tejun Heo wrote:
> Satyam Sharma wrote:
>>>> sysfs_find_dirent() -- to check for -EEXIST -- should be called
>>>> *before* we create the new dentry for the to-be-created symlink
>>>> in the
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
Satyam Sharma wrote:
> Readability, fewer LOC, 308 lesser bytes in kernel image and
> faster for the common case -- not good enough for you?! Oh, well.
Sorry, not agreed on readability. The rest doesn't really matter too
much and
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
Satyam Sharma wrote:
> A trivial nit:
>
> The cleanup ignores the return of sysfs_addrm_finish() -- functions
> such as those could and should be void-returning. It doesn't even
> need to return an int for success / failure
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
Satyam Sharma wrote:
>> Well, I dunno. Probably my taste just sucks. Please feel free to
>> submit patches and/or suggest better ideas.
>
> OK, for example:
>
> sysfs_find_dirent() -- to check for -EEXIST -- should
On 7/18/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
Hi,
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
> Satyam Sharma wrote:
> > On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
> >> There is a subtle bug in sysfs_create_link() failure path. When
> &g
Hi,
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
Satyam Sharma wrote:
> On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
>> There is a subtle bug in sysfs_create_link() failure path. When
>> symlink creation fails because there's already a node with t
Hi Tejun,
Thanks for tracking this down and fixing it.
On 7/18/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
There is a subtle bug in sysfs_create_link() failure path. When
symlink creation fails because there's already a node with the same
name, the target sysfs_dirent is put twice - once by
Hi Tejun,
Thanks for tracking this down and fixing it.
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote:
There is a subtle bug in sysfs_create_link() failure path. When
symlink creation fails because there's already a node with the same
name, the target sysfs_dirent is put twice - once by
Hi,
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote:
Satyam Sharma wrote:
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote:
There is a subtle bug in sysfs_create_link() failure path. When
symlink creation fails because there's already a node with the same
name, the target sysfs_dirent is put
On 7/18/07, Satyam Sharma [EMAIL PROTECTED] wrote:
Hi,
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote:
Satyam Sharma wrote:
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote:
There is a subtle bug in sysfs_create_link() failure path. When
symlink creation fails because there's already a node
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote:
Satyam Sharma wrote:
Well, I dunno. Probably my taste just sucks. Please feel free to
submit patches and/or suggest better ideas.
OK, for example:
sysfs_find_dirent() -- to check for -EEXIST -- should be called
*before* we create the new
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote:
Satyam Sharma wrote:
A trivial nit:
The cleanup ignores the return of sysfs_addrm_finish() -- functions
such as those could and should be void-returning. It doesn't even
need to return an int for success / failure ... I went over it's code
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote:
Satyam Sharma wrote:
Readability, fewer LOC, 308 lesser bytes in kernel image and
faster for the common case -- not good enough for you?! Oh, well.
Sorry, not agreed on readability. The rest doesn't really matter too
much and please stop making
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote:
Tejun Heo wrote:
Satyam Sharma wrote:
sysfs_find_dirent() -- to check for -EEXIST -- should be called
*before* we create the new dentry for the to-be-created symlink
in the first place. [ It's weird to grab a reference on the target
On Wed, 18 Jul 2007, Satyam Sharma wrote:
> On Wed, 18 Jul 2007, Al Viro wrote:
>
> > On Wed, Jul 18, 2007 at 01:24:46AM +0200, Uwe Kleine-Konig wrote:
> > > [...]
> > > a52b1752c07 introduces usage of the WARN_ON macro in , but
> > > doesn't pull in .
ons
of smp_call_function_single() in all the archs do this).
(3) We use the unconditional non-save/restore-flags versions of
local_irq_disable/enable just below this, so it's a bug to
call this function with IRQs disabled anyway.
Also remove the cpuid != 0 warning that I had erroneou
From: Satyam Sharma <[EMAIL PROTECTED]>
[PATCH] Introduce is_owner_or_cap() to wrap CAP_FOWNER use with fsuid check
Introduce is_owner_or_cap() macro in fs.h, and convert over relevant
users to it. This is done because we want to avoid bugs in the future
where we check for only effective
[ Ok, last overview of this thing. ]
On Tue, 17 Jul 2007, Satyam Sharma wrote:
> On Mon, 16 Jul 2007, Al Viro wrote:
> > On Tue, Jul 17, 2007 at 01:00:42AM +0530, Satyam Sharma wrote:
> > > > if ((current->fsuid != inode->i_uid) && !capable(CAP_FOWNER)
[ Ok, last overview of this thing. ]
On Tue, 17 Jul 2007, Satyam Sharma wrote:
On Mon, 16 Jul 2007, Al Viro wrote:
On Tue, Jul 17, 2007 at 01:00:42AM +0530, Satyam Sharma wrote:
if ((current-fsuid != inode-i_uid) !capable(CAP_FOWNER))
test is a rather common test
From: Satyam Sharma [EMAIL PROTECTED]
[PATCH] Introduce is_owner_or_cap() to wrap CAP_FOWNER use with fsuid check
Introduce is_owner_or_cap() macro in fs.h, and convert over relevant
users to it. This is done because we want to avoid bugs in the future
where we check for only effective fsuid
earlier (sorry!)
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
Cc: Andi Kleen [EMAIL PROTECTED]
Cc: Avi Kivity [EMAIL PROTECTED]
---
include/linux/smp.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/smp.h b/include/linux/smp.h
index 259a13c..016dab5
On Wed, 18 Jul 2007, Satyam Sharma wrote:
On Wed, 18 Jul 2007, Al Viro wrote:
On Wed, Jul 18, 2007 at 01:24:46AM +0200, Uwe Kleine-Konig wrote:
[...]
a52b1752c07 introduces usage of the WARN_ON macro in linux/smp.h, but
doesn't pull in linux/kernel.h. (asm/bug.h is not enough
On 7/17/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
CONFIG_BLK_DEV_BSG=y
CONFIG_SCSI=m
block/built-in.o: In function `bsg_init':
block/bsg.c:1097: undefined reference to `scsi_register_interface'
make: *** [.tmp_vmlinux1] Error 1
on latest -git.
Satyam
-
To unsubscribe from this list:
On Tue, 17 Jul 2007, Al Viro wrote:
> On Tue, Jul 17, 2007 at 03:24:14AM +0530, Satyam Sharma wrote:
> > On Tue, 17 Jul 2007, Satyam Sharma wrote:
> > > [...]
> > > Anwyay, so I'm thinking of adding:
> > >
> > > struct inode;
> > >
> >
On Tue, 17 Jul 2007, Satyam Sharma wrote:
> [...]
> Anwyay, so I'm thinking of adding:
>
> struct inode;
>
> int is_not_owner(struct inode *)
^static inline ^inode
of course.
> {
> return ((current->fsuid != inode->i_uid) && !c
On Mon, 16 Jul 2007, Al Viro wrote:
> On Tue, Jul 17, 2007 at 01:00:42AM +0530, Satyam Sharma wrote:
> > > if ((current->fsuid != inode->i_uid) && !capable(CAP_FOWNER))
> > >
> > > test is a rather common test, and in fact, arguably, every time you se
On Mon, 16 Jul 2007, Linus Torvalds wrote:
>
>
> On Tue, 17 Jul 2007, Satyam Sharma wrote:
> >
> > [PATCH] utime(s): Honour CAP_FOWNER when times==NULL
> >
> > do_utimes() does not honour CAP_FOWNER when times==NULL.
> > Trivial and obvious
[PATCH] utime(s): Honour CAP_FOWNER when times==NULL
do_utimes() does not honour CAP_FOWNER when times==NULL.
Trivial and obvious one-line fix.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
BTW this bug was hidden by the fact that we call vfs_permission() from the
code
On 7/16/07, Al Boldi <[EMAIL PROTECTED]> wrote:
Satyam Sharma wrote:
> Or just "cp -al" to create multiple trees at (almost) no disk cost
> that won't interfere with each other in any way, and makes the
> development process / generating patchsets trifle easier as well .
Hi Gabriel,
On 7/16/07, Gabriel C <[EMAIL PROTECTED]> wrote:
( http://194.231.229.228/Oops.txt )
I cannot reproduce this on plain 2.6.22 so I've started to bisect the
problem.
Could you reproduce this oops at will at the "bad" points? [ Note that
git-bisect isn't quite applicable to bugs
On 7/16/07, Stefan Seyfried <[EMAIL PROTECTED]> wrote:
Holy sh*t. There is not even a functional replacement ready, but still
everybody wants to remove /proc/acpi. (Maybe the replacement started
to work recently, i have not looked into this area for the last months.
This does not change my
On 7/16/07, Stefan Seyfried [EMAIL PROTECTED] wrote:
Holy sh*t. There is not even a functional replacement ready, but still
everybody wants to remove /proc/acpi. (Maybe the replacement started
to work recently, i have not looked into this area for the last months.
This does not change my pint,
Hi Gabriel,
On 7/16/07, Gabriel C [EMAIL PROTECTED] wrote:
( http://194.231.229.228/Oops.txt )
I cannot reproduce this on plain 2.6.22 so I've started to bisect the
problem.
Could you reproduce this oops at will at the bad points? [ Note that
git-bisect isn't quite applicable to bugs that
On 7/16/07, Al Boldi [EMAIL PROTECTED] wrote:
Satyam Sharma wrote:
Or just cp -al to create multiple trees at (almost) no disk cost
that won't interfere with each other in any way, and makes the
development process / generating patchsets trifle easier as well ...
That would be correct
[PATCH] utime(s): Honour CAP_FOWNER when times==NULL
do_utimes() does not honour CAP_FOWNER when times==NULL.
Trivial and obvious one-line fix.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
---
BTW this bug was hidden by the fact that we call vfs_permission() from the
code below
On Mon, 16 Jul 2007, Linus Torvalds wrote:
On Tue, 17 Jul 2007, Satyam Sharma wrote:
[PATCH] utime(s): Honour CAP_FOWNER when times==NULL
do_utimes() does not honour CAP_FOWNER when times==NULL.
Trivial and obvious one-line fix.
Ahh, ok. Is this old, or was it introduced
On Mon, 16 Jul 2007, Al Viro wrote:
On Tue, Jul 17, 2007 at 01:00:42AM +0530, Satyam Sharma wrote:
if ((current-fsuid != inode-i_uid) !capable(CAP_FOWNER))
test is a rather common test, and in fact, arguably, every time you see
one part of it, you should probably see the other
On Tue, 17 Jul 2007, Satyam Sharma wrote:
[...]
Anwyay, so I'm thinking of adding:
struct inode;
int is_not_owner(struct inode *)
^static inline ^inode
of course.
{
return ((current-fsuid != inode-i_uid) !capable(CAP_FOWNER));
}
to linux/capability.h
On Tue, 17 Jul 2007, Al Viro wrote:
On Tue, Jul 17, 2007 at 03:24:14AM +0530, Satyam Sharma wrote:
On Tue, 17 Jul 2007, Satyam Sharma wrote:
[...]
Anwyay, so I'm thinking of adding:
struct inode;
int is_not_owner(struct inode *)
^static inline ^inode
On 7/17/07, Andrew Morton [EMAIL PROTECTED] wrote:
CONFIG_BLK_DEV_BSG=y
CONFIG_SCSI=m
block/built-in.o: In function `bsg_init':
block/bsg.c:1097: undefined reference to `scsi_register_interface'
make: *** [.tmp_vmlinux1] Error 1
on latest -git.
Satyam
-
To unsubscribe from this list: send
[ the off-topic zillion-ways-to-do-same-thing-in-*nix sub-thread ]
On 7/16/07, Arnd Bergmann <[EMAIL PROTECTED]> wrote:
On Monday 16 July 2007, Satyam Sharma wrote:
> > Yeah. I was going for the general principle :)
>
> Even simpler to add --exclude-from=.gitignore
On 7/16/07, Nigel Cunningham <[EMAIL PROTECTED]> wrote:
On Monday 16 July 2007 08:45:26 Alan Cox wrote:
> > > These patches were written against the vanilla 2.6.21.1 kernel. They
> > > will have no effect UNLESS you make menuconfig and explicitly enable
> > > them there.
> >
> > Would you please
On 7/15/07, Gabriel C <[EMAIL PROTECTED]> wrote:
>> [...]
>> doing a modprobe fixed the driver segfaults and I get this Oops:
>>
>> Jul 14 13:43:30 lara [ 157.953261] BUG: unable to handle kernel paging
>> request at virtual address 43b7a800
>>
>
> 43b7a800 looks suspicious, it could have been
On 7/15/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
On 7/15/07, Timo Lindemann <[EMAIL PROTECTED]> wrote:
[...]
> >>> after this, kernel apparently goes into busy waiting (fans gradually
> >>> turn louder) and hangs indefinitely. I have also made sure tha
On 7/15/07, Timo Lindemann <[EMAIL PROTECTED]> wrote:
David Brownell wrote:
> On Thursday 12 July 2007, Satyam Sharma wrote:
>
> Note that hangs in that file almost always mean "your BIOS is goofy".
> Hunt for BIOS settings related to USB, and change them.
This lapto
On 7/15/07, Timo Lindemann [EMAIL PROTECTED] wrote:
David Brownell wrote:
On Thursday 12 July 2007, Satyam Sharma wrote:
Note that hangs in that file almost always mean your BIOS is goofy.
Hunt for BIOS settings related to USB, and change them.
This laptop's BIOS only offers legacy support
On 7/15/07, Satyam Sharma [EMAIL PROTECTED] wrote:
On 7/15/07, Timo Lindemann [EMAIL PROTECTED] wrote:
[...]
after this, kernel apparently goes into busy waiting (fans gradually
turn louder) and hangs indefinitely. I have also made sure that writel
(in linux/include/asm/io.h) really
On 7/15/07, Gabriel C [EMAIL PROTECTED] wrote:
[...]
doing a modprobe fixed the driver segfaults and I get this Oops:
Jul 14 13:43:30 lara [ 157.953261] BUG: unable to handle kernel paging
request at virtual address 43b7a800
43b7a800 looks suspicious, it could have been a valid kernel
On 7/16/07, Nigel Cunningham [EMAIL PROTECTED] wrote:
On Monday 16 July 2007 08:45:26 Alan Cox wrote:
These patches were written against the vanilla 2.6.21.1 kernel. They
will have no effect UNLESS you make menuconfig and explicitly enable
them there.
Would you please make mrproper
[ the off-topic zillion-ways-to-do-same-thing-in-*nix sub-thread ]
On 7/16/07, Arnd Bergmann [EMAIL PROTECTED] wrote:
On Monday 16 July 2007, Satyam Sharma wrote:
Yeah. I was going for the general principle :)
Even simpler to add --exclude-from=.gitignore to diff
Or build in a separate
Hi Gabriel,
On 7/14/07, Gabriel C <[EMAIL PROTECTED]> wrote:
Hi,
doing a modprobe fixed the driver segfaults and I get this Oops:
Jul 14 13:43:30 lara [ 157.952915] Fixed PHY: Registered new driver
Jul 14 13:43:30 lara [ 157.953010] Device '[EMAIL PROTECTED]:1' does not have a
release()
Hi Gabriel,
On 7/14/07, Gabriel C [EMAIL PROTECTED] wrote:
Hi,
doing a modprobe fixed the driver segfaults and I get this Oops:
Jul 14 13:43:30 lara [ 157.952915] Fixed PHY: Registered new driver
Jul 14 13:43:30 lara [ 157.953010] Device '[EMAIL PROTECTED]:1' does not have a
release()
Hi Tejun,
On 7/14/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
Hello,
Satyam Sharma wrote:
> The whole _purpose_ of get()/put() functions (i.e. refcounting in general)
> is to ensure that the (shared) objects don't go away from under us while
> we're holding them. The proposed c
Hi,
I'm totally confuzed by this patch ...
On 7/14/07, Linas Vepstas <[EMAIL PROTECTED]> wrote:
This is a patch (& bug report) for a crash in sysctl_set_parent()
in 2.6.22-git2.
Are you sure you saw this crash on 22-git2 (Linus' tree) ???
Problem: 2.6.22-git2 crashes with a stack trace
Hi,
Thanks for explaining the purpose behind the proposed change,
but I'm still not convinced that allowing NULL argument in _put()
is a good idea, however:
On 7/13/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
Satyam Sharma wrote:
> Please, this is _basic_ refcounting semantics. For
Hi Keiichi,
On Fri, 13 Jul 2007, KII Keiichi wrote:
> Hi Satyam,
>
> > [0/9] netconsole: Multiple targets and dynamic reconfigurability
> >
> > This patchset is a rework of the original idea and patches posted by
> > Keiichi Kii and Takayoshi Kochi at: http://lkml.org/lkml/2007/6/13/72
> >
> >
Hi Keiichi,
On Fri, 13 Jul 2007, KII Keiichi wrote:
Hi Satyam,
[0/9] netconsole: Multiple targets and dynamic reconfigurability
This patchset is a rework of the original idea and patches posted by
Keiichi Kii and Takayoshi Kochi at: http://lkml.org/lkml/2007/6/13/72
This is v2 of
Hi,
Thanks for explaining the purpose behind the proposed change,
but I'm still not convinced that allowing NULL argument in _put()
is a good idea, however:
On 7/13/07, Tejun Heo [EMAIL PROTECTED] wrote:
Satyam Sharma wrote:
Please, this is _basic_ refcounting semantics. For those who
Hi,
I'm totally confuzed by this patch ...
On 7/14/07, Linas Vepstas [EMAIL PROTECTED] wrote:
This is a patch ( bug report) for a crash in sysctl_set_parent()
in 2.6.22-git2.
Are you sure you saw this crash on 22-git2 (Linus' tree) ???
Problem: 2.6.22-git2 crashes with a stack trace
Hi Tejun,
On 7/14/07, Tejun Heo [EMAIL PROTECTED] wrote:
Hello,
Satyam Sharma wrote:
The whole _purpose_ of get()/put() functions (i.e. refcounting in general)
is to ensure that the (shared) objects don't go away from under us while
we're holding them. The proposed change _weakens_ the API
Hi Timo,
Thanks for your report!
On 7/12/07, Timo Lindemann <[EMAIL PROTECTED]> wrote:
a problem report to something giving me a real headache:
[2.] The version 2.6.22 of the linux kernel hangs when initializing the
integrated ohci controller of the nvidia MCP51 chipset (pci device ids
Hi,
Make sysfs_put() ignore NULL sd instead of oopsing.
>>> I do not think this is a good idea; it is non-sense (and rather a bug)
>>> to call "put" with NULL argument in general.
>> It's better than having to check it all the time in the caller :)
>
> How many callers do we have that will
On 7/12/07, Zhang, Rui <[EMAIL PROTECTED]> wrote:
Well, the ACPI sysfs conversion is not finished yet
[...]
I'm not sure if the button sysfs I/F is already finished.
We'd better make a double check. :)
Ok, this sounds reasonable.
and some user space tools still use the ACPI procfs.
But
Hi,
On Thu, 12 Jul 2007, Keiichi KII wrote:
> Hi Satyam,
>
> > struct netconsole_target {
> > struct list_headlist;
> > +#ifdef CONFIG_NETCONSOLE_DYNAMIC
> > + struct config_item item;
> > + int enabled;
> > +#endif
> > struct netpoll
Hi,
On Thu, 12 Jul 2007, Keiichi KII wrote:
Hi Satyam,
struct netconsole_target {
struct list_headlist;
+#ifdef CONFIG_NETCONSOLE_DYNAMIC
+ struct config_item item;
+ int enabled;
+#endif
struct netpoll np;
};
If
On 7/12/07, Zhang, Rui [EMAIL PROTECTED] wrote:
Well, the ACPI sysfs conversion is not finished yet
[...]
I'm not sure if the button sysfs I/F is already finished.
We'd better make a double check. :)
Ok, this sounds reasonable.
and some user space tools still use the ACPI procfs.
But this
Hi,
Make sysfs_put() ignore NULL sd instead of oopsing.
I do not think this is a good idea; it is non-sense (and rather a bug)
to call put with NULL argument in general.
It's better than having to check it all the time in the caller :)
How many callers do we have that will get benefit
Hi Timo,
Thanks for your report!
On 7/12/07, Timo Lindemann [EMAIL PROTECTED] wrote:
a problem report to something giving me a real headache:
[2.] The version 2.6.22 of the linux kernel hangs when initializing the
integrated ohci controller of the nvidia MCP51 chipset (pci device ids
On 7/11/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
Hi,
On 7/11/07, Gerb Stralko <[EMAIL PROTECTED]> wrote:
[...]
> This link will help:
> http://www.ii.com/internet/messaging/pine/pc/#gmail
>
> Scroll down untill you see a yellow box section that say:
> Gmail Tips
Hi,
On 7/11/07, Gerb Stralko <[EMAIL PROTECTED]> wrote:
> 2) If you have a box available at home (or elsewhere), use that to
> relay mail through.
>
read linux mail from you gmail account. When you need to send a patch,
send it from a linux box using pine, but change the From to your gmail
[ off the original topic, Cc: list trimmed ]
On 7/11/07, Nitin Gupta <[EMAIL PROTECTED]> wrote:
[...]
#define LZO1X_MEM_COMPRESS (16384 * sizeof(unsigned char *))
#define LZO1X_1_MEM_COMPRESS LZO1X_MEM_COMPRESS
-#define lzo1x_worst_compress(x) (x + (x / 64) + 16 + 3)
+#define
On 7/11/07, Avi Kivity <[EMAIL PROTECTED]> wrote:
[...]
It's not proposed. Andi mentioned it in passing.
Ok, thanks for clarifying that.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Hi Joel,
On Tue, 10 Jul 2007, Joel Becker wrote:
> On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote:
> > Hmm, I put it in there because I expected that the user must have had
> > at least one target configured (added to target_list) if he's got the
> >
Hi Joel,
On Tue, 10 Jul 2007, Joel Becker wrote:
On Wed, Jul 11, 2007 at 03:47:09AM +0530, Satyam Sharma wrote:
Hmm, I put it in there because I expected that the user must have had
at least one target configured (added to target_list) if he's got the
module loaded/built-in (and netconsole
On 7/11/07, Avi Kivity [EMAIL PROTECTED] wrote:
[...]
It's not proposed. Andi mentioned it in passing.
Ok, thanks for clarifying that.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
[ off the original topic, Cc: list trimmed ]
On 7/11/07, Nitin Gupta [EMAIL PROTECTED] wrote:
[...]
#define LZO1X_MEM_COMPRESS (16384 * sizeof(unsigned char *))
#define LZO1X_1_MEM_COMPRESS LZO1X_MEM_COMPRESS
-#define lzo1x_worst_compress(x) (x + (x / 64) + 16 + 3)
+#define
Hi,
On 7/11/07, Gerb Stralko [EMAIL PROTECTED] wrote:
2) If you have a box available at home (or elsewhere), use that to
relay mail through.
read linux mail from you gmail account. When you need to send a patch,
send it from a linux box using pine, but change the From to your gmail
account.
On 7/11/07, Satyam Sharma [EMAIL PROTECTED] wrote:
Hi,
On 7/11/07, Gerb Stralko [EMAIL PROTECTED] wrote:
[...]
This link will help:
http://www.ii.com/internet/messaging/pine/pc/#gmail
Scroll down untill you see a yellow box section that say:
Gmail Tips
* If you want to use the Gmail
On Tue, 10 Jul 2007, Joel Becker wrote:
> On Wed, Jul 11, 2007 at 03:40:22AM +0530, Satyam Sharma wrote:
> > IMHO something that mentions /proc/sys/kernel/printk would be better.
> >
> > You don't need to have built with SysRq support for that, it's clearly
&
Jesper Juhl <[EMAIL PROTECTED]>
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
---
Documentation/networking/netconsole.txt | 24
1 file changed, 24 insertions(+)
---
diff -ruNp a/Documentation/networking/netconsole.txt
b/Documentation/network
Hi,
On Tue, 10 Jul 2007, Duane Griffin wrote:
> On 10/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote:
> > + /* Avoid taking lock and disabling interrupts unnecessarily */
> > + if (unlikely(list_empty(_list)))
> > + return;
>
>
Hi Jesper,
On Tue, 10 Jul 2007, Jesper Juhl wrote:
> On Tuesday 10 July 2007 11:41:43 Matt Mackall wrote:
> > On Tue, Jul 10, 2007 at 02:49:41PM +0530, Satyam Sharma wrote:
> > > From: Satyam Sharma <[EMAIL PROTECTED]>
> > >
> > > [4/9] netcons
On 7/10/07, Avi Kivity <[EMAIL PROTECTED]> wrote:
Satyam Sharma wrote:
> On 7/10/07, Avi Kivity <[EMAIL PROTECTED]> wrote:
>> Satyam Sharma wrote:
>> >
>> >
>> > On 7/9/07, Andi Kleen <[EMAIL PROTECTED]> wrote:
>> >> [...]
>&g
On 7/10/07, Avi Kivity <[EMAIL PROTECTED]> wrote:
Satyam Sharma wrote:
>
>
> On 7/9/07, Andi Kleen <[EMAIL PROTECTED]> wrote:
>> [...]
>> on_each_cpu() was imho always a mistake. It would have been better
>> to just fix smp_call_function() directly
>
From: Satyam Sharma <[EMAIL PROTECTED]>
[7/9] netconsole: Use netif_running() in write_msg()
Avoid unnecessarily disabling interrupts and calling netpoll_send_udp()
if the corresponding local interface is not up.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
Cc: Keiichi Kii <[
From: Satyam Sharma <[EMAIL PROTECTED]>
[8/9] netconsole: Support multiple logging targets
This patch introduces support for multiple targets:
Let's keep this out of CONFIG_NETCONSOLE_DYNAMIC as well -- this is useful
even in the default case and (including the infrastructure intr
From: Satyam Sharma <[EMAIL PROTECTED]>
[9/9] netconsole: Support dynamic reconfiguration using configfs
This patch introduces support for dynamic reconfiguration (adding, removing
and/or modifying parameters of netconsole targets at runtime) using a
userspace interface exported via co
From: Satyam Sharma <[EMAIL PROTECTED]>
[6/9] netconsole: Introduce netconsole_netdev_notifier
To update fields of underlying netpoll structure at runtime on
corresponding NETDEV_CHANGEADDR or NETDEV_CHANGENAME notifications.
ioctl(SIOCSIFHWADDR) {or ioctl(SIOCSIFNAME)} could be used to
From: Satyam Sharma <[EMAIL PROTECTED]>
[5/9] netconsole: Introduce netconsole_target
Introduce a wrapper structure over netpoll to represent logging targets
configured in netconsole. This will get extended with other members in
further patches.
The original patchset did this
From: Satyam Sharma <[EMAIL PROTECTED]>
[3/9] netconsole: Simplify boot/module option setup logic
Presently, for built-in netconsole:
__setup(..., option_setup) ensures that the option_setup() function is
called at boot-time from obsolete_checksetup() with the string matching
"
From: Satyam Sharma <[EMAIL PROTECTED]>
[4/9] netconsole: Add some useful tips to documentation
Add some useful general-purpose tips.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
Cc: Keiichi Kii <[EMAIL PROTECTED]>
---
Documentation/networking/netconsole.txt | 13 +++
From: Satyam Sharma <[EMAIL PROTECTED]>
[2/9] netconsole: Remove bogus check
The (!np.dev) check in write_msg() is bogus (always false), because:
np.dev is set by netpoll_setup(), which is called by the target init
code in init_netconsole() _before_ register_console() => write_msg
From: Satyam Sharma <[EMAIL PROTECTED]>
[1/9] netconsole: Cleanups, codingstyle, prettyfication
(1) Remove unwanted headers.
(2) Mark __init and __exit as appropriate.
(3) Various trivial codingstyle and prettification stuff.
Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>
Cc:
[0/9] netconsole: Multiple targets and dynamic reconfigurability
This patchset is a rework of the original idea and patches posted by
Keiichi Kii and Takayoshi Kochi at: http://lkml.org/lkml/2007/6/13/72
This is v2 of the patchset, the previous version is available at:
[0/9] netconsole: Multiple targets and dynamic reconfigurability
This patchset is a rework of the original idea and patches posted by
Keiichi Kii and Takayoshi Kochi at: http://lkml.org/lkml/2007/6/13/72
This is v2 of the patchset, the previous version is available at:
From: Satyam Sharma [EMAIL PROTECTED]
[1/9] netconsole: Cleanups, codingstyle, prettyfication
(1) Remove unwanted headers.
(2) Mark __init and __exit as appropriate.
(3) Various trivial codingstyle and prettification stuff.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
Cc: Keiichi Kii [EMAIL
From: Satyam Sharma [EMAIL PROTECTED]
[2/9] netconsole: Remove bogus check
The (!np.dev) check in write_msg() is bogus (always false), because:
np.dev is set by netpoll_setup(), which is called by the target init
code in init_netconsole() _before_ register_console() = write_msg() cannot
From: Satyam Sharma [EMAIL PROTECTED]
[3/9] netconsole: Simplify boot/module option setup logic
Presently, for built-in netconsole:
__setup(..., option_setup) ensures that the option_setup() function is
called at boot-time from obsolete_checksetup() with the string matching
netconsole= passed
From: Satyam Sharma [EMAIL PROTECTED]
[4/9] netconsole: Add some useful tips to documentation
Add some useful general-purpose tips.
Signed-off-by: Satyam Sharma [EMAIL PROTECTED]
Cc: Keiichi Kii [EMAIL PROTECTED]
---
Documentation/networking/netconsole.txt | 13 +
1 file
From: Satyam Sharma [EMAIL PROTECTED]
[6/9] netconsole: Introduce netconsole_netdev_notifier
To update fields of underlying netpoll structure at runtime on
corresponding NETDEV_CHANGEADDR or NETDEV_CHANGENAME notifications.
ioctl(SIOCSIFHWADDR) {or ioctl(SIOCSIFNAME)} could be used to change
801 - 900 of 1619 matches
Mail list logo
