Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-06 Thread Sedat Dilek
On Sat, Feb 6, 2021 at 9:32 AM Sedat Dilek wrote: > > On Sat, Feb 6, 2021 at 9:27 AM Yonghong Song wrote: > > > > > > > > On 2/5/21 10:52 PM, Sedat Dilek wrote: > > > On Sat, Feb 6, 2021 at 7:26 AM Sedat Dilek wrote: > > >> >

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-06 Thread Sedat Dilek
On Sat, Feb 6, 2021 at 9:27 AM Yonghong Song wrote: > > > > On 2/5/21 10:52 PM, Sedat Dilek wrote: > > On Sat, Feb 6, 2021 at 7:26 AM Sedat Dilek wrote: > >> > >> On Sat, Feb 6, 2021 at 6:53 AM Sedat Dilek wrote: > >>> > &g

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 9:03 PM Yonghong Song wrote: > > > > On 2/5/21 11:24 AM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 05, 2021 at 11:10:08AM -0800, Yonghong Song escreveu: > >> On 2/5/21 11:06 AM, Sedat Dilek wrote: > >>> On Fri, Feb 5, 2021 at 7:5

Re: [PATCH] MAINTAINERS/.mailmap: Use my @kernel.org address

2021-02-05 Thread Sedat Dilek
On Wed, Jan 27, 2021 at 7:48 AM Sedat Dilek wrote: > > On Wed, Jan 27, 2021 at 6:07 AM Lukas Bulwahn wrote: > > > > On Tue, Jan 26, 2021 at 10:27 PM Nathan Chancellor > > wrote: > > > > > > Use my @kernel.org for all points of contact so that I am a

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Sat, Feb 6, 2021 at 7:26 AM Sedat Dilek wrote: > > On Sat, Feb 6, 2021 at 6:53 AM Sedat Dilek wrote: > > > > On Sat, Feb 6, 2021 at 6:44 AM Sedat Dilek wrote: > > > > > > On Sat, Feb 6, 2021 at 4:34 AM Sedat Dilek wrote: > > > > > > &g

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Sat, Feb 6, 2021 at 6:53 AM Sedat Dilek wrote: > > On Sat, Feb 6, 2021 at 6:44 AM Sedat Dilek wrote: > > > > On Sat, Feb 6, 2021 at 4:34 AM Sedat Dilek wrote: > > > > > > On Fri, Feb 5, 2021 at 10:54 PM Yonghong Song wrote: > > > > > &g

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Sat, Feb 6, 2021 at 6:44 AM Sedat Dilek wrote: > > On Sat, Feb 6, 2021 at 4:34 AM Sedat Dilek wrote: > > > > On Fri, Feb 5, 2021 at 10:54 PM Yonghong Song wrote: > > > > > > > > > > > > On 2/5/21 12:31 PM, Sedat Dilek wrote: >

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Sat, Feb 6, 2021 at 4:34 AM Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 10:54 PM Yonghong Song wrote: > > > > > > > > On 2/5/21 12:31 PM, Sedat Dilek wrote: > > > On Fri, Feb 5, 2021 at 9:03 PM Yonghong Song wrote: > > >> > > >

Re: [PATCH] Makefile: reuse CC_VERSION_TEXT

2021-02-05 Thread Sedat Dilek
On Sat, Feb 6, 2021 at 2:49 AM Masahiro Yamada wrote: > > On Sat, Feb 6, 2021 at 7:01 AM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > I noticed we're invoking $(CC) via $(shell) more than once to check the > > version. Let's reuse the first string captured in $CC_VERSION_TEXT. > >

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 10:54 PM Yonghong Song wrote: > > > > On 2/5/21 12:31 PM, Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 9:03 PM Yonghong Song wrote: > >> > >> > >> > >> On 2/5/21 11:24 AM, Arnaldo Carvalho de Melo wrote: > &g

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 3:41 PM Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 3:37 PM Sedat Dilek wrote: > > > > Hi, > > > > when building with pahole v1.20 and binutils v2.35.2 plus Clang > > v12.0.0-rc1 and DWARF-v5 I see: > > ... > > +

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 4:28 PM Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 05, 2021 at 04:23:59PM +0100, Sedat Dilek escreveu: > > On Fri, Feb 5, 2021 at 3:41 PM Sedat Dilek wrote: > > > > > > On Fri, Feb 5, 2021 at 3:37 PM Sedat Dilek wrote: > >

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 10:40 PM Nick Desaulniers wrote: > > On Fri, Feb 5, 2021 at 1:17 PM Sedat Dilek wrote: > > > > On Fri, Feb 5, 2021 at 10:10 PM Nick Desaulniers > > wrote: > > > > > > > Hi, > > > > > > > > when building

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 3:37 PM Sedat Dilek wrote: > > Hi, > > when building with pahole v1.20 and binutils v2.35.2 plus Clang > v12.0.0-rc1 and DWARF-v5 I see: > ... > + info BTF .btf.vmlinux.bin.o > + [ != silent_ ] > + printf %-7s %s\n BTF .btf.vmlinux.bin.o &g

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 10:10 PM Nick Desaulniers wrote: > > > Hi, > > > > when building with pahole v1.20 and binutils v2.35.2 plus Clang > > v12.0.0-rc1 and DWARF-v5 I see: > > ... > > + info BTF .btf.vmlinux.bin.o > > + [ != silent_ ] > > + printf %-7s %s\n BTF .btf.vmlinux.bin.o > > BTF

Re: [PATCH v9 0/3] Kbuild: DWARF v5 support

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 9:22 PM Nick Desaulniers wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > DWARF5 wins significantly in terms of size and especially so when mixed > with compression (CONFIG_DEBUG_INFO_COMPRESSED). > > Link:

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 9:03 PM Yonghong Song wrote: > > > > On 2/5/21 11:24 AM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 05, 2021 at 11:10:08AM -0800, Yonghong Song escreveu: > >> On 2/5/21 11:06 AM, Sedat Dilek wrote: > >>> On Fri, Feb 5, 2021 at 7:5

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 8:21 PM Yonghong Song wrote: > > > > On 2/5/21 11:15 AM, Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 8:10 PM Yonghong Song wrote: > >> > >> > >> > >> On 2/5/21 11:06 AM, Sedat Dilek wrote: > >>> On Fri, Fe

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 8:30 PM Fāng-ruì Sòng wrote: > > On Fri, Feb 5, 2021 at 11:21 AM Sedat Dilek wrote: > > > > On Fri, Feb 5, 2021 at 8:15 PM Sedat Dilek wrote: > > > > > > On Fri, Feb 5, 2021 at 8:10 PM Yonghong Song wrote: > > > > > &g

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 8:21 PM Yonghong Song wrote: > > > > On 2/5/21 11:15 AM, Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 8:10 PM Yonghong Song wrote: > >> > >> > >> > >> On 2/5/21 11:06 AM, Sedat Dilek wrote: > >>> On Fri, Fe

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 8:15 PM Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 8:10 PM Yonghong Song wrote: > > > > > > > > On 2/5/21 11:06 AM, Sedat Dilek wrote: > > > On Fri, Feb 5, 2021 at 7:53 PM Sedat Dilek wrote: > > >> >

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 8:10 PM Yonghong Song wrote: > > > > On 2/5/21 11:06 AM, Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 7:53 PM Sedat Dilek wrote: > >> > >> On Fri, Feb 5, 2021 at 6:48 PM Sedat Dilek wrote: > >>> > >>> On Fri,

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 7:53 PM Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 6:48 PM Sedat Dilek wrote: > > > > On Fri, Feb 5, 2021 at 4:28 PM Arnaldo Carvalho de Melo > > wrote: > > > > > > Em Fri, Feb 05, 2021 at 04:23:59PM +0100, Sedat Dilek escrev

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 6:48 PM Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 4:28 PM Arnaldo Carvalho de Melo > wrote: > > > > Em Fri, Feb 05, 2021 at 04:23:59PM +0100, Sedat Dilek escreveu: > > > On Fri, Feb 5, 2021 at 3:41 PM Sedat Dilek wrote: > > > &

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

2021-02-05 Thread Sedat Dilek
On Fri, Feb 5, 2021 at 4:28 PM Arnaldo Carvalho de Melo wrote: > > Em Fri, Feb 05, 2021 at 04:23:59PM +0100, Sedat Dilek escreveu: > > On Fri, Feb 5, 2021 at 3:41 PM Sedat Dilek wrote: > > > > > > On Fri, Feb 5, 2021 at 3:37 PM Sedat Dilek wrote: > >

Re: ANNOUNCE: pahole v1.20 (gcc11 DWARF5's default, lots of ELF sections, BTF)

2021-02-04 Thread Sedat Dilek
On Thu, Feb 4, 2021 at 11:07 PM Arnaldo Carvalho de Melo wrote: > > Hi, > > The v1.20 release of pahole and its friends is out, mostly > addressing problems related to gcc 11 defaulting to DWARF5 for -g, > available at the usual places: > Congrats and thanks for v1.20 and to all involved

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-02-04 Thread Sedat Dilek
ience and require pahole to be installed with an > appropriate version to select and use CONFIG_DEBUG_INFO_BTF, which is > standard for options that require a specific tools version. > > Suggested-by: Sedat Dilek > Signed-off-by: Nathan Chancellor > --- > MAINTAINERS | 1

Re: [PATCH v5 0/3] Kbuild: DWARF v5 support

2021-02-04 Thread Sedat Dilek
On Thu, Feb 4, 2021 at 9:42 AM Sedat Dilek wrote: > > On Thu, Feb 4, 2021 at 3:58 AM Andrii Nakryiko > wrote: > ... > > > > Is there another (easy) way to get your patch set without the b4 tool? > > Is your patch set present in some patchworks instance, so that

Re: [PATCH v5 0/3] Kbuild: DWARF v5 support

2021-02-04 Thread Sedat Dilek
On Thu, Feb 4, 2021 at 3:58 AM Andrii Nakryiko wrote: ... > > Is there another (easy) way to get your patch set without the b4 tool? > Is your patch set present in some patchworks instance, so that I can > download it in mbox format, for example? > Just to promote the b4 tool - we have some cool

Re: [PATCH v8 0/2] Kbuild: DWARF v5 support

2021-02-04 Thread Sedat Dilek
On Thu, Feb 4, 2021 at 8:45 AM Nick Desaulniers wrote: > > On Wed, Feb 3, 2021 at 10:58 PM Sedat Dilek wrote: > > > > I guess I need to test harder to get a Tested-by credit :-)? > > You're right Sedat, I'm sorry. Your testing is invaluable; thank you > for taking

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-02-03 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 12:07 AM Nathan Chancellor wrote: > > On Wed, Jan 13, 2021 at 02:38:27PM -0800, Andrii Nakryiko wrote: > > Hm.. Just saw Linus proposing using $(error-if) in Kconfig for an > > unrelated issue ([0]). If we can make this work, then it would catch > > such issue early on,

Re: [PATCH v8 0/2] Kbuild: DWARF v5 support

2021-02-03 Thread Sedat Dilek
On Thu, Feb 4, 2021 at 7:40 AM Nick Desaulniers wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > DWARF5 wins significantly in terms of size and especially so when mixed > with compression (CONFIG_DEBUG_INFO_COMPRESSED). > > Link:

Re: [PATCH v2] arch/x86: Propagate $(CLANG_FLAGS) to $(REALMODE_FLAGS)

2021-02-03 Thread Sedat Dilek
efile > > +++ b/arch/x86/Makefile > > @@ -33,6 +33,7 @@ REALMODE_CFLAGS += -ffreestanding > > REALMODE_CFLAGS += -fno-stack-protector > > This one too: > > checking file arch/x86/Makefile > patch: malformed patch at line 62: REALMODE_CFLAGS += > -fno-stack-protector > I needed to touch this as it was "malformed" and did not apply cleanly. If it is not too late, feel free to add my: Tested-by: Sedat Dilek - Sedat -

Re: [PATCH] kbuild: fix duplicated flags in DEBUG_CFLAGS

2021-02-03 Thread Sedat Dilek
On Wed, Feb 3, 2021 at 9:39 AM Masahiro Yamada wrote: > > On Wed, Feb 3, 2021 at 5:32 PM Sedat Dilek wrote: > > > > On Wed, Feb 3, 2021 at 8:53 AM Masahiro Yamada wrote: > > > > > > Sedat Dilek noticed duplicated debug flags passed when building

Re: [PATCH] kbuild: fix duplicated flags in DEBUG_CFLAGS

2021-02-03 Thread Sedat Dilek
On Wed, Feb 3, 2021 at 8:53 AM Masahiro Yamada wrote: > > Sedat Dilek noticed duplicated debug flags passed when building C > files with CONFIG_DEBUG_INFO. > > I do not know much about his build environment, but yes, Kbuild > recurses to the top Makefile with some build ta

Re: [PATCH] kbuild: fix duplicated flags in DEBUG_CFLAGS

2021-02-03 Thread Sedat Dilek
On Wed, Feb 3, 2021 at 8:53 AM Masahiro Yamada wrote: > > Sedat Dilek noticed duplicated debug flags passed when building C > files with CONFIG_DEBUG_INFO. > > I do not know much about his build environment, but yes, Kbuild > recurses to the top Makefile with some build ta

Re: [PATCH v2] scripts/clang-tools: switch explicitly to Python 3

2021-02-01 Thread Sedat Dilek
On Tue, Feb 2, 2021 at 7:06 AM Masahiro Yamada wrote: > > For the same reason as commit 51839e29cb59 ("scripts: switch explicitly > to Python 3"), switch some more scripts, which I tested and confirmed > working on Python 3. > > Signed-off-by: Masahiro Yamada > Acked-by: Nathan Chancellor > ---

Re: [PATCH] scripts: switch some more scripts explicitly to Python 3

2021-02-01 Thread Sedat Dilek
On Tue, Feb 2, 2021 at 7:10 AM Masahiro Yamada wrote: > > On Tue, Feb 2, 2021 at 3:28 AM Nick Desaulniers > wrote: > > > > On Sun, Jan 31, 2021 at 5:08 PM Masahiro Yamada > > wrote: > > > > > > For the same reason as commit 51839e29cb59 ("scripts: switch explicitly > > > to Python 3"), switch

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-01-30 Thread Sedat Dilek
On Sun, Jan 31, 2021 at 1:37 AM Fāng-ruì Sòng wrote: > > On Sat, Jan 30, 2021 at 3:10 PM Sedat Dilek wrote: > > > > On Sat, Jan 30, 2021 at 1:44 AM Nick Desaulniers > > wrote: > > > > > > DWARF v5 is the latest standard of the DWARF debug info forma

Re: [PATCH v7 0/2] Kbuild: DWARF v5 support

2021-01-30 Thread Sedat Dilek
On Sat, Jan 30, 2021 at 1:44 AM Nick Desaulniers wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > DWARF5 wins significantly in terms of size and especially so when mixed > with compression (CONFIG_DEBUG_INFO_COMPRESSED). > > Link:

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-01-30 Thread Sedat Dilek
On Sun, Jan 31, 2021 at 12:10 AM Sedat Dilek wrote: > > On Sat, Jan 30, 2021 at 1:44 AM Nick Desaulniers > wrote: > > > > DWARF v5 is the latest standard of the DWARF debug info format. > > > > Feature detection of DWARF5 is onerous, especially given that we

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-01-30 Thread Sedat Dilek
CONFIG_DEBUG_INFO_BTF is set; pahole doesn't yet > recognize the new additions to the DWARF debug info. Thanks to Sedat for > the report. > > Link: http://www.dwarfstd.org/doc/DWARF5.pdf > Reported-by: Sedat Dilek > Suggested-by: Arvind Sankar > Suggested-by: Caroline

Re: [PATCH v2] vmlinux.lds.h: Define SANTIZER_DISCARDS with CONFIG_GCOV_KERNEL=y

2021-01-30 Thread Sedat Dilek
On Sat, Jan 30, 2021 at 1:27 AM Nathan Chancellor wrote: > > clang produces .eh_frame sections when CONFIG_GCOV_KERNEL is enabled, > even when -fno-asynchronous-unwind-tables is in KBUILD_CFLAGS: > > $ make CC=clang vmlinux > ... > ld: warning: orphan section `.eh_frame' from `init/main.o' being

Re: [PATCH v6 0/2] Kbuild: DWARF v5 support

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > DWARF5 wins significantly in terms of size and especially so when mixed > with compression (CONFIG_DEBUG_INFO_COMPRESSED). > > Link:

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 11:31 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 2:23 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote: > &

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > &

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers > > > wrote:

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers > > > wrot

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek > > &g

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers > > wrote: > > > > > > diff --git a/Makefile b/Makefile > > > index 201

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
CONFIG_DEBUG_INFO_BTF is set; pahole doesn't yet > recognize the new additions to the DWARF debug info. Thanks to Sedat for > the report. > > Link: http://www.dwarfstd.org/doc/DWARF5.pdf > Reported-by: Sedat Dilek > Suggested-by: Arvind Sankar > Suggested-by: Caroline

Re: [PATCH v6 0/2] Kbuild: DWARF v5 support

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > DWARF5 wins significantly in terms of size and especially so when mixed > with compression (CONFIG_DEBUG_INFO_COMPRESSED). > > Link:

Re: [PATCH v7] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-28 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 7:41 PM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Fri, Jan 22, 2021 at 2:12 AM Bill Wendling wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profile, the kernel is instrumented with PGO

Re: [PATCH v7] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-28 Thread Sedat Dilek
On Thu, Jan 28, 2021 at 10:24 PM Nick Desaulniers wrote: > > On Thu, Jan 28, 2021 at 1:19 PM Sedat Dilek wrote: > > > > On Thu, Jan 28, 2021 at 10:12 PM Nick Desaulniers > > wrote: > > > > > > On Thu, Jan 28, 2021 at 12:46 PM Sedat D

Re: [PATCH v7] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-28 Thread Sedat Dilek
On Thu, Jan 28, 2021 at 10:12 PM Nick Desaulniers wrote: > > On Thu, Jan 28, 2021 at 12:46 PM Sedat Dilek wrote: > > > > [ LLVM ] > > > > Today, I switched over to LLVM version 12.0.0-rc1. > > > > > > [ Step #1: 5.11.0-rc5-5-amd64

Re: [PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Sedat Dilek
On Thu, Jan 28, 2021 at 2:41 AM Andrii Nakryiko wrote: > > On Wed, Jan 27, 2021 at 5:30 PM Sedat Dilek wrote: > > > > On Thu, Jan 28, 2021 at 2:27 AM Andrii Nakryiko > > wrote: > > > > > > On Thu, Jan 21, 2021 at 4:32 PM Sedat Dilek wrote: > &

[PATCH bpf-next] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Sedat Dilek
pf-next. CC: b...@vger.kernel.org Acked-by: Andrii Nakryiko Acked-by: Jiri Olsa # tools/build and tools/perf Signed-off-by: Sedat Dilek --- tools/bpf/bpftool/Makefile | 2 -- tools/bpf/runqslower/Makefile | 3 --- tools/build/feature/Makefile

Re: [PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-27 Thread Sedat Dilek
On Thu, Jan 28, 2021 at 2:27 AM Andrii Nakryiko wrote: > > On Thu, Jan 21, 2021 at 4:32 PM Sedat Dilek wrote: > > > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > > > > While looking into the source code I found duplicate assignments

Re: [PATCH v4] x86: Treat R_386_PLT32 as R_386_PC32

2021-01-27 Thread Sedat Dilek
diagnostic. > > Link: https://github.com/ClangBuiltLinux/linux/issues/1210 > Reported-by: Arnd Bergmann > Signed-off-by: Fangrui Song > Reviewed-by: Nick Desaulniers > Reviewed-by: Nathan Chancellor > Tested-by: Nick Desaulniers > Tested-by: Nathan Chancellor > Teste

Re: [PATCH] MAINTAINERS/.mailmap: Use my @kernel.org address

2021-01-26 Thread Sedat Dilek
On Wed, Jan 27, 2021 at 6:07 AM Lukas Bulwahn wrote: > > On Tue, Jan 26, 2021 at 10:27 PM Nathan Chancellor wrote: > > > > Use my @kernel.org for all points of contact so that I am always > > accessible. > > > > Signed-off-by: Nathan Chancellor > > Congrats, Nathan. You deserve it for all the

Re: [PATCH v2 00/20] objtool: vmlinux.o and CLANG LTO support

2021-01-22 Thread Sedat Dilek
On Sat, Jan 23, 2021 at 3:46 AM Josh Poimboeuf wrote: > > On Sat, Jan 23, 2021 at 03:31:20AM +0100, Sedat Dilek wrote: > > On Sat, Jan 23, 2021 at 3:26 AM Josh Poimboeuf wrote: > > > > > > On Fri, Jan 22, 2021 at 05:32:43PM -0800, Nick Desaulniers wrote: &

Re: [PATCH] MAINTAINERS: adjust to clang-version.sh removal

2021-01-22 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:34 PM Dan Carpenter wrote: > > On Thu, Jan 21, 2021 at 05:15:56PM +0100, Sedat Dilek wrote: > > On Thu, Jan 21, 2021 at 5:01 PM Lukas Bulwahn > > wrote: > > > > > > Commit 6c8ad4427f6e ("kbuild: check the minimum compiler ver

Re: [PATCH v2 00/20] objtool: vmlinux.o and CLANG LTO support

2021-01-22 Thread Sedat Dilek
On Sat, Jan 23, 2021 at 3:26 AM Josh Poimboeuf wrote: > > On Fri, Jan 22, 2021 at 05:32:43PM -0800, Nick Desaulniers wrote: > > > In this specific case, find_func_by_offset returns NULL for > > > .text..L.cfi.jumptable.43 at addend 0x8, because Clang doesn't emit > > > jump table symbols for

Re: [PATCH v7] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-22 Thread Sedat Dilek
tation, based on Nick Desaulniers's comment. > v5: - Correct padding calculation, discovered by Nathan Chancellor. > v6: - Add better documentation about the locking scheme and other things. > - Rename macros to better match the same macros in LLVM's source code. > v7: - Fix mino

Re: [PATCH v6] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 2:44 AM Nick Desaulniers wrote: > > On Thu, Jan 21, 2021 at 2:35 AM Sedat Dilek wrote: > > > > Thanks for v6. > > > > Small Changelog nits: > > * Can you reverse-order the changelog - latest v6 first. > > * v4: s/Makfile c

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 2:43 AM Nick Desaulniers wrote: > > On Wed, Jan 20, 2021 at 6:03 PM Sedat Dilek wrote: > > > > On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > > > > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > &g

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 2:34 AM Nick Desaulniers wrote: > > On Wed, Jan 20, 2021 at 6:21 PM Sedat Dilek wrote: > > > > Hi, > > > > When I looked through the code I wondered why we do not add a > > "CONFIG_PGO_CLANG_PROFDATA" which

Re: [PATCH v6] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:14 AM Sedat Dilek wrote: > > On Thu, Jan 21, 2021 at 9:25 AM 'Bill Wendling' via Clang Built Linux > wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profi

[PATCH RFC v2] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
v5.11-rc4. I hope to get some feedback from especially Linux-bpf folks. Acked-by: Jiri Olsa # tools/build and tools/perf Signed-off-by: Sedat Dilek --- Changelog RFC v1->v2: - Add Jiri's ACK - Adapt to fit Linux v5.11-rc4 tools/bpf/bpftool/Makefile | 2 -- tools/bpf/runqs

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:21 AM Sedat Dilek wrote: > > On Fri, Jan 22, 2021 at 1:12 AM Sedat Dilek wrote: > > > > On Fri, Jan 22, 2021 at 1:04 AM Andrii Nakryiko > > wrote: > > > > > > On Wed, Jan 20, 2021 at 2:36 PM Jiri Olsa wrote: > > >

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:12 AM Sedat Dilek wrote: > > On Fri, Jan 22, 2021 at 1:04 AM Andrii Nakryiko > wrote: > > > > On Wed, Jan 20, 2021 at 2:36 PM Jiri Olsa wrote: > > > > > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote: > > >

Re: [PATCH v6] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 9:25 AM 'Bill Wendling' via Clang Built Linux wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-21 Thread Sedat Dilek
On Fri, Jan 22, 2021 at 1:04 AM Andrii Nakryiko wrote: > > On Wed, Jan 20, 2021 at 2:36 PM Jiri Olsa wrote: > > > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote: > > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 3:03 AM Sedat Dilek wrote: > > On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > > > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > >

Re: [PATCH v2 00/20] objtool: vmlinux.o and CLANG LTO support

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 10:29 PM Josh Poimboeuf wrote: > > v2: > - fix commit description for why xen hypervisor page contents don't > matter [Juergen] > - annotate indirect jumps as safe instead of converting them to > retpolines [Andrew, Juergen] > - drop patch 1 - fake jumps no longer

Re: [PATCH] MAINTAINERS: adjust to clang-version.sh removal

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 5:16 PM Nathan Chancellor wrote: > > On Thu, Jan 21, 2021 at 05:01:15PM +0100, Lukas Bulwahn wrote: > > Commit 6c8ad4427f6e ("kbuild: check the minimum compiler version in > > Kconfig") removed ./scripts/clang-version.sh and moved its content to > >

Re: [PATCH] MAINTAINERS: adjust to clang-version.sh removal

2021-01-21 Thread Sedat Dilek
commit hash-id of "kbuild: check the minimum compiler version in Kconfig" - this missed that move. Maybe Masahiro does a respin and can fold this into above commit? That's not my decision. Reviewed-by: Sedat Dilek - Sedat - [1] https://git.kernel.org/pub/scm/linux/kernel/git/masa

Re: [PATCH bpf-next v3] samples/bpf: Update build procedure for manually compiling LLVM and Clang

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 9:55 AM Sedat Dilek wrote: > > On Thu, Jan 21, 2021 at 9:08 AM Andrii Nakryiko > wrote: > > > > On Wed, Jan 20, 2021 at 9:36 PM Nathan Chancellor > > wrote: > > > > > > On Thu, Jan 21, 2021 at 01:27:35PM +0800, Tiezhu Yang wr

Re: [PATCH v6] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Sedat Dilek
e workload test? Here I do a x86-64 defconfig build. See attached script. Usually, I download this patch from LORE. link="https://lore.kernel.org/r/20210111081821.3041587-1-mo...@google.com; b4 -d am $link This downloads v6. What if I want a previous version (compare)? Again, I will l

Re: [PATCH bpf-next v3] samples/bpf: Update build procedure for manually compiling LLVM and Clang

2021-01-21 Thread Sedat Dilek
On Thu, Jan 21, 2021 at 9:08 AM Andrii Nakryiko wrote: > > On Wed, Jan 20, 2021 at 9:36 PM Nathan Chancellor > wrote: > > > > On Thu, Jan 21, 2021 at 01:27:35PM +0800, Tiezhu Yang wrote: > > > The current LLVM and Clang build procedure in samples/bpf/README.rst is > > > out of date. See below

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-20 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > >

Re: [PATCH v5 2/3] Kbuild: make DWARF version a choice

2021-01-20 Thread Sedat Dilek
On Wed, Jan 20, 2021 at 9:40 PM Nathan Chancellor wrote: > > On Fri, Jan 15, 2021 at 01:06:15PM -0800, Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a > > way that's forward

Re: [PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-20 Thread Sedat Dilek
On Wed, Jan 20, 2021 at 11:36 PM Jiri Olsa wrote: > > On Sat, Jan 16, 2021 at 10:54:04AM +0100, Sedat Dilek wrote: > > When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. > > > > While looking into the source code I found duplicate assignments > &

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-20 Thread Sedat Dilek
Hi, When I looked through the code I wondered why we do not add a "CONFIG_PGO_CLANG_PROFDATA" which can be helpful when doing the PGO rebuild with a vmlinux.profdata. This introduces a "PGO_PROFDATA" to turn on/off to pass "-fprofile-use=vmlinux.profdata" (see CFLAGS_PGO_CLANG_PROFDATA in

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 10:56 PM Bill Wendling wrote: > > On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > >

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek wrote: > > > > > > [ big snip ] > > > > [More snippage.] > &

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Sedat Dilek
On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek wrote: > > > > [ big snip ] > > [More snippage.] > > > [ CC Fangrui ] > > > > With the attached... > > > >[PATCH v3] module: Ig

Re: [PATCH v4] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sat, Jan 16, 2021 at 1:13 AM Nick Desaulniers wrote: > > > On Wed, Jan 13, 2021 at 8:07 PM Nick Desaulniers > > wrote: > > > > > > On Wed, Jan 13, 2021 at 12:55 PM Nathan Chancellor > > > wrote: > > > > > > > > However, I see an issue with actually using the data: > > > > > > > > $ sudo -s >

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sun, Jan 17, 2021 at 1:05 PM Sedat Dilek wrote: > > On Sun, Jan 17, 2021 at 12:58 PM Sedat Dilek wrote: > > > > On Sun, Jan 17, 2021 at 12:42 PM Sedat Dilek wrote: > > > > > > On Sun, Jan 17, 2021 at 12:23 PM Sedat Dilek > > > wrote: > >

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sun, Jan 17, 2021 at 12:42 PM Sedat Dilek wrote: > > On Sun, Jan 17, 2021 at 12:23 PM Sedat Dilek wrote: > > > > On Sun, Jan 17, 2021 at 11:53 AM Sedat Dilek wrote: > > > > > > On Sun, Jan 17, 2021 at 11:44 AM Sedat Dilek > > > wrote: > &g

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sun, Jan 17, 2021 at 12:23 PM Sedat Dilek wrote: > > On Sun, Jan 17, 2021 at 11:53 AM Sedat Dilek wrote: > > > > On Sun, Jan 17, 2021 at 11:44 AM Sedat Dilek wrote: > > > > > > On Sat, Jan 16, 2021 at 9:23 PM Bill Wendling wrote: > > > > >

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sun, Jan 17, 2021 at 11:53 AM Sedat Dilek wrote: > > On Sun, Jan 17, 2021 at 11:44 AM Sedat Dilek wrote: > > > > On Sat, Jan 16, 2021 at 9:23 PM Bill Wendling wrote: > > > > > > On Sat, Jan 16, 2021 at 9:39 AM Sedat Dilek wrote: > > > > On S

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sun, Jan 17, 2021 at 11:44 AM Sedat Dilek wrote: > > On Sat, Jan 16, 2021 at 9:23 PM Bill Wendling wrote: > > > > On Sat, Jan 16, 2021 at 9:39 AM Sedat Dilek wrote: > > > On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Clang Built Linux > > > wrote:

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Sedat Dilek
On Sat, Jan 16, 2021 at 9:23 PM Bill Wendling wrote: > > On Sat, Jan 16, 2021 at 9:39 AM Sedat Dilek wrote: > > On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Clang Built Linux > > wrote: > > > > > > From: Sami Tolvanen > > > > > > E

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-16 Thread Sedat Dilek
On Sat, Jan 16, 2021 at 6:38 PM Sedat Dilek wrote: > > On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Clang Built Linux > wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profi

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-16 Thread Sedat Dilek
On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Clang Built Linux wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data

[PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-16 Thread Sedat Dilek
v5.11-rc3. I hope to get some feedback from especially Linux-bpf folks. Signed-off-by: Sedat Dilek --- tools/bpf/bpftool/Makefile | 2 -- tools/bpf/runqslower/Makefile | 3 --- tools/build/feature/Makefile| 4 ++-- tools/perf/Makefile.perf

Re: [PATCH v4] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-15 Thread Sedat Dilek
On Sat, Jan 16, 2021 at 6:07 AM Sedat Dilek wrote: > > On Sat, Jan 16, 2021 at 1:13 AM Nick Desaulniers > wrote: > > > > > On Wed, Jan 13, 2021 at 8:07 PM Nick Desaulniers > > > wrote: > > > > > > > > On Wed, Jan 13, 2021 at 12:55 PM Nath

Re: [PATCH v4] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-15 Thread Sedat Dilek
On Sat, Jan 16, 2021 at 1:13 AM Nick Desaulniers wrote: > > > On Wed, Jan 13, 2021 at 8:07 PM Nick Desaulniers > > wrote: > > > > > > On Wed, Jan 13, 2021 at 12:55 PM Nathan Chancellor > > > wrote: > > > > > > > > However, I see an issue with actually using the data: > > > > > > > > $ sudo -s >

Re: [PATCH v4] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-15 Thread Sedat Dilek
On Sat, Jan 16, 2021 at 1:13 AM Nick Desaulniers wrote: > > > On Wed, Jan 13, 2021 at 8:07 PM Nick Desaulniers > > wrote: > > > > > > On Wed, Jan 13, 2021 at 12:55 PM Nathan Chancellor > > > wrote: > > > > > > > > However, I see an issue with actually using the data: > > > > > > > > $ sudo -s >

<    1   2   3   4   5   6   7   8   9   10   >