y_printk_mrst/nvram driver for powerpc
I don't see any bugs which may causes kdump failure because
deadlocking/dynamic memory allocation don't happen in their write callbacks.
Signed-off-by: Seiji Aguchi
---
fs/pstore/platform.c |4
include/linux/kmsg_dump.h |1 +
I confirmed that efi_pstore_read() and efi_pstore_erase() work correctly.
Please feel free to add
Tested-by: Seiji Aguchi
> -Original Message-
> From: Matt Fleming [mailto:matt.flem...@intel.com]
> Sent: Tuesday, April 30, 2013 7:28 AM
> To: Seiji Aguchi
> C
It worked with this fix.
Thanks!
Seiji
> -Original Message-
> From: Matt Fleming [mailto:matt.flem...@intel.com]
> Sent: Friday, April 26, 2013 10:55 AM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; mi...@kernel.org; h...@zytor.com;
> mj...@srcf.ucam.org; tony
>Did you mount the efivarfs file system there?
Ah...
It worked by mounting efivarfs.
Thanks.
> -Original Message-
> From: Fleming, Matt [mailto:matt.flem...@intel.com]
> Sent: Friday, April 26, 2013 10:35 AM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; m
: Friday, April 26, 2013 5:56 AM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; mi...@kernel.org; h...@zytor.com;
> mj...@srcf.ucam.org; tony.l...@intel.com; j...@ozlabs.org;
> t...@jklm.no; t...@linutronix.de; mi...@google.com;
> linux-tip-comm...@vger.kernel.org
> Su
> -Original Message-
> From: Luis Henriques [mailto:luis.henriq...@canonical.com]
> Sent: Wednesday, April 10, 2013 8:18 AM
> To: Lingzhu Xiang
> Cc: Ben Hutchings; Seiji Aguchi; linux-kernel@vger.kernel.org;
> sta...@vger.kernel.org; kernel-t...@lists.ubuntu.com;
> -static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type,
> -int *count, struct timespec *timespec,
> -char **buf, struct pstore_info *psi)
> +struct pstore_read_data {
> + u64 *id;
> + enum pstore_type_id *type;
> + in
lugin function_graph
Seiji
> -Original Message-----
> From: Seiji Aguchi
> Sent: Friday, April 05, 2013 3:22 PM
> To: linux-kernel@vger.kernel.org; x...@kernel.org; rost...@goodmis.org;
> h...@zytor.com
> Cc: Thomas Gleixner (t...@linutronix.de); 'mi...@elte.hu' (mi
_exit();
irq_exit();
}
But it doesn't work, either.
If irq_enter() is nested, it may have a time penalty because it has to check if
it \
was already called or not. The time penalty is not desired in performance
sensitive \
paths even if it is tiny.
Signed-off-by: Seiji Aguchi
---
arch/x86/i
ng time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h
This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt
Signed-off-by: Seiji Aguchi
---
include/linux/tracepoint.h |2 ++
include/
ependently.
- local_timer_vector
- reschedule_vector
- call_function_vector
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each
ch 15, 2013 5:10 PM
> To: Seiji Aguchi
> Cc: H. Peter Anvin (h...@zytor.com); x...@kernel.org;
> linux-kernel@vger.kernel.org; Thomas Gleixner (t...@linutronix.de);
> 'mi...@elte.hu' (mi...@elte.hu); Borislav Petkov (b...@alien8.de); Satoru
> Moriya (smor...@redhat.co
This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt
Signed-off-by: Seiji Aguchi
---
include/linux/tracepoint.h |2 ++
include/
ot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt
Signed-off-by: Seiji Aguchi
---
include/linux/tracepoint.h |2 ++
include/trace/define_trace.h |
vector
- reschedule_vector
- call_function_vector
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
trac
ng time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h
_exit();
irq_exit();
}
But it doesn't work, either.
If irq_enter() is nested, it may have a time penalty because it has to check if
it \
was already called or not. The time penalty is not desired in performance
sensitive \
paths even if it is tiny.
Signed-off-by: Seiji Aguchi
---
arch/x86/i
Thank you for giving me the feedback.
>
> So it appears the problem occurs because the other CPUs are not offlined
> correctly, and still have pending work which may generate
> wakeup IPIs to them?
Right.
>
> The fix would be to either offline them properly - or, if we don't want to do
> tha
[] system_call_fastpath+0x16/0x1b
---[ end trace b3d5243c59d80624 ]---
[Solution]
Skip WARN_ON() when a panicked cpu which is set to stopping_cpu in
smp_send_stop() calls native_smp_send_reschedule().
Signed-off-by: Seiji Aguchi
---
arch/x86/kernel/smp.c |6 +-
1 files changed, 5
OK. I will update my patch.
Seiji
> -Original Message-
> From: Steven Rostedt [mailto:rost...@goodmis.org]
> Sent: Tuesday, February 19, 2013 1:41 PM
> To: H. Peter Anvin
> Cc: Seiji Aguchi; x...@kernel.org; linux-kernel@vger.kernel.org; Thomas
> Gleixner (t...@l
> > Not-yet-signed-off-by: Steven Rostedt
> >
> > ... so I was holding off on doing anything with it.
>
> Heh, and I was waiting for comments from you before doing anything further
> with it ;-)
>
> Email review deadlock!
So, how do you plan to push ahead with this patch?
https://lkml.org/lkm
ng time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h
_exit();
irq_exit();
}
But it doesn't work, either.
If irq_enter() is nested, it may have a time penalty because it has to check if
it was already called or not.
The time penalty is not desired in performance sensitive paths even if it is
tiny.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/
This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt
Signed-off-by: Seiji Aguchi
---
include/linux/tracepoint.h |2 ++
include/
tor
- reschedule_vector
- call_function_vector
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
t
> > How important is it that the tracepoint is *inside* the enter/exit
> > handling? If not, it would be simpler to just do:
> >
> > smp_trace_irq_handler()
> > {
> > trace_irq_entry();
> > smp_irq_handler();
> > trace_irq_exit();
> > }
> >
> > ... which seems a bit cleaner. If this i
riya; linux-kernel@vger.kernel.org;
> linux...@kvack.org; lwood...@redhat.com; Seiji Aguchi;
> a...@linux-foundation.org; hu...@google.com
> Subject: extra free kbytes tunable
>
> Hi,
>
> As discussed in this thread:
> http://marc.info/?l=linux-mm&m=131490523222031&
Peter,
Could you please review this patchset?
I have updated it in accordance with Steven's comment.
Seiji
> -Original Message-
> From: Seiji Aguchi
> Sent: Monday, February 04, 2013 5:49 PM
> To: 'Steven Rostedt'; x...@kernel.org; H. Peter Anvin (h...@
need to create sysfs entries because there is no chance
for
users to access to them.
efi_pstore will be robust against a kernel panic in an interrupt context with
this patch.
Signed-off-by: Seiji Aguchi
Acked-by: Matt Fleming
---
drivers/firmware/efivars.c |
ite() via kmsg_dump(KSMG_DUMP_PANIC)
And it can hold the lock successfully.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
Acked-by: Matt Fleming
---
drivers/firmware/efivars.c | 86 ++-
1 files changed, 44 insertions(+), 42 deletions(-)
diff --git
406
To resolve problems above, this patchset makes efivars/efi_pstore
interrupt-safe.
[Patch Description]
Please see detailed explanations in each patch.
Seiji Aguchi (2):
efivars: Disable external interrupt while holding efivars->lock
efi_pstore: Introducing workqu
Matt,
> Acked-by: Matt Fleming
>
> Tony, are you picking this up?
Thank you for reviewing and acking my patchset.
Tony,
This patchset can't be applied to a latest next tree due to following commits.
I will post v6 shortly to fit the latest next tree.
Then, please apply it.
efi: Make 'efi_ena
e to dynamic memory allocations during creating
>sysfs entries.
>An actual failure due to the create_sysfs_entry() has been reported.
>http://comments.gmane.org/gmane.linux.kernel.efi/406
>
> To resolve problems above, this patchset makes efivars/efi_pstore
> interrupt
trace handlers
* in a vector.
*/
trace_irq_exit(); /* tracepoint for irq exit */
exiting_irq(); /* post-processing of this handler */
}
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/apic.h | 27
ng time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h
This unfortunately
causes a lot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Steven Rostedt
Signed-off-by: Seiji Aguchi
---
include/linux/tracepoint.h |2 ++
include/
r
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
trace,x86: add x86 irq vector tracepoints
trace,x86: code-sharing between non-trace and trace irq handlers
Steven Ro
>
> Also, don't forget to add the mutex protection that I suggested in another
> email.
Will do.
Thanks,
Seiji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordo
> > +#include
> > +#include
> > +
> > +static struct desc_ptr trace_idt_descr = { NR_VECTORS * 16 - 1,
> > + (unsigned long) trace_idt_table };
> > +
> > +#ifndef CONFIG_X86_64
> > +gate_desc trace_idt_table[NR_VECTORS] __page_aligned_data
> > +
gt; From: Steven Rostedt [mailto:rost...@goodmis.org]
> Sent: Thursday, January 31, 2013 6:22 PM
> To: Seiji Aguchi
> Cc: x...@kernel.org; H. Peter Anvin (h...@zytor.com);
> linux-kernel@vger.kernel.org; Thomas Gleixner (t...@linutronix.de);
> 'mi...@elte.hu' (mi...@elte.hu); B
x27;t need to create sysfs entries because there is no chance
for
users to access to them.
efi_pstore will be robust against a kernel panic in an interrupt context with
this patch.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c | 85 +---
in
ite() via kmsg_dump(KSMG_DUMP_PANIC)
And it can hold the lock successfully.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/firmware/efivars.c | 86 ++-
1 files changed, 44 insertions(+), 42 deletions(-)
diff --git a/drivers/firmware/ef
to the create_sysfs_entry() has been reported.
http://comments.gmane.org/gmane.linux.kernel.efi/406
To resolve problems above, this patchset makes efivars/efi_pstore
interrupt-safe.
[Patch Description]
Please see detailed explanations in each patch.
Seiji Aguchi (2):
efivars: Disable external i
> >
> > @@ -918,10 +918,7 @@ acpi_os_read_memory(acpi_physical_address phys_addr,
> > u64 *value, u32 width)
> > virt_addr = acpi_map_vaddr_lookup(phys_addr, size);
> > if (!virt_addr) {
> > rcu_read_unlock();
> > - virt_addr = acpi_os_ioremap(phys_addr, size);
> >
[Issue]
Current erst driver is kicked in panic case.
On the other hand, a dynamic memory allocation seems to run in it
with a following code path.
erst_writer -> erst_write -> __erst_write_to_storage -> many of apei_exec_run
->
ctx->ins_table[entry->instruction].run()
which are functions defin
trace handlers
* in a vector.
*/
trace_irq_exit(); /* tracepoint for irq exit */
exiting_irq(); /* post-processing of this handler */
}
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/apic.h | 27
ng time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h
ot of wasted duplicate code created.
By adding a DEFINE_EVENT_FN(), these events can still use a
DECLARE_EVENT_CLASS() and then define their own triggers.
Signed-off-by: Seiji Aguchi
Signed-off-by: Steven Rostedt
---
include/linux/tracepoint.h |2 ++
include/trace/define_trace.h |
_timer_vector
- reschedule_vector
- call_function_vector
- call_function_single_vector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patc
Steven,
Thank you for reviewing my patchset.
I will update both patch 1/2 and 2/2 in accordance with your comment.
Seiji
> -Original Message-
> From: Steven Rostedt [mailto:rost...@goodmis.org]
> Sent: Tuesday, January 15, 2013 8:25 PM
> To: Seiji Aguchi
> Cc: x...@ke
: Thursday, January 10, 2013 6:55 PM
To: Luck, Tony
Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Seiji Aguchi
Subject: linux-next: build failure after merge of the ia64 tree
Hi all,
After merging the ia64 tree, today's linux-next build (x86_64_allmodconfig)
failed li
id the deadlock.
Signed-off-by: Seiji Aguchi
Acked-by: Don Zickus
Acked-by: Tony Luck
---
drivers/firmware/efivars.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 7b1c374..ef5070d 100644
--- a/d
* reboot the system. This is called when we know we are in
* trouble so this is our best effort to reboot. This is
* safe to call in interrupt context.
*/
void emergency_restart(void)
Signed-off-by: Seiji Aguchi
Acked-by: Don Zickus
Acked-by: Tony Luck
---
fs/pstore/platf
ths.
Please see each patch for detailed explanations.
Seiji Aguchi (2):
[PATCH v4 1/2] pstore: Avoid deadlock in panic and emergency-restart path
[PATCH v4 2/2] efi_pstore: Avoid deadlock in non-blocking paths
drivers/firmware/efivars.c | 11 ++-
fs/pstore/pla
Stephen, Tony,
I will take a look at it.
Seiji
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Thursday, January 10, 2013 6:55 PM
> To: Luck, Tony
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Seiji Aguchi
> S
tony.l...@gmail.com]
> Sent: Thursday, January 10, 2013 1:21 PM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; dzic...@redhat.com; ccr...@android.com;
> keesc...@chromium.org; cbouatmai...@gmail.com;
> Satoru Moriya; dle-deve...@lists.sourceforge.net
> Subject: Re: [PATC
and trace handlers
* in a vector.
*/
trace_irq_exit(); /* tracepoint for irq exit */
exiting_irq(); /* post-processing of this handler */
}
Signed-off-by: Seiji Aguchi
---
arch/x86/kernel/apic/apic.c | 103
ng time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h
ector
- irq_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
[RFC][PATCH v7 1/2] trace,x86: add x86 irq vector tracepoints
[RFC][PATCH v7 2/2] trace,x8
Tony,
Can you review this patchset?
Seiji
> -Original Message-
> From: Anton Vorontsov [mailto:cbouatmai...@gmail.com]
> Sent: Friday, December 21, 2012 6:37 PM
> To: Seiji Aguchi
> Cc: Luck, Tony (tony.l...@intel.com); linux-kernel@vger.kernel.org;
> ccr...@
Tony,
Could you please apply this patchset to your tree?
Seiji
> -Original Message-
> From: Don Zickus [mailto:dzic...@redhat.com]
> Sent: Thursday, December 20, 2012 2:09 PM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; Luck, Tony (tony.l...@intel.com);
>
id the deadlock.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 7b1c374..ef5070d 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/fi
king any locks
* reboot the system. This is called when we know we are in
* trouble so this is our best effort to reboot. This is
* safe to call in interrupt context.
*/
void emergency_restart(void)
Signed-off-by: Seiji Aguchi
---
fs/pstore/platf
s that pstore and efi_pstore driver are blocked
in the non-blocking paths like NMI, panic, and emrgency-restart
by introducing a function checking if they are in those paths.
Please see each patch for detailed explanations.
Seiji Aguchi (2):
[PATCH v3 1/2] pstore: Avoid deadlock in panic and
>Though it seems most of patch2 should have been in patch1 (except for the efi
>part).
OK. I will merge pstore part in patch2 to patch1.
>
> The only nitpick I have is the name 'is_non_blocking_path'. I don't know
> why, but the name doesn't seem exactly right to me. I was
> thinking some
Thank you for reviewing my patch.
I will update it in accordance with your comment.
Seiji
> -Original Message-
> From: Steven Rostedt [mailto:rost...@goodmis.org]
> Sent: Monday, December 17, 2012 10:02 PM
> To: Seiji Aguchi
> Cc: x...@kernel.org; linux-kernel@vger.kerne
e, at boot time by duplicating original IDT,
idt table, and
registering the new handers for tracpoints.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACEPOINTS is enabled to avoid being
used for other p
id the deadlock.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c | 11 ++-
fs/pstore/platform.c |6 +++---
include/linux/pstore.h |6 ++
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
* reboot the system. This is called when we know we are in
* trouble so this is our best effort to reboot. This is
* safe to call in interrupt context.
*/
void emergency_restart(void)
Signed-off-by: Seiji Aguchi
---
fs/pstore/platform.c | 34 -
ction checking if
they are in those paths.
Please see each patch for detailed explanations.
Seiji Aguchi (2):
[PATCH v2 1/2] pstore: Avoid deadlock in panic and emergency-restart path
[PATCH v2 2/2] efi_pstore: Avoid deadlock in non-blocking paths
drivers/firmware/efivars.c | 11
> A boot argument might help - so we can force use of pstore in cases where
> kdump is failing (or prevent use of pstore in cases where it
> seem to be preventing us getting to kdump ... I don't have a preference).
> BUT this would only be useful if we had a repeatable
> problem so that we could
> > If we can fix it with a small patch in adance, it is really helpful for us.
>
> As I said in my email I just sent, it may not help you without testing it.
> As there are probably other problems in that un-tested theoretical scenario.
OK. I understood.
> >
> > 2)
> > In the long term, I pla
> Now my first reaction would be, if that is the scenario, why couldn't cpuA
> release the lock within one second. Because if cpuA is stuck
> talking with firmware, then your patch to force the unlock is probably going
> to trip over the same problems.
> (those problems include dealing with rese
> Can all these things really happen (did you run into this problem on a real
> system?). Or is this just a theoretical problem. Ugly (but
> practical) hacks might be OK to solve real problems.
It is a theoretical problem right now.
But it is a timing issue and there is a possibility to happen
locking in x86 architecture.
Signed-off-by: Seiji Aguchi
---
fs/pstore/platform.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 947fbe0..ca4d2ab 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@
> What I actually meant was: can "this" CPU avoid stopping other CPUs so early?
> If we stop the other CPUs when this CPU is ready to
> stop itself then there will never be such deadlocks.
Let me explain my opinion.
When we focus on the deadlock only, the code will be simple by moving
smp_sen
Thank you for giving me the comment.
> - Makes the logic in this area even more twisty and complex, when
> what we need to do is to simplify it
>
> - Reinitialises in-use locks
>
> - Gives the boolean variable "yes" three states, but didn't rename
> that variable to something appropriate.
can't see panic messages.
[Solution]
this patch introduces a logic initializing logbuf_lock and console_sem
just after smp_send_stop() to avoid dead locks above.
Signed-off-by: Seiji Aguchi
---
include/linux/printk.h |5 +
kernel/panic.c |1 +
kernel/printk.c|
t; Anton Vorontsov; Seiji Aguchi
> Subject: linux-next: manual merge of the ia64 tree with Linus' tree
>
> Hi all,
>
> Today's linux-next merge of the ia64 tree got a conflict in
> fs/pstore/platform.c between commit 70a6f46d7b0e ("pstore: Fix NULL
> pointer deref
can't erase it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a erase callback to
make it erasable.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
dr
can't read it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a read callback
to make it readable.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
dr
In case of a write callback executed in pstore_console_write(), "0" is added to
an argument of the write callback because it just logs all kernel messages and
doesn't need to care about multiple events.
Signed-off-by: Seiji Aguchi
Acked-by: Rafael J. Wysocki
Acked-by: Mike Waych
at reading time.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/acpi/apei/erst.c |4 ++--
drivers/firmware/efivars.c | 17 -
fs/pstore/inode.c |3 ++-
fs/pstore/ram.c|2 +-
include/linux/pstore.h |2 +-
5 files changed
multiple logs.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/firmware/efivars.c | 39 ++-
1 files changed, 2 insertions(+), 37 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index bee14cc..fbe9202 100644
--- a
logs, the write callback doesn't need to erase any
entries and
it will be removed in a subsequent patch.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/firmware/efivars.c | 46 +++-
1 files changed, 45 insertions(+), 1 deletions(-)
ining space of
storage at writing time.
Therefore, efi_pstore may not work if it tries to write a large amount of data.
[Patch Description]
To avoid handling the situation above, this patch checks if there is a space
enough to log with
QueryVariableInfo() before writing data.
Signed-off-by:
ssions to find the possibility of introducing
overwriting
policy, especially getting critical messages in multiple oops case.
But I would like to begin with a simple and reasonable way to everyone.
So, this patch takes an approach just holding multiple logs.
Seiji Aguchi (7):
efi_p
can't erase it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a erase callback to
make it erasable.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
dr
can't read it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a read callback
to make it readable.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
dr
In case of a write callback executed in pstore_console_write(), "0" is added to
an argument of the write callback because it just logs all kernel messages and
doesn't need to care about multiple events.
Signed-off-by: Seiji Aguchi
Acked-by: Rafael J. Wysocki
Acked-by: Mike Waych
at reading time.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/acpi/apei/erst.c |4 ++--
drivers/firmware/efivars.c | 15 +++
fs/pstore/inode.c |3 ++-
fs/pstore/ram.c|2 +-
include/linux/pstore.h |2 +-
5 files changed
multiple logs.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/firmware/efivars.c | 39 ++-
1 files changed, 2 insertions(+), 37 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index bee14cc..fbe9202 100644
--- a
ining space of
storage at writing time.
Therefore, efi_pstore may not work if it tries to write a large amount of data.
[Patch Description]
To avoid handling the situation above, this patch checks if there is a space
enough to log with
QueryVariableInfo() before writing data.
Signed-off-by:
logs, the write callback doesn't need to erase any
entries and
it will be removed in a subsequent patch.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/firmware/efivars.c | 46 +++-
1 files changed, 45 insertions(+), 1 deletions(-)
urther discussions to find the possibility of introducing
overwriting
policy, especially getting critical messages in multiple oops case.
But I would like to begin with a simple and reasonable way to everyone.
So, this patch takes an approach just holding multiple logs.
Seiji Aguchi (7):
can't erase it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a erase callback to
make it erasable.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c |
can't read it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a read callback
to make it readable.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c |
are same among them.
it can be distinguishable by adding a sequence counter as follows.
a variable name of first event: dump-type0-1-1-12345678
a variable name of Second event: dump-type0-1-2-12345678
type:0
id:1
sequence counter: 1(first event), 2(second event)
ctime:12345678
at reading time.
Signed-off-by: Seiji Aguchi
---
drivers/acpi/apei/erst.c |4 ++--
drivers/firmware/efivars.c | 17 -
fs/pstore/inode.c |3 ++-
fs/pstore/ram.c|2 +-
include/linux/pstore.h |2 +-
5 files changed, 14 insertions(+), 14 del
101 - 200 of 299 matches
Mail list logo
