Steven,
Thank you for reviewing my patchset.
I will update both patch 1/2 and 2/2 in accordance with your comment.
Seiji
> -Original Message-
> From: Steven Rostedt [mailto:rost...@goodmis.org]
> Sent: Tuesday, January 15, 2013 8:25 PM
> To: Seiji Aguchi
> Cc: x...@ke
Steven,
Thank you for reviewing my patchset.
I will update both patch 1/2 and 2/2 in accordance with your comment.
Seiji
-Original Message-
From: Steven Rostedt [mailto:rost...@goodmis.org]
Sent: Tuesday, January 15, 2013 8:25 PM
To: Seiji Aguchi
Cc: x...@kernel.org; linux-kernel
, January 10, 2013 6:55 PM
To: Luck, Tony
Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Seiji Aguchi
Subject: linux-next: build failure after merge of the ia64 tree
Hi all,
After merging the ia64 tree, today's linux-next build (x86_64_allmodconfig)
failed like this:
ERROR
avoid the deadlock.
Signed-off-by: Seiji Aguchi
Acked-by: Don Zickus
Acked-by: Tony Luck
---
drivers/firmware/efivars.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 7b1c374..ef5070d 100644
--- a/d
reboot the system. This is called when we know we are in
* trouble so this is our best effort to reboot. This is
* safe to call in interrupt context.
*/
void emergency_restart(void)
Signed-off-by: Seiji Aguchi
Acked-by: Don Zickus
Acked-by: Tony Luck
---
fs/pstore/platform.c
Please see each patch for detailed explanations.
Seiji Aguchi (2):
[PATCH v4 1/2] pstore: Avoid deadlock in panic and emergency-restart path
[PATCH v4 2/2] efi_pstore: Avoid deadlock in non-blocking paths
drivers/firmware/efivars.c | 11 ++-
fs/pstore/platform
for detailed explanations.
Seiji Aguchi (2):
[PATCH v4 1/2] pstore: Avoid deadlock in panic and emergency-restart path
[PATCH v4 2/2] efi_pstore: Avoid deadlock in non-blocking paths
drivers/firmware/efivars.c | 11 ++-
fs/pstore/platform.c | 35
* reboot the system. This is called when we know we are in
* trouble so this is our best effort to reboot. This is
* safe to call in interrupt context.
*/
void emergency_restart(void)
snip
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Don Zickus dzic...@redhat.com
Acked
the deadlock.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Don Zickus dzic...@redhat.com
Acked-by: Tony Luck tony.l...@intel.com
---
drivers/firmware/efivars.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware
: Thursday, January 10, 2013 6:55 PM
To: Luck, Tony
Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Seiji Aguchi
Subject: linux-next: build failure after merge of the ia64 tree
Hi all,
After merging the ia64 tree, today's linux-next build (x86_64_allmodconfig)
failed like this:
ERROR
Stephen, Tony,
I will take a look at it.
Seiji
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Thursday, January 10, 2013 6:55 PM
> To: Luck, Tony
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Seiji Aguchi
> S
tony.l...@gmail.com]
> Sent: Thursday, January 10, 2013 1:21 PM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; dzic...@redhat.com; ccr...@android.com;
> keesc...@chromium.org; cbouatmai...@gmail.com;
> Satoru Moriya; dle-deve...@lists.sourceforge.net
> Subject: Re: [
and trace handlers
* in a vector.
*/
trace_irq_exit(); /* tracepoint for irq exit */
exiting_irq(); /* post-processing of this handler */
}
Signed-off-by: Seiji Aguchi
---
arch/x86/kernel/apic/apic.c | 103
of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi
---
arch/x86/include/asm/desc.h | 31
_work_entry_vector
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
[RFC][PATCH v7 1/2] trace,x86: add x86 irq vector tracepoints
[RFC][PATCH v7 2/2] trace,x86: code-sharing
- error_apic_vector
- thermal_apic_vector
- threshold_apic_vector
- spurious_apic_vector
- x86_platform_ipi_vector
Please see descriptions in each patch.
Seiji Aguchi (2):
[RFC][PATCH v7 1/2] trace,x86: add x86 irq vector tracepoints
[RFC][PATCH v7 2/2] trace,x86: code-sharing between non
time of irq_vector handlers.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACING is enabled to avoid being used
for other purposes.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm
and trace handlers
* in a vector.
*/
trace_irq_exit(); /* tracepoint for irq exit */
exiting_irq(); /* post-processing of this handler */
}
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/kernel/apic/apic.c
: Thursday, January 10, 2013 1:21 PM
To: Seiji Aguchi
Cc: linux-kernel@vger.kernel.org; dzic...@redhat.com; ccr...@android.com;
keesc...@chromium.org; cbouatmai...@gmail.com;
Satoru Moriya; dle-deve...@lists.sourceforge.net
Subject: Re: [PATCH v3 1/2] pstore: Avoid deadlock in panic
Stephen, Tony,
I will take a look at it.
Seiji
-Original Message-
From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
Sent: Thursday, January 10, 2013 6:55 PM
To: Luck, Tony
Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Seiji Aguchi
Subject: linux-next: build
Tony,
Can you review this patchset?
Seiji
> -Original Message-
> From: Anton Vorontsov [mailto:cbouatmai...@gmail.com]
> Sent: Friday, December 21, 2012 6:37 PM
> To: Seiji Aguchi
> Cc: Luck, Tony (tony.l...@intel.com); linux-kernel@vger.kernel.org;
> ccr...@
Tony,
Can you review this patchset?
Seiji
-Original Message-
From: Anton Vorontsov [mailto:cbouatmai...@gmail.com]
Sent: Friday, December 21, 2012 6:37 PM
To: Seiji Aguchi
Cc: Luck, Tony (tony.l...@intel.com); linux-kernel@vger.kernel.org;
ccr...@android.com; keesc
Tony,
Could you please apply this patchset to your tree?
Seiji
> -Original Message-
> From: Don Zickus [mailto:dzic...@redhat.com]
> Sent: Thursday, December 20, 2012 2:09 PM
> To: Seiji Aguchi
> Cc: linux-kernel@vger.kernel.org; Luck, Tony (tony.l...@intel.com);
>
Tony,
Could you please apply this patchset to your tree?
Seiji
-Original Message-
From: Don Zickus [mailto:dzic...@redhat.com]
Sent: Thursday, December 20, 2012 2:09 PM
To: Seiji Aguchi
Cc: linux-kernel@vger.kernel.org; Luck, Tony (tony.l...@intel.com);
ccr...@android.com; keesc
avoid the deadlock.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 7b1c374..ef5070d 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/fi
any locks
* reboot the system. This is called when we know we are in
* trouble so this is our best effort to reboot. This is
* safe to call in interrupt context.
*/
void emergency_restart(void)
Signed-off-by: Seiji Aguchi
---
fs/pstore/platform.c
that pstore and efi_pstore driver are blocked
in the non-blocking paths like NMI, panic, and emrgency-restart
by introducing a function checking if they are in those paths.
Please see each patch for detailed explanations.
Seiji Aguchi (2):
[PATCH v3 1/2] pstore: Avoid deadlock in panic and emerg
>Though it seems most of patch2 should have been in patch1 (except for the efi
>part).
OK. I will merge pstore part in patch2 to patch1.
>
> The only nitpick I have is the name 'is_non_blocking_path'. I don't know
> why, but the name doesn't seem exactly right to me. I was
> thinking
Though it seems most of patch2 should have been in patch1 (except for the efi
part).
OK. I will merge pstore part in patch2 to patch1.
The only nitpick I have is the name 'is_non_blocking_path'. I don't know
why, but the name doesn't seem exactly right to me. I was
thinking something
and efi_pstore driver are blocked
in the non-blocking paths like NMI, panic, and emrgency-restart
by introducing a function checking if they are in those paths.
Please see each patch for detailed explanations.
Seiji Aguchi (2):
[PATCH v3 1/2] pstore: Avoid deadlock in panic and emergency-restart path
* reboot the system. This is called when we know we are in
* trouble so this is our best effort to reboot. This is
* safe to call in interrupt context.
*/
void emergency_restart(void)
snip
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
fs/pstore/platform.c | 34
the deadlock.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
drivers/firmware/efivars.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 7b1c374..ef5070d 100644
--- a/drivers/firmware/efivars.c
+++ b
Thank you for reviewing my patch.
I will update it in accordance with your comment.
Seiji
> -Original Message-
> From: Steven Rostedt [mailto:rost...@goodmis.org]
> Sent: Monday, December 17, 2012 10:02 PM
> To: Seiji Aguchi
> Cc: x...@kernel.org; linux-kernel@vger.kerne
by duplicating original IDT,
idt table, and
registering the new handers for tracpoints.
- Switch IDT to new one at enabling TP time.
- Restore to an original IDT at disabling TP time.
The new IDT is created only when CONFIG_TRACEPOINTS is enabled to avoid being
used for other purposes.
Signe
avoid the deadlock.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c | 11 ++-
fs/pstore/platform.c |6 +++---
include/linux/pstore.h |6 ++
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
reboot the system. This is called when we know we are in
* trouble so this is our best effort to reboot. This is
* safe to call in interrupt context.
*/
void emergency_restart(void)
Signed-off-by: Seiji Aguchi
---
fs/pstore/platform.c | 34 --
checking if
they are in those paths.
Please see each patch for detailed explanations.
Seiji Aguchi (2):
[PATCH v2 1/2] pstore: Avoid deadlock in panic and emergency-restart path
[PATCH v2 2/2] efi_pstore: Avoid deadlock in non-blocking paths
drivers/firmware/efivars.c | 11 ++-
if
they are in those paths.
Please see each patch for detailed explanations.
Seiji Aguchi (2):
[PATCH v2 1/2] pstore: Avoid deadlock in panic and emergency-restart path
[PATCH v2 2/2] efi_pstore: Avoid deadlock in non-blocking paths
drivers/firmware/efivars.c | 11 ++-
fs/pstore
* reboot the system. This is called when we know we are in
* trouble so this is our best effort to reboot. This is
* safe to call in interrupt context.
*/
void emergency_restart(void)
snip
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
fs/pstore/platform.c | 34
the deadlock.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
drivers/firmware/efivars.c | 11 ++-
fs/pstore/platform.c |6 +++---
include/linux/pstore.h |6 ++
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware
-by: Seiji Aguchi seiji.agu...@hds.com
---
arch/x86/include/asm/desc.h | 27 +
arch/x86/include/asm/entry_arch.h| 32 +
arch/x86/include/asm/hw_irq.h| 14 +++
arch/x86/kernel/Makefile |1 +
arch/x86/kernel/apic/apic.c | 186
Thank you for reviewing my patch.
I will update it in accordance with your comment.
Seiji
-Original Message-
From: Steven Rostedt [mailto:rost...@goodmis.org]
Sent: Monday, December 17, 2012 10:02 PM
To: Seiji Aguchi
Cc: x...@kernel.org; linux-kernel@vger.kernel.org; H. Peter Anvin
> A boot argument might help - so we can force use of pstore in cases where
> kdump is failing (or prevent use of pstore in cases where it
> seem to be preventing us getting to kdump ... I don't have a preference).
> BUT this would only be useful if we had a repeatable
> problem so that we
> > If we can fix it with a small patch in adance, it is really helpful for us.
>
> As I said in my email I just sent, it may not help you without testing it.
> As there are probably other problems in that un-tested theoretical scenario.
OK. I understood.
> >
> > 2)
> > In the long term, I
> Now my first reaction would be, if that is the scenario, why couldn't cpuA
> release the lock within one second. Because if cpuA is stuck
> talking with firmware, then your patch to force the unlock is probably going
> to trip over the same problems.
> (those problems include dealing with
Now my first reaction would be, if that is the scenario, why couldn't cpuA
release the lock within one second. Because if cpuA is stuck
talking with firmware, then your patch to force the unlock is probably going
to trip over the same problems.
(those problems include dealing with
If we can fix it with a small patch in adance, it is really helpful for us.
As I said in my email I just sent, it may not help you without testing it.
As there are probably other problems in that un-tested theoretical scenario.
OK. I understood.
2)
In the long term, I plan to add a
A boot argument might help - so we can force use of pstore in cases where
kdump is failing (or prevent use of pstore in cases where it
seem to be preventing us getting to kdump ... I don't have a preference).
BUT this would only be useful if we had a repeatable
problem so that we could
> Can all these things really happen (did you run into this problem on a real
> system?). Or is this just a theoretical problem. Ugly (but
> practical) hacks might be OK to solve real problems.
It is a theoretical problem right now.
But it is a timing issue and there is a possibility to happen
ng in x86 architecture.
Signed-off-by: Seiji Aguchi
---
fs/pstore/platform.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 947fbe0..ca4d2ab 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -107
architecture.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
fs/pstore/platform.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 947fbe0..ca4d2ab 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
Can all these things really happen (did you run into this problem on a real
system?). Or is this just a theoretical problem. Ugly (but
practical) hacks might be OK to solve real problems.
It is a theoretical problem right now.
But it is a timing issue and there is a possibility to happen
> What I actually meant was: can "this" CPU avoid stopping other CPUs so early?
> If we stop the other CPUs when this CPU is ready to
> stop itself then there will never be such deadlocks.
Let me explain my opinion.
When we focus on the deadlock only, the code will be simple by moving
Thank you for giving me the comment.
> - Makes the logic in this area even more twisty and complex, when
> what we need to do is to simplify it
>
> - Reinitialises in-use locks
>
> - Gives the boolean variable "yes" three states, but didn't rename
> that variable to something appropriate.
can't see panic messages.
[Solution]
this patch introduces a logic initializing logbuf_lock and console_sem
just after smp_send_stop() to avoid dead locks above.
Signed-off-by: Seiji Aguchi
---
include/linux/printk.h |5 +
kernel/panic.c |1 +
kernel/printk.c| 17
can't see panic messages.
[Solution]
this patch introduces a logic initializing logbuf_lock and console_sem
just after smp_send_stop() to avoid dead locks above.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
---
include/linux/printk.h |5 +
kernel/panic.c |1 +
kernel/printk.c
Thank you for giving me the comment.
- Makes the logic in this area even more twisty and complex, when
what we need to do is to simplify it
- Reinitialises in-use locks
- Gives the boolean variable yes three states, but didn't rename
that variable to something appropriate.
I
What I actually meant was: can this CPU avoid stopping other CPUs so early?
If we stop the other CPUs when this CPU is ready to
stop itself then there will never be such deadlocks.
Let me explain my opinion.
When we focus on the deadlock only, the code will be simple by moving
t; Anton Vorontsov; Seiji Aguchi
> Subject: linux-next: manual merge of the ia64 tree with Linus' tree
>
> Hi all,
>
> Today's linux-next merge of the ia64 tree got a conflict in
> fs/pstore/platform.c between commit 70a6f46d7b0e ("pstore: Fix NULL
> pointer dereference in
Hi,
This fix is reasonable to me.
Thanks,
Seiji
-Original Message-
From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
Sent: Sunday, November 25, 2012 7:32 PM
To: Luck, Tony
Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Colin Ian King;
Anton Vorontsov; Seiji
can't erase it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a erase callback to
make it erasable.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers
can't read it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a read callback
to make it readable.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers
of a write callback executed in pstore_console_write(), "0" is added to
an argument of the write callback because it just logs all kernel messages and
doesn't need to care about multiple events.
Signed-off-by: Seiji Aguchi
Acked-by: Rafael J. Wysocki
Acked-by: Mike Waychison
---
driv
.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/acpi/apei/erst.c |4 ++--
drivers/firmware/efivars.c | 17 -
fs/pstore/inode.c |3 ++-
fs/pstore/ram.c|2 +-
include/linux/pstore.h |2 +-
5 files changed, 14 insertions
multiple logs.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/firmware/efivars.c | 39 ++-
1 files changed, 2 insertions(+), 37 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index bee14cc..fbe9202 100644
logs, the write callback doesn't need to erase any
entries and
it will be removed in a subsequent patch.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/firmware/efivars.c | 46 +++-
1 files changed, 45 insertions(+), 1 deletions(-)
diff
at writing time.
Therefore, efi_pstore may not work if it tries to write a large amount of data.
[Patch Description]
To avoid handling the situation above, this patch checks if there is a space
enough to log with
QueryVariableInfo() before writing data.
Signed-off-by: Seiji Aguchi
Acked-by: Mike
the possibility of introducing
overwriting
policy, especially getting critical messages in multiple oops case.
But I would like to begin with a simple and reasonable way to everyone.
So, this patch takes an approach just holding multiple logs.
Seiji Aguchi (7):
efi_pstore: Check
of introducing
overwriting
policy, especially getting critical messages in multiple oops case.
But I would like to begin with a simple and reasonable way to everyone.
So, this patch takes an approach just holding multiple logs.
Seiji Aguchi (7):
efi_pstore: Check remaining space
at writing time.
Therefore, efi_pstore may not work if it tries to write a large amount of data.
[Patch Description]
To avoid handling the situation above, this patch checks if there is a space
enough to log with
QueryVariableInfo() before writing data.
Signed-off-by: Seiji Aguchi seiji.agu
logs, the write callback doesn't need to erase any
entries and
it will be removed in a subsequent patch.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike Waychison mi...@google.com
---
drivers/firmware/efivars.c | 46 +++-
1 files changed, 45
multiple logs.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike Waychison mi...@google.com
---
drivers/firmware/efivars.c | 39 ++-
1 files changed, 2 insertions(+), 37 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
at reading time.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike Waychison mi...@google.com
---
drivers/acpi/apei/erst.c |4 ++--
drivers/firmware/efivars.c | 17 -
fs/pstore/inode.c |3 ++-
fs/pstore/ram.c|2 +-
include/linux/pstore.h
(second event)
ctime:12345678
In case of a write callback executed in pstore_console_write(), 0 is added to
an argument of the write callback because it just logs all kernel messages and
doesn't need to care about multiple events.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Rafael J
can't read it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a read callback
to make it readable.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike
can't erase it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a erase callback to
make it erasable.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike
can't erase it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a erase callback to
make it erasable.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers
can't read it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a read callback
to make it readable.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers
of a write callback executed in pstore_console_write(), "0" is added to
an argument of the write callback because it just logs all kernel messages and
doesn't need to care about multiple events.
Signed-off-by: Seiji Aguchi
Acked-by: Rafael J. Wysocki
Acked-by: Mike Waychison
---
driv
.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/acpi/apei/erst.c |4 ++--
drivers/firmware/efivars.c | 15 +++
fs/pstore/inode.c |3 ++-
fs/pstore/ram.c|2 +-
include/linux/pstore.h |2 +-
5 files changed, 13 insertions
multiple logs.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/firmware/efivars.c | 39 ++-
1 files changed, 2 insertions(+), 37 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index bee14cc..fbe9202 100644
at writing time.
Therefore, efi_pstore may not work if it tries to write a large amount of data.
[Patch Description]
To avoid handling the situation above, this patch checks if there is a space
enough to log with
QueryVariableInfo() before writing data.
Signed-off-by: Seiji Aguchi
Acked-by: Mike
logs, the write callback doesn't need to erase any
entries and
it will be removed in a subsequent patch.
Signed-off-by: Seiji Aguchi
Acked-by: Mike Waychison
---
drivers/firmware/efivars.c | 46 +++-
1 files changed, 45 insertions(+), 1 deletions(-)
diff
ions to find the possibility of introducing
overwriting
policy, especially getting critical messages in multiple oops case.
But I would like to begin with a simple and reasonable way to everyone.
So, this patch takes an approach just holding multiple logs.
Seiji Aguchi (7):
efi_pstore: Check rem
the possibility of introducing
overwriting
policy, especially getting critical messages in multiple oops case.
But I would like to begin with a simple and reasonable way to everyone.
So, this patch takes an approach just holding multiple logs.
Seiji Aguchi (7):
efi_pstore: Check remaining space
logs, the write callback doesn't need to erase any
entries and
it will be removed in a subsequent patch.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike Waychison mi...@google.com
---
drivers/firmware/efivars.c | 46 +++-
1 files changed, 45
at writing time.
Therefore, efi_pstore may not work if it tries to write a large amount of data.
[Patch Description]
To avoid handling the situation above, this patch checks if there is a space
enough to log with
QueryVariableInfo() before writing data.
Signed-off-by: Seiji Aguchi seiji.agu
multiple logs.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike Waychison mi...@google.com
---
drivers/firmware/efivars.c | 39 ++-
1 files changed, 2 insertions(+), 37 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
at reading time.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike Waychison mi...@google.com
---
drivers/acpi/apei/erst.c |4 ++--
drivers/firmware/efivars.c | 15 +++
fs/pstore/inode.c |3 ++-
fs/pstore/ram.c|2 +-
include/linux/pstore.h
(second event)
ctime:12345678
In case of a write callback executed in pstore_console_write(), 0 is added to
an argument of the write callback because it just logs all kernel messages and
doesn't need to care about multiple events.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Rafael J
can't read it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a read callback
to make it readable.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike
can't erase it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a erase callback to
make it erasable.
Signed-off-by: Seiji Aguchi seiji.agu...@hds.com
Acked-by: Mike
can't erase it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a erase callback to
make it erasable.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c | 20
can't read it via /dev/pstore.
Format of old variable name
dump-type0-1-12345678
type:0
id:1
ctime:12345678
[Solution]
This patch add a format check for the old variable name in a read callback
to make it readable.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c | 38
among them.
it can be distinguishable by adding a sequence counter as follows.
a variable name of first event: dump-type0-1-1-12345678
a variable name of Second event: dump-type0-1-2-12345678
type:0
id:1
sequence counter: 1(first event), 2(second event)
ctime:12345678
Signed-off
.
Signed-off-by: Seiji Aguchi
---
drivers/acpi/apei/erst.c |4 ++--
drivers/firmware/efivars.c | 17 -
fs/pstore/inode.c |3 ++-
fs/pstore/ram.c|2 +-
include/linux/pstore.h |2 +-
5 files changed, 14 insertions(+), 14 deletions(-)
diff
multiple logs.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c | 39 ++-
1 files changed, 2 insertions(+), 37 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index bee14cc..fbe9202 100644
--- a/drivers/firmware
logs, the write callback doesn't need to erase any
entries and
it will be removed in a subsequent patch.
Signed-off-by: Seiji Aguchi
---
drivers/firmware/efivars.c | 46 +++-
1 files changed, 45 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware
at writing time.
Therefore, efi_pstore may not work if it tries to write a large amount of data.
[Patch Description]
To avoid handling the situation above, this patch checks if there is a space
enough to log with
QueryVariableInfo() before writing data.
Signed-off-by: Seiji Aguchi
Acked-by: Mike
his patch takes an approach just holding multiple logs.
[Patch Description]
Seiji Aguchi (7):
efi_pstore: Check remaining space with QueryVariableInfo() before
writing data
efi_pstore: Add a logic erasing entries to an erase callback
efi_pstore: Remove a logic erasing entries from a write
301 - 400 of 598 matches
Mail list logo
