Re: [PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:40, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote: This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. I don't understand

Re: [PATCH v1 2/9] staging: android: binder: Add binder_copy_to_user()

2013-12-05 Thread Serban Constantinescu
On 04/12/13 23:17, Greg KH wrote: On Wed, Dec 04, 2013 at 06:09:34PM +, Serban Constantinescu wrote: This patch adds binder_copy_to_user() to be used for copying binder commands to user address space. This way we can abstract away the copy_to_user() calls and add separate handling

Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:00, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote: +static void bc_dead_binder_done(struct binder_proc *proc, + struct binder_thread *thread, void __user *cookie) +{ + struct binder_work *w; + struct

Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:18, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote: +static void bc_increfs_done(struct binder_proc *proc, + struct binder_thread *thread, uint32_t cmd, + void __user *node_ptr, void __user *cookie

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-05 Thread Serban Constantinescu
_t != void *). Author: Serban Constantinescu Date: Thu Jul 4 10:54:48 2013 +0100 staging: android: binder: fix binder interface for 64bit compat layer *64bit kernel/ 64bit coexisting with 32bit userspace Please note that *none of the above solutions fix this yet*. To understand why this is a sp

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-05 Thread Serban Constantinescu
*). Author: Serban Constantinescu serban.constantine...@arm.com Date: Thu Jul 4 10:54:48 2013 +0100 staging: android: binder: fix binder interface for 64bit compat layer *64bit kernel/ 64bit coexisting with 32bit userspace Please note that *none of the above solutions fix this yet*. To understand

Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:18, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote: +static void bc_increfs_done(struct binder_proc *proc, + struct binder_thread *thread, uint32_t cmd, + void __user *node_ptr, void __user *cookie

Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:00, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:33PM +, Serban Constantinescu wrote: +static void bc_dead_binder_done(struct binder_proc *proc, + struct binder_thread *thread, void __user *cookie) +{ + struct binder_work *w; + struct

Re: [PATCH v1 2/9] staging: android: binder: Add binder_copy_to_user()

2013-12-05 Thread Serban Constantinescu
On 04/12/13 23:17, Greg KH wrote: On Wed, Dec 04, 2013 at 06:09:34PM +, Serban Constantinescu wrote: This patch adds binder_copy_to_user() to be used for copying binder commands to user address space. This way we can abstract away the copy_to_user() calls and add separate handling

Re: [PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-05 Thread Serban Constantinescu
On 05/12/13 08:40, Dan Carpenter wrote: On Wed, Dec 04, 2013 at 06:09:35PM +, Serban Constantinescu wrote: This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. I don't understand

[PATCH v1 5/9] staging: android: binder: Add deref_helper() macro

2013-12-04 Thread Serban Constantinescu
-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 6719a53..95c2581 100644 --- a/drivers/staging/android

[PATCH v1 4/9] staging: android: binder: Add align_helper() macro

2013-12-04 Thread Serban Constantinescu
This patch adds align_helper() macro that will be used for enforcing the desired alignment on 64bit systems where the alignment will differ depending on the userspace used (32bit /64bit). This patch is a temporary patch that will be extended with 32bit compat handling. Signed-off-by: Serban

[PATCH v1 8/9] staging: android: binder: Add binder compat handling to binder.h

2013-12-04 Thread Serban Constantinescu
This patch adds all the needed compat structures to binder.h. All the structures defined in this patch mirror the structure and size of 32bit ones. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.h | 109 ++ 1 file changed, 109

[PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Serban Constantinescu
This patch adds support for 32bit userspace running on 64bit kernels. All the changes done in this patch have been tested on 32bit and 64bit systems. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 355 +- 1 file changed, 353

[PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-04 Thread Serban Constantinescu
This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 35 ++- 1 file changed, 18

[PATCH v1 7/9] staging: android: binder: Add copy_flat_binder_object()

2013-12-04 Thread Serban Constantinescu
This patch adds copy_flat_binder_object macro() that will help dereference struct flat_binder_object on 64bit systems where the structure differs between 32bit and 64bit userspace. This patch is a temporary patch that will be extended with 32bit compat handling. Signed-off-by: Serban

[PATCH v1 6/9] staging: android: binder: Add size_helper() macro

2013-12-04 Thread Serban Constantinescu
-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 95c2581..6d22717 100644 --- a/drivers/staging/android/binder.c +++ b

[PATCH v1 0/9] Android: Add Support for Binder Compat

2013-12-04 Thread Serban Constantinescu
that the helper macros are extended with compat handling by the last patch of the series. The patches have been successfully tested on 32 and 64bit platforms. Thanks for your help, Best regards, Serban Constantinescu Serban Constantinescu (9): staging: android: binder: Move some of the logic

[PATCH v1 2/9] staging: android: binder: Add binder_copy_to_user()

2013-12-04 Thread Serban Constantinescu
This patch adds binder_copy_to_user() to be used for copying binder commands to user address space. This way we can abstract away the copy_to_user() calls and add separate handling for the compat layer. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 39

[PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-04 Thread Serban Constantinescu
This patch moves some of the logic for binder_thread_write() into subfunctions. This way we can share more code with the binder compat layer. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 403 +- 1 file changed, 220 insertions

[PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

2013-12-04 Thread Serban Constantinescu
This patch moves some of the logic for binder_thread_write() into subfunctions. This way we can share more code with the binder compat layer. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c | 403 +- 1

[PATCH v1 2/9] staging: android: binder: Add binder_copy_to_user()

2013-12-04 Thread Serban Constantinescu
This patch adds binder_copy_to_user() to be used for copying binder commands to user address space. This way we can abstract away the copy_to_user() calls and add separate handling for the compat layer. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging

[PATCH v1 0/9] Android: Add Support for Binder Compat

2013-12-04 Thread Serban Constantinescu
that the helper macros are extended with compat handling by the last patch of the series. The patches have been successfully tested on 32 and 64bit platforms. Thanks for your help, Best regards, Serban Constantinescu Serban Constantinescu (9): staging: android: binder: Move some of the logic

[PATCH v1 7/9] staging: android: binder: Add copy_flat_binder_object()

2013-12-04 Thread Serban Constantinescu
This patch adds copy_flat_binder_object macro() that will help dereference struct flat_binder_object on 64bit systems where the structure differs between 32bit and 64bit userspace. This patch is a temporary patch that will be extended with 32bit compat handling. Signed-off-by: Serban

[PATCH v1 6/9] staging: android: binder: Add size_helper() macro

2013-12-04 Thread Serban Constantinescu
-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 95c2581..6d22717 100644 --- a/drivers

[PATCH v1 3/9] staging: android: binder: Add cmd == CMD_NAME handling

2013-12-04 Thread Serban Constantinescu
This patch modifies the functions that need to be passed the explicit command to use a boolean flag. This way we can reuse the code for 64bit compat commands. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c | 35

[PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Serban Constantinescu
This patch adds support for 32bit userspace running on 64bit kernels. All the changes done in this patch have been tested on 32bit and 64bit systems. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c | 355

[PATCH v1 8/9] staging: android: binder: Add binder compat handling to binder.h

2013-12-04 Thread Serban Constantinescu
This patch adds all the needed compat structures to binder.h. All the structures defined in this patch mirror the structure and size of 32bit ones. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.h | 109

[PATCH v1 4/9] staging: android: binder: Add align_helper() macro

2013-12-04 Thread Serban Constantinescu
This patch adds align_helper() macro that will be used for enforcing the desired alignment on 64bit systems where the alignment will differ depending on the userspace used (32bit /64bit). This patch is a temporary patch that will be extended with 32bit compat handling. Signed-off-by: Serban

[PATCH v1 5/9] staging: android: binder: Add deref_helper() macro

2013-12-04 Thread Serban Constantinescu
-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 6719a53..95c2581 100644

[PATCH v6 5/6] staging: android: binder: replace types with portable ones

2013-07-04 Thread Serban Constantinescu
he Android filesystem. The patch does not change in any way the functionality of the binder driver. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

[PATCH v6 2/6] staging: android: binder: fix BINDER_SET_MAX_THREADS declaration

2013-07-04 Thread Serban Constantinescu
for a 64bit size_t on 64bit platforms). The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/binder.h b/drivers

[PATCH v6 6/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-07-04 Thread Serban Constantinescu
as well as user-exportable ones and fix format specifier issues. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.c | 20 ++-- drivers/staging/android/binder.h | 12 ++-- 2 files

[PATCH v6 3/6] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration

2013-07-04 Thread Serban Constantinescu
will also ease our work in differentiating BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER. The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v6 4/6] staging: android: binder: fix alignment issues

2013-07-04 Thread Serban Constantinescu
-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index ce70909..7450d56 100644 --- a/drivers/staging/android/binder.c

[PATCH v6 1/6] staging: android: binder: modify struct binder_write_read to use size_t

2013-07-04 Thread Serban Constantinescu
. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.c | 10 +- drivers/staging/android/binder.h |8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging

[PATCH v6 0/6] Android Binder IPC Fixes

2013-07-04 Thread Serban Constantinescu
to Arve's review Changes for v2: 1: 1/7: Modified the commit message according to Greg's feedback; 2: 3/7: Merged with the patch fixing the printk format specifiers. Serban Constantinescu (6): staging: android: binder: modify struct binder_write_read to use size_t staging: android: b

Re: [PATCH v5 0/6] Android Binder IPC Fixes

2013-07-04 Thread Serban Constantinescu
On 03/07/13 23:32, Arve Hjønnevåg wrote: On Wed, Jul 3, 2013 at 9:35 AM, Serban Constantinescu wrote: Hi all, Any feedback or comments on this patch set? Thanks, Serban The new patches look OK, but I would like to also see the patches that add support for 32 bit user-space on a 64 bit

Re: [PATCH v5 5/6] staging: android: binder: replace types with portable ones

2013-07-04 Thread Serban Constantinescu
On 03/07/13 23:30, Arve Hjønnevåg wrote: On Wed, Jun 19, 2013 at 10:12 AM, Serban Constantinescu wrote: Since this driver is meant to be used on different types of processors and a portable driver should specify the size a variable expects to be this patch changes the types used throughout

Re: [PATCH v5 5/6] staging: android: binder: replace types with portable ones

2013-07-04 Thread Serban Constantinescu
On 03/07/13 23:30, Arve Hjønnevåg wrote: On Wed, Jun 19, 2013 at 10:12 AM, Serban Constantinescu serban.constantine...@arm.com wrote: Since this driver is meant to be used on different types of processors and a portable driver should specify the size a variable expects to be this patch changes

Re: [PATCH v5 0/6] Android Binder IPC Fixes

2013-07-04 Thread Serban Constantinescu
On 03/07/13 23:32, Arve Hjønnevåg wrote: On Wed, Jul 3, 2013 at 9:35 AM, Serban Constantinescu serban.constantine...@arm.com wrote: Hi all, Any feedback or comments on this patch set? Thanks, Serban The new patches look OK, but I would like to also see the patches that add support for 32

[PATCH v6 1/6] staging: android: binder: modify struct binder_write_read to use size_t

2013-07-04 Thread Serban Constantinescu
. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.c | 10 +- drivers/staging/android/binder.h |8 2 files changed, 9 insertions(+), 9

[PATCH v6 0/6] Android Binder IPC Fixes

2013-07-04 Thread Serban Constantinescu
review Changes for v2: 1: 1/7: Modified the commit message according to Greg's feedback; 2: 3/7: Merged with the patch fixing the printk format specifiers. Serban Constantinescu (6): staging: android: binder: modify struct binder_write_read to use size_t staging: android: binder: fix

[PATCH v6 3/6] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration

2013-07-04 Thread Serban Constantinescu
in differentiating BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER. The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion

[PATCH v6 4/6] staging: android: binder: fix alignment issues

2013-07-04 Thread Serban Constantinescu
-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index ce70909..7450d56

[PATCH v6 6/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-07-04 Thread Serban Constantinescu
as well as user-exportable ones and fix format specifier issues. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.c | 20 ++-- drivers/staging

[PATCH v6 2/6] staging: android: binder: fix BINDER_SET_MAX_THREADS declaration

2013-07-04 Thread Serban Constantinescu
for a 64bit size_t on 64bit platforms). The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v6 5/6] staging: android: binder: replace types with portable ones

2013-07-04 Thread Serban Constantinescu
filesystem. The patch does not change in any way the functionality of the binder driver. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.h | 26 +- 1 file changed, 13 insertions

Re: [PATCH v5 0/6] Android Binder IPC Fixes

2013-07-03 Thread Serban Constantinescu
Hi all, Any feedback or comments on this patch set? Thanks, Serban On 19/06/13 18:12, Serban Constantinescu wrote: Hi all, This set of patches will clean-up and fix some of the issues that arise with the current binder interface when moving to a 64bit kernel. All these changes

Re: [PATCH v5 0/6] Android Binder IPC Fixes

2013-07-03 Thread Serban Constantinescu
Hi all, Any feedback or comments on this patch set? Thanks, Serban On 19/06/13 18:12, Serban Constantinescu wrote: Hi all, This set of patches will clean-up and fix some of the issues that arise with the current binder interface when moving to a 64bit kernel. All these changes

[PATCH v5 1/6] staging: android: binder: modify struct binder_write_read to use size_t

2013-06-19 Thread Serban Constantinescu
. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.c | 10 +- drivers/staging/android/binder.h |8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging

[PATCH v5 2/6] staging: android: binder: fix BINDER_SET_MAX_THREADS declaration

2013-06-19 Thread Serban Constantinescu
for a 64bit size_t on 64bit platforms). The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/binder.h b/drivers

[PATCH v5 3/6] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration

2013-06-19 Thread Serban Constantinescu
will also ease our work in differentiating BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER. The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v5 6/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-06-19 Thread Serban Constantinescu
as well as user-exportable ones and fix format specifier issues. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 20 ++-- drivers/staging/android/binder.h | 10 +- 2 files changed, 15 insertions

[PATCH v5 0/6] Android Binder IPC Fixes

2013-06-19 Thread Serban Constantinescu
format specifiers. Serban Constantinescu (6): staging: android: binder: modify struct binder_write_read to use size_t staging: android: binder: fix BINDER_SET_MAX_THREADS declaration staging: android: binder: fix BC_FREE_BUFFER ioctl declaration staging: android: binder: fix alignment

[PATCH v5 5/6] staging: android: binder: replace types with portable ones

2013-06-19 Thread Serban Constantinescu
he Android filesystem. The patch does not change in any way the functionality of the binder driver. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

[PATCH v5 4/6] staging: android: binder: fix alignment issues

2013-06-19 Thread Serban Constantinescu
-by: Serban Constantinescu --- drivers/staging/android/binder.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index ce70909..7450d56 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging/android

[PATCH v5 0/6] Android Binder IPC Fixes

2013-06-19 Thread Serban Constantinescu
format specifiers. Serban Constantinescu (6): staging: android: binder: modify struct binder_write_read to use size_t staging: android: binder: fix BINDER_SET_MAX_THREADS declaration staging: android: binder: fix BC_FREE_BUFFER ioctl declaration staging: android: binder: fix alignment

[PATCH v5 5/6] staging: android: binder: replace types with portable ones

2013-06-19 Thread Serban Constantinescu
filesystem. The patch does not change in any way the functionality of the binder driver. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.h | 26 +- 1 file changed, 13 insertions

[PATCH v5 4/6] staging: android: binder: fix alignment issues

2013-06-19 Thread Serban Constantinescu
-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index ce70909..7450d56 100644 --- a/drivers/staging/android/binder.c

[PATCH v5 6/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-06-19 Thread Serban Constantinescu
as well as user-exportable ones and fix format specifier issues. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c | 20 ++-- drivers/staging/android/binder.h | 10 +- 2 files

[PATCH v5 3/6] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration

2013-06-19 Thread Serban Constantinescu
in differentiating BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER. The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion

[PATCH v5 2/6] staging: android: binder: fix BINDER_SET_MAX_THREADS declaration

2013-06-19 Thread Serban Constantinescu
for a 64bit size_t on 64bit platforms). The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 1/6] staging: android: binder: modify struct binder_write_read to use size_t

2013-06-19 Thread Serban Constantinescu
. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.c | 10 +- drivers/staging/android/binder.h |8 2 files changed, 9 insertions(+), 9

Re: [PATCH v4 2/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-06-18 Thread Serban Constantinescu
Hi all, Sorry for the late reply on this patch set - I had to re-prioritise some of the other tasks I am currently working on. v5 of this patch set should be out the door soon. On 05/06/13 00:58, Arve Hjønnevåg wrote: On Tue, Jun 4, 2013 at 1:54 AM, Serban Constantinescu wrote: On 03/06

Re: [PATCH v4 2/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-06-18 Thread Serban Constantinescu
Hi all, Sorry for the late reply on this patch set - I had to re-prioritise some of the other tasks I am currently working on. v5 of this patch set should be out the door soon. On 05/06/13 00:58, Arve Hjønnevåg wrote: On Tue, Jun 4, 2013 at 1:54 AM, Serban Constantinescu serban.constantine

Re: [PATCH v4 2/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-06-05 Thread Serban Constantinescu
On 05/06/13 00:58, Arve Hjønnevåg wrote: On Tue, Jun 4, 2013 at 1:54 AM, Serban Constantinescu wrote: On 03/06/13 22:41, Arve Hjønnevåg wrote: On Wed, May 22, 2013 at 3:12 AM, Serban Constantinescu wrote: The changes in this patch will fix the binder interface for use on 64bit machines

Re: [PATCH v4 2/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-06-05 Thread Serban Constantinescu
On 05/06/13 00:58, Arve Hjønnevåg wrote: On Tue, Jun 4, 2013 at 1:54 AM, Serban Constantinescu serban.constantine...@arm.com wrote: On 03/06/13 22:41, Arve Hjønnevåg wrote: On Wed, May 22, 2013 at 3:12 AM, Serban Constantinescu serban.constantine...@arm.com wrote: The changes in this patch

Re: [PATCH v4 2/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-06-04 Thread Serban Constantinescu
On 03/06/13 22:41, Arve Hjønnevåg wrote: On Wed, May 22, 2013 at 3:12 AM, Serban Constantinescu wrote: The changes in this patch will fix the binder interface for use on 64bit machines and stand as the base of the 64bit compat support. The changes apply to the structures that are passed

Re: [PATCH v4 2/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-06-04 Thread Serban Constantinescu
On 03/06/13 22:41, Arve Hjønnevåg wrote: On Wed, May 22, 2013 at 3:12 AM, Serban Constantinescu serban.constantine...@arm.com wrote: The changes in this patch will fix the binder interface for use on 64bit machines and stand as the base of the 64bit compat support. The changes apply

[PATCH v4 2/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-05-22 Thread Serban Constantinescu
as well as user-exportable ones and fix format specifier issues. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 20 ++-- drivers/staging/android/binder.h |8 2 files changed, 14 insertions(+), 14

[PATCH v4 3/6] staging: android: binder: fix BINDER_SET_MAX_THREADS declaration

2013-05-22 Thread Serban Constantinescu
for a 64bit size_t on 64bit platforms). The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h index

[PATCH v4 6/6] staging: android: binder: replace types with portable ones

2013-05-22 Thread Serban Constantinescu
he Android filesystem. The patch does not change in any way the functionality of the binder driver. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/android/

[PATCH v4 5/6] staging: android: binder: fix alignment issues

2013-05-22 Thread Serban Constantinescu
, where on 64bit systems, if the data_size is not aligned to 8bytes the offset's start address will be incorrectly calculated. The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 18 +- 1 file changed, 9

[PATCH v4 4/6] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration

2013-05-22 Thread Serban Constantinescu
will also ease our work in differentiating BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER. The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v4 0/6] Android Binder IPC Fixes

2013-05-22 Thread Serban Constantinescu
: Modified the commit message according to Greg's feedback; 2: 3/7: Merged with the patch fixing the printk format specifiers. Serban Constantinescu (6): staging: android: binder: modify struct binder_write_read to use size_t staging: android: binder: fix binder interface for 64bit compat layer

[PATCH v4 1/6] staging: android: binder: modify struct binder_write_read to use size_t

2013-05-22 Thread Serban Constantinescu
. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 10 +- drivers/staging/android/binder.h |8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers

[PATCH v4 0/6] Android Binder IPC Fixes

2013-05-22 Thread Serban Constantinescu
: Modified the commit message according to Greg's feedback; 2: 3/7: Merged with the patch fixing the printk format specifiers. Serban Constantinescu (6): staging: android: binder: modify struct binder_write_read to use size_t staging: android: binder: fix binder interface for 64bit compat layer

[PATCH v4 1/6] staging: android: binder: modify struct binder_write_read to use size_t

2013-05-22 Thread Serban Constantinescu
. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c | 10 +- drivers/staging/android/binder.h |8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging

[PATCH v4 4/6] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration

2013-05-22 Thread Serban Constantinescu
in differentiating BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER. The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com Acked-by: Arve Hjønnevåg a...@android.com --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion

[PATCH v4 5/6] staging: android: binder: fix alignment issues

2013-05-22 Thread Serban Constantinescu
, where on 64bit systems, if the data_size is not aligned to 8bytes the offset's start address will be incorrectly calculated. The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c | 18

[PATCH v4 6/6] staging: android: binder: replace types with portable ones

2013-05-22 Thread Serban Constantinescu
filesystem. The patch does not change in any way the functionality of the binder driver. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCH v4 3/6] staging: android: binder: fix BINDER_SET_MAX_THREADS declaration

2013-05-22 Thread Serban Constantinescu
for a 64bit size_t on 64bit platforms). The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/binder.h b/drivers

[PATCH v4 2/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-05-22 Thread Serban Constantinescu
as well as user-exportable ones and fix format specifier issues. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu serban.constantine...@arm.com --- drivers/staging/android/binder.c | 20 ++-- drivers/staging/android/binder.h |8 2 files

Re: [PATCH v3 0/6] Android Binder IPC Fixes

2013-05-02 Thread Serban Constantinescu
On 01/05/13 00:52, Arve Hjønnevåg wrote: On Tue, Apr 30, 2013 at 1:36 AM, Serban Constantinescu wrote: Hi Arve, On 30/04/13 00:13, Arve Hjønnevåg wrote: On Mon, Apr 29, 2013 at 9:16 AM, Serban Constantinescu wrote: Hi all, Any feedback or comments on this patch set? You don't seem

Re: [PATCH v3 0/6] Android Binder IPC Fixes

2013-05-02 Thread Serban Constantinescu
On 01/05/13 00:52, Arve Hjønnevåg wrote: On Tue, Apr 30, 2013 at 1:36 AM, Serban Constantinescu serban.constantine...@arm.com wrote: Hi Arve, On 30/04/13 00:13, Arve Hjønnevåg wrote: On Mon, Apr 29, 2013 at 9:16 AM, Serban Constantinescu serban.constantine...@arm.com wrote: Hi all, Any

Re: [PATCH v3 0/6] Android Binder IPC Fixes

2013-04-30 Thread Serban Constantinescu
On 30/04/13 11:04, Kirill A. Shutemov wrote: On Tue, Apr 30, 2013 at 09:52:34AM +0100, Serban Constantinescu wrote: Hi Kirill, On 30/04/13 08:31, Kirill A. Shutemov wrote: On Fri, Apr 12, 2013 at 01:25:49PM +0100, Serban Constantinescu wrote: The patch set has been successfully tested

Re: [PATCH v3 0/6] Android Binder IPC Fixes

2013-04-30 Thread Serban Constantinescu
Hi Kirill, On 30/04/13 08:31, Kirill A. Shutemov wrote: On Fri, Apr 12, 2013 at 01:25:49PM +0100, Serban Constantinescu wrote: The patch set has been successfully tested with a 64bit Linux userspace and 64bit binder unit-tests. This patch set has been successfully tested on 32bit platforms

Re: [PATCH v3 0/6] Android Binder IPC Fixes

2013-04-30 Thread Serban Constantinescu
Hi Arve, On 30/04/13 00:13, Arve Hjønnevåg wrote: On Mon, Apr 29, 2013 at 9:16 AM, Serban Constantinescu wrote: Hi all, Any feedback or comments on this patch set? You don't seem to have addressed my feedback on the previous patch set. For v3 I have modified the following according

Re: [PATCH v3 0/6] Android Binder IPC Fixes

2013-04-30 Thread Serban Constantinescu
Hi Arve, On 30/04/13 00:13, Arve Hjønnevåg wrote: On Mon, Apr 29, 2013 at 9:16 AM, Serban Constantinescu serban.constantine...@arm.com wrote: Hi all, Any feedback or comments on this patch set? You don't seem to have addressed my feedback on the previous patch set. For v3 I have modified

Re: [PATCH v3 0/6] Android Binder IPC Fixes

2013-04-30 Thread Serban Constantinescu
Hi Kirill, On 30/04/13 08:31, Kirill A. Shutemov wrote: On Fri, Apr 12, 2013 at 01:25:49PM +0100, Serban Constantinescu wrote: The patch set has been successfully tested with a 64bit Linux userspace and 64bit binder unit-tests. This patch set has been successfully tested on 32bit platforms

Re: [PATCH v3 0/6] Android Binder IPC Fixes

2013-04-30 Thread Serban Constantinescu
On 30/04/13 11:04, Kirill A. Shutemov wrote: On Tue, Apr 30, 2013 at 09:52:34AM +0100, Serban Constantinescu wrote: Hi Kirill, On 30/04/13 08:31, Kirill A. Shutemov wrote: On Fri, Apr 12, 2013 at 01:25:49PM +0100, Serban Constantinescu wrote: The patch set has been successfully tested

Re: [PATCH v3 0/6] Android Binder IPC Fixes

2013-04-29 Thread Serban Constantinescu
Hi all, Any feedback or comments on this patch set? Thanks, Serban On 12/04/13 13:25, Serban Constantinescu wrote: Hi all, This set of patches will clean-up and fix some of the issues that arise with the current binder interface when moving to a 64bit kernel. All these changes

Re: [PATCH v3 0/6] Android Binder IPC Fixes

2013-04-29 Thread Serban Constantinescu
Hi all, Any feedback or comments on this patch set? Thanks, Serban On 12/04/13 13:25, Serban Constantinescu wrote: Hi all, This set of patches will clean-up and fix some of the issues that arise with the current binder interface when moving to a 64bit kernel. All these changes

[PATCH v3 4/6] staging: android: binder: fix BC_FREE_BUFFER ioctl declaration

2013-04-12 Thread Serban Constantinescu
will also ease our work in differentiating BC_FREE_BUFFER from COMPAT_BC_FREE_BUFFER. The change does not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu Acked-by: Arve Hjønnevåg --- drivers/staging/android/binder.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH v3 5/6] staging: android: binder: fix alignment issues

2013-04-12 Thread Serban Constantinescu
-by: Serban Constantinescu --- drivers/staging/android/binder.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index 06004cf..6436f22 100644 --- a/drivers/staging/android/binder.c +++ b/drivers/staging

[PATCH v3 1/6] staging: android: binder: modify struct binder_write_read to use size_t

2013-04-12 Thread Serban Constantinescu
. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 10 +- drivers/staging/android/binder.h |8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers

[PATCH v3 2/6] staging: android: binder: fix binder interface for 64bit compat layer

2013-04-12 Thread Serban Constantinescu
as well as user-exportable ones and fix format specifier issues. The changes do not affect existing 32bit ABI. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 20 ++-- drivers/staging/android/binder.h |8 2 files changed, 14 insertions(+), 14

[PATCH v3 6/6] staging: android: binder: replace types with portable ones

2013-04-12 Thread Serban Constantinescu
he Android filesystem. The patch does not change in any way the functionality of the binder driver. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.h | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/android/

[PATCH v3 0/6] Android Binder IPC Fixes

2013-04-12 Thread Serban Constantinescu
ioctl definition accordint to Arve's review 5: Modified the binder command IOCTL declarations according to Arve's review Changes for v2: 1: 1/7: Modified the commit message according to Greg's feedback; 2: 3/7: Merged with the patch fixing the printk format specifiers. Serban Constantinescu (6

  1   2   >