Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-07 Thread Sergei Shtylyov
On 3/7/2017 10:52 AM, Reshetova, Elena wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-07 Thread Sergei Shtylyov
On 3/7/2017 10:52 AM, Reshetova, Elena wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-06 Thread Sergei Shtylyov
Hello. On 03/06/2017 05:20 PM, Elena Reshetova wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by:

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-06 Thread Sergei Shtylyov
Hello. On 03/06/2017 05:20 PM, Elena Reshetova wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by:

Re: [PATCH] MIPS: reset all task's asid to 0 after asid_cache(cpu) overflows

2017-03-06 Thread Sergei Shtylyov
On 3/6/2017 10:21 AM, jsun4 wrote: If asid_cache(cpu) overflows, there may be two tasks with the same asid. It is a risk that the two different tasks may have the same address space. A process will update its asid to newer version only when switch_mm() is called and matches the following

Re: [PATCH] MIPS: reset all task's asid to 0 after asid_cache(cpu) overflows

2017-03-06 Thread Sergei Shtylyov
On 3/6/2017 10:21 AM, jsun4 wrote: If asid_cache(cpu) overflows, there may be two tasks with the same asid. It is a risk that the two different tasks may have the same address space. A process will update its asid to newer version only when switch_mm() is called and matches the following

Re: [PATCH] MIPS: reset all task's asid to 0 after asid_cache(cpu) overflows

2017-03-05 Thread Sergei Shtylyov
Hello! On 3/5/2017 6:24 AM, Jiwei Sun wrote: If asid_cache(cpu) overflows, there may be two tasks with the same asid. It is a risk that the two different tasks may have the same address space. A process will update its asid to newer version only when switch_mm() is called and matches the

Re: [PATCH] MIPS: reset all task's asid to 0 after asid_cache(cpu) overflows

2017-03-05 Thread Sergei Shtylyov
Hello! On 3/5/2017 6:24 AM, Jiwei Sun wrote: If asid_cache(cpu) overflows, there may be two tasks with the same asid. It is a risk that the two different tasks may have the same address space. A process will update its asid to newer version only when switch_mm() is called and matches the

Re: [PATCH v4 08/19] scsi: be2iscsi: Replace PCI pool old API

2017-03-03 Thread Sergei Shtylyov
On 3/1/2017 6:55 PM, Romain Perier wrote: The PCI pool API is deprecated. This commits replaces the PCI pool old Commit. API by the appropriated function with the DMA pool API. Appropriate perhaps? Signed-off-by: Romain Perier Acked-by: Peter Senna

Re: [PATCH v4 08/19] scsi: be2iscsi: Replace PCI pool old API

2017-03-03 Thread Sergei Shtylyov
On 3/1/2017 6:55 PM, Romain Perier wrote: The PCI pool API is deprecated. This commits replaces the PCI pool old Commit. API by the appropriated function with the DMA pool API. Appropriate perhaps? Signed-off-by: Romain Perier Acked-by: Peter Senna Tschudin Tested-by: Peter

Re: [PATCH v4 09/19] scsi: csiostor: Replace PCI pool old API

2017-03-03 Thread Sergei Shtylyov
Hello! On 3/1/2017 6:55 PM, Romain Perier wrote: The PCI pool API is deprecated. This commits replaces the PCI pool old Commit. API by the appropriated function with the DMA pool API. It also updates Appropriate perhaps? the name of some variables and the content of comments,

Re: [PATCH v4 09/19] scsi: csiostor: Replace PCI pool old API

2017-03-03 Thread Sergei Shtylyov
Hello! On 3/1/2017 6:55 PM, Romain Perier wrote: The PCI pool API is deprecated. This commits replaces the PCI pool old Commit. API by the appropriated function with the DMA pool API. It also updates Appropriate perhaps? the name of some variables and the content of comments,

Re: [PATCH] usb: dwc2: Make sure we disconnect the gadget state

2017-03-03 Thread Sergei Shtylyov
Hello! On 3/3/2017 2:36 AM, John Stultz wrote: I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have chased down. Basically every other time I pluged in the OTG port, the gadget interface would Plugged. Perhaps could be fixed while applying...

Re: [PATCH] usb: dwc2: Make sure we disconnect the gadget state

2017-03-03 Thread Sergei Shtylyov
Hello! On 3/3/2017 2:36 AM, John Stultz wrote: I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have chased down. Basically every other time I pluged in the OTG port, the gadget interface would Plugged. Perhaps could be fixed while applying...

Re: [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors).

2017-02-27 Thread Sergei Shtylyov
Hello! Your subject is too long, mught want to move i(part of) it to the patch description... And you need to provide your Signed-off-by:, the patch can't be applied without it. MBR, Sergei

Re: [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors).

2017-02-27 Thread Sergei Shtylyov
Hello! Your subject is too long, mught want to move i(part of) it to the patch description... And you need to provide your Signed-off-by:, the patch can't be applied without it. MBR, Sergei

Re: [PATCH] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors

2017-02-23 Thread Sergei Shtylyov
On 2/23/2017 4:13 AM, Dmitry V. Levin wrote: Include in uapi/linux/seg6.h to fix the following linux/seg6.h userspace compilation error: /usr/include/linux/seg6.h:31:18: error: array type has incomplete element type 'struct in6_addr' struct in6_addr segments[0]; Include in

Re: [PATCH] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors

2017-02-23 Thread Sergei Shtylyov
On 2/23/2017 4:13 AM, Dmitry V. Levin wrote: Include in uapi/linux/seg6.h to fix the following linux/seg6.h userspace compilation error: /usr/include/linux/seg6.h:31:18: error: array type has incomplete element type 'struct in6_addr' struct in6_addr segments[0]; Include in

Re: [PATCH] uapi: fix linux/rds.h userspace compilation errors

2017-02-23 Thread Sergei Shtylyov
Hello! On 2/23/2017 4:13 AM, Dmitry V. Levin wrote: Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:198:2: error: unknown type name 'u8' u8 rx_traces; /usr/include/linux/rds.h:199:2: error: unknown type name

Re: [PATCH] uapi: fix linux/rds.h userspace compilation errors

2017-02-23 Thread Sergei Shtylyov
Hello! On 2/23/2017 4:13 AM, Dmitry V. Levin wrote: Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:198:2: error: unknown type name 'u8' u8 rx_traces; /usr/include/linux/rds.h:199:2: error: unknown type name

Re: [PATCH v3 7/8] arm64: dts: mt8173: move clock from phy node into port nodes

2017-02-22 Thread Sergei Shtylyov
On 2/22/2017 11:55 AM, Chunfeng Yun wrote: there is a reference clock for each port, HighSpeed port is 48M, and SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs is not. it is flexible to move it into port ... but on some SoCs does not? node.

Re: [PATCH v3 7/8] arm64: dts: mt8173: move clock from phy node into port nodes

2017-02-22 Thread Sergei Shtylyov
On 2/22/2017 11:55 AM, Chunfeng Yun wrote: there is a reference clock for each port, HighSpeed port is 48M, and SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs is not. it is flexible to move it into port ... but on some SoCs does not? node.

Re: [PATCH v3 4/8] phy: phy-mt65xx-usb3: move clock from phy node into port nodes

2017-02-22 Thread Sergei Shtylyov
Hello! On 2/22/2017 11:55 AM, Chunfeng Yun wrote: the reference clock of HighSpeed port is 48M which comes from PLL; the reference clock of SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs are not, add it for ... but on some SoCs does not?

Re: [PATCH v3 4/8] phy: phy-mt65xx-usb3: move clock from phy node into port nodes

2017-02-22 Thread Sergei Shtylyov
Hello! On 2/22/2017 11:55 AM, Chunfeng Yun wrote: the reference clock of HighSpeed port is 48M which comes from PLL; the reference clock of SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs are not, add it for ... but on some SoCs does not?

Re: [PATCH v7 1/5] x86: add simple udelay calibration

2017-02-14 Thread Sergei Shtylyov
Hello! On 2/14/2017 5:27 AM, Lu Baolu wrote: Add a simple udelay calibration in x86 architecture-specific boot-time initializations. This will get a workable estimate for loops_per_jiffy. Hence, udelay() could be used after this initialization. Cc: Ingo Molnar Cc:

Re: [PATCH v7 1/5] x86: add simple udelay calibration

2017-02-14 Thread Sergei Shtylyov
Hello! On 2/14/2017 5:27 AM, Lu Baolu wrote: Add a simple udelay calibration in x86 architecture-specific boot-time initializations. This will get a workable estimate for loops_per_jiffy. Hence, udelay() could be used after this initialization. Cc: Ingo Molnar Cc: x...@kernel.org

Re: [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

2017-02-12 Thread Sergei Shtylyov
Hello! On 2/10/2017 8:38 PM, Shannon Nelson wrote: When the sunvnet_common code was split out for use by both sunvnet and the newer ldmvsw, it was made into a static kernel library, which limits the usefulness of sunvnet and ldmvsw as loadables, since most of the real work is being done in the

Re: [PATCH v3 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

2017-02-12 Thread Sergei Shtylyov
Hello! On 2/10/2017 8:38 PM, Shannon Nelson wrote: When the sunvnet_common code was split out for use by both sunvnet and the newer ldmvsw, it was made into a static kernel library, which limits the usefulness of sunvnet and ldmvsw as loadables, since most of the real work is being done in the

Re: [PATCH 1/2] include: Fix checkpatch whitespace error and warning

2017-02-12 Thread Sergei Shtylyov
Hello! On 2/12/2017 5:57 AM, Tobin C. Harding wrote: This patch fixes two trivial whitespace messages (ERROR/WARNING). Fixes trailing whitespace ERROR and fixes space before tabs WARNING. Signed-off-by: Tobin C. Harding --- include/linux/idr.h | 4 ++-- 1 file changed, 2

Re: [PATCH 1/2] include: Fix checkpatch whitespace error and warning

2017-02-12 Thread Sergei Shtylyov
Hello! On 2/12/2017 5:57 AM, Tobin C. Harding wrote: This patch fixes two trivial whitespace messages (ERROR/WARNING). Fixes trailing whitespace ERROR and fixes space before tabs WARNING. Signed-off-by: Tobin C. Harding --- include/linux/idr.h | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v2 06/16] net: stmmac: fix some code style problem

2017-02-08 Thread Sergei Shtylyov
Hello! On 2/8/2017 11:31 AM, Corentin Labbe wrote: Checkpatch complains about some code style problem on stmmac_mdio.c. This patch fix them. Fixes. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro ---

Re: [PATCH v2 06/16] net: stmmac: fix some code style problem

2017-02-08 Thread Sergei Shtylyov
Hello! On 2/8/2017 11:31 AM, Corentin Labbe wrote: Checkpatch complains about some code style problem on stmmac_mdio.c. This patch fix them. Fixes. Signed-off-by: Corentin Labbe Acked-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 7 --- 1 file

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Sergei Shtylyov
Hello! On 02/06/2017 05:03 PM, Richard Leitner wrote: For USB string descriptors we need to convert ASCII strings to UTF16-LE. Therefore make a simple helper function (based on ascii2desc from drivers/usb/core/hcd.c) for that purpose. Signed-off-by: Richard Leitner

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Sergei Shtylyov
Hello! On 02/06/2017 05:03 PM, Richard Leitner wrote: For USB string descriptors we need to convert ASCII strings to UTF16-LE. Therefore make a simple helper function (based on ascii2desc from drivers/usb/core/hcd.c) for that purpose. Signed-off-by: Richard Leitner [...] diff --git

Re: [PATCH] MIPS: Allow compressed images to be loaded at the usual address

2017-02-06 Thread Sergei Shtylyov
Hello! On 2/5/2017 11:21 PM, Alban wrote: From: Alban Bedel Normally compressed images have to be loaded at a different address to allow the decompressor to run. This add an option to let vmlinuz copy itself to the correct address from the normal vmlinux address.

Re: [PATCH] MIPS: Allow compressed images to be loaded at the usual address

2017-02-06 Thread Sergei Shtylyov
Hello! On 2/5/2017 11:21 PM, Alban wrote: From: Alban Bedel Normally compressed images have to be loaded at a different address to allow the decompressor to run. This add an option to let vmlinuz copy itself to the correct address from the normal vmlinux address. Signed-off-by: Alban Bedel

Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-02 Thread Sergei Shtylyov
On 2/2/2017 1:39 AM, Jon Mason wrote: From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas

Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

2017-02-02 Thread Sergei Shtylyov
On 2/2/2017 1:39 AM, Jon Mason wrote: From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon Mason

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-02 Thread Sergei Shtylyov
Hello! On 2/2/2017 1:39 AM, Jon Mason wrote: From: Zac Schroff Fix a bug in the 'bgmac' driver init sequence that blind writes for init sequence where it should preserve most bits other than the ones it is deliberately manipulating. Signed-off-by: Zac Schroff

Re: [PATCH 1/2] net: ethernet: bgmac: init sequence bug

2017-02-02 Thread Sergei Shtylyov
Hello! On 2/2/2017 1:39 AM, Jon Mason wrote: From: Zac Schroff Fix a bug in the 'bgmac' driver init sequence that blind writes for init sequence where it should preserve most bits other than the ones it is deliberately manipulating. Signed-off-by: Zac Schroff Signed-off-by: Jon Mason

Re: remove the cmd_type field from struct request

2017-02-01 Thread Sergei Shtylyov
On 2/1/2017 9:53 AM, Hannes Reinecke wrote: [1] which were a pain in the ass to untangle and debug during development, it's really time for it to die.. Outside of the patch series in question, how to we expedite the euthanasia of IDE? What explicit features/support are we missing through

Re: remove the cmd_type field from struct request

2017-02-01 Thread Sergei Shtylyov
On 2/1/2017 9:53 AM, Hannes Reinecke wrote: [1] which were a pain in the ass to untangle and debug during development, it's really time for it to die.. Outside of the patch series in question, how to we expedite the euthanasia of IDE? What explicit features/support are we missing through

Re: remove the cmd_type field from struct request

2017-01-31 Thread Sergei Shtylyov
On 01/31/2017 09:51 PM, James Bottomley wrote: [1] which were a pain in the ass to untangle and debug during development, it's really time for it to die.. Outside of the patch series in question, how to we expedite the euthanasia of IDE? What explicit features/support are we missing through

Re: remove the cmd_type field from struct request

2017-01-31 Thread Sergei Shtylyov
On 01/31/2017 09:51 PM, James Bottomley wrote: [1] which were a pain in the ass to untangle and debug during development, it's really time for it to die.. Outside of the patch series in question, how to we expedite the euthanasia of IDE? What explicit features/support are we missing through

[PATCH v3 3/3] drm: rcar-du: Add VSP1 live source support

2017-01-25 Thread Sergei Shtylyov
.pinchart+rene...@ideasonboard.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- Changes in version 3: - ported the patch to the modern kernel; - reformatted rcar_du_live_fb_create_handle()/rcar_du_live_fb_create()'s parameter lists; - added my signoff. drive

[PATCH v3 3/3] drm: rcar-du: Add VSP1 live source support

2017-01-25 Thread Sergei Shtylyov
From: Laurent Pinchart Register live sources for VSPD0 and VSPD1 and configure the plane source at plane setup time to source frames from memory or from the VSP1. [Sergei: ported to the modern kernel.] Signed-off-by: Laurent Pinchart Signed-off-by: Sergei Shtylyov --- Changes in version 3

[PATCH v3 1/3] drm: Add live source object

2017-01-25 Thread Sergei Shtylyov
Sergei: ported to the modern kernel.] Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- Changes in version 3: - moved drm_live_source_{init|cleanup}() from drm_crtc.c to drm_plane.c and the

[PATCH v3 1/3] drm: Add live source object

2017-01-25 Thread Sergei Shtylyov
-by: Laurent Pinchart Signed-off-by: Sergei Shtylyov --- Changes in version 3: - moved drm_live_source_{init|cleanup}() from drm_crtc.c to drm_plane.c and their prototypes from to (along with *struct* drm_live_source[_funcs]); - moved drm_mode_getsource[_res]() prototypes from

[PATCH v3 2/3] drm: Connect live source to framebuffers

2017-01-25 Thread Sergei Shtylyov
plane to connect it with the live source. [Sergei: ported to the modern kernel.] Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- Changes in version 3: - ported the patch to the modern kernel;

[PATCH v3 2/3] drm: Connect live source to framebuffers

2017-01-25 Thread Sergei Shtylyov
: ported to the modern kernel.] Signed-off-by: Laurent Pinchart Signed-off-by: Sergei Shtylyov --- Changes in version 3: - ported the patch to the modern kernel; - added my signoff. drivers/gpu/drm/drm_framebuffer.c | 134 ++ include/uapi/drm/drm_mode.h

[PATCH v3 0/3] Enable R8A7790/1 DU VSPD compositor

2017-01-25 Thread Sergei Shtylyov
Hello. Here's the set of 3 patches against the 'drm-next' branch of David Airlie's 'linux.git' repo. This is a port of Laurent's DRM/DU live source patches to the recent kernel, see [1] for the version 2 of the patchset (including a Laurent's big blurb :-)). For the patch #3 to work one

[PATCH v3 0/3] Enable R8A7790/1 DU VSPD compositor

2017-01-25 Thread Sergei Shtylyov
Hello. Here's the set of 3 patches against the 'drm-next' branch of David Airlie's 'linux.git' repo. This is a port of Laurent's DRM/DU live source patches to the recent kernel, see [1] for the version 2 of the patchset (including a Laurent's big blurb :-)). For the patch #3 to work one

Re: [PATCH v4 12/14] ARM: dts: da850: add the SATA node

2017-01-19 Thread Sergei Shtylyov
On 01/19/2017 04:29 PM, Bartosz Golaszewski wrote: Add the SATA node to the da850 device tree. Signed-off-by: Bartosz Golaszewski --- arch/arm/boot/dts/da850.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/da850.dtsi

Re: [PATCH v4 12/14] ARM: dts: da850: add the SATA node

2017-01-19 Thread Sergei Shtylyov
On 01/19/2017 04:29 PM, Bartosz Golaszewski wrote: Add the SATA node to the da850 device tree. Signed-off-by: Bartosz Golaszewski --- arch/arm/boot/dts/da850.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index

Re: [PATCH 04/13] MIPS: zboot: fix 'make clean' failure

2017-01-18 Thread Sergei Shtylyov
Hello! On 1/17/2017 6:18 PM, Arnd Bergmann wrote: The filter-out macro needs two arguments, passing only one is clearly the result of a typo that leads to 'make clean' failing on MIPS: arch/mips/boot/compressed/Makefile:21: *** insufficient number of arguments (1) to function 'filter-out'.

Re: [PATCH 04/13] MIPS: zboot: fix 'make clean' failure

2017-01-18 Thread Sergei Shtylyov
Hello! On 1/17/2017 6:18 PM, Arnd Bergmann wrote: The filter-out macro needs two arguments, passing only one is clearly the result of a typo that leads to 'make clean' failing on MIPS: arch/mips/boot/compressed/Makefile:21: *** insufficient number of arguments (1) to function 'filter-out'.

Re: [PATCH v2 04/14] sata: ahci-da850: get the sata clock using a connector id

2017-01-17 Thread Sergei Shtylyov
Hello! On 01/17/2017 03:26 PM, Bartosz Golaszewski wrote: In preparation for using two clocks in the driver (the sysclk2-based clock and the external REFCLK), check if we got a functional clock after calling ahci_platform_get_resources(). If not, retry calling get_clk() with con_id specified.

Re: [PATCH v2 04/14] sata: ahci-da850: get the sata clock using a connector id

2017-01-17 Thread Sergei Shtylyov
Hello! On 01/17/2017 03:26 PM, Bartosz Golaszewski wrote: In preparation for using two clocks in the driver (the sysclk2-based clock and the external REFCLK), check if we got a functional clock after calling ahci_platform_get_resources(). If not, retry calling get_clk() with con_id specified.

Re: [PATCH] net: constify mdiobb_ops structures

2017-01-16 Thread Sergei Shtylyov
struct */ -static struct mdiobb_ops bb_ops = { +static const struct mdiobb_ops bb_ops = { .owner = THIS_MODULE, .set_mdc = sh_mdc_ctrl, .set_mdio_dir = sh_mmd_ctrl, [...] For the above 2 drivers: Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> MBR, Sergei

Re: [PATCH] net: constify mdiobb_ops structures

2017-01-16 Thread Sergei Shtylyov
mdiobb_ops bb_ops = { +static const struct mdiobb_ops bb_ops = { .owner = THIS_MODULE, .set_mdc = sh_mdc_ctrl, .set_mdio_dir = sh_mmd_ctrl, [...] For the above 2 drivers: Acked-by: Sergei Shtylyov MBR, Sergei

Re: [PATCH net-next v3 04/10] net: dsa: Move ports assignment closer to error checking

2017-01-15 Thread Sergei Shtylyov
Hello! On 1/15/2017 12:47 AM, Florian Fainelli wrote: Move the assignment of ports in _dsa_register_switch() closer to where it is checked, no functional change. Re-order declarations to be "Be" not needed. preserve the inverted christmas tree style. Signed-off-by: Florian Fainelli

Re: [PATCH net-next v3 04/10] net: dsa: Move ports assignment closer to error checking

2017-01-15 Thread Sergei Shtylyov
Hello! On 1/15/2017 12:47 AM, Florian Fainelli wrote: Move the assignment of ports in _dsa_register_switch() closer to where it is checked, no functional change. Re-order declarations to be "Be" not needed. preserve the inverted christmas tree style. Signed-off-by: Florian Fainelli

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

2017-01-10 Thread Sergei Shtylyov
Hello! On 01/10/2017 05:21 AM, Shuah Khan wrote: Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend clock is specified. Call clk_disable_unprepare() from remove and probe error path only when susp_clk has been set from remove and probe error paths. Signed-off-by: Shuah

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

2017-01-10 Thread Sergei Shtylyov
Hello! On 01/10/2017 05:21 AM, Shuah Khan wrote: Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend clock is specified. Call clk_disable_unprepare() from remove and probe error path only when susp_clk has been set from remove and probe error paths. Signed-off-by: Shuah

Re: [PATCH] arm64: do not set dma masks that device connection can't handle

2017-01-07 Thread Sergei Shtylyov
Hello! On 1/6/2017 5:45 PM, Nikita Yushchenko wrote: It is possible that device is capable of 64-bit DMA addresses, and device driver tries to set wide DMA mask, but bridge or bus used to connect device to the system can't handle wide addresses. With swiotlb, memory above 4G still can be used

Re: [PATCH] arm64: do not set dma masks that device connection can't handle

2017-01-07 Thread Sergei Shtylyov
Hello! On 1/6/2017 5:45 PM, Nikita Yushchenko wrote: It is possible that device is capable of 64-bit DMA addresses, and device driver tries to set wide DMA mask, but bridge or bus used to connect device to the system can't handle wide addresses. With swiotlb, memory above 4G still can be used

Re: [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit DMA mask

2016-12-30 Thread Sergei Shtylyov
On 12/30/2016 12:46 PM, Sergei Shtylyov wrote: It is possible that PCI device supports 64-bit DMA addressing, and thus it's driver sets device's dma_mask to DMA_BIT_MASK(64), however PCI host Its. bridge has limitations on inbound transactions addressing. Example of such setup is NVME

Re: [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit DMA mask

2016-12-30 Thread Sergei Shtylyov
On 12/30/2016 12:46 PM, Sergei Shtylyov wrote: It is possible that PCI device supports 64-bit DMA addressing, and thus it's driver sets device's dma_mask to DMA_BIT_MASK(64), however PCI host Its. bridge has limitations on inbound transactions addressing. Example of such setup is NVME

Re: [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit DMA mask

2016-12-30 Thread Sergei Shtylyov
Hello! On 12/29/2016 11:45 PM, Nikita Yushchenko wrote: It is possible that PCI device supports 64-bit DMA addressing, and thus it's driver sets device's dma_mask to DMA_BIT_MASK(64), however PCI host Its. bridge has limitations on inbound transactions addressing. Example of such setup

Re: [PATCH 1/2] arm64: dma_mapping: allow PCI host driver to limit DMA mask

2016-12-30 Thread Sergei Shtylyov
Hello! On 12/29/2016 11:45 PM, Nikita Yushchenko wrote: It is possible that PCI device supports 64-bit DMA addressing, and thus it's driver sets device's dma_mask to DMA_BIT_MASK(64), however PCI host Its. bridge has limitations on inbound transactions addressing. Example of such setup

Re: [PATCH] net: fix incorrect original ingress device index in PKTINFO

2016-12-27 Thread Sergei Shtylyov
Hello! On 12/27/2016 10:52 AM, Wei Zhang wrote: When we send a packet for our own local address on a non-loopback interface (e.g. eth0), due to the change had been introduced from commit 0b922b7a829c ("net: original ingress device index in PKTINFO"), the original ingress device index would be

Re: [PATCH] net: fix incorrect original ingress device index in PKTINFO

2016-12-27 Thread Sergei Shtylyov
Hello! On 12/27/2016 10:52 AM, Wei Zhang wrote: When we send a packet for our own local address on a non-loopback interface (e.g. eth0), due to the change had been introduced from commit 0b922b7a829c ("net: original ingress device index in PKTINFO"), the original ingress device index would be

Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

2016-12-25 Thread Sergei Shtylyov
Hello! On 12/25/2016 3:30 AM, Thomas Preisner wrote: In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan

Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value

2016-12-25 Thread Sergei Shtylyov
Hello! On 12/25/2016 3:30 AM, Thomas Preisner wrote: In some cases the return value of a failing function is not being used and the function typhoon_init_one() returns another negative error code instead. Signed-off-by: Thomas Preisner Signed-off-by: Milan Stephan ---

Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Sergei Shtylyov
Hello! On 12/24/2016 03:02 PM, Thomas Preisner wrote: In a few cases the err-variable is not set to a negative error code if a function call fails and thus 0 is returned instead. It may be better to set err to the appropriate negative error code before returning. Bugzilla:

Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Sergei Shtylyov
Hello! On 12/24/2016 03:02 PM, Thomas Preisner wrote: In a few cases the err-variable is not set to a negative error code if a function call fails and thus 0 is returned instead. It may be better to set err to the appropriate negative error code before returning. Bugzilla:

Re: [PATCH 4/4] usb: xhci: warn on command timeout in stopped command ring

2016-12-23 Thread Sergei Shtylyov
Hello! On 12/23/2016 9:52 AM, Lu Baolu wrote: If xhci host fails to response to a command, the command s/response/respond/. watchdog timer will be fired. The callback function will abort and clear current command and restart the command execution. If driver fails to restart command

Re: [PATCH 4/4] usb: xhci: warn on command timeout in stopped command ring

2016-12-23 Thread Sergei Shtylyov
Hello! On 12/23/2016 9:52 AM, Lu Baolu wrote: If xhci host fails to response to a command, the command s/response/respond/. watchdog timer will be fired. The callback function will abort and clear current command and restart the command execution. If driver fails to restart command

Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo

2016-12-16 Thread Sergei Shtylyov
Hello. On 12/16/2016 09:21 PM, Ozgur Karatas wrote: This patch fixed to keyboard typo, brackets not closed. I think, it should be close to parenthes. Signed-off-by: Ozgur Karatas --- tools/net/bpf_dbg.c | 2 +- 1 files changed, 1 insertion(+), 1 deletions(-)

Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo

2016-12-16 Thread Sergei Shtylyov
Hello. On 12/16/2016 09:21 PM, Ozgur Karatas wrote: This patch fixed to keyboard typo, brackets not closed. I think, it should be close to parenthes. Signed-off-by: Ozgur Karatas --- tools/net/bpf_dbg.c | 2 +- 1 files changed, 1 insertion(+), 1 deletions(-) diff --git

Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack

2016-12-13 Thread Sergei Shtylyov
Hello! On 12/12/2016 11:54 PM, Andy Lutomirski wrote: smbencrypt() points a scatterlist to the stack, which is breaks if s/is//. CONFIG_VMAP_STACK=y. Fix it by switching to crypto_cipher_encrypt_one(). The new code should be considerably faster as an added benefit. This code is

Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack

2016-12-13 Thread Sergei Shtylyov
Hello! On 12/12/2016 11:54 PM, Andy Lutomirski wrote: smbencrypt() points a scatterlist to the stack, which is breaks if s/is//. CONFIG_VMAP_STACK=y. Fix it by switching to crypto_cipher_encrypt_one(). The new code should be considerably faster as an added benefit. This code is

Re: [PATCH] ipv4: Should use consistent conditional judgement for ip fragment in __ip_append_data and ip_finish_output

2016-12-09 Thread Sergei Shtylyov
Hello! On 12/9/2016 6:08 AM, Zheng Li wrote: From: zheng li There is an inconsitent conditional judgement in __ip_append_data and Inconsistent. ip_finish_output functions, the variable length in __ip_append_data just include the length of applicatoin's payload

Re: [PATCH] ipv4: Should use consistent conditional judgement for ip fragment in __ip_append_data and ip_finish_output

2016-12-09 Thread Sergei Shtylyov
Hello! On 12/9/2016 6:08 AM, Zheng Li wrote: From: zheng li There is an inconsitent conditional judgement in __ip_append_data and Inconsistent. ip_finish_output functions, the variable length in __ip_append_data just include the length of applicatoin's payload and udp header, don't

Re: [net-next][PATCH 02/18] RDS: mark few internal functions static to make sparse build happy

2016-12-05 Thread Sergei Shtylyov
Hello! On 12/5/2016 9:57 AM, Santosh Shilimkar wrote: Fixes below warnings: warning: symbol 'rds_send_probe' was not declared. Should it be static? warning: symbol 'rds_send_ping' was not declared. Should it be static? warning: symbol 'rds_tcp_accept_one_path' was not declared. Should it be

Re: [net-next][PATCH 02/18] RDS: mark few internal functions static to make sparse build happy

2016-12-05 Thread Sergei Shtylyov
Hello! On 12/5/2016 9:57 AM, Santosh Shilimkar wrote: Fixes below warnings: warning: symbol 'rds_send_probe' was not declared. Should it be static? warning: symbol 'rds_send_ping' was not declared. Should it be static? warning: symbol 'rds_tcp_accept_one_path' was not declared. Should it be

Re: [PATCH 1/1] isdn: hisax: set error code on failure

2016-12-04 Thread Sergei Shtylyov
On 12/4/2016 1:33 PM, Pan Bian wrote: You now need to indicate the patch version in hte subject, like this: [PATCH 1/1 v2] isdn:... From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to

Re: [PATCH 1/1] isdn: hisax: set error code on failure

2016-12-04 Thread Sergei Shtylyov
On 12/4/2016 1:33 PM, Pan Bian wrote: You now need to indicate the patch version in hte subject, like this: [PATCH 1/1 v2] isdn:... From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region()

Re: [PATCH 1/1] net: bnx2x: fix improper return value

2016-12-04 Thread Sergei Shtylyov
On 12/4/2016 11:39 AM, Pan Bian wrote: From: Pan Bian Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate Macro. memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling

Re: [PATCH 1/1] net: bnx2x: fix improper return value

2016-12-04 Thread Sergei Shtylyov
On 12/4/2016 11:39 AM, Pan Bian wrote: From: Pan Bian Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate Macro. memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling the macro, the value

Re: [PATCH 1/1] isdn: hisax: set error code on failure

2016-12-04 Thread Sergei Shtylyov
Hello. On 12/4/2016 8:15 AM, Pan Bian wrote: From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region() returns NULL, the value of err is 0. This patch fixes the bug, assiging

Re: [PATCH 1/1] isdn: hisax: set error code on failure

2016-12-04 Thread Sergei Shtylyov
Hello. On 12/4/2016 8:15 AM, Pan Bian wrote: From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region() returns NULL, the value of err is 0. This patch fixes the bug, assiging "-ENOMEM" to err on the

Re: [PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Sergei Shtylyov
On 12/03/2016 06:38 PM, Pan Bian wrote: In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian ---

Re: [PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Sergei Shtylyov
On 12/03/2016 06:38 PM, Pan Bian wrote: In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian --- net/caif/caif_socket.c | 2 +- 1 file

Re: [PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Sergei Shtylyov
Hello. On 12/3/2016 2:18 PM, Pan Bian wrote: In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian ---

Re: [PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Sergei Shtylyov
Hello. On 12/3/2016 2:18 PM, Pan Bian wrote: In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian --- net/caif/caif_socket.c | 2 +- 1

Re: [PATCH v2] fsl/usb: Workarourd for USB erratum-A005697

2016-11-25 Thread Sergei Shtylyov
Hello. On 11/25/2016 06:24 AM, Changming Huang wrote: The EHCI specification states the following in the SUSP bit description: In the Suspend state, the port is senstive to resume detection. Sensitive. Note that the bit status does not change untile the port is suspended and Until.

Re: [PATCH v2] fsl/usb: Workarourd for USB erratum-A005697

2016-11-25 Thread Sergei Shtylyov
Hello. On 11/25/2016 06:24 AM, Changming Huang wrote: The EHCI specification states the following in the SUSP bit description: In the Suspend state, the port is senstive to resume detection. Sensitive. Note that the bit status does not change untile the port is suspended and Until.

Re: [PATCH 3/8] irda: w83977af_ir: Remove unnecessary blank lines

2016-11-25 Thread Sergei Shtylyov
Hello. On 11/24/2016 10:10 PM, Joe Perches wrote: These just add unnecessary vertical whitespace. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c

Re: [PATCH 3/8] irda: w83977af_ir: Remove unnecessary blank lines

2016-11-25 Thread Sergei Shtylyov
Hello. On 11/24/2016 10:10 PM, Joe Perches wrote: These just add unnecessary vertical whitespace. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c

<    4   5   6   7   8   9   10   11   12   13   >