[Linux-kernel-mentees] [PATCH] Documentation: filesystems: Convert jfs.txt to reStructedText format.

2019-07-06 Thread Shobhit Kukreti
This converts the plain text documentation of jfs.txt to reStructuredText format. Added to documentation build process and verified with make htmldocs Signed-off-by: Shobhit Kukreti --- Documentation/filesystems/index.rst | 1 + Documentation/filesystems/jfs.rst | 74

[Linux-kernel-mentees] [PATCH] video: atmel_lcdc: Fix Shifting signed 32 bit value by 31 bits problem

2019-07-06 Thread Shobhit Kukreti
for builds using compilers which do not handle this condition safely resulting in undefined behavior Signed-off-by: Shobhit Kukreti --- include/video/atmel_lcdc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/video/atmel_lcdc.h b/include/video/atmel_lcdc.h ind

Re: [PATCH 10/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

2019-06-29 Thread Shobhit Kukreti
On Sat, Jun 29, 2019 at 04:07:51PM +0530, Hariprasad Kelam wrote: Hello Hari Prasad, Please add the recommended reviewers mentioned in the TODO file of rtl8723bs directory. I see the following emails in the TODO file. Greg Kroah-Hartman , Hans de Goede and Larry Finger > fix below issues

[PATCH 3/3] staging: rtl8723bs: os_dep: Change return type of rtw_init_default_value() to void

2019-06-22 Thread Shobhit Kukreti
rtw_init_default_value() func always returns a value (u8)_SUCCESS. Modified return type to void to resolve coccicheck warnings of unneeded variable. Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

[PATCH 0/3] Change function return type to void

2019-06-22 Thread Shobhit Kukreti
changes return type of rtw_suspend_wow() to void PATCH[3/3]: This patch changes return type of rtw_init_default_value to void Shobhit Kukreti (3): staging: rtl8723bs: os_dep: Change return type of function rtw_suspend_normal() to void staging: rtl8723bs: os_dep: modified return type

[PATCH 2/3] staging: rtl8723bs: os_dep: modified return type of function rtw_suspend_wow() to void

2019-06-22 Thread Shobhit Kukreti
Changed return type of function rtw_suspend_wow() to void. The function always return _SUCCESS and the value is never checked in the calling function. Resolves coccicheck Unneeded variable "ret" warning. Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/include/drv_t

[PATCH 1/3] staging: rtl8723bs: os_dep: Change return type of function rtw_suspend_normal() to void

2019-06-22 Thread Shobhit Kukreti
Coccicheck issues Unneeded variable "ret" warning. The return value of function rtw_suspend_normal() is set to _SUCCESS. The return value is never never checked by the calling function. Modified return type to void to remove the coccicheck warning.. Signed-off-by: Shobhit Kukreti --

[PATCH 2/2] staging: rtl8723bs: os_dep: Modify return type of function rtw_reset_drv_sw() to void.

2019-06-22 Thread Shobhit Kukreti
The function rtw_reset_drv_sw() return value is set to _SUCCESS. The return value is never checked when the function is called. Modified the return value to void to remove "Unneeded Variable warning of coccicheck. Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/include/osdep_i

[PATCH 0/2] Modify functions return type to void

2019-06-22 Thread Shobhit Kukreti
] : This patch modifies return type of rtw_reset_drv_sw() to void. Shobhit Kukreti (2): staging: rtl8723bs: os_dep: Modify return type of function loadparam(..) to void staging: rtl8723bs: os_dep: Modify return type of function rtw_reset_drv_sw() to void. drivers/staging/rtl8723bs/include

[PATCH 1/2] staging: rtl8723bs: os_dep: Modify return type of function loadparam(..) to void

2019-06-22 Thread Shobhit Kukreti
. Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index 8a9d838..bd8e316 100644 --- a/drivers/staging/rtl8723bs

[PATCH] staging: rtl8723bs: hal: Fix Brace Style Issues in if/else statements

2019-06-18 Thread Shobhit Kukreti
Cleaned Up code to fix brace style issues reported by checkpatch: -space required before the open brace '{' -Unbalanced braces around if/else statements Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 25 +++-- 1 file changed, 11 insertions

[PATCH] staging: rtl8723bs: hal: Remove True/False Comparisons

2019-06-18 Thread Shobhit Kukreti
Removing comparisons to True/False in if statements. Checkpatch reported: CHECK: Using comparison to true is error prone Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v4 0/3] Resolve if/else brace-style errors

2019-06-18 Thread Shobhit Kukreti
n the else statement Shobhit Kukreti (3): staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver staging: rtl8723bs: Resolve the checkpatch error: else should follow close brace '}' staging: rtl8723bs: Fix Indentatio

[PATCH v4 1/3] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver

2019-06-18 Thread Shobhit Kukreti
3bs/os_dep/sdio_intf.c drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 14 ++--- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 76 --- drivers/staging/rtl8723bs/os_dep/rtw_proc.c

[PATCH v4 3/3] staging: rtl8723bs: Fix Indentation Error: code indent should use tabs where possible

2019-06-18 Thread Shobhit Kukreti
Resolve indentation errors which were caused by a mix of space and tabs for indentation. Previous patch to fix if-else brace styles revealed the indentation error Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 6 ++--- drivers/staging/rtl8723bs/os_dep

[PATCH v4 2/3] staging: rtl8723bs: Resolve the checkpatch error: else should follow close brace '}'

2019-06-18 Thread Shobhit Kukreti
Cleaned up the code to resolve the checkpatch error else should follow close brace '}' from the following files: mlme_linux.c recv_linux.c sdio_intf.c Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 6 ++ drivers/staging/rtl8723bs/os_dep/recv_linux.c

[PATCH v3 2/3] staging: rtl8723bs: Resolve the checkpatch error: else should follow close brace '}'

2019-06-16 Thread Shobhit Kukreti
Cleaned up the code to resolve the checkpatch error else should follow close brace '}' from the following files: mlme_linux.c recv_linux.c sdio_intf.c Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 6 ++ drivers/staging/rtl8723bs/os_dep/recv_linux.c

[PATCH v3 3/3] staging: rtl8723bs: Fix Indentation Error: code indent should use tabs where possible

2019-06-16 Thread Shobhit Kukreti
Resolve indentation errors which were caused by a mix of space and tabs for indentation. Previous patch to fix if-else brace styles revealed the indentation error Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 6 ++--- drivers/staging/rtl8723bs/os_dep

[PATCH v3 1/3] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver

2019-06-16 Thread Shobhit Kukreti
3bs/os_dep/sdio_intf.c drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 15 +++-- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 77 --- drivers/staging/rtl8723bs/os_dep/rtw_proc.c

[PATCH v3 0/3] Resolve checkpatch if/else brace style errors

2019-06-16 Thread Shobhit Kukreti
- Removed Trailing whitespace introduced in the previous patch - Moved comments to a new line in the else statement Shobhit Kukreti (3): staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver staging: rtl8723bs: Re

Re: [PATCH v2] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver

2019-06-16 Thread Shobhit Kukreti
On Sun, Jun 16, 2019 at 01:13:11AM -0700, Joe Perches wrote: > On Sat, 2019-06-15 at 14:29 -0700, Shobhit Kukreti wrote: > > Cleaned up the code from the following files to get rid of > > check patch error "that open brace { should be on the previous line" > > It

[PATCH v2] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver

2019-06-15 Thread Shobhit Kukreti
3bs/os_dep/sdio_intf.c drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c Signed-off-by: Shobhit Kukreti --- Changes in v2: - Removed Trailing whitespace introduced in the previous patch - Moved comments to a new line drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 15 +++-- drivers/staging

[PATCH] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723bs driver

2019-06-13 Thread Shobhit Kukreti
3bs/os_dep/sdio_intf.c drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 14 ++--- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 76 --- drivers/staging/rtl8723bs/os_dep/rtw_proc.c

[PATCH] iio: humidity: Replace older GPIO APIs with GPIO Consumer APIs for the dht11 sensor

2019-06-10 Thread Shobhit Kukreti
The dht11 driver uses a single gpio to make measurements. It was using the older global gpio numberspace. The patch replaces the old gpio api with the new gpio descriptor based api. Removed header files "linux/gpio.h" and "linux/of_gpio.h" Signed-off-by: Shobhit Kukre

[PATCH] staging: rtl8723bs: Fix Unneeded variable: "ret". Return "0"

2019-06-06 Thread Shobhit Kukreti
coccicheck reported Unneeded variable ret at rtl8723bs/core/rtw_ap.c:1400. Function "rtw_acl_remove_sta" always returns 0. Modified return type of the function to void. Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/core/rtw_ap.c| 4 +--- drivers/staging/rtl8723

[PATCH v2] staging: rtl8723bs: Resolve "(foo*)" should be "(foo *)" error reported by checkpatch

2019-06-06 Thread Shobhit Kukreti
Cleaned up the code to remove the error "(foo*)" should be "(foo *)" reported by checkpatch from the file rtl8723bs/os_dep/ioctl_linux.c Signed-off-by: Shobhit Kukreti --- Changes in v2: - Modified commit message to include reported ERROR by checkpatch drivers/stag

[PATCH] staging: rtl8723bs: CleanUp to remove the error reported by checkpatch

2019-06-05 Thread Shobhit Kukreti
Cleaned up the code to remove the error "(foo*)" should be "(foo *)" reported by checkpatch from the file rtl8723bs/os_dep/ioctl_linux.c Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 32 +- 1 file changed,

[PATCH] media: platform: Fix Warning of Unneeded Semicolon reported by coccicheck

2019-06-04 Thread Shobhit Kukreti
fixed the warning in the files below drivers/media/platform/pxa_camera.c:1391:2-3: Unneeded semicolon drivers/media/platform/qcom/venus/vdec_ctrls.c:78:2-3: Unneeded semicolon drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c:146:3-4: Unneeded semicolon Signed-off-by: Shobhit Kukreti

[PATCH] media: i2c: Fix Unnecessary Semicolon Warning Reported by coccicheck

2019-06-01 Thread Shobhit Kukreti
Removed the warning from the following files: drivers/media/i2c/ov13858.c drivers/media/i2c/ov2685.c drivers/media/i2c/ov5695.c Signed-off-by: Shobhit Kukreti --- drivers/media/i2c/ov13858.c | 4 ++-- drivers/media/i2c/ov2685.c | 2 +- drivers/media/i2c/ov5695