Re: [PATCH] drivers: usb: chipidea: convert to devm_ioremap_resource()

2013-04-11 Thread Silviu Popescu
On Thu, Apr 11, 2013 at 10:12 AM, Alexander Shishkin wrote: > That's cool, but your chipidea patches have to be based off of > ci-for-greg branch of the chipidea tree [1] or at least usb-next branch > of Greg's usb.git [2]. > > [1] git://github.com/virtuoso/linux-ci.git > [2] git://git.kernel.org/

Re: [PATCH] kirkwood: fix coccicheck warnings

2013-03-21 Thread Silviu Popescu
s > for cpufreq, cpuidle and thermal (which would be for Rui BTW). There seems to be an existing patch for thermal[1], as Rui pointed out himself. I have split the changes in two patches, as you have requested, and resent them. [1] http://marc.info/?l=linux-pm&m=136238017027514&w=2 Tha

Re: [PATCH] mach_omap2: use PTR_RET instead of IS_ERR + PTR_ERR

2013-03-21 Thread Silviu Popescu
t;> introduce bugs. > > Sorry I am now not sure I follow you here. Someone just pointed out to > me that PTR_RET() is defined as ... > > static inline int __must_check PTR_RET(const void *ptr) > { > if (IS_ERR(ptr)) > return PTR_ERR(ptr); > else

Re: [PATCH] drivers: staging: davinci_vpfe: use resource_size()

2013-03-18 Thread Silviu Popescu
d seem I was a bit overzealous. Indeed, there was no need for that extra include. I've send a refreshed patch. Would you be so kind as to review it? Thanks, Silviu Popescu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...

Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

2013-03-18 Thread Silviu Popescu
On Mon, Mar 18, 2013 at 8:05 PM, Silviu Popescu wrote: > On Wed, Mar 13, 2013 at 11:31 AM, David Miller wrote: >> From: Silviu-Mihai Popescu >> Date: Tue, 12 Mar 2013 20:13:15 +0200 >> >>> @@ -590,10 +590,7 @@ int __init bt_sysfs_init(void) >>> bt_

Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR

2013-03-18 Thread Silviu Popescu
and allyesconfig compile successfully on my system. Would you be so kind as to tell me what error you have encountered? Or perhaps enlighten me as to what I'm still doing wrong. I'd like to learn from my mistakes. Thanks, Silviu Popescu -- To unsubscribe from this list: send the line &q

Re: [PATCH] ethernet: nxp: use resource_size()

2013-03-12 Thread Silviu Popescu
(ndev, "IO address size :%d\n", >> - res->end - res->start + 1); >> + resource_size(res)); > > This might be better as > > netdev_dbg(ndev, "IO resource:%pR\n", res); > > Thanks for the

Re: [PATCH v2] pci: convert to devm_ioremap_resource()

2013-03-12 Thread Silviu Popescu
On Tue, Mar 12, 2013 at 1:17 PM, Sergei Shtylyov wrote: > Hello. > > > On 12-03-2013 11:28, Silviu-Mihai Popescu wrote: > >> Convert all uses of devm_request_and_ioremap() to the newly introduced >> devm_ioremap_resource() which provides more consistent error handling. > > >> devm_ioremap_resource

Re: [PATCH] omap: convert to devm_ioremap_resource()

2013-03-12 Thread Silviu Popescu
On Tue, Mar 12, 2013 at 10:16 AM, Peter Ujfalusi wrote: > Hi, > > On 03/11/2013 04:58 PM, Silviu-Mihai Popescu wrote: >> Convert all uses of devm_request_and_ioremap() to the newly introduced >> devm_ioremap_resource() which provides more consistent error handling. >> >> devm_ioremap_resource() pr

Re: [PATCH] aic7xxx: fix coccicheck warnings

2013-03-11 Thread Silviu Popescu
return (ENOMEM); > - memset(ahc->platform_data, 0, sizeof(struct ahc_platform_data)); > ahc->platform_data->irq = AHC_LINUX_NOIRQ; > ahc_lockinit(ahc); > ahc->seltime = (aic7xxx_seltime & 0x3) << 4; > -- > 1

Re: [PATCH] aic7xxx: use kzalloc instead of kmalloc + memset

2013-03-11 Thread Silviu Popescu
lstate\n"); > ccb->ccb_h.status = CAM_RESRC_UNAVAIL; > return; > } > - memset(lstate, 0, sizeof(*lstate)); > status = xpt_create_path(&lstate->path, /*periph*/NULL, >

Re: [PATCH] kirkwood: fix coccicheck warnings

2013-03-11 Thread Silviu Popescu
t; > - dev_err(&pdev->dev, "Failed to request_ioremap memory\n"); >> > - return -EADDRNOTAVAIL; >> > - } >> > + priv->sensor = devm_ioremap_resource(&pdev->dev, res); >> > + if (IS_ERR(priv->sensor

Re: [PATCH] soc_camera: convert to devm_ioremap_resource()

2013-03-11 Thread Silviu Popescu
m to have missed that patch series. And no, this does not cover anything extra. I'm sorry for the lack of attention on my behalf. -- Silviu Popescu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More