Re: [PATCH v2] block: ratelimite pr_err on IO path

2018-04-16 Thread Sreekanth Reddy
On Mon, Apr 16, 2018 at 1:46 PM, Jinpu Wang wrote: > On Fri, Apr 13, 2018 at 6:59 PM, Martin K. Petersen > wrote: >> >> Jinpu, >> >> [CC:ed the mpt3sas maintainers] >> >> The ratelimit patch is just an attempt to treat the symptom, not the >> cause. > Agree. If we can fix the root cause, it will

RE: [PATCH] scsi: mpt3sas: clarify mmio pointer types

2018-03-04 Thread Sreekanth Reddy
-Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Thursday, March 1, 2018 6:37 PM To: Suganath Prabu S; Sathya Prakash; Chaitra P B; James E.J. Bottomley; Martin K. Petersen Cc: Arnd Bergmann; Hannes Reinecke; Sreekanth Reddy; mpt-fusionlinux@broadcom.com; linux-s

[PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

2017-10-10 Thread Sreekanth Reddy
ddress for Virtual SES device instead of HBA's sas address. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.

[PATCH 07/10] mpt3sas: Display chassis slot information of the drive

2017-10-10 Thread Sreekanth Reddy
Display chassis slot information along with other drive location parameters such as slot number and connector name in the logs; if chassis slot validity bit is set in 'SAS Enclosure Page 0' while adding the drive. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_bas

[PATCH 09/10] mpt3sas: Adding support for SAS3616 HBA device

2017-10-10 Thread Sreekanth Reddy
Adding PNP ID of Mercator i.e. SAS3616 HBA device. Its device ID is 0xD1 and vendor ID is 0x1000. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas

[PATCH 06/10] mpt3sas: Updated MPI headers to v2.00.48

2017-10-10 Thread Sreekanth Reddy
Updated MPI headers to v2.00.48 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpi/mpi2.h | 43 ++- drivers/scsi/mpt3sas/mpi/mpi2_cnfg.h | 564 +-- drivers/scsi/mpt3sas/mpi/mpi2_init.h | 11 +- drivers/scsi/mpt3sas/mpi/mpi2_ioc.h | 282

[PATCH 10/10] mpt3sas: Bump mpt3sas driver version to v16.100.00.00

2017-10-10 Thread Sreekanth Reddy
Bump mpt3sas driver version to v16.100.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 75d90f2..0fe3969 100644

[PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

2017-10-10 Thread Sreekanth Reddy
reset to current value, by referring the enclosure handles from corresponding device pages Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 117 --- 1 file changed, 81 insertions(+), 36 deletions(-) diff --git a/drivers/scsi/mpt3sas

[PATCH 05/10] mpt3sas: Fix IO error occurs on pulling out a drive from RAID1 volume created on two SATA drive

2017-10-10 Thread Sreekanth Reddy
. Earlier driver is returning the IO with "DID_SOFT_ERROR" that reties the IO quickly for five times but still firmware needed some more time and hence IOs were failing. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 + 1 file changed, 5 insertio

[PATCH 01/10] mpt3sas: Processing of Cable Exception events

2017-10-10 Thread Sreekanth Reddy
. MPI 2.5 spec supporting HBAs) earlier this event was enabled only for MPI 2.6 spec supporting HBA devices. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 5 ++--- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 20 +++- 2 files changed, 13 insertions(+), 12 deletions(

[PATCH 02/10] mpt3sas: Fixed memory leaks in driver

2017-10-10 Thread Sreekanth Reddy
cated data structures. Updated the driver to remove the expander device from the list only after freeing all its child devices. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/sc

[PATCH 00/10] [SCSI] mpt3sas: Phase15 driver enhancements and fixes

2017-10-10 Thread Sreekanth Reddy
Phase15 driver enhancements and fixes. Sreekanth Reddy (10): mpt3sas: Processing of Cable Exception events mpt3sas: Fixed memory leaks in driver mpt3sas: Reduce memory footprints in kdump kernel mpt3sas: Fix removal and addition of vSES device during host reset mpt3sas: Fix IO error

[PATCH 03/10] mpt3sas: Reduce memory footprints in kdump kernel

2017-10-10 Thread Sreekanth Reddy
To reduce the memory footprints of the driver in kdump kernel, we have made below driver setting when system boots in to kdump kernel, 1. Used single MSI-x vector. 2. Disable RDPQ mode. 3. Set sg_table_size to 32 by default. 4) Set SCSI IO Queue depth to 200. Signed-off-by: Sreekanth Reddy

Re: [PATCH v2 00/13] mpt3sas driver NVMe support:

2017-08-08 Thread Sreekanth Reddy
On Tue, Aug 8, 2017 at 9:34 AM, Keith Busch wrote: > On Mon, Aug 07, 2017 at 08:45:25AM -0700, James Bottomley wrote: >> On Mon, 2017-08-07 at 20:01 +0530, Kashyap Desai wrote: >> > >> > We have to attempt this use case and see how it behaves. I have not >> > tried this, so not sure if things are

Re: [PATCH v2 09/13] mpt3sas: scan and add nvme device after controller reset

2017-08-03 Thread Sreekanth Reddy
On Thu, Aug 3, 2017 at 12:10 PM, Hannes Reinecke wrote: > On 07/14/2017 03:22 PM, Suganath Prabu S wrote: >> After Controller reset, Scan and add nvme device back to the topology. >> >> Signed-off-by: Chaitra P B >> Signed-off-by: Suganath Prabu S >> --- >> drivers/scsi/mpt3sas/mpt3sas_scsih.c

Re: [PATCH v2 02/13] mpt3sas: Add nvme device support in slave alloc, target alloc and probe

2017-08-03 Thread Sreekanth Reddy
On Thu, Aug 3, 2017 at 11:57 AM, Hannes Reinecke wrote: > On 07/14/2017 03:22 PM, Suganath Prabu S wrote: >> 1) Added support for probing pcie device and adding NVMe drives to >> SML and driver's internal list pcie_device_list. >> >> 2) Added support for determing NVMe as boot device. >> >> 3) Add

Re: [PATCH v2 08/13] mpt3sas: Set NVMe device queue depth as 128

2017-08-03 Thread Sreekanth Reddy
On Thu, Aug 3, 2017 at 12:09 PM, Hannes Reinecke wrote: > On 07/14/2017 03:22 PM, Suganath Prabu S wrote: >> Sets nvme device queue depth, name and displays device capabilities >> >> Signed-off-by: Chaitra P B >> Signed-off-by: Suganath Prabu S >> --- >> drivers/scsi/mpt3sas/mpt3sas_base.h |

Re: [PATCH v2 01/13] mpt3sas: Update MPI Header

2017-08-03 Thread Sreekanth Reddy
On Thu, Aug 3, 2017 at 1:25 PM, Johannes Thumshirn wrote: > On Thu, Aug 03, 2017 at 08:24:59AM +0200, Hannes Reinecke wrote: >> > + U32 >> > + IOCLogInfo; /*0x10 */ >> > + U16 >> > + ErrorResponseCount; /*0x14 */ >> > + U16 >> > +

mpt3sas: driver got task abort request just after it's .shutdown() function is invoked

2017-06-13 Thread Sreekanth Reddy
Hi All, I am using 4.9 kernel and I am observing NULL pointer deference type kernel panic in the below scenario, * Hotplug (i.e. hot add) the HBA (with a set of drives attached to it) to the system just few seconds before issuing "poweroff" command. * Observed that during drives discovery proces

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2017-04-25 Thread Sreekanth Reddy
On Thu, Jul 24, 2014 at 1:16 AM, Martin K. Petersen wrote: >>>>>> "Sreekanth" == Sreekanth Reddy writes: > > Sreekanth, > > Sreekanth> 2. As per MPI Spec, each set of 8 reply descriptor post > Sreekanth> queues must have the same value for the u

Re: [PATCH V2] scsi: mpt3sas: remove redundant wmb

2017-04-21 Thread Sreekanth Reddy
On Thu, Apr 20, 2017 at 7:58 AM, Martin K. Petersen wrote: > Sinan Kaya writes: > >> Due to relaxed ordering requirements on multiple architectures, >> drivers are required to use wmb/rmb/mb combinations when they need to >> guarantee observability between the memory and the HW. >> >> The mpt3sas

Re: Getting "Wrong diagnostic page; asked for 7 got 0" error message on HBA's virtual SES device

2017-03-15 Thread Sreekanth Reddy
Hi, Any Update? Thanks, Sreekanth On Mon, Mar 13, 2017 at 12:13 PM, Sreekanth Reddy wrote: > Hi, > > Our LSI(Broadcom) SAS3.5 HBA device's support virtual SES device. > > Whenever we load the mpt3sas driver then we are observing below error message, > > "Wrong d

Getting "Wrong diagnostic page; asked for 7 got 0" error message on HBA's virtual SES device

2017-03-12 Thread Sreekanth Reddy
Hi, Our LSI(Broadcom) SAS3.5 HBA device's support virtual SES device. Whenever we load the mpt3sas driver then we are observing below error message, "Wrong diagnostic page; asked for 7 got 0" Our virtual SES device doesn't support Diagnostic page 7, it supports only below diagnostic pages, • 0

Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

2017-01-20 Thread Sreekanth Reddy
On Fri, Jan 20, 2017 at 8:30 PM, Johannes Thumshirn wrote: > On Fri, Jan 20, 2017 at 08:12:11PM +0530, Chaitra P B wrote: >> Small glitch/degraded performance in Crusader is improved with SAS >> drives by removing unnecessary spinlocks while clearing scsi command >> in drivers internal lookup tabl

Re: [PATCH v2 3/4] mpt3sas: Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test.

2017-01-20 Thread Sreekanth Reddy
On Fri, Jan 20, 2017 at 8:40 PM, Johannes Thumshirn wrote: > On Fri, Jan 20, 2017 at 08:12:12PM +0530, Chaitra P B wrote: >> Due existence of loop in the IO path our HBA will receive heavy IOs and >> also as driver is not updating the Reply Post Host Index frequently, So >> there will be a high ch

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2017-01-17 Thread Sreekanth Reddy
it operations. I don't see any issue functionality wise. > sas_target_priv_data = sas_device_priv_data->sas_target; > > /* invalid device handle */ > @@ -4650,8 +4663,7 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *ioc, u16 smid, > u8 msix_index, u32 reply) > if (scmd == NULL) > return 1; > > - if (ata_12_16_cmd(scmd)) > - scsi_internal_device_unblock(scmd->device, SDEV_RUNNING); > + _scsih_set_satl_pending(scmd, false); > > mpi_request = mpt3sas_base_get_msg_frame(ioc, smid); > > -- > 2.6.6 > Tested this patch. It is working fine. Please consider this patch as Acked-by: Sreekanth Reddy Thanks, Sreekanth

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2017-01-06 Thread Sreekanth Reddy
folks: Please comment and test. Matin, We are fine with this patch. Can we rename function 'set_satl_pending()' name to '_scsih_set_satl_pending()' and can add headers to this function. other wise I am OK. Acked-by: Sreekanth Reddy > > -- > Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] mpt3sas: Recognize and act on iopriority info

2016-12-13 Thread Sreekanth Reddy
mand priorities in the identify information that is pulled from > the SATL. > > This patch depends on block: Add iocontext priority to request > > v2: > - Get iopriority class only if sysfs variable is set. > > Signed-off-by: Adam Manzanares Acked-by: Sreekanth Reddy &g

[PATCH RESEND] mpt3sas: Fix for block device of raid exists even after deleting raid disk

2016-10-27 Thread Sreekanth Reddy
ue to above hunk, we are not initializing raid_device's starget for raid volumes, and so during raid disk deletion driver is not calling scsi_remove_target() API as driver observes starget field of raid_device's structure as NULL. Signed-off-by: Sreekanth Reddy Cc: --- drivers/scsi/

[PATCH] mpt3sas: Fix for block device of raid exists even after deleting raid disk

2016-10-27 Thread Sreekanth Reddy
ue to above hunk, we are not initializing raid_device's starget for raid volumes, and so during raid disk deletion driver is not calling scsi_remove_target() API as driver observes starget field of raid_device's structure as NULL. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt

[PATCH v2] block: Fix kernel panic occurs while creating second raid disk

2016-10-25 Thread Sreekanth Reddy
From: Sreekanth Reddy Observing below kernel panic while creating second raid disk on LSI SAS3008 HBA card. [ +0.55] [ cut here ] [ +0.07] WARNING: CPU: 2 PID: 281 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x62/0x80 [ +0.02] sysfs: cannot create duplicate

[PATCH] block: Fix kernel panic occurs while creating second raid disk

2016-10-24 Thread Sreekanth Reddy
t there are no block devices for '8:32' & '8:48' bdi entries, which are PD's for raid disk /dev/sdk. Now while creating a second raid disk, kernel is trying to use MAJOR:MINOR as 8:32 for second raid disk and we observe above kernel OOPs. By calling bdi_unregi

Re: Observing Softlockup's while running heavy IOs

2016-09-12 Thread Sreekanth Reddy
On Thu, Sep 8, 2016 at 7:09 PM, Neil Horman wrote: > On Thu, Sep 08, 2016 at 11:12:40AM +0530, Sreekanth Reddy wrote: >> On Wed, Sep 7, 2016 at 6:54 PM, Neil Horman wrote: >> > On Wed, Sep 07, 2016 at 11:30:04AM +0530, Sreekanth Reddy wrote: >> >> On Tue, Sep 6

Re: Observing Softlockup's while running heavy IOs

2016-09-07 Thread Sreekanth Reddy
On Wed, Sep 7, 2016 at 6:54 PM, Neil Horman wrote: > On Wed, Sep 07, 2016 at 11:30:04AM +0530, Sreekanth Reddy wrote: >> On Tue, Sep 6, 2016 at 8:36 PM, Neil Horman wrote: >> > On Tue, Sep 06, 2016 at 04:52:37PM +0530, Sreekanth Reddy wrote: >> >> On Fri, Sep 2, 20

Re: Observing Softlockup's while running heavy IOs

2016-09-01 Thread Sreekanth Reddy
On Fri, Aug 19, 2016 at 9:26 PM, Bart Van Assche wrote: > On 08/19/2016 04:44 AM, Sreekanth Reddy wrote: >> >> [ +0.000439] __blk_mq_run_hw_queue() finished after 10058 ms >> [ ... ] >> [ +0.05] [] ? finish_task_switch+0x6b/0x200 >> [ +0.06] [] __sch

Re: Observing Softlockup's while running heavy IOs

2016-08-19 Thread Sreekanth Reddy
n Fri, Aug 19, 2016 at 2:38 AM, Elliott, Robert (Persistent Memory) wrote: > > >> -Original Message- >> From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- >> ow...@vger.kernel.org] On Behalf Of Sreekanth Reddy >> Sent: Thursday, August 18, 2016 12:56

Observing Softlockup's while running heavy IOs

2016-08-17 Thread Sreekanth Reddy
Hi, Problem statement: Observing softlockups while running heavy IOs on 8 SSD drives connected behind our LSI SAS 3004 HBA. System configuration: OS & kernel version: Fedora 23, v4.2.3-300.fc23.x86_64 NUMA : disabled, CPUs : 24 logical cpus, SCSI_MQ: enabled Driver : mpt3sas, MSIx vectors: we ha

Re: [PATCH] mpt3sas: Do scsi_remove_host() before deleting SAS PHY objects

2016-05-18 Thread Sreekanth Reddy
3sas_device_remove_by_sas_address+0xa1/0xe0 [mpt3sas] [] scsih_remove+0xe0/0x1d0 [mpt3sas] [] pci_device_remove+0x44/0xd0 [] ? __pm_runtime_idle+0x8e/0x90 [] __device_release_driver+0xb4/0x160 [] driver_detach+0xbe/0xc0 [] bus_remove_driver+0x59/0xc0 [] driver_unregister+0x30/0x60 [] pci_unreg

Re: [PATCH] mpt3sas: Do scsi_remove_host() before deleting SAS PHY objects

2016-05-18 Thread Sreekanth Reddy
On Tue, May 17, 2016 at 8:43 AM, Calvin Owens wrote: > On Monday 05/16 at 15:51 -0600, Sathya Prakash Veerichetty wrote: >> Our understanding is the relationship between the SCSI host and SAS end >> devices is a parent-child and before ripping of SCSI host we need to rip of >> all the children. >

Re: [PATCH 6/6] mpt3sas: Used "synchronize_irq()"API to synchronize timed-out IO & TMs

2016-05-10 Thread Sreekanth Reddy
On Tue, May 10, 2016 at 6:41 PM, Tomas Henzl wrote: > On 6.5.2016 10:59, Chaitra P B wrote: >> Replaced mpt3sas_base_flush_reply_queues()with >> mpt3sas_base_sync_reply_irqs(),as mpt3sas_base_flush_reply_queues() >> skips over reply queues that are currently busy (i.e. being handled >> by interrup

Re: [mpt3sas driver 07/10] mpt3sas: Add support for configurable Chain Frame Size

2016-02-04 Thread Sreekanth Reddy
On Thu, Feb 4, 2016 at 8:35 PM, Tomas Henzl wrote: > On 28.1.2016 07:37, Suganath prabu Subaramani wrote: >> From: Suganath prabu Subramani >> >> Added support for configurable Chain Frame Size. Calculate the >> Chain Message Frame size from the IOCMaxChainSegementSize (iocfacts). >> Applicable o

Re: MPT2SAS boot fail... due to silently loosing the driver

2015-12-01 Thread Sreekanth Reddy
On Mon, Nov 30, 2015 at 10:51 PM, Martin K. Petersen wrote: > > > "Ingo" == Ingo Molnar writes: > > Ingo> So you need to make it interactive, with a short help text that > Ingo> explains to users that this is legacy option only, and that they > Ingo> should enable the MPT3SAS option if they w

Re: linux-next: build failure after merge of the scsi tree

2015-11-13 Thread Sreekanth Reddy
Thanks Stephen. Please consider this patch as Ack-by: Sreekanth Reddy Thanks, Sreekanth On Fri, Nov 13, 2015 at 7:05 AM, Stephen Rothwell wrote: > Hi James, > > After merging the scsi tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > In fil

[PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag

2015-11-12 Thread Sreekanth Reddy
sable the TLR 3. sas_is_tlr_enabled() - to check whether TLR is enabled or not. but in scsih_qcmd() we have missed to use sas_is_tlr_enabled() API, instead we checking for TLR bit from flag field of driver's 'struct MPT3SAS_DEVIC' structure. which is corrected with this patch.

[PATCH RESEND 02/25] mpt3sas: Added mpt2sas driver definitions

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy 1. Added mpt2sas driver related macro's in mpt3sas header files 2. Made scsi host's, raid class's, pci's, ioctl's call back functions as a gobal API's, so that both the drivers can use these call back functions. Signed-off-by: Sreekanth Re

[PATCH RESEND 04/25] mpt2sas: Created mpt2sas_module.c file in which Gen2 HBA's are registers with PCI, SML and IOCTLs

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy 1. Create a mpt2sas_module.c file for mpt2sas driver module where GEN2 HBA devices registers with PCI, SML, IOCTL subsytems. 2. Updated the Makefile to use the object files from mpt3sas folder 3. Defined a compilation defination flag SCSI_MPT2SAS which can be used to not

[PATCH RESEND 16/25] mpt3sas: Added OEMs Gen2 PnP ID Branding names

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy Added OEMs Gen2 PnP ID Branding names from mpt2sas driver. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 326 drivers/scsi/mpt3sas/mpt3sas_base.h | 93 +- 2 files changed, 305 insertions(+), 114

[PATCH RESEND 13/25] mpt3sas: Ported the providing sysfs attribute to report Backup Rail Monitor Status

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy A new sysfs shost attribute called "BMR_status" is implemented to report Backup Rail Monitor status. This attribute is located in the path /sys/class/scsi_host/host#/BMR_status when reading this adapter attribute, then driver will output the state of GP

[PATCH RESEND 06/25] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy 1. Use 'hba_mpi_version_belonged' IOC varable to uniquely identify each individual generation driver functionality at runtime. 2. Declared global variable 'driver_name' and used this variable while reserving PCI regions and while allocating the I

[PATCH RESEND 08/25] mpt3sas: For an IO, build MPI SGL LIST on GEN2 HBA's and build IEEE SGL LIST on GEN3 HBA's

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy Gen2 HBA's uses MPI Scatter Gather Lists where as Gen3 HBA's uses IEEE Scatter Gather Lists. So modify the common code part in such a way that it will build IEEE SGL table for Gen3 HBA's and it will build MPI SGL table for Gen2 HBA's. Signed-off

[PATCH RESEND 15/25] mpt3sas: Refcount fw_events and fix unsafe list usage

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy The fw_event_work struct is concurrently referenced at shutdown, so add a refcount to protect it, and refactor the code to use it. Additionally, refactor _scsih_fw_event_cleanup_queue() such that it no longer iterates over the list without holding the lock, since

[PATCH RESEND 07/25] mpt2sas, mpt3sas : Removed SCSI_MPTXSAS_LOGGING entry from Kconfig

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy Currently there is a logging level option provided for user for each of our drivers in the kernel configuration utility. They can enable this option to get more verbose information. By default this is enabled. When this option is enabled then those functions which displays

[PATCH RESEND 11/25] mpt3sas: fix for driver fails EEH, recovery from injected pci bus error

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy This patch stops the driver to invoke kthread (which remove the dead ioc) for some time while EEH recovery has started. This changes are ported from below mpt2sas driver patch 'commit b4730fb6e54a634a145c9c71c5cf856f00beb5cd ("mpt2sas: fix for driver fails EEH

[PATCH RESEND 09/25] mpt3sas: Don't send PHYDISK_HIDDEN Raid Action request on SAS2 HBA's

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy Don't send PHYDISK_HIDDEN Raid Action request for SAS2 HBA's. Since these HBA's doesn't support this Raid Action. Also enable fast_path only for SAS3 HBA's. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 19 ++

[PATCH 22/25] mpt3sas: Added a module parameter hbas_to_enumerate

2015-11-11 Thread Sreekanth Reddy
Acts as legacy mpt2sas driver, which enumerates only SAS 2.0 HBAs 2 - Acts as legacy mpt3sas driver, which enumerates only SAS 3.0 HBAs Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 +-- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 32 +--- driver

[PATCH 25/25] mpt3sas: Bump mpt3sas driver version to 09.102.00.00

2015-11-11 Thread Sreekanth Reddy
Bump mpt3sas driver version to 09.102.00.00 Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h index 25c141c..a17bea9 100644

[PATCH RESEND 18/25] mpt2sas, mpt3sas: Update the driver versions

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy Bump the mpt2sas driver version to 20.102.00.00 and Bump the mpt3sas driver version to 9.101.00.00. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/scsi

[PATCH 19/25] mpt3sas: Single driver module which supports both SAS 2.0 & SAS 3.0 HBA's

2015-11-11 Thread Sreekanth Reddy
eever needed. * Aliased this merged driver to mpt2sas using MODULE_ALIAS. * Moved global varaible 'driver_name' to per adapter instance variable. * Created two raid function template and used corresponding raid function templates based on the run time check 'hba_mpi_version

[PATCH 24/25] mpt3sas: Added SCSI_MPT3SAS_MERGED config option

2015-11-11 Thread Sreekanth Reddy
. Allways set for merged mpt3sas driver. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/Kconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/scsi/mpt3sas/Kconfig b/drivers/scsi/mpt3sas/Kconfig index 2906146..ad171c4 100644 --- a/drivers/scsi/mpt3sas/Kconfig

[PATCH 21/25] mpt2sas: Removed mpt2sas folder

2015-11-11 Thread Sreekanth Reddy
Removed mpt2sas files, mpt2sas directory & mpt3sas_module.c file. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/Kconfig | 61 drivers/scsi/mpt2sas/Makefile | 15 -- drivers/scsi/mpt2sas/mpt2sas_module.c | 281 -- drivers/

[PATCH 23/25] mpt2sas: Removed mpt2sas entries from SCSI's Kconfig and Makefile

2015-11-11 Thread Sreekanth Reddy
Removed mpt2sas entries from SCSI's Kconfig and Makefile files. Signed-off-by: Sreekanth Reddy --- drivers/scsi/Kconfig | 1 - drivers/scsi/Makefile | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 95f7a76..8aed855 100644 --- a/drivers

[PATCH RESEND 12/25] mpt3sas: Ported WarpDrive product SSS6200 support

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy Ported below list of Warp drive specific patches 1. 'commit 0bdccdb0a090ad8dc5f851cad5e843244c410ee8 ("mpt2sas: WarpDrive New product SSS6200 support added")', 2. 'commit 82a452581230b3ffc9d6475dffdb2568497b5fec ("mpt2sas: WarpDrive I

[PATCH 20/25] mpt3sas: Moved Warpdriver specific functions to mpt3sas_warpdrive.c

2015-11-11 Thread Sreekanth Reddy
warpdrive specific functions. * Also in function mpt3sas_setup_direct_io(), used sector_div() API instead of division operator (which gives compilation errors on 32 bit machines) Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpt2sas_warpdrive.c | 338

[PATCH RESEND 17/25] mpt3sas: setpci reset kernel oops fix

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy setpci reset on nytro warpdrive card along with sysfs access and cli ioctl access resulted in kernel oops 1. pci_access_mutex lock added to provide synchronization between IOCTL, sysfs, PCI resource handling path 2. gioc_lock spinlock to protect list operations over

[PATCH RESEND 14/25] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy These objects can be referenced concurrently throughout the driver, we need a way to make sure threads can't delete them out from under each other. This patch adds the refcount, and refactors the code to use it. Additionally, we cannot iterate over the sas_device

[PATCH RESEND 10/25] mpt3sas: Manage MSIX vectors according to HBA device type

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy 1. Don't enable MSI-X vector for SAS2008 B0 controller, 2. Enable only single MSI-X vectors for below HBA's a. SAS2004 b. SAS2008 c. SAS2008_1 d. SAS2008_2 e. SAS2008_3 f. SAS2116_1 g. SAS2116_2 3. Enable Combined Reply Post Queue Support (i.e

[PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code

2015-11-11 Thread Sreekanth Reddy
pt2sas/mpt2sas_transport.c drivers/scsi/mpt2sas/mpt2sas_debug.h" Thanks, Sreekanth Sreekanth Reddy (25): mpt2sas: Use mpi headers from mpt3sas mpt3sas: Added mpt2sas driver definitions mpt3sas: Move Gen3 HBA's device registration with PCI, SML and IOCTL related API's to a sep

[PATCH RESEND 03/25] mpt3sas: Move Gen3 HBA's device registration with PCI, SML and IOCTL related API's to a separate file

2015-11-11 Thread Sreekanth Reddy
From: Sreekanth Reddy 1. Created a mpt3sas_module.c files for mpt3sas driver module, where it can register SAS3 HBA devices with PCI, SML, IOCTL subsystems. Also removed the correspanding API's from mpt3sas_scsih.c file. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/Mak

Re: [PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base

2015-10-08 Thread Sreekanth Reddy
On Wed, Oct 7, 2015 at 2:48 PM, Sreekanth Reddy wrote: > On Tue, Oct 6, 2015 at 10:43 PM, James Bottomley > wrote: >> On Tue, 2015-10-06 at 15:59 +0530, Sreekanth Reddy wrote: >>> On Tue, Oct 6, 2015 at 3:16 PM, Christoph Hellwig >>> wrote: >>> &g

Re: [PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base

2015-10-07 Thread Sreekanth Reddy
On Tue, Oct 6, 2015 at 10:43 PM, James Bottomley wrote: > On Tue, 2015-10-06 at 15:59 +0530, Sreekanth Reddy wrote: >> On Tue, Oct 6, 2015 at 3:16 PM, Christoph Hellwig wrote: >> > This series seems to miss patch 5 which actually removes the mpt2sas >> > driver - it

Re: [PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base

2015-10-06 Thread Sreekanth Reddy
can convert it to build a mpt_common > module used by both drivers later. > > Acked-by: Christoph Hellwig > > On Wed, Sep 30, 2015 at 09:17:00PM +0530, Sreekanth Reddy wrote: >> Combined mpt2sas and mpt3sas driver code base in such a way that >> still we can generate the t

[PATCH 02/18] mpt3sas : Added mpt2sas driver definitions

2015-09-30 Thread Sreekanth Reddy
1. Added mpt2sas driver related macro's in mpt3sas header files 2. Made scsi host's, raid class's, pci's, ioctl's call back functions as a gobal API's, so that both the drivers can use these call back functions. Signed-off-by: Sreekanth Reddy --- drivers/scsi

[PATCH 14/18] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-30 Thread Sreekanth Reddy
es on mpt3sas driver also. 'commit d224fe0d609734888af63656ddaf3a8352f0a7b5 ("mpt2sas: Refcount sas_device objects and fix unsafe list usage")' Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 24 +- drivers/scsi/mpt3sas/

[PATCH 09/18] mpt3as: Don't send PHYDISK_HIDDEN Raid Action request on SAS2 HBA's

2015-09-30 Thread Sreekanth Reddy
Don't send PHYDISK_HIDDEN Raid Action request for SAS2 HBA's. Since these HBA's doesn't support this Raid Action. Also enable fast_path only for SAS3 HBA's. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 19 +-- 1 file cha

[PATCH 03/18] mpt3sas: Move Gen3 HBA's device registration with PCI, SML and IOCTL related API's to a separate file

2015-09-30 Thread Sreekanth Reddy
1. Created a mpt3sas_module.c files for mpt3sas driver module, where it can register SAS3 HBA devices with PCI, SML, IOCTL subsystems. Also removed the correspanding API's from mpt3sas_scsih.c file. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/Makefile | 3 +- drivers

[PATCH 07/18] mpt2sas, mpt3sas : Removed SCSI_MPTXSAS_LOGGING entry from Kconfig

2015-09-30 Thread Sreekanth Reddy
mpletely enable this logging option (by removing the #ifdef CONFIG_SCSI_MPT3SAS_LOGGING preprocessor check conditions), so that all the functions which are defined to display more verbos will also get compiled. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/Kconfig | 6 -

[PATCH 12/18] mpt3sas : Ported WarpDrive product SSS6200 support

2015-09-30 Thread Sreekanth Reddy
_IOCTL_INTERFACE_SAS2_SSS6200 for Warp Drive MPT2_IOCTL_INTERFACE_SAS2 for other Gen2 HBA's Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpt2sas_warpdrive.c | 338 +++ drivers/scsi/mpt3sas/mpt3sas_base.c | 68 ++- drivers/scsi/mpt3sas/mp

[PATCH 11/18] mpt3sas: fix for driver fails EEH, recovery from injected pci bus error

2015-09-30 Thread Sreekanth Reddy
ed pci bus error")' Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 19 ++- drivers/scsi/mpt3sas/mpt3sas_base.h | 1 + 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_

[PATCH 06/18] mpt3sas: Define 'hba_mpi_version_belonged' IOC variable

2015-09-30 Thread Sreekanth Reddy
1. Use 'hba_mpi_version_belonged' IOC varable to uniquely identify each individual generation driver functionality at runtime. 2. Declared global variable 'driver_name' and used this variable while reserving PCI regions and while allocating the IRQ's. Signed-off-by: Sree

[PATCH 08/18] mpt3sas: For an IO, build MPI SGL LIST on GEN2 HBA's and build IEEE SGL LIST on GEN3 HBA's

2015-09-30 Thread Sreekanth Reddy
Gen2 HBA's uses MPI Scatter Gather Lists where as Gen3 HBA's uses IEEE Scatter Gather Lists. So modify the common code part in such a way that it will build IEEE SGL table for Gen3 HBA's and it will build MPI SGL table for Gen2 HBA's. Signed-off-by: Sreekanth Reddy ---

[PATCH 15/18] mpt3sas: Refcount fw_events and fix unsafe list usage

2015-09-30 Thread Sreekanth Reddy
#x27; Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 116 --- 1 file changed, 94 insertions(+), 22 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 5dbf214..436e65e 10064

[PATCH 13/18] mpt3sas: Ported the providing sysfs attribute to report Backup Rail Monitor Status

2015-09-30 Thread Sreekanth Reddy
rted form below mpt2sas driver patch 'commit 6c265660c26267754a02063642ae042d469b4ef9 ("mpt2sas: Provide sysfs attribute to report Backup Rail Monitor Status") Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++ drivers/scsi/mpt3sas/mpt3sas_config.c

[PATCH 16/18] mpt3sas: Added OEMs Gen2 PnP ID Branding names

2015-09-30 Thread Sreekanth Reddy
Added OEMs Gen2 PnP ID Branding names from mpt2sas driver. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 326 drivers/scsi/mpt3sas/mpt3sas_base.h | 93 +- 2 files changed, 305 insertions(+), 114 deletions(-) diff --git a

[PATCH 18/18] mpt2sas, mpt3sas: Update the driver versions

2015-09-30 Thread Sreekanth Reddy
Bump the mpt2sas driver version to 20.102.00.00 and Bump the mpt3sas driver version to 9.101.00.00. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.h | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b

[PATCH 17/18] mpt3sas: setpci reset kernel oops fix

2015-09-30 Thread Sreekanth Reddy
patch is ported from below mpt2sas driver patch, 'commit 6229b414b3adb3aac0b54e67d72d6462fc230c0d ("mpt2sas: setpci reset kernel oops fix") Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 6 ++ drivers/scsi/mpt3sas/mpt3sas_base.h | 20 +++

[PATCH 10/18] mpt3sas: Manage MSIX vectors according to HBA device type

2015-09-30 Thread Sreekanth Reddy
for only Gen3 Invader/Fury C0 and above revision HBA's 4. Enable Combined Reply Post Queue Support (i.e. 96 MSI-X vector) for all Intruder and Cutlass HBA's Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt3sas/mpt3sas_base.c | 39 +++-

[PATCH 04/18] mpt2sas: Created mpt2sas_module.c file in which Gen2 HBA's are registers with PCI, SML and IOCTLs

2015-09-30 Thread Sreekanth Reddy
of code from mpt3sas driver which are not required for mpt2sas driver. 4. Inherited Automatic diag buffer feature from mpt3sas driver. Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/Makefile | 14 +- drivers/scsi/mpt2sas/mpt2sas_module.c | 280

[PATCH 00/18] mpt2sas, mpt3sas: Combine mpt2sas and mpt3sas driver code base

2015-09-30 Thread Sreekanth Reddy
Combined mpt2sas and mpt3sas driver code base in such a way that still we can generate the two driver modules (i.e. mpt2sas.ko for SAS2 HBA's & mpt3sas.ko for SAS3 HBA's) individualy. Sreekanth Reddy (18): mpt2sas: Use mpi headers from mpt3sas mpt3sas : Added mpt2sas driv

Re: [PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-08 Thread Sreekanth Reddy
safe way. > > This patch is a port of Calvin's PATCH-v4 for mpt2sas code, atop > mpt3sas changes in scsi.git/for-next. > > Cc: Calvin Owens > Cc: Christoph Hellwig > Cc: Sreekanth Reddy > Cc: MPT-FusionLinux.pdl > Signed-off-by: Nicholas Bellinger > --- >

Re: [PATCH v4 2/2] mpt2sas: Refcount fw_events and fix unsafe list usage

2015-09-04 Thread Sreekanth Reddy
s over the list without holding the lock, since > _firmware_event_work() concurrently deletes items from the list. > > Cc: Christoph Hellwig > Signed-off-by: Calvin Owens Tested-by: Chaitra Basappa ACK-by: Sreekanth Reddy > --- > Changes in v4: None > > Changes in v3: &

Re: [PATCH v4 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-09-04 Thread Sreekanth Reddy
c: Bart Van Assche > Cc: Joe Lawrence > Signed-off-by: Calvin Owens Tested-by: Chaitra Basappa ACK-by: Sreekanth Reddy > --- > Changes in v4: > * Fix lack of put() in non-SATA case in _scsih_change_queue_depth() > * Fix lack of put() in the non-error case i

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-27 Thread Sreekanth Reddy
Ok James, by 9/4/2015 we will provide our feedback over this patch series. Thanks, Sreekanth On Thu, Aug 27, 2015 at 8:10 PM, James Bottomley wrote: > On Thu, 2015-08-27 at 10:37 +0530, Sreekanth Reddy wrote: >> HI Nicholas & Calvin, >> >> Thanks for the patchset. Sure

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-26 Thread Sreekanth Reddy
HI Nicholas & Calvin, Thanks for the patchset. Sure We will review and we do some unit testing on this patch series. Currently my bandwidth is occupied with some internal activity, so by end of next week I will acknowledge this series if all the thing are fine with this patch series. Thanks, Sree

Re: [PATCH v3 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-08-10 Thread Sreekanth Reddy
On Sat, Aug 1, 2015 at 10:32 AM, Calvin Owens wrote: > These objects can be referenced concurrently throughout the driver, we > need a way to make sure threads can't delete them out from under each > other. This patch adds the refcount, and refactors the code to use it. > > Additionally, we cannot

Re: [PATCH 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-07-16 Thread Sreekanth Reddy
On Sun, Jul 12, 2015 at 9:54 AM, Calvin Owens wrote: > These objects can be referenced concurrently throughout the driver, we > need a way to make sure threads can't delete them out from under each > other. This patch adds the refcount, and refactors the code to use it. > > Additionally, we cannot

Re: [PATCH v3] [SCSI] mpt2sas, mpt3sas: Abort initialization if no memory I/O resources detected

2015-07-14 Thread Sreekanth Reddy
On Tue, Jul 14, 2015 at 10:36:58PM -0700, Yinghai Lu wrote: > On Tue, Jul 14, 2015 at 9:49 PM, Sreekanth Reddy > wrote: > > Driver crashes if the BIOS do not set up at least one > > memory I/O resource. This failure can happen if the device is too > > slow to respond duri

[PATCH] MAINTAINERS: Update LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) maintainers list

2015-07-14 Thread Sreekanth Reddy
Updating maintainers list for the entry LSILOGIC MPT FUSION DRIVERS in MAINTAINERS file Signed-off-by: Sreekanth Reddy --- MAINTAINERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2d3d55c..c3cd5c9 100644 --- a/MAINTAINERS +++ b

[PATCH v3] [SCSI] mpt2sas, mpt3sas: Abort initialization if no memory I/O resources detected

2015-07-14 Thread Sreekanth Reddy
redundancy Signed-off-by: Sreekanth Reddy --- drivers/scsi/mpt2sas/mpt2sas_base.c | 16 +--- drivers/scsi/mpt3sas/mpt3sas_base.c | 16 +--- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas

[PATCH v2 06/20] [SCSI] mpt3sas: Provides the physical location of sas drives

2015-06-30 Thread Sreekanth Reddy
y if CONFIG_SCSI_MPT3SAS_LOGGING flag is disabled. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn --- drivers/scsi/mpt3sas/mpt3sas_base.h | 2 + drivers/scsi/mpt3sas/mpt3sas_scsih.c | 240 +-- 2 files changed, 203 insert

[PATCH v2 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-06-30 Thread Sreekanth Reddy
Removed the redundancy code while freeing the controller resources. Changes in v2: Patch version change only. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn --- drivers/scsi/mpt3sas/mpt3sas_base.c | 57

  1   2   3   >