HI baratosz and Andy,
> -Original Message-
> From: Bartosz Golaszewski
> Sent: Tuesday, April 13, 2021 4:14 PM
> To: Andy Shevchenko
> Cc: Srinivas Neeli ; linus.wall...@linaro.org; Michal Simek
> ; Shubhrajyoti Datta ; Srinivas
> Goud ; linux-g...@vger.kernel.
Return value of "pm_runtime_get_sync" API was neither captured nor checked.
Fixed it by capturing the return value and then checking for any warning.
Addresses-Coverity: "check_return"
Signed-off-by: Srinivas Neeli
---
drivers/gpio/gpio-zynq.c | 5 -
1 file changed
module_platform_driver() makes the code simpler by eliminating
boilerplate code.
Signed-off-by: Srinivas Neeli
---
drivers/gpio/gpio-zynq.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
index
In two different instances the return value of "irq_get_irq_data"
API was neither captured nor checked.
Fixed it by capturing the return value and then checking for any error.
Addresses-Coverity: "returned_null"
Signed-off-by: Srinivas Neeli
---
drivers/gpio/gpio-zynq.c | 1
This patch series does the following:
-Simplified the code by using module_platform_driver().
-Fixing coverity warnings.
Srinivas Neeli (3):
gpio: zynq: use module_platform_driver to simplify the code
gpio: zynq: Check return value of pm_runtime_get_sync
gpio: zynq: Check return value of
Hi,
> -Original Message-
> From: Bartosz Golaszewski
> Sent: Friday, March 26, 2021 10:58 PM
> To: Michal Simek
> Cc: Syed Nayyar Waris ; Srinivas Neeli
> ; Andy Shevchenko
> ; William Breathitt Gray
> ; Arnd Bergmann ; Robert
> Richter ; Linus Walleij ;
clk is an optional property, if clock not defined,
calling clk_prepare_enable() and devm_add_action_or_reset()
are not useful.
so calling these two apis only when clock is present.
Addresses-Coverity:"FORWARD_NULL"
Signed-off-by: Srinivas Neeli
Reviewed-by: Guenter Roeck
---
driver
From: Srinivas Goud
Used BIT macro instead of mask value.
Signed-off-by: Srinivas Goud
Signed-off-by: Michal Simek
Signed-off-by: Srinivas Neeli
---
Changes in V2:
-Included bits.h header file.
---
drivers/watchdog/of_xilinx_wdt.c | 9 +
1 file changed, 5 insertions(+), 4 deletions
From: Srinivas Goud
This patch removes pr_info in stop function and adds dev_dbg()
in start/stop function to display device specific debug info.
Signed-off-by: Srinivas Goud
Signed-off-by: Michal Simek
Signed-off-by: Srinivas Neeli
---
Changes in V2:
-Updated minor review comments
"%p" is not printing the pointer value.
In driver, printing pointer value is not useful so avoiding print.
Signed-off-by: Srinivas Neeli
Reviewed-by: Guenter Roeck
---
drivers/watchdog/of_xilinx_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driver
: Michal Simek
Signed-off-by: Srinivas Neeli
Reviewed-by: Guenter Roeck
---
drivers/watchdog/of_xilinx_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
index 7fe4f7c3f7ce..00549164b3d7 100644
--- a
related patches.
---
Srinivas Goud (3):
watchdog: of_xilinx_wdt: Add comment to spinlock
watchdog: of_xilinx_wdt: Used BIT macro
watchdog: of_xilinx_wdt: Used dev_dbg()
Srinivas Neeli (2):
watchdog: of_xilinx_wdt: Remove passing null pointer
watchdog: of_xilinx_wdt: Skip printing pointer
Hi,
> -Original Message-
> From: Guenter Roeck On Behalf Of Guenter Roeck
> Sent: Tuesday, March 16, 2021 7:53 AM
> To: Srinivas Neeli ; Michal Simek ;
> Shubhrajyoti Datta ; Srinivas Goud
>
> Cc: w...@linux-watchdog.org; linux-watch...@vger.kernel.
Hi Guenter,
Thanks for review
> -Original Message-
> From: Guenter Roeck On Behalf Of Guenter Roeck
> Sent: Tuesday, March 16, 2021 8:01 AM
> To: Srinivas Neeli ; Michal Simek ;
> Shubhrajyoti Datta ; Srinivas Goud
>
> Cc: w...@linux-watchdog.org; linux-watch...@v
clk is an optional property, if clock not defined,
calling clk_prepare_enable() and devm_add_action_or_reset()
are not useful.
so calling these two apis only when clock is present.
Addresses-Coverity:"FORWARD_NULL"
Signed-off-by: Srinivas Neeli
---
drivers/watchdog/of_xilinx_
"%p" is not printing the pointer value.
In driver, printing pointer value is not useful so avoiding print.
Signed-off-by: Srinivas Neeli
---
drivers/watchdog/of_xilinx_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/of_xilinx_wdt.c
, Stop and Refresh trigger only
in open window.
Signed-off-by: Srinivas Neeli
---
drivers/watchdog/of_xilinx_wdt.c | 285 ++-
1 file changed, 283 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
index
Updated watchdog binding for Versal window watchdog.
Signed-off-by: Srinivas Neeli
---
.../devicetree/bindings/watchdog/of-xilinx-wdt.txt | 33 --
1 file changed, 30 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/of-xilinx-wdt.txt
b
printing pointer value
---
Note:
- Converting DT bindings to yaml pending, Will update on top of this series.
---
Srinivas Goud (3):
watchdog: of_xilinx_wdt: Add comment to spinlock
watchdog: of_xilinx_wdt: Used BIT macro
watchdog: of_xilinx_wdt: Used dev_dbg()
Srinivas Neeli (6):
watchdog
From: Srinivas Goud
This patch removes pr_info in stop function and adds dev_dbg()
in start/stop function to display device specific debug info.
Signed-off-by: Srinivas Goud
Signed-off-by: Michal Simek
Signed-off-by: Srinivas Neeli
---
drivers/watchdog/of_xilinx_wdt.c | 6 +-
1 file
From: Srinivas Goud
Used BIT macro instead of mask value.
Signed-off-by: Srinivas Goud
Signed-off-by: Michal Simek
Signed-off-by: Srinivas Neeli
---
drivers/watchdog/of_xilinx_wdt.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/watchdog/of_xilinx_wdt.c
There is a need to identify watchdog type that's why new enum was
was introduced to cover it. Move functionality valid only for this
watchdog type if statement.
Signed-off-by: Srinivas Goud
Signed-off-by: Michal Simek
Signed-off-by: Srinivas Neeli
---
drivers/watchdog/of_xilinx_wdt.c
: Michal Simek
Signed-off-by: Srinivas Neeli
---
drivers/watchdog/of_xilinx_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
index 7fe4f7c3f7ce..00549164b3d7 100644
--- a/drivers/watchdog/of_xilinx_wdt.c
This patch is preparation for adding new watchdog based on this driver.
of_id->data is storing link xwdt_devtype_data which stores watchdog
info and ops pointers to structures.
Signed-off-by: Srinivas Goud
Signed-off-by: Michal Simek
Signed-off-by: Srinivas Neeli
---
drivers/watch
Hi Linus,
> -Original Message-
> From: Linus Walleij
> Sent: Thursday, January 7, 2021 3:17 PM
> To: Srinivas Neeli
> Cc: Bartosz Golaszewski ; Michal Simek
> ; Shubhrajyoti Datta ; Srinivas
> Goud ; Robert Hancock ;
> William Breathitt Gray ; Syed Nayyar
Changed spinlock array to single. It is preparation for irq support which
is shared between two channels that's why spinlock should be only one.
Signed-off-by: Srinivas Neeli
---
Changes in V4:
-None.
Changes in V3:
-Created new patch for spinlock changes.
---
drivers/gpio/gpio-xilinx.c
Add support for suspend and resume, pm runtime suspend and resume.
Added free and request calls.
Signed-off-by: Srinivas Neeli
---
Changes in V4:
-Adjust code to remove conflicts.
Changes in V3:
-Created new patch for suspend and resume.
---
drivers/gpio/gpio-xilinx.c | 94
Add check to see if gpio-width property does not exceed 32.
If it exceeds then return -EINVAL.
Signed-off-by: Srinivas Neeli
---
Changes in V4:
-New patch.
---
drivers/gpio/gpio-xilinx.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio
function to translate
gpiospec to the GPIO number and flags.
Signed-off-by: Robert Hancock
Signed-off-by: Shubhrajyoti Datta
Signed-off-by: Srinivas Neeli
---
Changes in V4:
-Added more commit description.
Changes in V3:
-Created separate patch for Clock changes and runtime resume
and suspend
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Srinivas Neeli
---
Changes in V4:
-New patch
---
drivers/gpio/gpio-xilinx.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a
Back.(channel 1.0 connected to channel 2.0)
-Tested External switch(Used DIP switch)
-Tested Cascade scenario(Here gpio controller acting as
an interrupt controller).
---
Srinivas Neeli (5):
gpio: gpio-xilinx: Simplify with dev_err_probe()
gpio: gpio-xilinx: Reduce spinlock array to array
gpio
Hi Linus,
> -Original Message-
> From: Linus Walleij
> Sent: Wednesday, November 18, 2020 6:12 AM
> To: Srinivas Neeli
> Cc: Bartosz Golaszewski ; Michal Simek
> ; Shubhrajyoti Datta ; Srinivas
> Goud ; Robert Hancock ;
> open list:GPIO SUBSYS
Added entry for xilinx GPIO drivers.
Signed-off-by: Srinivas Neeli
Acked-by: Shubhrajyoti Datta
---
Changes in V3:
-None
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 87452fca5235..89a7c045a213 100644
--- a/MAINTAINERS
+++ b
Add support for suspend and resume, pm runtime suspend and resume.
Added free and request calls.
Signed-off-by: Srinivas Neeli
---
Changes in V3:
-Created new patch for suspend and resume.
---
drivers/gpio/gpio-xilinx.c | 89 --
1 file changed, 87
In two different instances the return value of "of_property_read_u32"
API was neither captured nor checked.
Fixed it by capturing the return value and then checking for any error.
Addresses-Coverity: "check_return"
Signed-off-by: Srinivas Neeli
---
Changes in V3:
-Crea
Adds clock support to the Xilinx GPIO driver.
Signed-off-by: Srinivas Neeli
---
Chnages in V3:
-Created separate patch for Clock changes.
---
drivers/gpio/gpio-xilinx.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
Added remove function support.
Signed-off-by: Srinivas Neeli
---
Changes in V3:
-Created new patch for remove function.
---
drivers/gpio/gpio-xilinx.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index
).
---
Srinivas Neeli (9):
gpio: gpio-xilinx: Arrange headers in sorting order
dt-bindings: gpio: gpio-xilinx: Add clk support to xilinx soft gpio IP
gpio: gpio-xilinx: Add clock support
gpio: gpio-xilinx: Reduce spinlock array to single
gpio: gpio-xilinx: Add interrupt support
gpio: gpio
Specify clock property in binding.
Signed-off-by: Srinivas Neeli
---
Changes in V3:
-Created new patch for dt-bindings.
---
Documentation/devicetree/bindings/gpio/gpio-xilinx.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-xilinx.txt
b
Changed spinlock array to single. It is preparation for irq support which
is shared between two channels that's why spinlock should be only one.
Signed-off-by: Srinivas Neeli
---
Changes in V3:
-Created new patch for spinlock changes.
---
drivers/gpio/gpio-xilinx.c
Arrange header files in sorted order.
Signed-off-by: Srinivas Neeli
---
Changes in V3:
-Created new patch for sorting header files.
---
drivers/gpio/gpio-xilinx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
: Shubhrajyoti Datta
Signed-off-by: Srinivas Neeli
---
Chnages in V3:
-Created separate patch for Clock changes and runtime resume
and suspend.
-Updated minor review comments.
Changes in V2:
-Added check for return value of platform_get_irq() API.
-Updated code to support rising edge and falling
Hi Andy Shevchenko,
Thanks for the review.
Accepted comments will address in V3 and Added few comments in inline.
> -Original Message-
> From: Andy Shevchenko
> Sent: Thursday, July 23, 2020 11:33 PM
> To: Srinivas Neeli
> Cc: Linus Walleij ; Bartosz Golaszewski
&
Hi Linus,
Thanks for the review
> -Original Message-
> From: Linus Walleij
> Sent: Friday, July 24, 2020 2:52 PM
> To: kernel test robot
> Cc: Srinivas Neeli ; Bartosz Golaszewski
> ; Michal Simek ;
> Shubhrajyoti Datta ; Srinivas Goud
> ; kbuild-...@list
Add support of clock adaptation for AXI GPIO driver.
Signed-off-by: Srinivas Neeli
---
Changes in V2:
Add check for return value of platform_get_irq() API.
---
drivers/gpio/gpio-xilinx.c | 111 -
1 file changed, 109 insertions(+), 2 deletions(-)
diff
Added entry for xilinx GPIO drivers.
Signed-off-by: Srinivas Neeli
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index ea296f213e45..71c40b0ddef6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18900,6 +18900,16 @@ S: Maintained
F
MAINTAINERS fragment.
---
Tested Below scenarios:
-Tested Loop Back.(channel 1.0 connected to channel 2.0)
-Tested External switch(Used DIP switch)
-Tested Cascade scenario(Here gpio controller acting as
an interrupt controller).
---
Srinivas Neeli (3):
gpio: xilinx: Add clock adaptation support
: Shubhrajyoti Datta
Signed-off-by: Srinivas Neeli
---
Changes in V2:
Updated code to support rising edge and falling edge.
Added xgpio_xlate() API to support gpio-keys.
Updated code to check return value of of_property_read_u32.
---
drivers/gpio/Kconfig | 1 +
drivers/gpio/gpio-xilinx.c
From: Shubhrajyoti Datta
Add PMC gpio support.
Only bank 0,1, 3 and 4 are connected to the multiplexed Input output
pins. Bank 0 and 1 to mio and bank 3 and 4 to extended multiplexed input
output pins.
Versal devices are the industry's first adaptive compute
acceleration platforms.
https://www.x
From: Shubhrajyoti Datta
If gpio is not set to wake disable the interrupt. ATF set all slaves with
enabled interrupts as wakeup sources and if gpio is used in r5 then it
wakes up linux.
Signed-off-by: Shubhrajyoti Datta
Signed-off-by: Michal Simek
---
drivers/gpio/gpio-zynq.c | 8
1
From: Glenn Langedock
Fix race condition when changing the direction (in/out) of the GPIO pin.
The read-modify-write sequence (as coded in the driver) isn't atomic and
requires synchronization (spinlock).
Signed-off-by: Glenn Langedock
Signed-off-by: Michal Simek
Signed-off-by: Srinivas
This patch series does the following:
-protect direction in/out with a spinlock
-Add binding for Versal gpio
-Add binding for pmc gpio node
-Add Versal support
-Disable the irq if it is not a wakeup source
-Add pmc gpio support
-Remove error prints in EPROBE_DEFER
---
Changes in V2:
- In previous
From: Shubhrajyoti Datta
Add Versal support in gpio.
Only bank 0 and 3 are connected to the Multiplexed Input output pins.
Bank 0 to mio and bank3 to fabric Multiplexed input output pins.
Versal devices are the industry's first adaptive compute
acceleration platforms.
https://www.xilinx.com/supp
From: Shubhrajyoti Datta
In case of probe is deferred do not print the errors.
Signed-off-by: Shubhrajyoti Datta
Signed-off-by: Michal Simek
---
drivers/gpio/gpio-zynq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
i
From: Shubhrajyoti Datta
Add binding for Versal binding.
Versal devices are the industry's first adaptive compute
acceleration platforms.
https://www.xilinx.com/support/documentation/data_sheets/ds950-versal-overview.pdf
On the Versal platform, we are using two customized GPIO controllers(IP)
w
From: Shubhrajyoti Datta
Add the pmc gpio node to the device tree.
Versal devices are the industry's first adaptive compute
acceleration platforms.
https://www.xilinx.com/support/documentation/data_sheets/ds950-versal-overview.pdf
On the Versal platform, we are using two customized GPIO control
n share-skb case “can_create_echo_skb(skb);” returning "new skb". For storing
new skb need a double pointer.
Providing an example for overcoming above issue.
Example:
can_put_echo_skb(struct sk_buff **skb,struct net_device *dev,unsigned int idx);
If you ok with this change, I will sen
57 matches
Mail list logo