Hi Richard,
On 06/03/15 15:22, Richard Cochran wrote:
I don't really know what the problem here is. Yes, there is some
networking configuration that you need to do when administering a
network using PTP protocols. But these protocols (1588 aka PTP, and
802.1AS aka gPTP) do offer means for
Hi Richard,
On 06/03/15 15:22, Richard Cochran wrote:
I don't really know what the problem here is. Yes, there is some
networking configuration that you need to do when administering a
network using PTP protocols. But these protocols (1588 aka PTP, and
802.1AS aka gPTP) do offer means for
Hi Richard,
On 27/02/15 18:14, Richard Cochran wrote:
>> The H/W does have the capability to do that. However, in order to
>> implement it there will be some architectural changes needed
>> in the kernel. This module cannot really pretend to be a PHY.
>> In the real world it sits between the
Hi Richard,
On 27/02/15 18:14, Richard Cochran wrote:
The H/W does have the capability to do that. However, in order to
implement it there will be some architectural changes needed
in the kernel. This module cannot really pretend to be a PHY.
In the real world it sits between the MAC and
Hi Richard,
On 25/02/15 17:30, Richard Cochran wrote:
I need some more time to study your other suggestions regarding the
PHY timestamping framework.
From my (limited) understanding of your HW device, I should think that
it will work. The PHY time stamping subsystem is not the most obvious
Hi Richard,
On 25/02/15 17:30, Richard Cochran wrote:
I need some more time to study your other suggestions regarding the
PHY timestamping framework.
From my (limited) understanding of your HW device, I should think that
it will work. The PHY time stamping subsystem is not the most obvious
Hi Richard,
On 25/02/15 17:01, Richard Cochran wrote:
On Wed, Feb 25, 2015 at 04:19:45PM +0100, Richard Cochran wrote:
Let me suggest another approach that stays in line with the existing
frame work. Based on the device's limitations and your own example,
it seems clear that the intended use
Hi Richard,
On 25/02/15 09:50, Richard Cochran wrote:
The Linux kernel already fully supports this kind of application via
the SIOCSHWTSTAMP, SO_TIMESTAMPING, and PHC mechanisms. We certainly
don't need another another interface just for someone's warped
hardware design.
I suggest that you
Hi Richard,
On 25/02/15 17:01, Richard Cochran wrote:
On Wed, Feb 25, 2015 at 04:19:45PM +0100, Richard Cochran wrote:
Let me suggest another approach that stays in line with the existing
frame work. Based on the device's limitations and your own example,
it seems clear that the intended use
Hi Richard,
On 25/02/15 09:50, Richard Cochran wrote:
The Linux kernel already fully supports this kind of application via
the SIOCSHWTSTAMP, SO_TIMESTAMPING, and PHC mechanisms. We certainly
don't need another another interface just for someone's warped
hardware design.
I suggest that you
Signed-off-by: Stathis Voukelatos
---
.../bindings/net/linn-ether-packet-sniffer.txt | 39 ++
.../devicetree/bindings/vendor-prefixes.txt| 1 +
2 files changed, 40 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net/linn-ether-packet
bytes plus an optional
timestamp, if configured by the command string.
Signed-off-by: Stathis Voukelatos
---
MAINTAINERS| 6 +
drivers/net/ethernet/Kconfig | 1 +
drivers/net/ethernet/Makefile | 1 +
drivers/net
Driver for the Ethernet Mii packet sniffer H/W module found in
the IMG Pistachio SoC.
Signed-off-by: Stathis Voukelatos
---
drivers/net/ethernet/linn/Kconfig | 11 +
drivers/net/ethernet/linn/Makefile | 1 +
.../linn/pkt-sniffer/backends/ether/Makefile
tree binding
* A number of minor code improvements suggested by code review
Stathis Voukelatos (3):
Linn Ethernet packet sniffer: device tree binding and vendor prefix
Linn packet sniffer core framework
Linn Ethernet packet sniffer driver
.../bindings/net/linn-ether-packet-sniffer.txt
On 23/02/15 21:38, David Miller wrote:
From: Stathis Voukelatos
Date: Mon, 23 Feb 2015 14:26:22 +
Driver for the Ethernet Mii packet sniffer H/W module found in
the IMG Pistachio SoC.
Signed-off-by: Stathis Voukelatos
You really have to explain what this thing does, how it is used
On 23/02/15 21:37, David Miller wrote:
From: Stathis Voukelatos
Date: Mon, 23 Feb 2015 14:26:21 +
+ spin_lock_irqsave(>lock, flags);
+ /* Stop the hardware */
+ sch->stop(sch);
+ /* Set the new command pattern */
+ ret = sch->set_pattern(sch, skb-&
On 23/02/15 21:37, David Miller wrote:
From: Stathis Voukelatos stathis.voukela...@linn.co.uk
Date: Mon, 23 Feb 2015 14:26:21 +
+ spin_lock_irqsave(priv-lock, flags);
+ /* Stop the hardware */
+ sch-stop(sch);
+ /* Set the new command pattern */
+ ret = sch
On 23/02/15 21:38, David Miller wrote:
From: Stathis Voukelatos stathis.voukela...@linn.co.uk
Date: Mon, 23 Feb 2015 14:26:22 +
Driver for the Ethernet Mii packet sniffer H/W module found in
the IMG Pistachio SoC.
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
You
tree binding
* A number of minor code improvements suggested by code review
Stathis Voukelatos (3):
Linn Ethernet packet sniffer: device tree binding and vendor prefix
Linn packet sniffer core framework
Linn Ethernet packet sniffer driver
.../bindings/net/linn-ether-packet-sniffer.txt
Driver for the Ethernet Mii packet sniffer H/W module found in
the IMG Pistachio SoC.
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
drivers/net/ethernet/linn/Kconfig | 11 +
drivers/net/ethernet/linn/Makefile | 1 +
.../linn/pkt-sniffer
bytes plus an optional
timestamp, if configured by the command string.
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
MAINTAINERS| 6 +
drivers/net/ethernet/Kconfig | 1 +
drivers/net/ethernet/Makefile
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
.../bindings/net/linn-ether-packet-sniffer.txt | 39 ++
.../devicetree/bindings/vendor-prefixes.txt| 1 +
2 files changed, 40 insertions(+)
create mode 100644
Documentation/devicetree/bindings
bytes plus an optional
timestamp, if configured by the command string.
Signed-off-by: Stathis Voukelatos
---
MAINTAINERS| 6 +
drivers/net/ethernet/Kconfig | 1 +
drivers/net/ethernet/Makefile | 1 +
drivers/net
Driver for the Ethernet Mii packet sniffer H/W module found in
the IMG Pistachio SoC.
Signed-off-by: Stathis Voukelatos
---
drivers/net/ethernet/linn/Kconfig | 11 +
drivers/net/ethernet/linn/Makefile | 1 +
.../linn/pkt-sniffer/backends/ether/Makefile
redesign of core framework to use netdev instead of
the generic netlink framework
* Updated device tree binding
* A number of minor code improvements suggested by code review
Stathis Voukelatos (3):
Ethernet packet sniffer: device tree binding and vendor prefix
Packet sniffer core framework
Signed-off-by: Stathis Voukelatos
---
.../bindings/net/linn-ether-packet-sniffer.txt | 39 ++
.../devicetree/bindings/vendor-prefixes.txt| 1 +
2 files changed, 40 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net/linn-ether-packet
Hi Richard,
On 18/02/15 21:08, Richard Cochran wrote:
On Tue, Feb 17, 2015 at 02:03:30PM +, Stathis Voukelatos wrote:
The command string for packet matching is stored in module RAM
and consists of a sequence of 16-bit entries. Each entry includes
an 8-bit command code and and 8-bit data
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
.../bindings/net/linn-ether-packet-sniffer.txt | 39 ++
.../devicetree/bindings/vendor-prefixes.txt| 1 +
2 files changed, 40 insertions(+)
create mode 100644
Documentation/devicetree/bindings
Driver for the Ethernet Mii packet sniffer H/W module found in
the IMG Pistachio SoC.
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
drivers/net/ethernet/linn/Kconfig | 11 +
drivers/net/ethernet/linn/Makefile | 1 +
.../linn/pkt-sniffer
redesign of core framework to use netdev instead of
the generic netlink framework
* Updated device tree binding
* A number of minor code improvements suggested by code review
Stathis Voukelatos (3):
Ethernet packet sniffer: device tree binding and vendor prefix
Packet sniffer core framework
bytes plus an optional
timestamp, if configured by the command string.
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
MAINTAINERS| 6 +
drivers/net/ethernet/Kconfig | 1 +
drivers/net/ethernet/Makefile
Hi Richard,
On 18/02/15 21:08, Richard Cochran wrote:
On Tue, Feb 17, 2015 at 02:03:30PM +, Stathis Voukelatos wrote:
The command string for packet matching is stored in module RAM
and consists of a sequence of 16-bit entries. Each entry includes
an 8-bit command code and and 8-bit data
Hi Daniel,
On 18/02/15 15:42, Daniel Borkmann wrote:
This whole framework really looks like only tailored to your specific
driver, I have no idea who else should reuse that?! So, I don't think
putting this under drivers/net/pkt-sniffer/ is a good idea.
Yes, it is not necessarilly expected
Hi Mark,
On 18/02/15 12:11, Mark Rutland wrote:
Counters can often have a divider applied to their input clock and
therefore run at a scaled down frequency. This is not the case in the
first SoC where the sniffer is used, so for simplicity I can modify as
you suggest and remove that field
It is a useful utility function, that would allow cyclecounter
users built as loadable modules to dynamically calculate the mult
and shift values
Signed-off-by: Stathis Voukelatos
---
kernel/time/clocksource.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/time/clocksource.c b
On 17/02/15 17:30, Mark Rutland wrote:
It is the frequency of the timestamp values supplied to the sniffer
module. It is used by the driver to convert to nanoseconds.
I was trying to be somewhat generic here and not assume that it
is necessarily the same as the 'tstamp' clock below, in which
On 17/02/15 17:30, Mark Rutland wrote:
It is the frequency of the timestamp values supplied to the sniffer
module. It is used by the driver to convert to nanoseconds.
I was trying to be somewhat generic here and not assume that it
is necessarily the same as the 'tstamp' clock below, in which
It is a useful utility function, that would allow cyclecounter
users built as loadable modules to dynamically calculate the mult
and shift values
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
kernel/time/clocksource.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Hi Mark,
On 18/02/15 12:11, Mark Rutland wrote:
Counters can often have a divider applied to their input clock and
therefore run at a scaled down frequency. This is not the case in the
first SoC where the sniffer is used, so for simplicity I can modify as
you suggest and remove that field
Hi Daniel,
On 18/02/15 15:42, Daniel Borkmann wrote:
This whole framework really looks like only tailored to your specific
driver, I have no idea who else should reuse that?! So, I don't think
putting this under drivers/net/pkt-sniffer/ is a good idea.
Yes, it is not necessarilly expected
Hi Mark,
On 17/02/15 16:35, Mark Rutland wrote:
+- tstamp-hz : frequency of the timestamp counter
Is this the frequency the clock is running at, or a frequency that it
should be programmed to in order to be used?
The former can be queried from the common clock framework, and if you
Hi Mark,
On 17/02/15 14:51, Mark Rutland wrote:
+Matched packet bytes and timestamp values are returned through a
+FIFO. Timestamps are provided to the module through an externally
+generated Gray-encoded counter.
Does this counter unit need to be enabled (or have any input clocks
enabled)?
bytes plus an optional
timestamp, if configured by the command string.
Signed-off-by: Stathis Voukelatos
---
MAINTAINERS | 6 +
drivers/net/Kconfig | 2 +
drivers/net/Makefile| 2 +
drivers/net/pkt-sniffer/Kconfig
Driver for the Ethernet Mii packet sniffer H/W module found in
the IMG Pistachio SoC.
Signed-off-by: Stathis Voukelatos
---
drivers/net/pkt-sniffer/Kconfig | 11 +
drivers/net/pkt-sniffer/Makefile | 4 +
drivers/net/pkt-sniffer/backends/ether/channel.c
Signed-off-by: Stathis Voukelatos
---
.../bindings/net/linn-ether-packet-sniffer.txt | 42 ++
.../devicetree/bindings/vendor-prefixes.txt| 1 +
2 files changed, 43 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net/linn-ether-packet
by code review
Stathis Voukelatos (3):
Ethernet packet sniffer: Device tree binding and vendor prefix
Packet sniffer core framework
Linn Ethernet packet sniffer driver
.../bindings/net/linn-ether-packet-sniffer.txt | 42 +++
.../devicetree/bindings/vendor-prefixes.txt| 1
Hi Mark,
On 17/02/15 14:51, Mark Rutland wrote:
+Matched packet bytes and timestamp values are returned through a
+FIFO. Timestamps are provided to the module through an externally
+generated Gray-encoded counter.
Does this counter unit need to be enabled (or have any input clocks
enabled)?
Hi Mark,
On 17/02/15 16:35, Mark Rutland wrote:
+- tstamp-hz : frequency of the timestamp counter
Is this the frequency the clock is running at, or a frequency that it
should be programmed to in order to be used?
The former can be queried from the common clock framework, and if you
Driver for the Ethernet Mii packet sniffer H/W module found in
the IMG Pistachio SoC.
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
drivers/net/pkt-sniffer/Kconfig | 11 +
drivers/net/pkt-sniffer/Makefile | 4 +
drivers/net/pkt-sniffer
bytes plus an optional
timestamp, if configured by the command string.
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
MAINTAINERS | 6 +
drivers/net/Kconfig | 2 +
drivers/net/Makefile| 2 +
drivers/net/pkt
by code review
Stathis Voukelatos (3):
Ethernet packet sniffer: Device tree binding and vendor prefix
Packet sniffer core framework
Linn Ethernet packet sniffer driver
.../bindings/net/linn-ether-packet-sniffer.txt | 42 +++
.../devicetree/bindings/vendor-prefixes.txt| 1
Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
.../bindings/net/linn-ether-packet-sniffer.txt | 42 ++
.../devicetree/bindings/vendor-prefixes.txt| 1 +
2 files changed, 43 insertions(+)
create mode 100644
Documentation/devicetree/bindings
Hi Daniel,
On 27/01/15 14:46, Daniel Borkmann wrote:
Just wanted to clarify some implementation details for your approach.
- The driver would need to create and register two net_device instances.
One for sniffing Ethernet TX packets and one for RX.
Hm, I would represent the whole device as a
Hi Daniel,
On 26/01/15 10:10, Daniel Borkmann wrote:
Hello Daniel. Thank you for your feedback.
Packet sockets could also be used for the driver interface to
user space, however I think that both approaches would require the same
amount of maintenance. We need to maintain a protocol consisting
Hi Florian,
On 26/01/15 22:30, Florian Fainelli wrote:
On 23/01/15 02:07, Stathis Voukelatos wrote:
This patch adds support the Ethernet Packet Sniffer H/W module
developed by Linn Products Ltd and found in the IMG Pistachio SoC.
The module allows Ethernet packets to be parsed, matched against
On 26/01/15 19:39, Joe Perches wrote:
This header file is the public API for the driver.
Should it not live under the 'include' directory?
Several other drivers seem to follow that convention.
It depends on how public is public.
If it's _really_ public, it should be in uapi.
If it's kinda
On 26/01/15 19:39, Joe Perches wrote:
This header file is the public API for the driver.
Should it not live under the 'include' directory?
Several other drivers seem to follow that convention.
It depends on how public is public.
If it's _really_ public, it should be in uapi.
If it's kinda
Hi Daniel,
On 26/01/15 10:10, Daniel Borkmann wrote:
Hello Daniel. Thank you for your feedback.
Packet sockets could also be used for the driver interface to
user space, however I think that both approaches would require the same
amount of maintenance. We need to maintain a protocol consisting
Hi Florian,
On 26/01/15 22:30, Florian Fainelli wrote:
On 23/01/15 02:07, Stathis Voukelatos wrote:
This patch adds support the Ethernet Packet Sniffer H/W module
developed by Linn Products Ltd and found in the IMG Pistachio SoC.
The module allows Ethernet packets to be parsed, matched against
Hi Daniel,
On 27/01/15 14:46, Daniel Borkmann wrote:
Just wanted to clarify some implementation details for your approach.
- The driver would need to create and register two net_device instances.
One for sniffing Ethernet TX packets and one for RX.
Hm, I would represent the whole device as a
On 23/01/15 10:21, Arnd Bergmann wrote:
On Friday 23 January 2015 10:07:01 Stathis Voukelatos wrote:
+- interrupts : sniffer interrupt specifier
+- clocks : specify the system clock for the peripheral
+- clock-names : must contain the "sys" entry
+- fifo-block-words : number of wo
On 24/01/15 21:37, Joe Perches wrote:
On Fri, 2015-01-23 at 10:07 +, Stathis Voukelatos wrote:
This patch adds support the Ethernet Packet Sniffer H/W module
developed by Linn Products Ltd and found in the IMG Pistachio SoC.
The module allows Ethernet packets to be parsed, matched against
On 23/01/15 18:12, James Hogan wrote:
diff --git a/drivers/net/pkt-sniffer/Kconfig
b/drivers/net/pkt-sniffer/Kconfig
new file mode 100644
index 000..26b4f98
--- /dev/null
+++ b/drivers/net/pkt-sniffer/Kconfig
@@ -0,0 +1,23 @@
+menuconfig PKT_SNIFFER
+tristate "Linn packet sniffer
On 23/01/15 10:51, Mark Rutland wrote:
diff --git
a/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt
b/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt
new file mode 100644
index 000..6b6e105
--- /dev/null
+++
On 23/01/15 11:20, Daniel Borkmann wrote:
On 01/23/2015 11:07 AM, Stathis Voukelatos wrote:
This patch adds support the Ethernet Packet Sniffer H/W module
developed by Linn Products Ltd and found in the IMG Pistachio SoC.
The module allows Ethernet packets to be parsed, matched against
a user
On 23/01/15 11:20, Daniel Borkmann wrote:
On 01/23/2015 11:07 AM, Stathis Voukelatos wrote:
This patch adds support the Ethernet Packet Sniffer H/W module
developed by Linn Products Ltd and found in the IMG Pistachio SoC.
The module allows Ethernet packets to be parsed, matched against
a user
On 23/01/15 10:51, Mark Rutland wrote:
diff --git
a/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt
b/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt
new file mode 100644
index 000..6b6e105
--- /dev/null
+++
On 23/01/15 18:12, James Hogan wrote:
diff --git a/drivers/net/pkt-sniffer/Kconfig
b/drivers/net/pkt-sniffer/Kconfig
new file mode 100644
index 000..26b4f98
--- /dev/null
+++ b/drivers/net/pkt-sniffer/Kconfig
@@ -0,0 +1,23 @@
+menuconfig PKT_SNIFFER
+tristate Linn packet sniffer
On 24/01/15 21:37, Joe Perches wrote:
On Fri, 2015-01-23 at 10:07 +, Stathis Voukelatos wrote:
This patch adds support the Ethernet Packet Sniffer H/W module
developed by Linn Products Ltd and found in the IMG Pistachio SoC.
The module allows Ethernet packets to be parsed, matched against
On 23/01/15 10:21, Arnd Bergmann wrote:
On Friday 23 January 2015 10:07:01 Stathis Voukelatos wrote:
+- interrupts : sniffer interrupt specifier
+- clocks : specify the system clock for the peripheral
+- clock-names : must contain the sys entry
+- fifo-block-words : number of words in one data
-by: Stathis Voukelatos
---
.../bindings/net/linn-ether-packet-sniffer.txt | 27 ++
.../devicetree/bindings/vendor-prefixes.txt| 1 +
MAINTAINERS| 7 +
drivers/net/Kconfig| 2 +
drivers/net/Makefile
-by: Stathis Voukelatos stathis.voukela...@linn.co.uk
---
.../bindings/net/linn-ether-packet-sniffer.txt | 27 ++
.../devicetree/bindings/vendor-prefixes.txt| 1 +
MAINTAINERS| 7 +
drivers/net/Kconfig| 2
72 matches
Mail list logo
