Re: [PATCH v2 1/5] media: mt9p031: Add support for 8 bit and 10 bit formats

2020-10-01 Thread Stefan Riedmüller
Hi Laurent, On 30.09.20 13:42, Laurent Pinchart wrote: Hi Stefan, Thank you for the patch. On Wed, Sep 30, 2020 at 12:51:29PM +0200, Stefan Riedmueller wrote: From: Christian Hemp Aside from 12 bit monochrome or color format the sensor implicitly supports 10 and 8 bit formats as well

Re: [PATCH v2 3/5] media: mt9p031: Implement [gs]_register debug calls

2020-10-01 Thread Stefan Riedmüller
Hi Laurent, On 30.09.20 13:38, Laurent Pinchart wrote: Hi Stefan, Thank you for the patch. On Wed, Sep 30, 2020 at 12:51:31PM +0200, Stefan Riedmueller wrote: From: Enrico Scholz Implement g_register and s_register v4l2_subdev_core_ops to access camera register directly from userspace

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-09-30 Thread Stefan Wahren
;>>> Reviewed-by: Dave Stevenson >>>> Tested-by: Chanwoo Choi >>>> Tested-by: Hoegeun Kwon >>>> Tested-by: Stefan Wahren >>>> Signed-off-by: Maxime Ripard >>> Apologies if this has already been reported or have a

[PATCH] Revert "drm/i915: Force state->modeset=true when distrust_bios_wm==true"

2020-09-30 Thread Stefan Joosten
mit 0f8839f5f323da04a800e6ced1136e4b1e1689a9. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1879442 Signed-off-by: Stefan Joosten --- drivers/gpu/drm/i915/display/intel_display.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c

Re: [PATCH] xen/events: don't use chip_data for legacy IRQs

2020-09-30 Thread Stefan Bader
30fb1ddc0a ("XEN uses irqdesc::irq_data_common::handler_data to > store a per interrupt XEN data pointer which contains XEN specific > information.") > Signed-off-by: Juergen Gross Tested-by: Stefan Bader > --- > drivers/xen/events/events_base.c | 29 +-

[PATCH v2 5/5] media: mt9p031: Fix corrupted frame after restarting stream

2020-09-30 Thread Stefan Riedmueller
start Bit The Restart Bit is cleared automatically and must not be cleared manually as this would cause undefined behavior. Signed-off-by: Dirk Bender Signed-off-by: Stefan Riedmueller --- No changes in v2 --- drivers/media/i2c/mt9p031.c | 25 + 1 file changed, 25 i

[PATCH v2 3/5] media: mt9p031: Implement [gs]_register debug calls

2020-09-30 Thread Stefan Riedmueller
From: Enrico Scholz Implement g_register and s_register v4l2_subdev_core_ops to access camera register directly from userspace for debug purposes. Signed-off-by: Enrico Scholz Signed-off-by: Stefan Riedmueller --- No changes in v2 --- drivers/media/i2c/mt9p031.c | 28

[PATCH v2 4/5] media: mt9p031: Make pixel clock polarity configurable by DT

2020-09-30 Thread Stefan Riedmueller
From: Christian Hemp Evaluate the desired pixel clock polarity from the device tree. Signed-off-by: Christian Hemp Signed-off-by: Stefan Riedmueller --- Changes in v2: - Initialise endpoint bus_type field to V4L2_MBUS_PARALLEL since the sensor only supports a parallel interface

[PATCH v2 2/5] media: mt9p031: Read back the real clock rate

2020-09-30 Thread Stefan Riedmueller
From: Enrico Scholz The real and requested clock can differ and because it is used to calculate PLL values, the real clock rate should be read. Signed-off-by: Enrico Scholz Signed-off-by: Stefan Riedmueller --- No changes in v2 --- drivers/media/i2c/mt9p031.c | 9 ++--- 1 file changed, 6

[PATCH v2 1/5] media: mt9p031: Add support for 8 bit and 10 bit formats

2020-09-30 Thread Stefan Riedmueller
Luebbe Signed-off-by: Stefan Riedmueller --- Changes in v2: - Use unsigned int for num_fmts and loop variable in find_datafmt - Remove superfluous const qualifier from find_datafmt --- drivers/media/i2c/mt9p031.c | 50 + 1 file changed, 40 insertions(+), 10

Re: [PATCH 1/5] media: mt9p031: Add support for 8 bit and 10 bit formats

2020-09-30 Thread Stefan Riedmüller
Hi Sakari, On 25.09.20 22:11, Sakari Ailus wrote: Hi Stefan, On Fri, Sep 25, 2020 at 09:50:25AM +0200, Stefan Riedmueller wrote: From: Christian Hemp Aside from 12 bit monochrome or color format the sensor implicitly supports 10 and 8 bit formats as well by simply dropping the corresponding

Re: [PATCH 4.4 50/62] XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information.

2020-09-30 Thread Stefan Bader
On 29.09.20 16:05, Jürgen Groß wrote: > On 29.09.20 15:13, Stefan Bader wrote: >> On 01.09.20 17:10, Greg Kroah-Hartman wrote: >>> From: Thomas Gleixner >>> >>> commit c330fb1ddc0a922f044989492b7fcca77ee1db46 upstream. >>> >>> handler data i

Re: [PATCH 4/5] media: mt9p031: Make pixel clock polarity configurable by DT

2020-09-30 Thread Stefan Riedmüller
Hi Sakari, thanks for your review. On 25.09.20 22:07, Sakari Ailus wrote: Hi Stefan, Thanks for the patchset. On Fri, Sep 25, 2020 at 09:50:28AM +0200, Stefan Riedmueller wrote: From: Christian Hemp Evaluate the desired pixel clock polarity from the device tree. Signed-off-by: Christian

Re: [PATCH 4.4 50/62] XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information.

2020-09-29 Thread Stefan Bader
On 29.09.20 16:05, Jürgen Groß wrote: > On 29.09.20 15:13, Stefan Bader wrote: >> On 01.09.20 17:10, Greg Kroah-Hartman wrote: >>> From: Thomas Gleixner >>> >>> commit c330fb1ddc0a922f044989492b7fcca77ee1db46 upstream. >>> >>> handler data i

Re: [PATCH 4.4 50/62] XEN uses irqdesc::irq_data_common::handler_data to store a per interrupt XEN data pointer which contains XEN specific information.

2020-09-29 Thread Stefan Bader
zing ACPI SCI. mp_irqdomain_activate is accessing chip_data expecting ioapic data there. Oddly enough more recent kernels seem to do the same but not crashing as HVM guest (neither seen for our 4.15 nor the 5.4). Maybe someone could make sure the 4.4.y stable series is not also broken. -Stefan > &g

[PATCH 4/5] media: mt9p031: Make pixel clock polarity configurable by DT

2020-09-25 Thread Stefan Riedmueller
From: Christian Hemp Evaluate the desired pixel clock polarity from the device tree. Signed-off-by: Christian Hemp Signed-off-by: Stefan Riedmueller --- drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/mt9p031.c | 19 ++- include/media/i2c/mt9p031.h | 1 + 3 files

[PATCH 3/5] media: mt9p031: Implement [gs]_register debug calls

2020-09-25 Thread Stefan Riedmueller
From: Enrico Scholz Implement g_register and s_register v4l2_subdev_core_ops to access camera register directly from userspace for debug purposes. Signed-off-by: Enrico Scholz Signed-off-by: Stefan Riedmueller --- drivers/media/i2c/mt9p031.c | 28 1 file changed

[PATCH 5/5] media: mt9p031: Fix corrupted frame after restarting stream

2020-09-25 Thread Stefan Riedmueller
start Bit The Restart Bit is cleared automatically and must not be cleared manually as this would cause undefined behavior. Signed-off-by: Dirk Bender Signed-off-by: Stefan Riedmueller --- drivers/media/i2c/mt9p031.c | 25 + 1 file changed, 25 insertions(+) diff --git

[PATCH 2/5] media: mt9p031: Read back the real clock rate

2020-09-25 Thread Stefan Riedmueller
From: Enrico Scholz The real and requested clock can differ and because it is used to calculate PLL values, the real clock rate should be read. Signed-off-by: Enrico Scholz Signed-off-by: Stefan Riedmueller --- drivers/media/i2c/mt9p031.c | 9 ++--- 1 file changed, 6 insertions(+), 3

[PATCH 1/5] media: mt9p031: Add support for 8 bit and 10 bit formats

2020-09-25 Thread Stefan Riedmueller
Luebbe Signed-off-by: Stefan Riedmueller --- drivers/media/i2c/mt9p031.c | 50 + 1 file changed, 40 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index dc23b9ed510a..0002dd299ffa 100644 --- a/drivers/media/i2c

Re: [RFC PATCH 00/24] Control VQ support in vDPA

2020-09-24 Thread Stefan Hajnoczi
author didn't know that a certain virtqueue grouping is advantageous. BTW I like how general this feature is. It seems to allow vDPA devices to be split into sub-devices for further passthrough. Who will write the first vDPA-on-vDPA driver? :) Stefan signature.asc Description: PGP signature

Re: [EXT] Re: [PATCH] net: fec: Keep device numbering consistent with datasheet

2020-09-24 Thread Stefan Riedmüller
Hi Andy, David and Andrew, first of all, thanks for your review. I really appreciate it! On 24.09.20 08:36, Andy Duan wrote: From: David Miller Sent: Thursday, September 24, 2020 4:32 AM From: Stefan Riedmueller Date: Wed, 23 Sep 2020 16:25:28 +0200 From: Christian Hemp Make use

[PATCH] net: fec: Keep device numbering consistent with datasheet

2020-09-23 Thread Stefan Riedmueller
From: Christian Hemp Make use of device tree alias for device enumeration to keep the device order consistent with the naming in the datasheet. Otherwise for the i.MX 6UL/ULL the ENET1 interface is enumerated as eth1 and ENET2 as eth0. Signed-off-by: Christian Hemp Signed-off-by: Stefan

Re: [PATCH 08/14] dasd: cleanup dasd_scan_partitions

2020-09-22 Thread Stefan Haberland
Am 21.09.20 um 09:19 schrieb Christoph Hellwig: > Use blkdev_get_by_dev instead of bdget_disk + blkdev_get. > > Signed-off-by: Christoph Hellwig Beside what Sergei mentioned... Reviewed-by: Stefan Haberland > --- > drivers/s390/block/dasd_genhd.c | 15 --- >

[PATCH] Input: stmpe: Add axis inversion and swapping capability

2020-09-22 Thread Stefan Riedmueller
Make use of generic touchscreen_properties structure to add axis inversion and swapping capabilities. It's configurable via devicetree properties: touchscreen-inverted-x touchscreen-inverted-y touchscreen-swapped-x-y Signed-off-by: Stefan Riedmueller --- drivers/input/touchscreen/stmpe

Re: [PATCH] dasd: remove the unused dasd_enable_device export

2020-09-16 Thread Stefan Haberland
Am 03.09.20 um 10:30 schrieb Christoph Hellwig: > Signed-off-by: Christoph Hellwig Acked-by:Stefan Haberland > --- > drivers/s390/block/dasd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c > index eb17fea8075c6f..6ab992b3eed004

boot interrupt quirk (also in 4.19.y) breaks serial ports (was: [PATCH v2 0/2] pci: Add boot interrupt quirk mechanism for Xeon chipsets)

2020-09-16 Thread Stefan Bühler
else I can do to help getting this fixed properly? (We have the same card in other boxes with CPUs not affected by this quirk; they are working just fine.) cheers, Stefan -- Stefan BühlerMail/xmpp: stefan.bueh...@tik.uni-stuttgart.de Netze und Kommunikationssysteme der Universität Stutt

Re: [PATCH v3] drm: mxsfb: check framebuffer pitch

2020-09-16 Thread Stefan Agner
On 2020-09-08 16:16, Stefan Agner wrote: > The lcdif IP does not support a framebuffer pitch (stride) other than > framebuffer width. Check for equality and reject the framebuffer > otherwise. > > This prevents a distorted picture when using 640x800 and running the > Mesa gr

[BUG] NULL ptr deref in css_free_rwork_fn

2020-09-16 Thread Stefan Wahren
Hi, i noticed a regular crash (NULL pointer dereference) on my ARM i.MX28 board using the current mainline kernel (last tested version Linux 5.9-rc5). I also tested Linux 5.8, but i wasn't able to reproduce with this version, so i assume this is a regression. The crash happens mostly short after

Re: [PATCH 12/24] getgrent_r.3: Use sizeof() to get buffer size (instead of hardcoding macro name)

2020-09-15 Thread Stefan Puiu
Hi, On Fri, Sep 11, 2020 at 6:28 PM Alejandro Colomar wrote: > > Hi Stefan, > > On 2020-09-11 16:35, Stefan Puiu wrote: > > Hi, > > > > On Fri, Sep 11, 2020 at 12:15 AM Alejandro Colomar > > wrote: > >> > >> Signed-off-by: Alej

greetings

2020-09-11 Thread Ms Julianna Stefan Ndoi
-- My name is Mrs.Julianna Stefan Ndoi. I am a cancer patient who had decided to donate what I have to you for God's works. I want to donate $8.5 million to you so that you will use part of the this fund to help the poor ones,while you use the rest for your family.If you are interested,Respond

Re: [PATCH 12/24] getgrent_r.3: Use sizeof() to get buffer size (instead of hardcoding macro name)

2020-09-11 Thread Stefan Puiu
ste parts of this in their code, where maybe buf is just a pointer, and expect it to work. Maybe leaving BUFLEN here is useful as a reminder that they need to change something to adapt the code? Just my 2 cents, Stefan.

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Stefan Agner
On 2020-09-08 10:48, Daniel Vetter wrote: > On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Valkeinen wrote: >> Hi, >> >> On 08/09/2020 10:55, Stefan Agner wrote: >> > On 2020-09-07 20:18, Daniel Vetter wrote: >> >> On Mon, Sep 07, 2020 at 07:17:12PM +0300

[PATCH v3] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Stefan Agner
at that particular resolution to width != stride. Currently Mesa has no fallback behavior, but rejecting this configuration allows userspace to handle the issue correctly. Fixes: 45d59d704080 ("drm: Add new driver for MXSFB controller") Signed-off-by: Stefan Agner Reviewed-by: Lauren

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Stefan Agner
On 2020-09-08 14:33, Laurent Pinchart wrote: > On Tue, Sep 08, 2020 at 02:29:02PM +0200, Daniel Vetter wrote: >> On Tue, Sep 8, 2020 at 2:07 PM Stefan Agner wrote: >> > On 2020-09-08 10:48, Daniel Vetter wrote: >> >> On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Va

[PATCH v2] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Stefan Agner
at that particular resolution to width != stride. Currently Mesa has no fallback behavior, but rejecting this configuration allows userspace to handle the issue correctly. Signed-off-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 21 - 1 file changed, 20 insertions(+), 1

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Stefan Agner
On 2020-09-07 20:18, Daniel Vetter wrote: > On Mon, Sep 07, 2020 at 07:17:12PM +0300, Laurent Pinchart wrote: >> Hi Stefan, >> >> Thank you for the patch. >> >> On Mon, Sep 07, 2020 at 06:03:43PM +0200, Stefan Agner wrote: >> > The lcdif IP does not suppo

[PATCH] drm: mxsfb: check framebuffer pitch

2020-09-07 Thread Stefan Agner
at that particular resolution to width != stride. Currently Mesa has no fallback behavior, but rejecting this configuration allows userspace to handle the issue correctly. Signed-off-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions

Re: [PATCH v2 1/1] ARM: dts: bcm2711: Enable ddr modes on emmc2 controller

2020-09-02 Thread Stefan Wahren
Hi Tobias, Am 31.08.20 um 23:59 schrieb Tobias Schramm: > This commit enables ddr modes for eMMC storage on emmc2. > The bcm2711 supports eMMC storage using ddr modes. The board > layout of the Raspberry Pi 4 supports them, too. i want to inform you that Ulf Hansson already applied my driver

Re: [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output

2020-09-01 Thread Stefan Wahren
Hi Maxime, Am 01.09.20 um 11:58 schrieb Maxime Ripard: > Hi Stefan > > On Tue, Aug 25, 2020 at 11:30:58PM +0200, Stefan Wahren wrote: >> Am 25.08.20 um 17:06 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Wed, Jul 29, 2020 at 05:50:31PM +0200, Stef

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-28 Thread Stefan Wahren
Hi Maxime, Am 28.08.20 um 17:25 schrieb Maxime Ripard: > Hi, > > On Fri, Aug 28, 2020 at 02:45:49PM +0200, Stefan Wahren wrote: >> Am 28.08.20 um 08:30 schrieb Hoegeun Kwon: >>> On 8/27/20 6:49 PM, Stefan Wahren wrote: >>>> Am 27.08.20 um 06:35 s

[PATCH v2] clk: meson: g12a: mark fclk_div2 as critical

2020-08-28 Thread Stefan Agner
disabled which leads to a system freeze. Let's mark this clock as critical, fixing boot from SD card on G12b platforms. Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller") Cc: Marek Szyprowski Signed-off-by: Stefan Agner Tested-by: Anand Moon --- drivers/clk/me

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-28 Thread Stefan Wahren
Hi, Am 28.08.20 um 08:30 schrieb Hoegeun Kwon: > On 8/27/20 6:49 PM, Stefan Wahren wrote: >> Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: >>> Hi Stefan, >>> >>> Thank you for your review. >>> >>> >>> On 8/26/20 7:04 PM, Stefan Wahren

Re: [PATCH 1/2] EDAC/aspeed: Fix handling of platform_get_irq() error

2020-08-27 Thread Stefan Schaeckeler
> platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: 9b7e6242ee4e ("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver") > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Stefan Schaeckeler > --- >

[PATCH] clk: meson: g12a: mark fclk_div2 as critical

2020-08-27 Thread Stefan Agner
disabled which leads to a system freeze. Let's mark this clock as critical, fixing boot from SD card on G12b platforms. Signed-off-by: Stefan Agner --- drivers/clk/meson/g12a.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c index

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-27 Thread Stefan Wahren
Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: > Hi Stefan, > > Thank you for your review. > > > On 8/26/20 7:04 PM, Stefan Wahren wrote: >> Hi Hoeguen, >> >> Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: >>> There is a problem that the output does not wor

Re: [PATCH v3 11/18] fuse: implement FUSE_INIT map_alignment field

2020-08-26 Thread Stefan Hajnoczi
gt; > work even when emulating x86 on Power and similar combinations where the > > > host page sizes are different. > > > > > > Signed-off-by: Stefan Hajnoczi > > > Signed-off-by: Vivek Goyal > > > --- > > > fs/fuse/fuse_i.h

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-26 Thread Stefan Wahren
hdmi.yaml first. Is this clock physically available on BCM283x or only on BCM2711? I'm a little bit afraid, this change could break with older firmware versions on BCM283x. Best regards Stefan > > Signed-off-by: Hoegeun Kwon > --- > drivers/gpu/dr

Re: [PATCH 0/3] drm/vc4: Support HDMI QHD or higher output

2020-08-26 Thread Stefan Wahren
i: Add pixel bvb clock control Please change the order of your last 2 patches. First the driver changes and then the device tree sources. Regards Stefan > > arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 -- > drivers/clk/bcm/clk-raspberrypi.c | 1 + > drivers/gpu/drm/vc4/vc4_hd

Re: [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output

2020-08-25 Thread Stefan Wahren
Hi Maxime, Am 25.08.20 um 17:06 schrieb Maxime Ripard: > Hi Stefan, > > On Wed, Jul 29, 2020 at 05:50:31PM +0200, Stefan Wahren wrote: >> Am 29.07.20 um 16:42 schrieb Maxime Ripard: >>> Hi, >>> >>> On Wed, Jul 29, 2020 at 03:09:21PM +0100, Dave Stevens

Re: [PATCH v4] dt-bindings: nvmem: Add syscon to Vybrid OCOTP driver

2020-08-25 Thread Stefan Agner
ta...@vger.kernel.org > Signed-off-by: Chris Healy Reviewed-by: Stefan Agner > --- > Changes in v4: > - Point to the appropriate commit for the Fixes: line > - Update the Required Properties to add the "syscon" compatible > --- > Documentation/devicetree/bindin

[PATCH] ARM: dts: sun4i: Enable HDMI support on the Mele A1000

2020-08-21 Thread Stefan Monnier
Enable the display pipeline and HDMI output. Signed-off-by: Stefan Monnier --- arch/arm/boot/dts/sun4i-a10-a1000.dts | 25 + 1 file changed, 25 insertions(+) diff --git a/arch/arm/boot/dts/sun4i-a10-a1000.dts b/arch/arm/boot/dts/sun4i-a10-a1000.dts index 8692b11a83c3

Re: [PATCH v2] ARM: dts: vfxxx: Add syscon compatible with ocotp

2020-08-21 Thread Stefan Agner
On 2020-08-21 16:13, Chris Healy wrote: > On Fri, Aug 21, 2020 at 6:21 AM Stefan Agner wrote: >> >> On 2020-08-20 06:10, Chris Healy wrote: >> > From: Chris Healy >> > >> > Add syscon compatibility with Vybrid ocotp node. This is required to >> &g

Re: [PATCH] drm: fsl-dcu: enable PIXCLK on LS1021A

2020-08-21 Thread Stefan Agner
cu, so ideally we should enable the pixel clock through the clock framework. On the other hand, I guess that would mean adding a clock driver to flip a single bit, which seems a bit excessive too. I'd like a second opinion on that. Adding clk framework maintainers. -- Stefan > > Signed-off-

Re: [PATCH v2] ARM: dts: vfxxx: Add syscon compatible with ocotp

2020-08-21 Thread Stefan Agner
mx.c. Maybe it does make sense exposing it as syscon, but then we should probably also adjust Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt. -- Stefan > > Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP") > Cc: sta...@vger.kernel.o

Re: [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples

2020-08-19 Thread Stefan Berger
Sakkinen Cc: Mimi Zohar Cc: Stefan Berger OK, now it is clear. Thank you. Reviewed-by: Jarkko Sakkinen Reviewed-by: Stefan Berger /Jarkko --- Changelog: v3: update commit log with review comments from Jarkko Sakkinen. v2: remove the change of trusted key related operation. v1: initial version

Re: [PATCH] HID: roccat: add bounds checking in kone_sysfs_write_settings()

2020-08-19 Thread Stefan Achatz
Please remove the settings->size check. The driver sometimes just writes a modified version of the read settings data. This would fail if stored size is invalid. This value of size is not solely in my hands, I can't guarantee Windows driver does a sanity check, also cases of flash data corruption

Re: [PATCH v2] docs: update trusted-encrypted.rst

2020-08-17 Thread Stefan Berger
Williams Cc: James Bottomley Cc: Jarkko Sakkinen Cc: Mimi Zohar Cc: Stefan Berger --- Changelog: v2: remove the change of trusted key related operation. v1: initial version. Documentation/security/keys/trusted-encrypted.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

Re: [PATCH 4/8] net: mac802154: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Stefan Schmidt
); - tasklet_init(>tasklet, -ieee802154_tasklet_handler, -(unsigned long)local); + tasklet_setup(>tasklet, ieee802154_tasklet_handler); skb_queue_head_init(>skb_queue); Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH RESEND] docs: update trusted-encrypted.rst

2020-08-16 Thread Stefan Berger
Williams Cc: James Bottomley Cc: Jarkko Sakkinen Cc: Mimi Zohar Cc: Stefan Berger --- Documentation/security/keys/trusted-encrypted.rst | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Documentation/security/keys/trusted-encrypted.rst b/Documentation/security/keys

Re: [PATCH] ieee802154/adf7242: check status of adf7242_read_reg

2020-08-03 Thread Stefan Schmidt
lp, 0, _u8); + ret = adf7242_read_reg(lp, 0, _u8); + if (ret) + return ret; len = len_u8; This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH v2 0/5] virtio mmio specification enhancement

2020-07-31 Thread Stefan Hajnoczi
he effort might > have stalled? CCing Alex Bennee. I think he recently asked the same question. Stefan signature.asc Description: PGP signature

Re: [RFC PATCH 0/5] madvise MADV_DOEXEC

2020-07-31 Thread Stefan Hajnoczi
rtions of files into the DAX Window without coordinating with the QEMU process. This simplifies the virtio-fs code and should also improve DAX map/unmap performance. Stefan signature.asc Description: PGP signature

Re: [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output

2020-07-29 Thread Stefan Wahren
quot;); >>> >>> + mdelay(20); >> mdelay for 20ms seems a touch unfriendly as it's a busy wait. Can we >> not msleep instead? > Since the timing was fairly critical, sleeping didn't seem like a good > solution since there's definitely some chance you ove

Re: [PATCH 02/10] block: virtio-blk: check logical block size

2020-07-28 Thread Stefan Hajnoczi
ile changed, 13 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: strace of io_uring events?

2020-07-23 Thread Stefan Hajnoczi
> bases. > > > > Jens, Christoph? > > > > Stefano, what's your intended usecase for your restriction patchset? > > > > Hi Andy, > my use case concerns virtualization. The idea, that I described in the > proposal of io-uring restrictions [1], is to share io_uring CQ and SQ queues > with a guest VM for block operations. > > In the PoC that I realized, there is a block device driver in the guest that > uses io_uring queues coming from the host to submit block requests. > > Since the guest is not trusted, we need restrictions to allow only > a subset of syscalls on a subset of file descriptors and memory. BTW there's only a single mm in the kvm.ko use case. Stefan signature.asc Description: PGP signature

Re: [PATCH 3/3] arm64: dts: meson: add support for the ODROID-N2+

2020-07-22 Thread Stefan Agner
22x.dtsi, which were 1896MHz for the A53 and 1704MHz for the A73 (so it seems currently the A73 running even 100MHz below "Stock"). I guess we should pick either Stock or Overclock for the two models. Unless there is another good reason not to? -- Stefan > > Suggested-by: Dongjin

Re: [PATCH 24/24] net: pass a sockptr_t into ->setsockopt

2020-07-20 Thread Stefan Schmidt
m_setsockopt(struct sock *sk, int level, int optname, if (optlen < sizeof(int)) return -EINVAL; - if (get_user(val, (int __user *)optval)) + if (copy_from_sockptr(, optval, sizeof(int))) return -EFAULT; For the ieee802154 part: Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH] drm/mxsfb: Make supported modifiers explicit

2020-07-20 Thread Stefan Agner
n i do anything to get this applied? > Cheers, > -- Guido Sorry about the delay, I was thinking to apply it with another patchset which is not ready though. Pushed this patch to drm-misc-next just now. -- Stefan > >> >> > --- >> > drivers/gpu/drm/mxsfb/mxsfb_d

Re: [PATCH] drm/mxsfb: miss err handle in probe

2020-07-20 Thread Stefan Agner
, so I guess checking the return value isn't required anymore: https://patchwork.freedesktop.org/patch/msgid/20200408082641.590-11-tzimmerm...@suse.de -- Stefan > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH for v5.9] net: ieee802154: adf7242: Replace HTTP links with HTTPS ones

2020-07-20 Thread Stefan Schmidt
://www.analog.com/ADF7242 */ #include This patch has been applied to the wpan tree and will be part of the next pull request to net. Thanks! regards Stefan Schmidt

Re: [PATCH 05/22] net: remove compat_sock_common_{get,set}sockopt

2020-07-17 Thread Stefan Schmidt
sock_common_setsockopt, - .compat_getsockopt = compat_sock_common_getsockopt, -#endif For the ieee802154 part: Acked-by: Stefan Schmidt regards Stefan Schmidt

Re: [PATCH v5 01/18] nitro_enclaves: Add ioctl interface definition

2020-07-16 Thread Stefan Hajnoczi
On Wed, Jul 15, 2020 at 10:45:23PM +0300, Andra Paraschiv wrote: > + * A NE CPU pool has be set before calling this function. The pool can be set s/has be/has to be/ Thanks, this looks good! Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 07/17] dma: altera-msgdma: Fix struct documentation blocks

2020-07-16 Thread Stefan Roese
' not described in 'msgdma_device' drivers/dma/altera-msgdma.c:265: warning: Function parameter or member 'stride' not described in 'msgdma_desc_config' Cc: Stefan Roese Signed-off-by: Lee Jones Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/dma/altera-msgdma.c | 6 -- 1 file changed, 4

Re: [PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-07-14 Thread Stefan Berger
On 7/14/20 7:20 AM, Jarkko Sakkinen wrote: On Wed, Jul 08, 2020 at 10:17:17AM -0400, Stefan Berger wrote: ❯ swtpm-mvo.swtpm socket --tpmstate dir=/tmp/mytpm1 \ --ctrl type=unixio,path=/tmp/mytpm1/swtpm-sock \ --log level=20 swtpm: Could not open UnixIO socket: No such file or directory

Re: [PATCH] vhost/scsi: fix up req type endian-ness

2020-07-13 Thread Stefan Hajnoczi
rnel.org > Signed-off-by: Michael S. Tsirkin > --- > drivers/vhost/scsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH] vsock/virtio: annotate 'the_virtio_vsock' RCU pointer

2020-07-13 Thread Stefan Hajnoczi
eref] > __rcu * > net/vmw_vsock/virtio_transport.c:631:9:struct virtio_vsock * > > Fixes: 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free on > the_virtio_vsock") > Reported-by: Michael S. Tsirkin > Signed-off-by: Stefano Garzarella > --- >

Re: [PATCH RFC 0/3] io_uring: add restrictions to support untrusted applications and guests

2020-07-13 Thread Stefan Hajnoczi
a virtqueue is used the sqpoll thread cannot poll it directly so another host thread (QEMU) needs to poll the virtqueue. The same applies for the completion code path. Stefan signature.asc Description: PGP signature

Re: [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline

2020-07-10 Thread Stefan Wahren
ify the FIFO level stuff > - Reordered the patches according to Eric's reviews > - Fixed a regression with VID_CTL setting on RPI3 > i additionally applied "drm/vc4/vc4_hdmi: fill ASoC card owner" on top of your series (potential merge conflict). I didn't see any issues with a RPI 3B or RPI 4B. So this whole series is Tested-by: Stefan Wahren Regards Stefan

Re: [PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-07-08 Thread Stefan Berger
On 7/8/20 10:07 AM, Jarkko Sakkinen wrote: On Tue, Jul 07, 2020 at 12:09:11AM -0400, Stefan Berger wrote: On 7/7/20 12:03 AM, Jarkko Sakkinen wrote: On Mon, Jul 06, 2020 at 11:08:12PM -0400, Stefan Berger wrote: On 7/6/20 10:24 PM, Jarkko Sakkinen wrote: On Mon, Jul 06, 2020 at 07:55:26PM

Re: [PATCH][next] s390/dasd: Use struct_size() helper

2020-07-08 Thread Stefan Haberland
Am 19.06.20 um 18:56 schrieb Gustavo A. R. Silva: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > variable _datasize_. > > This code was detected with the help of Coccinelle and, audited and > fixed

Re: [PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-07-06 Thread Stefan Berger
On 7/7/20 12:03 AM, Jarkko Sakkinen wrote: On Mon, Jul 06, 2020 at 11:08:12PM -0400, Stefan Berger wrote: On 7/6/20 10:24 PM, Jarkko Sakkinen wrote: On Mon, Jul 06, 2020 at 07:55:26PM -0400, Stefan Berger wrote: On 7/6/20 7:09 PM, Jarkko Sakkinen wrote: On Mon, Jul 06, 2020 at 02:19:53PM

Re: [PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-07-06 Thread Stefan Berger
On 7/6/20 10:24 PM, Jarkko Sakkinen wrote: On Mon, Jul 06, 2020 at 07:55:26PM -0400, Stefan Berger wrote: On 7/6/20 7:09 PM, Jarkko Sakkinen wrote: On Mon, Jul 06, 2020 at 02:19:53PM -0400, Stefan Berger wrote: From: Stefan Berger In case a TPM2 is attached, search for a TPM2 ACPI table

[RESEND,PATCH v9 0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

2020-07-06 Thread Stefan Berger
From: Stefan Berger This series of patches adds an optional extensions for the TPM2 ACPI table with additional fields found in the TPM2 TCG ACPI specification (reference is in the patch) that allow access to the log's address and its size. We then modify the code that so far only enables access

[RESEND,PATCH v9 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-07-06 Thread Stefan Berger
From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more fields including 12 bytes of start method specific parameters and Log Area Minimum Length (u32) and Log Area Start Address (u64). So, we define a new structure acpi_tpm2_phy that holds these optional new fields. The new

[RESEND,PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-07-06 Thread Stefan Berger
From: Stefan Berger In case a TPM2 is attached, search for a TPM2 ACPI table when trying to get the event log from ACPI. If one is found, use it to get the start and length of the log area. This allows non-UEFI systems, such as SeaBIOS, to pass an event log when using a TPM2. Signed-off

Re: [PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-07-06 Thread Stefan Berger
On 7/6/20 7:09 PM, Jarkko Sakkinen wrote: On Mon, Jul 06, 2020 at 02:19:53PM -0400, Stefan Berger wrote: From: Stefan Berger In case a TPM2 is attached, search for a TPM2 ACPI table when trying to get the event log from ACPI. If one is found, use it to get the start and length of the log area

[PATCH v9 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-07-06 Thread Stefan Berger
From: Stefan Berger Recent extensions of the TPM2 ACPI table added 3 more fields including 12 bytes of start method specific parameters and Log Area Minimum Length (u32) and Log Area Start Address (u64). So, we define a new structure acpi_tpm2_phy that holds these optional new fields. The new

[PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table

2020-07-06 Thread Stefan Berger
From: Stefan Berger In case a TPM2 is attached, search for a TPM2 ACPI table when trying to get the event log from ACPI. If one is found, use it to get the start and length of the log area. This allows non-UEFI systems, such as SeaBIOS, to pass an event log when using a TPM2. Signed-off

[PATCH v9 0/2] tpm2: Make TPM2 logs accessible for non-UEFI firmware

2020-07-06 Thread Stefan Berger
From: Stefan Berger This series of patches adds an optional extensions for the TPM2 ACPI table with additional fields found in the TPM2 TCG ACPI specification (reference is in the patch) that allow access to the log's address and its size. We then modify the code that so far only enables access

Re: [PATCH] tpm: Define TPM2_SPACE_BUFFER_SIZE to replace the use of PAGE_SIZE

2020-07-06 Thread Stefan Berger
(the maximum for PPC64). Define a fixed buffer size set to 16 kB. This should be enough for most use with three handles (that is how many we allow at the moment). Parametrize the buffer size while doing this, so that it is easier to revisit this later on if required. Reported-by: Stefan Berger Cc: sta

Re: [PATCH v3 02/14] iommu: Report domain nesting info

2020-07-03 Thread Stefan Hajnoczi
On Tue, Jun 30, 2020 at 02:00:49AM +, Tian, Kevin wrote: > > From: Liu, Yi L > > Sent: Monday, June 29, 2020 8:23 PM > > > > Hi Stefan, > > > > > From: Stefan Hajnoczi > > > Sent: Monday, June 29, 2020 5:25 PM > > > >

Re: [PATCH v3 02/14] iommu: Report domain nesting info

2020-06-29 Thread Stefan Hajnoczi
kind of clarification could be done for SYSWIDE_PASID and BIND_PGTBL too. Stefan signature.asc Description: PGP signature

Re: [PATCH v3 13/14] vfio: Document dual stage control

2020-06-29 Thread Stefan Hajnoczi
fined by the Virtual Command Support in VT-d 3.0 spec, guest software > +running on VT-d should allocate PASID from host kernel. To allocate PASID > +from host, user space should +check the IOMMU_NESTING_FEAT_SYSWIDE_PASID s/+check/check/g Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[PATCH v3 2/3] ARM: use VFP assembler mnemonics in register load/store macros

2020-06-26 Thread Stefan Agner
the appropriate FPU version. This allows to build these macros with GNU assembler as well as with Clang's built-in assembler. [0] https://reviews.llvm.org/D59733 Link: https://github.com/ClangBuiltLinux/linux/issues/905 Signed-off-by: Stefan Agner --- Changes in v3: - Reworded commit message, adding hint

[PATCH v3 0/3] ARM: make use of UAL VFP mnemonics when possible

2020-06-26 Thread Stefan Agner
in arch/arm/vfp/ to make sure this changes leads to the same code. Besides different inlining behavior I was not able to spot a difference. In v2 the check for FPINST argument support is now made in Kconfig. In v3 reworded commit message and addressed review feedback in patch 1. -- Stefan [0] https

[PATCH v3 3/3] ARM: use VFP assembler mnemonics if available

2020-06-26 Thread Stefan Agner
use of .fpu directives and UAL VFP mnemonics for register access. This allows to build vfpmodule.c with Clang and its integrated assembler. [0] https://reviews.llvm.org/D59733 Link: https://github.com/ClangBuiltLinux/linux/issues/905 Signed-off-by: Stefan Agner --- Changes in v3: - Reworded commit

[PATCH v3 1/3] ARM: use .fpu assembler directives instead of assembler arguments

2020-06-26 Thread Stefan Agner
github.com/ClangBuiltLinux/linux/issues/762 Signed-off-by: Stefan Agner --- Changes in V3: - Drop unnecessary comma - Add .fpu directive also in single precision macros to avoid Clang error error: instruction requires: fp registers Changes in v2: - Add link in commit message arch/arm/vfp/Mak

Re: [PATCH] ARM: dts: vf610: Align L2 cache-controller nodename with dtschema

2020-06-26 Thread Stefan Agner
On 2020-06-26 10:05, Krzysztof Kozlowski wrote: > Fix dtschema validator warnings like: > l2-cache@40006000: $nodename:0: > 'l2-cache@40006000' does not match > '^(cache-controller|cpu)(@[0-9a-f,]+)*$' > > Signed-off-by: Krzysztof Kozlowski Acked-by: Stefan

Re: [PATCH] tpm: Define TPM2_SPACE_BUFFER_SIZE to replace the use of PAGE_SIZE

2020-06-26 Thread Stefan Berger
handles (that is how many we allow at the moment). Reported-by: Stefan Berger Cc: sta...@vger.kernel.org Fixes: 745b361e989a ("tpm: infrastructure for TPM spaces") Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm2-space.c | 27 --- 1 file changed, 16

<    1   2   3   4   5   6   7   8   9   10   >