Re: [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Thu, Apr 21, 2016 at 04:43:45PM +0300, Michael S. Tsirkin wrote: > This adds a flag to enable/disable bypassing the IOMMU by > virtio devices. > > This is on top of patch > http://article.gmane.org/gmane.comp.emulators.qemu/403467 > virtio: convert to use DMA api > > Tested with patchset >

[PATCH] virtio: make find_vqs() checkpatch.pl-friendly

a compiler error due to losing the second const. This patch adjusts the find_vqs() prototype and updates all virtio transports. This makes it possible for virtio_balloon.c, virtio_input.c, virtgpu_kms.c, and virtio_rpmsg_bus.c to use the checkpatch.pl-friendly type. Signed-off-by: Stefan Hajnoczi ---

[PATCH] virtio: make find_vqs() checkpatch.pl-friendly

a compiler error due to losing the second const. This patch adjusts the find_vqs() prototype and updates all virtio transports. This makes it possible for virtio_balloon.c, virtio_input.c, virtgpu_kms.c, and virtio_rpmsg_bus.c to use the checkpatch.pl-friendly type. Signed-off-by: Stefan Hajnoczi <

[PATCH] VSOCK: call sk->sk_data_ready() on accept()

port.c. This happens to work for userspace applications since sk->sk_state_change = sock_def_wakeup() and sk->sk_data_ready = sock_def_readable() both wake up the accept() waiter. In-kernel socket users, on the other hand, fail to detect incoming connections. Signed-off-by: Stefan Hajnoc

[PATCH] VSOCK: call sk->sk_data_ready() on accept()

port.c. This happens to work for userspace applications since sk->sk_state_change = sock_def_wakeup() and sk->sk_data_ready = sock_def_readable() both wake up the accept() waiter. In-kernel socket users, on the other hand, fail to detect incoming connections. Signed-off-by: Stefan Haj

[PATCH] VSOCK: define VSOCK_SS_LISTEN once only

, ...). This way it is clear that the constant is vsock-specific. The big text reflow in af_vsock.c was necessary to keep to the maximum line length. Text is unchanged except for s/SS_LISTEN/VSOCK_SS_LISTEN/. Signed-off-by: Stefan Hajnoczi --- include/net/af_vsock.h | 3 +++ net/vmw_vsock/af_vsock.c

[PATCH] VSOCK: define VSOCK_SS_LISTEN once only

, ...). This way it is clear that the constant is vsock-specific. The big text reflow in af_vsock.c was necessary to keep to the maximum line length. Text is unchanged except for s/SS_LISTEN/VSOCK_SS_LISTEN/. Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> --- include/net/af_vsock.h | 3 ++

Re: [Qemu-devel] [PATCH v3 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device

On Sat, Oct 03, 2015 at 07:28:06PM -0400, Gabriel L. Somlo wrote: > +/* read chunk of given fw_cfg blob (caller responsible for sanity-check) */ > +static inline void fw_cfg_read_blob(u16 key, > + void *buf, loff_t pos, size_t count) > +{ > +

Re: [Qemu-devel] [PATCH v3 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device

On Sat, Oct 03, 2015 at 07:28:06PM -0400, Gabriel L. Somlo wrote: > +/* read chunk of given fw_cfg blob (caller responsible for sanity-check) */ > +static inline void fw_cfg_read_blob(u16 key, > + void *buf, loff_t pos, size_t count) > +{ > +

Re: [PATCH v4] QEMU fw_cfg DMA interface documentation

On Mon, Oct 5, 2015 at 11:06 AM, Marc Marí wrote: > On Mon, 5 Oct 2015 09:20:55 +0100 > Stefan Hajnoczi wrote: > >> On Thu, Oct 1, 2015 at 1:15 PM, Marc Marí wrote: >> > +Additionaly, if the DMA interface is available then a read to the >> > DMA Address +will

Re: [PATCH v4] QEMU fw_cfg DMA interface documentation

On Thu, Oct 1, 2015 at 1:15 PM, Marc Marí wrote: > +Additionaly, if the DMA interface is available then a read to the DMA Address > +will return 0x51454d5520434647 ("QEMU CFG" in big-endian format). What does this mean? Stefan -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v4] QEMU fw_cfg DMA interface documentation

On Thu, Oct 1, 2015 at 1:15 PM, Marc Marí wrote: > +Additionaly, if the DMA interface is available then a read to the DMA Address > +will return 0x51454d5520434647 ("QEMU CFG" in big-endian format). What does this mean? Stefan -- To unsubscribe from this list: send the line

Re: [PATCH v4] QEMU fw_cfg DMA interface documentation

On Mon, Oct 5, 2015 at 11:06 AM, Marc Marí <mar...@redhat.com> wrote: > On Mon, 5 Oct 2015 09:20:55 +0100 > Stefan Hajnoczi <stefa...@gmail.com> wrote: > >> On Thu, Oct 1, 2015 at 1:15 PM, Marc Marí <mar...@redhat.com> wrote: >> > +Additionaly, if

Re: [PATCH v2] QEMU fw_cfg DMA interface documentation

lowing bits: > + - Bit 0: Error > + - Bit 1: Read > + - Bit 2: Skip > + > +When an operation is triggered, if the "control" field has bit 1 set, a read > +operation will be performed. "length" bytes for the current selector and > +offset will be copied

Re: [PATCH v2] QEMU fw_cfg DMA interface documentation

+ > +The "control" field has the following bits: > + - Bit 0: Error > + - Bit 1: Read > + - Bit 2: Skip > + > +When an operation is triggered, if the "control" field has bit 1 set, a read > +operation will be performed. "length" bytes for the current

Re: QEMU fw_cfg DMA interface

On Thu, Aug 6, 2015 at 1:37 PM, Marc Marí wrote: > On Thu, 6 Aug 2015 13:27:16 +0100 > Stefan Hajnoczi wrote: > >> On Thu, Aug 6, 2015 at 12:00 PM, Marc Marí wrote: >> > When running a Linux guest on top of QEMU, using the -kernel >> > options, this

Re: [PATCH] QEMU fw_cfg DMA interface documentation

On Thu, Aug 6, 2015 at 1:22 PM, Laszlo Ersek wrote: > On 08/06/15 14:12, Stefan Hajnoczi wrote: >> On Thu, Aug 6, 2015 at 12:03 PM, Marc Marí wrote: >>> Add fw_cfg DMA interface specfication in the fw_cfg documentation. >>> >>> Signed-off-by: Marc Marí &

Re: QEMU fw_cfg DMA interface

On Thu, Aug 6, 2015 at 12:00 PM, Marc Marí wrote: > When running a Linux guest on top of QEMU, using the -kernel options, this > is the timing improvement for x86: > > QEMU commit 2be4f242b50a8 and SeaBIOS commit 908a58c1d5ff > QEMU startup time: .078 > BIOS startup time: .060 > Kernel setup

Re: [PATCH] QEMU fw_cfg DMA interface documentation

On Thu, Aug 6, 2015 at 12:03 PM, Marc Marí wrote: > Add fw_cfg DMA interface specfication in the fw_cfg documentation. > > Signed-off-by: Marc Marí > --- > Documentation/devicetree/bindings/arm/fw-cfg.txt | 36 > > 1 file changed, 36 insertions(+) > > diff --git

Re: [PATCH] QEMU fw_cfg DMA interface documentation

On Thu, Aug 6, 2015 at 1:22 PM, Laszlo Ersek ler...@redhat.com wrote: On 08/06/15 14:12, Stefan Hajnoczi wrote: On Thu, Aug 6, 2015 at 12:03 PM, Marc Marí mar...@redhat.com wrote: Add fw_cfg DMA interface specfication in the fw_cfg documentation. Signed-off-by: Marc Marí mar...@redhat.com

Re: QEMU fw_cfg DMA interface

On Thu, Aug 6, 2015 at 12:00 PM, Marc Marí mar...@redhat.com wrote: When running a Linux guest on top of QEMU, using the -kernel options, this is the timing improvement for x86: QEMU commit 2be4f242b50a8 and SeaBIOS commit 908a58c1d5ff QEMU startup time: .078 BIOS startup time: .060 Kernel

Re: [PATCH] QEMU fw_cfg DMA interface documentation

On Thu, Aug 6, 2015 at 12:03 PM, Marc Marí mar...@redhat.com wrote: Add fw_cfg DMA interface specfication in the fw_cfg documentation. Signed-off-by: Marc Marí mar...@redhat.com --- Documentation/devicetree/bindings/arm/fw-cfg.txt | 36 1 file changed, 36

Re: QEMU fw_cfg DMA interface

On Thu, Aug 6, 2015 at 1:37 PM, Marc Marí mar...@redhat.com wrote: On Thu, 6 Aug 2015 13:27:16 +0100 Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Aug 6, 2015 at 12:00 PM, Marc Marí mar...@redhat.com wrote: When running a Linux guest on top of QEMU, using the -kernel options

Re: [PATCH 0/7] introduce Hyper-V VM Sockets(hvsock)

On Mon, Jul 06, 2015 at 07:39:35AM -0700, Dexuan Cui wrote: > Hyper-V VM Sockets (hvsock) is a byte-stream based communication mechanism > between Windowsd 10 (or later) host and a guest. It's kind of TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. > With Hyper-V VM

Re: [virtio-dev] [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1

--- > drivers/net/virtio_net.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi pgpETWrbb6BFs.pgp Description: PGP signature

Re: [virtio-dev] [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1

/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi stefa...@redhat.com pgpETWrbb6BFs.pgp Description: PGP signature

Re: [PATCH 0/7] introduce Hyper-V VM Sockets(hvsock)

On Mon, Jul 06, 2015 at 07:39:35AM -0700, Dexuan Cui wrote: Hyper-V VM Sockets (hvsock) is a byte-stream based communication mechanism between Windowsd 10 (or later) host and a guest. It's kind of TCP over VMBus, but the transportation layer (VMBus) is much simpler than IP. With Hyper-V VM

Re: [PATCH 00/25] line6usb cleanup

On Sun, Jan 11, 2015 at 10:34 AM, Takashi Iwai wrote: > At Fri, 9 Jan 2015 23:35:46 -0600, > Chris Rorvick wrote: >> >> The line6usb driver references the device's idProduct and, in some >> cases, the interface number in a number of places to determine device- >> specific configuration values

Re: [PATCH 00/25] line6usb cleanup

On Sun, Jan 11, 2015 at 10:34 AM, Takashi Iwai ti...@suse.de wrote: At Fri, 9 Jan 2015 23:35:46 -0600, Chris Rorvick wrote: The line6usb driver references the device's idProduct and, in some cases, the interface number in a number of places to determine device- specific configuration values

Re: [PATCH 00/25] line6usb cleanup

me of > this is really only compile-tested. I no longer own a Pod HD300 so I cannot test these patches. The code looks fine. Reviewed-by: Stefan Hajnoczi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger

Re: [PATCH 00/25] line6usb cleanup

of this is really only compile-tested. I no longer own a Pod HD300 so I cannot test these patches. The code looks fine. Reviewed-by: Stefan Hajnoczi stefa...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] staging: line6: toneport.c: Fix for possible null pointer dereference

: Rickard Strandqvist > --- > drivers/staging/line6/toneport.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) Reviewed-by: Stefan Hajnoczi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger

Re: [PATCH] staging: line6: toneport.c: Fix for possible null pointer dereference

-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/line6/toneport.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) Reviewed-by: Stefan Hajnoczi stefa...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [RFC 0/2] target: userspace pass-through backend

On Tue, Jul 1, 2014 at 9:11 PM, Andy Grover wrote: > Shaohua Li wrote an initial implementation of this, late last year[1]. > Starting from that, I started working on some alternate implementation > choices, and ended up with something rather different. > > Please take a look and let me know what

Re: [RFC 0/2] target: userspace pass-through backend

On Tue, Jul 1, 2014 at 9:11 PM, Andy Grover agro...@redhat.com wrote: Shaohua Li wrote an initial implementation of this, late last year[1]. Starting from that, I started working on some alternate implementation choices, and ended up with something rather different. Please take a look and let

Re: [RFC PATCH 2/2] block: virtio-blk: support multi virt queues per virtio-blk device

On Sat, Jun 14, 2014 at 1:29 AM, Ming Lei wrote: > Firstly this patch supports more than one virtual queues for virtio-blk > device. > > Secondly this patch maps the virtual queue to blk-mq's hardware queue. > > With this approach, both scalability and performance problem can be improved. > >

Re: [RFC PATCH 2/2] block: virtio-blk: support multi virt queues per virtio-blk device

On Sat, Jun 14, 2014 at 1:29 AM, Ming Lei ming@canonical.com wrote: Firstly this patch supports more than one virtual queues for virtio-blk device. Secondly this patch maps the virtual queue to blk-mq's hardware queue. With this approach, both scalability and performance problem can be

Re: Fwd: Re: [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items

e.com > Subject: Re: [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work > items > Message-ID: <20140611124731.ga16...@infradead.org> > In-Reply-To: <1401881699-1456-4-git-send-email-pbonz...@redhat.com> > > Can I get a second review on this one from anyone?

Re: Fwd: Re: [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items

, venkate...@google.com Subject: Re: [PATCH v3 3/6] virtio-scsi: avoid cancelling uninitialized work items Message-ID: 20140611124731.ga16...@infradead.org In-Reply-To: 1401881699-1456-4-git-send-email-pbonz...@redhat.com Can I get a second review on this one from anyone? Reviewed-by: Stefan

Re: [PATCH] staging: line6: toneport.c: Fix for possible null pointer dereference

@ void line6_toneport_disconnect(struct usb_interface > *interface) > device_remove_file(>dev, _attr_led_green); > } > > - if (toneport != NULL) { > - struct snd_line6_pcm *line6pcm = toneport->line6.line6pcm; Didn't look into th

Re: [PATCH] staging: line6: toneport.c: Fix for possible null pointer dereference

it. Reviewed-by: Stefan Hajnoczi stefa...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [Qemu-devel] Massive read only kvm guests when backing file was missing

On Mon, Mar 31, 2014 at 09:51:23PM -0300, Alejandro Comisario wrote: > Again, thanks to everyone. Did you reach a conclusion or is there still a problem that might be a bug in KVM? Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

On Tue, Apr 1, 2014 at 4:27 AM, Theodore Ts'o wrote: > On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: >> >> It's head of my virtio-next tree. > > Hey Rusty, > > While we have your attention --- what's your opinion about adding TRIM > support to virtio-blk. I understand that

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

On Tue, Apr 1, 2014 at 4:27 AM, Theodore Ts'o ty...@mit.edu wrote: On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: It's head of my virtio-next tree. Hey Rusty, While we have your attention --- what's your opinion about adding TRIM support to virtio-blk. I understand that

Re: [Qemu-devel] Massive read only kvm guests when backing file was missing

On Mon, Mar 31, 2014 at 09:51:23PM -0300, Alejandro Comisario wrote: Again, thanks to everyone. Did you reach a conclusion or is there still a problem that might be a bug in KVM? Stefan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [Qemu-devel] Massive read only kvm guests when backing file was missing

On Fri, Mar 28, 2014 at 11:01:00AM +0400, Michael Tokarev wrote: > 27.03.2014 20:14, Alejandro Comisario wrote: > > Seems like virtio (kvm 1.0) doesnt expose timeout on the guest side > > (ubuntu 12.04 on host and guest). > > So, how can i adjust the tinmeout on the guest ? > > After a bit more

Re: [Qemu-devel] Massive read only kvm guests when backing file was missing

On Fri, Mar 28, 2014 at 11:01:00AM +0400, Michael Tokarev wrote: 27.03.2014 20:14, Alejandro Comisario wrote: Seems like virtio (kvm 1.0) doesnt expose timeout on the guest side (ubuntu 12.04 on host and guest). So, how can i adjust the tinmeout on the guest ? After a bit more talks on

Re: [Qemu-devel] Massive read only kvm guests when backing file was missing

On Thu, Mar 27, 2014 at 10:10:40AM +0200, Michael S. Tsirkin wrote: > On Thu, Mar 27, 2014 at 08:36:57AM +0100, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > > > On Wed, Mar 26, 2014 at 11:08:03PM -0300, Alejandro Comisario wrote: > > >> Hi List! > > >> Hope some one can help

Re: [Qemu-devel] Massive read only kvm guests when backing file was missing

On Thu, Mar 27, 2014 at 10:10:40AM +0200, Michael S. Tsirkin wrote: On Thu, Mar 27, 2014 at 08:36:57AM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Mar 26, 2014 at 11:08:03PM -0300, Alejandro Comisario wrote: Hi List! Hope some one can help me,

Re: [PATCH v2] staging: line6: Add blank lines after declarations

rs/staging/line6/playback.c | 5 + > drivers/staging/line6/toneport.c | 1 + > 3 files changed, 7 insertions(+) Reviewed-by: Stefan Hajnoczi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH v2] staging: line6: Add blank lines after declarations

| 1 + drivers/staging/line6/playback.c | 5 + drivers/staging/line6/toneport.c | 1 + 3 files changed, 7 insertions(+) Reviewed-by: Stefan Hajnoczi stefa...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: kvm virtio ethernet ring on guest side over high throughput (packet per second)

On Tue, Jan 21, 2014 at 04:06:05PM -0200, Alejandro Comisario wrote: CCed Michael Tsirkin and Jason Wang who work on KVM networking. > Hi guys, we had in the past when using physical servers, several > throughput issues regarding the throughput of our APIS, in our case we > measure this with

Re: kvm virtio ethernet ring on guest side over high throughput (packet per second)

On Tue, Jan 21, 2014 at 04:06:05PM -0200, Alejandro Comisario wrote: CCed Michael Tsirkin and Jason Wang who work on KVM networking. Hi guys, we had in the past when using physical servers, several throughput issues regarding the throughput of our APIS, in our case we measure this with

Re: [patch] staging: line6: add bounds check in snd_toneport_source_put()

On Fri, Sep 13, 2013 at 10:07 AM, Dan Carpenter wrote: > "source" comes from the user in snd_ctl_elem_write() so it needs to be > checked. > > Signed-off-by: Dan Carpenter Reviewed-by: Stefan Hajnoczi -- To unsubscribe from this list: send the line "unsubscrib

Re: [patch] staging: line6: add bounds check in snd_toneport_source_put()

On Fri, Sep 13, 2013 at 10:07 AM, Dan Carpenter dan.carpen...@oracle.com wrote: source comes from the user in snd_ctl_elem_write() so it needs to be checked. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Stefan Hajnoczi stefa...@gmail.com -- To unsubscribe from this list

Re: [Qemu-devel] reply: reply: qemu crashed when starting vm(kvm) with vnc connect

On Mon, Apr 08, 2013 at 12:27:06PM +, Zhanghaoyu (A) wrote: > On Sun, Apr 07, 2013 at 04:58:07AM +, Zhanghaoyu (A) wrote: > > >>> I start a kvm VM with vnc(using the zrle protocol) connect, sometimes > > >>> qemu program crashed during starting period, received signal SIGABRT. > > >>>

Re: [Qemu-devel] reply: reply: qemu crashed when starting vm(kvm) with vnc connect

On Mon, Apr 08, 2013 at 12:27:06PM +, Zhanghaoyu (A) wrote: On Sun, Apr 07, 2013 at 04:58:07AM +, Zhanghaoyu (A) wrote: I start a kvm VM with vnc(using the zrle protocol) connect, sometimes qemu program crashed during starting period, received signal SIGABRT. Trying about 20

Re: 答复: [Qemu-devel] qemu crashed when starting vm(kvm) with vnc connect

On Sun, Apr 07, 2013 at 04:58:07AM +, Zhanghaoyu (A) wrote: > >> I start a kvm VM with vnc(using the zrle protocol) connect, sometimes qemu > >> program crashed during starting period, received signal SIGABRT. > >> Trying about 20 times, this crash may be reproduced. > >> I guess the cause

Re: 答复: [Qemu-devel] qemu crashed when starting vm(kvm) with vnc connect

On Sun, Apr 07, 2013 at 04:58:07AM +, Zhanghaoyu (A) wrote: I start a kvm VM with vnc(using the zrle protocol) connect, sometimes qemu program crashed during starting period, received signal SIGABRT. Trying about 20 times, this crash may be reproduced. I guess the cause memory

Re: [Qemu-devel] qemu crashed when starting vm(kvm) with vnc connect

On Tue, Apr 02, 2013 at 09:02:02AM +, Zhanghaoyu (A) wrote: > I start a kvm VM with vnc(using the zrle protocol) connect, sometimes qemu > program crashed during starting period, received signal SIGABRT. > Trying about 20 times, this crash may be reproduced. > I guess the cause memory

Re: [Qemu-devel] qemu crashed when starting vm(kvm) with vnc connect

On Tue, Apr 02, 2013 at 09:02:02AM +, Zhanghaoyu (A) wrote: I start a kvm VM with vnc(using the zrle protocol) connect, sometimes qemu program crashed during starting period, received signal SIGABRT. Trying about 20 times, this crash may be reproduced. I guess the cause memory corruption

Re: [PATCH] staging: line6: pod.c: fix checkpatch warning

On Mon, Feb 25, 2013 at 2:08 PM, Laurent Navet wrote: > - WARNING: braces {} are not necessary for single statement blocks > > Signed-off-by: Laurent Navet > --- > drivers/staging/line6/pod.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-b

Re: [PATCH] staging: line6: pod.c: fix checkpatch warning

(-) Reviewed-by: Stefan Hajnoczi stefa...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 1/2] staging: line6: clean up line6_pod_process_message()

of indentation. Only two MIDI messages are still tracked: the POD version message on startup and monitor level changes originating from the device. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 96 + 1 file changed, 19 insertions(+), 77

[PATCH 2/2] staging: line6: clean up line6_variax_process_message()

Previous versions of the line6 driver snooped MIDI traffic in order to make device state accessible via sysfs attributes. This involved a lot of logic in line6_variax_process_message() that has since been removed. Drop unused conditionals in line6_variax_process_message(). Signed-off-by: Stefan

[PATCH 0/2] staging: line6: clean up MIDI post-processing functions

The line6 driver inspects fewer MIDI messages than in previous versions. The conditionals to match these MIDI messages were left in place. This series removes unused conditionals in order to make the MIDI post-processing functions easier to read. Applies to linux-next/master. Stefan Hajnoczi

[PATCH] staging: line6: drop CONFIG_LINE6_USB_DUMP_PCM

* tcpdump and wireshark support for powerful analysis * No driver-specific code is required This is the last user of line6_write_hexdump() so we drop it too. Signed-off-by: Stefan Hajnoczi --- Applies on linux-next/master. drivers/staging/line6/Kconfig| 10 -- drivers/staging

[PATCH] staging: line6: drop CONFIG_LINE6_USB_DUMP_PCM

* tcpdump and wireshark support for powerful analysis * No driver-specific code is required This is the last user of line6_write_hexdump() so we drop it too. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- Applies on linux-next/master. drivers/staging/line6/Kconfig| 10

[PATCH 0/2] staging: line6: clean up MIDI post-processing functions

The line6 driver inspects fewer MIDI messages than in previous versions. The conditionals to match these MIDI messages were left in place. This series removes unused conditionals in order to make the MIDI post-processing functions easier to read. Applies to linux-next/master. Stefan Hajnoczi

[PATCH 1/2] staging: line6: clean up line6_pod_process_message()

of indentation. Only two MIDI messages are still tracked: the POD version message on startup and monitor level changes originating from the device. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 96 + 1 file changed, 19

[PATCH 2/2] staging: line6: clean up line6_variax_process_message()

Previous versions of the line6 driver snooped MIDI traffic in order to make device state accessible via sysfs attributes. This involved a lot of logic in line6_variax_process_message() that has since been removed. Drop unused conditionals in line6_variax_process_message(). Signed-off-by: Stefan

[PATCH 2/6] staging: line6: wrap comment to 80 chars in driver.c

Fix the following checkpatch.pl warning: WARNING: line over 80 characters #1107: FILE: staging/line6/driver.c:523: + /* Wait for data length. We'll get a couple of 0xff until length arrives. */ Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/driver.c | 2 +- 1 file

[PATCH 4/6] staging: line6: wrap lines to 80 chars in pod.c

: + if (memcmp(buf + 1, line6_midi_id, sizeof(line6_midi_id)) == 0) { Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/pod.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index e542540..1a11906

[PATCH 5/6] staging: line6: drop ToneportSourceInfo CamelCase name

definition. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/toneport.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/line6/toneport.c b/drivers/staging/line6/toneport.c index a529dd3..2f44d56 100644 --- a/drivers/staging/line6/toneport.c +++ b

[PATCH 3/6] staging: line6: use pr_err() instead of printk(KERN_ERR, ...)

Fix the following checkpatch.pl warning: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... #1861: FILE: staging/line6/driver.h:56: + printk(KERN_ERR "line6usb driver bug: missing case in %s:%d\n", \ Signed-off-by: Stefa

[PATCH 1/6] staging: line6: rename MidiBuffer to avoid CamelCase

idibuf.c already uses it for a different concept. Avoid possible confusion by using "midi_buffer" instead. Signed-off-by: Stefan Hajnoczi --- drivers/staging/line6/driver.c | 2 +- drivers/staging/line6/midi.c| 2 +- drivers/staging/line6/midi.h| 4 ++-- drivers/st

[PATCH 6/6] staging: line6: avoid CamelCase POD_* enums in pod.c

Fix the following checkpatch.pl warnings: WARNING: Avoid CamelCase: #4512: FILE: staging/line6/pod.c:41: + POD_monitor_level = 0x04, WARNING: Avoid CamelCase: #4513: FILE: staging/line6/pod.c:42: + POD_system_invalid = 0x1 Signed-off-by: Stefan Hajnoczi

[PATCH 0/6] staging: line6: more checkpatch.pl warnings fixes

This series addresses the remaining checkpatch.pl warnings that are easy to fix. This takes the line6 driver another step closer to getting merged as an ALSA driver. Stefan Hajnoczi (6): staging: line6: rename MidiBuffer to avoid CamelCase staging: line6: wrap comment to 80 chars in driver.c

Re: [PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached

On Fri, Jan 11, 2013 at 04:50:41PM +0800, Jason Wang wrote: > @@ -1546,6 +1544,9 @@ static int tun_set_iff(struct net *net, struct file > *file, struct ifreq *ifr) > struct net_device *dev; > int err; > > + if (rcu_dereference_protected(tfile->detached, lockdep_rtnl_is_held()))

Re: [PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached

On Fri, Jan 11, 2013 at 04:50:41PM +0800, Jason Wang wrote: @@ -1546,6 +1544,9 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr) struct net_device *dev; int err; + if (rcu_dereference_protected(tfile-detached, lockdep_rtnl_is_held())) +

[PATCH 0/6] staging: line6: more checkpatch.pl warnings fixes

This series addresses the remaining checkpatch.pl warnings that are easy to fix. This takes the line6 driver another step closer to getting merged as an ALSA driver. Stefan Hajnoczi (6): staging: line6: rename MidiBuffer to avoid CamelCase staging: line6: wrap comment to 80 chars in driver.c

[PATCH 1/6] staging: line6: rename MidiBuffer to avoid CamelCase

already uses it for a different concept. Avoid possible confusion by using midi_buffer instead. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/driver.c | 2 +- drivers/staging/line6/midi.c| 2 +- drivers/staging/line6/midi.h| 4 ++-- drivers/staging/line6

[PATCH 6/6] staging: line6: avoid CamelCase POD_* enums in pod.c

-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index 1a11906..ba6fed4 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging

[PATCH 3/6] staging: line6: use pr_err() instead of printk(KERN_ERR, ...)

Fix the following checkpatch.pl warning: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... #1861: FILE: staging/line6/driver.h:56: + printk(KERN_ERR line6usb driver bug: missing case in %s:%d\n, \ Signed-off-by: Stefan Hajnoczi

[PATCH 5/6] staging: line6: drop ToneportSourceInfo CamelCase name

of the table definition. Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/toneport.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/line6/toneport.c b/drivers/staging/line6/toneport.c index a529dd3..2f44d56 100644 --- a/drivers

[PATCH 4/6] staging: line6: wrap lines to 80 chars in pod.c

: + if (memcmp(buf + 1, line6_midi_id, sizeof(line6_midi_id)) == 0) { Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/pod.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index

[PATCH 2/6] staging: line6: wrap comment to 80 chars in driver.c

Fix the following checkpatch.pl warning: WARNING: line over 80 characters #1107: FILE: staging/line6/driver.c:523: + /* Wait for data length. We'll get a couple of 0xff until length arrives. */ Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- drivers/staging/line6/driver.c | 2

Re: [PATCH] tun: avoid owner checks on IFF_ATTACH_QUEUE

stent device not > owned by them. Here the fd is already attached, > enabling/disabling queue is more like read/write. > > Signed-off-by: Michael S. Tsirkin > > --- > > Note: this is unrelated to Stefan's bugfix. This should go into 3.8-rc. Reviewed-by: Stefan Hajnoc

Re: [PATCH 3.8-rc] tuntap: refuse to re-attach to different tun_struct

On Thu, Jan 10, 2013 at 12:23:19PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 10, 2013 at 08:59:48AM +0100, Stefan Hajnoczi wrote: > > Multiqueue tun devices support detaching a tun_file from its tun_struct > > and re-attaching at a later point in time. This allows u

[PATCH 3.8-rc] tuntap: refuse to re-attach to different tun_struct

to attach to interface "B" after detaching from interface "A". The driver is not designed to support this so check we are re-attaching to the right tun_struct. Failure to do so may lead to oops. Signed-off-by: Stefan Hajnoczi --- This fix is for 3.8-rc. drivers/net/tun.c | 2 +

[PATCH 3.8-rc] tuntap: refuse to re-attach to different tun_struct

to attach to interface B after detaching from interface A. The driver is not designed to support this so check we are re-attaching to the right tun_struct. Failure to do so may lead to oops. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- This fix is for 3.8-rc. drivers/net/tun.c | 2 ++ 1

Re: [PATCH 3.8-rc] tuntap: refuse to re-attach to different tun_struct

On Thu, Jan 10, 2013 at 12:23:19PM +0200, Michael S. Tsirkin wrote: On Thu, Jan 10, 2013 at 08:59:48AM +0100, Stefan Hajnoczi wrote: Multiqueue tun devices support detaching a tun_file from its tun_struct and re-attaching at a later point in time. This allows users to disable a specific

Re: [PATCH] tun: avoid owner checks on IFF_ATTACH_QUEUE

not owned by them. Here the fd is already attached, enabling/disabling queue is more like read/write. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Note: this is unrelated to Stefan's bugfix. This should go into 3.8-rc. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

On Wed, Dec 19, 2012 at 1:04 PM, Paolo Bonzini wrote: > Il 19/12/2012 11:47, Stefan Hajnoczi ha scritto: >> On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: >> What is the purpose of count_sg? > > It is needed to decide whether to use an indirect or a dire

Re: [PATCH v2 5/5] virtio-scsi: introduce multiqueue support

On Tue, Dec 18, 2012 at 01:32:52PM +0100, Paolo Bonzini wrote: > struct virtio_scsi_target_state { > - /* Never held at the same time as vq_lock. */ > + /* This spinlock ever held at the same time as vq_lock. */ s/ever/is never/ -- To unsubscribe from this list: send the line

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: > +/** > + * virtqueue_start_buf - start building buffer for the other end > + * @vq: the struct virtqueue we're talking about. > + * @buf: a struct keeping the state of the buffer > + * @data: the token identifying the buffer. > + *

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: +/** + * virtqueue_start_buf - start building buffer for the other end + * @vq: the struct virtqueue we're talking about. + * @buf: a struct keeping the state of the buffer + * @data: the token identifying the buffer. + * @count:

Re: [PATCH v2 5/5] virtio-scsi: introduce multiqueue support

On Tue, Dec 18, 2012 at 01:32:52PM +0100, Paolo Bonzini wrote: struct virtio_scsi_target_state { - /* Never held at the same time as vq_lock. */ + /* This spinlock ever held at the same time as vq_lock. */ s/ever/is never/ -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

On Wed, Dec 19, 2012 at 1:04 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 19/12/2012 11:47, Stefan Hajnoczi ha scritto: On Tue, Dec 18, 2012 at 01:32:48PM +0100, Paolo Bonzini wrote: What is the purpose of count_sg? It is needed to decide whether to use an indirect or a direct buffer

Re: [patch 1/2] staging: line6: delete an unused function

On Wed, Dec 5, 2012 at 7:43 PM, Dan Carpenter wrote: > line6_send_sysex_message_async() isn't called from anywhere. > > Signed-off-by: Dan Carpenter Reviewed-by: Stefan Hajnoczi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

<    1   2   3   4   5   6   7   8   >