Re: [PATCH RFC v4 10/10] tty: serdev: add functions to retrieve common UART settings

2017-03-28 Thread Stefan Wahren
Am 27.03.2017 um 22:00 schrieb Rob Herring: > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: >> Currently serdev core doesn't provide functions to retrieve common >> UART settings like data bits, stop bits or parity. This patch adds >>

Re: [PATCH RFC v4 10/10] tty: serdev: add functions to retrieve common UART settings

2017-03-28 Thread Stefan Wahren
Am 27.03.2017 um 22:00 schrieb Rob Herring: > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: >> Currently serdev core doesn't provide functions to retrieve common >> UART settings like data bits, stop bits or parity. This patch adds >> the interface to the c

Re: [PATCH RFC v4 06/10] net: qualcomm: make qca_common a separate kernel module

2017-03-28 Thread Stefan Wahren
Am 27.03.2017 um 17:44 schrieb Dan Williams: > On Mon, 2017-03-27 at 15:37 +0200, Stefan Wahren wrote: >> In order to share common functions between QCA7000 SPI and UART >> protocol >> driver the qca_common needs to be a separate kernel module. > Maybe "qca_eth_co

Re: [PATCH RFC v4 06/10] net: qualcomm: make qca_common a separate kernel module

2017-03-28 Thread Stefan Wahren
Am 27.03.2017 um 17:44 schrieb Dan Williams: > On Mon, 2017-03-27 at 15:37 +0200, Stefan Wahren wrote: >> In order to share common functions between QCA7000 SPI and UART >> protocol >> driver the qca_common needs to be a separate kernel module. > Maybe "qca_eth_co

Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

2017-03-28 Thread Stefan Wahren
Am 27.03.2017 um 22:30 schrieb Rob Herring: > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren <stefan.wah...@i2se.com> wrote: >> This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). >> >> Signed-off-by: Stefan Wahren <stefan.wah...@i2

Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

2017-03-28 Thread Stefan Wahren
Am 27.03.2017 um 22:30 schrieb Rob Herring: > On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: >> This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). >> >> Signed-off-by: Stefan Wahren >> --- >> >> According to this bindin

[PATCH RFC v4 09/10] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate

2017-03-27 Thread Stefan Wahren
Instead of returning the requested baudrate, we better return the actual one because it isn't always the same. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/tty/serdev/serdev-ttyport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/

[PATCH RFC v4 09/10] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate

2017-03-27 Thread Stefan Wahren
Instead of returning the requested baudrate, we better return the actual one because it isn't always the same. Signed-off-by: Stefan Wahren --- drivers/tty/serdev/serdev-ttyport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers

[PATCH RFC v4 02/10] net: qca_debug: use net_device_ops instead of direct call

2017-03-27 Thread Stefan Wahren
There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2

[PATCH RFC v4 05/10] net: qualcomm: prepare frame decoding for UART driver

2017-03-27 Thread Stefan Wahren
Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren <stefan.

[PATCH RFC v4 02/10] net: qca_debug: use net_device_ops instead of direct call

2017-03-27 Thread Stefan Wahren
There is no need to export qcaspi_netdev_open and qcaspi_netdev_close because they are also accessible via the net_device_ops. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_debug.c | 5 +++-- drivers/net/ethernet/qualcomm/qca_spi.h | 3 --- 2 files changed, 3 insertions

[PATCH RFC v4 05/10] net: qualcomm: prepare frame decoding for UART driver

2017-03-27 Thread Stefan Wahren
Unfortunately the frame format is not exactly identical between SPI and UART. In case of SPI there is an additional HW length at the beginning. So store the initial state to make the decoding state machine more flexible and easy to extend for UART support. Signed-off-by: Stefan Wahren

[PATCH RFC v4 00/10] net: qualcomm: add QCA7000 UART driver

2017-03-27 Thread Stefan Wahren
order of local variables where possible * implement basic serdev support (without hardware flow control) Changes in v3: * rebase to current net-next Changes in v2: * fix build issue by using netif_trans_update() and dev_trans_start() [1] - https://github.com/IoE/qca7000 Stefan Wahren (10

[PATCH RFC v4 00/10] net: qualcomm: add QCA7000 UART driver

2017-03-27 Thread Stefan Wahren
order of local variables where possible * implement basic serdev support (without hardware flow control) Changes in v3: * rebase to current net-next Changes in v2: * fix build issue by using netif_trans_update() and dev_trans_start() [1] - https://github.com/IoE/qca7000 Stefan Wahren (10

[PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

2017-03-27 Thread Stefan Wahren
This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- According to this binding are still some questions: Where should be the optional hardware flow control defined (at master or slave side)? Is it okay t

[PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

2017-03-27 Thread Stefan Wahren
This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). Signed-off-by: Stefan Wahren --- According to this binding are still some questions: Where should be the optional hardware flow control defined (at master or slave side)? Is it okay to have two bindings (qca-qca7000

[PATCH RFC v4 04/10] net: qualcomm: rename qca_framing.c to qca_common.c

2017-03-27 Thread Stefan Wahren
As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_common would make it clear. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qu

[PATCH RFC v4 04/10] net: qualcomm: rename qca_framing.c to qca_common.c

2017-03-27 Thread Stefan Wahren
As preparation for the upcoming UART driver we need a module which contains common functions for both interfaces. The module qca_framing is a good candidate but renaming to qca_common would make it clear. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Makefile

[PATCH RFC v4 08/10] net: qualcomm: add QCA7000 UART driver

2017-03-27 Thread Stefan Wahren
This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 10 + drivers/net/ethernet/qualcomm/Makefile | 2 + drivers/net/ethernet/qualcomm/qca_co

[PATCH RFC v4 08/10] net: qualcomm: add QCA7000 UART driver

2017-03-27 Thread Stefan Wahren
This patch adds the Ethernet over UART driver for the Qualcomm QCA7000 HomePlug GreenPHY. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 10 + drivers/net/ethernet/qualcomm/Makefile | 2 + drivers/net/ethernet/qualcomm/qca_common.h | 6 + drivers/net

[PATCH RFC v4 10/10] tty: serdev: add functions to retrieve common UART settings

2017-03-27 Thread Stefan Wahren
Currently serdev core doesn't provide functions to retrieve common UART settings like data bits, stop bits or parity. This patch adds the interface to the core and the necessary implementation for serdev-ttyport. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/tty/serdev/

[PATCH RFC v4 10/10] tty: serdev: add functions to retrieve common UART settings

2017-03-27 Thread Stefan Wahren
Currently serdev core doesn't provide functions to retrieve common UART settings like data bits, stop bits or parity. This patch adds the interface to the core and the necessary implementation for serdev-ttyport. Signed-off-by: Stefan Wahren --- drivers/tty/serdev/core.c | 33

[PATCH RFC v4 03/10] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

2017-03-27 Thread Stefan Wahren
The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qu

[PATCH RFC v4 03/10] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

2017-03-27 Thread Stefan Wahren
The function qcaspi_tx_cmd() is only called from qca_spi.c. So we better move it there. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 24 drivers/net/ethernet/qualcomm/qca_7k.h | 1 - drivers/net/ethernet/qualcomm/qca_spi.c | 24

[PATCH RFC v4 06/10] net: qualcomm: make qca_common a separate kernel module

2017-03-27 Thread Stefan Wahren
In order to share common functions between QCA7000 SPI and UART protocol driver the qca_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile

[PATCH RFC v4 01/10] net: qualcomm: remove unnecessary includes

2017-03-27 Thread Stefan Wahren
Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/et

[PATCH RFC v4 06/10] net: qualcomm: make qca_common a separate kernel module

2017-03-27 Thread Stefan Wahren
In order to share common functions between QCA7000 SPI and UART protocol driver the qca_common needs to be a separate kernel module. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/Kconfig | 8 +++- drivers/net/ethernet/qualcomm/Makefile | 5 +++-- drivers/net

[PATCH RFC v4 01/10] net: qualcomm: remove unnecessary includes

2017-03-27 Thread Stefan Wahren
Most of the includes in qca_7k.c are unnecessary so we better remove them. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/qca_7k.c b/drivers/net/ethernet/qualcomm/qca_7k.c index

Re: [GIT PULL 1/4] bcm2835 arm DT updates for 4.12

2017-03-25 Thread Stefan Wahren
Hi Arnd, i hope it's okay if i answer. > Arnd Bergmann hat am 24. März 2017 um 23:25 geschrieben: > > > On Tue, Mar 21, 2017 at 8:39 PM, Eric Anholt wrote: > > Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) > > > > are available in the git repository at: > > > >

Re: [GIT PULL 1/4] bcm2835 arm DT updates for 4.12

2017-03-25 Thread Stefan Wahren
Hi Arnd, i hope it's okay if i answer. > Arnd Bergmann hat am 24. März 2017 um 23:25 geschrieben: > > > On Tue, Mar 21, 2017 at 8:39 PM, Eric Anholt wrote: > > Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) > > > > are available in the git repository at: > > > > git://github.com/anholt/linux

Re: [PATCH] staging: vc04_services: fix NULL pointer dereference on pointer 'service'

2017-03-20 Thread Stefan Wahren
early of the function with a null return. Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced") Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Stefan Wahren <stefan.wah...@i2se.com>

Re: [PATCH] staging: vc04_services: fix NULL pointer dereference on pointer 'service'

2017-03-20 Thread Stefan Wahren
. Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced") Signed-off-by: Colin Ian King Acked-by: Stefan Wahren

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-20 Thread Stefan Wahren
Hi Mauro, Am 20.03.2017 um 11:58 schrieb Mauro Carvalho Chehab: Em Sun, 19 Mar 2017 22:11:07 -0300 Mauro Carvalho Chehab escreveu: Em Sun, 19 Mar 2017 10:04:28 -0700 Michael Zoran escreveu: A working DT that I tried this morning with the

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-20 Thread Stefan Wahren
Hi Mauro, Am 20.03.2017 um 11:58 schrieb Mauro Carvalho Chehab: Em Sun, 19 Mar 2017 22:11:07 -0300 Mauro Carvalho Chehab escreveu: Em Sun, 19 Mar 2017 10:04:28 -0700 Michael Zoran escreveu: A working DT that I tried this morning with the current firmware is posted here:

Re: [PATCH v15 0/5] mxs-lradc: Split driver into MFD

2017-03-17 Thread Stefan Wahren
support for mxs-lradc MFD > iio: adc: mxs-lradc: Add support for adc driver > input: touchscreen: mxs-lradc: Add support for touchscreen > iio: adc: mxs-lradc: Remove driver > mfd: Move binding document > Please add my Tested-by: Stefan Wahren <stefan.wah...@i2se.com&

Re: [PATCH v15 0/5] mxs-lradc: Split driver into MFD

2017-03-17 Thread Stefan Wahren
adc: mxs-lradc: Add support for adc driver > input: touchscreen: mxs-lradc: Add support for touchscreen > iio: adc: mxs-lradc: Remove driver > mfd: Move binding document > Please add my Tested-by: Stefan Wahren for Patch 1 and 2 :) Regarding to patch 5 i'm not sure. Shouldn't

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-15 Thread Stefan Wahren
Hi Mauro, > Mauro Carvalho Chehab hat am 15. März 2017 um > 15:01 geschrieben: > > > Em Fri, 27 Jan 2017 13:54:57 -0800 > Eric Anholt escreveu: > > > Here's my first pass at importing the camera driver. There's a bunch > > of TODO left to it, most

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-15 Thread Stefan Wahren
Hi Mauro, > Mauro Carvalho Chehab hat am 15. März 2017 um > 15:01 geschrieben: > > > Em Fri, 27 Jan 2017 13:54:57 -0800 > Eric Anholt escreveu: > > > Here's my first pass at importing the camera driver. There's a bunch > > of TODO left to it, most of which is documented, and the rest being

Re: [PATCH v14 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

2017-03-15 Thread Stefan Wahren
Hi Ksenija, > Lee Jones <lee.jo...@linaro.org> hat am 14. März 2017 um 12:05 geschrieben: > > > On Wed, 01 Mar 2017, Dmitry Torokhov wrote: > > > On Wed, Mar 01, 2017 at 09:10:50PM +0100, Stefan Wahren wrote: ... > > > > > > Since touchscreen i

Re: [PATCH v14 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

2017-03-15 Thread Stefan Wahren
Hi Ksenija, > Lee Jones hat am 14. März 2017 um 12:05 geschrieben: > > > On Wed, 01 Mar 2017, Dmitry Torokhov wrote: > > > On Wed, Mar 01, 2017 at 09:10:50PM +0100, Stefan Wahren wrote: ... > > > > > > Since touchscreen is optional it doesn't ma

Re: [PATCH] staging: vc04_services: Remove unused functions

2017-03-14 Thread Stefan Wahren
> Jean-Baptiste Abbadie <j...@abbadie.fr> hat am 14. März 2017 um 20:14 > geschrieben: > > > These four functions are not used and report errors with sparse. > > Signed-off-by: Jean-Baptiste Abbadie <j...@abbadie.fr> Acked-by: Stefan Wahren <stefan.wah...@i2se.com>

Re: [PATCH] staging: vc04_services: Remove unused functions

2017-03-14 Thread Stefan Wahren
> Jean-Baptiste Abbadie hat am 14. März 2017 um 20:14 > geschrieben: > > > These four functions are not used and report errors with sparse. > > Signed-off-by: Jean-Baptiste Abbadie Acked-by: Stefan Wahren

Re: [PATCH v4 3/7] mmc: bcm2835: add sdhost controller to devicetree

2017-03-08 Thread Stefan Wahren
Am 08.03.2017 um 10:19 schrieb Gerd Hoffmann: Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Acked-by: Eric Anholt <e...@anholt.net> Acked-by: Stefan Wahren <stefan.wah...@i2se.com> --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 6 ++ arch/arm/boot/dts/bcm

Re: [PATCH v4 3/7] mmc: bcm2835: add sdhost controller to devicetree

2017-03-08 Thread Stefan Wahren
Am 08.03.2017 um 10:19 schrieb Gerd Hoffmann: Signed-off-by: Gerd Hoffmann Acked-by: Eric Anholt Acked-by: Stefan Wahren --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 6 ++ arch/arm/boot/dts/bcm283x.dtsi | 10 ++ 2 files changed, 16 insertions(+) diff --git a/arch/arm

Re: [PATCH v3 2/7] mmc: bcm2835: Add new driver for the sdhost controller.

2017-03-01 Thread Stefan Wahren
> Eric Anholt <e...@anholt.net> hat am 1. März 2017 um 20:31 geschrieben: > > > Stefan Wahren <stefan.wah...@i2se.com> writes: > > >> Eric Anholt <e...@anholt.net> hat am 1. März 2017 um 19:00 geschrieben: > >> > >> > >&

Re: [PATCH v3 2/7] mmc: bcm2835: Add new driver for the sdhost controller.

2017-03-01 Thread Stefan Wahren
> Eric Anholt hat am 1. März 2017 um 20:31 geschrieben: > > > Stefan Wahren writes: > > >> Eric Anholt hat am 1. März 2017 um 19:00 geschrieben: > >> > >> > >> Gerd Hoffmann writes: > >> > >> > From: Eric Anholt &g

Re: [PATCH v14 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

2017-03-01 Thread Stefan Wahren
> Ksenija Stanojevic hat am 1. März 2017 um > 19:02 geschrieben: > > > Add core files for low resolution analog-to-digital converter (mxs-lradc) > MFD driver. > > Signed-off-by: Ksenija Stanojevic > Acked-by: Lee Jones

Re: [PATCH v14 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

2017-03-01 Thread Stefan Wahren
> Ksenija Stanojevic hat am 1. März 2017 um > 19:02 geschrieben: > > > Add core files for low resolution analog-to-digital converter (mxs-lradc) > MFD driver. > > Signed-off-by: Ksenija Stanojevic > Acked-by: Lee Jones > --- > Changes in v14: > - none > > Changes in v13: > - none > >

Re: [PATCH v3 2/7] mmc: bcm2835: Add new driver for the sdhost controller.

2017-03-01 Thread Stefan Wahren
> Eric Anholt hat am 1. März 2017 um 19:00 geschrieben: > > > Gerd Hoffmann writes: > > > From: Eric Anholt > > > > The 2835 has two SD controllers: The Arasan sdhci controller (supported > > by the iproc driver) and a custom sdhost

Re: [PATCH v3 2/7] mmc: bcm2835: Add new driver for the sdhost controller.

2017-03-01 Thread Stefan Wahren
> Eric Anholt hat am 1. März 2017 um 19:00 geschrieben: > > > Gerd Hoffmann writes: > > > From: Eric Anholt > > > > The 2835 has two SD controllers: The Arasan sdhci controller (supported > > by the iproc driver) and a custom sdhost controller. This patch adds a > > driver for the latter.

Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path

2017-02-24 Thread Stefan Wahren
> Dan Carpenter <dan.carpen...@oracle.com> hat am 24. Februar 2017 um 20:57 > geschrieben: > > > On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote: > > Hi Christophe, > > > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET: > > >I

Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path

2017-02-24 Thread Stefan Wahren
> Dan Carpenter hat am 24. Februar 2017 um 20:57 > geschrieben: > > > On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote: > > Hi Christophe, > > > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET: > > >If 'kzalloc()' fails, we shoul

Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path

2017-02-24 Thread Stefan Wahren
Hi Christophe, Am 19.02.2017 um 11:34 schrieb Christophe JAILLET: If 'kzalloc()' fails, we should release resources allocated so far, just as done in all other cases in this function. Signed-off-by: Christophe JAILLET --- Not sure that the error handling path is

Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path

2017-02-24 Thread Stefan Wahren
Hi Christophe, Am 19.02.2017 um 11:34 schrieb Christophe JAILLET: If 'kzalloc()' fails, we should release resources allocated so far, just as done in all other cases in this function. Signed-off-by: Christophe JAILLET --- Not sure that the error handling path is correct. Is 'gdev[0]' freed?

Re: [PATCH 1/2] MAINTAINERS: Add Stefan Wahren to bcm2835.

2017-02-23 Thread Stefan Wahren
lopment. > > Signed-off-by: Eric Anholt <e...@anholt.net> as i already wrote i'm happy to help you here. Acked-by: Stefan Wahren <stefan.wah...@i2se.com>

Re: [PATCH 1/2] MAINTAINERS: Add Stefan Wahren to bcm2835.

2017-02-23 Thread Stefan Wahren
gned-off-by: Eric Anholt as i already wrote i'm happy to help you here. Acked-by: Stefan Wahren

Re: [PATCH v3 3/7] mmc: bcm2835: add sdhost controller to devicetree

2017-02-21 Thread Stefan Wahren
Am 21.02.2017 um 10:07 schrieb Gerd Hoffmann: Signed-off-by: Gerd Hoffmann Acked-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 6 ++ arch/arm/boot/dts/bcm283x.dtsi | 10 ++ 2 files changed, 16 insertions(+) diff --git

Re: [PATCH v3 3/7] mmc: bcm2835: add sdhost controller to devicetree

2017-02-21 Thread Stefan Wahren
Am 21.02.2017 um 10:07 schrieb Gerd Hoffmann: Signed-off-by: Gerd Hoffmann Acked-by: Eric Anholt --- arch/arm/boot/dts/bcm2835-rpi.dtsi | 6 ++ arch/arm/boot/dts/bcm283x.dtsi | 10 ++ 2 files changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi

Re: [PATCH v2 2/8] mmc: bcm2835: Add new driver for the sdhost controller.

2017-02-08 Thread Stefan Wahren
> Gerd Hoffmann hat am 7. Februar 2017 um 09:02 geschrieben: > ... > > > > I'll send it after my tests. In the following review i will mention only > > the issues which aren't fixed in my patch series. > > I'll pick up the patches and look at the remaining issues, new

Re: [PATCH v2 2/8] mmc: bcm2835: Add new driver for the sdhost controller.

2017-02-08 Thread Stefan Wahren
> Gerd Hoffmann hat am 7. Februar 2017 um 09:02 geschrieben: > ... > > > > I'll send it after my tests. In the following review i will mention only > > the issues which aren't fixed in my patch series. > > I'll pick up the patches and look at the remaining issues, new version > later this

Re: [PATCH v2 2/8] mmc: bcm2835: Add new driver for the sdhost controller.

2017-02-07 Thread Stefan Wahren
Hi Gerd, Am 07.02.2017 um 09:02 schrieb Gerd Hoffmann: > On Mo, 2017-02-06 at 21:34 +0100, Stefan Wahren wrote: >> Hi Gerd, >> >> first of all here my wishlist for the next round of this driver: >> * compile test the series with ARM and ARM64 > It is tested on both a

Re: [PATCH v2 2/8] mmc: bcm2835: Add new driver for the sdhost controller.

2017-02-07 Thread Stefan Wahren
Hi Gerd, Am 07.02.2017 um 09:02 schrieb Gerd Hoffmann: > On Mo, 2017-02-06 at 21:34 +0100, Stefan Wahren wrote: >> Hi Gerd, >> >> first of all here my wishlist for the next round of this driver: >> * compile test the series with ARM and ARM64 > It is tested on both a

Re: [PATCH v2 2/8] mmc: bcm2835: Add new driver for the sdhost controller.

2017-02-06 Thread Stefan Wahren
d you the patches for squashing them all together. Here is the preview for my patch series: Stefan Wahren (15): mmc: bcm2835: Add missing include for threaded irq mmc: bcm2835: Remove CMD_DALLY_US mmc: bcm2835: Fix pio_timeout handling mmc: bcm2835: Remove unnecessary return in bcm2835_

Re: [PATCH v2 2/8] mmc: bcm2835: Add new driver for the sdhost controller.

2017-02-06 Thread Stefan Wahren
commit, because this commit [1] doesn't seem to be included. [1] - https://github.com/raspberrypi/linux/commit/ea4b1c5c2ddbb6caba43ab9b0103542a4ca7e1f0 I've found and fixed a lot of issues in this version and i think it would be better if i send you the patches for squashing them all toge

Re: [RESENT PATCH] ARM: bcm2835: Add devicetree for the Raspberry Pi 3, for arm (32)

2017-02-02 Thread Stefan Wahren
Am 02.02.2017 um 09:37 schrieb Michael Zoran: This is actually a problem I had to deal with way in the begging of ARM64. What was done in the github tree was to have the one of the DTS files(in this case 64) #include the 32 bit dts. That way it's not needed to have the symbolic link and

Re: [RESENT PATCH] ARM: bcm2835: Add devicetree for the Raspberry Pi 3, for arm (32)

2017-02-02 Thread Stefan Wahren
Am 02.02.2017 um 09:37 schrieb Michael Zoran: This is actually a problem I had to deal with way in the begging of ARM64. What was done in the github tree was to have the one of the DTS files(in this case 64) #include the 32 bit dts. That way it's not needed to have the symbolic link and

Re: [PATCH] MAINTAINERS: Update for the current location of the bcm2835 tree.

2017-01-31 Thread Stefan Wahren
> Eric Anholt <e...@anholt.net> hat am 31. Januar 2017 um 20:48 geschrieben: > > > I've been maintaining the bcm2835 branches here for a year or so. > > Signed-off-by: Eric Anholt <e...@anholt.net> FWIW Acked-by: Stefan Wahren <stefan.wah...@i2se.com>

Re: [PATCH] MAINTAINERS: Update for the current location of the bcm2835 tree.

2017-01-31 Thread Stefan Wahren
> Eric Anholt hat am 31. Januar 2017 um 20:48 geschrieben: > > > I've been maintaining the bcm2835 branches here for a year or so. > > Signed-off-by: Eric Anholt FWIW Acked-by: Stefan Wahren

Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost.

2017-01-30 Thread Stefan Wahren
> Gerd Hoffmann hat am 27. Januar 2017 um 12:36 geschrieben: > > > From: Eric Anholt > > This is the other SD controller on the platform, which can be swapped > to the role of SD card host using pin muxing. AFAIK the SDHOST controller isn't able to handle

Re: [PATCH 1/4] dt-bindings: Add binding for brcm,bcm2835-sdhost.

2017-01-30 Thread Stefan Wahren
> Gerd Hoffmann hat am 27. Januar 2017 um 12:36 geschrieben: > > > From: Eric Anholt > > This is the other SD controller on the platform, which can be swapped > to the role of SD card host using pin muxing. AFAIK the SDHOST controller isn't able to handle SDIO. Maybe we should mention this

Re: [PATCH 4/4] ARM: dts: bcm283x: switch from to

2017-01-30 Thread Stefan Wahren
> Gerd Hoffmann hat am 27. Januar 2017 um 12:36 geschrieben: > > > This flips the switch from (iproc-driven) sdhci controller to the custom > sdhost controller. As long as the SDHOST driver isn't enabled in bcm2835_defconfig we shouldn't do that. Btw please write down the

Re: [PATCH 4/4] ARM: dts: bcm283x: switch from to

2017-01-30 Thread Stefan Wahren
> Gerd Hoffmann hat am 27. Januar 2017 um 12:36 geschrieben: > > > This flips the switch from (iproc-driven) sdhci controller to the custom > sdhost controller. As long as the SDHOST driver isn't enabled in bcm2835_defconfig we shouldn't do that. Btw please write down the reason why this

Re: [PATCH 2/4] mmc: bcm2835: Add new driver for the internal SD controller.

2017-01-30 Thread Stefan Wahren
s fwd decl > mmc: bcm2835: use dev_dbg() > mmc: bcm2835: use dev_err() > mmc: bcm2835: use dev_warn() + dev_into() > > cleanups by Stefan Wahren: > > mmc: bcm2835: Fix checkpatch.pl warning > mmc: bcm2835: replace spaces with tabs > mmc: bcm2835: remove bcm2835_set_power > mmc: bcm

Re: [PATCH 2/4] mmc: bcm2835: Add new driver for the internal SD controller.

2017-01-30 Thread Stefan Wahren
t to bcm2835 > mmc: bcm2835: whitespace & comment style > mmc: bcm2835: zap bcm2835_write > mmc: bcm2835: zap bcm2835_read > mmc: bcm2835: zap bcm2835_read_relaxed > mmc: bcm2835: zap bcm2835_set_ios fwd decl > mmc: bcm2835: use dev_dbg() > mmc: bcm2835: use dev_err(

Re: [PATCH v13 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen

2017-01-29 Thread Stefan Wahren
Hi Ksenija, > Ksenija Stanojevic hat am 29. Januar 2017 um > 19:04 geschrieben: > > > Add 4-wire/5-wire touchscreen controller. i compiled all 3 driver as a module and kept the devicetree for the Olinuxino iMX233 [1] as it is (no touchscreen). After booting all

Re: [PATCH v13 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen

2017-01-29 Thread Stefan Wahren
Hi Ksenija, > Ksenija Stanojevic hat am 29. Januar 2017 um > 19:04 geschrieben: > > > Add 4-wire/5-wire touchscreen controller. i compiled all 3 driver as a module and kept the devicetree for the Olinuxino iMX233 [1] as it is (no touchscreen). After booting all 3 driver are loaded: Module

Re: [PATCH v13 2/5] iio: adc: mxs-lradc: Add support for adc driver

2017-01-29 Thread Stefan Wahren
drivers/iio/adc/mxs-lradc-adc.c:344: +static IIO_DEVICE_ATTR(in_voltage##ch##_scale_available, S_IRUGO, \ total: 1 errors, 2 warnings, 869 lines checked But the iio values on Olinuxino Maxi looks good. Tested-by: Stefan Wahren <stefan.wah...@i2se.com>

Re: [PATCH v13 2/5] iio: adc: mxs-lradc: Add support for adc driver

2017-01-29 Thread Stefan Wahren
otal: 1 errors, 2 warnings, 869 lines checked But the iio values on Olinuxino Maxi looks good. Tested-by: Stefan Wahren

Re: [PATCH v13 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

2017-01-29 Thread Stefan Wahren
Hi Ksenija, > Ksenija Stanojevic hat am 29. Januar 2017 um > 19:04 geschrieben: > > > Add core files for low resolution analog-to-digital converter (mxs-lradc) > MFD driver. > > Signed-off-by: Ksenija Stanojevic > Acked-by: Lee

Re: [PATCH v13 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

2017-01-29 Thread Stefan Wahren
Hi Ksenija, > Ksenija Stanojevic hat am 29. Januar 2017 um > 19:04 geschrieben: > > > Add core files for low resolution analog-to-digital converter (mxs-lradc) > MFD driver. > > Signed-off-by: Ksenija Stanojevic > Acked-by: Lee Jones unfortunately this patch (only MAKEFILE part) doesn't

Re: [PATCH 2/4] mmc: bcm2835: Add new driver for the internal SD controller.

2017-01-27 Thread Stefan Wahren
Am 27.01.2017 um 16:27 schrieb Ulf Hansson: > On 27 January 2017 at 12:36, Gerd Hoffmann wrote: >> From: Eric Anholt >> >> The 2835 has two SD controllers: The Arasan SDHCI controller (supported >> by the iproc driver) and a custom SD controller. This patch

Re: [PATCH 2/4] mmc: bcm2835: Add new driver for the internal SD controller.

2017-01-27 Thread Stefan Wahren
Am 27.01.2017 um 16:27 schrieb Ulf Hansson: > On 27 January 2017 at 12:36, Gerd Hoffmann wrote: >> From: Eric Anholt >> >> The 2835 has two SD controllers: The Arasan SDHCI controller (supported >> by the iproc driver) and a custom SD controller. This patch adds a >> driver for the custom SD

Re: [PATCH v11 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen

2017-01-20 Thread Stefan Wahren
Hi Ksenija, [updated Fabio's mail address] thanks for all your work on that driver. Do you plan to submit a V13 of this patch series to address Dmitry's notes? Best regards Stefan

Re: [PATCH v11 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen

2017-01-20 Thread Stefan Wahren
Hi Ksenija, [updated Fabio's mail address] thanks for all your work on that driver. Do you plan to submit a V13 of this patch series to address Dmitry's notes? Best regards Stefan

Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()

2016-12-30 Thread Stefan Wahren
> Jonathan Cameron <ji...@kernel.org> hat am 30. Dezember 2016 um 20:09 > geschrieben: > > > On 26/12/16 22:04, Stefan Wahren wrote: > > > >> Alexey Khoroshilov <khoroshi...@ispras.ru> hat am 23. Dezember 2016 um > >> 23:15 ges

Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()

2016-12-30 Thread Stefan Wahren
> Jonathan Cameron hat am 30. Dezember 2016 um 20:09 > geschrieben: > > > On 26/12/16 22:04, Stefan Wahren wrote: > > > >> Alexey Khoroshilov hat am 23. Dezember 2016 um > >> 23:15 geschrieben: > >> > >> > >> During tran

Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()

2016-12-26 Thread Stefan Wahren
That is wrong since resources are left undeallocated. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> > Fixes: 962ed43a3eac ("iio: mxs-lradc: remove mxs_lradc_ts_unregister") Acked-by

Re: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()

2016-12-26 Thread Stefan Wahren
s are left undeallocated. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > Fixes: 962ed43a3eac ("iio: mxs-lradc: remove mxs_lradc_ts_unregister") Acked-by: Stefan Wahren But since Ksenija's patch series [1] (w

Re: [PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

2016-12-20 Thread Stefan Wahren
Hi Sevak, > Sevak Arakelyan <sevak.arakel...@synopsys.com> hat am 20. Dezember 2016 um > 13:57 geschrieben: > > > On 12/19/2016 8:39 PM, Stefan Wahren wrote: > > Currently the upper limit for the endpoint index during fifo size > > config was always 16 inste

Re: [PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

2016-12-20 Thread Stefan Wahren
Hi Sevak, > Sevak Arakelyan hat am 20. Dezember 2016 um > 13:57 geschrieben: > > > On 12/19/2016 8:39 PM, Stefan Wahren wrote: > > Currently the upper limit for the endpoint index during fifo size > > config was always 16 instead of the available endpoint

[PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-

[PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-

[PATCH] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-

[PATCH] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-

Re: [PATCH] serial: mxs-auart: support CMSPAR termios cflag

2016-12-06 Thread Stefan Wahren
Hi Wolfgang, > --- a/drivers/tty/serial/mxs-auart.c > +++ b/drivers/tty/serial/mxs-auart.c > @@ -95,6 +95,7 @@ > #define AUART_LINECTRL_BAUD_DIVFRAC_SHIFT8 > #define AUART_LINECTRL_BAUD_DIVFRAC_MASK 0x3f00 > #define AUART_LINECTRL_BAUD_DIVFRAC(v) (((v) & 0x3f) << 8) >

Re: [PATCH] serial: mxs-auart: support CMSPAR termios cflag

2016-12-06 Thread Stefan Wahren
Hi Wolfgang, > --- a/drivers/tty/serial/mxs-auart.c > +++ b/drivers/tty/serial/mxs-auart.c > @@ -95,6 +95,7 @@ > #define AUART_LINECTRL_BAUD_DIVFRAC_SHIFT8 > #define AUART_LINECTRL_BAUD_DIVFRAC_MASK 0x3f00 > #define AUART_LINECTRL_BAUD_DIVFRAC(v) (((v) & 0x3f) << 8) >

Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

2016-11-22 Thread Stefan Wahren
Hi Felipe, Am 22.11.2016 um 13:23 schrieb Felipe Balbi: > Hi, > > Stefan Wahren <stefan.wah...@i2se.com> writes: >> Since there is no parameter @value replace it with @legacy. >> >> Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params")

Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

2016-11-22 Thread Stefan Wahren
Hi Felipe, Am 22.11.2016 um 13:23 schrieb Felipe Balbi: > Hi, > > Stefan Wahren writes: >> Since there is no parameter @value replace it with @legacy. >> >> Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params") >> Signed-off-by:

[PATCH 2/5] usb: dwc2: fix dwc2_get_device_property for u8 and u16

2016-11-20 Thread Stefan Wahren
t;) Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/params.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index fd5f7f8..2c7b624 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/u

[PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

2016-11-20 Thread Stefan Wahren
Since there is no parameter @value replace it with @legacy. Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params") Signed-off-by: Stefan Wahren <stefan.wah...@i2se.com> --- drivers/usb/dwc2/params.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

<    3   4   5   6   7   8   9   10   11   12   >