On Wed, Jun 26, 2024 at 02:08:37PM GMT, Luigi Leonardi via B4 Relay wrote:
From: Luigi Leonardi
Introduce two tests, one for SOCK_STREAM and one for SOCK_SEQPACKET, which
checks
after a packet is delivered, that the number of unsent bytes is zero,
using ioctl SIOCOUTQ.
Signed-off-by: Luigi
On Thu, Jul 11, 2024 at 04:58:47PM GMT, Luigi Leonardi via B4 Relay wrote:
From: Luigi Leonardi
Introduce an optimization in virtio_transport_send_pkt:
when the work queue (send_pkt_queue) is empty the packet is
Note: send_pkt_queue is just a queue of sk_buff, is not really a work
queue.
virtio_transport_send_skb() function.
Co-developed-by: Luigi Leonardi
Signed-off-by: Luigi Leonardi
Signed-off-by: Marco Pinna
---
net/vmw_vsock/virtio_transport.c | 105 ++-
1 file changed, 59 insertions(+), 46 deletions(-)
LGTM
Reviewed-by: Stefano Garzarella
On Thu, Jul 11, 2024 at 07:14:55AM GMT, Jakub Kicinski wrote:
On Thu, 11 Jul 2024 15:38:01 +0200 Stefan Hajnoczi wrote:
> Usually vsock tests test both the driver (virtio-vsock) in the guest and the
> device in the host kernel (vhost-vsock). So I usually run the tests in 2
> nested VMs to test
CCing Stefan.
On Wed, Jul 10, 2024 at 07:00:59PM GMT, Jakub Kicinski wrote:
On Wed, 10 Jul 2024 13:58:39 +0200 Stefano Garzarella wrote:
There is a comment there:
# Avoid changing the rest of the logic here and lib.mk.
Added by commit 17eac6c2db8b2cdfe33d40229bdda2acd86b304a.
IIUC
within a week, please resend specifying net-next.
Reviewed-by: Stefano Garzarella
V2:
Use VSOCK_INSTALL_PATH, drop INSTALL_PATH
tools/testing/vsock/Makefile | 13 +
1 file changed, 13 insertions(+)
diff --git a/tools/testing/vsock/Makefile b/tools/testing/vsock/Makefile
index
On Wed, Jul 10, 2024 at 11:34:05AM GMT, Peng Fan wrote:
Subject: Re: [PATCH] test/vsock: add install target
On Wed, Jul 10, 2024 at 08:11:32AM GMT, Peng Fan wrote:
>> Subject: Re: [PATCH] test/vsock: add install target
>>
>> On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote:
>>
On Wed, Jul 10, 2024 at 08:11:32AM GMT, Peng Fan wrote:
Subject: Re: [PATCH] test/vsock: add install target
On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote:
>From: Peng Fan
>
>Add install target for vsock to make Yocto easy to install the images.
>
>Signed-off-by: Peng Fan
>---
>
On Wed, Jul 10, 2024 at 03:28:31PM GMT, Jason Wang wrote:
On Wed, Jul 10, 2024 at 3:19 PM Stefano Garzarella wrote:
On Wed, Jul 10, 2024 at 11:08:48AM GMT, Jason Wang wrote:
>On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella wrote:
>>
>> On Tue, Jul 09, 2024 at 10:56:16AM
On Tue, Jul 09, 2024 at 09:50:51PM GMT, Peng Fan (OSS) wrote:
From: Peng Fan
Add install target for vsock to make Yocto easy to install the images.
Signed-off-by: Peng Fan
---
tools/testing/vsock/Makefile | 12
1 file changed, 12 insertions(+)
diff --git
On Wed, Jul 10, 2024 at 11:08:48AM GMT, Jason Wang wrote:
On Tue, Jul 9, 2024 at 8:41 PM Stefano Garzarella wrote:
On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote:
>On Mon, Jul 8, 2024 at 4:15 PM Stefano Garzarella wrote:
>>
>> Hi Cindy, Jason,
>>
>> On
On Tue, Jul 09, 2024 at 10:56:16AM GMT, Jason Wang wrote:
On Mon, Jul 8, 2024 at 4:15 PM Stefano Garzarella wrote:
Hi Cindy, Jason,
On Mon, Jul 08, 2024 at 03:59:34PM GMT, Jason Wang wrote:
>On Mon, Jul 8, 2024 at 3:06 PM Cindy Lu wrote:
>>
>> On Fri, 5 Jul 2024 at 20:42, Ste
Hi Cindy, Jason,
On Mon, Jul 08, 2024 at 03:59:34PM GMT, Jason Wang wrote:
On Mon, Jul 8, 2024 at 3:06 PM Cindy Lu wrote:
On Fri, 5 Jul 2024 at 20:42, Stefano Garzarella wrote:
>
> On Fri, Jul 05, 2024 at 07:30:51AM GMT, Michael S. Tsirkin wrote:
> >On Fri, Jul 05, 2024 at 01:2
On Fri, Jul 05, 2024 at 07:30:51AM GMT, Michael S. Tsirkin wrote:
On Fri, Jul 05, 2024 at 01:28:21PM +0200, Stefano Garzarella wrote:
The vDPA block simulator always allocated a 128 MiB ram-disk, but some
filesystems (e.g. XFS) may require larger minimum sizes (see
https://issues.redhat.com
capacity=614400
$ vdpa dev add mgmtdev vdpasim_blk name blk0
virtio_blk virtio6: 1/0/0 default/read/poll queues
virtio_blk virtio6: [vdb] 614400 512-byte logical blocks (315 MB/300 MiB)
Signed-off-by: Stefano Garzarella
---
drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 25 +
1
On Mon, Jul 01, 2024 at 04:28:03PM GMT, Luigi Leonardi via B4 Relay wrote:
From: Marco Pinna
Introduce an optimization in virtio_transport_send_pkt:
when the work queue (send_pkt_queue) is empty the packet is
put directly in the virtqueue reducing latency.
In the following benchmark (pingpong
On Mon, Jul 01, 2024 at 04:49:41PM GMT, Luigi Leonardi wrote:
Hi all,
+ /* Inside RCU, can't sleep! */
+ ret = mutex_trylock(>tx_lock);
+ if (unlikely(ret == 0))
+ goto out_worker;
I just realized that here I don't release the
On Mon, Jul 01, 2024 at 04:28:02PM GMT, Luigi Leonardi via B4 Relay wrote:
From: Marco Pinna
Preliminary patch to introduce an optimization to the
enqueue system.
All the code used to enqueue a packet into the virtqueue
is removed from virtio_transport_send_pkt_work()
and moved to the new
Hi Arseniy,
On Fri, Jun 21, 2024 at 10:25:40PM GMT, Arseniy Krasnov wrote:
Previous calculation of 'free_space' was wrong (but worked as expected
in most cases, see below), because it didn't account number of bytes in
rx queue. Let's rework 'free_space' calculation in the following way:
as this
On Wed, Jun 26, 2024 at 02:08:36PM GMT, Luigi Leonardi via B4 Relay wrote:
From: Luigi Leonardi
Introduce support for stream_bytes_unsent and seqpacket_bytes_unsent
ioctl for virtio_transport, vhost_vsock and vsock_loopback.
For all transports the unsent bytes counter is incremented
in
nit: in theory in this patch we don't support it for any of the
transports, so I wouldn't confuse and take that part out of the title.
WDYT with someting like:
vsock: add support for SIOCOUTQ ioctl
On Wed, Jun 26, 2024 at 02:08:35PM GMT, Luigi Leonardi via B4 Relay
wrote:
From: Luigi
On Fri, Jun 21, 2024 at 10:25:40PM GMT, Arseniy Krasnov wrote:
Previous calculation of 'free_space' was wrong (but worked as expected
in most cases, see below), because it didn't account number of bytes in
rx queue. Let's rework 'free_space' calculation in the following way:
as this value is
Hi,
thanks for this RFC!
On Fri, May 17, 2024 at 10:46:02PM GMT, Xuewei Niu wrote:
# Motivition
Vsock is a lightweight and widely used data exchange mechanism between host
and guest. Kata Containers, a secure container runtime, leverages the
capability to exchange control data between the shim
On Fri, May 17, 2024 at 10:46:07PM GMT, Xuewei Niu wrote:
The new request is called `IOCTL_VM_SOCKETS_GET_LOCAL_CIDS`. And the old
one, `IOCTL_VM_SOCKETS_GET_LOCAL_CID` is retained.
For the transport that supports multi-devices:
* `IOCTL_VM_SOCKETS_GET_LOCAL_CID` returns "-1";
What about
On Fri, May 17, 2024 at 10:46:06PM GMT, Xuewei Niu wrote:
Adds a new argument, named "src_cid", to let them know which `virtio_vsock`
to be selected.
Signed-off-by: Xuewei Niu
---
include/net/af_vsock.h | 2 +-
net/vmw_vsock/af_vsock.c | 15 +--
On Fri, May 17, 2024 at 10:46:05PM GMT, Xuewei Niu wrote:
Adds a new argument, named "cid", to let them know which `virtio_vsock` to
be selected.
Signed-off-by: Xuewei Niu
---
include/linux/virtio_vsock.h| 2 +-
net/vmw_vsock/virtio_transport.c| 5 ++---
On Fri, May 17, 2024 at 10:46:04PM GMT, Xuewei Niu wrote:
The maximum number of devices is limited by `MAX_VSOCK_NUM`.
Extends `vsock_transport` struct with 4 methods to support multi-devices:
* `get_virtio_vsock()`: It receives a CID, and returns a struct of virtio
vsock. This method is
As Alyssa suggested, we should discuss spec changes in the virtio ML.
BTW as long as this is an RFC, it's fine. Just be sure, though, to
remember to merge the change in the specification first versus the
patches in Linux.
So I recommend that you don't send a non-RFC set into Linux until you
ov
Tested-by: Arseniy Krasnov
---
Reposting now it's been tested.
drivers/vhost/vsock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for fixing this issue!
Reviewed-by: Stefano Garzarella
ernels with this yet, right?
(other than v6.9-rc*)
LGTM:
Reviewed-by: Stefano Garzarella
include/uapi/linux/vhost.h | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
index bea697390613..b95dd84eef2d 10064
er calling virtqueue_add_sgs()
and making sure it returned successfully.
Fixes: 82dfb540aeb2 ("VSOCK: Add virtio vsock vsockmon hooks")
Cc: sta...@vge.kernel.org
Signed-off-by: Marco Pinna
---
net/vmw_vsock/virtio_transport.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
: Yihuang Yu
Suggested-by: Will Deacon
Signed-off-by: Gavin Shan
Acked-by: Jason Wang
---
drivers/vhost/vhost.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
Thanks for fixing this!
Reviewed-by: Stefano Garzarella
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vho
: Yihuang Yu
Suggested-by: Will Deacon
Signed-off-by: Gavin Shan
Acked-by: Jason Wang
---
drivers/vhost/vhost.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 045f666b4f
On Mon, Mar 25, 2024 at 06:12:38PM +0100, Marco Pinna wrote:
Commit 82dfb540aeb2 ("VSOCK: Add virtio vsock vsockmon hooks") added
virtio_transport_deliver_tap_pkt() for handing packets to the
vsockmon device. However, in virtio_transport_send_pkt_work(),
the function is called before actually
On Wed, Mar 20, 2024 at 06:19:12PM +0800, Wang Rong wrote:
From: Rong Wang
Once enable iommu domain for one device, the MSI
translation tables have to be there for software-managed MSI.
Otherwise, platform with software-managed MSI without an
irq bypass function, can not get a correct memory
ons(-)
Reviewed-by: Stefano Garzarella
diff --git a/drivers/net/vsockmon.c b/drivers/net/vsockmon.c
index a0b4dca36baf..a1ba5169ed5d 100644
--- a/drivers/net/vsockmon.c
+++ b/drivers/net/vsockmon.c
@@ -46,9 +46,6 @@ static void
vsockmon_get_stats64(struct net_device *dev, struct rtnl_link_stat
1 file changed, 1 insertion(+), 15 deletions(-)
Thanks for this patch!
Reviewed-by: Stefano Garzarella
diff --git a/drivers/net/vsockmon.c b/drivers/net/vsockmon.c
index b1bb1b04b664..a0b4dca36baf 100644
--- a/drivers/net/vsockmon.c
+++ b/drivers/net/vsockmon.c
@@ -13,19 +1
On Wed, Feb 07, 2024 at 11:27:14AM +0800, Jason Wang wrote:
On Tue, Feb 6, 2024 at 10:52 PM Stefano Garzarella wrote:
If VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK is not negotiated, we expect
the driver to enable virtqueue before setting DRIVER_OK. If the driver
tries anyway, better to fail
On Tue, Feb 06, 2024 at 10:56:50AM -0500, Michael S. Tsirkin wrote:
better @subj: try late vq enable only if negotiated
I rewrote it 3/4 times, and before sending it I was not happy with the
result.
Thank you, much better! I'll change it in v2.
Stefano
for not meeting this requirement, see
https://lore.kernel.org/qemu-devel/20240202132521.32714-1-kw...@redhat.com/
Fixes: 9f09fd6171fe ("vdpa: accept VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK
backend feature")
Cc: epere...@redhat.com
Signed-off-by: Stefano Garzarella
---
include/uapi/linux/vho
!
Reviewed-by: Stefano Garzarella
diff --git a/tools/testing/vsock/vsock_diag_test.c
b/tools/testing/vsock/vsock_diag_test.c
index 5e6049226b77..17aeba7cbd14 100644
--- a/tools/testing/vsock/vsock_diag_test.c
+++ b/tools/testing/vsock/vsock_diag_test.c
@@ -39,6 +39,8 @@ static const char
will be '1234' - thus we preserve previous
behaviour.
Signed-off-by: Arseniy Krasnov
---
Changelog:
v1 -> v2:
* Reword usage message.
* Add commas after last field in 'opts' declaration.
* 'RFC' -> 'net-next'.
Thanks for the changes, LGTM!
Reviewed-by: Stefano Garzarella
tools/t
On Mon, Jan 22, 2024 at 11:47:22AM +0100, Eugenio Perez Martin wrote:
On Mon, Jan 22, 2024 at 11:22 AM Stefano Garzarella wrote:
On Wed, Jan 17, 2024 at 11:23:23AM -0800, Steve Sistare wrote:
>vdpasim_do_reset sets running to true, which is wrong, as it allows
>vdpasim_kick_vq to pos
On Wed, Jan 17, 2024 at 11:23:23AM -0800, Steve Sistare wrote:
vdpasim_do_reset sets running to true, which is wrong, as it allows
vdpasim_kick_vq to post work requests before the device has been
configured. To fix, do not set running until VIRTIO_CONFIG_S_FEATURES_OK
is set.
Fixes:
Hi Arseniy,
thanks for this patch!
On Sat, Jan 13, 2024 at 12:21:10AM +0300, Arseniy Krasnov wrote:
Implement port for given CID as input argument instead of using
hardcoded value '1234'. This allows to run different test instances
on a single CID. Port argument is not required parameter and if
-off-by: Mina Almasry
---
v2:
- Also fix skb_frag_off() + skb_frag_size() (David)
- Did not apply the reviewed-by from Stefano since the patch changed
relatively much.
Sorry for the delay, I was off.
LGTM!
Acked-by: Stefano Garzarella
Possibly we can also send this patch alone if the series
sender to send more data. Otherwise mutual hungup
for tx/rx is possible: sender waits for free space and receiver is
waiting data in 'poll()'.
Fixes: b89d882dc9fc ("vsock/virtio: reduce credit update messages")
Signed-off-by: Arseniy Krasnov
Reviewed-by: Stefano Garzarella
Acked-by:
r option a. BTW that
forces us to backport more patches on stable branches, so I'm fine with
option b as well.
That said:
Nacked-by: Stefano Garzarella
On Wed, Dec 13, 2023 at 08:11:57PM +0300, Arseniy Krasnov wrote:
On 13.12.2023 18:13, Michael S. Tsirkin wrote:
On Wed, Dec 13, 2023 at 10:05:44AM -0500, Michael S. Tsirkin wrote:
On Wed, Dec 13, 2023 at 12:08:27PM +0300, Arseniy Krasnov wrote:
On 13.12.2023 11:43, Stefano Garzarella
On Wed, Dec 13, 2023 at 12:08:27PM +0300, Arseniy Krasnov wrote:
On 13.12.2023 11:43, Stefano Garzarella wrote:
On Tue, Dec 12, 2023 at 08:43:07PM +0300, Arseniy Krasnov wrote:
On 12.12.2023 19:12, Michael S. Tsirkin wrote:
On Tue, Dec 12, 2023 at 06:59:03PM +0300, Arseniy Krasnov wrote
On Tue, Dec 12, 2023 at 08:43:07PM +0300, Arseniy Krasnov wrote:
On 12.12.2023 19:12, Michael S. Tsirkin wrote:
On Tue, Dec 12, 2023 at 06:59:03PM +0300, Arseniy Krasnov wrote:
On 12.12.2023 18:54, Michael S. Tsirkin wrote:
On Tue, Dec 12, 2023 at 12:16:54AM +0300, Arseniy Krasnov wrote:
| 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
Reviewed-by: Stefano Garzarella
Thanks!
Stefano
diff --git a/net/vmw_vsock/virtio_transport_common.c
b/net/vmw_vsock/virtio_transport_common.c
index e137d740804e..8572f94bba88 100644
--- a/net/vmw_vsock/virtio_transport_co
;)
Signed-off-by: Nikolay Kuratov
---
V1 -> V2: Added Fixes section
Please, next time carry also R-b tags.
net/vmw_vsock/virtio_transport_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella
Thanks,
Stefano
diff --git a/net/vmw_vsock/virtio_tr
So yes, we need to fix it!
Thanks!
Reviewed-by: Stefano Garzarella
if (bytes < 0)
bytes = 0;
--
2.34.1
changed, 34 insertions(+)
Reviewed-by: Stefano Garzarella
diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index f75731396b7e..ec20ecff85c7 100644
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -449,6 +449,7 @@ static struct virtio_transport vho
On Thu, Dec 07, 2023 at 01:50:05AM +0300, Arseniy Krasnov wrote:
On 07.12.2023 01:08, Michael S. Tsirkin wrote:
On Thu, Dec 07, 2023 at 12:52:51AM +0300, Arseniy Krasnov wrote:
On 07.12.2023 00:53, Michael S. Tsirkin wrote:
On Thu, Dec 07, 2023 at 12:18:48AM +0300, Arseniy Krasnov wrote:
581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY flag support")
Cc: avkras...@salutedevices.com
Signed-off-by: Stefano Garzarella
---
net/vmw_vsock/virtio_transport_common.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/vmw_vsock/virtio_transport_common.c
b/net/vmw_
On Tue, Dec 05, 2023 at 03:07:47PM +0300, Arseniy Krasnov wrote:
On 05.12.2023 13:54, Stefano Garzarella wrote:
On Tue, Dec 05, 2023 at 09:48:05AM +0300, Arseniy Krasnov wrote:
Add one more condition for sending credit update during dequeue from
stream socket: when number of bytes in the rx
se 'recv_buf(MSG_DONTWAIT)' instead of 'recv(MSG_DONTWAIT)'.
v5 -> v6:
* Add second test which checks, that credit update is sent during
reading data from socket.
* Update commit message.
tools/testing/vsock/vsock_test.c | 175 +++
1 file changed, 175 insertions(+)
Revie
On Tue, Dec 05, 2023 at 09:48:05AM +0300, Arseniy Krasnov wrote:
Add one more condition for sending credit update during dequeue from
stream socket: when number of bytes in the rx queue is smaller than
SO_RCVLOWAT value of the socket. This is actual for non-default value
of SO_RCVLOWAT (e.g. not
On Sat, Dec 02, 2023 at 03:22:39PM -0500, Michael S. Tsirkin wrote:
On Fri, Dec 01, 2023 at 01:40:41PM +0300, Arseniy Krasnov wrote:
On 01.12.2023 12:48, Stefano Garzarella wrote:
> On Fri, Dec 01, 2023 at 11:35:56AM +0300, Arseniy Krasnov wrote:
>>
>>
>> On 01.1
On Fri, Dec 01, 2023 at 11:35:56AM +0300, Arseniy Krasnov wrote:
On 01.12.2023 11:27, Stefano Garzarella wrote:
On Thu, Nov 30, 2023 at 12:40:43PM -0500, Michael S. Tsirkin wrote:
On Thu, Nov 30, 2023 at 03:11:19PM +0100, Stefano Garzarella wrote:
On Thu, Nov 30, 2023 at 08:58:58AM -0500
On Thu, Nov 30, 2023 at 12:40:43PM -0500, Michael S. Tsirkin wrote:
On Thu, Nov 30, 2023 at 03:11:19PM +0100, Stefano Garzarella wrote:
On Thu, Nov 30, 2023 at 08:58:58AM -0500, Michael S. Tsirkin wrote:
> On Thu, Nov 30, 2023 at 04:43:34PM +0300, Arseniy Krasnov wr
On Thu, Nov 30, 2023 at 04:08:40PM +0300, Arseniy Krasnov wrote:
Test which checks, that updating SO_RCVLOWAT value also sends credit
update message. Otherwise mutual hungup may happen when receiver didn't
send credit update and then calls 'poll()' with non default SO_RCVLOWAT
value (e.g.
_rcvlowat = virtio_transport_notify_set_rcvlowat
As we discussed in chat, better the order of the previous version, but
leaving the line of `.read_skb` untouched (with the final comma).
With that fixed in all transports, feel free to add:
Reviewed-by: Stefano Garzarella
},
On Thu, Nov 30, 2023 at 12:25:19AM +0300, Arseniy Krasnov wrote:
Test which checks, that updating SO_RCVLOWAT value also sends credit
update message. Otherwise mutual hungup may happen when receiver didn't
send credit update and then calls 'poll()' with non default SO_RCVLOWAT
value (e.g.
On Thu, Nov 30, 2023 at 12:25:18AM +0300, Arseniy Krasnov wrote:
Send credit update message when SO_RCVLOWAT is updated and it is bigger
than number of bytes in rx queue. It is needed, because 'poll()' will
wait until number of bytes in rx queue will be not smaller than
SO_RCVLOWAT, so kick
On Wed, Nov 29, 2023 at 12:16:54PM +0300, Arseniy Krasnov wrote:
On 29.11.2023 12:16, Stefano Garzarella wrote:
On Wed, Nov 22, 2023 at 09:05:10PM +0300, Arseniy Krasnov wrote:
Test which checks, that updating SO_RCVLOWAT value also sends credit
update message. Otherwise mutual hungup may
On Wed, Nov 22, 2023 at 09:05:10PM +0300, Arseniy Krasnov wrote:
Test which checks, that updating SO_RCVLOWAT value also sends credit
update message. Otherwise mutual hungup may happen when receiver didn't
send credit update and then calls 'poll()' with non default SO_RCVLOWAT
value (e.g.
On Wed, Nov 22, 2023 at 09:05:09PM +0300, Arseniy Krasnov wrote:
Send credit update message when SO_RCVLOWAT is updated and it is bigger
than number of bytes in rx queue. It is needed, because 'poll()' will
wait until number of bytes in rx queue will be not smaller than
SO_RCVLOWAT, so kick
quot;)
Signed-off-by: Arseniy Krasnov
---
tools/testing/vsock/vsock_test.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
The fix LGTM and it worked on aarch64 machine.
Reviewed-by: Stefano Garzarella
Thanks for the fast fix!
Stefano
diff --git a/tools/
On Fri, Nov 17, 2023 at 10:12:38AM +0300, Arseniy Krasnov wrote:
On 15.11.2023 14:11, Stefano Garzarella wrote:
On Wed, Nov 08, 2023 at 10:20:04AM +0300, Arseniy Krasnov wrote:
This adds test which checks, that updating SO_RCVLOWAT value also sends
You can avoid "This adds", and
On Wed, Nov 08, 2023 at 10:20:04AM +0300, Arseniy Krasnov wrote:
This adds test which checks, that updating SO_RCVLOWAT value also sends
You can avoid "This adds", and write just "Add test ...".
See
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
Describe
On Wed, Nov 08, 2023 at 10:20:03AM +0300, Arseniy Krasnov wrote:
This adds sending credit update message when SO_RCVLOWAT is updated and
it is bigger than number of bytes in rx queue. It is needed, because
'poll()' will wait until number of bytes in rx queue will be not smaller
than SO_RCVLOWAT,
On Wed, Nov 08, 2023 at 10:20:02AM +0300, Arseniy Krasnov wrote:
Hello,
DESCRIPTION
This patchset fixes old problem with hungup of both rx/tx sides and adds
test for it. This happens due to non-default SO_RCVLOWAT value and
deferred credit update in virtio/vsock.
ring the socket release")
Reported-and-tested-by: syzbot+24452624fc4c571ee...@syzkaller.appspotmail.com
Signed-off-by: Stefano Garzarella
---
net/vmw_vsock/virtio_transport_common.c | 28 +
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/net/vmw_vsock/virti
On Fri, Apr 16, 2021 at 12:06:18PM +, Jorgen Hansen wrote:
On 16 Apr 2021, at 12:44, Stefano Garzarella
mailto:sgarz...@redhat.com>> wrote:
VMCI feature is not supported in conjunction with the vSphere Fault
Tolerance (FT) feature.
VMware Tools can repeatedly try to create a
es, print it only once.
Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
Signed-off-by: Stefano Garzarella
---
net/vmw_vsock/vmci_transport.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c
index 8b6
-by: Stefano Garzarella
diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
index 376b2014916a..3b6f7862dbb8 100644
--- a/drivers/vdpa/ifcvf/ifcvf_main.c
+++ b/drivers/vdpa/ifcvf/ifcvf_main.c
@@ -356,7 +356,24 @@ static u32 ifcvf_vdpa_get_vq_align(struct vdpa_device
*vdpa_dev
insertions(+), 2 deletions(-)
Reviewed-by: Stefano Garzarella
diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdpa/ifcvf/ifcvf_base.h
index 1c04cd256fa7..0111bfdeb342 100644
--- a/drivers/vdpa/ifcvf/ifcvf_base.h
+++ b/drivers/vdpa/ifcvf/ifcvf_base.h
@@ -15,6 +15,7 @@
#include
#include
On Thu, Apr 15, 2021 at 05:53:36PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git
On Thu, Apr 15, 2021 at 05:53:35PM +0800, Zhu Lingshan wrote:
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block
for vDPA.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_base.h | 8 +++-
drivers/vdpa/ifcvf/ifcvf_main.c | 10 +-
2 files changed, 16
On Wed, Apr 14, 2021 at 05:18:32PM +0800, Zhu Lingshan wrote:
get_config_size() should return the size based on the decected
device type.
Signed-off-by: Zhu Lingshan
---
drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git
On Tue, Apr 13, 2021 at 12:12:50PM +, Jorgen Hansen wrote:
On 12 Apr 2021, at 20:53, Jiang Wang .
mailto:jiang.w...@bytedance.com>> wrote:
On Mon, Apr 12, 2021 at 7:04 AM Stefano Garzarella
mailto:sgarz...@redhat.com>> wrote:
Hi Jiang,
thanks for re-starting the multi-trans
.25533db01f5f 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -2089,7 +2089,7 @@ static int mlx5v_probe(struct auxiliary_device *adev,
return 0;
reg_err:
- kfree(mdev);
+ kfree(mgtdev);
return err;
}
--
2.30.2
Reviewed-by: Stefano Garzarella
Hi Jiang,
thanks for re-starting the multi-transport support for dgram!
On Wed, Apr 07, 2021 at 11:25:36AM -0700, Jiang Wang . wrote:
On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote:
> On 6 Apr 2021, at 20:31, Jiang Wang wrote:
>
> From: "jiang.wang"
>
> Currently, only VMCI supports
Hi Michael,
do you think this series is in an acceptable state to be queued for the
next merge window?
All patches should be already acked by Jason, let me know if I need to
change anything.
Thanks,
Stefano
On Mon, Mar 15, 2021 at 05:34:36PM +0100, Stefano Garzarella wrote:
v4:
- added
On Wed, Mar 31, 2021 at 10:04:18AM +0100, Stefan Hajnoczi wrote:
On Mon, Feb 08, 2021 at 08:39:30AM -0800, syzbot wrote:
Hello,
syzbot found the following issue on:
HEAD commit:9f29bd8b Merge tag 'fs_for_v5.11-rc5' of git://git.kernel...
git tree: upstream
console output:
On Thu, Mar 25, 2021 at 08:02:45AM -0600, Jens Axboe wrote:
On 3/25/21 7:44 AM, Pavel Begunkov wrote:
On 25/03/2021 11:33, Stefano Garzarella wrote:
Hi Jens, Hi Pavel,
I was taking a look at the new SQPOLL handling with io_thread instead of
kthread. Great job! Really nice feature that maybe
Hi Jens, Hi Pavel,
I was taking a look at the new SQPOLL handling with io_thread instead of
kthread. Great job! Really nice feature that maybe can be reused also in
other scenarios (e.g. vhost).
Regarding SQPOLL, IIUC these new threads are much closer to user
threads, so is there still a
Hi Arseny,
On Tue, Mar 23, 2021 at 04:07:13PM +0300, Arseny Krasnov wrote:
This patchset implements support of SOCK_SEQPACKET for virtio
transport.
As SOCK_SEQPACKET guarantees to save record boundaries, so to
do it, two new packet operations were added: first for start of
On Tue, Mar 23, 2021 at 04:14:33PM +0300, Arseny Krasnov wrote:
This adds SEQPACKET ops for loopback transport and 'seqpacket_allow()'
callback.
Signed-off-by: Arseny Krasnov
---
net/vmw_vsock/vsock_loopback.c | 12
1 file changed, 12 insertions(+)
Reviewed-by: Stefano
On Tue, Mar 23, 2021 at 04:14:18PM +0300, Arseny Krasnov wrote:
This also removes ignore of non-stream type of packets and adds
'seqpacket_allow()' callback.
Signed-off-by: Arseny Krasnov
---
drivers/vhost/vsock.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
Same
On Tue, Mar 23, 2021 at 04:14:03PM +0300, Arseny Krasnov wrote:
This adds SEQPACKET ops for virtio transport and 'seqpacket_allow()'
callback.
Signed-off-by: Arseny Krasnov
---
net/vmw_vsock/virtio_transport.c | 12
1 file changed, 12 insertions(+)
Sorry for not mentioning this
On Tue, Mar 23, 2021 at 04:13:49PM +0300, Arseny Krasnov wrote:
This adds new virtio vsock specific feature bit which means
SOCK_SEQPACKET support. Guest negotiates this bit with vhost,
thus checking that vhost side supports SEQPACKET.
Signed-off-by: Arseny Krasnov
---
On Tue, Mar 23, 2021 at 04:13:29PM +0300, Arseny Krasnov wrote:
This adds rest of logic for SEQPACKET:
1) SEQPACKET specific functions which send SEQ_BEGIN/SEQ_END.
Note that both functions may sleep to wait enough space for
SEQPACKET header.
2) SEQ_BEGIN/SEQ_END in TAP packet capture.
3)
64 +
1 file changed, 45 insertions(+), 19 deletions(-)
Reviewed-by: Stefano Garzarella
On Tue, Mar 23, 2021 at 04:12:55PM +0300, Arseny Krasnov wrote:
This adds transport callback which tries to fetch record begin marker
from socket's rx queue. It is called from af_vsock.c before reading data
packets of record.
Signed-off-by: Arseny Krasnov
---
v6 -> v7:
1) Now
On Tue, Mar 23, 2021 at 04:12:41PM +0300, Arseny Krasnov wrote:
This adds transport callback and it's logic for SEQPACKET dequeue.
Callback fetches RW packets from rx queue of socket until whole record
is copied(if user's buffer is full, user is not woken up). This is done
to not stall sender,
17 insertions(+), 6 deletions(-)
Reviewed-by: Stefano Garzarella
1 - 100 of 711 matches
Mail list logo
