Re: [PATCH 01/10] appletalk: remove localtalk and ppp support

2023-10-09 Thread Stephen Hemminger
On Mon, 9 Oct 2023 18:49:43 +0200 Rodolfo Zitellini wrote: > Hi! > I’ve been working on a new LocalTalk interface driver for the last couple > months, do you think it would be possible to at least postpone the removal of > LT a bit? > > It is a driver for an open source device called TashTalk

Re: [PATCH v8 net-next 2/2] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-19 Thread Stephen Hemminger
f-by: Shachar Raindel > Signed-off-by: Dexuan Cui Reviewed-by: Stephen Hemminger

Re: [PATCH v8 net-next 1/2] hv_netvsc: Make netvsc/VF binding check both MAC and serial number

2021-04-19 Thread Stephen Hemminger
he netvsc network > interface and the VF network interface have the same MAC address. > > Co-developed-by: Haiyang Zhang > Signed-off-by: Haiyang Zhang > Co-developed-by: Shachar Raindel > Signed-off-by: Shachar Raindel > Signed-off-by: Dexuan Cui Acked-by: Stephen Hemminger

Re: [PATCH v7 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-16 Thread Stephen Hemminger
On Fri, 16 Apr 2021 17:58:45 + Dexuan Cui wrote: > > > > > > This probably should be a separate patch. > > > I think it is trying to address the case of VF discovery in Hyper-V/Azure > > > where > > > the reported > > > VF from Hypervisor is bogus or confused. > > > > This is for the

Re: [PATCH v7 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-16 Thread Stephen Hemminger
On Thu, 15 Apr 2021 23:07:05 -0700 Dexuan Cui wrote: > diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c > index 7349a70af083..f682a5572d84 100644 > --- a/drivers/net/hyperv/netvsc_drv.c > +++ b/drivers/net/hyperv/netvsc_drv.c > @@ -2297,6 +2297,7 @@ static struct

Re: [PATCH v6 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-15 Thread Stephen Hemminger
On Wed, 14 Apr 2021 22:45:19 -0700 Dexuan Cui wrote: > +static int mana_probe_port(struct mana_context *ac, int port_idx, > +struct net_device **ndev_storage) > +{ > + struct gdma_context *gc = ac->gdma_dev->gdma_context; > + struct mana_port_context *apc; > +

Re: [PATCH v6 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-15 Thread Stephen Hemminger
On Wed, 14 Apr 2021 22:45:19 -0700 Dexuan Cui wrote: > +static int mana_query_vport_cfg(struct mana_port_context *apc, u32 > vport_index, > + u32 *max_sq, u32 *max_rq, u32 *num_indir_entry) > +{ > + struct mana_query_vport_cfg_resp resp = {}; > + struct

Re: [Resend RFC PATCH V2 08/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-14 Thread Stephen Hemminger
On Wed, 14 Apr 2021 17:45:51 +0200 Greg KH wrote: > On Wed, Apr 14, 2021 at 10:49:41AM -0400, Tianyu Lan wrote: > > From: Tianyu Lan > > > > UIO HV driver should not load in the isolation VM for security reason. > > Return ENOTSUPP in the hv_uio_probe() in the isolation VM. > > > >

Re: [PATCH net-next] net: Space: remove hp100 probe

2021-04-13 Thread Stephen Hemminger
On Tue, 13 Apr 2021 16:16:17 +0200 Arnd Bergmann wrote: > From: Arnd Bergmann > > The driver was removed last year, but the static initialization got left > behind by accident. > > Fixes: a10079c66290 ("staging: remove hp100 driver") > Signed-off-by: Arnd Bergmann > --- >

Re: [PATCH RFC iproute2-next] iplink: allow to change iplink value

2021-04-11 Thread Stephen Hemminger
On Sat, 10 Apr 2021 15:34:50 +0200 Ansuel Smith wrote: > Allow to change the interface to which a given interface is linked to. > This is useful in the case of multi-CPU port DSA, for changing the CPU > port of a given user port. > > Signed-off-by: Marek Behún > Cc: David Ah

Re: [PATCH v3 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Stephen Hemminger
On Thu, 8 Apr 2021 15:58:40 -0700 Dexuan Cui wrote: > Add a VF driver for Microsoft Azure Network Adapter (MANA) that will be > available in the future. > > Co-developed-by: Haiyang Zhang > Signed-off-by: Haiyang Zhang > Signed-off-by: Dexuan Cui > --- > MAINTAINERS

Re: [PATCH v2 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Stephen Hemminger
On Thu, 8 Apr 2021 09:22:57 -0700 Randy Dunlap wrote: > On 4/8/21 2:15 AM, Dexuan Cui wrote: > > diff --git a/drivers/net/ethernet/microsoft/Kconfig > > b/drivers/net/ethernet/microsoft/Kconfig > > new file mode 100644 > > index ..12ef6b581566 > > --- /dev/null > > +++

Re: Kconfig, DEFAULT_NETSCH, and shooting yourself in the foot..

2021-01-03 Thread Stephen Hemminger
On Sun, 3 Jan 2021 15:30:30 +0900 Masahiro Yamada wrote: > On Sun, Jan 3, 2021 at 5:14 AM Valdis Klētnieks > wrote: > > > > Consider the following own goal I just discovered I scored: > > > > [~] zgrep -i fq_codel /proc/config.gz > > CONFIG_NET_SCH_FQ_CODEL=m > > CONFIG_DEFAULT_FQ_CODEL=y > >

[ANNOUNCE] iproute2-5.10

2020-12-20 Thread Stephen Hemminger
dge: mdb: print source list when available bridge: mdb: print protocol when available Parav Pandit (2): devlink: Show external port attribute devlink: Show controller number of a devlink port Roopa Prabhu (1): iplink: add support for protodown reason Stephen Hemminger

Re: [PATCH v3 4/6] drivers: hv: vmbus: Fix checkpatch SPLIT_STRING

2020-11-29 Thread Stephen Hemminger
On Sun, 29 Nov 2020 08:51:47 -0800 "Michael Kelley" wrote: > From: Matheus Castello Sent: Tuesday, November > 24, 2020 7:29 PM > > > > Checkpatch emits WARNING: quoted string split across lines. > > To keep the code clean and with the 80 column length indentation the > > check and registration

Re: [PATCH v2] netem: fix zero division in tabledist

2020-10-28 Thread Stephen Hemminger
INT_MAX]. As negative std > deviation makes no sense, take the absolute value of the passed value > and cap it at INT_MAX. Inside tabledist(), switch to unsigned 32 bit > arithmetic in order to prevent overflows. > > Signed-off-by: Aleksandr Nogikh > Reported-by: syzbot+ec762a6342ad0d3c0...@syzkaller.appspotmail.com Acked-by: Stephen Hemminger

Re: [Bridge] [PATCH net-next v7 01/10] net: bridge: extend the process of special frames

2020-10-27 Thread Stephen Hemminger
On Tue, 27 Oct 2020 10:02:42 + Henrik Bjoernlund via Bridge wrote: > +/* Return 0 if the frame was not processed otherwise 1 > + * note: already called with rcu_read_lock > + */ > +static int br_process_frame_type(struct net_bridge_port *p, > + struct sk_buff

Re: [RFC PATCH iproute2] bridge: add support for L2 multicast groups

2020-10-22 Thread Stephen Hemminger
On Sat, 17 Oct 2020 21:45:26 +0300 Vladimir Oltean wrote: > Extend the 'bridge mdb' command for the following syntax: > bridge mdb add dev br0 port swp0 grp 01:02:03:04:05:06 permanent > > Signed-off-by: Vladimir Oltean > --- > bridge/mdb.c | 54

Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Reduce indentation in pvc_xmit

2020-10-03 Thread Stephen Hemminger
On Sat, 3 Oct 2020 10:35:28 -0700 Xie He wrote: > + if (dev->type == ARPHRD_ETHER) { > + int pad = ETH_ZLEN - skb->len; > + > + if (pad > 0) { /* Pad the frame with zeros */ > + int len = skb->len; > + > + if (skb_tailroom(skb)

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-02 Thread Stephen Hemminger
On Fri, 2 Oct 2020 16:23:46 -0400 Jarod Wilson wrote: > On Fri, Oct 2, 2020 at 3:13 PM Stephen Hemminger > wrote: > > > > On Fri, 2 Oct 2020 13:40:01 -0400 > > Jarod Wilson wrote: > > > > > By default, enable retaining all user-facing API that inc

Re: [PATCH net-next v2 6/6] bonding: make Kconfig toggle to disable legacy interfaces

2020-10-02 Thread Stephen Hemminger
On Fri, 2 Oct 2020 13:40:01 -0400 Jarod Wilson wrote: > By default, enable retaining all user-facing API that includes the use of > master and slave, but add a Kconfig knob that allows those that wish to > remove it entirely do so in one shot. > > Cc: Jay Vosburgh > Cc: Veaceslav Falico >

Re: [PATCH net-next v2 5/6] bonding: update Documentation for port/bond terminology

2020-10-02 Thread Stephen Hemminger
On Fri, 2 Oct 2020 13:40:00 -0400 Jarod Wilson wrote: > @@ -265,7 +265,7 @@ ad_user_port_key > This parameter has effect only in 802.3ad mode and is available through > SysFs interface. > > -all_slaves_active > +all_ports_active You can change internal variable names, comments,

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread Stephen Hemminger
On Tue, 22 Sep 2020 16:47:07 -0700 Jay Vosburgh wrote: > Stephen Hemminger wrote: > > >On Tue, 22 Sep 2020 09:37:30 -0400 > >Jarod Wilson wrote: > > > >> By default, enable retaining all user-facing API that includes the use of > >> master and slave

Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

2020-09-22 Thread Stephen Hemminger
On Tue, 22 Sep 2020 09:37:30 -0400 Jarod Wilson wrote: > By default, enable retaining all user-facing API that includes the use of > master and slave, but add a Kconfig knob that allows those that wish to > remove it entirely do so in one shot. > > Cc: Jay Vosburgh > Cc: Veaceslav Falico >

Re: [PATCH v3] net: use exponential backoff in netdev_wait_allrefs

2020-09-17 Thread Stephen Hemminger
On Thu, 17 Sep 2020 16:49:53 -0700 frugg...@arista.com (Francesco Ruggeri) wrote: > The combination of aca_free_rcu, introduced in commit 2384d02520ff > ("net/ipv6: Add anycast addresses to a global hashtable"), and > fib6_info_destroy_rcu, introduced in commit 9b0a8da8c4c6 ("net/ipv6: > respect

Re: [PATCH RFC 0/7] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-09-04 Thread Stephen Hemminger
On Fri, 4 Sep 2020 09:15:20 + Henrik Bjoernlund wrote: > Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. > > Connectivity Fault Management (CFM) comprises capabilities for > detecting, verifying, and isolating connectivity failures in > Virtual Bridged Networks.

Re: [PATCH v3] net: Use standardized (IANA) local port range

2020-08-28 Thread Stephen Hemminger
On Fri, 28 Aug 2020 22:44:47 +0200 Bart Groeneveld wrote: > IANA specifies User ports as 1024-49151, > and Private ports (local/ephemeral/dynamic/w/e) as 49152-65535 [1]. > > This means Linux uses 32768-49151 'illegally'. > This is not just a matter of following specifications: > IANA actually

Re: [PATCH iproute2 v5 0/2] iplink: hsr: add support for creating PRP device

2020-08-22 Thread Stephen Hemminger
On Mon, 17 Aug 2020 17:17:35 -0400 Murali Karicheri wrote: > This series enhances the iproute2 iplink module to add support > for creating PRP device similar to HSR. The kernel part of this > is already merged to v5.9 master > > v4 - addressed comment from Stephen Hemminger

Re: [net-next iproute2 PATCH v4 1/2] iplink: hsr: add support for creating PRP device similar to HSR

2020-08-16 Thread Stephen Hemminger
On Thu, 6 Aug 2020 16:37:11 -0400 Murali Karicheri wrote: > + > + print_int(PRINT_ANY, > + "proto", > + "proto %d ", > + rta_getattr_u8(tb[IFLA_HSR_PROTOCOL])); Since this unsigned value, you probably want to

[ANNOUNCE] iproute2 5.8

2020-08-07 Thread Stephen Hemminger
gate action man page Roi Dayan (1): ip address: Fix loop initial declarations are only allowed in C99 Roman Mashak (1): tc: report time an action was first used Sorah Fukumori (1): ip fou: respect preferred_family for IPv6 Stephen Hemminger (11): uapi: update headers

RE: [PATCH] hv_utils: Add validation for untrusted Hyper-V values

2020-07-29 Thread Stephen Hemminger
Ok at least use the ratelimit form of kernel logging. Netdev_err_ratelimited... -Original Message- From: Andres Beltran Sent: Wednesday, July 29, 2020 9:10 AM To: Stephen Hemminger Cc: KY Srinivasan ; Haiyang Zhang ; Wei Liu ; linux-hyp...@vger.kernel.org; linux-kernel

Re: [PATCH] Drivers: hv: vmbus: Fix variable assignments in hv_ringbuffer_read()

2020-07-24 Thread Stephen Hemminger
On Fri, 24 Jul 2020 09:46:06 -0700 "Andres Beltran" wrote: > Assignments to buffer_actual_len and requestid happen before packetlen > is checked to be within buflen. If this condition is true, > hv_ringbuffer_read() returns with these variables already set to some > value even though no data is

Re: [PATCH v2] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

2020-07-22 Thread Stephen Hemminger
On Wed, 22 Jul 2020 13:23:11 -0700 (PDT) David Miller wrote: > From: Stephen Hemminger > Date: Wed, 22 Jul 2020 08:27:41 -0700 > > > On Tue, 21 Jul 2020 15:36:32 -0700 (PDT) > > David Miller wrote: > > > >> From: Xiongfeng Wang > &

Re: [PATCH v5 0/3] Drivers: hv: vmbus: vmbus_requestor data structure for VMBus hardening

2020-07-22 Thread Stephen Hemminger
On Wed, 22 Jul 2020 11:10:48 -0700 "Andres Beltran" wrote: > Currently, VMbus drivers use pointers into guest memory as request IDs > for interactions with Hyper-V. To be more robust in the face of errors > or malicious behavior from a compromised Hyper-V, avoid exposing > guest memory addresses

Re: [PATCH v2] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

2020-07-22 Thread Stephen Hemminger
On Tue, 21 Jul 2020 15:36:32 -0700 (PDT) David Miller wrote: > From: Xiongfeng Wang > Date: Tue, 21 Jul 2020 15:02:57 +0800 > > > When I cat 'tx_timeout' by sysfs, it displays as follows. It's better to > > add a newline for easy reading. > > > > root@syzkaller:~# cat

Re: [PATCH v4] hv_netvsc: add support for vlans in AF_PACKET mode

2020-07-21 Thread Stephen Hemminger
On Tue, 21 Jul 2020 12:44:03 +0530 Sriram Krishnan wrote: > + /* When using AF_PACKET we need to drop VLAN header from > + * the frame and update the SKB to allow the HOST OS > + * to transmit the 802.1Q packet > + */ > + if (skb->protocol == htons(ETH_P_8021Q)) { > +

Re: [PATCH v5 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread Stephen Hemminger
on_show; > + dev_attr_netvsc_dev_attrs[i].store = NULL; > + netvsc_dev_attrs[i] = _attr_netvsc_dev_attrs[i].attr; > + } > + netvsc_dev_attrs[VRSS_SEND_TAB_SIZE] = NULL; You know that last line is unnecessary. The variable is static and starts out as all zero. Overall looks good. Acked-by: Stephen Hemminger

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-20 Thread Stephen Hemminger
On Mon, 20 Jul 2020 17:22:49 -0400 Willem de Bruijn wrote: > On Mon, Jul 20, 2020 at 4:57 PM Stephen Hemminger > wrote: > > > > On Mon, 20 Jul 2020 09:52:27 -0400 > > Willem de Bruijn wrote: > > > > > On Mon, Jul 20, 2020 at 12:27 AM

Re: [PATCH v2] AF_PACKET doesnt strip VLAN information

2020-07-20 Thread Stephen Hemminger
On Mon, 20 Jul 2020 09:52:27 -0400 Willem de Bruijn wrote: > On Mon, Jul 20, 2020 at 12:27 AM Sriram Krishnan (srirakr2) > wrote: > > > > +Stephen Hemminger > > > > Hi Willem, > > Thanks for looking into the code, I understand that this is more of

Re: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

2020-07-20 Thread Stephen Hemminger
On Mon, 20 Jul 2020 22:15:51 +0530 Sriram Krishnan wrote: > > + /* When using AF_PACKET we need to remove VLAN from frame > + * and indicate VLAN information in SKB so HOST OS will > + * transmit the VLAN frame > + */ > + if (skb->protocol == htons(ETH_P_8021Q)) { > +

Re: [PATCH v2 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-20 Thread Stephen Hemminger
On Mon, 20 Jul 2020 00:12:10 -0700 (PDT) Chi Song wrote: > An imbalanced TX indirection table causes netvsc to have low > performance. This table is created and managed during runtime. To help > better diagnose performance issues caused by imbalanced tables, add > device attributes to show the

Re: net: decnet: TODO Items

2020-07-19 Thread Stephen Hemminger
On Fri, 17 Jul 2020 11:48:16 +0530 Suraj Upadhyay wrote: > Hi Maintainers and Developers, > I am interested in the DECnet TODO list. > I just need a quick response whether they are worth doing or not > for the amount of development happening in this subsystem is extremely > low and I can't

Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-19 Thread Stephen Hemminger
On Thu, 16 Jul 2020 17:32:47 + Bixuan Cui wrote: > Fix the warning: [-Werror=-Wframe-larger-than=] > > drivers/net/ethernet/neterion/vxge/vxge-main.c: > In function'VXGE_COMPLETE_VPATH_TX.isra.37': > drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: > warning: the frame size of 1056

Re: [Ksummit-discuss] [PATCH v2] CodingStyle: Inclusive Terminology

2020-07-08 Thread Stephen Hemminger
igned-off-by: Greg Kroah-Hartman > Signed-off-by: Dan Williams Thanks for doing this. Signed-off-by: Stephen Hemminger

Re: [Ksummit-discuss] [Tech-board-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-07 Thread Stephen Hemminger
On Tue, 7 Jul 2020 02:03:36 +0300 Pavel Begunkov wrote: > On 07/07/2020 01:28, Steven Rostedt wrote: > > On Tue, 7 Jul 2020 01:17:47 +0300 > > Pavel Begunkov wrote: > > > >> Totally agree with you! But do we care then whether two _devices_ or > >> _objects_ > >> are slave-master? Can't see

Re: [PATCH v3 0/3] Drivers: hv: vmbus: vmbus_requestor data structure for VMBus hardening

2020-06-30 Thread Stephen Hemminger
On Tue, 30 Jun 2020 11:31:57 -0400 Andres Beltran wrote: > Currently, VMbus drivers use pointers into guest memory as request IDs > for interactions with Hyper-V. To be more robust in the face of errors > or malicious behavior from a compromised Hyper-V, avoid exposing > guest memory addresses

Re: [iproute2-next] action police: make 'mtu' could be set independently in police action

2020-06-28 Thread Stephen Hemminger
On Sun, 28 Jun 2020 09:46:02 +0800 Po Liu wrote: > Current police action must set 'rate' and 'burst'. 'mtu' parameter > set the max frame size and could be set alone without 'rate' and 'burst' > in some situation. Offloading to hardware for example, 'mtu' could limit > the flow max frame size. >

Re: [RFC,net-next, 2/5] vrf: track associations between VRF devices and tables

2020-06-13 Thread Stephen Hemminger
On Fri, 12 Jun 2020 18:49:34 +0200 Andrea Mayer wrote: > + /* shared_tables: > + * count how many distinct tables does not comply with the > + * strict mode requirement. > + * shared_table value must be 0 in order to switch to strict mode. > + * > + * example of

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-09 Thread Stephen Hemminger
On Sun, 07 Jun 2020 16:45:32 -0700 (PDT) David Miller wrote: > From: Stephen Hemminger > Date: Sun, 7 Jun 2020 15:30:19 -0700 > > > Open source projects have been working hard to remove the terms master and > > slave > > in API's and documentation. Apparently, Linu

Re: [PATCH ethtool v1] netlink: add master/slave configuration support

2020-06-07 Thread Stephen Hemminger
On Tue, 26 May 2020 11:10:25 +0200 Oleksij Rempel wrote: > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > auto-negotiation support, we needed to be able to configure the > MASTER-SLAVE role of the port manually or from an application in user > space. > > The same UAPI

[ANNOUNCE] iproute2-5.7.0 release

2020-06-02 Thread Stephen Hemminger
on Petr Machata (5): tc: q_red: Support 'nodrop' flag tc: p_ip6: Support pedit of IPv6 dsfield man: tc-pedit: Add examples for dsfield and retain man: tc-pedit: Drop the claim that pedit ex is only for IPv4 ip: link_gre: Do not send ERSPAN attributes to GRE tunnels Roman

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-20 Thread Stephen Hemminger
On Wed, 20 May 2020 21:37:11 +0200 Thomas Gleixner wrote: > David Miller writes: > > From: Thomas Gleixner > > Date: Wed, 20 May 2020 01:42:30 +0200 > >>> Please try, it isn't that hard.. > >>> > >>> # time for ((i=0;i<1000;i++)); do ip li add dev dummy$i type dummy; done > >>> > >>> real

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Stephen Hemminger
On Tue, 19 May 2020 20:18:19 -0700 Eric Dumazet wrote: > On 5/19/20 7:57 PM, David Miller wrote: > > From: Thomas Gleixner > > Date: Wed, 20 May 2020 01:42:30 +0200 > > > >> Stephen Hemminger writes: > >>> On Wed, 20 May 2020 00:23:48 +0200 >

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Stephen Hemminger
On Wed, 20 May 2020 01:42:30 +0200 Thomas Gleixner wrote: > Stephen Hemminger writes: > > On Wed, 20 May 2020 00:23:48 +0200 > > Thomas Gleixner wrote: > >> No. We did not. -ENOTESTCASE > > > > Please try, it isn't that hard.. > > > > # time

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Stephen Hemminger
On Wed, 20 May 2020 00:23:48 +0200 Thomas Gleixner wrote: > Stephen Hemminger writes: > > On Tue, 19 May 2020 23:45:23 +0200 > > "Ahmed S. Darwish" wrote: > > > >> Sequence counters write paths are critical sections that must never be > >> pr

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

2020-05-19 Thread Stephen Hemminger
On Tue, 19 May 2020 23:45:23 +0200 "Ahmed S. Darwish" wrote: > Sequence counters write paths are critical sections that must never be > preempted, and blocking, even for CONFIG_PREEMPTION=n, is not allowed. > > Commit 5dbe7c178d3f ("net: fix kernel deadlock with interface rename and > netdev

Re: [v4,iproute2-next 1/2] iproute2-next:tc:action: add a gate control action

2020-05-06 Thread Stephen Hemminger
On Wed, 6 May 2020 16:40:19 +0800 Po Liu wrote: > } else if (matches(*argv, "base-time") == 0) { > + NEXT_ARG(); > + if (get_u64(_time, *argv, 10)) { > + invalidarg = "base-time"; > +

Re: [v3,iproute2 1/2] iproute2:tc:action: add a gate control action

2020-05-04 Thread Stephen Hemminger
On Sun, 3 May 2020 14:32:50 +0800 Po Liu wrote: > + print_string(PRINT_ANY, "gate state", "\tgate-state %-8s", NAK Space in a json tag is not valid. Please run a dump command and feed it into JSON validation checker like Python.

Re: [v3,iproute2 1/2] iproute2:tc:action: add a gate control action

2020-05-04 Thread Stephen Hemminger
On Sun, 3 May 2020 14:32:50 +0800 Po Liu wrote: > Introduce a ingress frame gate control flow action. > Tc gate action does the work like this: > Assume there is a gate allow specified ingress frames can pass at > specific time slot, and also drop at specific time slot. Tc filter > chooses the

Re: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU

2019-10-21 Thread Stephen Hemminger
On Mon, 21 Oct 2019 20:26:03 +0800 Yunsheng Lin wrote: > Currently the MTU of vlan netdevice is set to the same MTU > of the lower device, which requires the underlying device > to handle it as the comment has indicated: > > /* need 4 bytes for extra VLAN header info, >* hope the

Re: [RFC 1/2] vhost: IFC VF hardware operation layer

2019-10-15 Thread Stephen Hemminger
On Wed, 16 Oct 2019 09:03:17 +0800 Zhu Lingshan wrote: > + IFC_INFO(>dev, "PCI capability mapping:\n" > + "common cfg: %p\n" > + "notify base: %p\n" > + "isr cfg: %p\n" > + "device

Re: [RFC 1/2] vhost: IFC VF hardware operation layer

2019-10-15 Thread Stephen Hemminger
On Wed, 16 Oct 2019 09:03:17 +0800 Zhu Lingshan wrote: > +int ifcvf_init_hw(struct ifcvf_hw *hw, struct pci_dev *dev) > +{ > + int ret; > + u8 pos; > + struct virtio_pci_cap cap; > + u32 i; > + u16 notify_off; For network code, the preferred declaration style is reverse

Re: [PATCH] AF_PACKET doesnt strip VLAN information

2019-10-01 Thread Stephen Hemminger
On Mon, 30 Sep 2019 11:16:14 -0400 Willem de Bruijn wrote: > On Mon, Sep 30, 2019 at 1:24 AM Sriram Krishnan wrote: > > > > When an application sends with AF_PACKET and places a vlan header on > > the raw packet; then the AF_PACKET needs to move the tag into the skb > > so that it gets

Re: ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!

2019-09-30 Thread Stephen Hemminger
On Mon, 30 Sep 2019 18:29:10 +0200 Borislav Petkov wrote: > On Mon, Sep 30, 2019 at 05:45:35PM +0200, Michal Kubecek wrote: > > On Mon, Sep 30, 2019 at 04:13:17PM +0200, Borislav Petkov wrote: > > > I'm seeing this on i386 allyesconfig builds of current Linus master: > > > > > > ERROR:

Re: ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!

2019-09-30 Thread Stephen Hemminger
On Mon, 30 Sep 2019 18:29:10 +0200 Borislav Petkov wrote: > On Mon, Sep 30, 2019 at 05:45:35PM +0200, Michal Kubecek wrote: > > On Mon, Sep 30, 2019 at 04:13:17PM +0200, Borislav Petkov wrote: > > > I'm seeing this on i386 allyesconfig builds of current Linus master: > > > > > > ERROR:

Re: WARNING in hso_free_net_device

2019-09-04 Thread Stephen Hemminger
On Wed, 4 Sep 2019 16:27:50 -0400 Hui Peng wrote: > Hi, all: > > I looked at the bug a little. > > The issue is that in the error handling code, hso_free_net_device > unregisters > > the net_device (hso_net->net)  by calling unregister_netdev. In the > error handling code path, > >

Re: [v2] iproute2-next: police: support 64bit rate and peakrate in tc utility

2019-08-30 Thread Stephen Hemminger
On Fri, 30 Aug 2019 14:07:17 -0500 David Dai wrote: > + if (rate64) { > fprintf(stderr, "Double \"rate\" spec\n"); > return -1; > } The m_police filter should start using the common functions

Re: [v1] iproute2: police: support 64bit rate and peakrate in tc utility

2019-08-29 Thread Stephen Hemminger
On Wed, 28 Aug 2019 17:52:56 -0500 David Dai wrote: > For high speed adapter like Mellanox CX-5 card, it can reach upto > 100 Gbits per second bandwidth. Currently htb already supports 64bit rate > in tc utility. However police action rate and peakrate are still limited > to 32bit value (upto 32

Re: [PATCH] hv_netvsc: Fix a memory leak bug

2019-08-14 Thread Stephen Hemminger
On Wed, 14 Aug 2019 15:16:11 -0500 Wenwen Wang wrote: > In rndis_filter_device_add(), 'rndis_device' is allocated through kzalloc() > by invoking get_rndis_device(). In the following execution, if an error > occurs, the execution will go to the 'err_dev_remv' label. However, the > allocated

Re: [PATCH] isdn: hysdn: fix code style error from checkpatch

2019-08-02 Thread Stephen Hemminger
On Fri, 2 Aug 2019 19:50:17 + Ricardo Bruno Lopes da Silva wrote: > Fix error bellow from checkpatch. > > WARNING: Block comments use * on subsequent lines > +/*** > + > > Signed-off-by: Ricardo Bruno Lopes da Silva Read the TODO,

Re: [PATCH] isdn: hysdn: Fix error spaces around '*'

2019-08-02 Thread Stephen Hemminger
On Fri, 2 Aug 2019 19:56:02 + Jose Carlos Cazarin Filho wrote: > Fix checkpath error: > CHECK: spaces preferred around that '*' (ctx:WxV) > +extern hysdn_card *card_root;/* pointer to first card */ > > Signed-off-by: Jose Carlos Cazarin Filho Read the TODO, these drivers are

Re: [PATCH 1/2] Drivers: hv: Specify receive buffer size using Hyper-V page size

2019-07-26 Thread Stephen Hemminger
On Wed, 24 Jul 2019 22:03:14 -0700 "Himadri Pandya" wrote: > The recv_buffer is used to retrieve data from the VMbus ring buffer. > VMbus ring buffers are sized based on the guest page size which > Hyper-V assumes to be 4KB. But it may be different on some > architectures. So use the Hyper-V

Re: [PATCH 2/2] Drivers: hv: util: Specify ring buffer size using Hyper-V page size

2019-07-26 Thread Stephen Hemminger
On Wed, 24 Jul 2019 22:03:15 -0700 "Himadri Pandya" wrote: > VMbus ring buffers are sized based on the 4K page size used by > Hyper-V. The Linux guest page size may not be 4K on all architectures > so use the Hyper-V page size to specify the ring buffer size. > > Signed-off-by: Himadri Pandya

Re: [PATCH net-next v2 3/3] netlink: add validation of NLA_F_NESTED flag

2019-07-23 Thread Stephen Hemminger
On Thu, 2 May 2019 16:15:10 +0200 (CEST) Michal Kubecek wrote: > Add new validation flag NL_VALIDATE_NESTED which adds three consistency > checks of NLA_F_NESTED_FLAG: > > - the flag is set on attributes with NLA_NESTED{,_ARRAY} policy > - the flag is not set on attributes with other

Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation

2019-07-15 Thread Stephen Hemminger
On Mon, 15 Jul 2019 21:09:44 +0200 (CEST) Thomas Gleixner wrote: > Octavio, > > On Mon, 15 Jul 2019, Octavio Alvarez wrote: > > If I reboot with sky2.disable_msi=1, then I get IO-APIC and the bug does not > > occur: > > > > 19: 0 0 0 0 IO-APIC 19-fasteoi

Re: [PATCH net-next] Name NICs based on vmbus offer and enable async probe by default

2019-07-09 Thread Stephen Hemminger
On Tue, 9 Jul 2019 22:56:30 + Haiyang Zhang wrote: > - VRSS_CHANNEL_MAX); > + if (probe_type == PROBE_PREFER_ASYNCHRONOUS) { > + snprintf(name, IFNAMSIZ, "eth%d", dev->channel->dev_num); What about PCI passthrough or VF devices that are also being

[ANNOUNCE] iproute2 5.2

2019-07-08 Thread Stephen Hemminger
cipher type. Roman Mashak (1): tc: Fix binding of gact action by index. Stefano Brivio (1): iproute: Set flags and attributes on dump to get IPv6 cached routes to be flushed Stephen Hemminger (14): uapi: update to elf-em header uapi: add include/linux/net.h uapi

Re: [PATCH v2] PCI: hv: fix pci-hyperv build when SYSFS not enabled

2019-07-08 Thread Stephen Hemminger
t; p...@vger.kernel.org> > >> Cc: Matthew Wilcox ; Jake Oshins > >> ; KY Srinivasan ; Haiyang > >> Zhang ; Stephen Hemminger > >> ; Sasha Levin ; Bjorn > >> Helgaas ; linux-hyp...@vger.kernel.org; Dexuan > >> Cui ; Yuehaibing > >>

Re: [PATCH net-next v6 01/15] rtnetlink: provide permanent hardware address in RTM_NEWLINK

2019-07-02 Thread Stephen Hemminger
ecek Do you want to make an iproute patch to display this? Acked-by: Stephen Hemminger

Re: PROBLEM: Marvell 88E8040 (sky2) fails after hibernation

2019-06-24 Thread Stephen Hemminger
On Sun, 23 Jun 2019 14:54:13 +0200 (CEST) Thomas Gleixner wrote: > Octavio, > > On Sat, 22 Jun 2019, Thomas Gleixner wrote: > > On Wed, 19 Jun 2019, Octavio Alvarez wrote: > > > On 6/13/19 3:45 PM, Thomas Gleixner wrote: > > > > Can you please provide the content of /proc/interrupts with

Re: [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates

2019-06-20 Thread Stephen Hemminger
On Thu, 20 Jun 2019 23:37:51 +0530 Puranjay Mohan wrote: > This patch series removes the private duplicates of PCI definitions in > favour of generic definitions defined in pci_regs.h. > > This driver only uses one of the generic PCI definitons, i.e. > PCI_REVISION_ID, which is included from

Re: Driver has suspect GRO implementation, TCP performance may be compromised.

2019-05-29 Thread Stephen Hemminger
On Wed, 29 May 2019 09:00:54 -0700 Eric Dumazet wrote: > On Wed, May 29, 2019 at 7:49 AM Paul Menzel wrote: > > > > Dear Eric, > > > > > > Thank you for the quick reply. > > > > On 05/28/19 19:18, Eric Dumazet wrote: > > > On 5/28/19 8:42 AM, Paul Menzel wrote: > > > > >> Occasionally,

Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-27 Thread Stephen Hemminger
On Tue, 28 May 2019 09:04:18 +0800 Yunsheng Lin wrote: > On 2019/5/27 22:58, Stephen Hemminger wrote: > > On Mon, 27 May 2019 09:47:54 +0800 > > Yunsheng Lin wrote: > > > >> When user has configured a large number of virtual netdev, such > >> as

Re: [PATCH net-next] macvlan: Replace strncpy() by strscpy()

2019-05-27 Thread Stephen Hemminger
On Mon, 27 May 2019 16:28:05 -0500 "Gustavo A. R. Silva" wrote: > On 5/27/19 4:20 PM, Stephen Hemminger wrote: > > On Mon, 27 May 2019 13:38:55 -0500 > > "Gustavo A. R. Silva" wrote: > > > >> The strncpy() function is being deprecat

Re: [PATCH net-next] macvlan: Replace strncpy() by strscpy()

2019-05-27 Thread Stephen Hemminger
On Mon, 27 May 2019 13:38:55 -0500 "Gustavo A. R. Silva" wrote: > The strncpy() function is being deprecated. Replace it by the safer > strscpy() and fix the following Coverity warning: > > "Calling strncpy with a maximum size argument of 16 bytes on destination > array ifrr.ifr_ifrn.ifrn_name

Re: [PATCH net-next] net: link_watch: prevent starvation when processing linkwatch wq

2019-05-27 Thread Stephen Hemminger
On Mon, 27 May 2019 09:47:54 +0800 Yunsheng Lin wrote: > When user has configured a large number of virtual netdev, such > as 4K vlans, the carrier on/off operation of the real netdev > will also cause it's virtual netdev's link state to be processed > in linkwatch. Currently, the processing is

Re: [PATCH net-next] hv_sock: perf: Allow the socket buffer size options to influence the actual socket buffers

2019-05-22 Thread Stephen Hemminger
On Wed, 22 May 2019 22:56:07 + Sunil Muthuswamy wrote: > Currently, the hv_sock buffer size is static and can't scale to the > bandwidth requirements of the application. This change allows the > applications to influence the socket buffer sizes using the SO_SNDBUF and > the SO_RCVBUF socket

Re: [PATCH 2/2] ftpm: firmware TPM running in TEE

2019-04-02 Thread Stephen Hemminger
On Tue, 2 Apr 2019 12:33:16 -0700 "Sasha Levin" wrote: > +/* > + * ftpm_tee_tpm_op_recv retrieve fTPM response. > + * @param: chip, the tpm_chip description as specified in > driver/char/tpm/tpm.h. > + * @param: buf, the buffer to store data. > + * @param: count, the number of bytes to

Re: [PATCH v3 3/3] Drivers: hv: vmbus: Fix race condition with new ring_buffer_info mutex

2019-03-28 Thread Stephen Hemminger
On Thu, 28 Mar 2019 00:30:57 -0400 Kimberly Brown wrote: > On Thu, Mar 21, 2019 at 04:04:20PM +, Michael Kelley wrote: > > From: Kimberly Brown Sent: Wednesday, March 20, > > 2019 8:48 PM > > > > > > Adding more locks will solve the problem but it seems like overkill. > > > > > > Why

Re: [PATCH hyperv-fixes] hv_netvsc: Fix unwanted wakeup after tx_disable

2019-03-28 Thread Stephen Hemminger
On Thu, 28 Mar 2019 17:48:45 + Haiyang Zhang wrote: > +static inline void netvsc_tx_enable(struct netvsc_device *nvscdev, > + struct net_device *ndev) > +{ > + nvscdev->tx_disable = false; > + mb(); /* ensure queue wake up mechanism is on */ > + > +

Re: [PATCH v3 3/3] Drivers: hv: vmbus: Fix race condition with new ring_buffer_info mutex

2019-03-20 Thread Stephen Hemminger
On Sat, 16 Mar 2019 21:49:28 -0400 Kimberly Brown wrote: > On Thu, Mar 14, 2019 at 03:45:33PM -0700, Stephen Hemminger wrote: > > On Thu, 14 Mar 2019 13:05:15 -0700 > > "Kimberly Brown" wrote: > > > > > Fix a race condition that can result in a rin

Re: [PATCH v3 3/3] Drivers: hv: vmbus: Fix race condition with new ring_buffer_info mutex

2019-03-14 Thread Stephen Hemminger
On Thu, 14 Mar 2019 13:05:15 -0700 "Kimberly Brown" wrote: > Fix a race condition that can result in a ring buffer pointer being set > to null while a "_show" function is reading the ring buffer's data. This > problem was discussed here: >

Re: r8169 only works in promisc mode

2019-03-10 Thread Stephen Hemminger
On Sun, 10 Mar 2019 15:26:16 +0100 Heiner Kallweit wrote: > On 10.03.2019 15:18, Stephen Hemminger wrote: > > On Sat, 9 Mar 2019 10:33:40 +0100 > > Heiner Kallweit wrote: > > > >> On 09.03.2019 03:16, Alex Xu (Hello71) wrote: > >>> After sus

Re: r8169 only works in promisc mode

2019-03-10 Thread Stephen Hemminger
On Sat, 9 Mar 2019 10:33:40 +0100 Heiner Kallweit wrote: > On 09.03.2019 03:16, Alex Xu (Hello71) wrote: > > After suspending, my r8169 (not actually 8169, just that driver) only > > receives packets when in promiscuous mode. I have tried disabling all > > offload features except highdma

Re: [PATCH 1/2] ipmr: Make cache queue length configurable

2019-03-07 Thread Stephen Hemminger
On Thu, 7 Mar 2019 09:19:55 +1300 Brodie Greenfield wrote: > +ip_mr_cache_queue_length - INTEGER > + Limit the number of multicast packets we can have in the queue to be > + resolved. > + Bear in mind that when an unresolved multicast packet is received, > + there is an O(n)

Re: [PATCH 0/3] pci-hyperv: fix memory leak and add pci_destroy_slot()

2019-03-05 Thread Stephen Hemminger
/pci/controller/pci-hyperv.c | 23 +++ > 1 file changed, 23 insertions(+) Thanks for fixing this. Reviewed-by: Stephen Hemminger

Re: Request for suggestion on net device re-naming/re-ordering based on DT alias

2019-02-27 Thread Stephen Hemminger
On Wed, 27 Feb 2019 10:45:44 -0800 Florian Fainelli wrote: > On 2/27/19 10:40 AM, Stephen Hemminger wrote: > > On Wed, 27 Feb 2019 17:24:03 +0530 > > Harini Katakam wrote: > > > >> Hi, > >> > >> We've had some users requesting control over n

Re: Request for suggestion on net device re-naming/re-ordering based on DT alias

2019-02-27 Thread Stephen Hemminger
On Wed, 27 Feb 2019 17:24:03 +0530 Harini Katakam wrote: > Hi, > > We've had some users requesting control over net device name order > when multiple ethernet devices are present on a system. I've tried a > few solutions to this and looked it up on forums. But I apologize if > I have missed

Re: [PATCH hyperv-fixes] hv_netvsc: Fix IP header checksum for coalesced packets

2019-02-23 Thread Stephen Hemminger
On Fri, 22 Feb 2019 18:25:03 + Haiyang Zhang wrote: > From: Haiyang Zhang > > Incoming packets may have IP header checksum verified by the host. > They may not have IP header checksum computed after coalescing. > This patch re-compute the checksum when necessary, otherwise the > packets

RE: [PATCH V3 1/10] X86/Hyper-V: Add parameter offset for hyperv_fill_flush_guest_mapping_list()

2019-02-22 Thread Stephen Hemminger
int hyperv_fill_flush_guest_mapping_list( struct hv_guest_mapping_flush_list *flush, - u64 start_gfn, u64 pages) + int offset, u64 start_gfn, u64 pages) { u64 cur = start_gfn; u64 additional_pages; - int gpa_n = 0; + int

  1   2   3   4   5   6   7   8   9   10   >