[PATCH] ASoC: max98390: Add support for tx slot configuration.

2021-04-05 Thread Steve Lee
Update voltage/current tx slot configuration support. Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.c | 62 + sound/soc/codecs/max98390.h | 2 ++ 2 files changed, 64 insertions(+) diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs

RE: [EXTERNAL] Re: [PATCH] ASoC: max98390: Add controls for tx path

2021-04-02 Thread Steve Lee
> -Original Message- > From: Mark Brown > Sent: Saturday, April 3, 2021 12:23 AM > To: Steve Lee > Cc: lgirdw...@gmail.com; pe...@perex.cz; ti...@suse.com; > ckee...@opensource.cirrus.com; ge...@linux-m68k.org; > r...@opensource.wolfsonmicro.com; shumi...@realtek.co

[PATCH] ASoC: max98390: Add controls for tx path

2021-04-01 Thread Steve Lee
Add controls for tx source. Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index bb736c44e68a..163093959da8 100644 --- a/sound/soc/codecs/max98390.c +++ b/sound/soc

RE: [PATCH 3/3] ASoC: max98390: update dsm param bin max size

2020-07-27 Thread Steve Lee
> -Original Message- > From: Mark Brown > Sent: Monday, July 27, 2020 10:08 PM > To: Steve Lee > Cc: lgirdw...@gmail.com; pe...@perex.cz; ti...@suse.com; > ckee...@opensource.cirrus.com; ge...@linux-m68k.org; > r...@opensource.wolfsonmicro.com; shumi...@realtek.co

[RESEND 3/3] ASoC: max98390: update dsm param bin max size

2020-07-26 Thread Steve Lee
MAX98390_DSM_PARAM_MAX_SIZE is changed to support extended register update. Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98390.h b/sound/soc/codecs/max98390.h index 5f444e7779b0..dff884f68e3e

[RESEND 2/3] ASoC: max98390: Update dsm init sequence and condition.

2020-07-26 Thread Steve Lee
Modify dsm_init sequence and dsm param bin check condition. - Move dsm_init() to after amp init setting to make sure dsm init is last setting. - dsm param bin check condition changed for extended register setting. Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.c | 6 +++--- 1

[RESEND 1/3] ASoC: max98390: Fix dac event dapm mixer.

2020-07-26 Thread Steve Lee
Global EN register guide to off before AMP_EN register when amp disable sequence. - remove AMP_EN control before max98390_dac_event call Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98390.c b

RE: [PATCH 3/3] ASoC: max98390: update dsm param bin max size

2020-07-26 Thread Steve Lee
> -Original Message- > From: Mark Brown > Sent: Friday, July 24, 2020 7:51 PM > To: Steve Lee > Cc: lgirdw...@gmail.com; pe...@perex.cz; ti...@suse.com; > ckee...@opensource.cirrus.com; ge...@linux-m68k.org; > r...@opensource.wolfsonmicro.com; shumi...@realtek.co

[PATCH 3/3] ASoC: max98390: update dsm param bin max size

2020-07-24 Thread Steve Lee
MAX98390_DSM_PARAM_MAX_SIZE is changed to support extended register update. Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98390.h b/sound/soc/codecs/max98390.h index 5f444e7779b0..dff884f68e3e

[PATCH 2/2] ASoC: max98390: Update dsm init sequence and condition.

2020-07-24 Thread Steve Lee
Modify dsm_init sequence and dsm param bin check condition. - Move dsm_init() to after amp init setting to make sure dsm init is last setting. - dsm param bin check condition changed for extended register setting. Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.c | 6 +++--- 1

[PATCH 1/2] ASoC: max98390: Fix dac event dapm mixer.

2020-07-24 Thread Steve Lee
Global EN register guide to off before AMP_EN register when amp disable sequence. - remove AMP_EN control before max98390_dac_event call Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max98390.c b

[PATCH 2/2] ASoC: max98390: Update regmap readable reg and volatile

2020-06-11 Thread Steve Lee
Update max98390_readable_register and max98390_volatile_reg Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c index 57d15dbfcda3..b345e626956d 100644

[PATCH 1/2] ASoC: max98390: Add Amp init common setting func.

2020-06-11 Thread Steve Lee
Add amp common init function to gather common init setting and finaize. - add max98390_init_regs func - move amp setting to max98390_init_regs func. - removed unneceary setting and finalize common register values. Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.c | 26

[v2 PATCH] ASoC: max98390: Fix potential crash during param fw loading

2020-06-03 Thread Steve Lee
h data. Signed-off-by: Steve Lee --- Change log v2: * add condtion that param_size + _PAYLOAD_OFFSET is less than fw->size to confirm enough data * remove unintended code sound/soc/codecs/max98390.c | 24 sound/soc/codecs/max98390.h | 3 ++-

RE: [PATCH] ASoC: max98390: Fix potential crash during param fw loading

2020-06-03 Thread Steve Lee
> -Original Message- > From: Mark Brown > Sent: Wednesday, June 3, 2020 8:43 PM > To: Steve Lee > Cc: lgirdw...@gmail.com; pe...@perex.cz; ti...@suse.com; > ckee...@opensource.cirrus.com; ge...@linux-m68k.org; > r...@opensource.wolfsonmicro.com; shumi...@realtek.co

RE: [PATCH] ASoC: max98390: Fix potential crash during param fw loading

2020-06-03 Thread Steve Lee
> -Original Message- > From: Mark Brown > Sent: Wednesday, June 3, 2020 8:32 PM > To: Steve Lee > Cc: lgirdw...@gmail.com; pe...@perex.cz; ti...@suse.com; > ckee...@opensource.cirrus.com; ge...@linux-m68k.org; > r...@opensource.wolfsonmicro.com;

RE: [PATCH] ASoC: max98390: Fix potential crash during param fw loading

2020-06-03 Thread Steve Lee
> -Original Message- > From: Takashi Iwai > Sent: Wednesday, June 3, 2020 8:24 PM > To: Steve Lee > Cc: lgirdw...@gmail.com; broo...@kernel.org; pe...@perex.cz; > ti...@suse.com; ckee...@opensource.cirrus.com; ge...@linux-m68k.org; > r...@opensource.wolfsonmicro.com;

[PATCH] ASoC: max98390: Fix potential crash during param fw loading

2020-06-03 Thread Steve Lee
malformed firmware file can cause out-of-bound access and crash during dsm_param bin loading. - add MIN/MAX param size to avoid out-of-bound access. - read start addr and size of param and check bound. Signed-off-by: Steve Lee --- sound/soc/codecs/max98390.c | 23

[V7 PATCH] dt-bindings: Added device tree binding for max98390

2020-06-02 Thread Steve Lee
Add DT binding of max98390 amplifier driver. Signed-off-by: Steve Lee --- Changed since V6: * Re-confirm yaml dt binding check * Add minimum and maximum value for each temperature_calib and r0_calib * Add maxim prefix for naming. Changed since V5: * Change txt

Re: [V6 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-31 Thread Steve Lee
On Fri, May 29, 2020 at 6:35 PM Mark Brown wrote: > > On Fri, May 29, 2020 at 05:04:36PM +0900, Steve Lee wrote: > > On Thu, May 28, 2020 at 8:54 PM Mark Brown wrote: > > > > > Reported-by: kbuild test robot > > > > Don't think the lkp bot asked for this

Re: [V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-29 Thread Steve Lee
On Thu, May 28, 2020 at 11:17 PM Rob Herring wrote: > > On Thu, May 28, 2020 at 07:37:55PM +0900, Steve Lee wrote: > > Add DT binding of max98390 amplifier driver. > > > > Signed-off-by: Steve Lee > > --- > > Changed since V5: > > * Change txt to

Re: [V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-29 Thread Steve Lee
On Thu, May 28, 2020 at 11:15 PM Rob Herring wrote: > > On Thu, 28 May 2020 19:37:55 +0900, Steve Lee wrote: > > Add DT binding of max98390 amplifier driver. > > > > Signed-off-by: Steve Lee > > --- > > Changed since V5: > > * Change txt to yaml

Re: [V6 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-29 Thread Steve Lee
On Thu, May 28, 2020 at 8:54 PM Mark Brown wrote: > > On Thu, May 28, 2020 at 07:39:42PM +0900, Steve Lee wrote: > > This is the initial amplifier driver for max98390. > > Please do not submit new versions of already applied patches, please > submit incremental updates

[V6 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-28 Thread Steve Lee
This is the initial amplifier driver for max98390. Reported-by: kbuild test robot Signed-off-by: Steve Lee --- Changes since V5: * Fixed warning message reported by kbuild. * Finalize default register value. * Update missed AMP_EN register setting during dsm_init

[V6 PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-28 Thread Steve Lee
Add DT binding of max98390 amplifier driver. Signed-off-by: Steve Lee --- Changed since V5: * Change txt to yaml and fix up the examples. Changed since V4: * No changes. Changed since V3: * No changes. Changed since V2: * No changes. Changed since V1

Re: [RESEND][V5 PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-28 Thread Steve Lee
On Wed, May 27, 2020 at 7:36 AM Rob Herring wrote: > > On Mon, May 18, 2020 at 09:49:30AM +0900, Steve Lee wrote: > > Add documentation for DT binding of max98390 amplifier driver. > > > > Signed-off-by: Steve Lee > > --- > > > > > > Changed since

[RESEND][V5 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-17 Thread Steve Lee
This is the initial amplifier driver for max98390. Signed-off-by: Steve Lee --- Changes since V4: * Revert return calibration status in max98390_dsm_calib_get: There is no need to return calibration status in get function because there is mixer control

[RESEND][V5 PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-17 Thread Steve Lee
Add documentation for DT binding of max98390 amplifier driver. Signed-off-by: Steve Lee --- Changed since V4: * No changes. Changed since V3: * No changes. Changed since V2: * No changes. Changed since V1: * Modified sample text in example .../devicetree

Re: [V5 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-17 Thread Steve Lee
On Fri, May 15, 2020 at 9:29 PM Mark Brown wrote: > > On Fri, May 15, 2020 at 10:42:24AM +0200, Krzysztof Kozlowski wrote: > > > Your "From" address still does not match the Signed-off-by. Set the > > author of commit to the signed-off person. > > git commit --amend --author='foo ' Thanks. I

[V5 PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-15 Thread Steve Lee
Add documentation for DT binding of max98390 amplifier driver. Signed-off-by: Steve Lee --- Changed since V4: * No changes. Changed since V3: * No changes. Changed since V2: * No changes. Changed since V1: * Modified sample text in example .../devicetree

[V5 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-15 Thread Steve Lee
This is the initial amplifier driver for max98390. Signed-off-by: Steve Lee --- Changes since V4: * Revert return calibration status in max98390_dsm_calib_get: There is no need to return calibration status in get function because there is mixer control

[V4 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-14 Thread Steve Lee
This is the initial amplifier driver for max98390. Signed-off-by: Steve Lee --- Changes since V3: * Add operation at max98390_dsm_calib_get: Add cal_running variable at max98390_priv structure Add return cal_running at max98390_dsm_calib_get

[V4 PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-14 Thread Steve Lee
Add documentation for DT binding of max98390 amplifier driver. Signed-off-by: Steve Lee --- Changed since V3: * No changes. Changed since V2: * No changes. Changed since V1: * Modified sample text in example .../devicetree/bindings/sound/max98390.txt| 26

Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-14 Thread Steve Lee
On Thu, May 14, 2020 at 7:17 PM Mark Brown wrote: > > On Wed, May 13, 2020 at 07:58:12PM +0800, Tzung-Bi Shih wrote: > > On Wed, May 13, 2020 at 6:53 PM Mark Brown wrote: > > > On Wed, May 13, 2020 at 04:45:23PM +0900, Steve Lee wrote: > > > > > Changes si

[V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-13 Thread Steve Lee
This is the initial amplifier driver for max98390. Signed-off-by: Steve Lee --- Changes since V2: * Removed warn massage in max98390_dsm_calib_get func and add comment. Changes since v1: * Updated according to Mark's comments. * Updated according to Tzung-Bi's

[V3 PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-13 Thread Steve Lee
Add documentation for DT binding of max98390 amplifier driver. Signed-off-by: Steve Lee --- Changed since V2: * No changes. Changed since V1: * Modified sample text in example .../devicetree/bindings/sound/max98390.txt| 26 +++ 1 file changed, 26 insertions

Re: [PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-12 Thread Steve Lee
On Tue, May 12, 2020 at 7:33 PM Mark Brown wrote: > > On Tue, May 12, 2020 at 06:13:05PM +0900, Steve Lee wrote: > > On Mon, May 11, 2020 at 8:03 PM Mark Brown wrote: > > > > > +static const char * const max98390_current_limit_text[] = { > > > > + &qu

[V2 PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-12 Thread Steve Lee
This is the initial amplifier driver for max98390. Signed-off-by: Steve Lee --- Changes since v1: * updated according to Mark's comments. * updated according to Tzung-Bi's comments. * Removed Enum structure and use TLV data for Volume control sound/soc/codecs/Kconfig

[V2 PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-12 Thread Steve Lee
Add documentation for DT binding of max98390 amplifier driver. Signed-off-by: Steve Lee --- .../devicetree/bindings/sound/max98390.txt| 26 +++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/max98390.txt diff --git

Re: [PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-12 Thread Steve Lee
On Mon, May 11, 2020 at 8:16 PM Tzung-Bi Shih wrote: > > (The patch passed 2 round review in https://crrev.com/c/2083354) > > On Sun, May 10, 2020 at 4:23 PM Steve Lee wrote: > > +static int max98390_dai_set_fmt(struct snd_soc_dai *codec_dai, unsigned > > int fmt) &

Re: [PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-12 Thread Steve Lee
On Mon, May 11, 2020 at 8:03 PM Mark Brown wrote: > > On Sat, May 09, 2020 at 12:19:19PM +0900, Steve Lee wrote: > > Signed-off-by: Steve Lee > > This looks mostly good, a few smallish things below though: > > > +++ b/sound/soc/codecs/max98390.c > > @@ -0,

[PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-08 Thread Steve Lee
Signed-off-by: Steve Lee --- sound/soc/codecs/Kconfig|5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/max98390.c | 1039 +++ sound/soc/codecs/max98390.h | 661 ++ 4 files changed, 1707 insertions(+) create mode 100644

[PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-08 Thread Steve Lee
Signed-off-by: Steve Lee --- .../devicetree/bindings/sound/max98390.txt| 26 +++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/max98390.txt diff --git a/Documentation/devicetree/bindings/sound/max98390.txt b/Documentation

Re: 3com 3c59x stopped working with 2.6.13-rc[56]

2005-08-22 Thread Steve Lee
> i tried to boot 2.6.13-rc5-git4 and 2.6.13-rc6-git13 both with the same > result: my 3com (3c59x driver on 3com 905c) card not working. > Here is what I saw in the logs. > Notice the regularity of the log barfs. They continue the same every 10secs. I'm currently using 2.6.13-rc6-git13 with the

Re: 3com 3c59x stopped working with 2.6.13-rc[56]

2005-08-22 Thread Steve Lee
i tried to boot 2.6.13-rc5-git4 and 2.6.13-rc6-git13 both with the same result: my 3com (3c59x driver on 3com 905c) card not working. Here is what I saw in the logs. Notice the regularity of the log barfs. They continue the same every 10secs. I'm currently using 2.6.13-rc6-git13 with the

Re: [RFC] Linux Kernel Subversion Howto

2005-02-10 Thread Steve Lee
Roman, besides BK being closed source, how exactly is it lacking for your needs? If what it lacks is a good idea and helps many, Larry and crew might be willing to add whatever it is you need. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [RFC] Linux Kernel Subversion Howto

2005-02-10 Thread Steve Lee
Roman, besides BK being closed source, how exactly is it lacking for your needs? If what it lacks is a good idea and helps many, Larry and crew might be willing to add whatever it is you need. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to