Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Steven Honeyman
On 28 March 2015 at 22:00, Pali Rohár wrote: > On Saturday 28 March 2015 13:54:51 Steven Honeyman wrote: >> i8k-virtual-0 >> Adapter: Virtual device >> Processor Fan: 3171 RPM >> CPU:+52.0°C >> Ambient:+46.0°C >> SODIMM: +40.0°C

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Steven Honeyman
On 28 March 2015 at 11:04, Paul Bolle wrote: > On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: >> --- a/drivers/hwmon/Kconfig >> +++ b/drivers/hwmon/Kconfig >> @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 >> This driver provides support for the Ultra45 workstation >> environmental

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Steven Honeyman
On 28 March 2015 at 22:00, Pali Rohár pali.ro...@gmail.com wrote: On Saturday 28 March 2015 13:54:51 Steven Honeyman wrote: i8k-virtual-0 Adapter: Virtual device Processor Fan: 3171 RPM CPU:+52.0°C Ambient:+46.0°C SODIMM: +40.0°C - Ambient and SODIMM look

Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k

2015-03-28 Thread Steven Honeyman
On 28 March 2015 at 11:04, Paul Bolle pebo...@tiscali.nl wrote: On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote: --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45 This driver provides support for the Ultra45 workstation

Re: [PATCH v3] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Steven Honeyman
On 21 December 2014 at 16:37, Pali Rohár wrote: > On Sunday 21 December 2014 13:23:32 Guenter Roeck wrote: >> On 12/21/2014 04:09 AM, Pali Rohár wrote: >> > On Sunday 21 December 2014 12:57:08 Guenter Roeck wrote: >> >>> -#define I8K_FAN_MULT 30 >> >>> +#define I8K_FAN_MAX_RPM

Re: [PATCH v3] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Steven Honeyman
On 21 December 2014 at 16:37, Pali Rohár pali.ro...@gmail.com wrote: On Sunday 21 December 2014 13:23:32 Guenter Roeck wrote: On 12/21/2014 04:09 AM, Pali Rohár wrote: On Sunday 21 December 2014 12:57:08 Guenter Roeck wrote: -#define I8K_FAN_MULT 30 +#define I8K_FAN_MAX_RPM

Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-20 Thread Steven Honeyman
On 20 December 2014 at 17:20, Guenter Roeck wrote: > I would think that it should be relatively safe > to assume that the first fan always exists That would be a bad idea, as this is definitely not the case: i8k-virtual-0 Adapter: Virtual device fan2:3181 RPM CPU: +43.0°C

Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-20 Thread Steven Honeyman
On 20 December 2014 at 17:20, Guenter Roeck li...@roeck-us.net wrote: I would think that it should be relatively safe to assume that the first fan always exists That would be a bad idea, as this is definitely not the case: i8k-virtual-0 Adapter: Virtual device fan2:3181 RPM CPU:

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-17 Thread Steven Honeyman
d autodetection code only on Dell Latitude E6440 >> > (where it worked). Other machines which needs to be tested: >> > >> > Dell Latitude D520 >> > Dell Latitude E6540 >> > Dell Precision WorkStation 490 >> > Dell Studio >> > Dell XPS M140 (MXC0

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-17 Thread Steven Honeyman
to be tested: Dell Latitude D520 Dell Latitude E6540 Dell Precision WorkStation 490 Dell Studio Dell XPS M140 (MXC051) --- Can somebody else with dell laptops test this patch series? Steven Honeyman, can you test this autodetection patch on your Latitude E6540? Sure. You picked the best

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Steven Honeyman
On 29 November 2014 at 16:09, Pali Rohár wrote: > On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: >> This patch adds labels for temperature sensors if SMM function >> with EAX register 0x11a3 reports it. These informations was >> taken from DOS binary NBSVC.MDM. >> >> Signed-off-by: Pali

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Steven Honeyman
On 29 November 2014 at 16:09, Pali Rohár pali.ro...@gmail.com wrote: On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM.

[PATCH V3b] x86, cpu: trivial printk formatting fixes

2014-11-05 Thread Steven Honeyman
, only fix the newline formatting issue V3: Expand patch description V3b: Fix silly mistake (log level) Signed-off-by: Steven Honeyman --- arch/x86/kernel/cpu/common.c | 11 ++- arch/x86/kernel/cpu/intel.c | 6 ++ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/arch

Re: [PATCH V3] x86, cpu: trivial printk formatting fixes

2014-11-05 Thread Steven Honeyman
On 5 November 2014 22:41, Joe Perches wrote: > On Wed, 2014-11-05 at 22:28 +0000, Steven Honeyman wrote: ... >> V2: Revert change to log level, only fix the newline formatting issue >> V3: Expand patch description > > The log level change is back... Oh oops - sorry for that,

[PATCH V3] x86, cpu: trivial printk formatting fixes

2014-11-05 Thread Steven Honeyman
, only fix the newline formatting issue V3: Expand patch description Signed-off-by: Steven Honeyman --- arch/x86/kernel/cpu/common.c | 11 ++- arch/x86/kernel/cpu/intel.c | 6 ++ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86

[PATCH V3] x86, cpu: trivial printk formatting fixes

2014-11-05 Thread Steven Honeyman
, only fix the newline formatting issue V3: Expand patch description Signed-off-by: Steven Honeyman stevenhoney...@gmail.com --- arch/x86/kernel/cpu/common.c | 11 ++- arch/x86/kernel/cpu/intel.c | 6 ++ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/arch/x86/kernel

Re: [PATCH V3] x86, cpu: trivial printk formatting fixes

2014-11-05 Thread Steven Honeyman
On 5 November 2014 22:41, Joe Perches j...@perches.com wrote: On Wed, 2014-11-05 at 22:28 +, Steven Honeyman wrote: ... V2: Revert change to log level, only fix the newline formatting issue V3: Expand patch description The log level change is back... Oh oops - sorry for that, I must have

[PATCH V3b] x86, cpu: trivial printk formatting fixes

2014-11-05 Thread Steven Honeyman
, only fix the newline formatting issue V3: Expand patch description V3b: Fix silly mistake (log level) Signed-off-by: Steven Honeyman stevenhoney...@gmail.com --- arch/x86/kernel/cpu/common.c | 11 ++- arch/x86/kernel/cpu/intel.c | 6 ++ 2 files changed, 8 insertions(+), 9

[PATCH V2] x86, cpu: trivial printk formatting fixes

2014-11-02 Thread Steven Honeyman
[0.012958] Freeing SMP alternatives memory: 28K (81d86000 - 81d8d000) [0.014961] dmar: Host address width 39 V2: Revert change to log level, only fix the newline formatting issue Signed-off-by: Steven Honeyman --- arch/x86/kernel/cpu/common.c | 11 ++- arch/x86/kernel

[PATCH V2] x86, cpu: trivial printk formatting fixes

2014-11-02 Thread Steven Honeyman
[0.012958] Freeing SMP alternatives memory: 28K (81d86000 - 81d8d000) [0.014961] dmar: Host address width 39 V2: Revert change to log level, only fix the newline formatting issue Signed-off-by: Steven Honeyman stevenhoney...@gmail.com --- arch/x86/kernel/cpu/common.c | 11

Re: [PATCH] x86, cpu: trivial printk formatting fixes

2014-11-01 Thread Steven Honeyman
On 1 November 2014 17:51, Borislav Petkov wrote: > On Sat, Nov 01, 2014 at 05:38:18PM +0000, Steven Honeyman wrote: >> On 1 November 2014 17:19, Borislav Petkov wrote: >> > On Sat, Nov 01, 2014 at 03:44:56PM +0000, Steven Honeyman wrote: >> >> A 2 line printk mak

Re: [PATCH] x86, cpu: trivial printk formatting fixes

2014-11-01 Thread Steven Honeyman
On 1 November 2014 17:19, Borislav Petkov wrote: > On Sat, Nov 01, 2014 at 03:44:56PM +0000, Steven Honeyman wrote: >> A 2 line printk makes dmesg output messy, because the second line does not >> get a timestamp. >> For example: >> >> [0.012863] CPU0

[PATCH] x86, cpu: trivial printk formatting fixes

2014-11-01 Thread Steven Honeyman
[0.012958] Freeing SMP alternatives memory: 28K (81d86000 - 81d8d000) [0.014961] dmar: Host address width 39 Signed-off-by: Steven Honeyman --- arch/x86/kernel/cpu/common.c | 11 ++- arch/x86/kernel/cpu/intel.c | 6 ++ 2 files changed, 8 insertions(+), 9 deletions

[PATCH] x86, cpu: trivial printk formatting fixes

2014-11-01 Thread Steven Honeyman
[0.012958] Freeing SMP alternatives memory: 28K (81d86000 - 81d8d000) [0.014961] dmar: Host address width 39 Signed-off-by: Steven Honeyman stevenhoney...@gmail.com --- arch/x86/kernel/cpu/common.c | 11 ++- arch/x86/kernel/cpu/intel.c | 6 ++ 2 files changed, 8

Re: [PATCH] x86, cpu: trivial printk formatting fixes

2014-11-01 Thread Steven Honeyman
On 1 November 2014 17:19, Borislav Petkov b...@alien8.de wrote: On Sat, Nov 01, 2014 at 03:44:56PM +, Steven Honeyman wrote: A 2 line printk makes dmesg output messy, because the second line does not get a timestamp. For example: [0.012863] CPU0: Thermal monitoring enabled (TM1

Re: [PATCH] x86, cpu: trivial printk formatting fixes

2014-11-01 Thread Steven Honeyman
On 1 November 2014 17:51, Borislav Petkov b...@alien8.de wrote: On Sat, Nov 01, 2014 at 05:38:18PM +, Steven Honeyman wrote: On 1 November 2014 17:19, Borislav Petkov b...@alien8.de wrote: On Sat, Nov 01, 2014 at 03:44:56PM +, Steven Honeyman wrote: A 2 line printk makes dmesg output

[PATCH] zram: trivial improvements to the startup message

2014-09-30 Thread Steven Honeyman
Originally I intended to just remove the ellipsis, because it usually signifies that something is in progress and will take some time to complete. The plural "device"/"devices" is just a bonus addition, because it was in the same line I was editing! Signed-off-by: Steven Ho

[PATCH] zram: trivial improvements to the startup message

2014-09-30 Thread Steven Honeyman
Originally I intended to just remove the ellipsis, because it usually signifies that something is in progress and will take some time to complete. The plural device/devices is just a bonus addition, because it was in the same line I was editing! Signed-off-by: Steven Honeyman stevenhoney

[PATCH] sd: assign more appropriate log levels for two messages

2014-09-13 Thread Steven Honeyman
KERN_ERR is too high severity for an "assumption" message, so I moved them down to KERN_WARNING Signed-off-by: Steven Honeyman --- drivers/scsi/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 2c2041c..bb7d

Subject: [PATCH] sdhci: change a warning message from pr_err to pr_warn

2014-09-13 Thread Steven Honeyman
This is just a warning, so I've given it a more appropriate log level Signed-off-by: Steven Honeyman --- drivers/mmc/host/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 37b2a9a..6e9ba15 100644 --- a/drivers

Subject: [PATCH] sdhci: change a warning message from pr_err to pr_warn

2014-09-13 Thread Steven Honeyman
This is just a warning, so I've given it a more appropriate log level Signed-off-by: Steven Honeyman stevenhoney...@gmail.com --- drivers/mmc/host/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 37b2a9a

[PATCH] sd: assign more appropriate log levels for two messages

2014-09-13 Thread Steven Honeyman
KERN_ERR is too high severity for an assumption message, so I moved them down to KERN_WARNING Signed-off-by: Steven Honeyman stevenhoney...@gmail.com --- drivers/scsi/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 2c2041c

[PATCH] i8k: Add support for Dell Latitude E6540

2014-09-05 Thread Steven Honeyman
Add support for the Dell Latitude E6540 which needs a different fan speed multiplier. Signed-off-by: Steven Honeyman --- drivers/char/i8k.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c index 65525c7..34174d0 100644 --- a/drivers

[PATCH] i8k: Add support for Dell Latitude E6540

2014-09-05 Thread Steven Honeyman
Add support for the Dell Latitude E6540 which needs a different fan speed multiplier. Signed-off-by: Steven Honeyman stevenhoney...@gmail.com --- drivers/char/i8k.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c index 65525c7..34174d0