[PATCH v3] ARM: dts: imx6qdl-icore: Fix OTG_ID pin and sdcard detect

2020-07-17 Thread Suniel Mahesh
pport") Cc: sta...@vger.kernel.org Signed-off-by: Michael Trimarchi Signed-off-by: Suniel Mahesh --- Changes for v3: - Changed subject of the patch, added fixes tag and copied stable kernel as suggested by Shawn Guo. Changes for v2: - Changed patch description as suggested by Michael Trimarc

[PATCH v2] arch: arm: imx6qdl-icore: Fix OTG_ID pin and sdcard detect

2020-06-19 Thread Suniel Mahesh
: host does not support reading read-only switch, assuming write-enable [ 22.459992] mmc0: new high speed SDHC card at address 0001 [ 22.469725] mmcblk0: mmc0:0001 EB1QT 29.8 GiB [ 22.478856] mmcblk0: p1 p2 Signed-off-by: Michael Trimarchi Signed-off-by: Suniel Mahesh --- Changes for v2

[PATCH] arch: arm: imx6qdl-icore: Fix OTG_ID pin and sdcard detect

2020-06-19 Thread Suniel Mahesh
, assuming write-enable [ 22.459992] mmc0: new high speed SDHC card at address 0001 [ 22.469725] mmcblk0: mmc0:0001 EB1QT 29.8 GiB [ 22.478856] mmcblk0: p1 p2 Cc: sta...@vger.kernel.org Signed-off-by: Michael Trimarchi Signed-off-by: Suniel Mahesh --- NOTE: - patch tested on i.Core 1.5

Machine specific static mappings iotable_init(), are they required ?

2019-08-06 Thread Suniel Mahesh
wrong here Can't I use ioremap and do dynamic mappings when ever required via device tree ? If I do so will I encounter any problems with vmalloc area. Thanks & Regards -- Suniel Mahesh

Re: [PATCH v3] staging: ccree: fix boolreturn.cocci warning

2017-10-19 Thread Suniel Mahesh
gs which I am working on and there by improving myself. Yeah English is not my first language, but all my education was done in English, no issues there. > > On Wed, Oct 18, 2017 at 12:11:55PM +0530, suni...@techveda.org wrote: >> From: Suniel Mahesh <suni...@techveda.org> >> &

Re: [PATCH v3] staging: ccree: fix boolreturn.cocci warning

2017-10-19 Thread Suniel Mahesh
gs which I am working on and there by improving myself. Yeah English is not my first language, but all my education was done in English, no issues there. > > On Wed, Oct 18, 2017 at 12:11:55PM +0530, suni...@techveda.org wrote: >> From: Suniel Mahesh >> >> This fixes the following

Re: [PATCH] staging: ccree: local variable "dev" not required

2017-10-05 Thread Suniel Mahesh
On Thursday 05 October 2017 11:30 PM, Joe Perches wrote: > On Thu, 2017-10-05 at 10:07 +0300, Gilad Ben-Yossef wrote: >> On Wed, Oct 4, 2017 at 10:12 PM, wrote: >>> There is no need to create a local pointer variable "dev" and >>> pass it various API's, instead use plat_dev

Re: [PATCH] staging: ccree: local variable "dev" not required

2017-10-05 Thread Suniel Mahesh
On Thursday 05 October 2017 11:30 PM, Joe Perches wrote: > On Thu, 2017-10-05 at 10:07 +0300, Gilad Ben-Yossef wrote: >> On Wed, Oct 4, 2017 at 10:12 PM, wrote: >>> There is no need to create a local pointer variable "dev" and >>> pass it various API's, instead use plat_dev which is enumerated

Re: [PATCH v2] drivers: cpufreq: Fix sysfs duplicate filename creation for platform-device

2017-09-19 Thread Suniel Mahesh
On Wednesday 20 September 2017 04:06 AM, Viresh Kumar wrote: > On 19-09-17, 10:12, Dave Gerlach wrote: >> Hi, >> On 09/18/2017 02:18 PM, suni...@techveda.org wrote: >>> From: Suniel Mahesh <suni...@techveda.org> >>> >>> ti-cpufreq and cpufreq-dt

Re: [PATCH v2] drivers: cpufreq: Fix sysfs duplicate filename creation for platform-device

2017-09-19 Thread Suniel Mahesh
On Wednesday 20 September 2017 04:06 AM, Viresh Kumar wrote: > On 19-09-17, 10:12, Dave Gerlach wrote: >> Hi, >> On 09/18/2017 02:18 PM, suni...@techveda.org wrote: >>> From: Suniel Mahesh >>> >>> ti-cpufreq and cpufreq-dt-platdev drivers are regi

Re: [PATCH] drivers: cpufreq: Fix sysfs duplicate filename creation for platform-device

2017-09-18 Thread Suniel Mahesh
On Monday 18 September 2017 06:45 AM, Viresh Kumar wrote: > On 17-09-17, 00:04, suni...@techveda.org wrote: >> From: Suniel Mahesh <suni...@techveda.org> >> >> ti-cpufreq.c and cpufreq-dt-platdev.c are registering >> platform device with same name "cpufreq-

Re: [PATCH] drivers: cpufreq: Fix sysfs duplicate filename creation for platform-device

2017-09-18 Thread Suniel Mahesh
On Monday 18 September 2017 06:45 AM, Viresh Kumar wrote: > On 17-09-17, 00:04, suni...@techveda.org wrote: >> From: Suniel Mahesh >> >> ti-cpufreq.c and cpufreq-dt-platdev.c are registering >> platform device with same name "cpufreq-dt" using >

Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

2017-07-27 Thread Suniel Mahesh
On Friday 28 July 2017 01:18 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote: >> +new_drvdata->cc_base = devm_ioremap_resource(_dev->dev, >> + req_mem_cc_regs); >> +if (IS_ERR(new_drvdata->cc_base))

Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

2017-07-27 Thread Suniel Mahesh
On Friday 28 July 2017 01:18 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote: >> +new_drvdata->cc_base = devm_ioremap_resource(_dev->dev, >> + req_mem_cc_regs); >> +if (IS_ERR(new_drvdata->cc_base))

Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

2017-07-17 Thread Suniel Mahesh
On Monday 17 July 2017 06:03 PM, Greg KH wrote: > On Sat, Jul 15, 2017 at 01:21:54PM +0530, suni...@techveda.org wrote: >> From: Suniel Mahesh <suni...@techveda.org> >> >> It is recommended to use managed function devm_kzalloc, which >> simplifies dri

Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

2017-07-17 Thread Suniel Mahesh
On Monday 17 July 2017 06:03 PM, Greg KH wrote: > On Sat, Jul 15, 2017 at 01:21:54PM +0530, suni...@techveda.org wrote: >> From: Suniel Mahesh >> >> It is recommended to use managed function devm_kzalloc, which >> simplifies driver cleanup paths and driver code. >&

Re: [PATCH] arm: dts: omap3: Remove interrupt-parent property

2017-06-26 Thread Suniel Mahesh
On Tuesday 27 June 2017 11:03 AM, kart...@techveda.org wrote: > From: Karthik Tummala > Please change the subject of the patch to something which is more meaningful and which reflect the changes done to the code base. > All nodes inhert "interrupt-parent" property from

Re: [PATCH] arm: dts: omap3: Remove interrupt-parent property

2017-06-26 Thread Suniel Mahesh
On Tuesday 27 June 2017 11:03 AM, kart...@techveda.org wrote: > From: Karthik Tummala > Please change the subject of the patch to something which is more meaningful and which reflect the changes done to the code base. > All nodes inhert "interrupt-parent" property from root > node. So removed

Re: [PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct

2017-03-17 Thread Suniel Mahesh
On Friday 10 March 2017 12:20 AM, suni...@techveda.org wrote: From: Suniel Mahesh <suni...@techveda.org> Prefer vzalloc(sizeof(*priv->pFirmware)...) over vzalloc(sizeof(struct rt_firmware)...) as reported by checkpatch.pl Signed-off-by: Suniel Mahesh <suni...@techveda.org> ---

Re: [PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct

2017-03-17 Thread Suniel Mahesh
On Friday 10 March 2017 12:20 AM, suni...@techveda.org wrote: From: Suniel Mahesh Prefer vzalloc(sizeof(*priv->pFirmware)...) over vzalloc(sizeof(struct rt_firmware)...) as reported by checkpatch.pl Signed-off-by: Suniel Mahesh --- Changes for v2: - new patch addition to the ser

Re: [PATCH v3 2/8] staging: rtl8192e: Fix coding style

2017-03-15 Thread Suniel Mahesh
On Wednesday 15 March 2017 03:44 PM, Dan Carpenter wrote: On Wed, Mar 15, 2017 at 03:21:51PM +0530, suni...@techveda.org wrote: @@ -1796,7 +1796,7 @@ static short _rtl92e_alloc_rx_ring(struct net_device *dev) for (rx_queue_idx = 0; rx_queue_idx < MAX_RX_QUEUE; rx_queue_idx++) {

Re: [PATCH v3 2/8] staging: rtl8192e: Fix coding style

2017-03-15 Thread Suniel Mahesh
On Wednesday 15 March 2017 03:44 PM, Dan Carpenter wrote: On Wed, Mar 15, 2017 at 03:21:51PM +0530, suni...@techveda.org wrote: @@ -1796,7 +1796,7 @@ static short _rtl92e_alloc_rx_ring(struct net_device *dev) for (rx_queue_idx = 0; rx_queue_idx < MAX_RX_QUEUE; rx_queue_idx++) {

[PATCH] staging: rtl8192e: fix coding style issue, improve error handling

2017-03-06 Thread Suniel Mahesh
Fix coding style issue and comments in rtl_core.c Return -ENOMEM, if it is out of memory Pointer comparison with NULL replaced by logical NOT Signed-off-by: Suniel Mahesh <suni...@techveda.org> --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 253 +++ 1 file c

[PATCH] staging: rtl8192e: fix coding style issue, improve error handling

2017-03-06 Thread Suniel Mahesh
Fix coding style issue and comments in rtl_core.c Return -ENOMEM, if it is out of memory Pointer comparison with NULL replaced by logical NOT Signed-off-by: Suniel Mahesh --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 253 +++ 1 file changed, 100 insertions(+), 153