Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

On 2019/10/17 9:51, Tan Xiaojun wrote: > On 2019/10/16 18:12, James Clark wrote: >> Hi Xiaojun, >> >>>> >>>> What do you mean when the user specifies "event:pp", if the SPE is >>>> available, configure and record the spe data directly

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

On 2019/10/16 18:12, James Clark wrote: > Hi Xiaojun, > >>> >>> What do you mean when the user specifies "event:pp", if the SPE is >>> available, configure and record the spe data directly via the perf event >>> open syscall? >>> (perf.data itself is the same as using -e arm_spe_0//xxx?) >> >>

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

On 2019/10/9 19:09, Tan Xiaojun wrote: > On 2019/10/9 17:48, James Clark wrote: >> Hi Xiaojun, >> >>> By the way, you mentioned before that you want the spe event to be in the >>> form of "event:pp" like pebs. Is that the whole framework should

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

On 2019/10/9 17:48, James Clark wrote: > Hi Xiaojun, > >> By the way, you mentioned before that you want the spe event to be in the >> form of "event:pp" like pebs. Is that the whole framework should be made >> similar to pebs? Or is it just a modification to the command format? > > We're

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

quot;-c -F, etc." is only for instructions rather than events, so it may be misunderstood by users. So I haven't figured out how to do. What do you think of this? Thanks. Xiaojun. > On 09/08/2019 07:12, Tan Xiaojun wrote: >> On 2019/8/9 5:00, Jeremy Linton wrote: >>> Hi,

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

igured out how to do. What do you think of this? Thanks. Xiaojun. > On 09/08/2019 07:12, Tan Xiaojun wrote: >> On 2019/8/9 5:00, Jeremy Linton wrote: >>> Hi, >>> >>> First thanks for posting this! >>> >>> I ran this on our DAWN platfo

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

igured out how to do. What do you think of this? Thanks. Xiaojun. > On 09/08/2019 07:12, Tan Xiaojun wrote: >> On 2019/8/9 5:00, Jeremy Linton wrote: >>> Hi, >>> >>> First thanks for posting this! >>> >>> I ran this on our DAWN platfo

Re: [RFC PATCH 3/3] perf report: add --spe options for arm-spe

ses:pp > > And then perf could use the modifier to configure SPE so that it only records > branch > misses? The benefits of this would be keeping the user interface for precise > tracing > similar between platforms. > Good suggestion. And I need to spend some time thinking a

[tip:perf/core] perf record: Support aarch64 random socket_id assignment

Commit-ID: 0a4d8fb229dd78f9e0752817339e19e903b37a60 Gitweb: https://git.kernel.org/tip/0a4d8fb229dd78f9e0752817339e19e903b37a60 Author: Tan Xiaojun AuthorDate: Fri, 2 Aug 2019 11:48:57 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 14 Aug 2019 11:00:00 -0300 perf record

Re: [RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

[.] __GI___printf_fp_l 8.33% 8.33% dd libc-2.28.so [.] _dl_addr 8.33% 8.33% dd libc-2.28.so [.] _int_malloc 8.33% 8.33% dd libc-2.28.so [.] _nl_intern_locale_data > > On 8/2/19 4:40 AM, Tan Xiaojun wrote: >> Af

[RFC PATCH 2/3] perf tools: Add support for "report" for some spe events

- After that, more analysis and processing of the raw data of spe will be done. Signed-off-by: Tan Xiaojun --- tools/perf/builtin-report.c| 5 + tools/perf/util/arm-spe-decoder/Build | 2 +- tools/perf/util/arm-spe-decoder/arm

[RFC PATCH 0/3] perf tools: Add support for "report" for some spe events

is to improve the "perf report" support for spe, and further process the data. Currently, support for the three events of llc-miss, tlb-miss, and branch-miss is added. More details in [2/3]. Tan Xiaojun (3): perf tools: Move arm-spe-pkt-decoder.h/c to the new dir perf tools: Add

[RFC PATCH 3/3] perf report: add --spe options for arm-spe

The previous patch added support in "perf report" for some arm-spe events(llc-miss, tlb-miss, branch-miss). This patch adds their help instructions. Signed-off-by: Tan Xiaojun --- tools/perf/Documentation/perf-report.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/

[RFC PATCH 1/3] perf tools: Move arm-spe-pkt-decoder.h/c to the new dir

Create a new arm-spe-decoder directory for subsequent extensions and move arm-spe-pkt-decoder.h/c to this directory. No code changes. Signed-off-by: Tan Xiaojun --- tools/perf/util/Build | 2 +- tools/perf/util/arm-spe-decoder/Build | 1 + .../util

[PATCH] perf record: Support aarch64 random socket_id assignment

st: 96-127 # # captured on: Thu Aug 1 22:58:38 2019 # header version : 1 ... # CPU 0: Core ID 0, Socket ID 36 # CPU 1: Core ID 1, Socket ID 36 ... # CPU 126: Core ID 126, Socket ID 8442 # CPU 127: Core ID 127, Socket ID 8442 ... Signed-off-by: Tan Xiaojun --- tools/perf/uti

Re: [PATCH v2] aio: add check for timeout to aviod invalid value

Any comments? Anything is fine to me. Thanks. Xiaojun. On 2019/2/25 18:09, Tan Xiaojun wrote: > Syzkaller reported a UBSAN bug below, which was mainly caused by a large > negative number passed to the timeout of the io_getevents syste

[PATCH v2] aio: add check for timeout to aviod invalid value

cussed at: https://lore.kernel.org/lkml/cact4y+bbxvylq6ltokrktnlthqlhcw-bmp3aqp3mjdavr9f...@mail.gmail.com/ Signed-off-by: Tan Xiaojun Reviewed-by: Jeff Moyer --- fs/aio.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index f4d..3a39673 100644 --- a/f

Re: [PATCH] aio: add check for timeout to aviod invalid value

I made a mistake. I will fix it and send v2. Thanks. Xiaojun. On 2019/2/25 17:42, Tan Xiaojun wrote: > Syzkaller reported a UBSAN bug below, which was mainly caused by a large > negative number passed to the timeout of the io_getevents syste

[PATCH] aio: add check for timeout to aviod invalid value

iously discussed at: https://lore.kernel.org/lkml/cact4y+bbxvylq6ltokrktnlthqlhcw-bmp3aqp3mjdavr9f...@mail.gmail.com/ Signed-off-by: Tan Xiaojun Reviewed-by: Jeff Moyer --- fs/aio.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/aio.c b/fs/aio.c index f4d..28e0fa6

Re: [RFC PATCH] aio: add check for timeout to aviod invalid value

On 2019/2/19 4:33, Jeff Moyer wrote: > Tan Xiaojun writes: > >> (When I was testing with syzkaller, I found a lot of ubsan problems. Here >> is one of them. I am not sure if it needs to be fixed and how it will be >> fixed. So I sent this patch to ask your opinion.)

[RFC PATCH] aio: add check for timeout to aviod invalid value

cribed in "man io_getevents" does not say whether it can be negative or not, but as a waiting time, a negative number has no meaning. So I add check to avoid this case. Signed-off-by: Tan Xiaojun --- fs/aio.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/aio.c

[PATCH net-next] net: hns3: add common validation in hclge_dcb

ndexed by tc num, so this patch changes them to use different index. Signed-off-by: Yunsheng Lin Signed-off-by: Tan Xiaojun --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 70 +++--- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 14 + .../net/ethernet/hisilico

[PATCH net-next] net: hns3: add common validation in hclge_dcb

ndexed by tc num, so this patch changes them to use different index. Signed-off-by: Yunsheng Lin Signed-off-by: Tan Xiaojun --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 70 +++--- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 14 + .../net/ethernet/hisilico

[Question] A UBSAN problem in stable-4.4

Hi, all, I found the following problem (attached to the end) when testing stable-4.4 with Syzkaller. This is not an easy-to-trigger problem, so the tool does not generate code for recurring problems. >From the call stack, it is because the first parameter in ktime_sub is large, >and the second

[Question] A UBSAN problem in stable-4.4

Hi, all, I found the following problem (attached to the end) when testing stable-4.4 with Syzkaller. This is not an easy-to-trigger problem, so the tool does not generate code for recurring problems. >From the call stack, it is because the first parameter in ktime_sub is large, >and the second

[Question] A UBSAN problem in stable-4.4

Hi, all, I found the following problem (attached to the end) when testing stable-4.4 with Syzkaller. This is not an easy-to-trigger problem, so the tool does not generate code for recurring problems. >From the call stack, it is because the first parameter in ktime_sub is large, >and the second

[Question] A UBSAN problem in stable-4.4

Hi, all, I found the following problem (attached to the end) when testing stable-4.4 with Syzkaller. This is not an easy-to-trigger problem, so the tool does not generate code for recurring problems. >From the call stack, it is because the first parameter in ktime_sub is large, >and the second

[PATCH] net: hns3: fix length overflow when CONFIG_ARM64_64K_PAGES

When enable the config item "CONFIG_ARM64_64K_PAGES", the size of PAGE_SIZE is 65536(64K). But the type of length is u16, it will overflow. So change it to u32. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 2 +- 1

[PATCH] net: hns3: fix length overflow when CONFIG_ARM64_64K_PAGES

When enable the config item "CONFIG_ARM64_64K_PAGES", the size of PAGE_SIZE is 65536(64K). But the type of length is u16, it will overflow. So change it to u32. Signed-off-by: Tan Xiaojun --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v2 00/12] drm: add check if io_mem_pfn is NULL and cleanup

On 2017/12/25 16:18, Christian König wrote: > Series is Reviewed-by: Christian König <christian.koe...@amd.com>. > > I'm going to pick that up for 4.16. > > Thanks for the cleanup, > Christian. > Thank you very much. Xiaojun. > Am 25.12.2017 um 04:43 schrieb T

Re: [PATCH v2 00/12] drm: add check if io_mem_pfn is NULL and cleanup

On 2017/12/25 16:18, Christian König wrote: > Series is Reviewed-by: Christian König . > > I'm going to pick that up for 4.16. > > Thanks for the cleanup, > Christian. > Thank you very much. Xiaojun. > Am 25.12.2017 um 04:43 schrieb Tan Xiaojun: >> I found an

[PATCH v2 07/12] drm/qxl: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/qxl/qxl_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/d

[PATCH v2 08/12] drm/radeon: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/radeon/radeon_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_tt

[PATCH v2 07/12] drm/qxl: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/qxl/qxl_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index

[PATCH v2 08/12] drm/radeon: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/radeon/radeon_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon

[PATCH v2 01/12] drm/ttm: add ttm_bo_io_mem_pfn to check io_mem_pfn

io_mem_pfn() as wrapper. Signed-off-by: Michal Srb <m...@suse.com> Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm

[PATCH v2 01/12] drm/ttm: add ttm_bo_io_mem_pfn to check io_mem_pfn

io_mem_pfn() as wrapper. Signed-off-by: Michal Srb Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c index c8ebb75..292d157 100644 --- a/drivers/g

[PATCH v2 09/12] drm/virtio: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/virtio/virtgpu_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_tt

[PATCH v2 09/12] drm/virtio: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/virtio/virtgpu_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio

[PATCH v2 12/12] drm/ttm: remove ttm_bo_default_io_mem_pfn

No one will use this function except ttm_bo_io_mem_pfn() now, so move the calculation of ttm_bo_default_io_mem_pfn() into ttm_bo_io_mem_pfn() and do some cleanup. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 11 ++- include/drm/ttm/ttm_bo

[PATCH v2 11/12] staging: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/staging/vboxvideo/vbox_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vboxvideo/vbox_tt

[PATCH v2 12/12] drm/ttm: remove ttm_bo_default_io_mem_pfn

No one will use this function except ttm_bo_io_mem_pfn() now, so move the calculation of ttm_bo_default_io_mem_pfn() into ttm_bo_io_mem_pfn() and do some cleanup. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 11 ++- include/drm/ttm/ttm_bo_api.h| 11 --- 2

[PATCH v2 11/12] staging: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/staging/vboxvideo/vbox_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo

[PATCH v2 00/12] drm: add check if io_mem_pfn is NULL and cleanup

of ttm_bo_default_io_mem_pfn() and do some cleanup. Tan Xiaojun (12): drm/ttm: add ttm_bo_io_mem_pfn to check io_mem_pfn drm/ast: remove the default io_mem_pfn set drm/bochs: remove the default io_mem_pfn set drm/cirrus: remove the default io_mem_pfn set drm/mgag200: remove the default io_mem_pfn set drm

[PATCH v2 00/12] drm: add check if io_mem_pfn is NULL and cleanup

of ttm_bo_default_io_mem_pfn() and do some cleanup. Tan Xiaojun (12): drm/ttm: add ttm_bo_io_mem_pfn to check io_mem_pfn drm/ast: remove the default io_mem_pfn set drm/bochs: remove the default io_mem_pfn set drm/cirrus: remove the default io_mem_pfn set drm/mgag200: remove the default io_mem_pfn set drm

[PATCH v2 04/12] drm/cirrus: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/cirrus/cirrus_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_tt

[PATCH v2 04/12] drm/cirrus: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/cirrus/cirrus_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_ttm.c b/drivers/gpu/drm/cirrus

[PATCH v2 05/12] drm/mgag200: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_tt

[PATCH v2 05/12] drm/mgag200: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c b/drivers/gpu/drm/mgag200

[PATCH v2 03/12] drm/bochs: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/bochs/bochs_mm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drive

[PATCH v2 06/12] drm/nouveau: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_b

[PATCH v2 03/12] drm/bochs: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/bochs/bochs_mm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c

[PATCH v2 06/12] drm/nouveau: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau

[PATCH v2 10/12] drm/vmwgfx: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_buffe

[PATCH v2 10/12] drm/vmwgfx: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c b/drivers/gpu/drm/vmwgfx

[PATCH v2 02/12] drm/ast: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/ast/ast_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_ttm.c b/drivers/gpu/d

[PATCH v2 02/12] drm/ast: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/ast/ast_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_ttm.c b/drivers/gpu/drm/ast/ast_ttm.c index

Re: [PATCH 01/12] drm/ttm: Use ttm_bo_default_io_mem_pfn if io_mem_pfn is NULL

On 2017/12/24 17:27, Christian König wrote: > Am 24.12.2017 um 07:14 schrieb Tan Xiaojun: >> From: Michal Srb <m...@suse.com> >> >> The io_mem_pfn field was added in commit >> ea642c3216cb2a60d1c0e760ae47ee85c9c16447 >> and is called unconditionally. Howev

Re: [PATCH 01/12] drm/ttm: Use ttm_bo_default_io_mem_pfn if io_mem_pfn is NULL

On 2017/12/24 17:27, Christian König wrote: > Am 24.12.2017 um 07:14 schrieb Tan Xiaojun: >> From: Michal Srb >> >> The io_mem_pfn field was added in commit >> ea642c3216cb2a60d1c0e760ae47ee85c9c16447 >> and is called unconditionally. However, no

[PATCH 11/12] staging: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/staging/vboxvideo/vbox_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vboxvideo/vbox_tt

[PATCH 03/12] drm/bochs: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/bochs/bochs_mm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drive

[PATCH 01/12] drm/ttm: Use ttm_bo_default_io_mem_pfn if io_mem_pfn is NULL

From: Michal Srb The io_mem_pfn field was added in commit ea642c3216cb2a60d1c0e760ae47ee85c9c16447 and is called unconditionally. However, not all drivers were updated to set it. Use the ttm_bo_default_io_mem_pfn function if a driver did not set its own. Signed-off-by: Michal

[PATCH 11/12] staging: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/staging/vboxvideo/vbox_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vboxvideo/vbox_ttm.c b/drivers/staging/vboxvideo

[PATCH 03/12] drm/bochs: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/bochs/bochs_mm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c

[PATCH 01/12] drm/ttm: Use ttm_bo_default_io_mem_pfn if io_mem_pfn is NULL

From: Michal Srb The io_mem_pfn field was added in commit ea642c3216cb2a60d1c0e760ae47ee85c9c16447 and is called unconditionally. However, not all drivers were updated to set it. Use the ttm_bo_default_io_mem_pfn function if a driver did not set its own. Signed-off-by: Michal Srb ---

[PATCH 12/12] drm/ttm: unexport ttm_bo_default_io_mem_pfn and make it static

No one will use this function except in ttm_bo_vm.c now. So unexport it and make it static. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 23 +++ include/drm/ttm/ttm_bo_api.h| 11 --- 2 files changed, 15 insertions(

[PATCH 10/12] drm/vmwgfx: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_buffe

[PATCH 10/12] drm/vmwgfx: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c b/drivers/gpu/drm/vmwgfx

[PATCH 12/12] drm/ttm: unexport ttm_bo_default_io_mem_pfn and make it static

No one will use this function except in ttm_bo_vm.c now. So unexport it and make it static. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 23 +++ include/drm/ttm/ttm_bo_api.h| 11 --- 2 files changed, 15 insertions(+), 19 deletions(-) diff

[PATCH 08/12] drm/radeon: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/radeon/radeon_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_tt

[PATCH 08/12] drm/radeon: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/radeon/radeon_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon

[PATCH 06/12] drm/nouveau: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_b

[PATCH 06/12] drm/nouveau: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau

[PATCH 07/12] drm/qxl: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/qxl/qxl_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/d

[PATCH 07/12] drm/qxl: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/qxl/qxl_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c index

[PATCH 00/12] drm: add check if io_mem_pfn is NULL and cleanup

is NULL Tan Xiaojun (11): drm/ast: remove the default io_mem_pfn set drm/bochs: remove the default io_mem_pfn set drm/cirrus: remove the default io_mem_pfn set drm/mgag200: remove the default io_mem_pfn set drm/nouveau: remove the default io_mem_pfn set drm/qxl: remove the default

[PATCH 00/12] drm: add check if io_mem_pfn is NULL and cleanup

is NULL Tan Xiaojun (11): drm/ast: remove the default io_mem_pfn set drm/bochs: remove the default io_mem_pfn set drm/cirrus: remove the default io_mem_pfn set drm/mgag200: remove the default io_mem_pfn set drm/nouveau: remove the default io_mem_pfn set drm/qxl: remove the default

[PATCH 05/12] drm/mgag200: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_tt

[PATCH 09/12] drm/virtio: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/virtio/virtgpu_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_tt

[PATCH 05/12] drm/mgag200: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c b/drivers/gpu/drm/mgag200

[PATCH 09/12] drm/virtio: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/virtio/virtgpu_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio

[PATCH 04/12] drm/cirrus: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/cirrus/cirrus_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_tt

[PATCH 04/12] drm/cirrus: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/cirrus/cirrus_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_ttm.c b/drivers/gpu/drm/cirrus

[PATCH 02/12] drm/ast: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/gpu/drm/ast/ast_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_ttm.c b/drivers/gpu/d

[PATCH 02/12] drm/ast: remove the default io_mem_pfn set

The default interface situation has been taken into the framework, so remove the default set of each module. Signed-off-by: Tan Xiaojun --- drivers/gpu/drm/ast/ast_ttm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_ttm.c b/drivers/gpu/drm/ast/ast_ttm.c index

Re: [Question] does there have another fix for ldisc crash instead of "tty: Fix ldisc crash on reopened tty" ?

On 2017/11/29 16:02, Greg KH wrote: > On Wed, Nov 29, 2017 at 03:57:51PM +0800, Tan Xiaojun wrote: >> Hi, all, >> >> I test in a Arm64 fpga board (Hisilicon D06 fpga) with >> kernel-stable-4.14.2, then I get a panic log attached in the end. >> >>

Re: [Question] does there have another fix for ldisc crash instead of "tty: Fix ldisc crash on reopened tty" ?

On 2017/11/29 16:02, Greg KH wrote: > On Wed, Nov 29, 2017 at 03:57:51PM +0800, Tan Xiaojun wrote: >> Hi, all, >> >> I test in a Arm64 fpga board (Hisilicon D06 fpga) with >> kernel-stable-4.14.2, then I get a panic log attached in the end. >> >>

[Question] does there have another fix for ldisc crash instead of "tty: Fix ldisc crash on reopened tty" ?

Hi, all, I test in a Arm64 fpga board (Hisilicon D06 fpga) with kernel-stable-4.14.2, then I get a panic log attached in the end. I found this problem try to be fixed before by the patch "tty: Fix ldisc crash on reopened tty", and it was reverted shortly thereafter

[Question] does there have another fix for ldisc crash instead of "tty: Fix ldisc crash on reopened tty" ?

Hi, all, I test in a Arm64 fpga board (Hisilicon D06 fpga) with kernel-stable-4.14.2, then I get a panic log attached in the end. I found this problem try to be fixed before by the patch "tty: Fix ldisc crash on reopened tty", and it was reverted shortly thereafter

Re: [PATCH] drivers: base: cacheinfo: support DT overrides for cache type

On 2017/11/17 19:13, Sudeep Holla wrote: > On Fri, Nov 17, 2017 at 10:13:39AM +0800, Tan Xiaojun wrote: >> On 2017/11/16 23:23, Sudeep Holla wrote: >>> >>> I assume L3 is outer non-architected system cache. >>> >> >> Yes. >> > >

Re: [PATCH] drivers: base: cacheinfo: support DT overrides for cache type

On 2017/11/17 19:13, Sudeep Holla wrote: > On Fri, Nov 17, 2017 at 10:13:39AM +0800, Tan Xiaojun wrote: >> On 2017/11/16 23:23, Sudeep Holla wrote: >>> >>> I assume L3 is outer non-architected system cache. >>> >> >> Yes. >> > >

Re: [PATCH] drivers: base: cacheinfo: support DT overrides for cache type

On 2017/11/17 10:13, Tan Xiaojun wrote: > On 2017/11/16 23:23, Sudeep Holla wrote: >> >> >> On 16/11/17 12:58, Tan Xiaojun wrote: >>> Since commit dfea747d2aba ("drivers: base: cacheinfo: support DT >>> overrides for cache properties"), we can se

Re: [PATCH] drivers: base: cacheinfo: support DT overrides for cache type

On 2017/11/17 10:13, Tan Xiaojun wrote: > On 2017/11/16 23:23, Sudeep Holla wrote: >> >> >> On 16/11/17 12:58, Tan Xiaojun wrote: >>> Since commit dfea747d2aba ("drivers: base: cacheinfo: support DT >>> overrides for cache properties"), we can se

Re: [PATCH] drivers: base: cacheinfo: support DT overrides for cache type

On 2017/11/16 23:23, Sudeep Holla wrote: > > > On 16/11/17 12:58, Tan Xiaojun wrote: >> Since commit dfea747d2aba ("drivers: base: cacheinfo: support DT >> overrides for cache properties"), we can set the correct cacheinfo >> via DT. But the cache type can't

Re: [PATCH] drivers: base: cacheinfo: support DT overrides for cache type

On 2017/11/16 23:23, Sudeep Holla wrote: > > > On 16/11/17 12:58, Tan Xiaojun wrote: >> Since commit dfea747d2aba ("drivers: base: cacheinfo: support DT >> overrides for cache properties"), we can set the correct cacheinfo >> via DT. But the cache type can't

[PATCH] drivers: base: cacheinfo: support DT overrides for cache type

t open /sys/devices/system/cpu/cpu0/cache/index3/type: No such file or directory So I think maybe we can set correct cache type via DT too. Signed-off-by: Tan Xiaojun <tanxiao...@huawei.com> --- drivers/base/cacheinfo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/dri

[PATCH] drivers: base: cacheinfo: support DT overrides for cache type

t open /sys/devices/system/cpu/cpu0/cache/index3/type: No such file or directory So I think maybe we can set correct cache type via DT too. Signed-off-by: Tan Xiaojun --- drivers/base/cacheinfo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/base/cacheinfo.c b/drivers/

Re: [bug report & help] arm64: ltp testcase "migrate_pages01" failed

On 2017/10/17 17:23, Will Deacon wrote: > On Tue, Oct 17, 2017 at 10:58:53AM +0800, Tan Xiaojun wrote: >> I'm not sure if this is the problem on arm64 numa. What do you think ? >> By the way, this testcase can be successful in any case on x86. > > To be honest, this isn't a

Re: [bug report & help] arm64: ltp testcase "migrate_pages01" failed

On 2017/10/17 17:23, Will Deacon wrote: > On Tue, Oct 17, 2017 at 10:58:53AM +0800, Tan Xiaojun wrote: >> I'm not sure if this is the problem on arm64 numa. What do you think ? >> By the way, this testcase can be successful in any case on x86. > > To be honest, this isn't a

Re: [bug report & help] arm64: ltp testcase "migrate_pages01" failed

Hi all, I'm not sure if this is the problem on arm64 numa. What do you think ? By the way, this testcase can be successful in any case on x86. Thanks. Xiaojun. On 2017/10/16 19:42, Tan Xiaojun wrote: > Hi all, > > I test ltp in Hisilicon D05 board and get a failed result about the

  1   2   >