Re: [PATCH] gigaset: stop maintaining seperately

2019-07-28 Thread Tilman Schmidt
gigaset was using (I4L and > CAPI). And many thanks to Hansjoerg Lipp and Tilman Schmidt for writing and > upstreaming this driver. > > Signed-off-by: Paul Bolle > --- > MAINTAINERS | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS

Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

2016-09-27 Thread Tilman Schmidt
lace, Paul already did show you the place. > > To which source code place do you refer here? Obviously the one Paul pointed out to you in detail in his mail dated Mon, 26 Sep 2016 23:13:54 +0200. HTH, Tilman -- Tilman Schmidt til...@imap.cc

Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

2016-09-27 Thread Tilman Schmidt
ly reclaimed > after it would return a null pointer? No. Should I? Do you? Regards, Tilman -- Tilman Schmidt til...@imap.cc

Re: [PATCH 3/5] ISDN-Gigaset: Delete an error message for a failed memory allocation

2016-09-27 Thread Tilman Schmidt
CJ16-Refactor_Strings-WSang_0.pdf > > Signed-off-by: Markus Elfring The patch is fine but the link in the commit message is irrelevant. Please remove it. (Yes, I read through the whole presentation to verify that. It was fun, even.) -- Tilman Schmidt til...@imap.cc

Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

2016-09-27 Thread Tilman Schmidt
hat is of secondary importance, and if you want to do that, as a minimum you have to make sure that you don't introduce new bugs. Thanks, Tilman -- Tilman Schmidt til...@imap.cc

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-19 Thread Tilman Schmidt
e has > ISDN support which is actively used. AFAIK none of these uses I4L anymore. Asterisk dropped I4L support with version 2 if my memory is correct and nowadays uses CAPI, mISDN or its own DAHDI interface. -- Tilman Schmidt E-Mail: til...@imap.cc Bonn, Germany

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-11 Thread Tilman Schmidt
-over-TCP service - last but not least, via the mISDNcapid daemon and mISDN Of course this cuts off anything that doesn't pass through libcapi20.so, including applications that (against the standard) access /dev/capi20 directly but also the capidrv.ko i4l compatibility shim. -- Tilman Schmidt

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-09 Thread Tilman Schmidt
Am 07.03.2016 um 09:48 schrieb Paul Bolle: > On za, 2016-03-05 at 14:08 +0100, Tilman Schmidt wrote: >> As a consequence, owners of HiSAX type adapters are in fact stuck with >> the old hisax driver if they want to continue using i4l userspace >> tools. > > Do you know

Re: [PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-05 Thread Tilman Schmidt
tristate + default ISDN_I4L help This option provides the glue code to hook up CAPI driven cards to the legacy isdn4linux link layer. If you have a card which is Jm2c, Tilman -- Tilman Schmidt E-Mail: til...@imap.cc Bonn, Germany Nous, on a des fleurs et des bougies pour nous protéger. signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/1] ser_gigaset: use container_of() instead of detour

2016-02-18 Thread Tilman Schmidt
; gigaset_device_release() to get to our struct cardstate. Which has the > net effect of leaking a struct ser_cardstate at every call of this > driver's tty close() operation. So using container_of() has the > additional benefit of actually working. > > Reported-by: Dmitry Vyukov

Re: [PATCH] gigaset: turn nonsense checks into WARN_ON

2015-12-12 Thread Tilman Schmidt
o have > a NULL tiocmset method. That in itself is probably a mistake given modern > coding practices - but needs fixing in the tty layer. > > Signed-off-by: Alan Cox Acked-by: Tilman Schmidt (Overlooking the nettling subject line.) > --- > drivers/isdn/gigaset/ser-gigaset.c |

Re: [PATCH 0/3] ser_gigaset fixes

2015-12-12 Thread Tilman Schmidt
fectly fine > with that.) I think as a maintainer you are supposed to sign off patches for the code you maintain. My signed-off as recently retired ex-maintainer was probably still good enough in July. I'm unsure whether it still is today. Regards, Tilman -- Tilman Schmidt

Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device structure

2015-12-12 Thread Tilman Schmidt
cs) >>>> + return; >>>> + dev_set_drvdata(dev, NULL); > > This is of marginal value and (I think) unnecessary; it implies > the core will use the device after release, which would trigger > many problems if true. Agreed, but I'm just moving existing code here. Dropping the dev_set_drvdata() call would be an unrelated change which should be done in a separate patch if I understand the rules correctly. Regards, Tilman -- Tilman Schmidt E-Mail: til...@imap.cc Bonn, Germany Nous, on a des fleurs et des bougies pour nous protéger. signature.asc Description: OpenPGP digital signature

Re: [PATCH 2/3] ser_gigaset: fix deallocation of platform device structure

2015-12-09 Thread Tilman Schmidt
w but > only moved around, but I think that's still an opportunity to have > another look at that code.) I'm a big fan of one change per patch. If we also want to modify the moved code then that should be done in a separate patch. It makes bisecting so much easier. Same reason why

Re: [PATCH 1/3] ser_gigaset: fix up NULL checks

2015-12-09 Thread Tilman Schmidt
Am 08.12.2015 um 23:16 schrieb One Thousand Gnomes: > The right fix as far as I can see is to remove the tests although > WARN_ON() combined with your tty->ops change might be safer. Feel free to submit a patch. >> It's pretty obvious that this should have been part of commit >> f34d7a5b7010 ("t

[PATCH 3/3] ser_gigaset: remove unnecessary kfree() calls from release method

2015-12-08 Thread Tilman Schmidt
device->platform_data and platform_device->resource are never used and remain NULL through their entire life. Drops the kfree() calls for them from the device release method. Signed-off-by: Tilman Schmidt Reported-by: Paul Bolle --- drivers/isdn/gigaset/ser-gigaset.c | 5 - 1 file c

[PATCH 1/3] ser_gigaset: fix up NULL checks

2015-12-08 Thread Tilman Schmidt
Commit f34d7a5b changed tty->driver to tty->ops but left NULL checks for tty->driver untouched. Fix. Signed-off-by: Tilman Schmidt Fixes: f34d7a5b7010 ("tty: The big operations rework") --- drivers/isdn/gigaset/ser-gigaset.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 2/3] ser_gigaset: fix deallocation of platform device structure

2015-12-08 Thread Tilman Schmidt
When shutting down the device, the struct ser_cardstate must not be kfree()d immediately after the call to platform_device_unregister() since the embedded struct platform_device is still in use. Move the kfree() call to the release method instead. Signed-off-by: Tilman Schmidt Fixes

[PATCH 0/3] ser_gigaset fixes

2015-12-08 Thread Tilman Schmidt
en through the cracks in my last series. Patch 2/3 should go into stable releases all the way back to 2.6.32. It applies cleanly to release 3.*/4.* with at most offset 1. For release 2.6.32 there is a trivial merge conflict with a removed comment line. Thanks, Tilman Tilman Schmidt (3): ser_gi

Re: gigaset: freeing an active object

2015-12-07 Thread Tilman Schmidt
n't claim anything like completeness for mine. > In the mean time you might want to turn your patch into something that > can actually be applied (with or without my Sign-off or Ack; I don't > care how it finds its way into the tree). Please add add > Fixes: 2869b23e4b95 (&q

Re: gigaset: freeing an active object

2015-12-07 Thread Tilman Schmidt
Am 06.12.2015 um 21:12 schrieb Paul Bolle: > On zo, 2015-12-06 at 16:29 +0100, Tilman Schmidt wrote: >> So the solution might be as simple as moving the kfree() call from >> gigaset_freecshw() to gigaset_device_release(). Something like this: >> >> --- a/drivers/isdn/gig

Re: gigaset: freeing an active object

2015-12-06 Thread Tilman Schmidt
latform_device(dev); + struct cardstate *cs = dev_get_drvdata(dev); - /* adapted from platform_device_release() in drivers/base/platform.c */ - kfree(dev->platform_data); - kfree(pdev->resource); + if (!cs) + return; + dev_set_drvdata(dev, NULL); + kfree(cs->hw.ser); + cs->hw.ser = NULL; } /* (Off the top of my hat, completely untested, don't even know if that will compile.) -- Tilman Schmidt E-Mail: til...@imap.cc Bonn, Germany Nous, on a des fleurs et des bougies pour nous protéger. signature.asc Description: OpenPGP digital signature

Re: gigaset: freeing an active object

2015-12-01 Thread Tilman Schmidt
le value, but it has never been anything but 1 in the entire in-tree history of the driver.) -- Tilman Schmidt E-Mail: til...@imap.cc Bonn, Germany Nous, on a des fleurs et des bougies pour nous protéger. signature.asc Description: OpenPGP digital signature

Re: gigaset: freeing an active object

2015-11-30 Thread Tilman Schmidt
is (malloc'ed and) free'd. I wonder how that will behave if someone attaches two of the devices to different serial ports. Not likely, but not forbidden either. Regards, Tilman -- Tilman Schmidt E-Mail: til...@imap.cc Bonn, Germany Nous, on a des fleurs et

Re: gigaset: freeing an active object

2015-11-29 Thread Tilman Schmidt
t. [...] > The platform_device embedded in struct ser_cardstate hasn't been released when > you kfree() the memory it's in. Btw I don't see a timer_list object in struct platform_device either. Nor in the embedded struct device. -- Tilman Schmidt

Re: gigaset: freeing an active object

2015-11-29 Thread Tilman Schmidt
Am 29.11.2015 um 19:22 schrieb Peter Hurley: > On 11/29/2015 10:30 AM, Tilman Schmidt wrote: >> >> Judging from the backtrace below this must be the call >> >> kfree(cs->hw.ser); >> >> in drivers/isdn/gigaset/ser-gigaset.c line 375. >

Re: gigaset: freeing an active object

2015-11-29 Thread Tilman Schmidt
freecshw+0xe1/0x120 There are functions by this name in all three Gigaset hardware dependent modules (bas_gigaset, ser_gigaset and usb_gigaset), but ... > [ 413.562723] [] gigaset_freecs+0x2ad/0x600 > [ 413.564240] [] gigaset_tty_close+0x210/0x280 this function only exists in ser_gigaset.

Re: [PATCH 3.12 16/33] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-11-04 Thread Tilman Schmidt
Hi Paul, Am 19.10.2015 um 11:09 schrieb Paul Bolle: > On ma, 2015-10-12 at 11:18 +0200, Tilman Schmidt wrote: >> While it doesn't make any sense indeed to run two instances of >> ldattach >> in parallel on one and the same serial port, it is entirely conceivable &

Re: [PATCH 3.12 16/33] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-10-12 Thread Tilman Schmidt
Paul, Am 06.10.2015 um 23:00 schrieb Paul Bolle: > On ma, 2015-09-21 at 18:07 +0200, Tilman Schmidt wrote: >> Am 21.09.2015 um 15:13 schrieb Peter Hurley: >>> ??? >>> >>> The tool you authored will do it from the command line >>> >>> $ ld

[PATCH v2] Documentation: improve line discipline method descriptions

2015-09-29 Thread Tilman Schmidt
Mention that the ldisc open method must set tty->receive_room, and that many methods are optional. Add description of receive_buf2 method. Signed-off-by: Tilman Schmidt --- Documentation/serial/tty.txt | 60 1 file changed, 39 insertions(+),

Re: [PATCH 3.12 16/33] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-09-21 Thread Tilman Schmidt
Am 21.09.2015 um 18:54 schrieb Peter Hurley: > On 09/21/2015 09:38 AM, Tilman Schmidt wrote: >> Am 21.09.2015 um 15:13 schrieb Peter Hurley: >>> On 09/18/2015 08:38 AM, Tilman Schmidt wrote: >>>> Am 17.09.2015 um 20:13 schrieb Peter Hurley: >>>>> On

Re: [PATCH 3.12 16/33] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-09-21 Thread Tilman Schmidt
Am 21.09.2015 um 15:13 schrieb Peter Hurley: > On 09/18/2015 08:38 AM, Tilman Schmidt wrote: >> Am 17.09.2015 um 20:13 schrieb Peter Hurley: [...] >>> So for example, if you manually set N_PPP (as if by user error) >> >> User error wouldn't suffice, as the L

Re: [PATCH 3.12 16/33] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-09-21 Thread Tilman Schmidt
Am 21.09.2015 um 15:13 schrieb Peter Hurley: > On 09/18/2015 08:38 AM, Tilman Schmidt wrote: >> Am 17.09.2015 um 20:13 schrieb Peter Hurley: >>> On Wed, Sep 16, 2015 at 7:26 AM, Tilman Schmidt wrote: [...] >>>> - The requirement for line disciplines to set receive_r

Re: [PATCH 3.12 16/33] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-09-18 Thread Tilman Schmidt
Am 17.09.2015 um 20:13 schrieb Peter Hurley: > On Wed, Sep 16, 2015 at 7:26 AM, Tilman Schmidt wrote: >> Am 16.09.2015 um 03:18 schrieb Peter Hurley: >>> On Tue, Sep 15, 2015 at 8:37 PM, Tilman Schmidt wrote: >>>> Am 16.09.2015 um 01:08 schrieb Peter Hurley: >&

Re: [PATCH 3.12 16/33] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-09-16 Thread Tilman Schmidt
Am 16.09.2015 um 03:18 schrieb Peter Hurley: > On Tue, Sep 15, 2015 at 8:37 PM, Tilman Schmidt wrote: >> Am 16.09.2015 um 01:08 schrieb Peter Hurley: >>> On Tue, Sep 15, 2015 at 10:22 AM, Jiri Slaby wrote: >>> >>> From: Tilman Schmidt >>> >>

Re: [PATCH 3.12 16/33] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-09-15 Thread Tilman Schmidt
Am 16.09.2015 um 01:08 schrieb Peter Hurley: > On Tue, Sep 15, 2015 at 10:22 AM, Jiri Slaby <mailto:jsl...@suse.cz>> wrote: > > From: Tilman Schmidt > > 3.12-stable review patch. If anyone has any objections, please let > me know. > > ==

Re: [PATCH 1/2] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-07-13 Thread Tilman Schmidt
Am 14.07.2015 um 01:14 schrieb Peter Hurley: > On 07/13/2015 06:37 PM, Tilman Schmidt wrote: >> Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"), >> first merged in kernel release 3.10, caused the following regression >> in the Gigaset M

[PATCH 2/2] isdn/gigaset: drop unused ldisc methods

2015-07-13 Thread Tilman Schmidt
The line discipline read and write methods are optional so the dummy methods in ser_gigaset are unnecessary and can be removed. Signed-off-by: Tilman Schmidt --- drivers/isdn/gigaset/ser-gigaset.c | 24 1 files changed, 0 insertions(+), 24 deletions(-) diff --git a

[PATCH 0/2] Fix long-standing regression in ser_gigaset ISDN driver

2015-07-13 Thread Tilman Schmidt
This series fixes a serious regression in the Gigaset M101 driver introduced in kernel release 3.10 and removes some unneeded code. Please also queue up patch 1 of the series for inclusion in the stable/longterm releases 3.10 and later. Tilman Schmidt (2): isdn/gigaset: reset tty->receive_r

[PATCH 1/2] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-07-13 Thread Tilman Schmidt
e value in the ldisc open method. Fixes: 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc") Signed-off-by: Tilman Schmidt --- drivers/isdn/gigaset/ser-gigaset.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/gigaset/ser-gi

[PATCH] Documentation: improve line discipline method descriptions

2015-07-13 Thread Tilman Schmidt
Mention that the ldisc open method must reset tty->receive_room, and that many methods are optional. Add description of receive_buf2 method. Signed-off-by: Tilman Schmidt --- Documentation/serial/tty.txt | 59 +++--- 1 files changed, 38 insertions(+),

Re: isdn: pcbit: another off-by-one issue?

2015-06-30 Thread Tilman Schmidt
ndidate for porting to the kernel CAPI interface, had anyone bothered. Which reinforces the impression that no-one is using this anymore. Note also that the FTP URL mentioned in Documentation/isdn/README.pcbit doesn't exist anymore. -- Tilman Schmidt E-Mail: til

[PATCH] isdn/gigaset: cede maintainership

2015-05-02 Thread Tilman Schmidt
As German phone operators are discontinuing ISDN service, neither Hansjörg nor I will be able to maintain the Gigaset ISDN drivers any longer. Paul Bolle offered to step into the breach for odd fixes. Signed-off-by: Tilman Schmidt Acked-by: Paul Bolle --- MAINTAINERS | 5 ++--- 1 file changed

Re: Kill I4L?

2015-02-09 Thread Tilman Schmidt
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 09.02.2015 um 11:07 schrieb Bas Peters: > 2015-02-09 0:59 GMT+01:00 Karsten Keil : >> Am 08.02.2015 um 20:47 schrieb Tilman Schmidt: >>> Am 07.02.2015 um 21:43 schrieb Paul Bolle: >>>> [M]aybe we should consider, say

Kill I4L? (was: [PATCH 2/6] drivers: isdn: act2000: capi.c: fix checkpatch errors)

2015-02-08 Thread Tilman Schmidt
It is still available, though, for use with adapters that are not - - supported by the new CAPI subsystem yet. - - source "drivers/isdn/i4l/Kconfig" menuconfig ISDN_CAPI and working its way from that to remove anything that's become unreachable. Shall I?

Re: make allyesconfig i386 build failure with next-20150122 (caused by fb_agm1264k-fl driver)

2015-01-27 Thread Tilman Schmidt
Am 27.01.2015 um 03:42 schrieb Guenter Roeck: > On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote: >> On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote: >>> On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote: make ARCH=i386 allyesconfig fails with drivers/staging/bu

Re: [PATCH] isdn:gigaset:Remove unneeded TODO comment for the function,gigaset_procinfo in capi.c

2015-01-18 Thread Tilman Schmidt
uild the name string but returns the already > generated one passed to gigaset_procinfo by the structure passed > to this function. > > Signed-off-by: Nicholas Krause Acked-by: Tilman Schmidt Thanks, Tilman > --- > drivers/isdn/gigaset/capi.c | 6 +++--- > 1 file change

Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2015-01-03 Thread Tilman Schmidt
dev_get_drvdata(dev); > - long int value; > - char *end; > + long int *value; > + int result; > > - value = simple_strtol(buf, &end, 0); > - while (*end) > - if (!isspace(*end++)) > - return -EINVAL

Re: [PATCH] drivers:isdn: Remove uneeded fix me comment in capi.c for the function,decode_ie

2015-01-02 Thread Tilman Schmidt
der to myself to do so eventually but obviously didn't succeed. :-) So let's leave it for now. Thanks, Tilman -- Tilman Schmidt E-Mail: til...@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar

Re: [PATCH] drivers:isdn: Remove uneeded fix me comment in capi.c for the function,decode_ie

2015-01-01 Thread Tilman Schmidt
/gigaset/capi.c @@ > -182,7 +182,6 @@ static void decode_ie(u8 *in, char *out) { int i = > *in; while (i-- > 0) { - /* ToDo: conversion to upper case > necessary? */ *out++ = toupper(hex_asc_hi(*++in)); *out++ = > toupper(hex_asc_lo(*in)); } > - -- Tilman Schmidt

Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2015-01-01 Thread Tilman Schmidt
ts own instead of just returning an error code to the caller as it should. > --- a/drivers/isdn/gigaset/usb-gigaset.c +++ > b/drivers/isdn/gigaset/usb-gigaset.c > default: rate = 9600; - dev_err(cs->dev, "unsupported baudrate > request 0x%x,"

Re: [PATCH] isdn/bas_gigaset: use USB API functions rather than constants

2014-08-17 Thread Tilman Schmidt
; \(USB_ENDPOINT_NUMBER_MASK\|0x0f\)) > + usb_endpoint_num(epd) > > Signed-off-by: Himangi Saraogi > Acked-by: Julia Lawall Acked-by: Tilman Schmidt Thanks, Tilman > --- > drivers/isdn/gigaset/bas-gigaset.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > &g

Re: [PATCH] isdn/gigaset: use USB API functions rather than constants

2014-08-16 Thread Tilman Schmidt
; \(USB_ENDPOINT_NUMBER_MASK\|0x0f\)) > + usb_endpoint_num(epd) > > Signed-off-by: Himangi Saraogi > Acked-by: Julia Lawall Acked-by: Tilman Schmidt Nice. Are you planning a similar patch for bas-gigaset.c too? Otherwise I'll prepare one myself. Thanks, Tilman > --- >

Re: [PATCH] isdn/bas_gigaset: fix a leak on failure path in gigaset_probe()

2014-07-26 Thread Tilman Schmidt
Am 26.07.2014 00:34, schrieb Alexey Khoroshilov: > There is a lack of usb_put_dev(udev) on failure path in gigaset_probe(). You're right. Good catch. > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Acked-b

Re: [PATCH 1/7] isdn: replace del_timer by del_timer_sync

2014-03-28 Thread Tilman Schmidt
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 26.03.2014 22:33, schrieb Julia Lawall: > From: Julia Lawall > > Use del_timer_sync to ensure that the timer is stopped on all CPUs > before the driver exists. Surely you meant "exits"? Regards, Tilman

Re: [PATCH net-next v3 1/3] random32: add prandom_u32_max and convert open coded users

2014-01-19 Thread Tilman Schmidt
uot; is consistently mistyped as "pseduo" in this comment. (Three occurrences.) You may want to correct this before it gets merged. Thanks, Tilman - -- Tilman Schmidt E-Mail: til...@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwertete

[3.10] [nouveau] INFO: possible circular locking dependency detected

2013-07-28 Thread Tilman Schmidt
<4>[ 23.246558] [] rest_init+0xc1/0xc8 <4>[ 23.246558] [] ? rest_init+0x40/0xc8 <4>[ 23.246558] [] start_kernel+0x3da/0x3e7 <4>[ 23.246558] [] ? repair_env_string+0x56/0x56 <4>[ 23.246558] [] x86_64_start_reservations+0x2a/0x2c <4>[ 23.246558] []

Re: [PATCH 0/6] ISDN patches for net-next

2013-01-22 Thread Tilman Schmidt
: stable for networking > patches, you ask me to queue them up into my -stable patch queue > for networking instead. I see. Is there somewhere I can read up on the workflow for networking patches and how it fits in with the general plan of things? Thanks, Tilman -- Tilman Schmidt

[PATCH 0/6] ISDN patches for net-next

2013-01-21 Thread Tilman Schmidt
Karsten, David, here's a series of six patches to the ISDN subsystem. Please consider for application to net-next. The last one should also go into -stable and is tagged "CC: stable" accordingly. Thanks, Tilman Tilman Schmidt (6): isdn/divert: fix readability damage

[PATCH 6/6] isdn/gigaset: fix zero size border case in debug dump

2013-01-21 Thread Tilman Schmidt
If subtracting 12 from l leaves zero we'd do a zero size allocation, leading to an oops later when we try to set the NUL terminator. Reported-by: Dan Carpenter Signed-off-by: Tilman Schmidt CC: stable --- drivers/isdn/gigaset/capi.c |2 ++ 1 files changed, 2 insertions(+), 0 dele

[PATCH 2/6] isdn/gigaset: leave DLE mode before hanging up

2013-01-21 Thread Tilman Schmidt
Some firmware releases of Gigaset M105 do not accept AT+VLS=0 command in DLE mode, so always leave DLE mode before sending the command. Signed-off-by: Tilman Schmidt --- drivers/isdn/gigaset/ev-layer.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/isdn

[PATCH 4/6] isdn/gigaset: beautify common.c

2013-01-21 Thread Tilman Schmidt
Rearrange the gigaset_freecs() function to make it more readable, and adapt gigaset_initcs() accordingly. Signed-off-by: Tilman Schmidt --- drivers/isdn/gigaset/common.c | 31 +-- 1 files changed, 9 insertions(+), 22 deletions(-) diff --git a/drivers/isdn/gigaset

[PATCH 3/6] isdn/gigaset: beautify interface.c

2013-01-21 Thread Tilman Schmidt
Avoid forward declarations and remove a needless initialization. Signed-off-by: Tilman Schmidt --- drivers/isdn/gigaset/interface.c | 46 - 1 files changed, 15 insertions(+), 31 deletions(-) diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn

[PATCH 1/6] isdn/divert: fix readability damage

2013-01-21 Thread Tilman Schmidt
Fix up some of the readibility deterioration caused by last year's ISDN whitespace coding style cleanup. Note that the checkpatch complaints all apply to the state of the source before this patch as well, and in many cases even more so. Signed-off-by: Tilman Schmidt --- drivers/isdn/d

[PATCH 5/6] isdn/gigaset: beautify ev-layer.c

2013-01-21 Thread Tilman Schmidt
Cosmetic changes to drivers/isdn/gigaset/ev-layer.c and drivers/isdn/gigaset/gigaset.h to improve readability. Signed-off-by: Tilman Schmidt --- drivers/isdn/gigaset/ev-layer.c | 119 +++ drivers/isdn/gigaset/gigaset.h |9 ++- 2 files changed, 64

Re: Regression: Bacula jobs fail with kernel 3.8-rc1

2013-01-04 Thread Tilman Schmidt
20 minutes spooling appears to be part of the problem; a job which aborted after 20 mins on 3.7.1 completed in 3 mins on 3.6.11. -- Tilman SchmidtE-Mail: til...@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens ha

Regression: Bacula jobs fail with kernel 3.8-rc1

2012-12-31 Thread Tilman Schmidt
Adaptec 29160B Ultra160 SCSI adapter driving a Tandberg TS400 LTO-2 tape drive openSUSE 11.4 userspace Bacula 5.2.12, all daemons on the same machine, spooling to local disk Regards, Tilman -- Tilman SchmidtE-Mail: til...@imap.cc Bonn, Germany Diese Nachricht besteht zu 100

Re: [3.5.y.z extended stable] Linux 3.5.7.2

2012-12-21 Thread Tilman Schmidt
m/ubuntu/linux.git linux-3.5.y Is there a rollup patch against 3.5.7 available somewhere? I'm very interested in this as I'm currently forced to stay with kernel 3.5 (or revert to something even older) because of the unresolved hangs of 3.6+ on my development machine. Thanks

Re: possible regression in kernel 3.6 and 3.7-rc: system hangs during nightly tape backup

2012-12-05 Thread Tilman Schmidt
o anything to help hunting this down? Am 20.11.2012 01:14, schrieb Tilman Schmidt: > For the 4th time now after switching to kernel 3.6, my system became > unresponsive during the nightly Bacula backup run. It looks as if > all disk accesses are suddenly blocked: > - Desktop apps sto

Re: possible regression in kernel 3.6: system hangs during nightly tape backup

2012-11-24 Thread Tilman Schmidt
;s any interest. Am 20.11.2012 01:14, schrieb Tilman Schmidt: > For the 4th time now after switching to kernel 3.6, my system became > unresponsive during the nightly Bacula backup run. It looks as if > all disk accesses are suddenly blocked: > - Desktop apps stop responding one a

Re: possible regression in kernel 3.6: system hangs during nightly tape backup

2012-11-20 Thread Tilman Schmidt
ttp://www.phoenixsoftware.de/~ts/kernel36hang/ along with the .config of the kernel running at the time. -- Tilman SchmidtE-Mail: til...@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) si

possible regression in kernel 3.6: system hangs during nightly tape backup

2012-11-19 Thread Tilman Schmidt
oneer DVR-216D DVD-RW drive Adaptec 29160B Ultra160 SCSI adapter driving a Tandberg TS400 LTO-2 tape drive Disk configuration: md RAID1, LVM, ext3 and ext4 volumes Software: Opensuse 11.4 64 bit, vanilla kernel 3.5.7 and 3.6.7, Bacula 5.2.12 HTH T. -- Tilman SchmidtE-Mail: til.

Re: [PATCH 9/9] TTY: call tty_port_destroy in the rest of drivers

2012-11-18 Thread Tilman Schmidt
tty_port_destroy(&cs->port); > error: > gig_dbg(DEBUG_INIT, "failed"); > gigaset_freecs(cs); You have already added a tty_port_destroy() call to gigaset_freecs(cs) above. Adding another one here will lead to the port being destroyed twice in this code path. Thanks, Tilman -- Tilman SchmidtE-Mail: til...@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) signature.asc Description: OpenPGP digital signature

Re: [PATCH 1/1] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES

2012-11-12 Thread Tilman Schmidt
ns which could work just fine without network devices. But I guess not many kernels will actually be built with CONFIG_NETDEVICES=n, so the inconvenience is small. -- Tilman SchmidtE-Mail: til...@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Un

Re: [PATCH] isdn/gigaset: use tasklet_kill in device remove/release process

2012-11-02 Thread Tilman Schmidt
c, never have a chance to be excuted. This might > lead to a heavy loaded ksoftirqd, wakeup with pending_softirq, but > tasklet is disabled. tasklet_kill should be used in this case. > > Signed-off-by: Xiaotian Feng > Cc: Hansjoerg Lipp > Cc: Tilman Schmidt > Cc:

[PATCH] bas_gigaset: fix pre_reset handling

2012-10-24 Thread Tilman Schmidt
ed by int_in_work() this might cause int_in_work() to run after the post_reset method, with urb_int_in already resubmitted, so handle that case gracefully. Signed-off-by: Tilman Schmidt --- drivers/isdn/gigaset/bas-gigaset.c | 19 --- 1 files changed, 16 insertions(+), 3 deletions(-)

Re: [PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree

2012-09-13 Thread Tilman Schmidt
Am 12.09.2012 17:06, schrieb Peter Senna Tschudin: > From: Peter Senna Tschudin > > Remove useless kfree() and clean up code related to the removal. > > The semantic patch that finds this problem is as follows: [...] > > Signed-off-by: Peter Senna Tschudin Ack

Re: Plans for mISDN?

2008-02-25 Thread Tilman Schmidt
a design document available? Or will there be some non-PCI driver soon, perhaps even one for a USB device? That would be immensely helpful. Thanks, Tilman -- Tilman SchmidtE-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits

Re: 2.6.25-rc2-mm1 - several bugs and a crash

2008-02-25 Thread Tilman Schmidt
Paul E. McKenney schrieb: On Fri, Feb 22, 2008 at 01:52:53AM +0100, Tilman Schmidt wrote: So the nf_conntrack BUG is fixed, but the crash (and of course the swapper "spinlock bad magic" BUG) persists. Do you have CONFIG_DEBUG_PREEMPT set? That would help find any other bugs

Re: 2.6.25-rc2-mm1 - several bugs and a crash

2008-02-21 Thread Tilman Schmidt
Am 22.02.2008 01:40 schrieb Tilman Schmidt: >> >> [NETFILTER]: nf_conntrack: fix smp_processor_id() in preemptible code >> warning > > Yes, it does; and the system also survives substantially longer. > (IOW, it hasn't crashed on me so far.) Which of course it

Re: 2.6.25-rc2-mm1 - several bugs and a crash

2008-02-21 Thread Tilman Schmidt
[NETFILTER]: nf_conntrack: fix smp_processor_id() in preemptible code > warning Yes, it does; and the system also survives substantially longer. (IOW, it hasn't crashed on me so far.) Thanks, T. -- Tilman Schmidt E-Mail: [EMAIL PROTECTED] Bonn, Germa

Re: 2.6.25-rc2-mm1 - several bugs and a crash

2008-02-21 Thread Tilman Schmidt
Am 21.02.2008 17:46 schrieb Christoph Hellwig: > On Thu, Feb 21, 2008 at 04:38:28AM -0800, Andrew Morton wrote: >> (net-related cc's removed) >> >> This look like a startup ordering bug in mnt_want_write(). > > Do you have CONFIG_ACPI_CUSTOM_DSDT_INITRD set? Negat

Re: Plans for mISDN?

2008-02-20 Thread Tilman Schmidt
t, mISDN must also be in-tree, otherwise an in-tree driver cannot rely on it. And second, someone must understand both the old driver and the mISDN framework in order to be able to actually do the porting. The maintainer of the old driver can provide the first part, but knowledge about mISDN will

[2.6.25-rc2] Drivers sd, sr, st, osst need updating - please use bus_type methods

2008-02-20 Thread Tilman Schmidt
/01/01 21:13:34 wriede Exp $ <4>[ 22.930554] Driver 'osst' needs updating - please use bus_type methods Just thought I'd let you know. -- Tilman Schmidt E-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ung

Re: Plans for mISDN?

2008-02-20 Thread Tilman Schmidt
ually, yes. But I find it unusually hard in this particular case. In fact I have been trying to do that for two years now, without getting anywhere. Reading code without a hint of what the authors are trying to do is terribly time-consuming, to put it mildly. Thanks, T. -- Tilman Schmidt

Re: Plans for mISDN? Was: [PATCH 00/14] [ISDN] ...

2008-02-20 Thread Tilman Schmidt
ssing documentation. The step after that is to convert the remaining isdn4linux drivers to mISDN. Then you can remove isdn4linux. HTH T. -- Tilman SchmidtE-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltba

Re: Plans for mISDN? Was: [PATCH 00/14] [ISDN] ...

2008-02-20 Thread Tilman Schmidt
. Regards, Tilman (maintainer of an isdn4linux driver, waiting desperately for documentation on how to convert to the new CAPI/mISDN world but tired of asking for it in vain) -- Tilman SchmidtE-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederv

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-19 Thread Tilman Schmidt
r for that again even if there is a previous setting. HTH T. -- Tilman SchmidtE-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) signature.asc Description: OpenPGP digital signature

Re: Unable to continue testing of 2.6.25

2008-02-18 Thread Tilman Schmidt
David Miller schrieb: From: Tilman Schmidt <[EMAIL PROTECTED]> Date: Sun, 17 Feb 2008 20:24:56 +0100 No, that's not the real problem. Even if the kernel didn't lack any required functionality and it could all be done today without VirtualBox, pulling the rug from underneath it

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-18 Thread Tilman Schmidt
re you set "write_cache_state = 1" in /etc/lvm.conf before running the above. That was already set by default. Thanks, Tilman -- Tilman SchmidtE-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar b

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-17 Thread Tilman Schmidt
Am 16.02.2008 23:37 schrieb Jiri Slaby: On 02/16/2008 09:12 PM, Alan Cox wrote: On Sat, 16 Feb 2008 20:14:30 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: 2.6.25-rc2 fails to bring up my openSUSE 10.3 PC because LVM cannot find the volume group containing the root file system. 2.6.

Re: Unable to continue testing of 2.6.25

2008-02-17 Thread Tilman Schmidt
redesign their working environment. Sticking to the removal schedule could have avoided that. HTH T. -- Tilman Schmidt E-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite)

assigning a line discipline to a serial device from inside the kernel

2008-01-16 Thread Tilman Schmidt
the kernel? Thanks, Tilman -- Tilman SchmidtE-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) signature.asc Description: OpenPGP digital signature

Re: where to maintain userspace daemon for line discipline

2008-01-16 Thread Tilman Schmidt
going, so it's a good place. I have asked on the util-linux-ng mailing list but received a flat refusal by Karel: I don't think that util-linux-ng is there for this purpose. It's not place for HW specific tools. Sorry. Back to square one. -- Tilman Schmidt

Re: Fw: G965 & on-board serial port

2008-01-15 Thread Tilman Schmidt
driver. The port works purrfectly fine, including non-trivial use of the modem control lines. I'm sure I would have noticed any existing problems by now. HTH T. -- Tilman Schmidt E-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwer

Re: where to maintain userspace daemon for line discipline

2008-01-15 Thread Tilman Schmidt
proceed in order to get this included in util-linux-ng? Thanks, Tilman -- Tilman Schmidt E-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) signature.asc Descriptio

Re: [2.6.22.1] spurious (?) message "BUG: lock held at task exit time"

2007-12-13 Thread Tilman Schmidt
/5970 is exiting with locks still held! > 1 lock held by gigasetm101d/5970: > #0: (&cs->hw.ser->dead_mutex){--..}, at: [] mutex_lock+0x1c/0x1f [...] > Who is at fault here? Ok, I accidentally solved this myself now, so please don't bother answering. -- Tilman Sc

Re: git guidance

2007-11-29 Thread Tilman Schmidt
ead at leisure instead of having to sit through a one hour videostream, that would be nice. -- Tilman SchmidtE-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) signature.a

Re: git guidance

2007-11-29 Thread Tilman Schmidt
Haavard Skinnemoen schrieb: > > No, use "git rebase --interactive" ;-) What's that? I can't find it in "man git-rebase". -- Tilman SchmidtE-Mail: [EMAIL PROTECTED] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bit

Re: git guidance

2007-11-28 Thread Tilman Schmidt
On Nov 27 2007 23:33, Tilman Schmidt wrote: >> > >> >Well, it did. So now I'm back to keeping a virgin kernel source tree >> >alongside my development area in order to produce diffs. That can't >> >be right? >> > >> No, it can't. Use

  1   2   3   >