Re: [Linux-kernel-mentees] [PATCH net] net/smc: Prevent kernel-infoleak in __smc_diag_dump()

On 8/1/20 9:44 PM, Peilin Ye wrote: > __smc_diag_dump() is potentially copying uninitialized kernel stack memory > into socket buffers, since the compiler may leave a 4-byte hole near the > beginning of `struct smcd_diag_dmbinfo`. Fix it by initializing `dinfo` > with memset(). > > Cc:

Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI

On 9/24/19 4:52 PM, David Miller wrote: > From: Eugene Syromiatnikov > Date: Fri, 20 Sep 2019 17:41:47 +0200 > >> As of now, it's a bit difficult to use SMC protocol, as significant part >> of definitions related to it are defined in private headers and are not >> part of UAPI. The following

Re: [PATCH net v2 0/3] net/smc: move some definitions to UAPI

On 9/20/19 5:41 PM, Eugene Syromiatnikov wrote: > Hello. > > As of now, it's a bit difficult to use SMC protocol, as significant part > of definitions related to it are defined in private headers and are not > part of UAPI. The following commits move some definitions to UAPI, > making them

Re: [PATCH] s390/qeth: fix spelling mistake "alocpool" -> "allocpool"

On 9/11/19 5:35 PM, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in QETH_CARD_TEXT text. Fix it. > This spelling mistake is intended, because this qeth trace area is defined for 8 byte length entries. We try to make the entries as speaking as possible - even at

Re: general protection fault in __smc_diag_dump

On 01/02/2019 12:29 PM, Eric Dumazet wrote: > > > On 01/02/2019 02:41 AM, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:    28e8c4bc8eb4 Merge tag 'rtc-4.21' of git://git.kernel.org/.. >> git tree:   upstream >> console output:

Re: [PATCH v2] net/smc: fix TCP fallback socket release

On 12/18/2018 08:03 AM, Myungho Jung wrote: > On Mon, Dec 17, 2018 at 03:58:58PM +0100, Ursula Braun wrote: >> > > Hi Ursula, > > Thank you for your suggestion. I have a question on your comment. > >> >> On 12/17/2018 06:21 AM, Myungho Jung wrot

Re: [PATCH v2] net/smc: fix TCP fallback socket release

On 12/17/2018 06:21 AM, Myungho Jung wrote: > clcsock can be released while kernel_accept() references it in TCP > listen worker. Also, clcsock needs to wake up before released if TCP > fallback is used and the clcsock is blocked by accept. Add a lock to > safely release clcsock and call

[PATCH net 1/5] net/smc: fix non-blocking connect problem

finished. Thus in state SMC_INIT this patch now calls sock_poll_wait() on the main SMC socket. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index 2d8a1e15e4f9..9c3976bcde46 100644

[PATCH net 1/5] net/smc: fix non-blocking connect problem

finished. Thus in state SMC_INIT this patch now calls sock_poll_wait() on the main SMC socket. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index 2d8a1e15e4f9..9c3976bcde46 100644

Re: [PATCH net-next] net/smc: cast sizeof to int for comparison

On 09/15/2018 12:00 PM, YueHaibing wrote: > Comparing an int to a size, which is unsigned, causes the int to become > unsigned, giving the wrong result. kernel_sendmsg can return a negative > error code. > Thanks for reporting this issue! > Signed-off-by: YueHaibing > --- >

Re: [PATCH net-next] net/smc: cast sizeof to int for comparison

On 09/15/2018 12:00 PM, YueHaibing wrote: > Comparing an int to a size, which is unsigned, causes the int to become > unsigned, giving the wrong result. kernel_sendmsg can return a negative > error code. > Thanks for reporting this issue! > Signed-off-by: YueHaibing > --- >

[PATCH net-next 3/4] net/smc: provide fallback reason code

From: Karsten Graul Remember the fallback reason code and the peer diagnosis code for smc sockets, and provide them in smc_diag.c to the netlink interface. And add more detailed reason codes. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- include/uapi/linux/smc_diag.h | 6

[PATCH net-next 3/4] net/smc: provide fallback reason code

From: Karsten Graul Remember the fallback reason code and the peer diagnosis code for smc sockets, and provide them in smc_diag.c to the netlink interface. And add more detailed reason codes. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- include/uapi/linux/smc_diag.h | 6

[PATCH net-next 1/4] net/smc: fewer parameters for smc_llc_send_confirm_link()

Link confirmation will always be sent across the new link being confirmed. This allows to shrink the parameter list. No functional change. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 10 ++ net/smc/smc_llc.c | 9 + net/smc/smc_llc.h | 2 +- 3 files changed, 8

[PATCH net-next 1/4] net/smc: fewer parameters for smc_llc_send_confirm_link()

Link confirmation will always be sent across the new link being confirmed. This allows to shrink the parameter list. No functional change. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 10 ++ net/smc/smc_llc.c | 9 + net/smc/smc_llc.h | 2 +- 3 files changed, 8

[PATCH net-next 2/4] net/smc: use correct vlan gid of RoCE device

device port, which is not enabled for the used vlan_id. Add another check whether a vlan gid exists for a certain IB device port. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 24 +--- net/smc/smc_clc.c | 10 -- net/smc/smc_clc.h | 2 +- net/smc/smc_core.c | 37

[PATCH net-next 2/4] net/smc: use correct vlan gid of RoCE device

device port, which is not enabled for the used vlan_id. Add another check whether a vlan gid exists for a certain IB device port. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 24 +--- net/smc/smc_clc.c | 10 -- net/smc/smc_clc.h | 2 +- net/smc/smc_core.c | 37

[PATCH net-next 4/4] net/smc: improve delete link processing

From: Karsten Graul Send an orderly DELETE LINK request before termination of a link group, add support for client triggered DELETE LINK processing. And send a disorderly DELETE LINK before module is unloaded. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- net/smc/smc_core.c

[PATCH net-next 4/4] net/smc: improve delete link processing

From: Karsten Graul Send an orderly DELETE LINK request before termination of a link group, add support for client triggered DELETE LINK processing. And send a disorderly DELETE LINK before module is unloaded. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun --- net/smc/smc_core.c

[PATCH net-next 0/4] net/smc: patches 2018-07-25

groups. Thanks, Ursula Karsten Graul (2): net/smc: provide fallback reason code net/smc: improve delete link processing Ursula Braun (2): net/smc: fewer parameters for smc_llc_send_confirm_link() net/smc: use correct vlan gid of RoCE device include/uapi/linux/smc_diag.h | 6 +++ net/smc

[PATCH net-next 0/4] net/smc: patches 2018-07-25

groups. Thanks, Ursula Karsten Graul (2): net/smc: provide fallback reason code net/smc: improve delete link processing Ursula Braun (2): net/smc: fewer parameters for smc_llc_send_confirm_link() net/smc: use correct vlan gid of RoCE device include/uapi/linux/smc_diag.h | 6 +++ net/smc

Re: [PATCH v3] net: iucv: Free memory obtained by kzalloc

On 03/01/2018 12:31 PM, Arvind Yadav wrote: > Free memory by calling put_device(), if afiucv_iucv_init is not > successful. > > Signed-off-by: Arvind Yadav > --- > changes in v2: > Calling put_device() before kfree(). > changes in v3: > No

Re: [PATCH v3] net: iucv: Free memory obtained by kzalloc

On 03/01/2018 12:31 PM, Arvind Yadav wrote: > Free memory by calling put_device(), if afiucv_iucv_init is not > successful. > > Signed-off-by: Arvind Yadav > --- > changes in v2: > Calling put_device() before kfree(). > changes in v3: > No need to call kfree(). So

Re: [PATCH v2] net: iucv: Free memory obtained by kzalloc

On 03/01/2018 06:25 AM, Arvind Yadav wrote: > Free memory, if afiucv_iucv_init is not successful. So calling > put_device() before kfree(). This will decrement the last reference. > > Signed-off-by: Arvind Yadav > --- > changes in v2: > Calling

Re: [PATCH v2] net: iucv: Free memory obtained by kzalloc

On 03/01/2018 06:25 AM, Arvind Yadav wrote: > Free memory, if afiucv_iucv_init is not successful. So calling > put_device() before kfree(). This will decrement the last reference. > > Signed-off-by: Arvind Yadav > --- > changes in v2: > Calling put_device() before kfree(). > >

Re: [PATCH v2] smc: return booleans instead of integers

On 01/23/2018 01:31 AM, Joe Perches wrote: > On Mon, 2018-01-22 at 12:58 +0100, Ursula Braun wrote: >> >> On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: >>> Return statements in functions returning bool should use >>> true/false instead of 1/0. >>>

Re: [PATCH v2] smc: return booleans instead of integers

On 01/23/2018 01:31 AM, Joe Perches wrote: > On Mon, 2018-01-22 at 12:58 +0100, Ursula Braun wrote: >> >> On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: >>> Return statements in functions returning bool should use >>> true/false instead of 1/0. >>>

Re: [PATCH v2] smc: return booleans instead of integers

- > Changes in v2: > - Fix function using_ipsec as suggested by Ursula Braun. > - Update subject line. > > net/smc/smc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/smc/smc.h b/net/smc/smc.h > index 0bee9d1..6328565 100644 > --- a

Re: [PATCH v2] smc: return booleans instead of integers

- Fix function using_ipsec as suggested by Ursula Braun. > - Update subject line. > > net/smc/smc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/smc/smc.h b/net/smc/smc.h > index 0bee9d1..6328565 100644 > --- a/net/smc/smc.h > +++ b/n

Re: [PATCH] smc: return boolean instead of integer in using_ipsec

same way. Will you come up with a second patch version here? Kind regards, Ursula Braun

Re: [PATCH] smc: return boolean instead of integer in using_ipsec

static inline bool using_ipsec(struct smc_sock *smc) > { > - return 0; > + return false; > } > #endif > Gustavo, thanks for reporting, but your improvement seems to be incomplete. Besides changing line 260 of net/smc/smc.h, line 255 should be adapted the same way. Will you come up with a second patch version here? Kind regards, Ursula Braun

Re: [PATCH] net/smc: Fix preinitialization of buf_desc in __smc_buf_create()

On 11/16/2017 12:22 PM, Geert Uytterhoeven wrote: > With gcc-4.1.2: > > net/smc/smc_core.c: In function ‘__smc_buf_create’: > net/smc/smc_core.c:567: warning: ‘bufsize’ may be used uninitialized in > this function > > Indeed, if the for-loop is never executed, bufsize is used >

Re: [PATCH] net/smc: Fix preinitialization of buf_desc in __smc_buf_create()

On 11/16/2017 12:22 PM, Geert Uytterhoeven wrote: > With gcc-4.1.2: > > net/smc/smc_core.c: In function ‘__smc_buf_create’: > net/smc/smc_core.c:567: warning: ‘bufsize’ may be used uninitialized in > this function > > Indeed, if the for-loop is never executed, bufsize is used >

Re: run_timer_softirq gpf. [smc]

> > From: Thomas Gleixner <t...@linutronix.de> > To: Dave Jones <da...@codemonkey.org.uk> > Cc: Linux Kernel <linux-kernel@vger.kernel.org>, Steven Rostedt > <rost...@goodmis.org>, Ursula Braun <ubr...@linux.vnet.ibm.com>, > net...@vger

Re: run_timer_softirq gpf. [smc]

> > From: Thomas Gleixner > To: Dave Jones > Cc: Linux Kernel , Steven Rostedt > , Ursula Braun , > net...@vger.kernel.org > Date: 21.03.2017 22:46 > Subject:Re: run_timer_softirq gpf. [smc] > Sent by:netdev-ow...@vger.kernel.org >

Re: [PATCH 06/14] s390/qeth: use atomic_dec_not_zero()

ACK - compile-tested successfully on s390. On 01/30/2017 07:47 PM, Fabian Frederick wrote: > instead of atomic_add_unless(value, -1, 0) > > Signed-off-by: Fabian Frederick > --- > drivers/s390/net/qeth_core_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 06/14] s390/qeth: use atomic_dec_not_zero()

ACK - compile-tested successfully on s390. On 01/30/2017 07:47 PM, Fabian Frederick wrote: > instead of atomic_add_unless(value, -1, 0) > > Signed-off-by: Fabian Frederick > --- > drivers/s390/net/qeth_core_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: linux-next: build failure after merge of the net-next tree

ACK - smc_splice_read() is just a place holder at the moment. Its implementation for AF_SMC will follow. Regards, Ursula Braun On 01/10/2017 12:59 AM, Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (x86_64 > allmodconfig)

Re: linux-next: build failure after merge of the net-next tree

ACK - smc_splice_read() is just a place holder at the moment. Its implementation for AF_SMC will follow. Regards, Ursula Braun On 01/10/2017 12:59 AM, Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (x86_64 > allmodconfig)

Re: [PATCH 12/20] net/iucv: Convert to hotplug state machine

all the callbacks via the state machine and let the core invoke the > callbacks on the already online CPUs. The smp function calls in the > online/downprep callbacks are not required as the callback is guaranteed to > be invoked on the upcoming/outgoing cpu. > > Cc: Ursula Braun <ubr.

Re: [PATCH 12/20] net/iucv: Convert to hotplug state machine

all the callbacks via the state machine and let the core invoke the > callbacks on the already online CPUs. The smp function calls in the > online/downprep callbacks are not required as the callback is guaranteed to > be invoked on the upcoming/outgoing cpu. > > Cc: Ursula Braun > Cc: &q

Re: [patch] netiucv: silence an underflow warning

Hi Dan, thanks for reporting this netiucv-problem. There is an implication: Without fix, buffer values between 2**31 and 2**32 are not detected as invalid values. Your fix would help, but since we have to touch the code, I suggest to modernize it, moving from simple_strtoul() to

Re: [patch] netiucv: silence an underflow warning

Hi Dan, thanks for reporting this netiucv-problem. There is an implication: Without fix, buffer values between 2**31 and 2**32 are not detected as invalid values. Your fix would help, but since we have to touch the code, I suggest to modernize it, moving from simple_strtoul() to

Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online()

On Sun, 2016-01-03 at 11:02 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 10:48:05 +0100 > > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. > > Signed-off-by: Markus Elfring > --- >

Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online()

On Sun, 2016-01-03 at 11:02 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 10:48:05 +0100 > > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. > > Signed-off-by: Markus

Re: [PATCH] qeth: don't rely on signedness of char

Rasmus, I do not see a need for your first patch proposal. Our code works fine in our environment. But I will pickup your second part to remove the explicit setting of the 0-termination. Thanks! Regards, Ursula On Sat, 2015-12-05 at 22:32 +0100, Rasmus Villemoes wrote: > AFAICT, char is

Re: [PATCH] qeth: don't rely on signedness of char

Rasmus, I do not see a need for your first patch proposal. Our code works fine in our environment. But I will pickup your second part to remove the explicit setting of the 0-termination. Thanks! Regards, Ursula On Sat, 2015-12-05 at 22:32 +0100, Rasmus Villemoes wrote: > AFAICT, char is

Re: [PATCH] s390-ctcm: Delete unnecessary checks before the function call "channel_remove"

Applied to our local git. Thanks. It will be part of my next patch submission for net-next. Kind regards, Ursula Braun, IBM Germany On Tue, 2015-11-17 at 20:20 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 17 Nov 2015 20:10:02 +0100 > > The channel_remove() fu

Re: [PATCH] s390-ctcm: Delete unnecessary checks before the function call "channel_remove"

Applied to our local git. Thanks. It will be part of my next patch submission for net-next. Kind regards, Ursula Braun, IBM Germany On Tue, 2015-11-17 at 20:20 +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfr...@users.sourceforge.net> > Date: Tue, 17 Nov 2015 20

Re: [PATCH] qeth: Convert use of __constant_htons to htons

> From:Vaishali Thakkar > To: Ursula Braun , > Cc:Ursula Braun1/Germany/IBM@IBMDE, BOEBLINGEN > LINUX390/Germany/IBM@IBMDE, mschw...@linux.vnet.ibm.com, > heica...@linux.vnet.ibm.com, linux-s...@vger.kernel.org, Linux Kernel > Mailing List > Date:

Re: [PATCH] qeth: Convert use of __constant_htons to htons

From:Vaishali Thakkar vthakkar1...@gmail.com To:Ursula Braun ubr...@linux.vnet.ibm.com, Cc:Ursula Braun1/Germany/IBM@IBMDE, BOEBLINGEN LINUX390/Germany/IBM@IBMDE, mschw...@linux.vnet.ibm.com, heica...@linux.vnet.ibm.com, linux-s...@vger.kernel.org, Linux Kernel

Re: [PATCH] qeth: Convert use of __constant_htons to htons

Thanks Vaishali. I have added your patch to our local kernel git, and will submit it within a following upstream shipment. Regards, Ursula Braun On Wed, 2015-06-10 at 16:22 +0530, Vaishali Thakkar wrote: > In little endian cases, the macro htons unfolds to __swab16 which > provides specia

Re: [PATCH] qeth: Convert use of __constant_htons to htons

Thanks Vaishali. I have added your patch to our local kernel git, and will submit it within a following upstream shipment. Regards, Ursula Braun On Wed, 2015-06-10 at 16:22 +0530, Vaishali Thakkar wrote: In little endian cases, the macro htons unfolds to __swab16 which provides special case

Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

Joe, thanks, we will add your qeth patch to our local library and submit it with one of our next shipments. Regards, Ursula Braun > > From:Joe Perches > To:Rasmus Villemoes , Evgeny > Cherkashin/Russia/IBM@IBMRU, Frank Blaschka > , Ursula Braun > Cc:

Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

Joe, thanks, we will add your qeth patch to our local library and submit it with one of our next shipments. Regards, Ursula Braun From:Joe Perches j...@perches.com To:Rasmus Villemoes li...@rasmusvillemoes.dk, Evgeny Cherkashin/Russia/IBM@IBMRU, Frank Blaschka frank.blasc

Re: [PATCH v5] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

Thanks, Aya. I have added this patch version to our local library. It will be part of our next upstream shipment to Dave Miller. Regards, Ursula Braun On Wed, 2014-11-05 at 21:04 +0200, Aya Mahfouz wrote: > This patch is concerned with migrating the time variables for the s390 > network

Re: [PATCH v5] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

Thanks, Aya. I have added this patch version to our local library. It will be part of our next upstream shipment to Dave Miller. Regards, Ursula Braun On Wed, 2014-11-05 at 21:04 +0200, Aya Mahfouz wrote: This patch is concerned with migrating the time variables for the s390 network driver

Re: [PATCH v4] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

fies_to_usecs(priv->channel[WRITE]->prof.tx_time)); printk(KERN_INFO "Statistics for %s:\n%s", priv->channel[CTCM_WRITE]->netdev->name, sbuf); Regards, Ursula Braun On Mon, 2014-11-03 at 21:33 +0200, Aya Mahfouz wrote: > This patch is concerned

Re: [PATCH v4] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

Statistics for %s:\n%s, priv-channel[CTCM_WRITE]-netdev-name, sbuf); Regards, Ursula Braun On Mon, 2014-11-03 at 21:33 +0200, Aya Mahfouz wrote: This patch is concerned with migrating the time variables for the s390 network driver. The changes handle the y2038

Re: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two function calls

I agree with your proposed debug_unregister() changes, but not with your kfree_fsm() change. Regards, Ursula Braun On Fri, 2014-10-31 at 18:40 +0100, SF Markus Elfring wrote: > The functions debug_unregister() and kfree_fsm() test whether their argument > is NULL and then return immed

Re: [PATCH v3] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

Thx, Aya. Now I will add your patch to our collection for our next upstream posting on net_next. The only thing I want to change is removing your #include lines. All affected routines use already #include Thus these lines are not needed. Regards, Ursula Braun On Sat, 2014-11-01

Re: [PATCH v3] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

, Ursula Braun On Sat, 2014-11-01 at 02:16 +0200, Aya Mahfouz wrote: This patch is concerned with migrating the time variables for the s390 network driver. The changes handle the y2038 problem where timespec will overflow in the year 2038. timespec was replaced by unsigned long and all time variables

Re: [PATCH 1/1] s390/net: Deletion of unnecessary checks before two function calls

I agree with your proposed debug_unregister() changes, but not with your kfree_fsm() change. Regards, Ursula Braun On Fri, 2014-10-31 at 18:40 +0100, SF Markus Elfring wrote: The functions debug_unregister() and kfree_fsm() test whether their argument is NULL and then return immediately. Thus

Re: [PATCH v2] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

nfirmation of the send operation. The maximum value is saved and can be displayed in the statistics. Regards, Ursula Braun On Fri, 2014-10-31 at 11:18 +0200, Aya Mahfouz wrote: > This patch is concerned with migrating the time variables for the s390 > network driver. The changes handle the y20

Re: [PATCH v2] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

of the send operation. The maximum value is saved and can be displayed in the statistics. Regards, Ursula Braun On Fri, 2014-10-31 at 11:18 +0200, Aya Mahfouz wrote: This patch is concerned with migrating the time variables for the s390 network driver. The changes handle the y2038 problem where

Re: [PATCH] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

er a statistic value. Since the time stamps are used in the hot traffic path of the ctcm-driver, I prefer the "speed" optimized solution based on jiffies here. Regards, Ursula Braun On Wed, 2014-10-29 at 18:02 +0200, Aya Mahfouz wrote: > This patch is concerned with migrating the time

Re: [PATCH] drivers: s390: net: ctcm: migrate variables to handle y2038 problem

. Since the time stamps are used in the hot traffic path of the ctcm-driver, I prefer the speed optimized solution based on jiffies here. Regards, Ursula Braun On Wed, 2014-10-29 at 18:02 +0200, Aya Mahfouz wrote: This patch is concerned with migrating the time variables for the s390 network driver

Re: [PATCH] s390: net: claw.c: Cleaning up possible error if incorrect in parameter

On Wed, 2014-07-30 at 22:32 +0200, Rickard Strandqvist wrote: > Possible error if incorrect in parameter, count = 0. > And clarified what the code actually does significantly. > > Signed-off-by: Rickard Strandqvist > --- > drivers/s390/net/claw.c | 24 > 1 file

Re: [PATCH] s390: net: claw.c: Cleaning up possible error if incorrect in parameter

On Wed, 2014-07-30 at 22:32 +0200, Rickard Strandqvist wrote: Possible error if incorrect in parameter, count = 0. And clarified what the code actually does significantly. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/s390/net/claw.c | 24

Re: [PATCH] s390: net: qeth_core_main.c: Cleaning up missing null-terminate in conjunction with strncpy

On Tue, 2014-07-29 at 15:21 +0200, Rickard Strandqvist wrote: > > Den 29 jul 2014 15:13 skrev "Ursula Braun" > : > > > > On Sat, 2014-07-26 at 16:35 +0200, Rickard Strandqvist wrote: > > > Replacing strncpy with strlcpy to avoid strings that lacks

Re: [PATCH] s390: net: claw.c: Fix a define larger than in a sizeof in conjunction with strncpy

On Sun, 2014-07-27 at 13:50 +0200, Rickard Strandqvist wrote: > The MAX_NAME_LEN is larger than sizeof, which could potentially > giving lots of error here. > > Signed-off-by: Rickard Strandqvist > --- > drivers/s390/net/claw.c | 31 +++ > 1 file changed, 19

Re: [PATCH] s390: net: claw.c: Fix a define larger than in a sizeof in conjunction with strncpy

On Sun, 2014-07-27 at 13:50 +0200, Rickard Strandqvist wrote: The MAX_NAME_LEN is larger than sizeof, which could potentially giving lots of error here. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/s390/net/claw.c | 31

Re: [PATCH] s390: net: qeth_core_main.c: Cleaning up missing null-terminate in conjunction with strncpy

On Tue, 2014-07-29 at 15:21 +0200, Rickard Strandqvist wrote: Den 29 jul 2014 15:13 skrev Ursula Braun ubr...@linux.vnet.ibm.com: On Sat, 2014-07-26 at 16:35 +0200, Rickard Strandqvist wrote: Replacing strncpy with strlcpy to avoid strings that lacks null terminate. Signed-off

Re: [PATCH] s390: net: qeth_core_main.c: Cleaning up missing null-terminate in conjunction with strncpy

On Sat, 2014-07-26 at 16:35 +0200, Rickard Strandqvist wrote: > Replacing strncpy with strlcpy to avoid strings that lacks null terminate. > > Signed-off-by: Rickard Strandqvist > --- > drivers/s390/net/qeth_core_main.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] s390: net: ctcm_main.c: Cleaning up missing null-terminate in conjunction with strncpy

On Sat, 2014-07-26 at 16:33 +0200, Rickard Strandqvist wrote: > Replacing strncpy with strlcpy to avoid strings that lacks null terminate. > > Signed-off-by: Rickard Strandqvist > --- > drivers/s390/net/ctcm_main.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH] s390: net: ctcm_main.c: Cleaning up missing null-terminate in conjunction with strncpy

On Sat, 2014-07-26 at 16:33 +0200, Rickard Strandqvist wrote: Replacing strncpy with strlcpy to avoid strings that lacks null terminate. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/s390/net/ctcm_main.c |4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH] s390: net: qeth_core_main.c: Cleaning up missing null-terminate in conjunction with strncpy

On Sat, 2014-07-26 at 16:35 +0200, Rickard Strandqvist wrote: Replacing strncpy with strlcpy to avoid strings that lacks null terminate. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/s390/net/qeth_core_main.c |2 +- 1 file changed, 1

Re: [PATCH 1/1] drivers/s390/cio/qdio_main.c: replace shift loop by ilog2

yes, the callers guarantee that count > 0 here. Regards, Ursula Braun On Thu, 2014-05-22 at 12:14 +0200, Ursula Braun1 wrote: > From:Sebastian Ott > To:Joe Perches , Ursula > Braun1/Germany/IBM@IBMDE, > Cc:Fabian Frederick , linux-kernel > , akpm &g

Re: [PATCH 1/1] drivers/s390/cio/qdio_main.c: replace shift loop by ilog2

yes, the callers guarantee that count 0 here. Regards, Ursula Braun On Thu, 2014-05-22 at 12:14 +0200, Ursula Braun1 wrote: From:Sebastian Ott seb...@linux.vnet.ibm.com To:Joe Perches j...@perches.com, Ursula Braun1/Germany/IBM@IBMDE, Cc:Fabian Frederick f

Re: [PATCH] clean up scary strncpy(dst, src, strlen(src)) uses

> > Signed-off-by: Kees Cook For the s390-part: Acked-by: Ursula Braun > --- > This is a follow-up to the anti-pattern being fixed in iscsi-target, > which was exploitable: > "iscsi-target: fix heap buffer overflow on error" > http://git.kerne

Re: [PATCH] clean up scary strncpy(dst, src, strlen(src)) uses

For the s390-part: Acked-by: Ursula Braun ursula.br...@de.ibm.com --- This is a follow-up to the anti-pattern being fixed in iscsi-target, which was exploitable: iscsi-target: fix heap buffer overflow on error http://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/commit/?id

[Re: [PATCH 2/2] drivers/s390/net/ctcm_main.c: fix error return code]

thanks, Peter, your patch will be added to our next patch series submission. Ursula Braun From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere

[Re: [PATCH 2/2] drivers/s390/net/ctcm_main.c: fix error return code]

thanks, Peter, your patch will be added to our next patch series submission. Ursula Braun From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one

Re: [PATCH 7/15] drivers/s390/net: removes unnecessary semicolon

Thanks, Peter. I will schedule these changes for our next posting. Ursula Braun > Peter Senna Tschudin wrote on 12/09/2012 19:03:14: > > > From: > > > > Peter Senna Tschudin > > > > To: > > > > Ursula Braun1/Germany/IBM@IBMDE > &

Re: [PATCH 7/15] drivers/s390/net: removes unnecessary semicolon

Thanks, Peter. I will schedule these changes for our next posting. Ursula Braun Peter Senna Tschudin peter.se...@gmail.com wrote on 12/09/2012 19:03:14: From: Peter Senna Tschudin peter.se...@gmail.com To: Ursula Braun1/Germany/IBM@IBMDE Cc: triv...@kernel.org

Re: [PATCH 4/4] : More use DIV_ROUND_UP

Equivalent patch submitted for 2.6.25. Thanks. --On Samstag, 16. Februar 2008 15:52 +0100 Julia Lawall <[EMAIL PROTECTED]> wrote: From: Julia Lawall <[EMAIL PROTECTED]> The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) / (d)) but is perhaps more readable. An extract

Re: [PATCH 4/4] : More use DIV_ROUND_UP

Equivalent patch submitted for 2.6.25. Thanks. --On Samstag, 16. Februar 2008 15:52 +0100 Julia Lawall [EMAIL PROTECTED] wrote: From: Julia Lawall [EMAIL PROTECTED] The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) / (d)) but is perhaps more readable. An extract of

Re: [s390] networking related oops during boot on Hercules (was: build failure)

a This seems to be related to the new network namespace code by Eric Biederman (CCed). Can you try the following (untested) patch? I also CCed Ursula and Peter as they know the ctc code better than me. CC: Eric W. Biederman <[EMAIL PROTECTED]> CC: Ursula Braun <[EMAIL PROTECTED]> C

Re: [s390] networking related oops during boot on Hercules (was: build failure)

(CCed). Can you try the following (untested) patch? I also CCed Ursula and Peter as they know the ctc code better than me. CC: Eric W. Biederman [EMAIL PROTECTED] CC: Ursula Braun [EMAIL PROTECTED] CC: Peter Tiedemann [EMAIL PROTECTED] Signed-off-by: Christian Borntraeger [EMAIL PROTECTED

[patch 1/1] qeth: remove header_ops bug

From: Ursula Braun <[EMAIL PROTECTED]> Remove qeth bug caused by commit: [NET]: Move hardware header operations out of netdevice. Signed-off-by: Ursula Braun <[EMAIL PROTECTED]> --- drivers/s390/net/qeth_main.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: lin

[patch 0/1] remove header_ops bug in qeth driver

-- Remove qeth driver bug introduced by this commit: commit 3b04ddde02cf1b6f14f2697da5c20eca5715017f Author: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue Oct 9 01:40:57 2007 -0700 [NET]: Move hardware header operations out of netdevice. - To unsubscribe from this list: send the line

[patch 0/1] remove header_ops bug in qeth driver

-- Remove qeth driver bug introduced by this commit: commit 3b04ddde02cf1b6f14f2697da5c20eca5715017f Author: Stephen Hemminger [EMAIL PROTECTED] Date: Tue Oct 9 01:40:57 2007 -0700 [NET]: Move hardware header operations out of netdevice. - To unsubscribe from this list: send the line

[patch 1/1] qeth: remove header_ops bug

From: Ursula Braun [EMAIL PROTECTED] Remove qeth bug caused by commit: [NET]: Move hardware header operations out of netdevice. Signed-off-by: Ursula Braun [EMAIL PROTECTED] --- drivers/s390/net/qeth_main.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-2.6-uschi