Re: [PATCH v1] [media] netup_unidvb: use generic power management

This patch is compile-tested only. Thanks Vaibhav Gupta

Re: [PATCH v1] pch_can: use generic power management

This patch is compile-tested only. Thanks Vaibhav Gupta

Re: [PATCH v1] farsync: use generic power management

This patch is compile-tested only. Thanks Vaibhav Gupta

[PATCH v1] staging: sm750fb: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/staging/sm750fb/sm750.c | 91 ++--- 1 file changed, 17 insertions(+), 74 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index a1a82e59dfee..84fb585a5739 10064

[PATCH v1] wireless: airo: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/net/wireless/cisco/airo.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c index 827bb6d74815..f9627fa360

[PATCH v1] [media] bttv: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/media/pci/bt8xx/bttv-driver.c | 56 --- 1 file changed, 16 insertions(+), 40 deletions(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 9144f795fb93..cb8d

[PATCH v1] [media] netup_unidvb: use generic power management

The .suspend() and .resume() callbacks are not defined for this driver. Still, their power management structure follows the legacy framework. To bring it under the generic framework, simply remove the binding of callbacks from "struct pci_driver". Signed-off-by: Vaibhav Gupta --- dri

[PATCH v1] pch_can: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/net/can/pch_can.c | 63 +-- 1 file changed, 21 insertions(+), 42 deletions(-) diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c index db415771..ca54a6e1c810 100644 --- a/

Re: [PATCH v2] ata: use generic power management

On Mon, Jul 27, 2020 at 02:30:03PM -0600, Jens Axboe wrote: > On 7/27/20 12:11 PM, Vaibhav Gupta wrote: > > On Mon, Jul 27, 2020 at 11:59:05AM -0600, Jens Axboe wrote: > >> On 7/27/20 11:51 AM, Vaibhav Gupta wrote: > >>> On Mon, Jul 27, 2020 at 11:42:51AM -0600, Jens

[PATCH v1] farsync: use generic power management

to tab in "struct pci_driver". Signed-off-by: Vaibhav Gupta --- drivers/net/wan/farsync.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c index 7916efce7188..15dacfde6b83 100644 --- a/drivers/net/wan/far

Re: [PATCH v2] ata: use generic power management

On Mon, Jul 27, 2020 at 11:59:05AM -0600, Jens Axboe wrote: > On 7/27/20 11:51 AM, Vaibhav Gupta wrote: > > On Mon, Jul 27, 2020 at 11:42:51AM -0600, Jens Axboe wrote: > >> On 7/27/20 11:40 AM, Vaibhav Gupta wrote: > >>> The patch is compile-tested only. > >

Re: [PATCH v2] ata: use generic power management

On Mon, Jul 27, 2020 at 11:42:51AM -0600, Jens Axboe wrote: > On 7/27/20 11:40 AM, Vaibhav Gupta wrote: > > The patch is compile-tested only. > > Please test and verify actual functionality, if you're serious about > potentially getting this into the kernel. > Hello Jen

Re: [PATCH v2] ata: use generic power management

The patch is compile-tested only. Thanks Vaibhav Gupta

[PATCH v2] ata: use generic power management

pass this argument. Hence, modfy each instance of call to .host_susped(), in respective PCI drivers, and pass the value "PMSG_SUSPEND" to it. Signed-off-by: Vaibhav Gupta --- drivers/ata/acard-ahci.c| 36 +--- drivers/ata/ata_generic.c | 5 +-- d

[PATCH v3] spi: spi-topcliff-pch: drop call to wakeup-disable

behavior, drop the wakeup-disable call. Fixes: f185bcc77980 ("spi: spi-topcliff-pch: use generic power management") Reported-by: Andy Shevchenko Signed-off-by: Vaibhav Gupta --- drivers/spi/spi-topcliff-pch.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-topcliff-pch.c

Re: [PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable

On Mon, Jul 27, 2020 at 04:38:40PM +0300, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 4:21 PM Vaibhav Gupta > wrote: > > > > Before generic upgrade, both .suspend() and .resume() were invoking > > pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in

[PATCH v2] spi: spi-topcliff-pch: drop call to wakeup-disable

behavior, drop the wakeup-disable call. Fix: f185bcc77980("spi: spi-topcliff-pch: use generic power management") Reported by: Andy Shevchenko Signed-off-by: Vaibhav Gupta --- drivers/spi/spi-topcliff-pch.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-topcliff-pch.c

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

On Mon, Jul 27, 2020 at 02:12:16PM +0300, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 10:08 AM Vaibhav Gupta > wrote: > > On Sat, Jul 25, 2020 at 01:44:44PM +0300, Andy Shevchenko wrote: > > > On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko > > > wrote: >

Re: [PATCH v1] dmaengine: pch_dma: use generic power management

On Mon, Jul 27, 2020 at 02:19:14PM +0300, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 1:16 PM Vinod Koul wrote: > > On 20-07-20, 17:07, Vaibhav Gupta wrote: > > > Drivers using legacy PM have to manage PCI states and device's PM states > > > themselves

Re: [PATCH v1] dmaengine: pch_dma: use generic power management

On Mon, Jul 27, 2020 at 02:26:21PM +0530, Vinod Koul wrote: > Hi Vaibhav, > > On 20-07-20, 17:07, Vaibhav Gupta wrote: > > Drivers using legacy PM have to manage PCI states and device's PM states > > themselves. They also need to take care of configuration registers.

Re: [PATCH v1] ata: use generic power management

to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/ata-use-generic-power-management/20200724-1

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

to test, so I just replicated the legacy behaviour in generic by replacing pci_enable_wake(,false) with device_wakeup_disable(). So, from now, while upgrading drivers with generic PM, should I completely drop the pci_enable_wake(,false) calls if both .suspend() and .resume() try to wakeup-disable the device? Thanks Vaibhav Gupta > > -- > With Best Regards, > Andy Shevchenko

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

On Fri, Jul 24, 2020 at 01:51:49PM +0300, Andy Shevchenko wrote: > On Mon, Jul 20, 2020 at 7:31 PM Vaibhav Gupta > wrote: > > > > Drivers using legacy PM have to manage PCI states and device's PM states > > themselves. They also need to take care of configuration reg

Re: [PATCH v1] ata: use generic power management

This patch is compile-tested only. --Vaibhav Gupta

[PATCH v1] ata: use generic power management

pass this argument. Hence, modfy each instance of call to .host_susped(), in respective PCI drivers, and pass the value "PMSG_SUSPEND" to it. Signed-off-by: Vaibhav Gupta --- drivers/ata/acard-ahci.c| 36 +--- drivers/ata/ata_generic.c | 5 +-- d

Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management

On Wed, Jul 22, 2020 at 02:45:17PM +0100, Mark Brown wrote: > On Mon, 20 Jul 2020 21:27:15 +0530, Vaibhav Gupta wrote: > > Drivers using legacy PM have to manage PCI states and device's PM states > > themselves. They also need to take care of configuration registers. > &

Re: [PATCH v2 3/3] skd: use generic power management

On Wed, Jul 22, 2020 at 12:52:47PM -0500, Bjorn Helgaas wrote: > On Tue, Jul 21, 2020 at 12:39:39PM +0530, Vaibhav Gupta wrote: > > Okay. I will improve on it. Just inform me after testing that if any other > > changes are required. I guess [PATCH 1/3] and [PATCH 2/3] are okay,

[PATCH v2] crypto: ccp: sp-pci: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/crypto/ccp/ccp-dev.c | 4 +--- drivers/crypto/ccp/sp-dev.c | 6 ++ drivers/crypto/ccp/sp-dev.h | 6 +++--- drivers/crypto/ccp/sp-pci.c | 17 ++--- drivers/crypto/ccp/sp-platform.c | 2 +- 5 fi

[PATCH v3 3/3] skd: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/block/skd_main.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 51569c199a6c..7f2d42900b38 100644 --- a/drivers/block/s

[PATCH v3 2/3] rsxx: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/block/rsxx/core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index 10f6368117d8..866153fd380a 100644 --- a/drivers/block/rsxx/core.c +++ b/dri

[PATCH v3 1/3] mtip32xx: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/block/mtip32xx/mtip32xx.c | 54 +++ 1 file changed, 12 insertions(+), 42 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index f6bafa9a68b9..7d1280952b

[PATCH v3 0/3] block: use generic power management

some changes in commit messages. Vaibhav Gupta (3): mtip32xx: use generic power management rsxx: use generic power management skd: use generic power management drivers/block/mtip32xx/mtip32xx.c | 54 +++ drivers/block/rsxx/core.c | 9 -- drivers/

Re: [PATCH v2 3/3] skd: use generic power management

On Wed, Jul 22, 2020 at 06:28:58AM +, Damien Le Moal wrote: > On Tue, 2020-07-21 at 12:39 +0530, Vaibhav Gupta wrote: > > On Tue, Jul 21, 2020 at 02:57:28AM +, Damien Le Moal wrote: > > > On 2020/07/20 22:32, Vaibhav Gupta wrote: > > > > Drivers using legac

Re: [PATCH v1] crypto: ccp: sp-pci: use generic power management

On Tue, Jul 21, 2020 at 12:15:13PM -0500, Tom Lendacky wrote: > On 7/21/20 11:30 AM, Vaibhav Gupta wrote: > > On Tue, Jul 21, 2020 at 10:19:33AM -0500, Tom Lendacky wrote: > >> On 7/21/20 7:31 AM, Vaibhav Gupta wrote: > >>> +bool __maybe_unused ccp_queues_su

Re: [PATCH v1] crypto: ccp: sp-pci: use generic power management

On Tue, Jul 21, 2020 at 10:19:33AM -0500, Tom Lendacky wrote: > On 7/21/20 7:31 AM, Vaibhav Gupta wrote: > > Drivers using legacy power management .suspen()/.resume() callbacks > > have to manage PCI states and device's PM states themselves. They also > > nee

Re: [PATCH v1] hostap: use generic power management

This patch is compile-tested only. --Vaibhav Gupta

[PATCH v1] hostap: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- .../net/wireless/intersil/hostap/hostap_hw.c | 6 ++-- .../net/wireless/intersil/hostap/hostap_pci.c | 34 ++- 2 files changed, 13 insertions(+), 27 deletions(-) diff --git a/drivers/net/wireless/intersil/hostap/hostap_hw.c

Re: [PATCH v1] mptfusion: use generic power management

This patch is compile-tested only. --Vaibhav Gupta

[PATCH v1] mptfusion: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/message/fusion/mptbase.c | 36 +++ drivers/message/fusion/mptbase.h | 7 +++--- drivers/message/fusion/mptfc.c| 5 + drivers/message/fusion/mptsas.c | 5 + drivers/message/fusion/

Re: [PATCH v1] prism54: islpci_hotplug: use generic power management

This Patch is Compile-tested only.

[PATCH v1] prism54: islpci_hotplug: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- .../intersil/prism54/islpci_hotplug.c | 34 ++- 1 file changed, 11 insertions(+), 23 deletions(-) diff --git a/drivers/net/wireless/intersil/prism54/islpci_hotplug.c b/drivers/net/wireless/intersil/prism54/islpci_

Re: [PATCH v1] crypto: ccp: sp-pci: use generic power management

The Patch is Compile-tested only.

[PATCH v1] crypto: ccp: sp-pci: use generic power management

device-specific jobs. Signed-off-by: Vaibhav Gupta --- drivers/crypto/ccp/ccp-dev.c | 8 +++- drivers/crypto/ccp/sp-dev.c | 6 ++ drivers/crypto/ccp/sp-dev.h | 6 +++--- drivers/crypto/ccp/sp-pci.c | 17 ++--- drivers/crypto/ccp/sp-platform.c | 2 +- 5 fi

Re: [PATCH v2 3/3] skd: use generic power management

On Tue, Jul 21, 2020 at 02:57:28AM +, Damien Le Moal wrote: > On 2020/07/20 22:32, Vaibhav Gupta wrote: > > Drivers using legacy PM have to manage PCI states and device's PM states > > themselves. They also need to take care of configuration registers. > > >

Re: [PATCH v1 3/3] skd: use generic power management

On Tue, Jul 21, 2020 at 02:49:06AM +, Damien Le Moal wrote: > On 2020/07/20 22:18, Vaibhav Gupta wrote: > > On Mon, Jul 20, 2020 at 12:52:14PM +, Damien Le Moal wrote: > >> On 2020/07/17 17:10, Vaibhav Gupta wrote: > >>> Change function parameter in bo

[PATCH v2] media: cafe-driver: use generic power management

elper functions like pci_save/restore_state() and pci_enable/disable_device() to do required operations. In generic mode, they are no longer needed. Change function parameter in both .suspend() and .resume() to "struct device*" type. Compile-tested only. Signed-off-by: Vaibhav Gupta

[PATCH v1] media: cafe-driver: use generic power management

elper functions like pci_save/restore_state() and pci_enable/disable_device() to do required operations. In generic mode, they are no longer needed. Change function parameter in both .suspend() and .resume() to "struct device*" type. Compile-tested only. Signed-off-by: Vaibhav Gupta

[PATCH v1] spi: spi-topcliff-pch: use generic power management

ta() to get drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/spi/spi-topcliff-pch.c | 51 +- 1 file changed, 13 insertions(+), 38 deletions(-) diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index d7ea6af7474

[PATCH v1] ethernet: myri10ge: use generic power management

o_pci_dev() and dev_get_drvdata() to get "struct pci_dev*" variable and drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- .../net/ethernet/myricom/myri10ge/myri10ge.c | 37 --- 1 file changed, 8 insertions(+), 29 deletions(-) diff --git a/drivers/net/ethernet/myric

[PATCH v1] firewire: ohci: use generic power management

t pci_dev*" variable. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/firewire/ohci.c | 43 - 1 file changed, 12 insertions(+), 31 deletions(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index 54fdc39cd0bc..2d19db5e81a1 1006

[PATCH v1] mmc: via-sdmmc: use generic power management

rvdata() to get drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/mmc/host/via-sdmmc.c | 33 - 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/mmc/host/via-sdmmc.c b/drivers/mmc/host/via-sdmmc.c index ef95bce50889..49da

[PATCH v1] i2c: eg20t: use generic power management

o_pci_dev() and dev_get_drvdata() to get "struct pci_dev*" variable and drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/i2c/busses/i2c-eg20t.c | 39 -- 1 file changed, 9 insertions(+), 30 deletions(-) diff --git a/drivers/i2c/busses/i2c-eg2

[PATCH v2 15/15] scsi: pmcraid: use generic power management

t pci_dev*" variable. In function pmcraid_resume(), earlier, the variable "rc" was set by pci_enable_device() which is now removed. Since PCI core does the required job, initialize "rc" with 0 value when declaring it. Compile-tested only. Signed-off-by: Va

[PATCH v2 14/15] scsi: mvumi: use generic power management

ta() to get drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/mvumi.c | 49 ++-- 1 file changed, 11 insertions(+), 38 deletions(-) diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c index 8906aceda4c4..7a6ef8264e47 10064

[PATCH v2 13/15] scsi: 3w-sas: use generic power management

o_pci_dev() and dev_get_drvdata() to get "struct pci_dev*" variable and drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/3w-sas.c | 31 --- 1 file changed, 8 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w

[PATCH v2 09/15] scsi: lpfc: use generic power management

_save/restore_state(), pci_choose_state() and pci_set_power_state() which is no more needed. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/lpfc/lpfc_init.c | 100 +++--- 1 file changed, 33 insertions(+), 67 deletions(-) diff --git a/drivers/scsi

[PATCH v2 11/15] scsi: hpsa: use generic power management

both .suspend() and .resume() to "struct device*" type. The function body remains unchanged as it was empty. Also, bind callbacks with "static const struct dev_pm_ops" variable. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/hpsa.c | 12 +++- 1 file ch

[PATCH v2 10/15] scsi: pm_8001: use generic power management

_save/restore_state(), pci_choose_state(), pci_enable/disable_device() and pci_set_power_state() which is no more needed. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/pm8001/pm8001_init.c | 46 --- 1 file changed, 17 insertions(+), 29 dele

[PATCH v2 12/15] scsi: 3w-9xxx: use generic power management

o_pci_dev() and dev_get_drvdata() to get "struct pci_dev*" variable and drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/3w-9xxx.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/scsi/3w-9xxx.c b/dri

[PATCH v2 07/15] scsi: hisi_sas_v3_hw: use generic power management

_save/restore_state(), pci_choose_state(), pci_enable/disable_device() and pci_set_power_state() which is no more needed. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 32 +- 1 file changed, 11 insertions(+), 21 dele

[PATCH v2 03/15] scsi: aic7xxx: use generic power management

ot; directive. Remove the directive and mark those functions as "__maybe_unused". Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/aic7xxx/aic7xxx.h | 10 ++ drivers/scsi/aic7xxx/aic7xxx_core.c| 6 ++-- drivers/scsi/aic7xxx/aic7xxx_osm_pci.c | 46 +

[PATCH v2 04/15] scsi: aic79xx: use generic power management

t; directive. Remove them and mark them as "__maybe_unused". Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/aic7xxx/aic79xx.h | 12 +++ drivers/scsi/aic7xxx/aic79xx_core.c| 8 ++--- drivers/scsi/aic7xxx/aic79xx_osm_pci.c | 43 +++--

[PATCH v2 05/15] scsi: arcmsr: use generic power management

also using PCI helper functions like pci_save/restore_state(), pci_disable/enable_device(), pci_set_power_state() and pci_enable_wake(). They should not be invoked by the driver. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/arcmsr/arcmsr_hba.c | 35 -

[PATCH v2 06/15] scsi: esas2r: use generic power management

_save/restore_state(), pci_choose_state(), pci_enable/disable_device() and pci_set_power_state() which is no more needed. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/esas2r/esas2r.h | 5 ++-- drivers/scsi/esas2r/esas2r_init.c | 48 +-- dr

[PATCH v2 02/15] scsi: aacraid: use generic power management

sing PCI helper functions like pci_save/restore_state(), pci_disable/enable_device(), pci_set_power_state() and pci_enable_wake(). They should not be invoked by the driver. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/aacraid/linit.c | 34 --

[PATCH v2 08/15] scsi: mpt3sas_scsih: use generic power management

_save/restore_state(), pci_choose_state(), pci_enable/disable_device() and pci_set_power_state() which is no more needed. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 36 +++- 1 file changed, 14 insertions(+), 22 dele

[PATCH v2 00/15] scsi: use generic power management

1 all Vaibhav Gupta (15): scsi: megaraid_sas: use generic power management scsi: aacraid: use generic power management scsi: aic7xxx: use generic power management scsi: aic79xx: use generic power management scsi: arcmsr: use generic power management scsi: esas2r: use generic power manag

[PATCH v2 01/15] scsi: megaraid_sas: use generic power management

iver. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/megaraid/megaraid_sas_base.c | 61 ++- 1 file changed, 16 insertions(+), 45 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 0066

[PATCH v2 3/3] skd: use generic power management

ice*" type. Use to_pci_dev() to get "struct pci_dev*" variable. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/block/skd_main.c | 30 -- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/block/skd_main.c b/drive

[PATCH v2 0/3] block: use generic power management

. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gup

[PATCH v2 1/3] mtip32xx: use generic power management

quot; type. Use dev_get_drvdata() to get drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/block/mtip32xx/mtip32xx.c | 54 +++ 1 file changed, 12 insertions(+), 42 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/m

[PATCH v2 2/3] rsxx: use generic power management

esume(), hence define it as NULL. Change function parameter in both .suspend() to "struct device*" type and mark the parameter as "__attribute__((unused)) " as the function body is empty. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/block/rsxx/core.c | 9 +++

Re: [PATCH v1 3/3] skd: use generic power management

On Mon, Jul 20, 2020 at 12:52:14PM +, Damien Le Moal wrote: > On 2020/07/17 17:10, Vaibhav Gupta wrote: > > Drivers using legacy PM have to manage PCI states and device's PM states > > themselves. They also need to take care of configuration registers. > > >

[PATCH v1] serial: pch_uart: use generic power management

ile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/tty/serial/pch_uart.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 40fa7a27722d..67aca8cb9cd4 100644 --- a/dri

[PATCH v1] dmaengine: pch_dma: use generic power management

data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/dma/pch_dma.c | 35 +-- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c index a3b0b4c56a19..e93005837e3f 100644 --- a/drivers/dma/

[PATCH v1] memstick: jmb38x_ms: use generic power management

o_pci_dev() and dev_get_drvdata() to get "struct pci_dev*" variable and drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/memstick/host/jmb38x_ms.c | 38 +-- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/memstick/ho

Re: [PATCH v1] [media] saa7134: use generic power management

On Mon, Jun 22, 2020 at 5:36 PM Vaibhav Gupta wrote: > > With the support of generic PM callbacks, drivers no longer need to use > legacy .suspend() and .resume() in which they had to maintain PCI states > changes and device's power state themselves. The required operations are &

[PATCH v2] [media] saa7164: use generic power management

The .suspend() and .resume() callbacks are not defined for this driver. Still, their power management structure follows the legacy framework. To bring it under the generic framework, simply remove the binding of callbacks from struct "pci_driver". Compile-tested only. Signed-off-b

[PATCH v2] cardreader/rtsx_pcr.c: use generic power management

essentials will be handled by the PCI core. Driver needs to do only device-specific operations. The driver was also using pci_enable_wake(...,..., 0) to disable wake. Use device_wakeup_disable() instead. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/misc/cardreader/rtsx_pcr.c | 33

Re: [PATCH v1 07/15] scsi: hisi_sas_v3_hw: use generic power management

On Mon, Jul 20, 2020 at 02:16:45PM +0800, chenxiang (M) wrote: > Hi Vaibhav, > > 在 2020/7/17 14:34, Vaibhav Gupta 写道: > > With legacy PM, drivers themselves were responsible for managing the > > device's power states and takes care of register states. > > &g

[PATCH v1] ralink/rt2x00: pci: use generic power management

;. Thus, make the callbacks static. Declare an "extern const struct dev_pm_ops" variable and bind PM callbacks to it. Now, export the variable instead and use it in respective drivers. Compile-tested only. Signed-off-by: Vaibhav Gupta --- .../net/wireless/ralink/rt2x00/rt2400pci.c

Re: [PATCH v2 4/6] cx88: use generic power management

On Fri, Jul 17, 2020 at 12:49:43PM +0200, Hans Verkuil wrote: > On 17/07/2020 12:31, Vaibhav Gupta wrote: > > On Fri, Jul 17, 2020 at 12:54:40PM +0530, Vaibhav Gupta wrote: > >> On Fri, Jul 17, 2020 at 03:14:28PM +0800, kernel test robot wrote: > >>> Hi Vaibhav, >

Re: [PATCH v2 4/6] cx88: use generic power management

On Fri, Jul 17, 2020 at 12:54:40PM +0530, Vaibhav Gupta wrote: > On Fri, Jul 17, 2020 at 03:14:28PM +0800, kernel test robot wrote: > > Hi Vaibhav, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on linuxtv-media/master]

[PATCH v1 0/3] block: use generic power management

. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gup

[PATCH v1 3/3] skd: use generic power management

ice*" type. Use to_pci_dev() to get "struct pci_dev*" variable. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/block/skd_main.c | 36 ++-- 1 file changed, 10 insertions(+), 26 deletions(-) diff --git a/drivers/block/skd_main.c b/drive

[PATCH v1 1/3] mtip32xx: use generic power management

quot; type. Use dev_get_drvdata() to get drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/block/mtip32xx/mtip32xx.c | 54 +++ 1 file changed, 12 insertions(+), 42 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/m

[PATCH v1 2/3] rsxx: use generic power management

esume(), hence define it as NULL. Change function parameter in both .suspend() to "struct device*" type and mark the parameter as "__attribute__((unused)) " as the function body is empty. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/block/rsxx/core.c | 9 +++

[PATCH v1 1/3] amd64-agp: use generic power management

suspend() became an empty-body function, hence defined as NULL. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/char/agp/amd64-agp.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64

[PATCH v1 2/3] sis-agp: use generic power management

suspend() became an empty-body function, hence defined as NULL. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/char/agp/sis-agp.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/drivers/char/agp/sis-agp.c b/drivers/char/agp/sis

[PATCH v1 3/3] via-agp: use generic power management

suspend() became an empty-body function, hence defined as NULL. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/char/agp/via-agp.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/drivers/char/agp/via-agp.c b/drivers/char/agp/via

[PATCH v1 0/3] char: use generic power management

. The conversion requires the removal of those function calls, change the callbacks' definition accordingly and make use of dev_pm_ops structure. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gup

[PATCH v3 5/6] meye: use generic power management

g PCI helper functions like pci_save/restore_state() which is not recommended. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/media/pci/meye/meye.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/media/pci/meye/meye.c b/drivers/media/pci

[PATCH v3 3/6] cx25821: use generic power management

The .suspend() and .resume() callbacks are not defined for this driver. Still, their power management structure follows the legacy framework. To bring it under the generic framework, simply remove the binding of callbacks from struct "pci_driver". Compile-tested only. Signed-off-b

[PATCH v3 6/6] tw68: use generic power management

g PCI helper functions like pci_save/restore_state() which is not recommended. Compile-Tested only. Signed-off-by: Vaibhav Gupta --- drivers/media/pci/tw68/tw68-core.c | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/drivers/media/pci/tw68/tw68-c

[PATCH v3 4/6] cx88: use generic power management

g PCI helper functions like pci_save/restore_state(), pci_enable/disable_device() and pci_set_power_state(), which is not recommended. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/media/pci/cx88/cx88-video.c | 58 - 1 file changed, 15 insertions(+

[PATCH v3 0/6] [media] pci: use generic power management

: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gupta (6): sta2x11: use generic power management cx23885: use generic power management cx25821: use generic power management cx88: use generic power management meye: use generic power management tw68: use generic

[PATCH v3 2/6] cx23885: use generic power management

The .suspend() and .resume() callbacks are not defined for this driver. Still, their power management structure follows the legacy framework. To bring it under the generic framework, simply remove the binding of callbacks from struct "pci_driver". Compile-tested only. Signed-off-b

[PATCH v3 1/6] sta2x11: use generic power management

call the PCI helper functions like pci_enable_device(), pci_save/restore_sate(), etc. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/media/pci/sta2x11/sta2x11_vip.c | 63 ++--- 1 file changed, 15 insertions(+), 48 deletions(-) diff --git a/drivers/media/pci/st

Re: [PATCH v2 4/6] cx88: use generic power management

lied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/pci-use-generic-power-manageme

[PATCH v1 14/15] scsi: mvumi: use generic power management

ta() to get drv data. Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/scsi/mvumi.c | 49 ++-- 1 file changed, 11 insertions(+), 38 deletions(-) diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c index 8906aceda4c4..7a6ef8264e47 10064

<    1   2   3   4   5   >