Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 01:56 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 13:49:53 +0530 Vaibhav Hiremath wrote: On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: Currently

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: Currently, the sdhci_do_start_signal_voltage_switch() function invokes controller specific voltage switch configuration only for 1.8v usecase; but it is required

Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 12:24 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 00:54:13 +0530 Vaibhav Hiremath wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc

Re: [PATCH-v5 RESEND 0/5] i2c: pxa: Add support for PXA910 family of device

2015-09-02 Thread Vaibhav Hiremath
On Monday 24 August 2015 11:29 AM, Vaibhav Hiremath wrote: Sorry for not following up on this aggressively, was quit busy with some other stuff. Resending this patch with Robert's Tested-By. This patch-series is subset of the original patch-series, submitted on 14 Jul 2015. Link to Original

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the actual root-cause of the failure. I'm not sure why that is as nearly every error path in sdhci_add_host emits a message

Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc

Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 12:24 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 00:54:13 +0530 Vaibhav Hiremath <vaibhav.hirem...@linaro.org> wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of fu

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath <vaibhav.hirem...@linaro.org> wrote: Currently, the sdhci_do_start_signal_voltage_switch() function invokes controller specific voltage switch configuration only for 1.8v u

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the actual root-cause of the failure. I'm not sure why that is as nearly every error path in sdhci_add_host emits a message

Re: [PATCH-v5 RESEND 0/5] i2c: pxa: Add support for PXA910 family of device

2015-09-02 Thread Vaibhav Hiremath
On Monday 24 August 2015 11:29 AM, Vaibhav Hiremath wrote: Sorry for not following up on this aggressively, was quit busy with some other stuff. Resending this patch with Robert's Tested-By. This patch-series is subset of the original patch-series, submitted on 14 Jul 2015. Link to Original

Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote: On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote: On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 01:56 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 13:49:53 +0530 Vaibhav Hiremath <vaibhav.hirem...@linaro.org> wrote: On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath <vaib

Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the actual root-cause of the failure. diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c @@ -455,7

Re: [RFC 3/3] mmc: sdhci-pxav3: Add ->voltage_switch callback support

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 07:21 PM, Shawn Lin wrote: On 2015/9/2 3:32, Vaibhav Hiremath wrote: In case PXA1928 family of devices, there is device/controller specific configuration to control voltage/power on the IO pins. This patch implements and enables the sdhci_ops->voltage_swi

[RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-01 Thread Vaibhav Hiremath
support (I/O domain power control register). Signed-off-by: Vaibhav Hiremath --- Note: Currently ->voltage_switch() callback is only supported in f_sdh30 driver. And I am not sure on the dependency of execution sequence for that device. I could have moved ->voltage_switch() call at one common

[RFC 1/3] mmc: sdhci: pass signal_voltage as an argument to voltage_switch callback

2015-09-01 Thread Vaibhav Hiremath
In order to do particular voltage specific configuration in sdhci_ops->voltage_switch() callback function, we need to pass respective voltage value as well. So this patch adds an extra argument for signal voltage to the callback function. Signed-off-by: Vaibhav Hiremath Signed-off-by: Kevin

[RFC 3/3] mmc: sdhci-pxav3: Add ->voltage_switch callback support

2015-09-01 Thread Vaibhav Hiremath
<0xd401e81c 4>, <0xd4015068 8>; ... }; Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci

[RFC 0/3] mmc: sdhci: pass signal voltage as an argument to ->voltage_switch()

2015-09-01 Thread Vaibhav Hiremath
l at one common place (above/below), but was not quite sure about it. So, replicated/duplicated the call for other voltages. Vaibhav Hiremath (3): mmc: sdhci: pass signal_voltage as an argument to voltage_switch callback mmc: sdhci: add host_ops->voltage_switch callback for all other

[PATCH 0/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-01 Thread Vaibhav Hiremath
Trivial patch-series, which fixes the tabbing issue in the driver and second patch prints the return value from sdhci_add_host() function Vaibhav Hiremath (2): mmc: sdhci-pxav3: Fix tabbing issue mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn drivers/mmc/host/sdhci

[PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-01 Thread Vaibhav Hiremath
There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc... This patch fixes all such occurrences in the code. And also use BIT for bit definitions. Signed-off-by: Vaibhav Hiremath

[PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-01 Thread Vaibhav Hiremath
Return value would give clear information about the actual root-cause of the failure. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c index

[RFC 0/3] mmc: sdhci: pass signal voltage as an argument to ->voltage_switch()

2015-09-01 Thread Vaibhav Hiremath
l at one common place (above/below), but was not quite sure about it. So, replicated/duplicated the call for other voltages. Vaibhav Hiremath (3): mmc: sdhci: pass signal_voltage as an argument to voltage_switch callback mmc: sdhci: add host_ops->voltage_switch callback for all other

[PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-01 Thread Vaibhav Hiremath
Return value would give clear information about the actual root-cause of the failure. Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org> --- drivers/mmc/host/sdhci-pxav3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drive

[PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-01 Thread Vaibhav Hiremath
There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc... This patch fixes all such occurrences in the code. And also use BIT for bit definitions. Signed-off-by: Vaibhav Hiremath

[PATCH 0/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-01 Thread Vaibhav Hiremath
Trivial patch-series, which fixes the tabbing issue in the driver and second patch prints the return value from sdhci_add_host() function Vaibhav Hiremath (2): mmc: sdhci-pxav3: Fix tabbing issue mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn drivers/mmc/host/sdhci

[RFC 1/3] mmc: sdhci: pass signal_voltage as an argument to voltage_switch callback

2015-09-01 Thread Vaibhav Hiremath
In order to do particular voltage specific configuration in sdhci_ops->voltage_switch() callback function, we need to pass respective voltage value as well. So this patch adds an extra argument for signal voltage to the callback function. Signed-off-by: Vaibhav Hiremath <vaibhav

[RFC 3/3] mmc: sdhci-pxav3: Add ->voltage_switch callback support

2015-09-01 Thread Vaibhav Hiremath
<0xd401e81c 4>, <0xd4015068 8>; ... }; Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org> --- drivers/mmc/host/sdhci-pxav3.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/drivers/mmc/host/sd

[RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-01 Thread Vaibhav Hiremath
support (I/O domain power control register). Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org> --- Note: Currently ->voltage_switch() callback is only supported in f_sdh30 driver. And I am not sure on the dependency of execution sequence for that device. I could h

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 04:05 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 04:00 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes them

[PATCH-v3 RESEND] mfd: 88pm80x: Add 88pm860 chip type support

2015-08-25 Thread Vaibhav Hiremath
Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski Acked-by: Lee Jones --- drivers/mfd/88pm80x.c | 2 ++ include/linux/mfd/88pm80x.h | 1 + 2 files changed, 3 insertions(+) diff --git

Re: [PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 02:00 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: On Monday 24 August 2015 09:21 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: On Monday 24 August 2015 07:24 PM, Lee Jones wrote: On Wed, 08 Jul 2015, Vaibhav Hiremath

Re: [PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:28 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: This patch updates the binding documentation for optional clocks node and related information for buffered 32KHz clock. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski Acked

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 125

Re: [PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:25 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Update header file with required macros for 32KHz buffered clock output of 88PM800 family of device. These macros will be used in clk provider driver. Signed-off-by: Vaibhav Hiremath

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. That's not all it's doing though is it? Yes, its just tabbing related fixes. Please

Re: [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:19 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Krzysztof Kozlowski wrote: On 25.08.2015 03:56, Vaibhav Hiremath wrote: This patch adds mfd_cell/clk-subdevice for 88PM800 MFD (and family of devices). Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c

Re: [PATCH-v3] mfd: 88pm80x: Add 88pm860 chip type support

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 12:08 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 12:32:17PM +0530, Vaibhav Hiremath wrote: On Monday 20 July 2015 05:22 PM, Vaibhav Hiremath wrote: Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Last update/understanding

Re: [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 10:55 AM, Krzysztof Kozlowski wrote: On 25.08.2015 03:56, Vaibhav Hiremath wrote: This patch adds mfd_cell/clk-subdevice for 88PM800 MFD (and family of devices). Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 25 + 1 file

Re: [PATCH-v3 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 10:18 AM, Krzysztof Kozlowski wrote: On 24.08.2015 21:40, Vaibhav Hiremath wrote: 88PM860 device supports dual phase mode on BUCK1 output. In normal usecase, BUCK1A and BUCK1B operates independently with 3A capacity. And they both can work as a dual phase providing

Re: [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 10:55 AM, Krzysztof Kozlowski wrote: On 25.08.2015 03:56, Vaibhav Hiremath wrote: This patch adds mfd_cell/clk-subdevice for 88PM800 MFD (and family of devices). Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 25

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. That's not all it's doing though is it? Yes, its just tabbing related fixes. Please

Re: [PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:28 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: This patch updates the binding documentation for optional clocks node and related information for buffered 32KHz clock. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Reviewed

Re: [PATCH-v3] mfd: 88pm80x: Add 88pm860 chip type support

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 12:08 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 12:32:17PM +0530, Vaibhav Hiremath wrote: On Monday 20 July 2015 05:22 PM, Vaibhav Hiremath wrote: Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Last update/understanding

Re: [PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:25 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Update header file with required macros for 32KHz buffered clock output of 88PM800 family of device. These macros will be used in clk provider driver. Signed-off-by: Vaibhav Hiremath

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 125

Re: [PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 02:00 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: On Monday 24 August 2015 09:21 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: On Monday 24 August 2015 07:24 PM, Lee Jones wrote: On Wed, 08 Jul 2015, Vaibhav Hiremath

Re: [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:19 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Krzysztof Kozlowski wrote: On 25.08.2015 03:56, Vaibhav Hiremath wrote: This patch adds mfd_cell/clk-subdevice for 88PM800 MFD (and family of devices). Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org

Re: [PATCH-v3 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 10:18 AM, Krzysztof Kozlowski wrote: On 24.08.2015 21:40, Vaibhav Hiremath wrote: 88PM860 device supports dual phase mode on BUCK1 output. In normal usecase, BUCK1A and BUCK1B operates independently with 3A capacity. And they both can work as a dual phase providing

[PATCH-v3 RESEND] mfd: 88pm80x: Add 88pm860 chip type support

2015-08-25 Thread Vaibhav Hiremath
Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Acked-by: Lee Jones lee.jo...@linaro.org --- drivers/mfd/88pm80x.c | 2 ++ include/linux

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 04:00 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes them

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 04:05 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes

[PATCH-v2 4/5] clk: 88pm800: Add clk provider driver for 88pm800 family of devices

2015-08-24 Thread Vaibhav Hiremath
iver pm800_clk_driver = { + .driver = { + .name = "88pm80x-clk", + }, + .probe = pm800_clk_probe, + .remove = pm800_clk_remove, + .id_table = pm800_clk_id, +}; + +static int __init pm800_clk_init(void) +{ + return platform_driver_

[PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice

2015-08-24 Thread Vaibhav Hiremath
This patch adds mfd_cell/clk-subdevice for 88PM800 MFD (and family of devices). Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index c4e097d..a928eed 100644

[PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros

2015-08-24 Thread Vaibhav Hiremath
Update header file with required macros for 32KHz buffered clock output of 88PM800 family of device. These macros will be used in clk provider driver. Signed-off-by: Vaibhav Hiremath --- include/linux/mfd/88pm80x.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux

[PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information

2015-08-24 Thread Vaibhav Hiremath
This patch updates the binding documentation for optional clocks node and related information for buffered 32KHz clock. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski Acked-by: Rob Herring --- Documentation/devicetree/bindings/mfd/88pm800.txt | 27 +++ 1

[PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-24 Thread Vaibhav Hiremath
Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 125 -- 1 file changed, 61 insertions(+), 64 deletions(-) diff --git a/drivers/mfd

[PATCH-v2 0/5] clk: 88pm800: Add new clk provider driver for 88PM800 MFD

2015-08-24 Thread Vaibhav Hiremath
sed devm_kcalloc variants for array allocation instead of kzalloc. - Fixed all other trivial issues. Vaibhav Hiremath (5): mfd: 88pm800: Fix tabbing issue mfd: 88pm800: Update the header file with 32K clk related macros mfd: devicetree: bindings: Add clock subdevice node information

[PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-24 Thread Vaibhav Hiremath
Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 125 -- 1 file changed, 61 insertions(+), 64 deletions(-) diff --git a/drivers/mfd

Re: [PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method

2015-08-24 Thread Vaibhav Hiremath
On Monday 24 August 2015 09:21 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: On Monday 24 August 2015 07:24 PM, Lee Jones wrote: On Wed, 08 Jul 2015, Vaibhav Hiremath wrote: As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe (page 0) controls the method

Re: [PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method

2015-08-24 Thread Vaibhav Hiremath
On Monday 24 August 2015 07:24 PM, Lee Jones wrote: On Wed, 08 Jul 2015, Vaibhav Hiremath wrote: As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe (page 0) controls the method of clearing interrupt status of 88pm800 family of devices; 0: clear on read 1: clear on write If pdata

Re: [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-08-24 Thread Vaibhav Hiremath
On Monday 24 August 2015 06:32 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: 88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch updates the devicetree

[PATCH-v3 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1

2015-08-24 Thread Vaibhav Hiremath
mode on BUCK1. Note that if dual phase mode is enabled, then BUCK1B will not be registered to the regulator framework and the current capacity of BUCK1(A) would be set to 6A [3A of BUCK1A + 3A of BUCK1B]. Signed-off-by: Vaibhav Hiremath --- drivers/regulator/88pm800.c | 40

[PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-08-24 Thread Vaibhav Hiremath
88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch updates the devicetree binding with DT property to enable dual-phase mode on BUCK1. Signed-off-by: Vaibhav Hiremath

[PATCH-v3 0/2] regulator: 88pm800: Add dual phase mode support on BUCK1

2015-08-24 Thread Vaibhav Hiremath
. - Based on Mark Brown's comment, we should use DT property of its own. using set_current_limit() is not right way here. So, created DT property for Dual phase mode enable. - Updated binding for new DT property Vaibhav Hiremath (2): mfd: devicetree: bindings: 88pm800: Add DT property for

Re: [PATCH-v3] mfd: 88pm80x: Add 88pm860 chip type support

2015-08-24 Thread Vaibhav Hiremath
On Monday 20 July 2015 05:22 PM, Vaibhav Hiremath wrote: Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski --- drivers/mfd/88pm80x.c | 2 ++ include/linux/mfd/88pm80x.h | 1 + 2

Re: [PATCH-v6 0/6] mfd: 88pm800: Add Device tree support

2015-08-24 Thread Vaibhav Hiremath
On Tuesday 14 July 2015 12:27 AM, Vaibhav Hiremath wrote: On Wednesday 08 July 2015 05:56 PM, Vaibhav Hiremath wrote: This patch-series adds support for Device tree to 88PM800 mfd driver. It also sets default configuration of irq clear method if board file doesn't exist. Testing:: - Boot

[PATCH-v5 RESEND 3/5] i2c: pxa: Add support for pxa910/988 & new configuration features

2015-08-24 Thread Vaibhav Hiremath
ndard DT properties for ilcr and iwcr configuration fields. In case of Master ilcr is used for low/high time and in case of slave mode of operation iwcr is used for setup/hold time. Signed-off-by: Jett.Zhou Signed-off-by: Yi Zhang Signed-off-by: Vaibhav Hiremath Tested-by: Robert Jarzmik --- drive

[PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-08-24 Thread Vaibhav Hiremath
of the I2C module after xfer in master mode of operation. i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer Signed-off-by: Yi Zhang Signed-off-by: Vaibhav Hiremath --- drivers/i2c/busses/i2c-pxa.c | 43 +-- 1 file changed, 41

[PATCH-v5 RESEND 4/5] Documentation: binding: add sclk adjustment properties to i2c-pxa

2015-08-24 Thread Vaibhav Hiremath
hold/setup wait counter for standard and fast mode. Signed-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt b/Documentation/devicetree/bindings

[PATCH-v5 RESEND 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-08-24 Thread Vaibhav Hiremath
-by: Vaibhav Hiremath Signed-off-by: Jett.Zhou Signed-off-by: Yi Zhang Tested-by: Robert Jarzmik --- drivers/i2c/busses/i2c-pxa.c | 69 1 file changed, 63 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c

[PATCH-v5 RESEND 1/5] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

2015-08-24 Thread Vaibhav Hiremath
Driver will now supports enable/disable across msg xfer, which user can control it by new DT property - i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer and enable it back before xfer. Signed-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings/i2c/i2c

[PATCH-v5 RESEND 0/5] i2c: pxa: Add support for PXA910 family of device

2015-08-24 Thread Vaibhav Hiremath
- Dropped Patch 05/12: using core bus reset implementation - under work. 08/12: NAKed and dropped - Separated DT binding patch from driver changes, for easy merge Vaibhav Hiremath (4): Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa i2c: pxa: Add support for

[PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-08-24 Thread Vaibhav Hiremath
88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch updates the devicetree binding with DT property to enable dual-phase mode on BUCK1. Signed-off-by: Vaibhav Hiremath

[PATCH-v3 0/2] regulator: 88pm800: Add dual phase mode support on BUCK1

2015-08-24 Thread Vaibhav Hiremath
on Mark Brown's comment, we should use DT property of its own. using set_current_limit() is not right way here. So, created DT property for Dual phase mode enable. - Updated binding for new DT property Vaibhav Hiremath (2): mfd: devicetree: bindings: 88pm800: Add DT property for dual phase

[PATCH-v3 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1

2015-08-24 Thread Vaibhav Hiremath
mode on BUCK1. Note that if dual phase mode is enabled, then BUCK1B will not be registered to the regulator framework and the current capacity of BUCK1(A) would be set to 6A [3A of BUCK1A + 3A of BUCK1B]. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/regulator/88pm800.c | 40

Re: [PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method

2015-08-24 Thread Vaibhav Hiremath
On Monday 24 August 2015 07:24 PM, Lee Jones wrote: On Wed, 08 Jul 2015, Vaibhav Hiremath wrote: As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe (page 0) controls the method of clearing interrupt status of 88pm800 family of devices; 0: clear on read 1: clear on write If pdata

Re: [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-08-24 Thread Vaibhav Hiremath
On Monday 24 August 2015 06:32 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: 88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch updates the devicetree

Re: [PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method

2015-08-24 Thread Vaibhav Hiremath
On Monday 24 August 2015 09:21 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: On Monday 24 August 2015 07:24 PM, Lee Jones wrote: On Wed, 08 Jul 2015, Vaibhav Hiremath wrote: As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe (page 0) controls the method

[PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-24 Thread Vaibhav Hiremath
Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 125 -- 1 file changed, 61 insertions(+), 64 deletions

[PATCH-v2 0/5] clk: 88pm800: Add new clk provider driver for 88PM800 MFD

2015-08-24 Thread Vaibhav Hiremath
devm_kcalloc variants for array allocation instead of kzalloc. - Fixed all other trivial issues. Vaibhav Hiremath (5): mfd: 88pm800: Fix tabbing issue mfd: 88pm800: Update the header file with 32K clk related macros mfd: devicetree: bindings: Add clock subdevice node information clk: 88pm800

[PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-24 Thread Vaibhav Hiremath
Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 125 -- 1 file changed, 61 insertions(+), 64 deletions

[PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information

2015-08-24 Thread Vaibhav Hiremath
This patch updates the binding documentation for optional clocks node and related information for buffered 32KHz clock. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Acked-by: Rob Herring r...@kernel.org --- Documentation

[PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros

2015-08-24 Thread Vaibhav Hiremath
Update header file with required macros for 32KHz buffered clock output of 88PM800 family of device. These macros will be used in clk provider driver. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- include/linux/mfd/88pm80x.h | 12 1 file changed, 12 insertions

[PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice

2015-08-24 Thread Vaibhav Hiremath
This patch adds mfd_cell/clk-subdevice for 88PM800 MFD (and family of devices). Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index

[PATCH-v2 4/5] clk: 88pm800: Add clk provider driver for 88pm800 family of devices

2015-08-24 Thread Vaibhav Hiremath
); + +MODULE_DESCRIPTION(88PM800 Clock Driver); +MODULE_AUTHOR(Vaibhav Hiremath vaibhav.hirem...@linaro.org); +MODULE_LICENSE(GPL); -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH-v5 RESEND 1/5] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

2015-08-24 Thread Vaibhav Hiremath
Driver will now supports enable/disable across msg xfer, which user can control it by new DT property - i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer and enable it back before xfer. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- Documentation

[PATCH-v5 RESEND 0/5] i2c: pxa: Add support for PXA910 family of device

2015-08-24 Thread Vaibhav Hiremath
/12: NAKed and dropped - Separated DT binding patch from driver changes, for easy merge Vaibhav Hiremath (4): Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa i2c: pxa: Add support for pxa910/988 new configuration features Documentation: binding: add sclk

[PATCH-v5 RESEND 3/5] i2c: pxa: Add support for pxa910/988 new configuration features

2015-08-24 Thread Vaibhav Hiremath
configuration fields. In case of Master ilcr is used for low/high time and in case of slave mode of operation iwcr is used for setup/hold time. Signed-off-by: Jett.Zhou jtz...@marvell.com Signed-off-by: Yi Zhang yizh...@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Tested

[PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-08-24 Thread Vaibhav Hiremath
to control disable of the I2C module after xfer in master mode of operation. i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer Signed-off-by: Yi Zhang yizh...@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/i2c/busses/i2c-pxa.c | 43

[PATCH-v5 RESEND 4/5] Documentation: binding: add sclk adjustment properties to i2c-pxa

2015-08-24 Thread Vaibhav Hiremath
hold/setup wait counter for standard and fast mode. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt b

[PATCH-v5 RESEND 5/5] i2c: pxa: Add ILCR (tLow tHigh) configuration support

2015-08-24 Thread Vaibhav Hiremath
-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Signed-off-by: Jett.Zhou jtz...@marvell.com Signed-off-by: Yi Zhang yizh...@marvell.com Tested-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/i2c/busses/i2c-pxa.c | 69 1 file changed, 63 insertions(+), 6

Re: [PATCH-v6 0/6] mfd: 88pm800: Add Device tree support

2015-08-24 Thread Vaibhav Hiremath
On Tuesday 14 July 2015 12:27 AM, Vaibhav Hiremath wrote: On Wednesday 08 July 2015 05:56 PM, Vaibhav Hiremath wrote: This patch-series adds support for Device tree to 88PM800 mfd driver. It also sets default configuration of irq clear method if board file doesn't exist. Testing:: - Boot

Re: [PATCH-v3] mfd: 88pm80x: Add 88pm860 chip type support

2015-08-24 Thread Vaibhav Hiremath
On Monday 20 July 2015 05:22 PM, Vaibhav Hiremath wrote: Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/88pm80x.c

Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-08-09 Thread Vaibhav Hiremath
On Sunday 09 August 2015 05:48 PM, Robert Jarzmik wrote: Vaibhav Hiremath writes: Robert, It would be helpful if you can test this patch-series and confirm that it now fixes the NULL pointer deference issue. Tested, it works on pxa27x in master mode, in non-DT mode. For all non-DT

Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow tHigh) configuration support

2015-08-09 Thread Vaibhav Hiremath
On Sunday 09 August 2015 05:48 PM, Robert Jarzmik wrote: Vaibhav Hiremath vaibhav.hirem...@linaro.org writes: Robert, It would be helpful if you can test this patch-series and confirm that it now fixes the NULL pointer deference issue. Tested, it works on pxa27x in master mode, in non-DT

Re: [PATCH-v2 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1

2015-08-06 Thread Vaibhav Hiremath
On Thursday 06 August 2015 05:28 AM, Krzysztof Kozlowski wrote: On 05.08.2015 17:45, Vaibhav Hiremath wrote: On Thursday 23 July 2015 10:21 AM, Krzysztof Kozlowski wrote: 2015-07-22 1:23 GMT+09:00 Vaibhav Hiremath : 88PM860 device supports dual phase mode on BUCK1 output. In normal

Re: [PATCH-v2 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1

2015-08-06 Thread Vaibhav Hiremath
On Thursday 06 August 2015 05:28 AM, Krzysztof Kozlowski wrote: On 05.08.2015 17:45, Vaibhav Hiremath wrote: On Thursday 23 July 2015 10:21 AM, Krzysztof Kozlowski wrote: 2015-07-22 1:23 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org: 88PM860 device supports dual phase mode

<    1   2   3   4   5   6   7   >