Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method

2015-06-24 Thread Vaibhav Hiremath
On Thursday 25 June 2015 11:20 AM, Krzysztof Kozlowski wrote: On 25.06.2015 14:44, Vaibhav Hiremath wrote: On Thursday 25 June 2015 11:02 AM, Krzysztof Kozlowski wrote: On 25.06.2015 14:26, Vaibhav Hiremath wrote: On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: 2015-06-24

Re: Use of pinctrl-single for external device over I2C

2015-06-24 Thread Vaibhav Hiremath
On Thursday 25 June 2015 10:08 AM, Tony Lindgren wrote: * Vaibhav Hiremath [150624 10:12]: I do not like this, as this is not HW feature, so DT may not be right approach. So I will dig more from either runtime or Compile time option to use regmap_ Vs raw read/writes. Can't you just check

Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method

2015-06-24 Thread Vaibhav Hiremath
On Thursday 25 June 2015 11:02 AM, Krzysztof Kozlowski wrote: On 25.06.2015 14:26, Vaibhav Hiremath wrote: On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath : As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe (page 0) controls

Re: [PATCH-v3 1/3] mfd: 88pm800: Add device tree support

2015-06-24 Thread Vaibhav Hiremath
On Thursday 25 June 2015 05:27 AM, Krzysztof Kozlowski wrote: 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath : Add DT support to the 88pm800 driver, along with compatible field for it's sub-devices (rtc, onkey and regulator) Signed-off-by: Chao Xie Signed-off-by: Vaibhav Hiremath

Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method

2015-06-24 Thread Vaibhav Hiremath
On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath : As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe (page 0) controls the method of clearing interrupt status of 88pm800 family of devices; 0: clear on read 1: clear on write

Re: Use of pinctrl-single for external device over I2C

2015-06-24 Thread Vaibhav Hiremath
On Wednesday 24 June 2015 07:03 PM, Tony Lindgren wrote: * Vaibhav Hiremath [150624 05:06]: On Tuesday 23 June 2015 04:25 PM, Vaibhav Hiremath wrote: /* * REVISIT: Reads and writes could eventually use regmap or something * generic. But at least on omaps, some mux registers

Re: Use of pinctrl-single for external device over I2C

2015-06-24 Thread Vaibhav Hiremath
On Tuesday 23 June 2015 04:25 PM, Vaibhav Hiremath wrote: Hi, + linux-arm-kernel & MFD Thanks, Vaibhav I am working on enabling support for PMIC 88PM860 device in the mainline. In 88PM860 (and family of devices) few pins are labelled as GPIO's, to be precise, in 88PM860, we have 8 GP

[PATCH-v3 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-06-24 Thread Vaibhav Hiremath
With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav Hiremath Acked-by: Rob Herring --- Documentation/devicetree/bindings/mfd/88pm800.txt | 60 +++ 1 file changed, 60

[PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method

2015-06-24 Thread Vaibhav Hiremath
T property and variable field to appropriate name. Signed-off-by: Zhao Ye Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 15 ++- include/linux/mfd/88pm80x.h | 6 -- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/mfd/88pm800.c b/drivers/m

[PATCH-v3 1/3] mfd: 88pm800: Add device tree support

2015-06-24 Thread Vaibhav Hiremath
Add DT support to the 88pm800 driver, along with compatible field for it's sub-devices (rtc, onkey and regulator) Signed-off-by: Chao Xie Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/mfd/88pm800

[PATCH-v3 0/3] mfd: 88pm800: Add Device tree support

2015-06-24 Thread Vaibhav Hiremath
d all other minor comments Attempt has been made to push some of the patches to the list sometime back in 2013. Link to previous patch submission: https://lkml.org/lkml/2013/8/14/86 TODO: = - init config for 88PM860 device - Rgulator driver changes to add support for 88PM860 d

[PATCH-v3 0/3] mfd: 88pm800: Add Device tree support

2015-06-24 Thread Vaibhav Hiremath
Attempt has been made to push some of the patches to the list sometime back in 2013. Link to previous patch submission: https://lkml.org/lkml/2013/8/14/86 TODO: = - init config for 88PM860 device - Rgulator driver changes to add support for 88PM860 device Vaibhav Hiremath (3): mfd

[PATCH-v3 1/3] mfd: 88pm800: Add device tree support

2015-06-24 Thread Vaibhav Hiremath
Add DT support to the 88pm800 driver, along with compatible field for it's sub-devices (rtc, onkey and regulator) Signed-off-by: Chao Xie chao@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 25 + 1 file changed, 25

[PATCH-v3 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-06-24 Thread Vaibhav Hiremath
With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Acked-by: Rob Herring r...@kernel.org --- Documentation/devicetree/bindings/mfd/88pm800.txt | 60

[PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method

2015-06-24 Thread Vaibhav Hiremath
and variable field to appropriate name. Signed-off-by: Zhao Ye zh...@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 15 ++- include/linux/mfd/88pm80x.h | 6 -- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git

Re: Use of pinctrl-single for external device over I2C

2015-06-24 Thread Vaibhav Hiremath
On Tuesday 23 June 2015 04:25 PM, Vaibhav Hiremath wrote: Hi, + linux-arm-kernel MFD Thanks, Vaibhav I am working on enabling support for PMIC 88PM860 device in the mainline. In 88PM860 (and family of devices) few pins are labelled as GPIO's, to be precise, in 88PM860, we have 8 GPIO's

Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method

2015-06-24 Thread Vaibhav Hiremath
On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org: As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe (page 0) controls the method of clearing interrupt status of 88pm800 family of devices; 0: clear

Re: Use of pinctrl-single for external device over I2C

2015-06-24 Thread Vaibhav Hiremath
On Thursday 25 June 2015 10:08 AM, Tony Lindgren wrote: * Vaibhav Hiremath vaibhav.hirem...@linaro.org [150624 10:12]: I do not like this, as this is not HW feature, so DT may not be right approach. So I will dig more from either runtime or Compile time option to use regmap_ Vs raw read

Re: [PATCH-v3 1/3] mfd: 88pm800: Add device tree support

2015-06-24 Thread Vaibhav Hiremath
On Thursday 25 June 2015 05:27 AM, Krzysztof Kozlowski wrote: 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org: Add DT support to the 88pm800 driver, along with compatible field for it's sub-devices (rtc, onkey and regulator) Signed-off-by: Chao Xie chao

Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method

2015-06-24 Thread Vaibhav Hiremath
On Thursday 25 June 2015 11:02 AM, Krzysztof Kozlowski wrote: On 25.06.2015 14:26, Vaibhav Hiremath wrote: On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org: As per the spec, bit 1 (INT_CLEAR_MODE) of reg

Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method

2015-06-24 Thread Vaibhav Hiremath
On Thursday 25 June 2015 11:20 AM, Krzysztof Kozlowski wrote: On 25.06.2015 14:44, Vaibhav Hiremath wrote: On Thursday 25 June 2015 11:02 AM, Krzysztof Kozlowski wrote: On 25.06.2015 14:26, Vaibhav Hiremath wrote: On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: 2015-06-24

Re: Use of pinctrl-single for external device over I2C

2015-06-24 Thread Vaibhav Hiremath
On Wednesday 24 June 2015 07:03 PM, Tony Lindgren wrote: * Vaibhav Hiremath vaibhav.hirem...@linaro.org [150624 05:06]: On Tuesday 23 June 2015 04:25 PM, Vaibhav Hiremath wrote: /* * REVISIT: Reads and writes could eventually use regmap or something * generic. But at least on omaps

Re: [PATCH-v2 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-06-23 Thread Vaibhav Hiremath
On Wednesday 24 June 2015 05:59 AM, Krzysztof Kozlowski wrote: 2015-06-18 3:58 GMT+09:00 Vaibhav Hiremath : With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav Hiremath --- Documentation

Re: [PATCH-v2 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-06-23 Thread Vaibhav Hiremath
On Tuesday 23 June 2015 09:07 PM, Rob Herring wrote: On Wed, Jun 17, 2015 at 1:58 PM, Vaibhav Hiremath wrote: With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav Hiremath Acked-by: Rob

Re: [PATCH V2 1/2] mfd: add Marvell 88pm88x description

2015-06-23 Thread Vaibhav Hiremath
On Tuesday 23 June 2015 08:01 PM, Rob Herring wrote: On Fri, Jun 12, 2015 at 3:43 AM, Yi Zhang wrote: 88pm880 and 88pm886 are two combo PMIC chips, most of the function and the register mapping are the same How do they compare to 80x/822/860 PMICs? Zhang, Sorry, I missed this

Use of pinctrl-single for external device over I2C

2015-06-23 Thread Vaibhav Hiremath
Hi, I am working on enabling support for PMIC 88PM860 device in the mainline. In 88PM860 (and family of devices) few pins are labelled as GPIO's, to be precise, in 88PM860, we have 8 GPIO's (ana & dig). I was looking at pinctrl-single driver, as it seems it can not handle pinmux configuration

Re: [PATCH V2 1/2] mfd: add Marvell 88pm88x description

2015-06-23 Thread Vaibhav Hiremath
On Tuesday 23 June 2015 08:01 PM, Rob Herring wrote: On Fri, Jun 12, 2015 at 3:43 AM, Yi Zhang yizh...@marvell.com wrote: 88pm880 and 88pm886 are two combo PMIC chips, most of the function and the register mapping are the same How do they compare to 80x/822/860 PMICs? Zhang, Sorry, I

Re: [PATCH-v2 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-06-23 Thread Vaibhav Hiremath
On Tuesday 23 June 2015 09:07 PM, Rob Herring wrote: On Wed, Jun 17, 2015 at 1:58 PM, Vaibhav Hiremath vaibhav.hirem...@linaro.org wrote: With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav

Re: [PATCH-v2 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-06-23 Thread Vaibhav Hiremath
On Wednesday 24 June 2015 05:59 AM, Krzysztof Kozlowski wrote: 2015-06-18 3:58 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org: With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav

Use of pinctrl-single for external device over I2C

2015-06-23 Thread Vaibhav Hiremath
Hi, I am working on enabling support for PMIC 88PM860 device in the mainline. In 88PM860 (and family of devices) few pins are labelled as GPIO's, to be precise, in 88PM860, we have 8 GPIO's (ana dig). I was looking at pinctrl-single driver, as it seems it can not handle pinmux configuration

Re: [PATCH-v2 0/3] mfd: 88pm800: Add Device tree support

2015-06-22 Thread Vaibhav Hiremath
On Thursday 18 June 2015 12:28 AM, Vaibhav Hiremath wrote: This patch-series adds support for Device tree to 88PM800 mfd driver. It also enabled configuration of irq clear method through DT. Testing:: - Boot tested on PXA1928 based platform. - probe of mfd, rtc and regulator function

Re: [PATCH-v2 0/3] mfd: 88pm800: Add Device tree support

2015-06-22 Thread Vaibhav Hiremath
On Thursday 18 June 2015 12:28 AM, Vaibhav Hiremath wrote: This patch-series adds support for Device tree to 88PM800 mfd driver. It also enabled configuration of irq clear method through DT. Testing:: - Boot tested on PXA1928 based platform. - probe of mfd, rtc and regulator function

[PATCH-v2 2/3] mfd: 88pm800: Allow configuration of interrupt clear method

2015-06-17 Thread Vaibhav Hiremath
T property and variable field to appropriate name. Signed-off-by: Zhao Ye Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 15 ++- include/linux/mfd/88pm80x.h | 6 -- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/mfd/88pm800.c b/drivers/m

[PATCH-v2] rtc: 88pm80x: add device tree support

2015-06-17 Thread Vaibhav Hiremath
Along with DT support, this patch also cleans up the unnecessary code around 'rtc_wakeup' initialization. Signed-off-by: Chao Xie Signed-off-by: Vaibhav Hiremath --- Link to V1: https://lkml.org/lkml/2015/5/29/757 drivers/rtc/rtc-88pm80x.c | 28 +--- 1 file changed, 17

[PATCH-v2 0/3] mfd: 88pm800: Add Device tree support

2015-06-17 Thread Vaibhav Hiremath
so will submit it separately to ease merging. - Fixed all other minor comments Attempt has been made to push some of the patches to the list sometime back in 2013. Link to previous patch submission: https://lkml.org/lkml/2013/8/14/86 Vaibhav Hiremath (3): mfd: 88pm800: Add device t

[PATCH-v2 1/3] mfd: 88pm800: Add device tree support

2015-06-17 Thread Vaibhav Hiremath
Add DT support to the 88pm800 driver, along with compatible field for it's sub-devices (rtc, onkey and regulator) Signed-off-by: Chao Xie Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/mfd/88pm800

[PATCH-v2 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-06-17 Thread Vaibhav Hiremath
With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings/mfd/88pm800.txt | 60 +++ 1 file changed, 60 insertions(+) create mode

[PATCH-v2 1/3] mfd: 88pm800: Add device tree support

2015-06-17 Thread Vaibhav Hiremath
Add DT support to the 88pm800 driver, along with compatible field for it's sub-devices (rtc, onkey and regulator) Signed-off-by: Chao Xie chao@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 25 + 1 file changed, 25

[PATCH-v2 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-06-17 Thread Vaibhav Hiremath
With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- Documentation/devicetree/bindings/mfd/88pm800.txt | 60 +++ 1 file changed, 60

[PATCH-v2 0/3] mfd: 88pm800: Add Device tree support

2015-06-17 Thread Vaibhav Hiremath
will submit it separately to ease merging. - Fixed all other minor comments Attempt has been made to push some of the patches to the list sometime back in 2013. Link to previous patch submission: https://lkml.org/lkml/2013/8/14/86 Vaibhav Hiremath (3): mfd: 88pm800: Add device tree

[PATCH-v2] rtc: 88pm80x: add device tree support

2015-06-17 Thread Vaibhav Hiremath
Along with DT support, this patch also cleans up the unnecessary code around 'rtc_wakeup' initialization. Signed-off-by: Chao Xie chao@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- Link to V1: https://lkml.org/lkml/2015/5/29/757 drivers/rtc/rtc-88pm80x.c | 28

[PATCH-v2 2/3] mfd: 88pm800: Allow configuration of interrupt clear method

2015-06-17 Thread Vaibhav Hiremath
and variable field to appropriate name. Signed-off-by: Zhao Ye zh...@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 15 ++- include/linux/mfd/88pm80x.h | 6 -- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 1/4] mfd: 88pm800: add device tree support

2015-06-16 Thread Vaibhav Hiremath
On Tuesday 16 June 2015 06:32 PM, Rob Herring wrote: On Tue, Jun 16, 2015 at 2:52 AM, Vaibhav Hiremath wrote: On Monday 01 June 2015 02:08 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote: Thanks for your review. and sorry for delayed response. Add DT support

Re: [PATCH 1/4] mfd: 88pm800: add device tree support

2015-06-16 Thread Vaibhav Hiremath
On Monday 01 June 2015 02:08 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote: Thanks for your review. and sorry for delayed response. Add DT support to the 88pm800 driver along with below properties - marvell,88pm800-irq-write-clear : Idicates whether

Re: [PATCH 1/4] mfd: 88pm800: add device tree support

2015-06-16 Thread Vaibhav Hiremath
On Tuesday 16 June 2015 06:32 PM, Rob Herring wrote: On Tue, Jun 16, 2015 at 2:52 AM, Vaibhav Hiremath vaibhav.hirem...@linaro.org wrote: On Monday 01 June 2015 02:08 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote: Thanks for your review. and sorry for delayed

Re: [PATCH 1/4] mfd: 88pm800: add device tree support

2015-06-16 Thread Vaibhav Hiremath
On Monday 01 June 2015 02:08 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote: Thanks for your review. and sorry for delayed response. Add DT support to the 88pm800 driver along with below properties - marvell,88pm800-irq-write-clear : Idicates whether

Re: [PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier

2015-06-02 Thread Vaibhav Hiremath
On Tuesday 02 June 2015 03:37 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: On Tuesday 02 June 2015 03:03 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: On Tuesday 02 June 2015 01:10 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote

Re: [PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier

2015-06-02 Thread Vaibhav Hiremath
On Tuesday 02 June 2015 03:03 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: On Tuesday 02 June 2015 01:10 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: On Monday 01 June 2015 01:52 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote

Re: [PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier

2015-06-02 Thread Vaibhav Hiremath
On Tuesday 02 June 2015 01:10 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: On Monday 01 June 2015 01:52 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote: RTC in pmic 88PM800 can run even the core is powered off, and user can set alarm in RTC. When

Re: [PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method

2015-06-02 Thread Vaibhav Hiremath
On Monday 01 June 2015 02:01 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote: From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the method of clearing interrupt status register of 88pm800; 0: clear on read 1: clear on write Signed-off-by: zhaoy

Re: [PATCH 4/4] mfd: 88pm800: allocate pdata-rtc if not allocated earlier

2015-06-02 Thread Vaibhav Hiremath
On Tuesday 02 June 2015 01:10 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: On Monday 01 June 2015 01:52 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote: RTC in pmic 88PM800 can run even the core is powered off, and user can set alarm in RTC. When

Re: [PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method

2015-06-02 Thread Vaibhav Hiremath
On Monday 01 June 2015 02:01 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote: From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the method of clearing interrupt status register of 88pm800; 0: clear on read 1: clear on write Signed-off-by: zhaoy zh

Re: [PATCH 4/4] mfd: 88pm800: allocate pdata-rtc if not allocated earlier

2015-06-02 Thread Vaibhav Hiremath
On Tuesday 02 June 2015 03:37 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: On Tuesday 02 June 2015 03:03 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: On Tuesday 02 June 2015 01:10 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote

Re: [PATCH 4/4] mfd: 88pm800: allocate pdata-rtc if not allocated earlier

2015-06-02 Thread Vaibhav Hiremath
On Tuesday 02 June 2015 03:03 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: On Tuesday 02 June 2015 01:10 PM, Lee Jones wrote: On Tue, 02 Jun 2015, Vaibhav Hiremath wrote: On Monday 01 June 2015 01:52 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote

Re: [PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier

2015-06-01 Thread Vaibhav Hiremath
On Monday 01 June 2015 01:52 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote: RTC in pmic 88PM800 can run even the core is powered off, and user can set alarm in RTC. When the alarm is timed out, the PMIC will power up the core, and the whole system will boot up. And during

Re: [PATCH 4/4] mfd: 88pm800: allocate pdata-rtc if not allocated earlier

2015-06-01 Thread Vaibhav Hiremath
On Monday 01 June 2015 01:52 PM, Lee Jones wrote: On Sat, 30 May 2015, Vaibhav Hiremath wrote: RTC in pmic 88PM800 can run even the core is powered off, and user can set alarm in RTC. When the alarm is timed out, the PMIC will power up the core, and the whole system will boot up. And during

[PATCH 4/4] mfd: 88pm800: allocate pdata->rtc if not allocated earlier

2015-05-29 Thread Vaibhav Hiremath
or not, and pass on this information to the RTC driver. So we need rtc platform data to be existed in PMIC driver to pass this information. Signed-off-by: Chao Xie Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[PATCH 1/4] mfd: 88pm800: add device tree support

2015-05-29 Thread Vaibhav Hiremath
-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings/mfd/88pm800.txt | 57 +++ drivers/mfd/88pm800.c | 39 2 files changed, 96 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt diff --git

[PATCH 3/4] rtc: 88pm80x: add device tree support

2015-05-29 Thread Vaibhav Hiremath
Along with DT support, this patch also cleans up the unnecessary code around 'rtc_wakeup' initialization. Signed-off-by: Chao Xie Signed-off-by: Vaibhav Hiremath --- drivers/rtc/rtc-88pm80x.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git

[PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method

2015-05-29 Thread Vaibhav Hiremath
>From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the method of clearing interrupt status register of 88pm800; 0: clear on read 1: clear on write Signed-off-by: zhaoy Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 4 +++- include/linux/mfd/88pm80x.h

[PATCH 0/4] Add Device tree support for 88PM800 mfd and rtc driver

2015-05-29 Thread Vaibhav Hiremath
sometime back in 2013. Link to previous patch submission: https://lkml.org/lkml/2013/8/14/86 Vaibhav Hiremath (4): mfd: 88pm800: add device tree support mfd: 88pm800: use irq_mode to configure interrupt status reg clear method rtc: 88pm80x: add device tree support mfd

[PATCH 0/4] Add Device tree support for 88PM800 mfd and rtc driver

2015-05-29 Thread Vaibhav Hiremath
sometime back in 2013. Link to previous patch submission: https://lkml.org/lkml/2013/8/14/86 Vaibhav Hiremath (4): mfd: 88pm800: add device tree support mfd: 88pm800: use irq_mode to configure interrupt status reg clear method rtc: 88pm80x: add device tree support mfd

[PATCH 3/4] rtc: 88pm80x: add device tree support

2015-05-29 Thread Vaibhav Hiremath
Along with DT support, this patch also cleans up the unnecessary code around 'rtc_wakeup' initialization. Signed-off-by: Chao Xie chao@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/rtc/rtc-88pm80x.c | 28 +--- 1 file changed, 17

[PATCH 2/4] mfd: 88pm800: use irq_mode to configure interrupt status reg clear method

2015-05-29 Thread Vaibhav Hiremath
From the spec, bit 1 of reg 0xe (page 0): IN_CLEAR_MODE controls the method of clearing interrupt status register of 88pm800; 0: clear on read 1: clear on write Signed-off-by: zhaoy zh...@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c

[PATCH 1/4] mfd: 88pm800: add device tree support

2015-05-29 Thread Vaibhav Hiremath
@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- Documentation/devicetree/bindings/mfd/88pm800.txt | 57 +++ drivers/mfd/88pm800.c | 39 2 files changed, 96 insertions(+) create mode 100644 Documentation

[PATCH 4/4] mfd: 88pm800: allocate pdata-rtc if not allocated earlier

2015-05-29 Thread Vaibhav Hiremath
or not, and pass on this information to the RTC driver. So we need rtc platform data to be existed in PMIC driver to pass this information. Signed-off-by: Chao Xie chao@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 19

Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

2015-05-18 Thread Vaibhav Hiremath
On Tuesday 19 May 2015 12:01 AM, Fabian Frederick wrote: On 18 May 2015 at 20:20 Vaibhav Hiremath wrote: On Monday 18 May 2015 11:24 PM, Fabian Frederick wrote: Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- drivers/media/platform/omap/omap_vout.c | 10

Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

2015-05-18 Thread Vaibhav Hiremath
On Monday 18 May 2015 11:24 PM, Fabian Frederick wrote: Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- drivers/media/platform/omap/omap_vout.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/omap/omap_vout.c

Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

2015-05-18 Thread Vaibhav Hiremath
On Monday 18 May 2015 11:24 PM, Fabian Frederick wrote: Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/media/platform/omap/omap_vout.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

2015-05-18 Thread Vaibhav Hiremath
On Tuesday 19 May 2015 12:01 AM, Fabian Frederick wrote: On 18 May 2015 at 20:20 Vaibhav Hiremath vaibhav.hirem...@linaro.org wrote: On Monday 18 May 2015 11:24 PM, Fabian Frederick wrote: Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers

[PATCH] ARM: OMAP2: AM33XX: id: Add support for new AM335x PG2.1 Si

2013-05-04 Thread Vaibhav Hiremath
Add support for chip id detection of AM335x PG2.1 Silicon. Currently omap3xxx_check_revision() detects PG1.0 and PG2.0 only, this patch extends it by adding PG2.1 Si support. Signed-off-by: Vaibhav Hiremath --- arch/arm/mach-omap2/id.c |8 ++-- arch/arm/mach-omap2/soc.h |1 + 2

[PATCH] ARM: OMAP2: AM33XX: id: Add support for new AM335x PG2.1 Si

2013-05-04 Thread Vaibhav Hiremath
Add support for chip id detection of AM335x PG2.1 Silicon. Currently omap3xxx_check_revision() detects PG1.0 and PG2.0 only, this patch extends it by adding PG2.1 Si support. Signed-off-by: Vaibhav Hiremath hvaib...@ti.com --- arch/arm/mach-omap2/id.c |8 ++-- arch/arm/mach-omap2/soc.h

Re: [PATCH] da8xx: Allow use by am33xx based devices

2012-12-10 Thread Vaibhav Hiremath
On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote: > Hi Tomi, > > On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote: >> Hi, >> >> On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote: >>> This driver can be used for AM33xx devices, like the popular beaglebone. >>> >>>

Re: [PATCH] da8xx: Allow use by am33xx based devices

2012-12-10 Thread Vaibhav Hiremath
On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote: Hi Tomi, On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote: Hi, On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote: This driver can be used for AM33xx devices, like the popular beaglebone. Signed-off-by: Pantelis

[PATCH] ARM: OMAP2+: gpmc: Fix kernel BUG for DT boot mode

2012-10-09 Thread Vaibhav Hiremath
is expected behavior, as gpmc is not supported yet from DT. Signed-off-by: Vaibhav Hiremath Cc: Afzal Mohammed Cc: Tony Lindgren Cc Paul Walmsley --- This should go in for rc1, as this breaks AM33xx boot. arch/arm/mach-omap2/gpmc.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff

[PATCH] ARM: OMAP2+: gpmc: Fix kernel BUG for DT boot mode

2012-10-09 Thread Vaibhav Hiremath
is expected behavior, as gpmc is not supported yet from DT. Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Cc: Afzal Mohammed af...@ti.com Cc: Tony Lindgren t...@atomide.com Cc Paul Walmsley p...@pwsan.com --- This should go in for rc1, as this breaks AM33xx boot. arch/arm/mach-omap2/gpmc.c |4

[PATCH 0/2] ARM: AM33XX: hwmod: Minor fixes for v3.7

2012-09-12 Thread Vaibhav Hiremath
been varified for, - Build Test (omap2plus_defconfig) - Boot tested on Bone - Sparse check pass Paul, Request to review these patches and give another pull request for this. Vaibhav Hiremath (2): ARM: AM33XX: hwmod: Remove platform specific header files ARM: AM33XX: hwmod: Add

[PATCH 2/2] ARM: AM33XX: hwmod: Add OMAP_INTC_START offset to all module int nos

2012-09-12 Thread Vaibhav Hiremath
With recent migration of omap architectures to SPARSE_IRQ framework, it is important to add OMAP_INTC_START to all interrupt numbers which will be eventually requested by drivers. This is required in order to get AM33XX boot functionality. Signed-off-by: Vaibhav Hiremath Cc: Paul Walmsley

[PATCH 1/2] ARM: AM33XX: hwmod: Remove platform specific header files

2012-09-12 Thread Vaibhav Hiremath
omap_hwmod_33xx_data.c. Signed-off-by: Vaibhav Hiremath Cc: Paul Walmsley --- arch/arm/mach-omap2/omap_hwmod_33xx_data.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c index

[PATCH 1/2] ARM: AM33XX: hwmod: Remove platform specific header files

2012-09-12 Thread Vaibhav Hiremath
omap_hwmod_33xx_data.c. Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Cc: Paul Walmsley p...@pwsan.com --- arch/arm/mach-omap2/omap_hwmod_33xx_data.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2

[PATCH 2/2] ARM: AM33XX: hwmod: Add OMAP_INTC_START offset to all module int nos

2012-09-12 Thread Vaibhav Hiremath
With recent migration of omap architectures to SPARSE_IRQ framework, it is important to add OMAP_INTC_START to all interrupt numbers which will be eventually requested by drivers. This is required in order to get AM33XX boot functionality. Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Cc: Paul

[PATCH 0/2] ARM: AM33XX: hwmod: Minor fixes for v3.7

2012-09-12 Thread Vaibhav Hiremath
been varified for, - Build Test (omap2plus_defconfig) - Boot tested on Bone - Sparse check pass Paul, Request to review these patches and give another pull request for this. Vaibhav Hiremath (2): ARM: AM33XX: hwmod: Remove platform specific header files ARM: AM33XX: hwmod: Add

Re: [PATCH 13/16] ARM: omap: move platform_data definitions

2012-09-11 Thread Vaibhav Hiremath
On 9/11/2012 7:54 PM, Shilimkar, Santosh wrote: > On Tue, Sep 11, 2012 at 7:47 PM, Arnd Bergmann wrote: >> On Tuesday 11 September 2012, Shilimkar, Santosh wrote: >>> Just curious to know how you came with some of the above header names ? >>> >>> plat/mcbsp ---> dsp-mcbsp.h >>> There is no

Re: [PATCH v2 3/3] usb: musb: omap: Add device tree support for omap musb glue

2012-09-11 Thread Vaibhav Hiremath
On 9/11/2012 2:39 PM, Kishon Vijay Abraham I wrote: > Added device tree support for omap musb driver and updated the > Documentation with device tree binding information. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/usb/omap-usb.txt | 33 >

Re: [PATCH v2 3/3] usb: musb: omap: Add device tree support for omap musb glue

2012-09-11 Thread Vaibhav Hiremath
On 9/11/2012 2:39 PM, Kishon Vijay Abraham I wrote: Added device tree support for omap musb driver and updated the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I kis...@ti.com --- Documentation/devicetree/bindings/usb/omap-usb.txt | 33

Re: [PATCH 13/16] ARM: omap: move platform_data definitions

2012-09-11 Thread Vaibhav Hiremath
On 9/11/2012 7:54 PM, Shilimkar, Santosh wrote: On Tue, Sep 11, 2012 at 7:47 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 11 September 2012, Shilimkar, Santosh wrote: Just curious to know how you came with some of the above header names ? plat/mcbsp --- dsp-mcbsp.h There is no

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Vaibhav Hiremath
On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: > The mailbox register for usb otg in omap is present in control module. > On detection of any events VBUS or ID, this register should be written > to send the notification to musb core. > > Till we have a separate control module driver to

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Vaibhav Hiremath
On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: The mailbox register for usb otg in omap is present in control module. On detection of any events VBUS or ID, this register should be written to send the notification to musb core. Till we have a separate control module driver to write to

Re: [PATCHv2 4/4] gpio: smscece: Add support for gpio IO expander feature

2012-09-05 Thread Vaibhav Hiremath
On 9/5/2012 5:07 PM, Sourav Poddar wrote: > smsc can be used as an gpio io expander device also. So adding > support for configuring smsc pins as a gpio. > > Cc: Benoit Cousson > Cc: Felipe Balbi > Cc: Santosh Shilimkar > Signed-off-by: Sourav Poddar > --- > Changes since v1: > - Use edge

Re: [PATCHv2 2/4] Input: keypad: Add smsc ece1099 keypad driver

2012-09-05 Thread Vaibhav Hiremath
On 9/5/2012 5:06 PM, Sourav Poddar wrote: > From: G, Manjunath Kondaiah > > SMSC ECE1099 is a keyboard scan or GPIO expansion device.The device > supports a keypad scan matrix of 23*8.This driver uses this > device as a keypad driver. > > Cc: Dmitry Torokhov > Cc: Benoit Cousson > Cc:

Re: [PATCHv2 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-09-05 Thread Vaibhav Hiremath
On 9/5/2012 5:06 PM, Sourav Poddar wrote: > smsc ece1099 is a keyboard scan or gpio expansion device. > The patch create keypad and gpio expander child for this > multi function smsc driver. > > Cc: Samuel Ortiz > Cc: Benoit Cousson > Cc: Felipe Balbi > Cc: Santosh Shilimkar >

Re: [PATCHv2 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-09-05 Thread Vaibhav Hiremath
On 9/5/2012 5:06 PM, Sourav Poddar wrote: smsc ece1099 is a keyboard scan or gpio expansion device. The patch create keypad and gpio expander child for this multi function smsc driver. Cc: Samuel Ortiz sa...@linux.intel.com Cc: Benoit Cousson b-cous...@ti.com Cc: Felipe Balbi

Re: [PATCHv2 2/4] Input: keypad: Add smsc ece1099 keypad driver

2012-09-05 Thread Vaibhav Hiremath
On 9/5/2012 5:06 PM, Sourav Poddar wrote: From: G, Manjunath Kondaiah manj...@ti.com SMSC ECE1099 is a keyboard scan or GPIO expansion device.The device supports a keypad scan matrix of 23*8.This driver uses this device as a keypad driver. Cc: Dmitry Torokhov dmitry.torok...@gmail.com

Re: [PATCHv2 4/4] gpio: smscece: Add support for gpio IO expander feature

2012-09-05 Thread Vaibhav Hiremath
On 9/5/2012 5:07 PM, Sourav Poddar wrote: smsc can be used as an gpio io expander device also. So adding support for configuring smsc pins as a gpio. Cc: Benoit Cousson b-cous...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Santosh Shilimkar santosh.shilim...@ti.com Signed-off-by: Sourav

[PATCH] ARM: OMAP2+: Makefile.boot: Add am335x evm and bone targets

2012-08-31 Thread Vaibhav Hiremath
This adds am335x-evm and am335x-bone dtb targets to 'make dtbs', just like other platforms. Signed-off-by: Vaibhav Hiremath Cc: Tony Lindgren --- arch/arm/mach-omap2/Makefile.boot |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Makefile.boot b/arch

[PATCH] ARM: OMAP2+: Makefile.boot: Add am335x evm and bone targets

2012-08-31 Thread Vaibhav Hiremath
This adds am335x-evm and am335x-bone dtb targets to 'make dtbs', just like other platforms. Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Cc: Tony Lindgren t...@atomide.com --- arch/arm/mach-omap2/Makefile.boot |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm

[RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resources allocated by OF layer

2012-08-29 Thread Vaibhav Hiremath
y (through DTB). Once DMA resource is available from OF layer, we should kill filling any resources from hwmod. - Non-DT boot mode Here, pdev->num_resources = 0, and we should get all the resources from hwmod (following existing steps) Signed-off-by: Vaibhav Hiremath Cc: B

[RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resources allocated by OF layer

2012-08-29 Thread Vaibhav Hiremath
). Once DMA resource is available from OF layer, we should kill filling any resources from hwmod. - Non-DT boot mode Here, pdev-num_resources = 0, and we should get all the resources from hwmod (following existing steps) Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Cc: Benoit

[PATCH 2/2] arm/dts: AM33XX: Specify reg and interrupt property for all nodes

2012-08-27 Thread Vaibhav Hiremath
and for only specific things. Newer platforms like, OMAP5 and AM33XX, we only support DT boot mode, so this patch is preparation for the future where we supposed to get rid of hwmod dependency anyway. Signed-off-by: Vaibhav Hiremath Cc: Tony Lindgren Cc: Benoit Cousson --- arch/arm/boot/dts

[PATCH 1/2] arm/dts: AM33XX: Convert all hex numbers to lower-case

2012-08-27 Thread Vaibhav Hiremath
To make it consistent, convert all hex number presentation to lower-case from all am33xx specific nodes. Signed-off-by: Vaibhav Hiremath Cc: Tony Lindgren --- arch/arm/boot/dts/am335x-bone.dts |2 +- arch/arm/boot/dts/am335x-evm.dts |2 +- arch/arm/boot/dts/am33xx.dtsi | 20

<    1   2   3   4   5   6   7   >