[PATCH] staging: pi433: fix CamelCase for Address variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/d

[PATCH] staging: pi433: fix CamelCase for afterSyncInterrupt

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH] staging: pi433: fix CamelCase for Address variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b

[PATCH] staging: pi433: fix CamelCase for address_filtering enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 12 ++-- drivers/staging/pi433/pi433_if.c

[PATCH] staging: pi433: fix CamelCase for flag enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin

[PATCH] staging: pi433: fix CamelCase for packetFormat enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 8 drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/

[PATCH] staging: pi433: fix CamelCase for paRamp enum

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/s

[PATCH] staging: pi433: fix CamelCase for address_filtering enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 12 ++-- drivers/staging/pi433/pi433_if.c | 6 +++--- drivers/staging/pi433/rf69.c

[PATCH] staging: pi433: fix CamelCase for flag enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin

[PATCH] staging: pi433: fix CamelCase for packetFormat enum

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 8 drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 2 +- drivers

[PATCH] staging: pi433: fix CamelCase for paRamp enum

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h

[PATCH] staging: pi433: fix CamelCase for addressFiltering

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 4 ++-- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- d

[PATCH] staging: pi433: fix CamelCase for addressFiltering

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 4 ++-- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.h

[PATCH] staging: pi433: fix CamelCase for thresholdDecrement

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/s

[PATCH] staging: pi433: fix CamelCase for thresholdDecrement

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h

[PATCH] staging: pi433: fix CamelCase for txStartCondition

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 4

[PATCH] staging: pi433: fix CamelCase for txStartCondition

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 4 files changed, 5 insertions(+), 5

[PATCH 8/8] staging: pi433: fix CamelCase for DIONumber

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/d

[PATCH 7/8] staging: pi433: fix CamelCase for regValue

Local variable storing the new value for dio register so replace with dio_value. Update regaddr to dio_addr to match. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.

[PATCH 7/8] staging: pi433: fix CamelCase for regValue

Local variable storing the new value for dio register so replace with dio_value. Update regaddr to dio_addr to match. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 24 1 file changed, 12

[PATCH 8/8] staging: pi433: fix CamelCase for DIONumber

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index

[PATCH 6/8] staging: pi433: fix CamelCase for newValue

Local variable storing the new value for bandwidth register so replace with bandwidth. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 16 1 file changed, 8 insertions

[PATCH 6/8] staging: pi433: fix CamelCase for newValue

Local variable storing the new value for bandwidth register so replace with bandwidth. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 5/8] staging: pi433: fix CamelCase for currentValue

Local variable storing the value for modulation register so replace with modulation_reg. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH 5/8] staging: pi433: fix CamelCase for currentValue

Local variable storing the value for modulation register so replace with modulation_reg. Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 4/8] staging: pi433: fix CamelCase for Ohm identifiers

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 4 ++-- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/

[PATCH 3/8] staging: pi433: fix CamelCase for antennaImpedance

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/s

[PATCH 4/8] staging: pi433: fix CamelCase for Ohm identifiers

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 4 ++-- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers

[PATCH 3/8] staging: pi433: fix CamelCase for antennaImpedance

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 2 +- drivers/staging/pi433/pi433_if.h | 2 +- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69.h

[PATCH 1/8] staging: pi433: fix CamelCase for syncValues

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 18 +- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging

[PATCH 1/8] staging: pi433: fix CamelCase for syncValues

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 18 +- drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging

[PATCH 2/8] staging: pi433: fix CamelCase for powerLevel

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/rf

[PATCH 2/8] staging: pi433: fix CamelCase for powerLevel

Fixes checkpatch warnings: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 8 drivers/staging/pi433/rf69.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c

[PATCH v2] staging: pi433: align function parameters with open parenthesis

Fixes checkpatch warnings: CHECK: Alignment should match open parenthesis Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: add missing Signed-off-by drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/d

[PATCH v2] staging: pi433: align function parameters with open parenthesis

Fixes checkpatch warnings: CHECK: Alignment should match open parenthesis Signed-off-by: Valentin Vidic --- v2: add missing Signed-off-by drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b

[PATCH] staging: pi433: align function parameters with open parenthesis

Fixes checkpatch warnings: CHECK: Alignment should match open parenthesis --- drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index f56425ffbe90..edcd7e798f99

[PATCH] staging: pi433: align function parameters with open parenthesis

Fixes checkpatch warnings: CHECK: Alignment should match open parenthesis --- drivers/staging/pi433/pi433_if.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index f56425ffbe90..edcd7e798f99

[PATCH] staging: pi433: remove unnecessary parentheses

Fixes checkpatch warnings: CHECK: Unnecessary parentheses around 'mantisse != mantisse16' CHECK: Unnecessary parentheses around 'mantisse != mantisse20' CHECK: Unnecessary parentheses around 'mantisse != mantisse24' Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- d

[PATCH] staging: pi433: remove unnecessary parentheses

Fixes checkpatch warnings: CHECK: Unnecessary parentheses around 'mantisse != mantisse16' CHECK: Unnecessary parentheses around 'mantisse != mantisse20' CHECK: Unnecessary parentheses around 'mantisse != mantisse24' Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 6

[PATCH] staging: pi433: replace shifting with BIT macro

Fixes checkpatch warnings: CHECK: Prefer using the BIT macro Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi43

[PATCH] staging: pi433: replace shifting with BIT macro

Fixes checkpatch warnings: CHECK: Prefer using the BIT macro Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 960249c600a5

[PATCH] staging: pi433: fix CamelCase for payload identifiers

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 6 +++--- drivers/staging/pi433/rf69.h | 2 +- drivers/staging

[PATCH] staging: pi433: fix CamelCase for payload identifiers

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 6 +++--- drivers/staging/pi433/rf69.h | 2 +- drivers/staging/pi433/rf69_enum.h | 2 +- 4 files

[PATCH] staging: pi433: fix CamelCase for maxMinus variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/Documentation/pi433.txt | 10 +- d

[PATCH] staging: pi433: fix CamelCase for maxMinus variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433.txt | 10 +- drivers/staging/pi433/rf69.c

[PATCH] staging: pi433: fix CamelCase for fifo variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/s

[PATCH] staging: pi433: fix CamelCase for fifo variables

Fixes checkpatch warnings: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Documentation/pi433

[PATCH 6/6 v5] staging: pi433: remove unused function

As it turns out rf69_get_lna_gain is not used at all. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/rf69.c | 18 -- drivers/staging/pi433/rf69.h | 1 - 2 files changed, 19 deletions(-) diff

[PATCH 6/6 v5] staging: pi433: remove unused function

As it turns out rf69_get_lna_gain is not used at all. Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/rf69.c | 18 -- drivers/staging/pi433/rf69.h | 1 - 2 files changed, 19 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b

[PATCH 5/6 v5] staging: pi433: replace printk calls with dev_dbg

Fixes checkpatch warning: WARNING: printk() should include KERN_ facility level Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 5/6 v5] staging: pi433: replace printk calls with dev_dbg

Fixes checkpatch warning: WARNING: printk() should include KERN_ facility level Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b

[PATCH 1/6 v5] staging: pi433: collapse else block after return statement

Fixes checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 14 +++--- 1 file changed, 7 insertions(+), 7 del

[PATCH 1/6 v5] staging: pi433: collapse else block after return statement

Fixes checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging

[PATCH 4/6 v5] staging: pi433: avoid logging ENOMEM messages

Fixes checkpatch warning: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/d

[PATCH 4/6 v5] staging: pi433: avoid logging ENOMEM messages

Fixes checkpatch warning: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b

[PATCH 3/6 v5] staging: pi433: replace unsigned with unsigned int

Fixes checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 2/6 v5] staging: pi433: cleanup local variable declaration

Fix variable naming and checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

[PATCH 3/6 v5] staging: pi433: replace unsigned with unsigned int

Fixes checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b

[PATCH 2/6 v5] staging: pi433: cleanup local variable declaration

Fix variable naming and checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic --- v5: resend patchset based on comments drivers/staging/pi433/pi433_if.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 6/8 v4] staging: pi433: remove unused function

As it turns out rf69_get_lna_gain is not used at all. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use CURRENT suffix - precompute define values v4:

[PATCH 6/8 v4] staging: pi433: remove unused function

As it turns out rf69_get_lna_gain is not used at all. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use CURRENT suffix - precompute define values v4: - drop the whole function since

[PATCH] staging: pi433: fix CamelCase for dccPercent variables

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 30 +++--- drivers/staging/pi433/rf69.h | 6 +++--- drivers/staging/pi433/rf69_enum.h | 18 +--

[PATCH] staging: pi433: fix CamelCase for dccPercent variables

Fixes checkpatch warning: CHECK: Avoid CamelCase: Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 30 +++--- drivers/staging/pi433/rf69.h | 6 +++--- drivers/staging/pi433/rf69_enum.h | 18 +- 3 files changed, 27 insertions

[PATCH 2/8 v3] staging: pi433: cleanup local variable declaration

Fix variable naming and checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: use a better variable name v3: keep the variable scope drivers/staging/pi433/pi433_if.c | 8 +--- 1 file changed, 5 inse

[PATCH 2/8 v3] staging: pi433: cleanup local variable declaration

Fix variable naming and checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic --- v2: use a better variable name v3: keep the variable scope drivers/staging/pi433/pi433_if.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

[PATCH 6/8 v3] staging: pi433: use defines for shifting register values

Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use CURRENT suffix - precompute define values d

[PATCH 6/8 v3] staging: pi433: use defines for shifting register values

Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use CURRENT suffix - precompute define values drivers/staging/pi433/rf69.c

Re: [PATCH 6/8] staging: pi433: use defines for shifting register values

On Wed, Dec 13, 2017 at 05:32:28PM +0200, Marcus Wolf wrote: > Am 13.12.2017 um 16:21 schrieb Valentin Vidic: > > Avoid shifting by magic numbers and use defines instead: > > > >SHIFT_DATAMODUL_MODULATION_TYPE > >SHIFT_LNA_CURRENT_GAIN > > > > Sig

Re: [PATCH 6/8] staging: pi433: use defines for shifting register values

On Wed, Dec 13, 2017 at 05:32:28PM +0200, Marcus Wolf wrote: > Am 13.12.2017 um 16:21 schrieb Valentin Vidic: > > Avoid shifting by magic numbers and use defines instead: > > > >SHIFT_DATAMODUL_MODULATION_TYPE > >SHIFT_LNA_CURRENT_GAIN > >

[PATCH 6/8 v2] staging: pi433: use defines for shifting register values

Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file drivers/staging/pi433/rf69.c | 16 drivers/staging

[PATCH 6/8 v2] staging: pi433: use defines for shifting register values

Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file drivers/staging/pi433/rf69.c | 16 drivers/staging/pi433/rf69_registers.h | 8

[PATCH 2/8 v2] staging: pi433: move var declaration to function level

Fixes checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- v2: use a better variable name drivers/staging/pi433/pi433_if.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/s

[PATCH 2/8 v2] staging: pi433: move var declaration to function level

Fixes checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic --- v2: use a better variable name drivers/staging/pi433/pi433_if.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers

Re: [PATCH 8/8] staging: pi433: replace printk calls with dev_dbg

On Wed, Dec 13, 2017 at 05:52:36PM +0300, Dan Carpenter wrote: > On Wed, Dec 13, 2017 at 03:21:56PM +0100, Valentin Vidic wrote: > > drivers/staging/pi433/pi433_if.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/pi43

Re: [PATCH 8/8] staging: pi433: replace printk calls with dev_dbg

On Wed, Dec 13, 2017 at 05:52:36PM +0300, Dan Carpenter wrote: > On Wed, Dec 13, 2017 at 03:21:56PM +0100, Valentin Vidic wrote: > > drivers/staging/pi433/pi433_if.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/pi43

[PATCH 4/8] staging: pi433: add parentheses to mask and shift

Fixes checkpatch warning: WARNING: Possible precedence defect with mask then right shift - may need parentheses Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH 4/8] staging: pi433: add parentheses to mask and shift

Fixes checkpatch warning: WARNING: Possible precedence defect with mask then right shift - may need parentheses Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers

[PATCH 7/8] staging: pi433: avoid logging ENOMEM messages

Fixes checkpatch warning: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/d

[PATCH 6/8] staging: pi433: use defines for shifting register values

Avoid shifting by magic numbers and use defines instead: SHIFT_DATAMODUL_MODULATION_TYPE SHIFT_LNA_CURRENT_GAIN Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_registers.h | 2 ++ 2 files chan

[PATCH 7/8] staging: pi433: avoid logging ENOMEM messages

Fixes checkpatch warning: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index

[PATCH 6/8] staging: pi433: use defines for shifting register values

Avoid shifting by magic numbers and use defines instead: SHIFT_DATAMODUL_MODULATION_TYPE SHIFT_LNA_CURRENT_GAIN Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_registers.h | 2 ++ 2 files changed, 4 insertions(+), 2 deletions

[PATCH 3/8] staging: pi433: replace unsigned with unsigned int

Fixes checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/d

[PATCH 3/8] staging: pi433: replace unsigned with unsigned int

Fixes checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index

[PATCH 2/8] staging: pi433: move var declaration to function level

Fixes checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/s

[PATCH 1/8] staging: pi433: collapse else block after return statement

Fixes checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging

[PATCH 2/8] staging: pi433: move var declaration to function level

Fixes checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index

[PATCH 1/8] staging: pi433: collapse else block after return statement

Fixes checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging

[PATCH 5/8] staging: pi433: fix DATAMODUL_MODULATION_TYPE_OOK value

Reading from the spec, allowed values for modulation scheme after the shift are: 00 FSK 01 OOK 10 - 11 reserved Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/rf69_registers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 5/8] staging: pi433: fix DATAMODUL_MODULATION_TYPE_OOK value

Reading from the spec, allowed values for modulation scheme after the shift are: 00 FSK 01 OOK 10 - 11 reserved Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69_registers.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433

[PATCH 8/8] staging: pi433: replace printk calls with dev_dbg

Fixes checkpatch warning: WARNING: printk() should include KERN_ facility level Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/d

[PATCH 8/8] staging: pi433: replace printk calls with dev_dbg

Fixes checkpatch warning: WARNING: printk() should include KERN_ facility level Signed-off-by: Valentin Vidic --- drivers/staging/pi433/pi433_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index

Re: [Xen-devel] HPET enabled in BIOS, not presented as available_clocksource -- config, kernel code, &/or BIOS?

On Sat, May 13, 2017 at 02:58:54PM -0700, PGNet Dev wrote: > Does this perhaps imply that Xen correctly uses HPET > > (XEN) [VT-D] MSI HPET: :f0:0f.0 > (XEN) Platform timer is 14.318MHz HPET I think so, yes. > but that Dom0 does not > > current_clocksource >

Re: [Xen-devel] HPET enabled in BIOS, not presented as available_clocksource -- config, kernel code, &/or BIOS?

On Sat, May 13, 2017 at 02:58:54PM -0700, PGNet Dev wrote: > Does this perhaps imply that Xen correctly uses HPET > > (XEN) [VT-D] MSI HPET: :f0:0f.0 > (XEN) Platform timer is 14.318MHz HPET I think so, yes. > but that Dom0 does not > > current_clocksource >

Re: [Xen-devel] HPET enabled in BIOS, not presented as available_clocksource -- config, kernel code, &/or BIOS?

On Sat, May 13, 2017 at 02:06:28PM -0700, PGNet Dev wrote: > xl dmesg | grep -i hpet | grep -vi command > [1.365876] hpet_acpi_add: no address or irqs in _CRS > [1.365876] hpet_acpi_add: no address or irqs in _CRS Ah, guess this is caused by console_to_ring boot option. Better check

Re: [Xen-devel] HPET enabled in BIOS, not presented as available_clocksource -- config, kernel code, &/or BIOS?

On Sat, May 13, 2017 at 02:06:28PM -0700, PGNet Dev wrote: > xl dmesg | grep -i hpet | grep -vi command > [1.365876] hpet_acpi_add: no address or irqs in _CRS > [1.365876] hpet_acpi_add: no address or irqs in _CRS Ah, guess this is caused by console_to_ring boot option. Better check

Re: [Xen-devel] HPET enabled in BIOS, not presented as available_clocksource -- config, kernel code, &/or BIOS?

On Sat, May 13, 2017 at 01:05:22PM -0700, PGNet Dev wrote: > back to the error at hand ... > > xl dmesg | grep -i hpet > [1.365876] hpet_acpi_add: no address or irqs in _CRS > [1.365876] hpet_acpi_add: no address or irqs in _CRS > > again, only present when booting with Xen. > >

Re: [Xen-devel] HPET enabled in BIOS, not presented as available_clocksource -- config, kernel code, &/or BIOS?

On Sat, May 13, 2017 at 01:05:22PM -0700, PGNet Dev wrote: > back to the error at hand ... > > xl dmesg | grep -i hpet > [1.365876] hpet_acpi_add: no address or irqs in _CRS > [1.365876] hpet_acpi_add: no address or irqs in _CRS > > again, only present when booting with Xen. > >

[PATCH] staging: media/atomisp: drop unused qos variable

Fixes a sparse warning: drivers/staging/media/atomisp/platform/intel-mid/intel_mid_pcihelpers.c:35:5: warning: symbol 'qos' was not declared. Should it be static? Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/staging/media/atomisp/platform/int

[PATCH] staging: media/atomisp: drop unused qos variable

Fixes a sparse warning: drivers/staging/media/atomisp/platform/intel-mid/intel_mid_pcihelpers.c:35:5: warning: symbol 'qos' was not declared. Should it be static? Signed-off-by: Valentin Vidic --- drivers/staging/media/atomisp/platform/intel-mid/intel_mid_pcihelpers.c | 1 - 1 file changed, 1

[PATCH] ipmi/watchdog: fix watchdog timeout set on reboot

of (XEN) Scrubbing Free RAM. Fix this by setting the timer to 120s only if it was previously set to a low value. Signed-off-by: Valentin Vidic <valentin.vi...@carnet.hr> --- drivers/char/ipmi/ipmi_watchdog.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/d

<    1   2   3   >