Andersson.
- Removed extra newlines as suggested by Konrad Dybcio.
- Changed sd-cd pin to bias-pull-up in sdc2_off as suggested by
Veerabhadrarao Badiganti.
- Added bandwidth votes for eMMC and SD card.
---
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 25
On 3/24/2021 9:58 PM, Stephen Boyd wrote:
Quoting Stephen Boyd (2021-03-24 08:57:33)
Quoting sbh...@codeaurora.org (2021-03-24 08:23:55)
On 2021-03-23 12:31, Stephen Boyd wrote:
Quoting Shaik Sajida Bhanu (2021-03-20 11:17:00)
+
+ bus-width = <8>;
+
On 3/10/2021 12:48 AM, Shaik Sajida Bhanu wrote:
Add nodes for eMMC and SD card on sc7280.
Signed-off-by: Shaik Sajida Bhanu
---
This change is depends on the below patch series:
https://lore.kernel.org/lkml/1613114930-1661-1-git-send-email-rna...@codeaurora.org/
https://lore.kernel.org/patc
On 12/22/2020 2:18 PM, Md Sadre Alam wrote:
of_device_get_match_data returns NULL when no match.
So add the NULL pointer check to avoid dereference.
Signed-off-by: Md Sadre Alam
---
Reviewed-by: Veerabhadrarao Badiganti
drivers/mmc/host/sdhci-msm.c | 2 ++
1 file changed, 2
nclude the multiplier that sdhci-msm needs
internally.
Suggested-by: Adrian Hunter
Signed-off-by: Douglas Anderson
Reviewed-by: Bjorn Andersson
Reviewed-by: Veerabhadrarao Badiganti
---
Changes in v5:
- Remove unused clock parameter.
- Add a comment that we're stashing the requested rate
On 12/11/2020 10:42 PM, Douglas Anderson wrote:
The MSM SDHCI driver always set the "actual_clock" field to 0. It had
a comment about it not being needed because we weren't using the
standard SDHCI divider mechanism and we'd just fallback to
"host->clock". However, it's still better to provid
On 11/3/2020 8:55 PM, Ulf Hansson wrote:
On Wed, 28 Oct 2020 at 12:20, Veerabhadrarao Badiganti
wrote:
The commit bbdc74dc19e0 ("mmc: block: Prevent new req entering queue
after its cleanup") has introduced this change but it got moved after
del_gendisk() with commit 57678e5a
Hi Ulf, Adrian,
Gentle reminder. Can you share your comments on this issue and change?
Thanks
On 10/28/2020 4:49 PM, Veerabhadrarao Badiganti wrote:
The commit bbdc74dc19e0 ("mmc: block: Prevent new req entering queue
after its cleanup") has introduced this change but it got m
mmc_remove_host
sdhci_remove_host
sdhci_msm_remove
sdhci_msm_shutdown
platform_drv_shutdown
device_shutdown
kernel_restart_prepare
kernel_restart
So bringing this change back.
Signed-off-by: Veerabhadrarao Badiganti
---
I'm observing this issue 100%
restore_dll_config ensures this.
Enabling this flag with this change. And simply re-using the sdm845
target configuration for this flag.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-msm.c b
On 7/24/2020 3:06 PM, Ulf Hansson wrote:
On Tue, 14 Jul 2020 at 16:12, Veerabhadrarao Badiganti
wrote:
On 7/13/2020 9:26 PM, Veerabhadrarao Badiganti wrote:
On 7/11/2020 5:49 AM, Matthias Kaehlcke wrote:
Hi,
On Fri, Jul 10, 2020 at 04:28:36PM +0530, Veerabhadrarao Badiganti
wrote:
Hi
On 7/13/2020 9:26 PM, Veerabhadrarao Badiganti wrote:
On 7/11/2020 5:49 AM, Matthias Kaehlcke wrote:
Hi,
On Fri, Jul 10, 2020 at 04:28:36PM +0530, Veerabhadrarao Badiganti
wrote:
Hi Mathias,
On 7/10/2020 6:22 AM, Matthias Kaehlcke wrote:
Hi,
On Wed, Jul 08, 2020 at 06:41:20PM +0530
On 7/11/2020 5:49 AM, Matthias Kaehlcke wrote:
Hi,
On Fri, Jul 10, 2020 at 04:28:36PM +0530, Veerabhadrarao Badiganti wrote:
Hi Mathias,
On 7/10/2020 6:22 AM, Matthias Kaehlcke wrote:
Hi,
On Wed, Jul 08, 2020 at 06:41:20PM +0530, Veerabhadrarao Badiganti wrote:
Configure SDHC IO pins
Hi Mathias,
On 7/10/2020 6:22 AM, Matthias Kaehlcke wrote:
Hi,
On Wed, Jul 08, 2020 at 06:41:20PM +0530, Veerabhadrarao Badiganti wrote:
Configure SDHC IO pins with low power configuration when the driver
is in suspend state.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host
Don't access vqmmc regulator handler, if it's already invalidated.
Fixes: f870b6d480d3 (mmc: sdhci: Allow platform controlled voltage switching)
Reported-by: Dan Carpenter
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci.c | 12 +++-
1 file changed, 7 insert
ned-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index efd2bae1430c..93d67a3a899f 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/s
Configure SDHC IO pins with low power configuration when the driver
is in suspend state.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
cases in
shci_msm_handle_pwr_irq().
- Moved common code out of switch case in
sdhci_msm_start_signal_voltage_switch().
- Updated variable name to sdhci_core_to_disable_vqmmc.
- Updated pr_err logs to dev_err logs.
Veerabhadrarao Badiganti (2):
mmc: core: Set default
Set the default power mode (which is MMC_POWER_UNDEFINE)
in mmc_alloc_host, so that the vendor drivers can make use of this
state to perform needed actions during the platform driver probe.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/core/host.c | 1 +
1 file changed, 1 insertion
Badiganti
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 206 +--
1 file changed, 197 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 15c42b059240..cbe15519e7b9 100644
--- a
From: Vijay Viswanath
If vendor platform drivers are controlling whole logic of voltage
switching, then sdhci driver no need control vqmmc regulator.
So skip enabling/disable vqmmc from SDHC driver.
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
Acked-by: Adrian Hunter
On 6/17/2020 7:46 PM, Ulf Hansson wrote:
On Wed, 17 Jun 2020 at 14:46, Veerabhadrarao Badiganti
wrote:
Thanks for comments Uffe.
On 6/17/2020 3:04 PM, Ulf Hansson wrote:
On Tue, 16 Jun 2020 at 17:38, Veerabhadrarao Badiganti
wrote:
On qcom SD host controllers voltage switching be done
Thanks for comments Uffe.
On 6/17/2020 3:04 PM, Ulf Hansson wrote:
On Tue, 16 Jun 2020 at 17:38, Veerabhadrarao Badiganti
wrote:
On qcom SD host controllers voltage switching be done after the HW
is ready for it. The HW informs its readiness through power irq.
The voltage switching should
From: Vijay Viswanath
If vendor platform drivers are controlling whole logic of voltage
switching, then sdhci driver no need control vqmmc regulator.
So skip enabling/disable vqmmc from SDHC driver.
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
Acked-by: Adrian Hunter
Badiganti
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 208 +--
1 file changed, 199 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 15c42b059240..8297b2142748 100644
--- a
sdhci_msm_start_signal_voltage_switch().
- Updated variable name to sdhci_core_to_disable_vqmmc.
- Updated pr_err logs to dev_err logs.
Veerabhadrarao Badiganti (2):
dt-bindings: mmc: Supply max load for mmc supplies
mmc: sdhci-msm: Use internal voltage control
Vijay Viswanath (1):
mmc: sdhci: Allow
Hi Bjorn,
Do you have any comments on V3 patchset?
Thanks
Veera
On 6/2/2020 4:17 PM, Veerabhadrarao Badiganti wrote:
On qcom SD host controllers voltage switching be done after the HW
is ready for it. The HW informs its readiness through power irq.
The voltage switching should happen only
full initialization
which gives time reduction in system/runtime resume path.
Signed-off-by: Maya Erez
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/core/mmc.c | 146 ---
include/linux/mmc/card.h | 4 ++
include/linux/mmc/host.h | 2 +
3
From: Vijay Viswanath
If vendor platform drivers are controlling whole logic of voltage
switching, then sdhci driver no need control vqmmc regulator.
So skip enabling/disable vqmmc from SDHC driver.
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
Acked-by: Adrian Hunter
well so that regulator can be configured
in LPM mode when in is not being used.
Co-developed-by: Asutosh Das
Signed-off-by: Asutosh Das
Co-developed-by: Vijay Viswanath
Signed-off-by: Vijay Viswanath
Co-developed-by: Veerabhadrarao Badiganti
Signed-off-by: Veerabhadrarao Badiganti
sdhci_core_to_disable_vqmmc.
- Updated pr_err logs to dev_err logs.
Veerabhadrarao Badiganti (2):
dt-bindings: mmc: Supply max load for mmc supplies
mmc: sdhci-msm: Use internal voltage control
Vijay Viswanath (1):
mmc: sdhci: Allow platform controlled voltage switching
.../devicetree/bindings/mmc
Supply the max load needed for driving the mmc supplies.
Signed-off-by: Veerabhadrarao Badiganti
---
Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
b/Documentation
On 5/29/2020 4:05 PM, Ulf Hansson wrote:
On Thu, 28 May 2020 at 17:14, Veerabhadrarao Badiganti
wrote:
Clear tuning_done flag while executing tuning to ensure vendor
specific HS400 settings are applied properly when the controller
is re-initialized in HS400 mode.
Without this, re
.
Fixes: ff06ce4 ("mmc: sdhci-msm: Add HS400 platform support")
Cc: sta...@vger.kernel.org
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
ind
On 5/22/2020 10:34 PM, Bjorn Andersson wrote:
On Fri 22 May 06:27 PDT 2020, Veerabhadrarao Badiganti wrote:
Hi Bjorn,
On 5/22/2020 12:37 AM, Bjorn Andersson wrote:
On Thu 21 May 08:23 PDT 2020, Veerabhadrarao Badiganti wrote:
On qcom SD host controllers voltage switching be done after
Hi Bjorn,
On 5/22/2020 12:37 AM, Bjorn Andersson wrote:
On Thu 21 May 08:23 PDT 2020, Veerabhadrarao Badiganti wrote:
On qcom SD host controllers voltage switching be done after the HW
is ready for it. The HW informs its readiness through power irq.
The voltage switching should happen only
From: Vijay Viswanath
If vendor platform drivers are controlling whole logic of voltage
switching, then sdhci driver no need control vqmmc regulator.
So skip enabling/disable vqmmc from SDHC driver.
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host
Supply the max load needed for driving the mmc supplies.
Signed-off-by: Veerabhadrarao Badiganti
---
.../devicetree/bindings/mmc/mmc-controller.yaml | 16
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
b
dev_err logs.
Veerabhadrarao Badiganti (1):
dt-bindings: mmc: Supply max load for mmc supplies
mmc: sdhci-msm: Use internal voltage control
Vijay Viswanath (1):
mmc: sdhci: Allow platform controlled voltage switching
.../devicetree/bindings/mmc/mmc-controller.yaml| 16 ++
drivers/mmc/host
well so that regulator can be configured
in LPM mode when in is not being used.
Co-developed-by: Asutosh Das
Signed-off-by: Asutosh Das
Co-developed-by: Vijay Viswanath
Signed-off-by: Vijay Viswanath
Co-developed-by: Veerabhadrarao Badiganti
Signed-off-by: Veerabhadrarao Badiganti
On 5/19/2020 11:36 AM, Adrian Hunter wrote:
On 15/05/20 2:18 pm, Veerabhadrarao Badiganti wrote:
From: Vijay Viswanath
If vendor platform drivers are controlling whole logic of voltage
switching, then sdhci driver no need control vqmmc regulator.
So skip enabling/disable vqmmc from SDHC
Thanks Bjorn for the review. For major comments I'm responding.
Other comments, i will take care of them in my next patch-set.
On 5/19/2020 1:27 AM, Bjorn Andersson wrote:
On Fri 15 May 04:18 PDT 2020, Veerabhadrarao Badiganti wrote:
From: Vijay Viswanath
On qcom SD host contro
Supply the max load needed for driving the mmc supplies.
Signed-off-by: Veerabhadrarao Badiganti
---
.../devicetree/bindings/mmc/mmc-controller.yaml | 16
1 file changed, 16 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
b
From: Vijay Viswanath
If vendor platform drivers are controlling whole logic of voltage
switching, then sdhci driver no need control vqmmc regulator.
So skip enabling/disable vqmmc from SDHC driver.
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host
.
Set the regulator load as well so that regulator can be configured
in LPM mode when in is not being used.
Signed-off-by: Asutosh Das
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 215 +--
1 file
but not actively pursued
https://lore.kernel.org/linux-arm-msm/1539004739-32060-1-git-send-email-vbadi...@codeaurora.org/
So posting it as fresh patchset.
Veerabhadrarao Badiganti (1):
dt-bindings: mmc: Supply max load for mmc supplies
Vijay Viswanath (2):
mmc: sdhci-msm: Use internal
On 5/6/2020 10:06 PM, Ulf Hansson wrote:
On Wed, 6 May 2020 at 15:01, Veerabhadrarao Badiganti
wrote:
On 4/28/2020 5:26 AM, Chun-Hung Wu wrote:
Parse CQE bindings "supports-cqe" and "disable-cqe-dcmd"
in mmc_of_parse().
Signed-off-by: Chun-Hung Wu
---
drivers
From: Sarthak Garg
Consider the following stack trace
-001|raw_spin_lock_irqsave
-002|mmc_blk_cqe_complete_rq
-003|__blk_mq_complete_request(inline)
-003|blk_mq_complete_request(rq)
-004|mmc_cqe_timed_out(inline)
-004|mmc_mq_timed_out
mmc_mq_timed_out acquires the queue_lock for the first
time.
From: Sarthak Garg
Consider the following stack trace
-001|raw_spin_lock_irqsave
-002|mmc_blk_cqe_complete_rq
-003|__blk_mq_complete_request(inline)
-003|blk_mq_complete_request(rq)
-004|mmc_cqe_timed_out(inline)
-004|mmc_mq_timed_out
mmc_mq_timed_out acquires the queue_lock for the first
time.
Fixes for a couple of issues observed with CQE. One with CQE completion
path and the other one is with CQE recovery path.
Sarthak Garg (1):
mmc: core: Fix recursive locking issue in CQE recovery path
Veerabhadrarao Badiganti (1):
mmc: core: Check request type before completing the request
-by: Veerabhadrarao Badiganti
---
drivers/mmc/core/block.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index 8499b56..c5367e2 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -1370,6 +1370,7 @@ static v
On 4/28/2020 5:26 AM, Chun-Hung Wu wrote:
Parse CQE bindings "supports-cqe" and "disable-cqe-dcmd"
in mmc_of_parse().
Signed-off-by: Chun-Hung Wu
---
drivers/mmc/core/host.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index c87
that the
user space application that wants to make use of this can do so.
Signed-off-by: Krishna Konda
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/core/mmc.c | 6 ++
include/linux/mmc/card.h | 1 +
include/linux/mmc/mmc.h | 1 +
3 files changed, 8 insertions(+)
diff --git a
On 11/12/2018 10:49 PM, Veerabhadrarao Badiganti wrote:
On 10/17/2018 3:39 AM, Evan Green wrote:
On Mon, Oct 8, 2018 at 6:22 AM Veerabhadrarao Badiganti
wrote:
From: Vijay Viswanath
Some controllers can have internal mechanism to inform the SW that it
is ready for voltage switching. For
On 10/17/2018 3:39 AM, Evan Green wrote:
On Mon, Oct 8, 2018 at 6:22 AM Veerabhadrarao Badiganti
wrote:
From: Vijay Viswanath
Some controllers can have internal mechanism to inform the SW that it
is ready for voltage switching. For such controllers, changing voltage
before the HW is ready
Please ignore this patch set. Right patch-set is V5.
https://patchwork.kernel.org/project/linux-mmc/list/?series=41661
Sorry for the inconvenience.
Thanks
Veera
On 11/12/2018 11:52 AM, Veerabhadrarao Badiganti wrote:
On few SDHCI-MSM controllers, the host controller's clock t
Please ignore this patch set. Right patch-set is V5.
https://patchwork.kernel.org/project/linux-mmc/list/?series=41661
Sorry for the inconvenience.
Thanks
Veera
On 11/12/2018 11:26 AM, Veerabhadrarao Badiganti wrote:
Add SoC-specific compatible strings for qcom-sdhci controller
Please ignore this patch set. Right patch-set is V5.
https://patchwork.kernel.org/project/linux-mmc/list/?series=41661
Sorry for the inconvenience.
Thanks
Veera
On 11/12/2018 12:08 PM, Veerabhadrarao Badiganti wrote:
On few SDHCI-MSM controllers, the host controller's clock t
Please ignore this patch set. Right patch-set is V5.
https://patchwork.kernel.org/project/linux-mmc/list/?series=41661
Sorry for the inconvenience.
Thanks
Veera
On 11/12/2018 12:08 PM, Veerabhadrarao Badiganti wrote:
Add SoC-specific compatible strings for qcom-sdhci controller.
Signed
tings once clocks are ungated.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 78 +---
1 file changed, 67 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 3cc8bfe..4c
ce V1:
- Replaced dt flag with a dt compatible string to
indicate SHDCI-MSM controller varients which need this fix.
- Moved the DLL settings restoration logic from request
context to platform driver runtime pm context.
Tested on: sdm845
Veerabhadrarao Badiganti (2):
Add SoC-specific compatible strings for qcom-sdhci controller.
Signed-off-by: Veerabhadrarao Badiganti
---
Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci
tings once clocks are ungated.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 78 +---
1 file changed, 67 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 3cc8bfe..4c
Add SoC-specific compatible strings for qcom-sdhci controller.
Signed-off-by: Veerabhadrarao Badiganti
---
Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci
s fix.
- Moved the DLL settings restoration logic from request
context to platform driver runtime pm context.
Tested on: sdm845
Veerabhadrarao Badiganti (2):
dt-bindings: mmc: sdhci-msm: Add SoC-specific compatible strings
mmc: sdhci-msm: Re-initialize DLL if MCLK is gated dynami
tings once clocks are ungated.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 78 +---
1 file changed, 67 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 3cc8bfe..4c
tings once clocks are ungated.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 78 +---
1 file changed, 67 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 3cc8bfe..4c
Add SoC-specific compatible strings for qcom-sdhci controller.
Signed-off-by: Veerabhadrarao Badiganti
---
Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci
On 10/12/2018 8:25 PM, Rob Herring wrote:
On Mon, Oct 08, 2018 at 06:48:58PM +0530, Veerabhadrarao Badiganti wrote:
From: Vijay Viswanath
The load a particular sdhc controller should request from a regulator
is device specific and hence each device should individually vote for
the required
On 11/6/2018 2:41 AM, Doug Anderson wrote:
Hi,
On Mon, Nov 5, 2018 at 12:37 PM Rob Herring wrote:
On Thu, Nov 01, 2018 at 01:29:54PM -0700, Doug Anderson wrote:
Hi,
On Thu, Nov 1, 2018 at 5:07 AM Veerabhadrarao Badiganti
wrote:
For SDM845 SOC, new compatible string "qcom,sdm845-
On 11/2/2018 2:03 AM, Doug Anderson wrote:
Hi,
On Thu, Nov 1, 2018 at 5:08 AM Veerabhadrarao Badiganti
wrote:
static const struct sdhci_msm_variant_info sdhci_msm_v5_var = {
.mci_removed = true,
+ .restore_dll_config = false,
+ .var_ops = &v5_var_ops,
+ .of
tings once clocks are ungated.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 59 ++--
1 file changed, 57 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 3cc8bfe..e3
For SDM845 SOC, new compatible string "qcom,sdm845-sdhci" is added.
Signed-off-by: Veerabhadrarao Badiganti
---
Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt
b/Doc
On 10/13/2018 2:18 AM, Rob Herring wrote:
On Mon, Oct 08, 2018 at 06:55:37PM +0530, Veerabhadrarao Badiganti wrote:
On the SDHC-MSM controllers which makes use of sdcdc10 variant DLLs,
the DLL configuration needs to be restored whenever controller clocks
are gated. This new compatible string
On 10/17/2018 3:58 AM, Evan Green wrote:
On Mon, Oct 8, 2018 at 6:26 AM Veerabhadrarao Badiganti
wrote:
On few SDHCI-MSM controllers, the host controller's clock tuning
circuit may go out of sync if controller clocks are gated which
eventually will result in data CRC, command CRC/ti
update interrupt number and base address
https://android.googlesource.com/kernel/msm/+/android-msm-wahoo-4.4-oreo-m2/arch/arm/boot/dts/qcom/sdm660.dtsi
On 25 September 2018 16:39:33 BST, Craig wrote:
On 25 September 2018 12:17:26 BST, Veerabhadrarao Badiganti
wrote:
On 9/25/2018 1:18 AM, Craig
tings once clocks are ungated.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 67 ++--
1 file changed, 65 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 6918e70..1e
On the SDHC-MSM controllers which makes use of sdcdc10 variant DLLs,
the DLL configuration needs to be restored whenever controller clocks
are gated. This new compatible string denotes the sdhc-msm controller
variant which uses sdcdc10 DLL.
Signed-off-by: Veerabhadrarao Badiganti
switching using power irq.
Signed-off-by: Asutosh Das
Signed-off-by: Venkat Gopalakrishnan
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 212 +--
1 file changed, 204 insertions(+), 8 deletions(-)
diff
From: Vijay Viswanath
The load a particular sdhc controller should request from a regulator
is device specific and hence each device should individually vote for
the required load.
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
---
Documentation/devicetree/bindings
already done by platform driver.
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci.c | 32 +++-
drivers/mmc/host/sdhci.h | 1 +
2 files changed, 20 insertions(+), 13 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b
On 9/22/2018 1:36 AM, Evan Green wrote:
On Fri, Sep 21, 2018 at 3:32 AM Veerabhadrarao Badiganti
wrote:
Hi Evan,
On 9/21/2018 5:45 AM, Evan Green wrote:
On Wed, Sep 19, 2018 at 11:24 PM Veerabhadrarao Badiganti
wrote:
From: Vijay Viswanath
The load a particular sdhc controller should
Hi Evan,
On 9/22/2018 1:38 AM, Evan Green wrote:
On Wed, Sep 19, 2018 at 11:24 PM Veerabhadrarao Badiganti
wrote:
From: Vijay Viswanath
Some controllers can have internal mechanism to inform the SW that it
is ready for voltage switching. For such controllers, changing voltage
before the HW
On 9/22/2018 1:39 AM, Evan Green wrote:
On Wed, Sep 19, 2018 at 11:24 PM Veerabhadrarao Badiganti
wrote:
From: Vijay Viswanath
Some sdhci-msm controllers require that voltage switching be done after
the HW is ready for it. The HW informs its readiness through power irq.
The voltage
On 9/25/2018 11:08 PM, Evan Green wrote:
On Tue, Sep 25, 2018 at 8:05 AM Veerabhadrarao Badiganti
wrote:
The dll settings of SDHC controller needs to be restored whenever
controller clocks are gated. This restoration is needed only on
few SDHCI-MSM controllers. This dt flag indicates
Hi Doug,
On 9/26/2018 3:58 AM, Doug Anderson wrote:
Hi,
On Tue, Sep 25, 2018 at 8:05 AM Veerabhadrarao Badiganti
wrote:
+ /*
+* Whenever core-clock is gated dynamically, it's needed to
+* re-initialize the DLL when the clock is ungated.
+*/
+ if (msm
tings once clocks are ungated.
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 486462d..4a83850 100644
The dll settings of SDHC controller needs to be restored whenever
controller clocks are gated. This restoration is needed only on
few SDHCI-MSM controllers. This dt flag indicates whether dll
restoration is needed or not.
Signed-off-by: Veerabhadrarao Badiganti
---
Documentation/devicetree
On 9/25/2018 1:18 AM, Craig Tatlor wrote:
What socs have you tested this on?
On sdm660 it seems to crash device
when writing pwr ctl.
Hi
We have tested this on SDM845.
SDM660 also has SDCC5 controller, so you would need to define
"qcom,sdhci-msm-v5" in your platform dt.
Can you confirm if you
Hi Evan,
On 9/21/2018 5:45 AM, Evan Green wrote:
On Wed, Sep 19, 2018 at 11:24 PM Veerabhadrarao Badiganti
wrote:
From: Vijay Viswanath
The load a particular sdhc controller should request from a regulator
is device specific and hence each device should individually vote for
the required
switching using power irq.
Signed-off-by: Asutosh Das
Signed-off-by: Venkat Gopalakrishnan
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci-msm.c | 211 +--
1 file changed, 203 insertions(+), 8 deletions(-)
diff
already done by platform driver.
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
---
drivers/mmc/host/sdhci.c | 22 +++---
drivers/mmc/host/sdhci.h | 1 +
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host
From: Vijay Viswanath
The load a particular sdhc controller should request from a regulator
is device specific and hence each device should individually vote for
the required load.
Signed-off-by: Vijay Viswanath
Signed-off-by: Veerabhadrarao Badiganti
---
Documentation/devicetree/bindings
the quirk for internal voltage switching and then control the
voltage switching using power irq.
Signed-off-by: Asutosh Das
Signed-off-by: Venkat Gopalakrishnan
Signed-off-by: Veerabhadrarao Badiganti
Signed-off-by: Vijay Viswanath
---
drivers/mmc/host/sdhci-msm.c | 220
94 matches
Mail list logo
