RE: [PATCH v3 2/5] i3c: master: make sure ->boardinfo is initialized in add_i3c_dev_locked()

2019-10-03 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Thu, Oct 03, 2019 at 15:29:43 > On Thu, 5 Sep 2019 12:00:35 +0200 > Vitor Soares wrote: > > > The newdev->boardinfo assignment was missing in > > i3c_master_add_i3c_dev_locked() and hence the ->of_node info isn'

RE: [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-10-03 Thread Vitor Soares
Hi Jonathan, From: Jonathan Cameron Date: Thu, Oct 03, 2019 at 12:49:02 > On Wed, 25 Sep 2019 15:35:10 + > Vitor Soares wrote: > > > Hi Jonathan, > > > > From: Jonathan Cameron > > Date: Sun, Jul 21, 2019 at 18:16:56 > > > > > On Fr

RE: [PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-09-25 Thread Vitor Soares
Hi Jonathan, From: Jonathan Cameron Date: Sun, Jul 21, 2019 at 18:16:56 > On Fri, 19 Jul 2019 15:30:55 +0200 > Vitor Soares wrote: > > > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in > > spi and i2c mode. > > > > The LSM6DSO an

RE: [PATCH v3 1/5] i3c: master: detach/free devices fail on pre_assign_dyn_addr()

2019-09-17 Thread Vitor Soares
Hi Boris, From: Vitor Soares Date: Thu, Sep 05, 2019 at 11:00:34 > As for today, the I3C framework is keeping in memory and master->bus.devs > list the devices that fail during pre_assign_dyn_addr() and send them on > DEFSLVS command. > > According to MIPI I3C Bus spec the

[PATCH v3 5/5] i3c: master: dw: reattach device on first available location of address table

2019-09-05 Thread Vitor Soares
For today the reattach function only update the device address on the controller. Update the location to the first available too, will optimize the enumeration process avoiding additional checks to keep the available positions on address table consecutive. Signed-off-by: Vitor Soares Reviewed

[PATCH v3 1/5] i3c: master: detach/free devices fail on pre_assign_dyn_addr()

2019-09-05 Thread Vitor Soares
capable devices due to lack of space in controller. Signed-off-by: Vitor Soares --- Changes in v3: - Change commit message Changes in v2: - Move out detach/free the i3c_dev_desc from pre_assign_dyn_addr() - Convert i3c_master_pre_assign_dyn_addr() to return an int drivers/i3c/maste

[PATCH v3 3/5] dt-bindings: i3c: Make 'assigned-address' valid if static address == 0

2019-09-05 Thread Vitor Soares
The I3C devices without a static address can require a specific dynamic address for priority reasons. Let's update the binding document to make the 'assigned-address' property valid if static address == 0 and add an example with this use case. Signed-off-by: Vitor Soares R

[PATCH v3 2/5] i3c: master: make sure ->boardinfo is initialized in add_i3c_dev_locked()

2019-09-05 Thread Vitor Soares
") Signed-off-by: Vitor Soares --- Change in v3: - None Changes in v2: - Change commit message - Change i3c_master_search_i3c_boardinfo(newdev) to i3c_master_init_i3c_dev_boardinfo(newdev) - Add fixes, stable tags drivers/i3c/master.c | 27 +-- 1 file changed

[PATCH v3 4/5] dt-bindings: i3c: add a note for no guarantee of 'assigned-address' use

2019-09-05 Thread Vitor Soares
By default, the framework will try to assign the 'assigned-address' to the device but if the address is already in use the device dynamic address will be different. Signed-off-by: Vitor Soares Reviewed-by: Rob Herring --- Change in v3: - Add Rob rb-tag Documentation/devicetree/bi

[PATCH v3 0/5] i3c: detach/free device fail pre_assign_dyn_addr()

2019-09-05 Thread Vitor Soares
guarantee of 'assigned-address' use Vitor Soares (5): i3c: master: detach and free device if pre_assign_dyn_addr() fails i3c: master: make sure ->boardinfo is initialized in add_i3c_dev_locked() dt-bindings: i3c: Make 'assigned-address' valid if static address ==

RE: [PATCH v2 1/5] i3c: master: detach and free device if pre_assign_dyn_addr() fails

2019-09-04 Thread Vitor Soares
From: Przemyslaw Gaj Date: Wed, Sep 04, 2019 at 05:47:18 > The 09/03/2019 11:57, Vitor Soares wrote: > > EXTERNAL MAIL > > > > > > From: Przemyslaw Gaj > > Date: Tue, Sep 03, 2019 at 12:13:57 > > > > > Hi Vitor, > > > > > >

RE: [PATCH v2 1/5] i3c: master: detach and free device if pre_assign_dyn_addr() fails

2019-09-03 Thread Vitor Soares
From: Przemyslaw Gaj Date: Tue, Sep 03, 2019 at 12:13:57 > Hi Vitor, > > I'm sorry for the delay. > > The 09/03/2019 12:35, Vitor Soares wrote: > > EXTERNAL MAIL > > > > > > On pre_assing_dyn_addr() the devices that fail: > > i3c_master_

RE: [PATCH v2 1/5] i3c: master: detach and free device if pre_assign_dyn_addr() fails

2019-09-03 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Tue, Sep 03, 2019 at 11:52:37 > On Tue, 3 Sep 2019 12:35:50 +0200 > Vitor Soares wrote: > > > On pre_assing_dyn_addr() the devices that fail: > > i3c_master_setdasa_locked() > > i3c_master_reattach_i3c_dev() > &g

[PATCH v2 1/5] i3c: master: detach and free device if pre_assign_dyn_addr() fails

2019-09-03 Thread Vitor Soares
ing and freeing the devices that fail on pre_assign_dyn_addr(). Signed-off-by: Vitor Soares --- Changes in v2: - Move out detach/free the i3c_dev_desc from pre_assign_dyn_addr() - Convert i3c_master_pre_assign_dyn_addr() to return an int drivers/i3c/master.c | 22 +++--- 1 f

[PATCH v2 2/5] i3c: master: make sure ->boardinfo is initialized in add_i3c_dev_locked()

2019-09-03 Thread Vitor Soares
") Signed-off-by: Vitor Soares --- Changes in v2: - Change commit message - Change i3c_master_search_i3c_boardinfo(newdev) to i3c_master_init_i3c_dev_boardinfo(newdev) - Add fixes, stable tags drivers/i3c/master.c | 27 +-- 1 file changed, 25 insertions(+), 2 delet

[PATCH v2 3/5] dt-bindings: i3c: Make 'assigned-address' valid if static address == 0

2019-09-03 Thread Vitor Soares
The I3C devices without a static address can require a specific dynamic address for priority reasons. Let's update the binding document to make the 'assigned-address' property valid if static address == 0 and add an example with this use case. Signed-off-by: Vitor Soares ---

[PATCH v2 5/5] i3c: master: dw: reattach device on first available location of address table

2019-09-03 Thread Vitor Soares
For today the reattach function only update the device address on the controller. Update the location to the first available too, will optimize the enumeration process avoiding additional checks to keep the available positions on address table consecutive. Signed-off-by: Vitor Soares Reviewed

[PATCH v2 0/5] i3c: remove device if failed on pre_assign_dyn_addr()

2019-09-03 Thread Vitor Soares
dev) - Add fixes, stable tags on patch 2 - Add a note for no guarantee of 'assigned-address' use Vitor Soares (5): i3c: master: detach and free device if pre_assign_dyn_addr() fails i3c: master: make sure ->boardinfo is initialized in add_i3c_dev_locked() dt-bindings: i3c

[PATCH v2 4/5] dt-bindings: i3c: add a note for no guarantee of 'assigned-address' use

2019-09-03 Thread Vitor Soares
By default, the framework will try to assign the 'assigned-address' to the device but if the address is already in use the device dynamic address will be different. Signed-off-by: Vitor Soares --- Documentation/devicetree/bindings/i3c/i3c.txt | 4 +++- 1 file changed, 3 insert

RE: [PATCH 2/4] i3c: master: Check if devices have i3c_dev_boardinfo on i3c_master_add_i3c_dev_locked()

2019-08-29 Thread Vitor Soares
From: Boris Brezillon Date: Thu, Aug 29, 2019 at 17:15:20 > On Thu, 29 Aug 2019 15:57:32 + > Vitor Soares wrote: > > > -Original Message- > > From: Boris Brezillon > > > > Sent: Thursday, August 29, 2019 4:25 > > PM > >

RE: [PATCH 1/4] i3c: master: detach and free device if pre_assign_dyn_addr() fails

2019-08-29 Thread Vitor Soares
From: Boris Brezillon Date: Thu, Aug 29, 2019 at 16:37:09 > On Thu, 29 Aug 2019 15:23:30 + > Vitor Soares wrote: > > > From: Boris Brezillon > > Date: Thu, Aug 29, 2019 at 15:35:20 > > > > > On Thu, 29 Aug 2019 13:53:24 + > > > V

RE: [PATCH 2/4] i3c: master: Check if devices have i3c_dev_boardinfo on i3c_master_add_i3c_dev_locked()

2019-08-29 Thread Vitor Soares
-Original Message- From: Boris Brezillon Sent: Thursday, August 29, 2019 4:25 PM To: Vitor Soares Cc: linux-kernel@vger.kernel.org; devicet...@vger.kernel.org; linux-...@lists.infradead.org; bbrezil...@kernel.org; robh...@kernel.org; mark.rutl...@arm.com; joao.pi...@synopsys.com

RE: [PATCH 1/4] i3c: master: detach and free device if pre_assign_dyn_addr() fails

2019-08-29 Thread Vitor Soares
From: Boris Brezillon Date: Thu, Aug 29, 2019 at 15:35:20 > On Thu, 29 Aug 2019 13:53:24 + > Vitor Soares wrote: > > > Hi Boris, > > > > From: Boris Brezillon > > Date: Thu, Aug 29, 2019 at 11:41:15 > > > > > +Przemek > > > >

RE: [PATCH 2/4] i3c: master: Check if devices have i3c_dev_boardinfo on i3c_master_add_i3c_dev_locked()

2019-08-29 Thread Vitor Soares
From: Boris Brezillon Date: Thu, Aug 29, 2019 at 15:39:41 > On Thu, 29 Aug 2019 16:39:18 +0200 > Boris Brezillon wrote: > > > On Thu, 29 Aug 2019 14:00:44 + > > Vitor Soares wrote: > > > > > Hi Boris, > > > > > > From: Bori

RE: [PATCH 4/4] i3c: master: dw: reattach device on first available location of address table

2019-08-29 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Thu, Aug 29, 2019 at 12:15:19 > On Thu, 29 Aug 2019 12:19:35 +0200 > Vitor Soares wrote: > > > For today the reattach function only update the device address on the > > controller. > > > > Update the location to the first

RE: [PATCH 3/4] dt-bindings: i3c: Make 'assigned-address' valid if static address != 0

2019-08-29 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Thu, Aug 29, 2019 at 11:51:38 > On Thu, 29 Aug 2019 12:19:34 +0200 > Vitor Soares wrote: > > > The I3C devices without a static address can require a specific dynamic > > address for priority reasons. > > > > Let's u

RE: [PATCH 2/4] i3c: master: Check if devices have i3c_dev_boardinfo on i3c_master_add_i3c_dev_locked()

2019-08-29 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Thu, Aug 29, 2019 at 11:44:57 > On Thu, 29 Aug 2019 12:19:33 +0200 > Vitor Soares wrote: > > > The I3C devices described in DT might not be attached to the master which > > doesn't allow to assign a specific dynamic address. &g

RE: [PATCH 1/4] i3c: master: detach and free device if pre_assign_dyn_addr() fails

2019-08-29 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Thu, Aug 29, 2019 at 11:41:15 > +Przemek > > Please try to Cc active I3C contributors so they get a chance to > comment on your patches. I can do that next time. > > On Thu, 29 Aug 2019 12:19:32 +0200 > Vitor Soares wrote: > &g

[PATCH 0/4] i3c: remove device if failed on pre_assign_dyn_addr()

2019-08-29 Thread Vitor Soares
if there no oldev. This change will allow to describe in DT device with preferable dynamic address but without static address. Vitor Soares (4): "i3c: detach and free device if pre_assign_dyn_addr fails " i3c: check i3c_boardinfo during i3c_master_add_i3c_dev_locked update i3c bingins

[PATCH 2/4] i3c: master: Check if devices have i3c_dev_boardinfo on i3c_master_add_i3c_dev_locked()

2019-08-29 Thread Vitor Soares
dinfo->init_dyn_addr even if stactic address = 0. Signed-off-by: Vitor Soares --- drivers/i3c/master.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 4d29e1f..85fbda6 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/

[PATCH 1/4] i3c: master: detach and free device if pre_assign_dyn_addr() fails

2019-08-29 Thread Vitor Soares
ing and freeing the devices that fail on pre_assign_dyn_addr(). Signed-off-by: Vitor Soares --- drivers/i3c/master.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 5f4bd52..4d29e1f 100644 --- a/drivers/i3c/maste

[PATCH 3/4] dt-bindings: i3c: Make 'assigned-address' valid if static address != 0

2019-08-29 Thread Vitor Soares
The I3C devices without a static address can require a specific dynamic address for priority reasons. Let's update the binding document to make the 'assigned-address' property valid if static address != 0 and add an example with this use case. Signed-off-by: Vitor Soares ---

[PATCH 4/4] i3c: master: dw: reattach device on first available location of address table

2019-08-29 Thread Vitor Soares
For today the reattach function only update the device address on the controller. Update the location to the first available too, will optimize the enumeration process avoiding additional checks to keep the available positions on address table consecutive. Signed-off-by: Vitor Soares

RE: [PATCH v6 1/2] i3c: move i3c_device_match_id to device.c and export it

2019-07-19 Thread Vitor Soares
From: Boris Brezillon Date: Fri, Jul 19, 2019 at 14:45:03 > On Fri, 19 Jul 2019 15:30:54 +0200 > Vitor Soares wrote: > > > Some I3C device drivers need to know which entry matches the > > i3c_device object passed to the probe function > > > > Let's move

RE: [PATCH v5 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-19 Thread Vitor Soares
From: Boris Brezillon Date: Fri, Jul 19, 2019 at 13:51:10 > On Fri, 19 Jul 2019 13:19:05 +0200 > Vitor Soares wrote: > > > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in > > spi and i2c mode. > > > > The LSM6DSO and LSM6DSR are a

[PATCH v6 1/2] i3c: move i3c_device_match_id to device.c and export it

2019-07-19 Thread Vitor Soares
Some I3C device drivers need to know which entry matches the i3c_device object passed to the probe function Let's move i3c_device_match_id() to device.c and export it so it can be used by drivers. Signed-off-by: Vitor Soares --- Changes in v6: Improve kerneldoc Changes in v5: Add kern

[PATCH v6 0/2] Add ST lsm6dso i3c support

2019-07-19 Thread Vitor Soares
v4: remover hw_id variable from st_lsm6dsx_i3c_probe() Change in v3: Update st_lsm6dsx_probe() call Remove i3c_get_device_id() and use i3c_device_match_id() Changes in v2: Change i3c_get_device_id() to drivers/i3c/device.c Add support for LSM6DSR Vitor Soares (2): i3c: add

[PATCH v6 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-19 Thread Vitor Soares
For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in spi and i2c mode. The LSM6DSO and LSM6DSR are also i3c capable so let's give i3c support to them. Signed-off-by: Vitor Soares Acked-by: Lorenzo Bianconi Reviewed-by: Boris Brezillon --- Changes in v6: none Ch

[PATCH v5 1/2] i3c: move i3c_device_match_id to device.c and export it

2019-07-19 Thread Vitor Soares
Some I3C device drivers need to know which entry matches the i3c_device object passed to the probe function Let's move i3c_device_match_id() to device.c and export it so it can be used by drivers. Signed-off-by: Vitor Soares --- Changes in v5: Add kerneldoc Improve commit message Ch

[PATCH v5 0/2] Add ST lsm6dso i3c support

2019-07-19 Thread Vitor Soares
st_lsm6dsx_i3c_probe() Change in v3: Update st_lsm6dsx_probe() call Remove i3c_get_device_id() and use i3c_device_match_id() Changes in v2: Change i3c_get_device_id() to drivers/i3c/device.c Add support for LSM6DSR Vitor Soares (2): i3c: add i3c_get_device_id helper iio: imu

[PATCH v5 2/2] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-19 Thread Vitor Soares
For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in spi and i2c mode. The LSM6DSO and LSM6DSR are also i3c capable so let's give i3c support to them. Signed-off-by: Vitor Soares Acked-by: Lorenzo Bianconi --- Changes in v5: Move regmap_config declaration i

RE: [PATCH v4 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-16 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Fri, Jul 12, 2019 at 21:03:20 > On Fri, 12 Jul 2019 18:40:14 + > Vitor Soares wrote: > > > From: Boris Brezillon > > Date: Fri, Jul 12, 2019 at 17:43:23 > > > > > On Fri, 12 Jul 2019 16:28:02 + > > &g

RE: [PATCH v4 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-12 Thread Vitor Soares
From: Boris Brezillon Date: Fri, Jul 12, 2019 at 17:43:23 > On Fri, 12 Jul 2019 16:28:02 + > Vitor Soares wrote: > > > From: Boris Brezillon > > Date: Fri, Jul 12, 2019 at 17:14:29 > > > > > On Fri, 12 Jul 2019 13:53:30 +0200 > > > Vitor

RE: [PATCH v4 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-12 Thread Vitor Soares
From: Boris Brezillon Date: Fri, Jul 12, 2019 at 17:14:29 > On Fri, 12 Jul 2019 13:53:30 +0200 > Vitor Soares wrote: > > > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in > > spi and i2c mode. > > > > The LSM6DSO and LSM6DSR are

RE: [PATCH v4 2/3] i3c: move i3c_device_match_id to device.c and export it

2019-07-12 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Fri, Jul 12, 2019 at 17:03:38 > On Fri, 12 Jul 2019 13:53:29 +0200 > Vitor Soares wrote: > > > The i3c device driver needs the i3c_device_id table. > > "Some I3C device drivers need to know which entry matches the > i3c_devi

RE: [PATCH v4 1/3] regmap: add i3c bus support

2019-07-12 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Fri, Jul 12, 2019 at 16:59:15 > On Fri, 12 Jul 2019 13:53:28 +0200 > Vitor Soares wrote: > > > Add basic support for i3c bus. > > This is a simple implementation that only give support > > for SDR Read and Write commands. &g

[PATCH v4 2/3] i3c: move i3c_device_match_id to device.c and export it

2019-07-12 Thread Vitor Soares
The i3c device driver needs the i3c_device_id table. Lets move it to device.c and export it to be used. Signed-off-by: Vitor Soares --- Changes in v4: None Changes in v3: Remove i3c_get_device_id Move i3c_device_match_id from drivers/i3c/master.c to drivers/i3c/device.c Export

[PATCH v4 0/3] Add ST lsm6dso i3c support

2019-07-12 Thread Vitor Soares
() Changes in v2: Change i3c_get_device_id() to drivers/i3c/device.c Add support for LSM6DSR Vitor Soares (3): regmap: add i3c bus support i3c: add i3c_get_device_id helper iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR drivers/base/regmap/Kconfig | 6

[PATCH v4 1/3] regmap: add i3c bus support

2019-07-12 Thread Vitor Soares
Add basic support for i3c bus. This is a simple implementation that only give support for SDR Read and Write commands. Signed-off-by: Vitor Soares --- drivers/base/regmap/Kconfig | 6 +++- drivers/base/regmap/Makefile | 1 + drivers/base/regmap/regmap-i3c.c | 60

[PATCH v4 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-12 Thread Vitor Soares
For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in spi and i2c mode. The LSM6DSO and LSM6DSR are also i3c capable so lets give i3c support to them. Signed-off-by: Vitor Soares Acked-by: Lorenzo Bianconi --- Changes in v4: Remove hw_id variable Changes in v3: Remove

RE: [PATCH v3 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-11 Thread Vitor Soares
From: Vitor Soares Date: Thu, Jul 11, 2019 at 11:12:34 > Hi Lorenzo, > > From: Lorenzo Bianconi > Date: Wed, Jul 10, 2019 at 20:44:05 > > > > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in > > > spi and i2c mode. > > >

RE: [PATCH v3 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-11 Thread Vitor Soares
. > > Hi Vitor, > > just few comments inline. > > Regards, > Lorenzo > > > > > Signed-off-by: Vitor Soares > > Acked-by: Lorenzo Bianconi > > --- > > Changes in v3: > > Remove unnecessary st_lsm6dsx_i3c_data table used to hold dev

[PATCH v3 2/3] i3c: move i3c_device_match_id to device.c and export it

2019-07-10 Thread Vitor Soares
The i3c device driver needs the i3c_device_id table. Lets move it to device.c and export it to be used. Signed-off-by: Vitor Soares --- Changes in v3: Remove i3c_get_device_id Move i3c_device_match_id from drivers/i3c/master.c to drivers/i3c/device.c Export i3c_device_match_id Changes in

[PATCH v3 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-07-10 Thread Vitor Soares
For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in spi and i2c mode. The LSM6DSO and LSM6DSR are also i3c capable so lets give i3c support to them. Signed-off-by: Vitor Soares Acked-by: Lorenzo Bianconi --- Changes in v3: Remove unnecessary st_lsm6dsx_i3c_data table

[PATCH v3 0/3] Add ST lsm6dso i3c support

2019-07-10 Thread Vitor Soares
Add support for LSM6DSR Vitor Soares (3): regmap: add i3c bus support i3c: add i3c_get_device_id helper iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR drivers/base/regmap/Kconfig | 6 ++- drivers/base/regmap/Makefile| 1 + drivers/base

[PATCH v3 1/3] regmap: add i3c bus support

2019-07-10 Thread Vitor Soares
Add basic support for i3c bus. This is a simple implementation that only give support for SDR Read and Write commands. Signed-off-by: Vitor Soares --- drivers/base/regmap/Kconfig | 6 +++- drivers/base/regmap/Makefile | 1 + drivers/base/regmap/regmap-i3c.c | 60

[PATCH v4 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-19 Thread Vitor Soares
operating in mixed fast mode. Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Signed-off-by: Vitor Soares Cc: Boris Brezillon Cc: Cc: --- Changes in v4: Print i2c-scl and i3c-scl unconditionally when in debug mode Changes in v3: Change dev_warn() to dev_dbg() Changes in v2:

[PATCH v4 2/3] i3c: add mixed limited bus mode

2019-06-19 Thread Vitor Soares
The i3c bus spec defines a bus configuration where i2c devices don't have a 50ns filter but support SCL running at SDR max rate (12.5MHz). This patch introduces the limited bus mode so that users can use a higher speed in presence of i2c devices index 1. Signed-off-by: Vitor Soares Cc:

[PATCH v4 3/3] i3c: dw: add limited bus mode support

2019-06-19 Thread Vitor Soares
This patch add limited bus mode support for DesignWare i3c master Signed-off-by: Vitor Soares Cc: Boris Brezillon Cc: --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/i3c/master/dw-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c

RE: [PATCH v3 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-12 Thread Vitor Soares
From: Boris Brezillon Date: Wed, Jun 12, 2019 at 12:37:27 > On Wed, 12 Jun 2019 11:16:34 + > Vitor Soares wrote: > > > From: Boris Brezillon > > Date: Wed, Jun 12, 2019 at 07:15:33 > > > > > On Tue, 11 Jun 2019 16:06:43 +0200 > > > Vitor Soar

RE: [PATCH v3 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-12 Thread Vitor Soares
From: Boris Brezillon Date: Wed, Jun 12, 2019 at 07:15:33 > On Tue, 11 Jun 2019 16:06:43 +0200 > Vitor Soares wrote: > > > Currently the I3C framework limits SCL frequency to FM speed when > > dealing with a mixed slow bus, even if all I2C devices are FM+ capable. >

[PATCH v3 2/3] i3c: add mixed limited bus mode

2019-06-11 Thread Vitor Soares
The i3c bus spec defines a bus configuration where i2c devices don't have a 50ns filter but support SCL running at SDR max rate (12.5MHz). This patch introduces the limited bus mode so that users can use a higher speed in presence of i2c devices index 1. Signed-off-by: Vitor Soares Cc:

[PATCH v3 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-11 Thread Vitor Soares
operating in mixed fast mode. Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Signed-off-by: Vitor Soares Cc: Boris Brezillon Cc: Cc: --- Changes in v3: Change dev_warn() to dev_dbg() Changes in v2: Enhance commit message Add dev_warn() in case user-defined i2c rate doe

[PATCH v3 3/3] i3c: dw: add limited bus mode support

2019-06-11 Thread Vitor Soares
This patch add limited bus mode support for DesignWare i3c master Signed-off-by: Vitor Soares Cc: Boris Brezillon Cc: --- Changes in v3: None Changes in v2: None drivers/i3c/master/dw-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/dw-i3c-master.c b

RE: [PATCH v2 0/3] Add ST lsm6dso i3c support

2019-06-11 Thread Vitor Soares
Hi, Since the regmap-i3c.c was already applied in: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git tags/regmap-i3c I wonder what is clean way to submit this patch set? And since the i3c-regmap was merge in From: Vitor Soares Date: Thu, Jun 06, 2019 at 16:12:01 > T

RE: [PATCH v2 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-06 Thread Vitor Soares
From: Boris Brezillon Date: Thu, Jun 06, 2019 at 18:35:40 > On Thu, 6 Jun 2019 17:16:55 + > Vitor Soares wrote: > > > From: Boris Brezillon > > Date: Thu, Jun 06, 2019 at 15:18:44 > > > > > On Thu, 6 Jun 2019 16:00:01 +0200 > > > Vitor Soar

RE: [PATCH v2 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-06 Thread Vitor Soares
From: Boris Brezillon Date: Thu, Jun 06, 2019 at 15:18:44 > On Thu, 6 Jun 2019 16:00:01 +0200 > Vitor Soares wrote: > > > Currently the I3C framework limits SCL frequency to FM speed when > > dealing with a mixed slow bus, even if all I2C devices are FM+ capable. >

RE: [PATCH v2 2/3] i3c: add i3c_get_device_id helper

2019-06-06 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Thu, Jun 06, 2019 at 16:17:55 > On Thu, 6 Jun 2019 17:12:03 +0200 > Vitor Soares wrote: > > > This helper return the i3c_device_id structure in order the client > > have access to the driver data. > > > > Signed-off-by:

RE: [PATCH v2 0/3] Add ST lsm6dso i3c support

2019-06-06 Thread Vitor Soares
Hi Wolfram, I think I2C ecosystem is also part interested in I3C due the compatibility and maybe they can provide some feedback. If you think differently, sorry I will remove I2C list next time. Regards, Vitor Soares From: Wolfram Sang Date: Thu, Jun 06, 2019 at 17:25:23 > On Thu, Jun

[PATCH v2 1/3] regmap: add i3c bus support

2019-06-06 Thread Vitor Soares
Add basic support for i3c bus. This is a simple implementation that only give support for SDR Read and Write commands. Signed-off-by: Vitor Soares --- Changes in v2: None drivers/base/regmap/Kconfig | 6 +++- drivers/base/regmap/Makefile | 1 + drivers/base/regmap/regmap-i3c.c

[PATCH v2 0/3] Add ST lsm6dso i3c support

2019-06-06 Thread Vitor Soares
i3c_get_device_id() to drivers/i3c/device.c Add support for LSM6DSR Vitor Soares (3): regmap: add i3c bus support i3c: Add i3c_get_device_id helper iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR drivers/base/regmap/Kconfig | 6 ++- drivers/base/regmap

[PATCH v2 2/3] i3c: add i3c_get_device_id helper

2019-06-06 Thread Vitor Soares
This helper return the i3c_device_id structure in order the client have access to the driver data. Signed-off-by: Vitor Soares --- Changes in v2: move this function to drivers/i3c/device.c drivers/i3c/device.c | 8 include/linux/i3c/device.h | 1 + 2 files changed, 9

[PATCH v2 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

2019-06-06 Thread Vitor Soares
For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in spi and i2c mode. The LSM6DSO and LSM6DSR are also i3c capable so lets give i3c support to them. Signed-off-by: Vitor Soares --- Changes in v2: Add support for LSM6DSR Set pm_ops to st_lsm6dsx_pm_ops drivers/iio

[PATCH v2 2/3] i3c: add mixed limited bus mode

2019-06-06 Thread Vitor Soares
The i3c bus spec defines a bus configuration where i2c devices don't have a 50ns filter but support SCL running at SDR max rate (12.5MHz). This patch introduces the limited bus mode so that users can use a higher speed in presence of i2c devices index 1. Signed-off-by: Vitor Soares Cc:

[PATCH v2 3/3] i3c: dw: add limited bus mode support

2019-06-06 Thread Vitor Soares
This patch add limited bus mode support for DesignWare i3c master Signed-off-by: Vitor Soares Cc: Boris Brezillon Cc: --- Changes in v2: None drivers/i3c/master/dw-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw

[PATCH v2 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-06-06 Thread Vitor Soares
operating in mixed fast mode. Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Signed-off-by: Vitor Soares Cc: Boris Brezillon Cc: Cc: --- Changes in v2: Enhance commit message Add dev_warn() in case user-defined i2c rate doesn't match LVR constraint Add dev_warn

RE: [PATCH 1/3] remap: Add I3C bus support

2019-04-23 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Tue, Apr 23, 2019 at 16:14:16 > On Tue, 23 Apr 2019 14:58:06 + > Vitor Soares wrote: > > > Hi Mark, > > > > From: Mark Brown > > Date: Tue, Apr 16, 2019 at 16:39:48 > > > > > On Mon, Apr

RE: [PATCH 1/3] remap: Add I3C bus support

2019-04-23 Thread Vitor Soares
Hi Mark, From: Mark Brown Date: Tue, Apr 16, 2019 at 16:39:48 > On Mon, Apr 15, 2019 at 09:19:39PM +0200, Vitor Soares wrote: > > > +++ b/drivers/base/regmap/regmap-i3c.c > > @@ -0,0 +1,62 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyrigh

RE: [PATCH 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-04-22 Thread Vitor Soares
From: Boris Brezillon Date: Mon, Apr 22, 2019 at 19:27:32 > On Mon, 22 Apr 2019 17:54:29 + > Vitor Soares wrote: > > > > > > > > > > > > > > > > { > > > > > > > > i3cbus->

RE: [PATCH 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-04-22 Thread Vitor Soares
From: Boris Brezillon Date: Mon, Apr 22, 2019 at 17:07:15 > On Mon, 22 Apr 2019 15:54:33 + > Vitor Soares wrote: > > > > > > > > > > > > > { > > > > > > i3cbus->mode = mode; > > > > > > >

RE: [PATCH 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-04-22 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Tue, Apr 16, 2019 at 15:52:50 > On Tue, 16 Apr 2019 14:24:57 + > Vitor Soares wrote: > > > Hi Boris, > > > > From: Boris Brezillon > > Date: Tue, Apr 16, 2019 at 06:50:41 > > > > > On Mon, 15 A

RE: [PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support

2019-04-16 Thread Vitor Soares
, > > + .id_table = st_lsm6dsx_i3c_ids, > > You should probably set the pm_ops here (st_lsm6dsx_pm_ops). Yes, I missed that. > > > +}; > > +module_i3c_driver(st_lsm6dsx_driver); > > + > > +MODULE_AUTHOR("Vitor Soares "); > &g

RE: [PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support

2019-04-16 Thread Vitor Soares
Hi Boris and Lorenzo, From: Boris Brezillon Date: Tue, Apr 16, 2019 at 09:05:40 > On Tue, 16 Apr 2019 09:58:33 +0200 > Lorenzo Bianconi wrote: > > > > > > > On Mon, 15 Apr 2019 21:19:41 +0200 > > > Vitor Soares wrote: > > > > > > &g

RE: [PATCH 2/3] i3c: Add i3c_get_device_id helper

2019-04-16 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Tue, Apr 16, 2019 at 07:18:25 > On Mon, 15 Apr 2019 21:19:40 +0200 > Vitor Soares wrote: > > > This helper return the i3c_device_id structure in order the client > > have access to the driver data. > > >

RE: [PATCH 1/3] remap: Add I3C bus support

2019-04-16 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Tue, Apr 16, 2019 at 07:15:51 > Typo in the subject: s/remap/regmap/ > > On Mon, 15 Apr 2019 21:19:39 +0200 > Vitor Soares wrote: > > > Add basic support for I3C bus. > > This is a simple implementation that only give sup

RE: [PATCH 2/3] i3c: add mixed limited bus mode

2019-04-16 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Tue, Apr 16, 2019 at 07:00:49 > Hi Vitor, > > On Mon, 15 Apr 2019 20:46:42 +0200 > Vitor Soares wrote: > > > The i3c bus spec define a bus configuration where the i2c devices > > ^defines

RE: [PATCH 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-04-16 Thread Vitor Soares
Hi Boris, From: Boris Brezillon Date: Tue, Apr 16, 2019 at 06:50:41 > On Mon, 15 Apr 2019 20:46:41 +0200 > Vitor Soares wrote: > > > Currently in case of mixed slow bus topologie and all i2c devices > > support FM+ speed, the i3c subsystem limite the SCL to FM speed.

[PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support

2019-04-15 Thread Vitor Soares
For today the st_lsm6dsx driver support lsm6dso sensor only in spi and i2c mode. The lsm6dso is also i3c capable so lets give i3c support to it. Signed-off-by: Vitor Soares --- drivers/iio/imu/st_lsm6dsx/Kconfig | 8 +++- drivers/iio/imu/st_lsm6dsx/Makefile | 1 + drivers

[PATCH 1/3] remap: Add I3C bus support

2019-04-15 Thread Vitor Soares
Add basic support for I3C bus. This is a simple implementation that only give support for Read and Write commands. Signed-off-by: Vitor Soares --- drivers/base/regmap/Kconfig | 6 +++- drivers/base/regmap/Makefile | 1 + drivers/base/regmap/regmap-i3c.c | 62

[PATCH 2/3] i3c: Add i3c_get_device_id helper

2019-04-15 Thread Vitor Soares
This helper return the i3c_device_id structure in order the client have access to the driver data. Signed-off-by: Vitor Soares --- drivers/i3c/device.c | 8 include/linux/i3c/device.h | 1 + 2 files changed, 9 insertions(+) diff --git a/drivers/i3c/device.c b/drivers/i3c

[PATCH 0/3] Add ST lsm6dso i3c suppport

2019-04-15 Thread Vitor Soares
Vitor Soares (3): remap: Add i3c bus support i3c: Add i3c_get_device_id helper iio: imu: st_lsm6dsx: Add i3c basic support drivers/base/regmap/Kconfig | 6 ++- drivers/base/regmap/Makefile| 1 + drivers/base/regmap/regmap-i3c.c| 62

[PATCH 3/3] i3c: dw: Add limited bus mode support

2019-04-15 Thread Vitor Soares
This patch add limited bus mode support for DesignWare i3c master Signed-off-by: Vitor Soares Cc: Boris Brezillon Cc: --- drivers/i3c/master/dw-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index

[PATCH 2/3] i3c: add mixed limited bus mode

2019-04-15 Thread Vitor Soares
The i3c bus spec define a bus configuration where the i2c devices doesn't have the 50ns filter yet they allow the SDR max speed. This patch introduce the limited bus mode so the users can use a higher speed on presence of i2c devices index 1. Signed-off-by: Vitor Soares Cc: Boris Brezillo

[PATCH 1/3] i3c: fix i2c and i3c scl rate by bus mode

2019-04-15 Thread Vitor Soares
topologie and LVR[4] if no user input. In case of mixed slow mode the i3c scl rate is overridden. Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Signed-off-by: Vitor Soares Cc: Boris Brezillon Cc: Cc: --- drivers/i3c/master.c | 39 +-- 1 fi

RE: [PATCH] reset: axs10x: Implement assert and deassert callbacks

2019-04-12 Thread Vitor Soares
Hi Eugeniy, From: Eugeniy Paltsev Date: Fri, Apr 12, 2019 at 14:22:33 > Hi Vitor, > > On Mon, 2019-04-08 at 13:25 +0000, Vitor Soares wrote: > > Hi Eugeniy, > > > > From: Eugeniy Paltsev > > Date: Mon, Apr 08, 2019 at 12:40:00 > > > > > Hi

RE: [PATCH] reset: axs10x: Implement assert and deassert callbacks

2019-04-08 Thread Vitor Soares
Hi Eugeniy, From: Eugeniy Paltsev Date: Mon, Apr 08, 2019 at 12:40:00 > Hi Vitor, > > On Mon, 2019-04-08 at 12:31 +0200, Vitor Soares wrote: > > Some custom IP-block connected to ARC AXS10x board need assert and > > deassert functions to control reset signal of

[PATCH] reset: axs10x: Implement assert and deassert callbacks

2019-04-08 Thread Vitor Soares
Some custom IP-block connected to ARC AXS10x board need assert and deassert functions to control reset signal of selected peripherals. This patch improve AXS10x reset driver by adding assert and deassert callbacks. Signed-off-by: Vitor Soares Cc: Eugeniy Paltsev Cc: Alexey Brodkin Cc: Joao

[PATCH 3/7] i3c: master: dw: remove dead code from dw_i3c_master_*_xfers()

2019-03-06 Thread Vitor Soares
values of its operands. This occurs as the logical operand of "if" Signed-off-by: Vitor Soares --- drivers/i3c/master/dw-i3c-master.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index bb03079..

[PATCH v3 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-11-08 Thread Vitor soares
Add driver for Synopsys DesignWare I3C master IP Signed-off-by: Vitor soares --- Change in v3: - Use struct_size() (suggested by Matthew) Change in v2: - Rename some variables - Remove dw_i3c_master_dev_set_info() - Ajust code to match the changes made of i3c subsystem - Use readsl/writesl() to

Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP

2018-07-25 Thread Vitor Soares
Hi Andy, Às 4:35 PM de 7/21/2018, Andy Shevchenko escreveu: > On Fri, Jul 20, 2018 at 11:57 PM, Vitor soares > wrote: >> This patch add driver for Synopsys DesignWare IP on top of >> I3C subsystem patchset proposal V6 > Some of comments below related to style. > But unal

  1   2   >