[PATCH v8 3/5] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-03-02 Thread Vivek Gautam
runtime calls] Signed-off-by: Vivek Gautam --- drivers/iommu/arm-smmu.c | 96 1 file changed, 88 insertions(+), 8 deletions(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index c8b16f53f597..3d6a1875431f 100644 --- a/drivers/iommu

Re: [Freedreno] [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-23 Thread Vivek Gautam
On Fri, Feb 23, 2018 at 9:10 PM, Jordan Crouse wrote: > On Fri, Feb 23, 2018 at 04:06:39PM +0530, Vivek Gautam wrote: >> On Fri, Feb 23, 2018 at 5:22 AM, Jordan Crouse >> wrote: >> > On Wed, Feb 07, 2018 at 04:01:19PM +0530, Vivek Gautam wrote: >> >> Fro

Re: [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-23 Thread Vivek Gautam
On Fri, Feb 23, 2018 at 5:22 AM, Jordan Crouse wrote: > On Wed, Feb 07, 2018 at 04:01:19PM +0530, Vivek Gautam wrote: >> From: Sricharan R >> >> The smmu device probe/remove and add/remove master device callbacks >> gets called when the smmu is not linked to its mas

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-22 Thread Vivek Gautam
Hi, On Thu, Feb 22, 2018 at 7:42 PM, Tomasz Figa wrote: > On Thu, Feb 22, 2018 at 10:45 PM, Robin Murphy wrote: >> [sorry, I had intended to reply sooner but clearly forgot] >> >> >> On 16/02/18 00:13, Tomasz Figa wrote: >>> >>> On Fri, Feb 16, 2018 at 2:14 AM, Robin Murphy >>> wrote:

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-14 Thread Vivek Gautam
On Wed, Feb 14, 2018 at 2:46 PM, Tomasz Figa wrote: Adding Jordan to this thread as well. > On Wed, Feb 14, 2018 at 6:13 PM, Vivek Gautam > wrote: >> Hi Tomasz, >> >> On Wed, Feb 14, 2018 at 11:08 AM, Tomasz Figa wrote: >>> On Wed, Feb 14, 2018 at 1:17 PM,

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

2018-02-14 Thread Vivek Gautam
On 1/24/2018 7:19 PM, Robin Murphy wrote: On 24/01/18 10:35, Jeffy Chen wrote: From: Tomasz Figa Current code relies on master driver enabling necessary clocks before IOMMU is accessed, however there are cases when the IOMMU should be accessed while the master is not running yet, for example

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-14 Thread Vivek Gautam
Hi Tomasz, On Wed, Feb 14, 2018 at 11:08 AM, Tomasz Figa wrote: > On Wed, Feb 14, 2018 at 1:17 PM, Vivek Gautam > wrote: >> Hi Tomasz, >> >> On Wed, Feb 14, 2018 at 8:31 AM, Tomasz Figa wrote: >>> On Wed, Feb 14, 2018 at 11:13 AM, Rob Clark wrote: >>>

Re: [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-14 Thread Vivek Gautam
Hi Tomasz, On Tue, Feb 13, 2018 at 1:54 PM, Tomasz Figa wrote: > Hi Vivek, > > Thanks for the patch. Please see my comments inline. > > On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam > wrote: >> From: Sricharan R >> >> The smmu device probe/remove and add/re

Re: [PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-14 Thread Vivek Gautam
On Tue, Feb 13, 2018 at 7:22 PM, Tomasz Figa wrote: > On Tue, Feb 13, 2018 at 9:57 PM, Robin Murphy wrote: >> On 13/02/18 08:24, Tomasz Figa wrote: >>> >>> Hi Vivek, >>> >>> Thanks for the patch. Please see my comments inline. >>> >&

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-13 Thread Vivek Gautam
, Tomasz Figa wrote: >>>>> Hi Vivek, >>>>> >>>>> Thanks for the patch. Please see my comments inline. >>>>> >>>>> On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam >>>>> wrote: >>>>>> While

Re: [PATCH v7 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-02-13 Thread Vivek Gautam
Hi Tomasz, Please find my response inline below. On Tue, Feb 13, 2018 at 1:33 PM, Tomasz Figa wrote: > Hi Vivek, > > Thanks for the patch. Please see some comments inline. > > On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam > wrote: >> From: Sricharan R >> >

Re: [PATCH v7 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

2018-02-13 Thread Vivek Gautam
Hi Tomasz, On Tue, Feb 13, 2018 at 2:01 PM, Tomasz Figa wrote: > Hi Vivek, > > Thanks for the patch. Please see my comments inline. Thanks for reviewing the patch series. > > On Wed, Feb 7, 2018 at 7:31 PM, Vivek Gautam > wrote: >> From: Sricharan R >> >>

[PATCH v8 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant

2018-02-09 Thread Vivek Gautam
qcom,smmu-v2 is an arm,smmu-v2 implementation with specific clock and power requirements. This smmu core is used with multiple masters on msm8996, viz. mdss, video, etc. Add bindings for the same. Signed-off-by: Vivek Gautam Reviewed-by: Rob Herring --- Changes in v8: - Added the missing

[PATCH v7 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

2018-02-07 Thread Vivek Gautam
-off-by: Vivek Gautam --- drivers/iommu/arm-smmu.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index c024f69c1682..c7e924d553bd 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -215,6 +215,9

[PATCH v7 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant

2018-02-07 Thread Vivek Gautam
qcom,smmu-v2 is an arm,smmu-v2 implementation with specific clock and power requirements. This smmu core is used with multiple masters on msm8996, viz. mdss, video, etc. Add bindings for the same. Signed-off-by: Vivek Gautam Reviewed-by: Rob Herring --- .../devicetree/bindings/iommu/arm

[PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-07 Thread Vivek Gautam
() calls, to power-up the connected iommu through the device link interface. In case the device link is not setup these get/put_suppliers() calls will be a no-op, and the iommu driver should take care of powering on its devices accordingly. Signed-off-by: Vivek Gautam --- drivers/gpu/drm/msm

[PATCH v7 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-07 Thread Vivek Gautam
runtime calls] Signed-off-by: Vivek Gautam --- drivers/iommu/arm-smmu.c | 42 ++ 1 file changed, 38 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 9e2f917e16c2..c024f69c1682 100644 --- a/drivers/iommu/arm

[PATCH v7 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-02-07 Thread Vivek Gautam
bulk of clocks] Signed-off-by: Vivek Gautam --- drivers/iommu/arm-smmu.c | 56 ++-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 69e7c60792a8..9e2f917e16c2 100644 --- a/drivers/

[PATCH v7 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-02-07 Thread Vivek Gautam
https://patchwork.kernel.org/patch/9827825/ Signed-off-by: Vivek Gautam Acked-by: Rafael J. Wysocki --- drivers/base/power/runtime.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index 8bef3cb2424d..5b8226c8af19 100644 --- a/drivers

[PATCH v7 0/6] iommu/arm-smmu: Add runtime pm/sleep support

2018-02-07 Thread Vivek Gautam
atch/10102445/ [5] https://lkml.org/lkml/2018/1/19/217 Sricharan R (3): iommu/arm-smmu: Add pm_runtime/sleep ops iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam (3): base: power: runtime: Export pm_r

Re: [PATCH RFC 1/1] iommu/arm-smmu: Fix context fault message considering non-NTS

2018-02-06 Thread Vivek Gautam
Hi Robin, On Tue, Feb 6, 2018 at 5:22 PM, Robin Murphy wrote: > Hi Vivek, > > On 06/02/18 10:16, Vivek Gautam wrote: >> >> SMMU_CBn_FSYNR0 definition from SMMU v2 architecture document >> says that, the S1CBNDX[23:16] field is only valid if SMMU_IDR0.NTS==1. >>

[PATCH RFC 1/1] iommu/arm-smmu: Fix context fault message considering non-NTS

2018-02-06 Thread Vivek Gautam
his patch - arm-smmu 1500.apps-smmu: Unhandled context fault: fsr=0x402, iova=0x9e0aa000, fsynr=0x20, cb=0 Signed-off-by: Vivek Gautam Cc: Robin Murphy --- Hi Robin, Does it make sense to mask fsynr like this? Would it still be confusing for CB==0? Tagging the patch as RFC

Re: [PATCH 1/1] iommu/io-pgtable: use size_t return type for all foo_unmap

2018-02-05 Thread Vivek Gautam
Hi Robin, On 2/5/2018 11:38 PM, Robin Murphy wrote: On 05/02/18 17:59, Vivek Gautam wrote: Unmap returns a size_t all throughout the IOMMU framework. Make io-pgtable match this convention. Moreover, there isn't a need to have a signed int return type as we return 0 in case of failures.

[PATCH 1/1] iommu/io-pgtable: use size_t return type for all foo_unmap

2018-02-05 Thread Vivek Gautam
Unmap returns a size_t all throughout the IOMMU framework. Make io-pgtable match this convention. Moreover, there isn't a need to have a signed int return type as we return 0 in case of failures. Signed-off-by: Vivek Gautam --- drivers/iommu/io-pgtable-arm-v7s.c

Re: [PATCH v6 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-02-01 Thread Vivek Gautam
On 2/1/2018 5:03 PM, Sricharan R wrote: Hi Robin, On 1/31/2018 6:36 PM, Robin Murphy wrote: On 19/01/18 11:43, Vivek Gautam wrote: From: Sricharan R The smmu device probe/remove and add/remove master device callbacks gets called when the smmu is not linked to its master, that is without

Re: [PATCH v6 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

2018-02-01 Thread Vivek Gautam
Hi, On 1/31/2018 6:39 PM, Robin Murphy wrote: On 19/01/18 11:43, Vivek Gautam wrote: From: Sricharan R Finally add the device link between the master device and smmu, so that the smmu gets runtime enabled/disabled only when the master needs it. This is done from add_device callback which

Re: [PATCH v6 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-01-31 Thread Vivek Gautam
On 1/31/2018 5:53 PM, Robin Murphy wrote: On 19/01/18 11:43, Vivek Gautam wrote: From: Sricharan R The smmu needs to be functional only when the respective master's using it are active. The device_link feature helps to track such functional dependencies, so that the iommu gets powered

Re: [PATCH v6 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant

2018-01-31 Thread Vivek Gautam
On 1/30/2018 1:12 AM, Rob Herring wrote: On Fri, Jan 19, 2018 at 05:13:42PM +0530, Vivek Gautam wrote: qcom,smmu-v2 is an arm,smmu-v2 implementation with specific clock and power requirements. This smmu core is used with multiple masters on msm8996, viz. mdss, video, etc. Add bindings for the

Re: [PATCH 1/1] scsi: ufs-qcom: remove broken hci version quirk

2018-01-29 Thread Vivek Gautam
Hi Asutosh, On 1/30/2018 10:11 AM, Asutosh Das wrote: From: Subhash Jadavani UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host controller version 2.x.y and this has been fixed from version 3.x.y onwards, hence this change removes this quirk for version 3.x.y onwards. S

[PATCH v6 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-01-19 Thread Vivek Gautam
() calls, to power-up the connected iommu through the device link interface. In case the device link is not setup these get/put_suppliers() calls will be a no-op, and the iommu driver should take care of powering on its devices accordingly. Signed-off-by: Vivek Gautam --- drivers/gpu/drm/msm

[PATCH v6 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant

2018-01-19 Thread Vivek Gautam
qcom,smmu-v2 is an arm,smmu-v2 implementation with specific clock and power requirements. This smmu core is used with multiple masters on msm8996, viz. mdss, video, etc. Add bindings for the same. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/iommu/arm,smmu.txt | 43

[PATCH v6 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-01-19 Thread Vivek Gautam
bulk of clocks] Signed-off-by: Vivek Gautam --- drivers/iommu/arm-smmu.c | 55 ++-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 78d4c6b8f1ba..21acffe91a1c 100644 --- a/drivers/

[PATCH v6 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-01-19 Thread Vivek Gautam
runtime calls] Signed-off-by: Vivek Gautam --- drivers/iommu/arm-smmu.c | 45 + 1 file changed, 41 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 21acffe91a1c..95478bfb182c 100644 --- a/drivers/iommu/arm

[PATCH v6 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-01-19 Thread Vivek Gautam
https://patchwork.kernel.org/patch/9827825/ Signed-off-by: Vivek Gautam Acked-by: Rafael J. Wysocki --- drivers/base/power/runtime.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index 6e89b51ea3d9..06a2a88fe866 100644 --- a/drivers

[PATCH v6 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

2018-01-19 Thread Vivek Gautam
From: Sricharan R Finally add the device link between the master device and smmu, so that the smmu gets runtime enabled/disabled only when the master needs it. This is done from add_device callback which gets called once when the master is added to the smmu. Signed-off-by: Sricharan R --- driv

[PATCH v6 0/6] iommu/arm-smmu: Add runtime pm/sleep support

2018-01-19 Thread Vivek Gautam
Invoke pm_runtime during probe, add/remove device iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam (3): base: power: runtime: Export pm_runtime_get/put_suppliers iommu/arm-smmu: Add support for qcom,smmu-v2 variant drm/msm: iommu: Replace runtime calls with runtime s

Re: [PATCH v4 09/16] phy: qcom-qusb2: Add support for QUSB2 V2 version

2018-01-12 Thread Vivek Gautam
TRL2 0x224 > +#defineQUSB2PHY_CHG_CTRL2 0x23c nit: Replace these tabs with simple spaces. Rest all look good. Reviewed-by: Vivek Gautam Thanks Vivek > + > struct qusb2_phy_init_tbl { > unsigned int offset; > un

Re: [PATCH v4 07/16] phy: qcom-qusb2: Add support for different register layouts

2018-01-12 Thread Vivek Gautam
On Wed, Jan 3, 2018 at 4:58 PM, Manu Gautam wrote: > New version of QUSB2 PHY has some registers offset changed. > Add support to have register layout for a target and update > the same in phy_configuration. > > Signed-off-by: Manu Gautam > --- LGTM. Reviewed-by: Vivek Gauta

Re: [PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2018-01-12 Thread Vivek Gautam
On Fri, Jan 12, 2018 at 2:16 PM, Manu Gautam wrote: > Hi Vivek, > > > On 1/12/2018 2:14 PM, Vivek Gautam wrote: >> On Wed, Jan 3, 2018 at 4:58 PM, Manu Gautam wrote: >>> PHY block or asynchronous reset requires signal >>> to be asserted before de-asserting. Dr

Re: [PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence

2018-01-12 Thread Vivek Gautam
t_list[i]); > + goto err_rst_assert; > + } > } > > - for (i = 0; i < cfg->num_resets; i++) { > + for (i = cfg->num_resets - 1; i >= 0; i--) { Do we a dependency on the order in which these resets are applied? If

Re: [PATCH v4 04/16] phy: qcom-qusb2: Power-on PHY before initialization

2018-01-12 Thread Vivek Gautam
on and init for QUSB2 PHY > need to be executed together always, hence remove > poweron callback from phy_ops and explicitly perform > this from init, similar changes needed for poweroff. > > Signed-off-by: Manu Gautam > --- Looks good. Reviewed-by: Vivek Gautam Thanks Vivek

Re: [PATCH v4 03/16] phy: qcom-qmp: Power-on PHY before initialization

2018-01-12 Thread Vivek Gautam
On Wed, Jan 3, 2018 at 4:58 PM, Manu Gautam wrote: > PHY regulators which are enabled from power_on() must be ON > before turning-on clocks and initializing it as part of init(). > As most of the core drivers perform power_on() after init(), move > PHY regulators enable to com_init() and use power

Re: [PATCH v4 10/16] phy: qcom-qmp: Move register offsets to header file

2018-01-11 Thread Vivek Gautam
Hi Manu, On Wed, Jan 3, 2018 at 4:58 PM, Manu Gautam wrote: > New revision (v3) of QMP PHY uses different offsets > for almost all of the registers. Hence, move these > definitions to header file so that updated offsets > can be added for QMP v3. > > Signed-off-by: Manu Gautam > --- > drivers/p

Re: [PATCH v5 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-01-11 Thread Vivek Gautam
On 01/12/2018 04:23 AM, Rafael J. Wysocki wrote: On Tue, Jan 9, 2018 at 11:01 AM, Vivek Gautam wrote: The device link allows the pm framework to tie the supplier and consumer. So, whenever the consumer is powered-on the supplier is powered-on first. There are however cases in which the

Re: [PATCH v5 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant

2018-01-11 Thread Vivek Gautam
Hi Rob, On 01/12/2018 03:53 AM, Rob Herring wrote: On Tue, Jan 09, 2018 at 03:31:48PM +0530, Vivek Gautam wrote: qcom,smmu-v2 is an arm,smmu-v2 implementation with specific clock and power requirements. This smmu core is used with multiple masters on msm8996, viz. mdss, video, etc. Add

Re: [PATCH v5 0/6] iommu/arm-smmu: Add runtime pm/sleep support

2018-01-09 Thread Vivek Gautam
On 01/09/2018 04:53 PM, Rafael J. Wysocki wrote: On Tuesday, January 9, 2018 11:01:43 AM CET Vivek Gautam wrote: This series provides the support for turning on the arm-smmu's clocks/power domains using runtime pm. This is done using the recently introduced device links patches, which

[PATCH v5 0/6] iommu/arm-smmu: Add runtime pm/sleep support

2018-01-09 Thread Vivek Gautam
/patch/9827825/ [5] https://patchwork.kernel.org/patch/10102445/ Sricharan R (3): iommu/arm-smmu: Add pm_runtime/sleep ops iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam (3): base: power: runtime: Ex

[PATCH v5 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-01-09 Thread Vivek Gautam
() calls, to power-up the connected iommu through the device link interface. In case the device link is not setup these get/put_suppliers() calls will be a no-op, and the iommu driver should take care of powering on its devices accordingly. Signed-off-by: Vivek Gautam --- * New patch added in

[PATCH v5 4/6] iommu/arm-smmu: Add the device_link between masters and smmu

2018-01-09 Thread Vivek Gautam
From: Sricharan R Finally add the device link between the master device and smmu, so that the smmu gets runtime enabled/disabled only when the master needs it. This is done from add_device callback which gets called once when the master is added to the smmu. Signed-off-by: Sricharan R --- driv

[PATCH v5 5/6] iommu/arm-smmu: Add support for qcom,smmu-v2 variant

2018-01-09 Thread Vivek Gautam
qcom,smmu-v2 is an arm,smmu-v2 implementation with specific clock and power requirements. This smmu core is used with multiple masters on msm8996, viz. mdss, video, etc. Add bindings for the same. Signed-off-by: Vivek Gautam --- * Major change in this patch - Changed compatible string from

[PATCH v5 2/6] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-01-09 Thread Vivek Gautam
bulk of clocks] Signed-off-by: Vivek Gautam --- drivers/iommu/arm-smmu.c | 55 ++-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 78d4c6b8f1ba..21acffe91a1c 100644 --- a/drivers/

[PATCH v5 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-01-09 Thread Vivek Gautam
runtime calls] Signed-off-by: Vivek Gautam --- drivers/iommu/arm-smmu.c | 45 + 1 file changed, 41 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 21acffe91a1c..95478bfb182c 100644 --- a/drivers/iommu/arm

[PATCH v5 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-01-09 Thread Vivek Gautam
https://patchwork.kernel.org/patch/9827825/ Signed-off-by: Vivek Gautam --- * This is v2 of the patch [1]. Adding it to this patch series. [1] https://patchwork.kernel.org/patch/10102447/ drivers/base/power/runtime.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/power/runtim

Re: [PATCH 1/1] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-01-03 Thread Vivek Gautam
Hi Rafael, On Wed, Jan 3, 2018 at 5:31 PM, Rafael J. Wysocki wrote: > On Friday, December 8, 2017 6:03:37 PM CET Vivek Gautam wrote: >> On Fri, Dec 8, 2017 at 7:37 PM, Rafael J. Wysocki wrote: >> > On Fri, Dec 8, 2017 at 2:39 PM, Vivek Gautam >> > wrote: >> >

Re: [PATCH v3 02/16] phy: qcom-qmp: Adapt to clk_bulk_* APIs

2017-12-19 Thread Vivek Gautam
Hi Manu, On Tue, Nov 21, 2017 at 2:53 PM, Manu Gautam wrote: > From: Vivek Gautam > > Move from using array of clocks to clk_bulk_* APIs that > are available now. > > Signed-off-by: Vivek Gautam > Signed-off-by: Manu Gautam > --- > drivers/phy/q

Re: [PATCH 1/1] base: power: runtime: Export pm_runtime_get/put_suppliers

2017-12-08 Thread Vivek Gautam
On Fri, Dec 8, 2017 at 7:37 PM, Rafael J. Wysocki wrote: > On Fri, Dec 8, 2017 at 2:39 PM, Vivek Gautam > wrote: >> Hi Greg, >> >> >> On Fri, Dec 8, 2017 at 6:51 PM, Greg KH wrote: >>> On Fri, Dec 08, 2017 at 06:00:47PM +0530, Vivek Gautam wrote: >>

Re: [PATCH 1/1] base: power: runtime: Export pm_runtime_get/put_suppliers

2017-12-08 Thread Vivek Gautam
Hi Greg, On Fri, Dec 8, 2017 at 6:51 PM, Greg KH wrote: > On Fri, Dec 08, 2017 at 06:00:47PM +0530, Vivek Gautam wrote: >> The device link allows the pm framework to tie the supplier and >> consumer. So, whenever the consumer is powered-on, the supplier >> is powered-on f

[PATCH 1/1] base: power: runtime: Export pm_runtime_get/put_suppliers

2017-12-08 Thread Vivek Gautam
. [1] https://patchwork.kernel.org/patch/9827825/ Signed-off-by: Vivek Gautam --- drivers/base/power/runtime.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index 027d159ac381..af169304ca13 100644 --- a/drivers/base/power/runtime.c

Re: [PATCH v3 07/16] phy: qcom-qusb2: Add support for different register layouts

2017-12-05 Thread Vivek Gautam
On 11/21/2017 02:53 PM, Manu Gautam wrote: New version of QUSB2 PHY has some registers offset changed. Add support to have register layout for a target and update the same in phy_configuration. Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 131 ++

Re: [PATCH V4 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2017-11-28 Thread Vivek Gautam
On 11/28/2017 05:13 AM, Rob Clark wrote: On Mon, Nov 27, 2017 at 5:22 PM, Stephen Boyd wrote: On 11/15, Vivek Gautam wrote: Hi, On Mon, Aug 7, 2017 at 5:59 PM, Rob Clark wrote: On Mon, Aug 7, 2017 at 4:27 AM, Vivek Gautam wrote: On Thu, Jul 13, 2017 at 5:20 PM, Rob Clark wrote: On

Re: [PATCH V4 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2017-11-14 Thread Vivek Gautam
Hi, On Mon, Aug 7, 2017 at 5:59 PM, Rob Clark wrote: > On Mon, Aug 7, 2017 at 4:27 AM, Vivek Gautam > wrote: >> On Thu, Jul 13, 2017 at 5:20 PM, Rob Clark wrote: >>> On Thu, Jul 13, 2017 at 1:35 AM, Sricharan R >>> wrote: >>>> Hi Vivek, >>&

[PATCH v2 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

2017-10-11 Thread Vivek Gautam
Set the phy mode based on the UFS HS PA mode. This lets the controller let phy know the mode in which the PHY Adapter is running and set the phy rates accordingly. Signed-off-by: Vivek Gautam Reviewed-by: Subhash Jadavani --- Changes since v1: - none. drivers/scsi/ufs/ufs-qcom.c | 3 +++ 1

[PATCH v2 3/5] phy: qcom-ufs: Add support to set phy mode

2017-10-11 Thread Vivek Gautam
Adding support to set desired UFS phy mode that can be set from the host controller. Signed-off-by: Vivek Gautam --- Changes since v1: - none. drivers/phy/qualcomm/phy-qcom-ufs-i.h| 2 ++ drivers/phy/qualcomm/phy-qcom-ufs-qmp-14nm.c | 14 ++ drivers/phy/qualcomm/phy-qcom

[PATCH v2 5/5] ufs/phy: qcom: Refactor to use phy_init call

2017-10-11 Thread Vivek Gautam
Refactor ufs_qcom_power_up_sequence() to get rid of ugly exported phy APIs and use the phy_init() and phy_power_on() to do the phy initialization. Signed-off-by: Vivek Gautam --- Changes since v1: - The UFS phy retain state in low power mode. The phy can enter the low power state and come

[PATCH v2 2/5] phy: Add UFS PHY modes

2017-10-11 Thread Vivek Gautam
UFS phy has two modes for each High speed generation. These modes are identified by two rates of operations - Rate A, and Rate B. Add these UFS phy modes to phy framework. Signed-off-by: Vivek Gautam --- Changes since v1: - Rebased on linux-phy/next. include/linux/phy/phy.h | 2 ++ 1 file

[PATCH v2 1/5] dt-bindings: phy: Add PHY_TYPE_UFS definition

2017-10-11 Thread Vivek Gautam
Add definition for UFS phy type. Signed-off-by: Vivek Gautam --- Changes since v1: - none. include/dt-bindings/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h index 6c901930eb3e..d16e8755f6a9 100644 --- a/include/dt

[PATCH v2 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-10-11 Thread Vivek Gautam
for the last patch if you find it good. [1] https://lkml.org/lkml/2017/8/10/958 Vivek Gautam (5): dt-bindings: phy: Add PHY_TYPE_UFS definition phy: Add UFS PHY modes phy: qcom-ufs: Add support to set phy mode scsi/ufs: qcom: Set phy mode based on the controllers HS MODE ufs/phy: qcom:

Re: [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk

2017-10-09 Thread Vivek Gautam
On 10/08/2017 06:06 PM, Anand Moon wrote: Hi Krzysztof, On 6 October 2017 at 12:08, Krzysztof Kozlowski wrote: On Fri, Oct 6, 2017 at 6:36 AM, Anand Moon wrote: update the usbdrd link control and phy contol clks. The commit title and especially commit message should explain why you are do

Re: [RFC PATCH 1/1] iommu/arm-smmu: Add support for multiple TBU child devices

2017-09-26 Thread Vivek Gautam
Hi Rob, On 09/19/2017 07:40 PM, Rob Herring wrote: Thanks for reviewing the patch. On Tue, Sep 12, 2017 at 05:31:07PM +0530, Vivek Gautam wrote: ARM MMU-500 implements a TBU (uTLB) for each connected master besides a single TCU which controls and manages the address translations. Each of

Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

2017-09-26 Thread Vivek Gautam
On 09/27/2017 04:14 AM, Subhash Jadavani wrote: On 2017-08-03 23:48, Vivek Gautam wrote: Set the phy mode based on the UFS HS PA mode. This lets the controller let phy know the mode in which the PHY Adapter is running and set the phy rates accordingly. Signed-off-by: Vivek Gautam

Re: [PATCH 5/5] ufs/phy: qcom: Refactor to use phy_init call

2017-09-26 Thread Vivek Gautam
Hi Subhash, On Wed, Sep 27, 2017 at 4:43 AM, Subhash Jadavani wrote: > Hi Vivek, > > Please find one comment inline below, rest look good. > > Regards, > Subhash > > > On 2017-08-03 23:48, Vivek Gautam wrote: >> >> Refactor ufs_qcom_power_up_sequence()

[RFC PATCH 1/1] iommu/arm-smmu: Add support for multiple TBU child devices

2017-09-12 Thread Vivek Gautam
long as it's available. When the master is not available, the TBUs are identified with sid and powered on. Signed-off-by: Vivek Gautam --- - The idea behind this patch is to handle the distributed smmu architectures, similar to MMU-500. - Untested yet. - There are still few instances

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-11 Thread Vivek Gautam
On Fri, Aug 11, 2017 at 5:33 AM, Martin K. Petersen wrote: > > Vivek, > >> Can you kindly review this patch series (for UFS controller changes) >> and consider giving your Ack so that Kishon can pull in the series >> through phy tree. > > SCSI piece looks OK. Thank you Martin for your review. > >

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-08 Thread Vivek Gautam
Hi Martin, Subhash On Wed, Aug 9, 2017 at 11:18 AM, Kishon Vijay Abraham I wrote: > Vivek, > > On Tuesday 08 August 2017 09:20 PM, Vivek Gautam wrote: >> Hi Koshon, >> >> On 2017-08-08 17:39, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>>

Re: [PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-08 Thread Vivek Gautam
Hi Koshon, On 2017-08-08 17:39, Kishon Vijay Abraham I wrote: Hi, On Friday 04 August 2017 12:18 PM, Vivek Gautam wrote: Refactoring the qcom-ufs phy and host controller code to move further towards the generic phy usage. Right now the qcom-ufs exports a bunch of APIs that are used by the

Re: [PATCH V4 3/6] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2017-08-07 Thread Vivek Gautam
On Thu, Jul 13, 2017 at 5:20 PM, Rob Clark wrote: > On Thu, Jul 13, 2017 at 1:35 AM, Sricharan R wrote: >> Hi Vivek, >> >> On 7/13/2017 10:43 AM, Vivek Gautam wrote: >>> Hi Stephen, >>> >>> >>> On 07/13/2017 04:24 AM, Stephen Boyd wr

Re: [PATCH] iommu/arm-smmu: Defer TLB flush in case of unmap op

2017-08-07 Thread Vivek Gautam
Hi Robin, On Fri, Aug 4, 2017 at 10:34 PM, Robin Murphy wrote: > On 03/08/17 06:35, Vivek Gautam wrote: >> Hi Robin, >> >> >> >> On 08/02/2017 05:47 PM, Robin Murphy wrote: >>> On 02/08/17 10:53, Vivek Gautam wrote: >>>> We don't want t

[PATCH 1/5] dt-bindings: phy: Add PHY_TYPE_UFS definition

2017-08-03 Thread Vivek Gautam
Add definition for UFS phy type. Signed-off-by: Vivek Gautam --- include/dt-bindings/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h index 6c901930eb3e..d16e8755f6a9 100644 --- a/include/dt-bindings/phy/phy.h +++ b

[PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

2017-08-03 Thread Vivek Gautam
Set the phy mode based on the UFS HS PA mode. This lets the controller let phy know the mode in which the PHY Adapter is running and set the phy rates accordingly. Signed-off-by: Vivek Gautam --- drivers/scsi/ufs/ufs-qcom.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/ufs

[PATCH 3/5] phy: qcom-ufs: Add support to set phy mode

2017-08-03 Thread Vivek Gautam
Adding support to set desired UFS phy mode that can be set from the host controller. Signed-off-by: Vivek Gautam --- drivers/phy/qualcomm/phy-qcom-ufs-i.h| 2 ++ drivers/phy/qualcomm/phy-qcom-ufs-qmp-14nm.c | 14 ++ drivers/phy/qualcomm/phy-qcom-ufs-qmp-20nm.c | 14

[PATCH 5/5] ufs/phy: qcom: Refactor to use phy_init call

2017-08-03 Thread Vivek Gautam
Refactor ufs_qcom_power_up_sequence() to get rid of ugly exported phy APIs and use the phy_init() and phy_power_on() to do the phy initialization. Signed-off-by: Vivek Gautam --- drivers/phy/qualcomm/phy-qcom-ufs-i.h| 2 -- drivers/phy/qualcomm/phy-qcom-ufs-qmp-14nm.c | 9

[PATCH 0/5] qcom-ufs: phy/hcd: Refactor phy initialization code

2017-08-03 Thread Vivek Gautam
phy. Host controller can direct the phy to set the respective configurations based on the phy modes. The patch-series has been tested with necessary dt patches on db820c. Vivek Gautam (5): dt-bindings: phy: Add PHY_TYPE_UFS definition phy: Add UFS PHY modes phy: qcom-ufs: Add support to set

[PATCH 2/5] phy: Add UFS PHY modes

2017-08-03 Thread Vivek Gautam
UFS phy has two modes for each High speed generation. These modes are identified by two rates of operations - Rate A, and Rate B. Add these UFS phy modes to phy framework. Signed-off-by: Vivek Gautam --- include/linux/phy/phy.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux

Re: [PATCH] iommu/arm-smmu: Defer TLB flush in case of unmap op

2017-08-02 Thread Vivek Gautam
Hi Robin, On 08/02/2017 05:47 PM, Robin Murphy wrote: On 02/08/17 10:53, Vivek Gautam wrote: We don't want to touch the TLB when smmu is suspended. Defer it until resume. Signed-off-by: Vivek Gautam --- Hi all, Here's the small patch in response of suggestion to defer tlb opera

[PATCH] iommu/arm-smmu: Defer TLB flush in case of unmap op

2017-08-02 Thread Vivek Gautam
We don't want to touch the TLB when smmu is suspended. Defer it until resume. Signed-off-by: Vivek Gautam --- Hi all, Here's the small patch in response of suggestion to defer tlb operations when smmu is in suspend state. The patch stores the TLB requests in 'unmap' whe

Re: [PATCH] phy: qcom-qmp: Fix failure path in phy_init functions

2017-08-01 Thread Vivek Gautam
On Wed, Aug 2, 2017 at 10:39 AM, Kishon Vijay Abraham I wrote: > Vivek, > > On Monday 31 July 2017 10:58 AM, Vivek Gautam wrote: >> Hi Kishon, >> >> >> On Tue, Jun 20, 2017 at 11:27 AM, Vivek Gautam >> wrote: >>> Fixing the clk enable failure path

[PATCH 4/4] arm64: dts: msm8996: Add device node for qcom,dwc3

2017-07-30 Thread Vivek Gautam
Adding required device node for couple of DWC3 controllers present on msm8996 chipset to enable High speed and Super speed USB support. Signed-off-by: Vivek Gautam --- .../boot/dts/qcom/apq8096-db820c-pmic-pins.dtsi| 24 + arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34

[PATCH 0/4] arm64: dt: msm8996: Enable support for qmp and qusb2 phy, and USB

2017-07-30 Thread Vivek Gautam
/msg29046.html 2) Dt binding fix for pipe clock source: a. https://patchwork.kernel.org/patch/9870865/ b. https://patchwork.kernel.org/patch/9870871/ 3) pmi8994 gpio support: https://lkml.org/lkml/2017/7/28/346 Tested the series on dragonboard db820c target. Vivek Gautam (4): arm64: dts

[PATCH 1/4] arm64: dts: msm8996: Add device node for qcom qusb2 phy

2017-07-30 Thread Vivek Gautam
Adding device node for QUSB2 phy and the required infrastructure to enable support for the same. This phy is used by dwc3 controller present on msm8996. Signed-off-by: Vivek Gautam --- arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 8 + arch/arm64/boot/dts/qcom/msm8996.dtsi| 51

[PATCH 3/4] arm64: dts: msm8996: Add device node for qcom qmp-phy for pcie

2017-07-30 Thread Vivek Gautam
Add required device node for QMP phy based 3-lane PCIe phy present on msm8996 chipset to enable support for the same. Signed-off-by: Vivek Gautam --- arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 4 ++ arch/arm64/boot/dts/qcom/msm8996.dtsi| 62 2 files

[PATCH 2/4] arm64: dts: msm8996: Add device node for qcom qmp-phy for usb

2017-07-30 Thread Vivek Gautam
Adding required device node for USB3 QMP phy present on msm8996 chipset to enable support for the same. This phy provides super speed usb functionality for dwc3 controller on msm8996. Signed-off-by: Vivek Gautam --- arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 4 arch/arm64/boot/dts

Re: [PATCH v5 3/7] phy: qcom-qmp: Fix phy pipe clock name

2017-07-30 Thread Vivek Gautam
* Register the pipe clock provided by phy. -* See function description to see details of this pipe clock. +* Register the pipe clock provided by phy. See function +* description to see details of this pipe clock. Is there some whitespace

Re: [PATCH v5 2/7] dt-bindings: phy: qmp: Add support for QMP phy in IPQ8074

2017-07-30 Thread Vivek Gautam
On 07/31/2017 11:09 AM, Varadarajan Narayanan wrote: IPQ8074 uses QMP phy controller that provides support to PCIe and USB. Adding dt binding information for the same. Signed-off-by: Varadarajan Narayanan --- Reviewed-by: Vivek Gautam Documentation/devicetree/bindings/phy/qcom-qmp

Re: [PATCH] phy: qcom-qmp: Fix failure path in phy_init functions

2017-07-30 Thread Vivek Gautam
Hi Kishon, On Tue, Jun 20, 2017 at 11:27 AM, Vivek Gautam wrote: > Fixing the clk enable failure path in qcom_qmp_phy_init() > and cleanup the reset control deassertion failure path in > qcom_qmp_phy_com_init(). > > Fixes: e78f3d15e115 ("phy: qcom-qmp: new qmp phy driv

[PATCH v2 2/2] arm64: dts: pmi8994: Add device node for pmi8994 gpios

2017-07-28 Thread Vivek Gautam
Signed-off-by: Vivek Gautam --- Changes since v1: - Added "qcom,spmi-gpio" to the compatible. arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.

[PATCH v2 1/2] Documentation: dt: pinctrl: Add pmi8994 gpio support

2017-07-28 Thread Vivek Gautam
Update the binding doc for qcom pmi8994-gpio devices. Signed-off-by: Vivek Gautam --- - Have been testing this patch-set on db820c for extcon with usb controller. The usb controller uses one of these gpios for usb-id/vbus detection. Changes since v1: - Dropped "qcom,pmi8994

Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios

2017-07-27 Thread Vivek Gautam
On Fri, Jul 28, 2017 at 2:30 AM, Stephen Boyd wrote: > On 07/26/2017 11:30 PM, Vivek Gautam wrote: >> Signed-off-by: Vivek Gautam >> --- >> arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 + >> 1 file changed, 17 insertions(+) >> >> diff --git

[PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios

2017-07-26 Thread Vivek Gautam
Signed-off-by: Vivek Gautam --- arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi index d3879a4e8076..3b04ca63c31e 100644 --- a/arch/arm64/boot/dts/qcom

[PATCH 1/2] pinctrl: qcom: spmi-gpio: Add pmi8994 gpio support

2017-07-26 Thread Vivek Gautam
Update the bindings doc and driver for pmi8994-gpio devices. Signed-off-by: Vivek Gautam --- - Have been using this patch-set on db820c [1] for extcon with usb controller. The usb controller uses one of these gpios for usb-id/vbus detection. [1] https://github.com/boddob/linux/tree/for

Re: [PATCH v4 4/7] phy: qcom-qmp: Add support for IPQ8074

2017-07-26 Thread Vivek Gautam
On 07/21/2017 05:06 PM, Varadarajan Narayanan wrote: Add definitions required to enable QMP phy support for IPQ8074. Signed-off-by: smuthayy Signed-off-by: Varadarajan Narayanan --- drivers/phy/qualcomm/phy-qcom-qmp.c | 124 1 file changed, 124 inserti

<    1   2   3   4   5   6   7   8   9   10   >