Domen Puncer wrote:
On 14/03/05 12:35 -0500, Wen Xiong wrote:
Domen Puncer wrote:
Just some nitpicking...
Hi Domen, all,
Thanks for your comments. I did some minor changes for patch1 based on
Domen's comment.
And i missed, what is probably a bug:
+module_param(jsm_debug
Domen Puncer wrote:
Just some nitpicking...
Hi Domen, all,
Thanks for your comments. I did some minor changes for patch1 based on
Domen's comment.
Thanks,
wendy
diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm_driver.c
linux-2.6.11.new/drivers/serial/jsm/jsm_driver.c
---
Domen Puncer wrote:
Just some nitpicking...
Hi Domen, all,
Thanks for your comments. I did some minor changes for patch1 based on
Domen's comment.
Thanks,
wendy
diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm_driver.c
linux-2.6.11.new/drivers/serial/jsm/jsm_driver.c
---
Domen Puncer wrote:
On 14/03/05 12:35 -0500, Wen Xiong wrote:
Domen Puncer wrote:
Just some nitpicking...
Hi Domen, all,
Thanks for your comments. I did some minor changes for patch1 based on
Domen's comment.
And i missed, what is probably a bug:
+module_param(jsm_debug
Arjan van de Ven wrote:
Jeff pointed out several PCI posting errors last time. Before we used
udelay and now we changed to readb/readl instead of udelay this time.
But we only used PCI posting when we think maybe delay there.
So we have to do PCI posting on every writeb?
not every
Do
Arjan van de Ven wrote:
On Fri, 2005-03-11 at 10:38 -0500, Wen Xiong wrote:
+static void neo_set_cts_flow_control(struct jsm_channel *ch)
+{
+ u8 ier = readb(>ch_neo_uart->ier);
+ u8 efr = readb(>ch_neo_uart->efr);
+
...
+
+ writeb(ier, >ch_neo_uart->ier);
+}
This is fifth patch for jsm serial device driver.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.11.org/drivers/serial/Kconfig
linux-2.6.11.new/drivers/serial/Kconfig
--- linux-2.6.11.org/drivers/serial/Kconfig 2005-03-10 16:28:59.552930408
-0600
+++ linux-2.6.
The third patch for jsm device driver.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm_neo.c
linux-2.6.11.new/drivers/serial/jsm/jsm_neo.c
--- linux-2.6.11.org/drivers/serial/jsm/jsm_neo.c 1969-12-31
18:00:00.0 -0600
+++ linux-
The fouth patch for jsm serial device driver.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm.h
linux-2.6.11.new/drivers/serial/jsm/jsm.h
--- linux-2.6.11.org/drivers/serial/jsm/jsm.h 1969-12-31 18:00:00.0
-0600
+++ linux-2.6.
The second patch for new jsm serial device driver.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm_tty.c
linux-2.6.11.new/drivers/serial/jsm/jsm_tty.c
--- linux-2.6.11.org/drivers/serial/jsm/jsm_tty.c 1969-12-31
18:00:00.0
Greg KH wrote:
On Wed, Mar 09, 2005 at 12:18:21PM -0500, Wen Xiong wrote:
Greg KH wrote:
On Wed, Mar 09, 2005 at 10:47:22AM -0500, Wen Xiong wrote:
+static ssize_t jsm_driver_debug_show(struct device_driver *ddp, char
*buf)
+{
+ return snprintf(buf, PAGE_SIZE, "0x%x\n",
Greg KH wrote:
On Wed, Mar 09, 2005 at 12:18:21PM -0500, Wen Xiong wrote:
Greg KH wrote:
On Wed, Mar 09, 2005 at 10:47:22AM -0500, Wen Xiong wrote:
+static ssize_t jsm_driver_debug_show(struct device_driver *ddp, char
*buf)
+{
+ return snprintf(buf, PAGE_SIZE, 0x%x\n, jsm_debug
The second patch for new jsm serial device driver.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm_tty.c
linux-2.6.11.new/drivers/serial/jsm/jsm_tty.c
--- linux-2.6.11.org/drivers/serial/jsm/jsm_tty.c 1969-12-31
18:00:00.0 -0600
The fouth patch for jsm serial device driver.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm.h
linux-2.6.11.new/drivers/serial/jsm/jsm.h
--- linux-2.6.11.org/drivers/serial/jsm/jsm.h 1969-12-31 18:00:00.0
-0600
+++ linux-2.6.11.new/drivers
The third patch for jsm device driver.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm_neo.c
linux-2.6.11.new/drivers/serial/jsm/jsm_neo.c
--- linux-2.6.11.org/drivers/serial/jsm/jsm_neo.c 1969-12-31
18:00:00.0 -0600
+++ linux-2.6.11
This is fifth patch for jsm serial device driver.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.11.org/drivers/serial/Kconfig
linux-2.6.11.new/drivers/serial/Kconfig
--- linux-2.6.11.org/drivers/serial/Kconfig 2005-03-10 16:28:59.552930408
-0600
+++ linux-2.6.11.new/drivers
Arjan van de Ven wrote:
On Fri, 2005-03-11 at 10:38 -0500, Wen Xiong wrote:
+static void neo_set_cts_flow_control(struct jsm_channel *ch)
+{
+ u8 ier = readb(ch-ch_neo_uart-ier);
+ u8 efr = readb(ch-ch_neo_uart-efr);
+
...
+
+ writeb(ier, ch-ch_neo_uart-ier);
+}
Hi,
have you ever
Arjan van de Ven wrote:
Jeff pointed out several PCI posting errors last time. Before we used
udelay and now we changed to readb/readl instead of udelay this time.
But we only used PCI posting when we think maybe delay there.
So we have to do PCI posting on every writeb?
not every
Do
Greg KH wrote:
For the JSM driver, its up to you whether you feel its needed or not.
However, I would like to mention that the DIGI drivers that currently
reside in the kernel sources *do* reserve that ioctl space,
and is acknowledged by "Documentation/ioctl-number.txt":
d' F0-FF
Greg KH wrote:
On Wed, Mar 09, 2005 at 01:35:41PM -0600, Kilau, Scott wrote:
As it stands today, your requirement appears to be that she needs
to yank all diags ioctls and sysfs files before the driver can make
it into the kernel sources.
Not all sysfs files, sysfs files are fine, as long
Greg KH wrote:
On Wed, Mar 09, 2005 at 10:50:04AM -0500, Wen Xiong wrote:
+/* Ioctls needed for dpa operation */
+#define DIGI_GETDD ('d'<<8) | 248 /* get driver info */
+#define DIGI_GETBD ('d'<<8) | 249 /* get board info */
+#define DIGI_GET_NI_INFO ('
Greg KH wrote:
On Wed, Mar 09, 2005 at 10:47:22AM -0500, Wen Xiong wrote:
+static ssize_t jsm_driver_debug_show(struct device_driver *ddp, char *buf)
+{
+ return snprintf(buf, PAGE_SIZE, "0x%x\n", jsm_debug);
+}
+static DRIVER_ATTR(debug, S_IRUSR, jsm_driver_debug_show, NULL);
S
Greg KH wrote:
On Tue, Mar 08, 2005 at 01:42:31PM -0500, Wen Xiong wrote:
The following email I got from Scott Kilau in digi:
Scott Kilau wrote:
The DPA program is very old, and is shared among other drivers
and OS's,
so changing the code to read the sysfs instead of doing ioctls
Greg KH wrote:
On Tue, Mar 08, 2005 at 01:55:33PM -0500, Wen Xiong wrote:
+static ssize_t jsm_driver_boards_show(struct device_driver *ddp, char *buf)
+{
+ int adapter_count = 0;
+ adapter_count = jsm_total_boardnum();
+ return snprintf(buf, PAGE_SIZE, "%d\n", adapter_count);
Greg KH wrote:
On Tue, Mar 08, 2005 at 01:55:33PM -0500, Wen Xiong wrote:
+static ssize_t jsm_driver_boards_show(struct device_driver *ddp, char *buf)
+{
+ int adapter_count = 0;
+ adapter_count = jsm_total_boardnum();
+ return snprintf(buf, PAGE_SIZE, %d\n, adapter_count);
+}
+static
Greg KH wrote:
On Tue, Mar 08, 2005 at 01:42:31PM -0500, Wen Xiong wrote:
The following email I got from Scott Kilau in digi:
Scott Kilau wrote:
The DPA program is very old, and is shared among other drivers
and OS's,
so changing the code to read the sysfs instead of doing ioctls
Greg KH wrote:
On Wed, Mar 09, 2005 at 10:47:22AM -0500, Wen Xiong wrote:
+static ssize_t jsm_driver_debug_show(struct device_driver *ddp, char *buf)
+{
+ return snprintf(buf, PAGE_SIZE, 0x%x\n, jsm_debug);
+}
+static DRIVER_ATTR(debug, S_IRUSR, jsm_driver_debug_show, NULL);
Should just
Greg KH wrote:
On Wed, Mar 09, 2005 at 10:50:04AM -0500, Wen Xiong wrote:
+/* Ioctls needed for dpa operation */
+#define DIGI_GETDD ('d'8) | 248 /* get driver info */
+#define DIGI_GETBD ('d'8) | 249 /* get board info */
+#define DIGI_GET_NI_INFO ('d'8) | 250 /* nonintelligent
Greg KH wrote:
On Wed, Mar 09, 2005 at 01:35:41PM -0600, Kilau, Scott wrote:
As it stands today, your requirement appears to be that she needs
to yank all diags ioctls and sysfs files before the driver can make
it into the kernel sources.
Not all sysfs files, sysfs files are fine, as long
Greg KH wrote:
For the JSM driver, its up to you whether you feel its needed or not.
However, I would like to mention that the DIGI drivers that currently
reside in the kernel sources *do* reserve that ioctl space,
and is acknowledged by Documentation/ioctl-number.txt:
d' F0-FF
Greg KH wrote:
On Mon, Mar 07, 2005 at 05:46:51PM -0500, Wen Xiong wrote:
+static ssize_t jsm_driver_version_show(struct device_driver *ddp, char *buf)
+{
+ return snprintf(buf, PAGE_SIZE, "jsm_version: %s\n", JSM_VERSION);
Again, drop the "prefix:" from every s
Greg KH wrote:
On Mon, Mar 07, 2005 at 05:48:56PM -0500, Wen Xiong wrote:
Since some tools in Digi company need these new ioctls to access device
driver. I still keep these new ioctls.
What tools? What are they used for? Why do they need them? Why can't
they just use the sysfs files
Greg KH wrote:
On Mon, Mar 07, 2005 at 05:48:56PM -0500, Wen Xiong wrote:
Since some tools in Digi company need these new ioctls to access device
driver. I still keep these new ioctls.
What tools? What are they used for? Why do they need them? Why can't
they just use the sysfs files
Greg KH wrote:
On Mon, Mar 07, 2005 at 05:46:51PM -0500, Wen Xiong wrote:
+static ssize_t jsm_driver_version_show(struct device_driver *ddp, char *buf)
+{
+ return snprintf(buf, PAGE_SIZE, jsm_version: %s\n, JSM_VERSION);
Again, drop the prefix: from every sysfs file, it should
Greg KH wrote:
On Fri, Mar 04, 2005 at 04:08:44PM -0500, Wen Xiong wrote:
+/
+ * Structure used with ioctl commands for DIGI parameters.
+ /
+struct
Greg KH wrote:
On Fri, Mar 04, 2005 at 04:08:17PM -0500, Wen Xiong wrote:
+int get_jsm_board_number(void)
+{
+struct list_head *tmp;
+struct jsm_board *cur_board_entry;
+int adapter_count = 0;
+u64 lock_flags;
+
+spin_lock_irqsave(_board_head_lock
Greg KH wrote:
On Fri, Mar 04, 2005 at 04:08:17PM -0500, Wen Xiong wrote:
+int get_jsm_board_number(void)
+{
+struct list_head *tmp;
+struct jsm_board *cur_board_entry;
+int adapter_count = 0;
+u64 lock_flags;
+
+spin_lock_irqsave(jsm_board_head_lock
Greg KH wrote:
On Fri, Mar 04, 2005 at 04:08:44PM -0500, Wen Xiong wrote:
+/
+ * Structure used with ioctl commands for DIGI parameters.
+ /
+struct
Jeff Garzik wrote:
Wen Xiong wrote:
+/* Our "in use" variables, to enforce 1 open only */
+static int jsm_mgmt_in_use[MAXMGMTDEVICES];
Eliminate MAXMGMTDEVICES
+
+/*
+ * jsm_mgmt_open() + *
+ * Open the mgmt/downld/dpa device
+ */ +int jsm_mgmt_open(struct inode *inode, struct
e makefile.
Also please use jsm-y instead of jsm-objs.
Hi Christoph,
Thanks for your comments here!
wendy
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.11.org/drivers/serial/Kconfig
linux-2.6.11.new/drivers/serial/Kconfig
--- linux-2.6.11.org/drivers/serial/Kconfig
Greg KH wrote:
On Sun, Feb 27, 2005 at 06:40:20PM -0500, Wen Xiong wrote:
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/digi.h linux-2.6.9.new/drivers/serial/jsm/digi.h
Oh, and please diff against at least the latest kernel release, 2.6.9 is
old...
+ * $Id: digi.h,v 1.7 2004/09/23 16
Jeff Garzik wrote:
Wen Xiong wrote:
+static inline void neo_set_rts_flow_control(struct channel_t *ch)
+{
+uchar ier = readb(>ch_neo_uart->ier);
+uchar efr = readb(>ch_neo_uart->efr);
Do not invent new types like "ushort" or "uchar".
For situations wher
Greg KH wrote:
On Sun, Feb 27, 2005 at 06:38:44PM -0500, Wen Xiong wrote:
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_tty.c linux-2.6.9.new/drivers/serial/jsm/jsm_tty.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_tty.c 1969-12-31 18:00:00.0 -0600
+++ linux-2.6.9.new/drivers
Greg KH wrote:
On Sun, Feb 27, 2005 at 06:39:51PM -0500, Wen Xiong wrote:
This patch is for jsm_proc.c and includes the functions relating to
/proc/jsm entry.
No, don't add new /proc stuff. Use sysfs, and if you want to spit out
more data, use debugfs.
What is the need for these files
Jeff Garzik wrote:
Wen Xiong wrote:
General comment: This driver has -way- too many global variables.
Normal drivers should associate state information with each instance
of a device (e.g. each struct pci_dev), not globally.
+/*
+ * Globals
+ */
+uintjsm_NumBoards,current_NumBoards
Jeff Garzik wrote:
Wen Xiong wrote:
General comment: This driver has -way- too many global variables.
Normal drivers should associate state information with each instance
of a device (e.g. each struct pci_dev), not globally.
+/*
+ * Globals
+ */
+uintjsm_NumBoards,current_NumBoards
Greg KH wrote:
On Sun, Feb 27, 2005 at 06:39:51PM -0500, Wen Xiong wrote:
This patch is for jsm_proc.c and includes the functions relating to
/proc/jsm entry.
No, don't add new /proc stuff. Use sysfs, and if you want to spit out
more data, use debugfs.
What is the need for these files
Greg KH wrote:
On Sun, Feb 27, 2005 at 06:38:44PM -0500, Wen Xiong wrote:
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_tty.c linux-2.6.9.new/drivers/serial/jsm/jsm_tty.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_tty.c 1969-12-31 18:00:00.0 -0600
+++ linux-2.6.9.new/drivers
Jeff Garzik wrote:
Wen Xiong wrote:
+static inline void neo_set_rts_flow_control(struct channel_t *ch)
+{
+uchar ier = readb(ch-ch_neo_uart-ier);
+uchar efr = readb(ch-ch_neo_uart-efr);
Do not invent new types like ushort or uchar.
For situations where specific size is required, use
Greg KH wrote:
On Sun, Feb 27, 2005 at 06:40:20PM -0500, Wen Xiong wrote:
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/digi.h linux-2.6.9.new/drivers/serial/jsm/digi.h
Oh, and please diff against at least the latest kernel release, 2.6.9 is
old...
+ * $Id: digi.h,v 1.7 2004/09/23 16
three-line makefile.
Also please use jsm-y instead of jsm-objs.
Hi Christoph,
Thanks for your comments here!
wendy
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.11.org/drivers/serial/Kconfig
linux-2.6.11.new/drivers/serial/Kconfig
--- linux-2.6.11.org/drivers/serial/Kconfig
Jeff Garzik wrote:
Wen Xiong wrote:
+/* Our in use variables, to enforce 1 open only */
+static int jsm_mgmt_in_use[MAXMGMTDEVICES];
Eliminate MAXMGMTDEVICES
+
+/*
+ * jsm_mgmt_open() + *
+ * Open the mgmt/downld/dpa device
+ */ +int jsm_mgmt_open(struct inode *inode, struct file *file
This patch includes drivers/serial/Kconfig, drivers/serial/Makefile,
serial_core.h and Makefile for jsm device driver.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.9.orig/drivers/serial/Kconfig
linux-2.6.9.new/drivers/serial/Kconfig
--- linux-2.6.9.orig/drivers/
This patch is all headers for this device driver.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/digi.h
linux-2.6.9.new/drivers/serial/jsm/digi.h
--- linux-2.6.9.orig/drivers/serial/jsm/digi.h 1969-12-31 18:00:00.0
-0600
+++ linux-2.6
This patch is for jsm_mgmt.c. It includes the functions to process
management ports.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_mgmt.c
linux-2.6.9.new/drivers/serial/jsm/jsm_mgmt.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_mgmt.c
This patch is for jsm_proc.c and includes the functions relating to
/proc/jsm entry.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_proc.c
linux-2.6.9.new/drivers/serial/jsm/jsm_proc.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_proc.c
The third patch is for jsm_tty_neo.c and includes all low level
adapter functions.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_neo.c
linux-2.6.9.new/drivers/serial/jsm/jsm_neo.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_neo.c
This second patch is for jsm_tty.c and included all handling TTY layer
functions.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_tty.c
linux-2.6.9.new/drivers/serial/jsm/jsm_tty.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_tty.c 1969
initialization functions for this driver.
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_driver.c
linux-2.6.9.new/drivers/serial/jsm/jsm_driver.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_driver.c1969-12-31
18:00:00.0 -0600
+++
initialization functions for this driver.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_driver.c
linux-2.6.9.new/drivers/serial/jsm/jsm_driver.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_driver.c1969-12-31
18:00:00.0 -0600
+++ linux-2.6.9
This second patch is for jsm_tty.c and included all handling TTY layer
functions.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_tty.c
linux-2.6.9.new/drivers/serial/jsm/jsm_tty.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_tty.c 1969-12-31
The third patch is for jsm_tty_neo.c and includes all low level
adapter functions.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_neo.c
linux-2.6.9.new/drivers/serial/jsm/jsm_neo.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_neo.c 1969-12
This patch is for jsm_proc.c and includes the functions relating to
/proc/jsm entry.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_proc.c
linux-2.6.9.new/drivers/serial/jsm/jsm_proc.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_proc.c 1969-12
This patch is for jsm_mgmt.c. It includes the functions to process
management ports.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_mgmt.c
linux-2.6.9.new/drivers/serial/jsm/jsm_mgmt.c
--- linux-2.6.9.orig/drivers/serial/jsm/jsm_mgmt.c 1969-12
This patch is all headers for this device driver.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/digi.h
linux-2.6.9.new/drivers/serial/jsm/digi.h
--- linux-2.6.9.orig/drivers/serial/jsm/digi.h 1969-12-31 18:00:00.0
-0600
+++ linux-2.6.9.new
This patch includes drivers/serial/Kconfig, drivers/serial/Makefile,
serial_core.h and Makefile for jsm device driver.
Signed-off-by: Wen Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.9.orig/drivers/serial/Kconfig
linux-2.6.9.new/drivers/serial/Kconfig
--- linux-2.6.9.orig/drivers/serial/Kconfig
66 matches
Mail list logo
