Re: page fault deadlock

2013-11-28 Thread Xiaotian Feng
On Fri, Nov 29, 2013 at 3:17 AM, Greg KH wrote: > On Thu, Nov 28, 2013 at 03:28:39PM +0800, Xiaotian Feng wrote: >> On Thu, Nov 28, 2013 at 12:11 PM, Greg KH wrote: >> > On Thu, Nov 28, 2013 at 11:25:32AM +0800, Xiaotian Feng wrote: >> >> Hi, >> >> &g

Re: page fault deadlock

2013-11-28 Thread Xiaotian Feng
On Fri, Nov 29, 2013 at 3:17 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Nov 28, 2013 at 03:28:39PM +0800, Xiaotian Feng wrote: On Thu, Nov 28, 2013 at 12:11 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Nov 28, 2013 at 11:25:32AM +0800, Xiaotian Feng wrote: Hi

Re: page fault deadlock

2013-11-27 Thread Xiaotian Feng
On Thu, Nov 28, 2013 at 12:11 PM, Greg KH wrote: > On Thu, Nov 28, 2013 at 11:25:32AM +0800, Xiaotian Feng wrote: >> Hi, >> >> When I upgrade to latest kernel, I found my system hang there. It >> is reproducible on my virtualbox, and I found each time I mounted my &

Re: page fault deadlock

2013-11-27 Thread Xiaotian Feng
On Thu, Nov 28, 2013 at 12:11 PM, Greg KH wrote: > On Thu, Nov 28, 2013 at 11:25:32AM +0800, Xiaotian Feng wrote: >> Hi, >> >> When I upgrade to latest kernel, I found my system hang there. It >> is reproducible on my virtualbox, and I found each time I mounted my &

page fault deadlock

2013-11-27 Thread Xiaotian Feng
Hi, When I upgrade to latest kernel, I found my system hang there. It is reproducible on my virtualbox, and I found each time I mounted my RAID6 partition and tried to vi or build kernel, my whole system lockup very soon. After turning on lockdep, I found following lockdep warning: [

page fault deadlock

2013-11-27 Thread Xiaotian Feng
Hi, When I upgrade to latest kernel, I found my system hang there. It is reproducible on my virtualbox, and I found each time I mounted my RAID6 partition and tried to vi or build kernel, my whole system lockup very soon. After turning on lockdep, I found following lockdep warning: [

Re: page fault deadlock

2013-11-27 Thread Xiaotian Feng
On Thu, Nov 28, 2013 at 12:11 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Nov 28, 2013 at 11:25:32AM +0800, Xiaotian Feng wrote: Hi, When I upgrade to latest kernel, I found my system hang there. It is reproducible on my virtualbox, and I found each time I mounted my RAID6

Re: page fault deadlock

2013-11-27 Thread Xiaotian Feng
On Thu, Nov 28, 2013 at 12:11 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Nov 28, 2013 at 11:25:32AM +0800, Xiaotian Feng wrote: Hi, When I upgrade to latest kernel, I found my system hang there. It is reproducible on my virtualbox, and I found each time I mounted my RAID6

[tip:sched/core] cpumask: Fix cpumask leak in partition_sched_domains()

2013-08-16 Thread tip-bot for Xiaotian Feng
Commit-ID: c8d2d47a9cbb4222ae4e993aa0e3703430c8193c Gitweb: http://git.kernel.org/tip/c8d2d47a9cbb4222ae4e993aa0e3703430c8193c Author: Xiaotian Feng AuthorDate: Tue, 6 Aug 2013 20:06:42 +0800 Committer: Ingo Molnar CommitDate: Fri, 16 Aug 2013 17:44:27 +0200 cpumask: Fix cpumask leak

[tip:sched/core] cpumask: Fix cpumask leak in partition_sched_domains()

2013-08-16 Thread tip-bot for Xiaotian Feng
Commit-ID: c8d2d47a9cbb4222ae4e993aa0e3703430c8193c Gitweb: http://git.kernel.org/tip/c8d2d47a9cbb4222ae4e993aa0e3703430c8193c Author: Xiaotian Feng xtf...@gmail.com AuthorDate: Tue, 6 Aug 2013 20:06:42 +0800 Committer: Ingo Molnar mi...@kernel.org CommitDate: Fri, 16 Aug 2013 17:44:27

Re: [PATCH] cpumask: fix cpumask leak in partition_sched_domains

2013-08-14 Thread Xiaotian Feng
On Tue, Aug 6, 2013 at 8:06 PM, Xiaotian Feng wrote: > If doms_new is NULL, partition_sched_domains() will reset ndoms_cur > to 0, and free old sched domains with free_sched_domains(doms_cur, ndoms_cur). > As ndoms_cur is 0, the cpumask will not be freed. > > Signed-off-by: Xiao

Re: [PATCH] cpumask: fix cpumask leak in partition_sched_domains

2013-08-14 Thread Xiaotian Feng
On Tue, Aug 6, 2013 at 8:06 PM, Xiaotian Feng xtf...@gmail.com wrote: If doms_new is NULL, partition_sched_domains() will reset ndoms_cur to 0, and free old sched domains with free_sched_domains(doms_cur, ndoms_cur). As ndoms_cur is 0, the cpumask will not be freed. Signed-off-by: Xiaotian

[PATCH] cpumask: fix cpumask leak in partition_sched_domains

2013-08-06 Thread Xiaotian Feng
If doms_new is NULL, partition_sched_domains() will reset ndoms_cur to 0, and free old sched domains with free_sched_domains(doms_cur, ndoms_cur). As ndoms_cur is 0, the cpumask will not be freed. Signed-off-by: Xiaotian Feng Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Rusty Russell Cc: Thomas

[PATCH] cpumask: fix cpumask leak in partition_sched_domains

2013-08-06 Thread Xiaotian Feng
If doms_new is NULL, partition_sched_domains() will reset ndoms_cur to 0, and free old sched domains with free_sched_domains(doms_cur, ndoms_cur). As ndoms_cur is 0, the cpumask will not be freed. Signed-off-by: Xiaotian Feng xtf...@gmail.com Cc: Ingo Molnar mi...@redhat.com Cc: Peter Zijlstra

Re: [PATCH] cpumask: fix cpumask leak in partition_sched_domains

2013-08-05 Thread Xiaotian Feng
On Tue, Aug 6, 2013 at 12:37 PM, Rusty Russell wrote: > Xiaotian Feng writes: >> On Sat, Jul 27, 2013 at 3:26 PM, Xiaotian Feng wrote: >>> If doms_new is NULL, partition_sched_domains() will reset ndoms_cur >>> to 0, and free old sched domains with free_sched_domai

Re: [PATCH] cpumask: fix cpumask leak in partition_sched_domains

2013-08-05 Thread Xiaotian Feng
On Sat, Jul 27, 2013 at 3:26 PM, Xiaotian Feng wrote: > If doms_new is NULL, partition_sched_domains() will reset ndoms_cur > to 0, and free old sched domains with free_sched_domains(doms_cur, ndoms_cur). > As ndoms_cur is 0, the cpumask will not be freed. > > Signed-off-by: Xiao

Re: [PATCH] cpumask: fix cpumask leak in partition_sched_domains

2013-08-05 Thread Xiaotian Feng
On Sat, Jul 27, 2013 at 3:26 PM, Xiaotian Feng xtf...@gmail.com wrote: If doms_new is NULL, partition_sched_domains() will reset ndoms_cur to 0, and free old sched domains with free_sched_domains(doms_cur, ndoms_cur). As ndoms_cur is 0, the cpumask will not be freed. Signed-off-by: Xiaotian

Re: [PATCH] cpumask: fix cpumask leak in partition_sched_domains

2013-08-05 Thread Xiaotian Feng
On Tue, Aug 6, 2013 at 12:37 PM, Rusty Russell ru...@rustcorp.com.au wrote: Xiaotian Feng xtf...@gmail.com writes: On Sat, Jul 27, 2013 at 3:26 PM, Xiaotian Feng xtf...@gmail.com wrote: If doms_new is NULL, partition_sched_domains() will reset ndoms_cur to 0, and free old sched domains

[PATCH] cpumask: fix cpumask leak in partition_sched_domains

2013-07-27 Thread Xiaotian Feng
If doms_new is NULL, partition_sched_domains() will reset ndoms_cur to 0, and free old sched domains with free_sched_domains(doms_cur, ndoms_cur). As ndoms_cur is 0, the cpumask will not be freed. Signed-off-by: Xiaotian Feng Cc: Ingo Molnar Cc: Peter Zijlstra Cc: linux-kernel@vger.kernel.org

[PATCH] cpumask: fix cpumask leak in partition_sched_domains

2013-07-27 Thread Xiaotian Feng
If doms_new is NULL, partition_sched_domains() will reset ndoms_cur to 0, and free old sched domains with free_sched_domains(doms_cur, ndoms_cur). As ndoms_cur is 0, the cpumask will not be freed. Signed-off-by: Xiaotian Feng xtf...@gmail.com Cc: Ingo Molnar mi...@redhat.com Cc: Peter Zijlstra

[PATCH v2] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-22 Thread Xiaotian Feng
art. changes in v2: use pp to check dummy ports, update comments Reported-and-tested-by: Alex Williamson Signed-off-by: Xiaotian Feng Cc: Alexander Gordeev Cc: Tejun Heo Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/ata/ahci.c |9 - 1 file changed

Re: [PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-22 Thread Xiaotian Feng
On Tue, Jul 23, 2013 at 5:28 AM, Tejun Heo wrote: > Hello, Xiaotian. > > Thanks for the fix. A couple comments below. > > On Wed, Jul 17, 2013 at 02:10:39PM +0800, Xiaotian Feng wrote: >> for (i = 0; i < host->n_ports; i++) { >> struct a

Re: [PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-22 Thread Xiaotian Feng
On Tue, Jul 23, 2013 at 5:28 AM, Tejun Heo t...@kernel.org wrote: Hello, Xiaotian. Thanks for the fix. A couple comments below. On Wed, Jul 17, 2013 at 02:10:39PM +0800, Xiaotian Feng wrote: for (i = 0; i host-n_ports; i++) { struct ahci_port_priv *pp = host-ports[i

[PATCH v2] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-22 Thread Xiaotian Feng
. changes in v2: use pp to check dummy ports, update comments Reported-and-tested-by: Alex Williamson alex.william...@redhat.com Signed-off-by: Xiaotian Feng xtf...@gmail.com Cc: Alexander Gordeev agord...@redhat.com Cc: Tejun Heo t...@kernel.org Cc: linux-...@vger.kernel.org Cc: linux-kernel

Re: [ipc,shm] BUG: lock held when returning to user space!

2013-07-20 Thread Xiaotian Feng
On Sat, Jul 20, 2013 at 9:13 PM, Fengguang Wu wrote: > Greetings, > > I got the below dmesg and the first bad commit is > > commit c5d0282a0405b0a81fa3390e4230e4cbb3ced7a2 > Author: Davidlohr Bueso > Date: Fri Jul 19 09:56:58 2013 +1000 > > ipc,shm: shorten critical region for shmat > >

Re: [ipc,shm] BUG: lock held when returning to user space!

2013-07-20 Thread Xiaotian Feng
On Sat, Jul 20, 2013 at 9:13 PM, Fengguang Wu fengguang...@intel.com wrote: Greetings, I got the below dmesg and the first bad commit is commit c5d0282a0405b0a81fa3390e4230e4cbb3ced7a2 Author: Davidlohr Bueso davidlohr.bu...@hp.com Date: Fri Jul 19 09:56:58 2013 +1000 ipc,shm:

[PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-17 Thread Xiaotian Feng
art. Reported-and-tested-by: Alex Williamson Signed-off-by: Xiaotian Feng Cc: Alexander Gordeev Cc: Tejun Heo Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/ata/ahci.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/ata/ahci.

[PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-17 Thread Xiaotian Feng
. Reported-and-tested-by: Alex Williamson alex.william...@redhat.com Signed-off-by: Xiaotian Feng xtf...@gmail.com Cc: Alexander Gordeev agord...@redhat.com Cc: Tejun Heo t...@kernel.org Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/ata/ahci.c |8 +++- 1 file

[PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-15 Thread Xiaotian Feng
off-by: Xiaotian Feng Cc: Alexander Gordeev Cc: Tejun Heo Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/ata/ahci.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 5064f3e..f1de689 100644 --- a/driv

Re: ahci_host_activate NULL pointer (was Re: Linux 3.11-rc1)

2013-07-15 Thread Xiaotian Feng
On Mon, Jul 15, 2013 at 3:44 PM, Alex Williamson wrote: > On Mon, 2013-07-15 at 13:23 -0600, Alex Williamson wrote: >> On Mon, 2013-07-15 at 14:46 -0400, Xiaotian Feng wrote: >> > On Tue, Jul 16, 2013 at 1:38 AM, Alex Williamson >> > > > > wrote: >>

Re: ahci_host_activate NULL pointer (was Re: Linux 3.11-rc1)

2013-07-15 Thread Xiaotian Feng
On Mon, Jul 15, 2013 at 3:44 PM, Alex Williamson wrote: > On Mon, 2013-07-15 at 13:23 -0600, Alex Williamson wrote: >> On Mon, 2013-07-15 at 14:46 -0400, Xiaotian Feng wrote: >> > On Tue, Jul 16, 2013 at 1:38 AM, Alex Williamson >> > > > > wrote: >>

Re: ahci_host_activate NULL pointer (was Re: Linux 3.11-rc1)

2013-07-15 Thread Xiaotian Feng
On Mon, Jul 15, 2013 at 3:44 PM, Alex Williamson alex.william...@redhat.com wrote: On Mon, 2013-07-15 at 13:23 -0600, Alex Williamson wrote: On Mon, 2013-07-15 at 14:46 -0400, Xiaotian Feng wrote: On Tue, Jul 16, 2013 at 1:38 AM, Alex Williamson alex.william...@redhat.com wrote

Re: ahci_host_activate NULL pointer (was Re: Linux 3.11-rc1)

2013-07-15 Thread Xiaotian Feng
On Mon, Jul 15, 2013 at 3:44 PM, Alex Williamson alex.william...@redhat.com wrote: On Mon, 2013-07-15 at 13:23 -0600, Alex Williamson wrote: On Mon, 2013-07-15 at 14:46 -0400, Xiaotian Feng wrote: On Tue, Jul 16, 2013 at 1:38 AM, Alex Williamson alex.william...@redhat.com wrote

[PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-15 Thread Xiaotian Feng
...@redhat.com Signed-off-by: Xiaotian Feng xtf...@gmail.com Cc: Alexander Gordeev agord...@redhat.com Cc: Tejun Heo t...@kernel.org Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/ata/ahci.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH] [SCSI] mptfusion: delete rphy info in mptsas_del_end_device()

2013-02-20 Thread Xiaotian Feng
Otherwise, we might get wrong rphy attributes through sysfs when a end device is not responding. Signed-off-by: Xiaotian Feng Cc: Nagalakshmi Nandigama Cc: Sreekanth Reddy Cc: supp...@lsi.com Cc: dl-mptfusionli...@lsi.com Cc: linux-s...@vger.kernel.org Cc: linux-kernel@vger.kernel.org

Re: [PATCH] sched/core: remove obsolete nr_uninterruptible()

2013-02-20 Thread Xiaotian Feng
On Wed, Feb 20, 2013 at 3:37 PM, Sha Zhengju wrote: > From: Sha Zhengju > > Signed-off-by: Sha Zhengju > --- > kernel/sched/core.c | 17 - > 1 file changed, 17 deletions(-) You missed include/linux/sched.h :) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c >

Re: [PATCH] sched/core: remove obsolete nr_uninterruptible()

2013-02-20 Thread Xiaotian Feng
On Wed, Feb 20, 2013 at 3:37 PM, Sha Zhengju handai@gmail.com wrote: From: Sha Zhengju handai@taobao.com Signed-off-by: Sha Zhengju handai@taobao.com --- kernel/sched/core.c | 17 - 1 file changed, 17 deletions(-) You missed include/linux/sched.h :) diff

[PATCH] [SCSI] mptfusion: delete rphy info in mptsas_del_end_device()

2013-02-20 Thread Xiaotian Feng
Otherwise, we might get wrong rphy attributes through sysfs when a end device is not responding. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Nagalakshmi Nandigama nagalakshmi.nandig...@lsi.com Cc: Sreekanth Reddy sreekanth.re...@lsi.com Cc: supp...@lsi.com Cc: dl-mptfusionli...@lsi.com

Re: [PATCH v2 repost] sched: cputime: avoid multiplication overflow (in common cases)

2013-01-23 Thread Xiaotian Feng
On Thu, Jan 10, 2013 at 2:33 AM, Frederic Weisbecker wrote: > On Mon, Jan 07, 2013 at 12:31:45PM +0100, Stanislaw Gruszka wrote: >> We scale stime, utime values based on rtime (sum_exec_runtime converted >> to jiffies). During scaling we multiple rtime * utime, what seems to be >> fine, since

Re: [PATCH v2 repost] sched: cputime: avoid multiplication overflow (in common cases)

2013-01-23 Thread Xiaotian Feng
On Thu, Jan 10, 2013 at 2:33 AM, Frederic Weisbecker fweis...@gmail.com wrote: On Mon, Jan 07, 2013 at 12:31:45PM +0100, Stanislaw Gruszka wrote: We scale stime, utime values based on rtime (sum_exec_runtime converted to jiffies). During scaling we multiple rtime * utime, what seems to be

[PATCH] proc: fix inconsistent lock state

2012-12-19 Thread Xiaotian Feng
xa0 [ 49.732029] [] ? cpuidle_wrap_enter+0x51/0xa0 [ 49.732399] [] cpuidle_enter_tk+0x10/0x20 [ 49.732759] [] cpuidle_enter_state+0x17/0x50 [ 49.733128] [] cpuidle_idle_call+0x287/0x520 [ 49.733496] [] cpu_idle+0xba/0x130 [ 49.733830] [] start_secondary+0x2b3/0x2bc Signed-off-by: Xiaotian F

[PATCH] proc: fix inconsistent lock state

2012-12-19 Thread Xiaotian Feng
] cpuidle_idle_call+0x287/0x520 [ 49.733496] [8105feca] cpu_idle+0xba/0x130 [ 49.733830] [81b2059f] start_secondary+0x2b3/0x2bc Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Andrew Morton a...@linux-foundation.org Cc: Al Viro v...@zeniv.linux.org.uk Cc: Eric W. Biederman ebied

[PATCH] megaraid: convert to work_struct

2012-12-13 Thread Xiaotian Feng
There's no need to use delayed work, convert to use work_struct and cancel_work_sync(). Requested-by: Tejun Heo Signed-off-by: Xiaotian Feng Cc: Neela Syam Kolli Cc: "James E.J. Bottomley" Cc: linux-s...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/scs

[PATCH] [libata] scsi: fix Null pointer dereference on disk error

2012-12-13 Thread Xiaotian Feng
/pci:00/:00:1f.2/host0/target0:0:0/0:0:0:0/sw_activity [ 4291.934235] CPU 9 [ 4291.958301] Pid: 27942, comm: hwinfo .. ata_scsi_find_dev could return NULL, so ata_scsi_activity_{show,store} should check if atadev is NULL. Signed-off-by: Xiaotian Feng Cc: Jeff Garzik Cc: James

[PATCH] [libata] scsi: fix Null pointer dereference on disk error

2012-12-13 Thread Xiaotian Feng
/pci:00/:00:1f.2/host0/target0:0:0/0:0:0:0/sw_activity [ 4291.934235] CPU 9 [ 4291.958301] Pid: 27942, comm: hwinfo .. ata_scsi_find_dev could return NULL, so ata_scsi_activity_{show,store} should check if atadev is NULL. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Jeff

[PATCH] megaraid: convert to work_struct

2012-12-13 Thread Xiaotian Feng
There's no need to use delayed work, convert to use work_struct and cancel_work_sync(). Requested-by: Tejun Heo t...@kernel.org Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Neela Syam Kolli megaraidli...@lsi.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-s

[PATCH] megaraid: fix use of delayed work

2012-12-04 Thread Xiaotian Feng
dwork->timer before queue_work, this will cause megaraid code to hit the BUG_ON in workqueue code. Change megaraid code to use delayed work. Signed-off-by: Xiaotian Feng Cc: Tejun Heo Cc: Neela Syam Kolli Cc: "James E.J. Bottomley" Cc: linux-s...@vger.kernel.org --- drivers/

[PATCH] megaraid: fix use of delayed work

2012-12-04 Thread Xiaotian Feng
dwork-timer before queue_work, this will cause megaraid code to hit the BUG_ON in workqueue code. Change megaraid code to use delayed work. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Tejun Heo t...@kernel.org Cc: Neela Syam Kolli megaraidli...@lsi.com Cc: James E.J. Bottomley jbottom

Re: linux-next: manual merge of the akpm tree with Linus' tree

2012-11-26 Thread Xiaotian Feng
On Mon, Nov 26, 2012 at 8:48 PM, Stephen Rothwell wrote: > Hi Andrew, > > Today's linux-next merge of the akpm tree got a conflict in > drivers/net/ethernet/jme.c between commit 71c6c837a0fe ("drivers/net: fix > tasklet misuse issue") from Linus' tree and commit "tasklet: ignore > disabled

Re: linux-next: manual merge of the akpm tree with Linus' tree

2012-11-26 Thread Xiaotian Feng
On Mon, Nov 26, 2012 at 8:48 PM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Andrew, Today's linux-next merge of the akpm tree got a conflict in drivers/net/ethernet/jme.c between commit 71c6c837a0fe (drivers/net: fix tasklet misuse issue) from Linus' tree and commit tasklet: ignore

[PATCH] drivers/net: fix tasklet misuse issue

2012-11-13 Thread Xiaotian Feng
razy then. Normally, drivers should use tasklet_init/tasklet_kill on device open/remove, and use tasklet_disable/tasklet_enable on device suspend/resume. Reported-by: Peter Wu Tested-by: Peter Wu Signed-off-by: Xiaotian Feng Cc: "David S. Miller" Cc: net...@vger.kernel.org Cc: linux-kernel@v

[PATCH] drivers/net: fix tasklet misuse issue

2012-11-13 Thread Xiaotian Feng
then. Normally, drivers should use tasklet_init/tasklet_kill on device open/remove, and use tasklet_disable/tasklet_enable on device suspend/resume. Reported-by: Peter Wu lekenst...@gmail.com Tested-by: Peter Wu lekenst...@gmail.com Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: David S. Miller da

Re: [RFC PATCH] tasklet: ignore disabled tasklet in tasklet_action

2012-11-05 Thread Xiaotian Feng
On Tue, Nov 6, 2012 at 6:52 AM, Andrew Morton wrote: > On Fri, 2 Nov 2012 10:48:54 +0800 > Xiaotian Feng wrote: > >> We met a ksoftirqd 100% issue, the perf top shows kernel is busy >> with tasklet_action(), but no actual action is shown. From dumped >> kernel, there'

Re: [RFC PATCH] tasklet: ignore disabled tasklet in tasklet_action

2012-11-05 Thread Xiaotian Feng
On Tue, Nov 6, 2012 at 6:52 AM, Andrew Morton a...@linux-foundation.org wrote: On Fri, 2 Nov 2012 10:48:54 +0800 Xiaotian Feng xtf...@gmail.com wrote: We met a ksoftirqd 100% issue, the perf top shows kernel is busy with tasklet_action(), but no actual action is shown. From dumped kernel

[RFC PATCH] tasklet: ignore disabled tasklet in tasklet_action

2012-11-01 Thread Xiaotian Feng
it is the same as tasklet_enable(). So only tasklet_enable() needs to be modified, if tasklet state is changed from disable to enable, use __tasklet_schedule() to put it on the right vec. Signed-off-by: Xiaotian Feng Cc: Andrew Morton --- include/linux/interrupt.h | 12 ++-- kernel

[PATCH] swapfile: fix name leak in swapoff

2012-11-01 Thread Xiaotian Feng
there's a name leak introduced by commit 91a27b2, add the missing putname. Signed-off-by: Xiaotian Feng Cc: Jeff Layton Cc: Al Viro --- mm/swapfile.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/swapfile.c b/mm/swapfile.c index 71cd288..459fe30 100644 --- a/mm/swapfile.c +++ b

[PATCH] swapfile: fix name leak in swapoff

2012-11-01 Thread Xiaotian Feng
there's a name leak introduced by commit 91a27b2, add the missing putname. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Jeff Layton jlay...@redhat.com Cc: Al Viro v...@zeniv.linux.org.uk --- mm/swapfile.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/swapfile.c b/mm

[RFC PATCH] tasklet: ignore disabled tasklet in tasklet_action

2012-11-01 Thread Xiaotian Feng
it is the same as tasklet_enable(). So only tasklet_enable() needs to be modified, if tasklet state is changed from disable to enable, use __tasklet_schedule() to put it on the right vec. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Andrew Morton a...@linux-foundation.org --- include/linux

Re: [PATCH] dma: ioat: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
On Wed, Oct 31, 2012 at 6:41 PM, Xiaotian Feng wrote: > Some driver uses tasklet_disable in device remove/release process, > tasklet_disable will inc tasklet->count and return. If the tasklet > is not handled yet under some softirq pressure, the tasklet will be > placed on the tas

[PATCH] staging: ozwpan: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ded ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng Cc: Rupesh Gujare Cc: Chris Kelly Cc: Greg Kroah-Hartman Cc: de...@driverdev.osuosl.org --- drivers/staging/ozwpan/ozhcd.c |4 ++-- 1 file changed

[PATCH] rapidio/tsi721: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ded ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng Cc: Matt Porter Cc: Alexandre Bounine Cc: Andrew Morton --- drivers/rapidio/devices/tsi721_dma.c |2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] mmc: s3cmci: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ded ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng Cc: Ben Dooks Cc: Chris Ball Cc: linux-arm-ker...@lists.infradead.org Cc: linux-...@vger.kernel.org --- drivers/mmc/host/s3cmci.c |2 +- 1 file changed

[PATCH] isdn/gigaset: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ded ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng Cc: Hansjoerg Lipp Cc: Tilman Schmidt Cc: Karsten Keil Cc: gigaset307x-com...@lists.sourceforge.net --- drivers/isdn/gigaset/interface.c |1 - 1 f

[PATCH] dma: ioat: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ded ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng Cc: Vinod Koul Cc: Dan Williams --- drivers/dma/ioat/dma.c|2 +- drivers/dma/ioat/dma_v2.c |2 +- 2 files changed, 2 insertions(+), 2 deleti

[PATCH] atm: he: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ded ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng Cc: Chas Williams Cc: linux-atm-gene...@lists.sourceforge.net --- drivers/atm/he.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH] drivers/net: use tasklet_kill in device remove/close process

2012-10-31 Thread Xiaotian Feng
ded, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng Cc: "David S. Miller" Cc: net...@vger.kernel.org --- drivers/net/ethernet/jme.c|8 drivers/net/ethernet/m

[PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Xiaotian Feng
If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng Cc: Jon Maloy Cc: Allan Stephens Cc: "David S. Miller" Cc: net...@vger.kernel.org Cc: tipc-discuss...@lists.sourceforge.net ---

[PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Xiaotian Feng
If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng Cc: Li Yang Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org --- drivers/usb/gadget

[PATCH 1/3] input: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Xiaotian Feng
If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng Cc: Dmitry Torokhov Cc: Tony Lindgren Cc: Sourav Poddar Cc: Josh Cc: Greg Kroah-Hartman Cc: linux-in...@vger.kernel.org --- drivers

[PATCH 1/2] tasklet: remove tasklet_kill_immediate()

2012-10-31 Thread Xiaotian Feng
tasklet_kill_immediate() is no longer used, just remove it. Signed-off-by: Xiaotian Feng Cc: Thomas Gleixner Cc: Frederic Weisbecker Cc: "Paul E. McKenney" Cc: Andrew Morton Cc: Josh Triplett --- kernel/softirq.c | 32 1 file changed, 32

[PATCH 1/2] tasklet: remove tasklet_kill_immediate()

2012-10-31 Thread Xiaotian Feng
tasklet_kill_immediate() is no longer used, just remove it. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Thomas Gleixner t...@linutronix.de Cc: Frederic Weisbecker fweis...@gmail.com Cc: Paul E. McKenney paul...@linux.vnet.ibm.com Cc: Andrew Morton a...@linux-foundation.org Cc: Josh

[PATCH 1/3] input: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Xiaotian Feng
If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: Tony Lindgren t...@atomide.com Cc: Sourav Poddar sourav.pod...@ti.com

[PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Xiaotian Feng
If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Li Yang le...@freescale.com Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux

[PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Xiaotian Feng
If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Jon Maloy jon.ma...@ericsson.com Cc: Allan Stephens allan.steph...@windriver.com Cc: David S. Miller da

[PATCH] drivers/net: use tasklet_kill in device remove/close process

2012-10-31 Thread Xiaotian Feng
, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: David S. Miller da...@davemloft.net Cc: net...@vger.kernel.org --- drivers/net/ethernet/jme.c|8 drivers/net

[PATCH] atm: he: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Chas Williams c...@cmf.nrl.navy.mil Cc: linux-atm-gene...@lists.sourceforge.net --- drivers/atm/he.c |2 +- 1 file changed, 1

[PATCH] dma: ioat: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams d...@fb.com --- drivers/dma/ioat/dma.c|2 +- drivers/dma/ioat/dma_v2.c |2

[PATCH] isdn/gigaset: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Hansjoerg Lipp hjl...@web.de Cc: Tilman Schmidt til...@imap.cc Cc: Karsten Keil i...@linux-pingi.de Cc: gigaset307x-com

[PATCH] mmc: s3cmci: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Ben Dooks ben-li...@fluff.org Cc: Chris Ball c...@laptop.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-...@vger.kernel.org

[PATCH] rapidio/tsi721: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Matt Porter mpor...@kernel.crashing.org Cc: Alexandre Bounine alexandre.boun...@idt.com Cc: Andrew Morton a...@linux-foundation.org

[PATCH] staging: ozwpan: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Rupesh Gujare rguj...@ozmodevices.com Cc: Chris Kelly cke...@ozmodevices.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: de

Re: [PATCH] dma: ioat: use tasklet_kill in device remove/release process

2012-10-31 Thread Xiaotian Feng
On Wed, Oct 31, 2012 at 6:41 PM, Xiaotian Feng xtf...@gmail.com wrote: Some driver uses tasklet_disable in device remove/release process, tasklet_disable will inc tasklet-count and return. If the tasklet is not handled yet under some softirq pressure, the tasklet will be placed

Re: [PATCH] V2 sched, autogroup: fix crash on reboot when autogroup is disabled

2012-10-28 Thread Xiaotian Feng
On Mon, Oct 29, 2012 at 3:19 AM, Mike Galbraith wrote: > On Sun, 2012-10-28 at 15:05 +0100, Ingo Molnar wrote: >> * Mike Galbraith wrote: >> >> > On Sun, 2012-10-28 at 14:19 +0100, Ingo Molnar wrote: >> > > * Mike Galbraith wrote: >> > > >> > > > On Sun, 2012-10-28 at 11:25 +0100, Ingo Molnar

Re: [PATCH] V2 sched, autogroup: fix crash on reboot when autogroup is disabled

2012-10-28 Thread Xiaotian Feng
On Mon, Oct 29, 2012 at 3:19 AM, Mike Galbraith efa...@gmx.de wrote: On Sun, 2012-10-28 at 15:05 +0100, Ingo Molnar wrote: * Mike Galbraith efa...@gmx.de wrote: On Sun, 2012-10-28 at 14:19 +0100, Ingo Molnar wrote: * Mike Galbraith efa...@gmx.de wrote: On Sun, 2012-10-28 at 11:25

Re: [PATCH] sched, autogroup: fix kernel crashes caused by runtime disable autogroup

2012-10-20 Thread Xiaotian Feng
On Fri, Oct 19, 2012 at 9:42 PM, Peter Zijlstra wrote: > Always try and CC people who wrote the code.. > > On Fri, 2012-10-19 at 16:36 +0800, Xiaotian Feng wrote: >> There's a regression from commit 800d4d30, in autogroup_move_group() >> >> p->signal->

Re: [PATCH] sched, autogroup: fix kernel crashes caused by runtime disable autogroup

2012-10-20 Thread Xiaotian Feng
On Fri, Oct 19, 2012 at 9:42 PM, Peter Zijlstra pet...@infradead.org wrote: Always try and CC people who wrote the code.. On Fri, 2012-10-19 at 16:36 +0800, Xiaotian Feng wrote: There's a regression from commit 800d4d30, in autogroup_move_group() p-signal-autogroup = autogroup_kref_get

[PATCH] sched, autogroup: fix kernel crashes caused by runtime disable autogroup

2012-10-19 Thread Xiaotian Feng
nriques Signed-off-by: Xiaotian Feng Cc: Ingo Molnar Cc: Peter Zijlstra --- kernel/sched/auto_group.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/auto_group.c b/kernel/sched/auto_group.c index 0984a21..ac62415 100644 --- a/kernel/sched/auto_group.c

[PATCH] sched, autogroup: fix kernel crashes caused by runtime disable autogroup

2012-10-19 Thread Xiaotian Feng
luis.henriq...@canonical.com Signed-off-by: Xiaotian Feng dannyf...@tencent.com Cc: Ingo Molnar mi...@redhat.com Cc: Peter Zijlstra pet...@infradead.org --- kernel/sched/auto_group.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/auto_group.c b/kernel/sched

Re: [PATCH] pidns: remove recursion from free_pid_ns (v3)

2012-10-10 Thread Xiaotian Feng
On Wed, Oct 10, 2012 at 5:12 PM, Xiaotian Feng wrote: > On Wed, Oct 10, 2012 at 3:49 PM, Greg KH wrote: >> On Tue, Oct 09, 2012 at 12:08:31PM -0700, Andrew Morton wrote: >>> On Tue, 9 Oct 2012 12:03:00 -0700 >>> Greg KH wrote: >>> >>> > On Tue,

Re: [PATCH] pidns: remove recursion from free_pid_ns (v3)

2012-10-10 Thread Xiaotian Feng
On Wed, Oct 10, 2012 at 3:49 PM, Greg KH wrote: > On Tue, Oct 09, 2012 at 12:08:31PM -0700, Andrew Morton wrote: >> On Tue, 9 Oct 2012 12:03:00 -0700 >> Greg KH wrote: >> >> > On Tue, Oct 09, 2012 at 11:48:21AM -0700, Andrew Morton wrote: >> > > On Sat, 6 Oct 2012 23:56:33 +0400 >> > > Andrew

Re: [PATCH] pidns: remove recursion from free_pid_ns (v3)

2012-10-10 Thread Xiaotian Feng
On Wed, Oct 10, 2012 at 3:49 PM, Greg KH g...@kroah.com wrote: On Tue, Oct 09, 2012 at 12:08:31PM -0700, Andrew Morton wrote: On Tue, 9 Oct 2012 12:03:00 -0700 Greg KH g...@kroah.com wrote: On Tue, Oct 09, 2012 at 11:48:21AM -0700, Andrew Morton wrote: On Sat, 6 Oct 2012 23:56:33 +0400

Re: [PATCH] pidns: remove recursion from free_pid_ns (v3)

2012-10-10 Thread Xiaotian Feng
On Wed, Oct 10, 2012 at 5:12 PM, Xiaotian Feng xtf...@gmail.com wrote: On Wed, Oct 10, 2012 at 3:49 PM, Greg KH g...@kroah.com wrote: On Tue, Oct 09, 2012 at 12:08:31PM -0700, Andrew Morton wrote: On Tue, 9 Oct 2012 12:03:00 -0700 Greg KH g...@kroah.com wrote: On Tue, Oct 09, 2012 at 11:48