Hi Srinivas
Thanks for the review.
On Tue, Mar 09, 2021 at 08:08:36AM -0800, Srinivas Pandruvada wrote:
> On Tue, 2021-03-09 at 11:47 +0800, Ye, Xiang wrote:
> > Hi Srinivas, Jiri
> >
> > On Mon, Mar 08, 2021 at 08:00:41AM -0800, Srinivas Pandruvada wrote:
> > &g
Hi Srinivas, Jiri
On Mon, Mar 08, 2021 at 08:00:41AM -0800, Srinivas Pandruvada wrote:
> On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote:
> > On Wed, 3 Mar 2021, Ye Xiang wrote:
> >
> > > ISH firmware uses connected standby state bit
> > > (CONNECTED_STANDBY
This patch fixes 2 issues of timestamp channel:
1. This patch ensures that there is sufficient space and correct
alignment for the timestamp.
2. Correct the timestamp channel scan index.
Fixes: 59d0f2da3569 ("iio: hid: Add temperature sensor support")
Signed-off-by: Ye Xiang
---
d
Try to get sample timestamp from sensor hub first, if failed
then use system timestamp.
Signed-off-by: Ye Xiang
---
drivers/iio/temperature/hid-sensor-temperature.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/temperature/hid-sensor
Try to get sample timestamp from sensor hub first, if failed
then use system timestamp.
Signed-off-by: Ye Xiang
---
drivers/iio/humidity/hid-sensor-humidity.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/humidity/hid-sensor-humidity.c
b
This patch ensures that, there is sufficient space and correct
alignment for the timestamp.
Fixes: d7ed89d5aadf ("iio: hid: Add humidity sensor support")
Signed-off-by: Ye Xiang
---
drivers/iio/humidity/hid-sensor-humidity.c | 12 +++-
1 file changed, 7 insertions(+), 5
This patch series fixes timestamp issues for humidity and temperature sensor.
Ye Xiang (4):
iio: hid-sensor-humidity: Fix alignment issue of timestamp channel
iio: hid-sensor-humidity: Get sample timestamp from sensor hub
iio: hid-sensor-temperature: Fix issues of timestamp channel
iio
ISH firmware uses connected standby state bit (CONNECTED_STANDBY_STATE_BIT bit
1)
to notify current power state to sensors instead of suspend state bit (bit 0).
So send both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT to firmware
to be compatible with the previous version.
Signed-off-by:
Some hid sensors may use relative sensitivity such as als sensor.
This patch adds relative sensitivity checking for all hid sensors.
Signed-off-by: Ye Xiang
---
.../hid-sensors/hid-sensor-attributes.c | 74 ++-
drivers/iio/industrialio-core.c | 1 +
include
Add relative hysteresis in ABI documentation for als sensor.
Signed-off-by: Ye Xiang
---
Documentation/ABI/testing/sysfs-bus-iio | 9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b/Documentation/ABI/testing/sysfs-bus-iio
index d957f5da5c04
Hid sensor als use relative hysteresis, this patch adds the support.
Signed-off-by: Ye Xiang
---
drivers/iio/light/hid-sensor-als.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/light/hid-sensor-als.c
b/drivers/iio/light/hid-sensor-als.c
index
Currently, hid sensor als are using the relative hysteresis.
This patch series add the relative hysteresis for hid sensors.
---
v2:
- (1/3) fix the formatting issue in hid_sensor_read_raw_hyst_rel_value.
- (3/3) add documentation just for light sensor.
Ye Xiang (3):
iio: Add relative
Some hid sensors may use relative sensitivity such as als sensor.
This patch adds relative sensitivity checking for all hid sensors.
Signed-off-by: Ye Xiang
---
.../hid-sensors/hid-sensor-attributes.c | 75 ++-
drivers/iio/industrialio-core.c | 1 +
include
Add relative hysteresis in ABI documentation.
Signed-off-by: Ye Xiang
---
Documentation/ABI/testing/sysfs-bus-iio | 8
1 file changed, 8 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b/Documentation/ABI/testing/sysfs-bus-iio
index d957f5da5c04..1c51db7eb8ef
Hid sensor als uses relative hysteresis, this patch adds the support.
Signed-off-by: Ye Xiang
---
drivers/iio/light/hid-sensor-als.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/light/hid-sensor-als.c
b/drivers/iio/light/hid-sensor-als.c
index
Currently, hid sensor als are using the relative hysteresis.
This patch series add the relative hysteresis for hid sensors.
Ye Xiang (3):
iio: Add relative sensitivity support
iio: hid-sensor-als: Add relative hysteresis support
iio: Add relative hysteresis in ABI documentation
This patch series move get sensitivity attribute to common layer and
resolve read hystersis return invalid argument issue for hid sensors als,
incli-3d, rotation, and press on intel ISH Platform.
---
v2:
- separate the add relative sensitivity patch to the next patch series.
Ye Xiang (2
Before, when reading/writing the hysteresis of als, incli-3d, press, and
rotation sensor, we will get invalid argument error.
This patch add more sensitivity data fields for these sensors, so that
these sensors can get sensitivity index and return correct hysteresis
value.
Signed-off-by: Ye
this to common place will avoid code repetition.
Signed-off-by: Ye Xiang
---
drivers/iio/accel/hid-sensor-accel-3d.c | 23 ++---
.../hid-sensors/hid-sensor-attributes.c | 17 +-
drivers/iio/gyro/hid-sensor-gyro-3d.c | 19 ---
drivers/iio/humidity/hid-sensor
Before, when reading/writing the hysteresis of als, incli-3d, press, and
rotation sensor, we will get invalid argument error.
This patch add more sensitivity data fields for these sensors, so that
these sensors can get sensitivity index and return correct hysteresis
value.
Signed-off-by: Ye
This patch series move get sensitivity attribute to common layer and
resolve read hystersis return invalid argument issue for hid sensors als,
incli-3d, rotation, and press on intel ISH Platform.
---
v2:
- separate the add relative sensitivity patch to the next patch series.
Ye Xiang (2
this to common place will avoid code repetition.
Signed-off-by: Ye Xiang
---
drivers/iio/accel/hid-sensor-accel-3d.c | 23 ++---
.../hid-sensors/hid-sensor-attributes.c | 17 +-
drivers/iio/gyro/hid-sensor-gyro-3d.c | 19 ---
drivers/iio/humidity/hid-sensor
On Sat, Jan 30, 2021 at 07:14:29PM +, Jonathan Cameron wrote:
> On Sat, 30 Jan 2021 18:25:30 +0800
> Ye Xiang wrote:
>
> > Currently, the proxy sensor scale is zero because it just return the
> > exponent directly. To fix this issue, this patch use
> > hid_sen
On Sat, Jan 30, 2021 at 07:14:29PM +, Jonathan Cameron wrote:
> On Sat, 30 Jan 2021 18:25:30 +0800
> Ye Xiang wrote:
>
> > Currently, the proxy sensor scale is zero because it just return the
> > exponent directly. To fix this issue, this patch use
> > hid_sen
Because the data of HID_USAGE_SENSOR_ORIENT_QUATERNION defined by ISH FW
is s16, but quaternion data type is in_rot_quaternion_type(le:s16/32X4>>0),
need to transform data type from s16 to s32
Fixes: fc18dddc0625 ("iio: hid-sensors: Added device rotation support")
Signed-off-by:
Currently, the proxy sensor scale is zero because it just return the
exponent directly. To fix this issue, this patch use
hid_sensor_format_scale to process the scale first then return the
output.
Fixes: 39a3a0138f61 ("iio: hid-sensors: Added Proximity Sensor Driver")
Signed-off-by
Hi Srinivas andd Jonathan
Thanks for the review.
On Sun, Jan 24, 2021 at 08:20:12AM -0800, Srinivas Pandruvada wrote:
> On Sun, 2021-01-24 at 13:14 +, Jonathan Cameron wrote:
> > On Wed, 20 Jan 2021 15:47:05 +0800
> > Ye Xiang wrote:
> >
> > > Some hid sensor
Currently, the proxy sensor scale is zero because it just return the
exponent directly. To fix this issue, this patch use
hid_sensor_format_scale to process the scale first then return the
output.
Signed-off-by: Ye Xiang
---
drivers/iio/light/hid-sensor-prox.c | 13 +++--
1 file changed
Because the data of HID_USAGE_SENSOR_ORIENT_QUATERNION defined by ISH FW
is s16, but quaternion data type is in_rot_quaternion_type(le:s16/32X4>>0),
need to transform data type from s16 to s32
Signed-off-by: Ye Xiang
---
drivers/iio/orientation/hid-sensor-rotation.c | 13 ++---
Some hid sensors may use relative sensitivity such as als sensor.
This patch add relative sensitivity check for all hid-sensors.
Signed-off-by: Ye Xiang
---
.../iio/common/hid-sensors/hid-sensor-attributes.c| 11 ++-
include/linux/hid-sensor-ids.h| 1 +
2
Before, when reading/writing the hysteresis of als, incli-3d, press, and
rotation sensor, we will get invalid argument error.
This patch add more sensitivity data fields for these sensors, so that
these sensors can get sensitivity index and return correct hysteresis
value.
Signed-off-by: Ye
this to common place will avoid code repetition.
Signed-off-by: Ye Xiang
---
drivers/iio/accel/hid-sensor-accel-3d.c | 23 +
.../hid-sensors/hid-sensor-attributes.c | 17 +-
drivers/iio/gyro/hid-sensor-gyro-3d.c | 19 ---
drivers/iio/humidity/hid-sensor
This patch series move get sensitivity attribute to common layer and
resolve read hystersis return invalid argument issue for hid sensors als,
incli-3d, rotation, and press on intel ISH Platform.
Ye Xiang (3):
iio: hid-sensors: Move get sensitivity attribute to hid-sensor-common
hid-sensor
On Sat, Jan 09, 2021 at 07:28:05PM +, Jonathan Cameron wrote:
> On Tue, 5 Jan 2021 17:26:33 +0800
> "Ye, Xiang" wrote:
>
> > On Tue, Jan 05, 2021 at 12:53:44AM -0800, Srinivas Pandruvada wrote:
> > > On Tue, 2021-01-05 at 15:21 +0800, Ye Xiang wrot
Each sample has a timestamp field with this change. This timestamp may
be from the sensor hub when present or local kernel timestamp. And the
unit of timestamp is nanosecond.
Signed-off-by: Ye Xiang
---
drivers/iio/orientation/hid-sensor-rotation.c | 46 +++
1 file changed, 26
Each sample has a timestamp field with this change. This timestamp may
be from the sensor hub when present or local kernel timestamp. And the
unit of timestamp is nanosecond.
Signed-off-by: Ye Xiang
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 48 ---
1 file changed, 30
Each sample has a timestamp field with this change. This timestamp may
be from the sensor hub when present or local kernel timestamp. And the
unit of timestamp is nanosecond.
Signed-off-by: Ye Xiang
---
drivers/iio/orientation/hid-sensor-incl-3d.c | 43
1 file changed, 27
Each sample has a timestamp field with this change. This timestamp may
be from the sensor hub when present or local kernel timestamp. And the
unit of timestamp is nanosecond.
Signed-off-by: Ye Xiang
---
drivers/iio/light/hid-sensor-als.c | 39 ++
1 file changed, 23
Each sample has a timestamp field with this change. This timestamp may
be from the sensor hub when present or local kernel timestamp. And the
unit of timestamp is nanosecond.
Signed-off-by: Ye Xiang
---
drivers/iio/gyro/hid-sensor-gyro-3d.c | 40 ---
1 file changed, 24
The accel_3d sensor already has a timestamp channel, this patch just
replicate that for gravity sensor.
Signed-off-by: Ye Xiang
---
drivers/iio/accel/hid-sensor-accel-3d.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c
b
This patch series add a timestamp channel for hid sensors,
including gravity sensor, gyro sensor, magnetometer sensor,
ambient light sensor, inclinometer sensor, and rotation sensor.
With this patch series, user can get the time when sensor yield
a sample.
Ye Xiang (6):
iio: hid-sensor-accel
On Tue, Jan 05, 2021 at 12:53:44AM -0800, Srinivas Pandruvada wrote:
> On Tue, 2021-01-05 at 15:21 +0800, Ye Xiang wrote:
> > This patch series add a timestamp channel for hid sensors,
> > including gravity sensor, gyro sensor, magnetometer sensor,
> > ambient light sensor
The accel_3d sensor already has a timestamp channel, this patch just
replicate that for gravity sensor.
Signed-off-by: Ye Xiang
---
drivers/iio/accel/hid-sensor-accel-3d.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c
b
Each sample has a timestamp field with this change. This timestamp may
be from the sensor hub when present or local kernel timestamp. And the
unit of timestamp is nanosecond.
Signed-off-by: Ye Xiang
---
drivers/iio/orientation/hid-sensor-rotation.c | 46 +++
1 file changed, 26
Each sample has a timestamp field with this change. This timestamp may
be from the sensor hub when present or local kernel timestamp. And the
unit of timestamp is nanosecond.
Signed-off-by: Ye Xiang
---
drivers/iio/gyro/hid-sensor-gyro-3d.c | 40 ---
1 file changed, 24
Each sample has a timestamp field with this change. This timestamp may
be from the sensor hub when present or local kernel timestamp. And the
unit of timestamp is nanosecond.
Signed-off-by: Ye Xiang
---
drivers/iio/light/hid-sensor-als.c | 39 ++
1 file changed, 23
Each sample has a timestamp field with this change. This timestamp may
be from the sensor hub when present or local kernel timestamp. And the
unit of timestamp is nanosecond.
Signed-off-by: Ye Xiang
---
drivers/iio/orientation/hid-sensor-incl-3d.c | 43
1 file changed, 27
iio_val buffer len issue.
- hid-sensor-accel-3d: refine commit message
v2:
- remove unrelated changes.
Ye Xiang (6):
iio: hid-sensor-accel-3d: Add timestamp channel for gravity sensor
iio: hid-sensor-gyro-3d: Add timestamp channel
iio: hid-sensor-als: Add timestamp channel
iio: hid-sensor
Each sample has a timestamp field with this change. This timestamp may
be from the sensor hub when present or local kernel timestamp. And the
unit of timestamp is nanosecond.
Signed-off-by: Ye Xiang
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 48 ---
1 file changed, 30
On Wed, Dec 30, 2020 at 12:05:17PM +, Jonathan Cameron wrote:
> On Tue, 15 Dec 2020 13:44:41 +0800
> Ye Xiang wrote:
>
> > Here we register one iio device with three channels which present angle for
> > hinge, keyboard and screen.
> >
> > This driver works
meaningful return value in
get_known_custom_sensor_index and checked in call side.
- hid-sensor-ids.h: use HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE(x) to
define custom sensor value.
Changes since v1:
- fixed errors reported by lkp
Ye Xiang (3):
HID: hid-sensor-custom: Add custom
Add channel description for hinge sensor, including channel label
attribute and raw data description.
Signed-off-by: Ye Xiang
---
Documentation/ABI/testing/sysfs-bus-iio | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b/Documentation/ABI
, in order to display appropriate user interface.
Signed-off-by: Ye Xiang
---
.../hid-sensors/hid-sensor-attributes.c | 2 +
drivers/iio/position/Kconfig | 16 +
drivers/iio/position/Makefile | 1 +
.../position/hid-sensor-custom-intel-hinge.c | 391
in the report.
This change is identifying hinge sensor when the manufacturer is "INTEL".
This creates a platform device so that a sensor driver can be loaded to
process these sensors.
Signed-off-by: Ye Xiang
---
drivers/hid/hid-sensor-custom.c | 143
inc
On Sun, Dec 13, 2020 at 02:15:45PM +, Jonathan Cameron wrote:
> On Mon, 7 Dec 2020 17:18:18 +0800
> "Ye, Xiang" wrote:
>
> > Hi Jonathan
> >
> > Thanks for review and comments.
> >
> > On Sat, Dec 05, 2020 at 04:05:40PM +, Jonathan
Hi Jonathan
Thanks for review and comments.
On Sat, Dec 05, 2020 at 04:05:40PM +, Jonathan Cameron wrote:
> On Thu, 3 Dec 2020 11:53:52 +0800
> Ye Xiang wrote:
>
> > Add channel description for hinge sensor, including channel label
> > attribute and raw data descrip
Add channel description for hinge sensor, including channel label
attribute and raw data description.
Signed-off-by: Ye Xiang
---
Documentation/ABI/testing/sysfs-bus-iio | 17 +
1 file changed, 17 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b
, in order to display appropriate user interface.
Signed-off-by: Ye Xiang
---
.../hid-sensors/hid-sensor-attributes.c | 2 +
drivers/iio/position/Kconfig | 16 +
drivers/iio/position/Makefile | 1 +
.../position/hid-sensor-custom-intel-hinge.c | 393
in the report.
This change is identifying hinge sensor when the manufacturer is "INTEL".
This creates a platform device so that a sensor driver can be loaded to
process these sensors.
Signed-off-by: Ye Xiang
---
drivers/hid/hid-sensor-custom.c | 181
inc
in
get_known_custom_sensor_index and checked in call side.
- hid-sensor-ids.h: use HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE(x) to
define custom sensor value.
Changes since v1:
- fixed errors reported by lkp
Ye Xiang (3):
HID: hid-sensor-custom: Add custom sensor iio support
iio
On Tue, Nov 24, 2020 at 11:36:56AM +, Jonathan Cameron wrote:
> On Tue, 24 Nov 2020 11:30:50 +0800
> "Ye, Xiang" wrote:
>
> > On Sun, Nov 22, 2020 at 04:50:47PM +, Jonathan Cameron wrote:
> > > On Sun, 22 Nov 2020 15:51:18 +
&
clude "hid-sensor-trigger.h", if not using
> > this cflag-y
> > it should be #include "../common/hid-sensors/hid-sensor-trigger.h"
>
> Even though that looks a bit ugly, I'd prefer that rather than having to
> realize we
> were doing something not entirely obvious in the Makefile.
Okay, will remove ccflags-y in the makefile
Thanks
Ye, Xiang
>
> Thanks,
>
> Jonathan
\
BUILD_BUG_ON(x > 28); \
BUILD_BUG_ON(x < 0); \
(HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_BASE + (x)); \
})
I can use the define with a comments to
On Sat, Nov 21, 2020 at 05:21:27PM +, Jonathan Cameron wrote:
> On Thu, 19 Nov 2020 18:03:28 +0800
> Ye Xiang wrote:
>
> > Currently custom sensors properties are not decoded and it is up to
> > user space to interpret.
> >
> > Some manufacturers already
On Sat, Nov 21, 2020 at 05:56:29PM +, Jonathan Cameron wrote:
> On Thu, 19 Nov 2020 18:03:31 +0800
> Ye Xiang wrote:
>
> > The Hinge sensor is a common custom sensor on laptops. It calculates
> > the angle between the lid (screen) and the base (keyboard). In addition
gt; > > "Pandruvada, Srinivas" wrote:
> > >
> > > > On Sat, 2020-11-21 at 17:46 -0800, Srinivas Pandruvada wrote:
> > > > > On Sat, 2020-11-21 at 17:56 +, Jonathan Cameron wrote:
> > > > > > On Thu, 19 Nov 2020 18:03:31 +0800
> &
in the report.
This change is identifying hinge sensor when the manufacturer is "INTEL".
This creates a platform device so that a sensor driver can be loaded to
process these sensors.
Signed-off-by: Ye Xiang
---
drivers/hid/hid-sensor-custom.c | 170
inc
, in order to display appropriate user interface.
Signed-off-by: Ye Xiang
---
.../hid-sensors/hid-sensor-attributes.c | 2 +
drivers/iio/position/Kconfig | 16 +
drivers/iio/position/Makefile | 3 +
.../iio/position/hid-sensor-custom-hinge.c| 412
ll iio devices.
Signed-off-by: Ye Xiang
---
drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index 30340abcbc8d..bb5e7c
To avoid pm_runtime_disable called repeatedly by hid sensor drivers,
decrease runtime pm enable count after call it.
Signed-off-by: Ye Xiang
---
drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/common/hid
.
Changes since v1:
- fixed errors reported by lkp
Ye Xiang (4):
HID: hid-sensor-custom: Add custom sensor iio support
iio: hid-sensor-trigger: Decrement runtime pm enable count on driver
removal
iio: hid-sensor-trigger: Use iio->trig instead trig field internal
structure
iio:
in the report.
This change is identifying hinge sensor when the manufacturer is "INTEL".
This creates a platform device so that a sensor driver can be loaded to
process these sensors.
Signed-off-by: Ye Xiang
---
drivers/hid/hid-sensor-custom.c | 169
inc
, in order to display appropriate user interface.
Signed-off-by: Ye Xiang
---
.../hid-sensors/hid-sensor-attributes.c | 2 +
drivers/iio/position/Kconfig | 16 +
drivers/iio/position/Makefile | 3 +
.../iio/position/hid-sensor-custom-hinge.c| 412
ll iio devices.
Signed-off-by: Ye Xiang
---
drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index 30340abcbc8d..bb5e7c
To avoid pm_runtime_disable called repeatedly by hid sensor drivers,
decrease runtime pm enable count after call it.
Signed-off-by: Ye Xiang
---
drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/common/hid
.
Ye Xiang (4):
HID: hid-sensor-custom: Add custom sensor iio support
iio: hid-sensor-trigger: Decrement runtime pm enable count on driver
removal
iio: hid-sensor-trigger: Use iio->trig instead trig field internal
structure
iio: hid-sensors: Add hinge sensor driver
drivers/hid/
76 matches
Mail list logo
