RE: [PATCH RFT] platform/x86: intel_pmc_ipc: Convert to use platform_device_register_full

It's good to me, thanks. >+LKML > >Axel, please always include LKML on any patch. > >Qipeng, any concerns? On Sat, Sep 24, 2016 at 11:54:08AM +0800, Axel Lin wrote: > Use platform_device_register_full() instead of open-coded. > > Signed-off-by: Axel Lin > --- >

RE: [PATCH RFT] platform/x86: intel_pmc_ipc: Convert to use platform_device_register_full

It's good to me, thanks. >+LKML > >Axel, please always include LKML on any patch. > >Qipeng, any concerns? On Sat, Sep 24, 2016 at 11:54:08AM +0800, Axel Lin wrote: > Use platform_device_register_full() instead of open-coded. > > Signed-off-by: Axel Lin > --- >

RE: [PATCH] platform:x86 decouple telemetry driver from the optional IPC resources

>> Currently the optional IPC resources prevent telemetry driver from >> probing if these resources are not in ACPI table. This patch decouples >> telemetry driver from these optional resources, so that telemetry >> driver has dependency only on the necessary ACPI resources. >> >>

RE: [PATCH] platform:x86 decouple telemetry driver from the optional IPC resources

>> Currently the optional IPC resources prevent telemetry driver from >> probing if these resources are not in ACPI table. This patch decouples >> telemetry driver from these optional resources, so that telemetry >> driver has dependency only on the necessary ACPI resources. >> >>

RE: [PATCH v6 3/3] mfd: add Intel Broxton Whiskey Cove PMIC driver

> > --- > > change in v6 > > Replace INIT_REGMAP_IRQ with REGMAP_IRQ_REG. > If that's all that has changed my Ack can carry: > Acked-by: Lee Jones > Still no Ack for the regmap side though, so still can't apply. Yes, compare to V5, that's all change for V6. Mark acked patch set 1 for regmap

RE: [PATCH v6 3/3] mfd: add Intel Broxton Whiskey Cove PMIC driver

> > --- > > change in v6 > > Replace INIT_REGMAP_IRQ with REGMAP_IRQ_REG. > If that's all that has changed my Ack can carry: > Acked-by: Lee Jones > Still no Ack for the regmap side though, so still can't apply. Yes, compare to V5, that's all change for V6. Mark acked

RE: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to support Broxton WC PMIC

> > >> > > >> +#define INIT_REGMAP_IRQ(_irq, _off, _mask) \ > > >> +[_irq] = { .reg_offset = (_off), .mask = (_mask) } > > >> + > > > > >No, that's not what I asked. > > > > >Either this macro is going to be useful to *everyone*, or it's probably > > >not useful to

RE: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to support Broxton WC PMIC

> > >> > > >> +#define INIT_REGMAP_IRQ(_irq, _off, _mask) \ > > >> +[_irq] = { .reg_offset = (_off), .mask = (_mask) } > > >> + > > > > >No, that's not what I asked. > > > > >Either this macro is going to be useful to *everyone*, or it's probably > > >not useful to

RE: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to support Broxton WC PMIC

>> >> +#define INIT_REGMAP_IRQ(_irq, _off, _mask) \ >> +[_irq] = { .reg_offset = (_off), .mask = (_mask) } >> + >No, that's not what I asked. >Either this macro is going to be useful to *everyone*, or it's probably not >useful to *anyone*. If it's going to exist, it should exist

RE: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to support Broxton WC PMIC

>> >> +#define INIT_REGMAP_IRQ(_irq, _off, _mask) \ >> +[_irq] = { .reg_offset = (_off), .mask = (_mask) } >> + >No, that's not what I asked. >Either this macro is going to be useful to *everyone*, or it's probably not >useful to *anyone*. If it's going to exist, it should exist

RE: [PATCH v4] mfd: add Intel Broxton Whiskey Cove PMIC driver

> intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o > +intel-soc-pmic-$(CONFIG_INTEL_PMC_IPC) += intel_soc_pmic_bxtwc.o > You want to build this for all Intel products? As intel_soc_pmic_crc driver, this is depend on the option of CONFIG_INTEL_SOC_PMIC, And it's

RE: [PATCH v4] mfd: add Intel Broxton Whiskey Cove PMIC driver

intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o +intel-soc-pmic-$(CONFIG_INTEL_PMC_IPC) += intel_soc_pmic_bxtwc.o You want to build this for all Intel products? As intel_soc_pmic_crc driver, this is depend on the option of CONFIG_INTEL_SOC_PMIC, And it's

RE: [PATCH] regmap: add virtual PMIC IPC bus support

drivers. Best wishes Qipeng -Original Message- From: Mark Brown [mailto:broo...@kernel.org] Sent: Tuesday, May 19, 2015 8:09 PM To: Zha, Qipeng Cc: linux-kernel@vger.kernel.org; Yang, Fei; Zhong, Huiquan; Chen, Jason CJ; Zheng, Qi Subject: Re: [PATCH] regmap: add virtual PMIC IPC bus

RE: [PATCH] regmap: add virtual PMIC IPC bus support

drivers. Best wishes Qipeng -Original Message- From: Mark Brown [mailto:broo...@kernel.org] Sent: Tuesday, May 19, 2015 8:09 PM To: Zha, Qipeng Cc: linux-kernel@vger.kernel.org; Yang, Fei; Zhong, Huiquan; Chen, Jason CJ; Zheng, Qi Subject: Re: [PATCH] regmap: add virtual PMIC IPC bus

RE: [PATCH] regmap: add virtual PMIC IPC bus support

t: Monday, May 18, 2015 7:21 PM To: Zha, Qipeng Cc: linux-kernel@vger.kernel.org; Yang, Fei; Zhong, Huiquan; Chen, Jason CJ; Zheng, Qi Subject: Re: [PATCH] regmap: add virtual PMIC IPC bus support On Mon, May 18, 2015 at 08:10:04AM +0000, Zha, Qipeng wrote: > Hi Broonie > > Ca

RE: [PATCH] regmap: add virtual PMIC IPC bus support

Hi Broonie Can you help comment on this patch ? We do really want to leverage current regmap framework to acess intel pmic devices. So please evaluate this driver, thanks. Best wishes Qipeng -Original Message- From: Zha, Qipeng Sent: Tuesday, April 21, 2015 7:39 AM To: linux-kernel

RE: [PATCH] regmap: add virtual PMIC IPC bus support

Hi Broonie Can you help comment on this patch ? We do really want to leverage current regmap framework to acess intel pmic devices. So please evaluate this driver, thanks. Best wishes Qipeng -Original Message- From: Zha, Qipeng Sent: Tuesday, April 21, 2015 7:39 AM To: linux-kernel

RE: [PATCH] regmap: add virtual PMIC IPC bus support

18, 2015 7:21 PM To: Zha, Qipeng Cc: linux-kernel@vger.kernel.org; Yang, Fei; Zhong, Huiquan; Chen, Jason CJ; Zheng, Qi Subject: Re: [PATCH] regmap: add virtual PMIC IPC bus support On Mon, May 18, 2015 at 08:10:04AM +, Zha, Qipeng wrote: Hi Broonie Can you help comment on this patch

RE: [PATCH] dmaengine: dw: add Intel Broxton LPSS Integrated DMA support

+ dma maillist Best wishes Qipeng -Original Message- From: Zha, Qipeng Sent: Tuesday, April 21, 2015 7:34 AM To: linux-kernel@vger.kernel.org Cc: viresh.li...@gmail.com; andriy.shevche...@linux.intel.com; Westerberg, Mika; Chen, Jason CJ; Zheng, Qi; Zha, Qipeng; Zhong, Huiquan

RE: [PATCH] dmaengine: dw: add Intel Broxton LPSS Integrated DMA support

+ dma maillist Best wishes Qipeng -Original Message- From: Zha, Qipeng Sent: Tuesday, April 21, 2015 7:34 AM To: linux-kernel@vger.kernel.org Cc: viresh.li...@gmail.com; andriy.shevche...@linux.intel.com; Westerberg, Mika; Chen, Jason CJ; Zheng, Qi; Zha, Qipeng; Zhong, Huiquan