Re: [PATCH 6/6] kselftest/arm64: Fix check_user_mem test

2020-10-27 Thread Amit Kachhap
On 10/26/20 5:42 PM, Vincenzo Frascino wrote: The check_user_mem test reports the error below because the test plan is not declared correctly: # Planned tests != run tests (0 != 4) Fix the test adding the correct test plan declaration. This change looks fine and got missed earlier. Acke

Re: [PATCH 3/6] kselftest/arm64: Fix check_child_memory test

2020-10-27 Thread Amit Kachhap
On 10/26/20 5:42 PM, Vincenzo Frascino wrote: The check_child_memory test reports the error below because the test plan is not declared correctly: # Planned tests != run tests (0 != 12) Fix the test adding the correct test plan declaration. This change is required and got missed earlier

Re: [PATCH 5/6] kselftest/arm64: Fix check_ksm_options test

2020-10-27 Thread Amit Kachhap
On 10/26/20 5:42 PM, Vincenzo Frascino wrote: The check_ksm_options test reports the error below because the test plan is not declared correctly: # Planned tests != run tests (0 != 4) Fix the test adding the correct test plan declaration. This change makes sense and got missed earlier. A

Re: [PATCH 4/6] kselftest/arm64: Fix check_mmap_options test

2020-10-27 Thread Amit Kachhap
On 10/26/20 5:42 PM, Vincenzo Frascino wrote: The check_mmap_options test reports the error below because the test plan is not declared correctly: # Planned tests != run tests (0 != 22) Fix the test adding the correct test plan declaration. This change is required and got missed earlier

Re: [PATCH 2/6] kselftest/arm64: Fix check_tags_inclusion test

2020-10-27 Thread Amit Kachhap
On 10/26/20 5:42 PM, Vincenzo Frascino wrote: The check_tags_inclusion test reports the error below because the test plan is not declared correctly: # Planned tests != run tests (0 != 4) Fix the test adding the correct test plan declaration. This change is required and got missed earlie

Re: [PATCH 1/6] kselftest/arm64: Fix check_buffer_fill test

2020-10-27 Thread Amit Kachhap
On 10/26/20 5:42 PM, Vincenzo Frascino wrote: The check_buffer_fill test reports the error below because the test plan is not declared correctly: # Planned tests != run tests (0 != 20) Fix the test adding the correct test plan declaration. This change is required and got missed earlier.

Re: [PATCH 6/6] kselftest/arm64: Check mte tagged user address in kernel

2020-09-23 Thread Amit Kachhap
On 9/22/20 4:11 PM, Catalin Marinas wrote: On Tue, Sep 01, 2020 at 02:57:19PM +0530, Amit Daniel Kachhap wrote: Add a testcase to check that user address with valid/invalid mte tag works in kernel mode. This test verifies the kernel API's __arch_copy_from_user/__arch_copy_to_user works by con

Re: [PATCH v2 1/4] kselftests/arm64: add a basic Pointer Authentication test

2020-09-16 Thread Amit Kachhap
Hi Boyan, On 8/31/20 4:34 PM, Boyan Karatotev wrote: PAuth signs and verifies return addresses on the stack. It does so by inserting a Pointer Authentication code (PAC) into some of the unused top bits of an address. This is achieved by adding paciasp/autiasp instructions at the beginning and en

Re: [PATCH 4/4] kselftests/arm64: add PAuth tests for single threaded consistency and key uniqueness

2020-08-31 Thread Amit Kachhap
Hi, On 8/28/20 6:46 PM, Boyan Karatotev wrote: PAuth adds 5 different keys that can be used to sign addresses. Add a test that verifies that the kernel initializes them uniquely and preserves them across context switches. Cc: Shuah Khan Cc: Catalin Marinas Cc: Will Deacon Signed-off-by: Boy

Re: [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec() changes keys

2020-08-31 Thread Amit Kachhap
On 8/28/20 6:46 PM, Boyan Karatotev wrote: Kernel documentation states that it will change PAuth keys on exec() calls. Verify that all keys are correctly switched to new ones. Cc: Shuah Khan Cc: Catalin Marinas Cc: Will Deacon Signed-off-by: Boyan Karatotev The changes look fine so, Re

Re: [PATCH 2/4] kselftests/arm64: add nop checks for PAuth tests

2020-08-31 Thread Amit Kachhap
On 8/28/20 6:46 PM, Boyan Karatotev wrote: PAuth adds sign/verify controls to enable and disable groups of instructions in hardware for compatibility with libraries that do not implement PAuth. The kernel always enables them if it detects PAuth. Add a test that checks that each group of instr

Re: [PATCH 1/4] kselftests/arm64: add a basic Pointer Authentication test

2020-08-31 Thread Amit Kachhap
Hi Boyan, On 8/28/20 6:46 PM, Boyan Karatotev wrote: PAuth signs and verifies return addresses on the stack. It does so by inserting a Pointer Authentication code (PAC) into some of the unused top bits of an address. This is achieved by adding paciasp/autiasp instructions at the beginning and en

Re: [PATCH v6 2/2] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-07-01 Thread Amit Kachhap
Hi Bhupesh, On 5/14/20 12:22 AM, Bhupesh Sharma wrote: vabits_actual variable on arm64 indicates the actual VA space size, and allows a single binary to support both 48-bit and 52-bit VA spaces. If the ARMv8.2-LVA optional feature is present, and we are running with a 64KB page size; then it is

Re: [PATCH v2 1/2] arm64/crash_core: Export KERNELPACMASK in vmcoreinfo

2020-05-06 Thread Amit Kachhap
Hi, On 5/6/20 6:01 PM, Will Deacon wrote: On Wed, May 06, 2020 at 05:32:56PM +0530, Amit Kachhap wrote: On 5/4/20 10:47 PM, Will Deacon wrote: On Mon, Apr 27, 2020 at 11:55:01AM +0530, Amit Daniel Kachhap wrote: diff --git a/arch/arm64/include/asm/compiler.h b/arch/arm64/include/asm

Re: [PATCH v2 2/2] Documentation/vmcoreinfo: Add documentation for 'KERNELPACMASK'

2020-05-06 Thread Amit Kachhap
Hi, On 5/4/20 11:04 PM, Will Deacon wrote: On Mon, Apr 27, 2020 at 11:55:02AM +0530, Amit Daniel Kachhap wrote: Add documentation for KERNELPACMASK variable being added to the vmcoreinfo. It indicates the PAC bits mask information of signed kernel pointers if Armv8.3-A Pointer Authentication f

Re: [PATCH v2 1/2] arm64/crash_core: Export KERNELPACMASK in vmcoreinfo

2020-05-06 Thread Amit Kachhap
Hi Will, On 5/4/20 10:47 PM, Will Deacon wrote: On Mon, Apr 27, 2020 at 11:55:01AM +0530, Amit Daniel Kachhap wrote: Recently arm64 linux kernel added support for Armv8.3-A Pointer Authentication feature. If this feature is enabled in the kernel and the hardware supports address authentication

Re: [PATCH v2 1/2] arm64/crash_core: Export KERNELPACMASK in vmcoreinfo

2020-04-30 Thread Amit Kachhap
Hi Will/Catalin, Sorry: Resending with correct To list. On 4/27/20 11:55 AM, Amit Daniel Kachhap wrote: Recently arm64 linux kernel added support for Armv8.3-A Pointer Authentication feature. If this feature is enabled in the kernel and the hardware supports address authentication then the retu

Re: [PATCH v2 1/2] arm64/crash_core: Export KERNELPACMASK in vmcoreinfo

2020-04-30 Thread Amit Kachhap
Hi Will/Catalin, On 4/27/20 11:55 AM, Amit Daniel Kachhap wrote: Recently arm64 linux kernel added support for Armv8.3-A Pointer Authentication feature. If this feature is enabled in the kernel and the hardware supports address authentication then the return addresses are signed and stored in th

Re: [PATCH] thermal: samsung: Add TMU support for Exynos3250 SoC

2014-07-09 Thread Amit Kachhap
On Wed, Jul 9, 2014 at 8:30 AM, Chanwoo Choi wrote: > On 07/01/2014 09:33 AM, Chanwoo Choi wrote: >> This patch add registers, bit fields and compatible strings for Exynos3250 >> TMU >> (Thermal Management Unit). Exynos3250 uses the Cortex-A7 dual cores and has >> a target speed of 1.0 GHz. >> >>

Re: [PATCH v1 3/6] thermal: thermal-core: Add notifications support for the cooling states

2014-06-02 Thread Amit Kachhap
On 5/29/14, Javi Merino wrote: > Hi Amit, > > On Thu, May 29, 2014 at 09:15:31AM +0100, Amit Daniel Kachhap wrote: >> This patch adds notification infrastructure for any requests related to >> cooling >> states. The notifier structure passed is of both Get/Set type. So the >> receiver >> of these

Re: [PATCH v1 2/6] thermal: cpu_cooling: Support passing driver private data.

2014-06-02 Thread Amit Kachhap
On 5/29/14, Javi Merino wrote: > Hi Amit, > > One minor comment. > > On Thu, May 29, 2014 at 09:15:30AM +0100, Amit Daniel Kachhap wrote: >> This patch allows the caller of cpufreq cooling APIs to register along >> with their driver data which will be useful while receiving any cooling >> states >

Re: [PATCH v1 6/6] ACPI: thermal: processor: Use the generic cpufreq infrastructure

2014-06-02 Thread Amit Kachhap
Hi Javi, On 5/29/14, Javi Merino wrote: > Hi Amit, > > On Thu, May 29, 2014 at 09:15:34AM +0100, Amit Daniel Kachhap wrote: >> This patch upgrades the ACPI cpufreq cooling portions to use the generic >> cpufreq cooling infrastructure. There should not be any functionality >> related changes as th

Re: [PATCH 00/10] thermal: exynos: various cleanups

2014-05-18 Thread Amit Kachhap
On 5/15/14, Zhang Rui wrote: > On 一, 2014-05-05 at 13:15 +0200, Bartlomiej Zolnierkiewicz wrote: >> Hi, >> >> This patch series contains various cleanups for EXYNOS thermal >> driver. Overall it decreases driver's LOC by 13%. It is based >> on next-20140428 kernel. It should not cause any funct

Re: [PATCH 10/10] thermal: exynos: remove identical values from exynos*_tmu_registers structures

2014-05-18 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > There is no need for abstracting configuration for registers that > are identical on all SoC types. Changes look fine and also that shift and masks may not change in future socs also. Reviewed-by: Amit Daniel Kachhap > > There should be no functional c

Re: [PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()

2014-05-18 Thread Amit Kachhap
Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > pdata->reference_voltage and pdata->gain are always defined > to non-zero values so remove the redundant checks from > exynos_tmu_control(). I prefer to have these checks for the same reason that new soc support should not add these same

Re: [PATCH 08/10] thermal: exynos: cache non_hw_trigger_levels in pdata

2014-05-18 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > Cache number of non-hardware trigger levels in a new pdata field > (non_hw_trigger_levels) and convert code in exynos_tmu_initialize() > accordingly. Changes looks fine, Reviewed-by: Amit Daniel Kachhap > > There should be no functional changes caused

Re: [PATCH 07/10] thermal: exynos: simplify temp_to_code() and code_to_temp()

2014-05-18 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > * Remove dead temp check from temp_to_code() (this function users > in exynos_tmu_initialize() always pass correct temperatures and > exynos_tmu_set_emulation() returns early for EXYNOS4210 because > TMU_SUPPORT_EMULATION flag is not set on this

Re: [PATCH 06/10] thermal: exynos: remove redundant threshold_code checks from exynos_tmu_initialize()

2014-05-18 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > Remove runtime checks for negative return values of temp_to_code() > from exynos_tmu_initialize(). The current level temperature data > hardcoded in pdata will never cause a negative temp_to_code() > return values and for the new code potential mistak

Re: [PATCH 05/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_initialize()

2014-05-18 Thread Amit Kachhap
On 5/15/14, Bartlomiej Zolnierkiewicz wrote: > On Thursday, May 15, 2014 10:47:40 AM Eduardo Valentin wrote: >> Hello Bartlomiej, > > Hi, > >> On Mon, May 05, 2014 at 01:15:34PM +0200, Bartlomiej Zolnierkiewicz >> wrote: >> > Remove runtime checks for pdata sanity from exynos_tmu_initialize(). >>

Re: [PATCH 04/10] thermal: exynos: remove dead code for TYPE_TWO_POINT_TRIMMING calibration

2014-05-18 Thread Amit Kachhap
On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > Only TYPE_ONE_POINT_TRIMMING calibration is used so remove > the dead code for TYPE_TWO_POINT_TRIMMING calibration. I prefer to retain this feature as it is provided by the TMU controller. This will avoid unnecessary churning of code when some new soc

Re: [PATCH 03/10] thermal: exynos: remove dead code for HW_MODE calibration

2014-05-18 Thread Amit Kachhap
Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > There should be no functional changes caused by this patch. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/thermal/samsung/exynos_tmu.c | 33 > +-- > drivers/thermal/samsung/exynos_tmu.h

Re: [PATCH 02/10] thermal: exynos: remove unused defines

2014-05-18 Thread Amit Kachhap
Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > There should be no functional changes caused by this patch. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/thermal/samsung/exynos_tmu_data.h | 27 +-- > 1 file changed, 1 insertion(+), 26 deletion

Re: [PATCH 01/10] thermal: exynos: remove unused struct exynos_tmu_registers entries

2014-05-18 Thread Amit Kachhap
Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > There should be no functional changes caused by this patch. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/thermal/samsung/exynos_tmu.h | 40 > --- > drivers/thermal/samsung/exynos_tmu_da

Re: [PATCH] thermal: samsung: Only update available threshold limits

2014-04-23 Thread Amit Kachhap
On 4/14/14, Tushar Behera wrote: > Currently the threshold limits are updated in 2 stages, once for all > software trigger levels and again for hardware trip point. I guess the first stage is bootloader as could not find this in this file. Anyways the changes looks fine to me. Acked-by: Amit Dani

Re: [PATCH] thermal: EXYNOS: always register TMU driver with core thermal framework

2013-11-25 Thread Amit Kachhap
On 11/25/13, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > Could you please also apply this patch? > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > > On Friday, October 04, 2013 02:38:25 PM Bartlomiej Zolnierkiewicz wrote: >> There is little

Re: [PATCH] thermal: offer Samsung thermal support only when ARCH_EXYNOS is defined

2013-11-25 Thread Amit Kachhap
On 10/4/13, Bartlomiej Zolnierkiewicz wrote: > Menu for Samsung thermal support is visible on all Samsung > platforms while thermal drivers are currently available only > for EXYNOS SoCs. Fix it by replacing PLAT_SAMSUNG dependency > with ARCH_EXYNOS one. > > Signed-off-by: Bartlomiej Zolnierkiewi

Re: [PATCH 03/30] thermal: cpu_cooling: fix kernel_doc for cpufreq_cooling_device

2013-04-21 Thread amit kachhap
On Wed, Apr 17, 2013 at 10:41 PM, Eduardo Valentin wrote: > Simple fixes for making kernel_doc happy about > struct cpufreq_cooling_device. Includes also a minor > spelling fix. > > Cc: Zhang Rui > Cc: linux...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin

Re: [2/9] thermal: exynos: Add support for instance based register/unregister

2013-04-12 Thread amit kachhap
Hi Eduardo, On Fri, Apr 12, 2013 at 1:39 AM, Eduardo Valentin wrote: > Hey Amit, > > > On 26-03-2013 07:33, Amit Daniel Kachhap wrote: >> >> This code modifies the thermal driver to have multiple thermal zone >> support by replacing the global thermal zone varibale with device data > > > s/variba

Re: [1/9] thermal: exynos: Adapt to temperature emulation core thermal framework

2013-04-12 Thread amit kachhap
Hi Eduardo, Thanks for your review comments. On Fri, Apr 12, 2013 at 1:03 AM, Eduardo Valentin wrote: > Hello Amit, > > Couple of comments inline. > > > On 26-03-2013 07:33, Amit Daniel Kachhap wrote: >> >> This removes the driver specific sysfs support of the temperature >> emulation and uses t

Re: [PATCH V4 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-18 Thread amit kachhap
Hi Viresh, On Tue, Mar 12, 2013 at 4:19 PM, Viresh Kumar wrote: > This is what Russell told me a long time back: > "Don't use Adding, Fixing, etc words as this work is not something, which is > already done." > > So your subject should have been: "cpufreq: exynos: Add cpufreq driver > for exynos5

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Viresh, On Sat, Mar 9, 2013 at 4:17 PM, Viresh Kumar wrote: > On 7 March 2013 12:13, Amit Daniel Kachhap wrote: >> diff --git a/drivers/cpufreq/exynos5440-cpufreq.c >> b/drivers/cpufreq/exynos5440-cpufreq.c >> +struct exynos_dvfs_data { >> + void __iomem *base; >> + struct resour

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Russell, On Thu, Mar 7, 2013 at 9:07 PM, Russell King - ARM Linux wrote: > On Thu, Mar 07, 2013 at 04:28:00PM +0100, Sylwester Nawrocki wrote: >> On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: >> > + dvfs_info->cpu_clk = devm_clk_get(dvfs_info->dev, "armclk"); >> > + if (IS_ERR_OR_NULL

Re: [PATCH V3 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-10 Thread amit kachhap
Hi Sylwester, Thanks for the review. Will update with your suggestion in the next version, Thanks, Amit D On Thu, Mar 7, 2013 at 8:58 PM, Sylwester Nawrocki wrote: > On 03/07/2013 05:13 AM, Amit Daniel Kachhap wrote: >> +/* Register definations */ > > s/definations/definitions ok > >> +#define

Re: [PATCH V2 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-05 Thread amit kachhap
Hi Viresh, Again thanks for your review comments. On Tue, Mar 5, 2013 at 6:48 AM, Viresh Kumar wrote: > On 2 March 2013 15:04, Amit Daniel Kachhap wrote: >> This patch adds dvfs support for exynos5440 SOC. This soc has 4 cores and >> they run at same frequency. The nature of exynos5440 clock co

Re: [PATCH V2 2/2] thermal: exynos: Use the framework for temperature emulation support

2013-02-07 Thread amit kachhap
On Thu, Feb 7, 2013 at 7:04 PM, Zhang Rui wrote: > On Mon, 2013-02-04 at 10:14 +0800, Zhang Rui wrote: >> On Sun, 2013-01-27 at 19:28 -0800, Amit Daniel Kachhap wrote: >> > This removes the driver specific sysfs support of the temperature >> > emulation and uses the newly added core thermal framew

Re: [PATCH V2 2/2] thermal: exynos: Use the framework for temperature emulation support

2013-02-07 Thread amit kachhap
Hi Rui, Please merge this patch also. The 1st series of this patchset is already accepted by you. This is just a adaptation of the earlier one and does code cleanup. Thanks, Amit Daniel On Sun, Feb 3, 2013 at 6:14 PM, Zhang Rui wrote: > On Sun, 2013-01-27 at 19:28 -0800, Amit Daniel Kachhap wro

Re: [PATCH] Thermal: fix iteration over CPU frequency list

2013-02-04 Thread amit kachhap
On Thu, Jan 24, 2013 at 7:24 AM, Gu1 wrote: > In different places in the Thermal code, the CPU frequency list is iterated > in an incorrect way, leading to endless loops when the frequency list contains > a CPUFREQ_TABLE_INVALID entry, which is the case by default in the the Exynos > 4x12 cpufreq

Re: [PATCH V2 1/2] thermal: sysfs: Add a new sysfs node emul_temp for thermal emulation

2013-02-03 Thread amit kachhap
On Fri, Feb 1, 2013 at 12:27 AM, Zhang Rui wrote: > On Sun, 2013-01-27 at 19:28 -0800, Amit Daniel Kachhap wrote: >> This patch adds support to set the emulated temperature method in >> thermal zone (sensor). After setting this feature thermal zone may >> report this temperature and not the actual

Re: [PATCH 1/2] thermal: sysfs: Add a new sysfs node emul_temp

2013-01-27 Thread amit kachhap
On Mon, Jan 21, 2013 at 7:20 PM, Zhang Rui wrote: > On Wed, 2013-01-16 at 11:30 -0800, amit kachhap wrote: >> Hi Rui, >> >> Thanks for the review comments, >> On Tue, Jan 15, 2013 at 11:33 PM, Zhang Rui wrote: >> > Hi, Amit, >> > >> > On Sun

Re: [PATCH 1/2] thermal: sysfs: Add a new sysfs node emul_temp

2013-01-16 Thread amit kachhap
Hi Rui, Thanks for the review comments, On Tue, Jan 15, 2013 at 11:33 PM, Zhang Rui wrote: > Hi, Amit, > > On Sun, 2013-01-06 at 16:08 -0800, Amit Daniel Kachhap wrote: >> This patch adds support to set the emulated temperature method in >> thermal zone (sensor). After setting this feature therma

Re: [linux-pm] [PATCH] cpufreq: exynos: Show list of available frequencies

2013-01-08 Thread amit kachhap
On Tue, Jan 8, 2013 at 2:50 AM, Inderpal Singh wrote: > Add freq_attr attribute to show list of available frequencies. > > Signed-off-by: Donggeun Kim > Signed-off-by: MyungJoo Ham > Signed-off-by: KyungMin Park > Signed-off-by: Inderpal Singh > --- > drivers/cpufreq/exynos-cpufreq.c | 13 +

Re: [PATCH 2/5 RESEND] thermal: exynos: Miscellaneous fixes to support falling threshold interrupt

2013-01-08 Thread amit kachhap
Hi Joe, Thanks for the review. Will re-post with your suggestion, On Sun, Jan 6, 2013 at 3:55 PM, Joe Perches wrote: > On Sun, 2013-01-06 at 15:50 -0800, Amit Daniel Kachhap wrote: >> Below fixes are done to support falling threshold interrupt, >> * Falling interrupt status macro corrected accor

Re: [PATCH v4 2/2] therma: exynos: Supports thermal tripping

2012-11-28 Thread Amit Kachhap
On 26 November 2012 07:01, Jonghwan Choi wrote: > TMU urgently sends active-high signal (thermal trip) to PMU, > and thermal tripping by hardware logic i.e PMU is performed. > Thermal tripping means that PMU cut off the whole power of SoC > by controlling external voltage regulator. > > Signed-off

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-22 Thread Amit Kachhap
On 22 November 2012 13:42, Zhang Rui wrote: > On Thu, 2012-11-22 at 10:11 +0530, Amit Kachhap wrote: >> On 22 November 2012 06:52, Zhang Rui wrote: >> > On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: >> >> This modification adds 2 new thermal trend

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-22 Thread Amit Kachhap
On 22 November 2012 06:52, Zhang Rui wrote: > On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: >> This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL >> and THERMAL_TREND_DROP_FULL. This thermal trend can be used to quickly >> jump to the upper or lower cooling le

Re: [PATCH v3 2/2] therma: exynos: Supports thermal tripping

2012-11-22 Thread Amit Kachhap
On 22 November 2012 07:48, wrote: > Hi, > On 2012년 11월 22일 09:43, Jonghwan Choi wrote: >> Hi~ >> >> > data->base + EXYNOS_THD_TEMP_RISE); > @@ -665,6 +672,8 @@ static void exynos_tmu_control(struct >>> platform_device > *pdev, bool on) >

Re: [PATCH v3 1/2] thermal: exynos: Fix wrong bit to control tmu core

2012-11-21 Thread Amit Kachhap
On 20 November 2012 11:23, Zhang Rui wrote: > On Tue, 2012-11-20 at 10:39 +0900, Kyungmin Park wrote: >> On 11/20/12, Jonghwan Choi wrote: >> > [0]bit is used to enable/disable tmu core. [1] bit is a reserved bit. >> > >> > Signed-off-by: Jonghwan Choi >> Acked-by: Kyungmin Park > > Amit and Do

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-08 Thread Amit Kachhap
On 9 November 2012 09:21, Zhang Rui wrote: > On Thu, 2012-11-08 at 11:56 +0530, Amit Kachhap wrote: >> On 8 November 2012 11:31, Zhang Rui wrote: >> > On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: >> >> This modification adds 2 new thermal trend

Re: [PATCH v2 1/2] thermal: exynos: Fix wrong bit to control tmu core

2012-11-08 Thread Amit Kachhap
Hi On 31 October 2012 12:17, Jonghwan Choi wrote: > [0]bit is used to enable/disable tmu core. [1] bit is a reserved bit. > > Signed-off-by: Jonghwan Choi > --- > drivers/thermal/exynos_thermal.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/ex

Re: [PATCH v2 2/2] therma: exynos: Supports thermal tripping

2012-11-08 Thread Amit Kachhap
On 31 October 2012 12:17, Jonghwan Choi wrote: > TMU urgently sends active-high signal (thermal trip) to PMU, > and thermal tripping by hardware logic i.e PMU is performed. > Thermal tripping means that PMU cut off the whole power of SoC > by controlling external voltage regulator. > > Signed-off-

Re: [PATCH v4] Thermal: exynos: Add sysfs node supporting exynos's emulation mode.

2012-11-08 Thread Amit Kachhap
Hi Jonghwa Lee, I tested this patch and it looks good. I have some minor comments below, Reviewed-by: Amit Daniel Kachhap Thanks, Amit Daniel On 2 November 2012 07:54, Jonghwa Lee wrote: > This patch supports exynos's emulation mode with newly created sysfs node. > Exynos 4x12 (4212, 4412) and

Re: [PATCH 1/4] thermal: Add new thermal trend type to support quick cooling

2012-11-07 Thread Amit Kachhap
On 8 November 2012 11:31, Zhang Rui wrote: > On Thu, 2012-11-08 at 09:56 +0530, Amit Daniel Kachhap wrote: >> This modification adds 2 new thermal trend type THERMAL_TREND_RAISE_FULL >> and THERMAL_TREND_DROP_FULL. This thermal trend can be used to quickly >> jump to the upper or lower cooling lev

Re: [PATCH] Thermal: exynos: Add support for temperature falling interrupt.

2012-11-07 Thread Amit Kachhap
Hi Jonghwa Lee, Adding Zhang Rui and Durgadoss. I reviewed and tested this patch. This is a nice feature to have but this will not call the cpufreq cooling device properly as thermal framework calls the frequency states in a step wise fashion which is not possible if we disable polling completely

Re: [PATCH V2 4/6] Thermal: Remove the cooling_cpufreq_list.

2012-10-30 Thread Amit Kachhap
On 26 October 2012 12:39, hongbo.zhang wrote: > From: "hongbo.zhang" > > Problem of using this list is that the cpufreq_get_max_state callback will be > called when register cooling device by thermal_cooling_device_register, but > this list isn't ready at this moment. What's more, there is no nee

Re: [PATCH V2 3/6] Thermal: fix bug of counting cpu frequencies.

2012-10-29 Thread Amit Kachhap
On 24 October 2012 19:04, Viresh Kumar wrote: > On 24 October 2012 17:28, hongbo.zhang wrote: >> From: "hongbo.zhang" >> >> In the while loop for counting cpu frequencies, if table[i].frequency equals >> CPUFREQ_ENTRY_INVALID, index i won't be increased, so this leads to an >> endless >> loop,

Re: [PATCH V2 2/6] Thermal: make sure cpufreq cooling register after cpufreq driver

2012-10-29 Thread Amit Kachhap
On 24 October 2012 17:28, hongbo.zhang wrote: > From: "hongbo.zhang" > > The cpufreq works as a cooling device, so the cooling layer should check if > the > cpufreq driver is initialized or not. > > Signed-off-by: hongbo.zhang > --- > drivers/thermal/cpu_cooling.c | 4 > 1 file changed, 4

Re: [PATCH] thermal: exynos: Fix wrong name of MODULE_DEVICE_TABLE

2012-10-22 Thread Amit Kachhap
On 22 October 2012 16:49, Jonghwan Choi wrote: > exynos4_tmu_driver_ids should be exynos_tmu_driver_ids. > > Signed-off-by: Jonghwan Choi > --- > drivers/thermal/exynos_thermal.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/thermal/exynos_thermal.c > b/d

Re: [PATCH] Thermal: Fix bug on cpu_cooling, cooling device's id conflict problem.

2012-09-26 Thread Amit Kachhap
On 26 September 2012 06:13, Jonghwa Lee wrote: > This patch fixes small bug on cpu_cooling. CPU cooling device has own > id generated with idr mathod. However in the previous version, it swapped > to all same id at last stage of probing as 0. This makes id's collision and > also occures error when

Re: [PATCH -next] thermal: cpu_cooling.c needs to select CPU_FREQ_TABLE

2012-09-13 Thread Amit Kachhap
On 13 September 2012 03:06, Randy Dunlap wrote: > From: Randy Dunlap > > cpu_cooling.c (CONFIG_CPU_THERMAL) uses cpu frequency table > intefaces so it should select CPU_FREQ_TABLE. > Fixes these build errors: > > drivers/built-in.o: In function `cpufreq_get_max_state': > cpu_cooling.c:(.text+0x4e

Re: [linux-pm] [PATCH RESEND] thermal: add generic cpufreq cooling implementation

2012-09-11 Thread amit kachhap
On Mon, Sep 10, 2012 at 3:25 PM, Zhang Rui wrote: > Refreshed to remove the notifier mechanism as we do not have a real user of > it. > if there is no problem, I'll apply the whole patch set to thermal next tree. The removal of notification API looks fine. Thanks for refreshing this. Thanks, Am

Re: [RESEND PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-17 Thread Amit Kachhap
This is repost containing the changes suggested by Zhang Rui. Now the cpufreq current state will be calculated each time instead of earlier way of returning the cached value. Thanks, Amit Daniel On 17 August 2012 18:59, Amit Daniel Kachhap wrote: > This patchset introduces a new generic cooling

Re: [PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-17 Thread Amit Kachhap
On 17 August 2012 12:54, Zhang Rui wrote: > On 四, 2012-08-16 at 17:11 +0530, Amit Daniel Kachhap wrote: >> This patchset introduces a new generic cooling device based on cpufreq >> that can be used on non-ACPI platforms. As a proof of concept, we have >> drivers for the following platforms using

Re: [linux-pm] [PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-16 Thread Amit Kachhap
On 16 August 2012 20:22, Valentin, Eduardo wrote: > > Amit, > > Thanks again for keeping this up. > > On Thu, Aug 16, 2012 at 2:41 PM, Amit Daniel Kachhap > wrote: > > This patchset introduces a new generic cooling device based on cpufreq > > that can be used on non-ACPI platforms. As a proof of

Re: thermal patches in linux-next

2012-08-13 Thread Amit Kachhap
On 10 August 2012 11:21, Zhang Rui wrote: > On 五, 2012-08-10 at 10:37 +0530, Amit Kachhap wrote: >> On 10 August 2012 08:14, Zhang Rui wrote: >> > On 五, 2012-08-10 at 12:23 +1000, Stephen Rothwell wrote: >> >> Hi Rui, >> >> >> >&g

Re: thermal patches in linux-next

2012-08-09 Thread Amit Kachhap
On 10 August 2012 08:14, Zhang Rui wrote: > On 五, 2012-08-10 at 12:23 +1000, Stephen Rothwell wrote: >> Hi Rui, >> >> On Fri, 10 Aug 2012 09:41:06 +0800 Zhang Rui wrote: >> > >> > > > And could you please drop these commits >> > > > ef25a0fe0087963c1611c1c8903886fbea053f76 >> > > > 09ec52fca274ba

Re: thermal patches in linux-next

2012-08-07 Thread Amit Kachhap
Hi, Thanks Rui for creating the next tree. I will rebase my patches on top of your tree and post them shortly. Thanks, Amit Daniel On 7 August 2012 08:23, Zhang Rui wrote: > Hi, all, > > I just created a git tree for catching all thermal changes. > http://git.kernel.org/?p=linux/kernel/git/rzha

Re: [linux-pm] ACPI & Power Management Patches for Linux-3.6-merge - part 1

2012-07-24 Thread Amit Kachhap
On 25 July 2012 09:10, Len Brown wrote: > Here is my initial queue of patches for Linux 3.6. > Please let me know if you see troubles with any of them. Hi Len, I cannot see my patches (V5) http://www.spinics.net/lists/linux-pm/msg27866.html in your list. V4 version was part of your pull request

Re: [PATCH v5 5/5] ARM: exynos: add thermal sensor driver platform data support

2012-07-14 Thread amit kachhap
On Sat, Jul 14, 2012 at 7:03 AM, Kyungmin Park wrote: > On Fri, Jul 13, 2012 at 8:10 PM, Amit Daniel Kachhap > wrote: >> Add necessary default platform data support needed for TMU driver. This >> dt/non-dt values are tested for origen exynos4210 and smdk exynos5250 >> platforms. > Looks good to

Re: [PATCH v4 1/5] thermal: Add generic cpufreq cooling implementation

2012-07-13 Thread amit kachhap
On Fri, Jul 13, 2012 at 3:39 PM, Hongbo Zhang wrote: > > > On 12 May 2012 17:40, Amit Daniel Kachhap wrote: >> >> This patch adds support for generic cpu thermal cooling low level >> implementations using frequency scaling up/down based on the registration >> parameters. Different cpu related coo

Re: [linux-pm] [RESEND PATCH v4 1/5] thermal: add generic cpufreq cooling implementation

2012-07-13 Thread amit kachhap
On Fri, Jul 13, 2012 at 4:34 AM, Andrew Morton wrote: > On Thu, 12 Jul 2012 19:11:04 +0530 > Amit Daniel Kachhap wrote: > >> [a...@linux-foundation.org: fix comment layout] >> Signed-off-by: Amit Daniel Kachhap >> Cc: Donggeun Kim >> Cc: Guenter Roeck >> Cc: SangWook Ju >> Cc: Durgadoss >> C

Re: [linux-pm] [RESEND PATCH v4 1/5] thermal: add generic cpufreq cooling implementation

2012-07-13 Thread amit kachhap
On Thu, Jul 12, 2012 at 8:40 PM, Valentin, Eduardo wrote: > Amit, > > On Thu, Jul 12, 2012 at 4:41 PM, Amit Daniel Kachhap > wrote: >> This patchset introduces a new generic cooling device based on cpufreq >> that can be used on non-ACPI platforms. As a proof of concept, we have >> drivers for t

Re: [PATCH v4 1/5] thermal: Add generic cpufreq cooling implementation

2012-07-11 Thread amit kachhap
On Tue, Jul 10, 2012 at 12:31 PM, Hongbo Zhang wrote: > > > On 12 May 2012 17:40, Amit Daniel Kachhap wrote: >> >> This patch adds support for generic cpu thermal cooling low level >> implementations using frequency scaling up/down based on the registration >> parameters. Different cpu related co

Re: [PATCH v4 1/5] thermal: Add generic cpufreq cooling implementation

2012-07-09 Thread amit kachhap
Hi Rob/Eduardo, As these patches have still not made into mainline. I will rebase the whole set along with your suggestion and send them shortly. Sorry for late reply. Thanks, Amit Daniel On Tue, Jun 26, 2012 at 1:12 PM, Valentin, Eduardo wrote: > Hey Rob and Amit, > > On Tue, Jun 26, 2012 at 6