Re: [PATCH 1/1] scsi: ufs: make UFS Tx lane1 clock optional

Hi Doug, Really thank you for your review. On 2018-10-10 05:56, Doug Anderson wrote: Hi, On Sun, Oct 7, 2018 at 9:34 PM Can Guo wrote: From: Venkat Gopalakrishnan The UFS Tx lane1 clock could be muxed, hence keep it optional by ignoring it if it is not provided in device tree. Thanks

Re: [PATCH 1/1] scsi: ufs: make UFS Tx lane1 clock optional

Hi Doug, Really thank you for your review. On 2018-10-10 05:56, Doug Anderson wrote: Hi, On Sun, Oct 7, 2018 at 9:34 PM Can Guo wrote: From: Venkat Gopalakrishnan The UFS Tx lane1 clock could be muxed, hence keep it optional by ignoring it if it is not provided in device tree. Thanks

Re: [PATCH v9 7/7] dt-bindings: ufshcd-pltfrm: Add core reset string

On 2018-09-27 23:06, Rob Herring wrote: On Thu, Sep 20, 2018 at 09:28:00PM -0700, Can Guo wrote: From: Can Guo Add core reset support string for UFS. Signed-off-by: Amit Nischal Signed-off-by: Can Guo --- Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 7 +++ 1 file changed,

Re: [PATCH v9 7/7] dt-bindings: ufshcd-pltfrm: Add core reset string

On 2018-09-27 23:06, Rob Herring wrote: On Thu, Sep 20, 2018 at 09:28:00PM -0700, Can Guo wrote: From: Can Guo Add core reset support string for UFS. Signed-off-by: Amit Nischal Signed-off-by: Can Guo --- Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 7 +++ 1 file changed,

Re: [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845

On 2018-07-31 18:09, Can Guo wrote: This patch series adds support for UFS QMP PHY on SDM845 and the compatible string for it. This patch series depends on the current proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and

Re: [PATCH v8 0/5] Support for Qualcomm UFS QMP PHY on SDM845

On 2018-07-31 18:09, Can Guo wrote: This patch series adds support for UFS QMP PHY on SDM845 and the compatible string for it. This patch series depends on the current proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1], on the DT bindings for the QMP V3 USB3 PHYs based dirver [2], and

Re: [PATCH v7 3/4] phy: Add QMP phy based UFS phy support for sdm845

On 2018-06-28 04:17, Evan Green wrote: On Tue, Jun 19, 2018 at 1:38 AM Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 173 +++-

Re: [PATCH v7 3/4] phy: Add QMP phy based UFS phy support for sdm845

On 2018-06-28 04:17, Evan Green wrote: On Tue, Jun 19, 2018 at 1:38 AM Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 173 +++-

Re: [PATCH v6 1/3] phy: Update PHY power control sequence

On 2018-06-12 19:34, Vivek Gautam wrote: Hi Can, On 5/29/2018 10:07 AM, Can Guo wrote: All PHYs should be powered on before register configuration starts. And only PCIe PHYs need an extra power control before deasserts reset state. Signed-off-by: Can Guo ---

Re: [PATCH v6 1/3] phy: Update PHY power control sequence

On 2018-06-12 19:34, Vivek Gautam wrote: Hi Can, On 5/29/2018 10:07 AM, Can Guo wrote: All PHYs should be powered on before register configuration starts. And only PCIe PHYs need an extra power control before deasserts reset state. Signed-off-by: Can Guo ---

Re: [PATCH v6 2/3] phy: Add QMP phy based UFS phy support for sdm845

On 2018-06-08 16:10, Vivek Gautam wrote: Hi Can, On 5/29/2018 10:07 AM, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 200 +---

Re: [PATCH v6 2/3] phy: Add QMP phy based UFS phy support for sdm845

On 2018-06-08 16:10, Vivek Gautam wrote: Hi Can, On 5/29/2018 10:07 AM, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 200 +---

Re: [PATCH v6 1/3] phy: Update PHY power control sequence

On 2018-06-08 14:45, Manu Gautam wrote: Hi, On 5/29/2018 10:07 AM, Can Guo wrote: All PHYs should be powered on before register configuration starts. And only PCIe PHYs need an extra power control before deasserts reset state. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c

Re: [PATCH v6 1/3] phy: Update PHY power control sequence

On 2018-06-08 14:45, Manu Gautam wrote: Hi, On 5/29/2018 10:07 AM, Can Guo wrote: All PHYs should be powered on before register configuration starts. And only PCIe PHYs need an extra power control before deasserts reset state. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c

Re: [PATCH v5 1/3] phy: Power on PHY before start Serdes configuration

On 2018-05-24 16:17, Vivek Gautam wrote: Hi Can, On 5/23/2018 9:17 AM, Can Guo wrote: PHYs should be powered on before register configuration starts. Signed-off-by: Can Guo --- Thanks for fixing this. drivers/phy/qualcomm/phy-qcom-qmp.c | 6 ++ 1 file

Re: [PATCH v5 1/3] phy: Power on PHY before start Serdes configuration

On 2018-05-24 16:17, Vivek Gautam wrote: Hi Can, On 5/23/2018 9:17 AM, Can Guo wrote: PHYs should be powered on before register configuration starts. Signed-off-by: Can Guo --- Thanks for fixing this. drivers/phy/qualcomm/phy-qcom-qmp.c | 6 ++ 1 file changed, 6 insertions(+)

Re: [PATCH v5 3/3] dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845

On 2018-05-24 00:13, Rob Herring wrote: On Wed, May 23, 2018 at 11:47:12AM +0800, Can Guo wrote: Update the compatible string for UFS QMP PHY on SDM845. Signed-off-by: Can Guo --- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 4 +++- 1 file changed, 3

Re: [PATCH v5 3/3] dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845

On 2018-05-24 00:13, Rob Herring wrote: On Wed, May 23, 2018 at 11:47:12AM +0800, Can Guo wrote: Update the compatible string for UFS QMP PHY on SDM845. Signed-off-by: Can Guo --- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH v3 1/2] phy: Add QMP phy based UFS phy support for sdm845

On 2018-04-12 13:13, Vivek Gautam wrote: On 4/12/2018 6:27 AM, c...@codeaurora.org wrote: On 2018-04-09 19:28, Vivek Gautam wrote: Hi Can, On 3/27/2018 12:48 PM, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo

Re: [PATCH v3 1/2] phy: Add QMP phy based UFS phy support for sdm845

On 2018-04-12 13:13, Vivek Gautam wrote: On 4/12/2018 6:27 AM, c...@codeaurora.org wrote: On 2018-04-09 19:28, Vivek Gautam wrote: Hi Can, On 3/27/2018 12:48 PM, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo ---  

Re: [PATCH v1] scsi: ufs: add 2 lane support

On 2018-04-02 18:00, Vivek Gautam wrote: Hi Can, On 3/2/2018 1:48 PM, Can Guo wrote: From: Venkat Gopalakrishnan Qcom ufs controller v3.1.0 supports 2 lanes, add support to configure 2 lanes during phy initialization. Signed-off-by: Venkat Gopalakrishnan

Re: [PATCH v1] scsi: ufs: add 2 lane support

On 2018-04-02 18:00, Vivek Gautam wrote: Hi Can, On 3/2/2018 1:48 PM, Can Guo wrote: From: Venkat Gopalakrishnan Qcom ufs controller v3.1.0 supports 2 lanes, add support to configure 2 lanes during phy initialization. Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Subhash Jadavani

Re: [PATCH v3 1/2] phy: Add QMP phy based UFS phy support for sdm845

On 2018-04-09 19:28, Vivek Gautam wrote: Hi Can, On 3/27/2018 12:48 PM, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 130 +---

Re: [PATCH v3 1/2] phy: Add QMP phy based UFS phy support for sdm845

On 2018-04-09 19:28, Vivek Gautam wrote: Hi Can, On 3/27/2018 12:48 PM, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 130 +---

Re: [PATCH v2 2/2] dt-bindings: phy-qcom-qmp: Add UFS phy compitable string for sdm845

On 2018-03-27 06:24, Rob Herring wrote: On Wed, Mar 21, 2018 at 01:37:20PM +0800, Can Guo wrote: Update the compatible string for UFS QMP PHY on SDM845. typo in the subject. Thank you Rob, shall correct it in the next patch series. Thanks Can. Signed-off-by: Can Guo

Re: [PATCH v2 2/2] dt-bindings: phy-qcom-qmp: Add UFS phy compitable string for sdm845

On 2018-03-27 06:24, Rob Herring wrote: On Wed, Mar 21, 2018 at 01:37:20PM +0800, Can Guo wrote: Update the compatible string for UFS QMP PHY on SDM845. typo in the subject. Thank you Rob, shall correct it in the next patch series. Thanks Can. Signed-off-by: Can Guo ---

Re: [PATCH v2 2/2] dt-bindings: phy-qcom-qmp: Add UFS phy compitable string for sdm845

On 2018-03-26 23:00, Vivek Gautam wrote: On 3/21/2018 11:07 AM, Can Guo wrote: Update the compatible string for UFS QMP PHY on SDM845. Signed-off-by: Can Guo --- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH v2 2/2] dt-bindings: phy-qcom-qmp: Add UFS phy compitable string for sdm845

On 2018-03-26 23:00, Vivek Gautam wrote: On 3/21/2018 11:07 AM, Can Guo wrote: Update the compatible string for UFS QMP PHY on SDM845. Signed-off-by: Can Guo --- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 1/2] phy: Add QMP phy based UFS phy support for sdm845

On 2018-03-26 22:56, Vivek Gautam wrote: Hi Can, On 3/21/2018 11:07 AM, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- Thanks for the patch. Just few minor nits, and we are good. Please see comments

Re: [PATCH v2 1/2] phy: Add QMP phy based UFS phy support for sdm845

On 2018-03-26 22:56, Vivek Gautam wrote: Hi Can, On 3/21/2018 11:07 AM, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- Thanks for the patch. Just few minor nits, and we are good. Please see comments inline.

Re: [PATCH v1 1/2] phy: Add QMP phy based UFS phy support for sdm845

On 2018-03-20 19:30, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 120 +++- drivers/phy/qualcomm/phy-qcom-qmp.h | 8 +++ 2 files

Re: [PATCH v1 1/2] phy: Add QMP phy based UFS phy support for sdm845

On 2018-03-20 19:30, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 120 +++- drivers/phy/qualcomm/phy-qcom-qmp.h | 8 +++ 2 files changed, 126

Re: [PATCH v1 0/2] Support for Qualcomm UFS QMP PHY on SDM845

On 2018-03-20 19:30, Can Guo wrote: This patch series adds support for UFS QMP PHY on SDM845 and updates the compitable string for it. Can Guo (2): phy: Add QMP phy based UFS phy support for sdm845 dt-bindings: phy-qcom-qmp: Update UFS phy compitable string for sdm845

Re: [PATCH v1 0/2] Support for Qualcomm UFS QMP PHY on SDM845

On 2018-03-20 19:30, Can Guo wrote: This patch series adds support for UFS QMP PHY on SDM845 and updates the compitable string for it. Can Guo (2): phy: Add QMP phy based UFS phy support for sdm845 dt-bindings: phy-qcom-qmp: Update UFS phy compitable string for sdm845

Re: [PATCH v1 2/2] dt-bindings: phy-qcom-qmp: Update UFS phy binding for sdm845

On 2018-03-20 19:30, Can Guo wrote: Update the compatible string for UFS QMP PHY on SDM845. Signed-off-by: Can Guo --- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v1 2/2] dt-bindings: phy-qcom-qmp: Update UFS phy binding for sdm845

On 2018-03-20 19:30, Can Guo wrote: Update the compatible string for UFS QMP PHY on SDM845. Signed-off-by: Can Guo --- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v1] phy: Add QMP phy based UFS phy support for sdm845.

On 2018-03-20 18:07, Vivek Gautam wrote: Hi Can, On 3/20/2018 1:13 PM, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- Thanks for the patch. Can you please include the dt binding documentation in this

Re: [PATCH v1] phy: Add QMP phy based UFS phy support for sdm845.

On 2018-03-20 18:07, Vivek Gautam wrote: Hi Can, On 3/20/2018 1:13 PM, Can Guo wrote: Add UFS PHY support to make SDM845 UFS work with common PHY framework. Signed-off-by: Can Guo --- Thanks for the patch. Can you please include the dt binding documentation in this patch series and may be

Re: [PATCH] scsi: ufs-qcom: add number of lanes per direction

On 2018-02-09 10:29, Rob Herring wrote: On Mon, Feb 05, 2018 at 08:02:07PM +0800, Can Guo wrote: From: Gilad Broner Different platforms may have different number of lanes for the UFS link. Add parameter to device tree specifying how many lanes should be configured

Re: [PATCH] scsi: ufs-qcom: add number of lanes per direction

On 2018-02-09 10:29, Rob Herring wrote: On Mon, Feb 05, 2018 at 08:02:07PM +0800, Can Guo wrote: From: Gilad Broner Different platforms may have different number of lanes for the UFS link. Add parameter to device tree specifying how many lanes should be configured for the UFS link. And