Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-25 Thread Ching Huang
On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: > On 08/19/2014 09:17 AM, Ching Huang wrote: > > From: Ching Huang > > > > Rewrite ioctl entry and its relate function. > > This patch fix ioctl data read/write error and change data I/O access from > > byt

[PATCH v5 1/2] arcmsr: simplify ioctl data read/write

2014-09-24 Thread Ching Huang
From: Ching Huang This patch is relative to: http://git.infradead.org/users/hch/scsi-queue.git/tree/drivers-for-3.18:/drivers/scsi/arcmsr change in v5: 1. rename firstindex to getIndex, lastindex to putIndex for readability 2. define ARCMSR_API_DATA_BUFLEN as 1032 3. simplify ioctl data read by

Re: [PATCH v5 1/2] arcmsr: simplify ioctl data read/write

2014-09-25 Thread Ching Huang
On Wed, 2014-09-24 at 17:48 +0200, Tomas Henzl wrote: > On 09/24/2014 11:33 AM, Ching Huang wrote: > > From: Ching Huang > > > > This patch is relative to: > > http://git.infradead.org/users/hch/scsi-queue.git/tree/drivers-for-3.18:/drivers/scsi/arcmsr > >

Re: [PATCH v5 1/2] arcmsr: simplify ioctl data read/write

2014-09-25 Thread Ching Huang
On Thu, 2014-09-25 at 19:01 +0200, Christoph Hellwig wrote: > Thanks, applied to drivers-for-3.18. Thanks for all of your review, especially Tomas. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info a

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-14 Thread Ching Huang
On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: > On 09/12/2014 09:29 AM, Ching Huang wrote: > > From: Ching Huang > > > > This patch is to modify previous patch 13/17 and it is relative to > > http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-fo

Re: [PATCH v4 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-14 Thread Ching Huang
On Fri, 2014-09-12 at 16:05 +0200, Tomas Henzl wrote: > On 09/12/2014 10:22 AM, Ching Huang wrote: > > From: Ching Huang > > > > This patch is to modify previous patch 16/17 and it is relative to > > http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-fo

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Ching Huang
On Mon, 2014-09-15 at 12:25 +0200, Tomas Henzl wrote: > On 09/15/2014 04:56 AM, Ching Huang wrote: > > On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote: > >> On 09/12/2014 09:29 AM, Ching Huang wrote: > >>> From: Ching Huang > >>> > >>>

[PATCH v5 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-15 Thread Ching Huang
From: Ching Huang This patch is to modify previous patch 16/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr change since v4: 1. add spin_lock in arcmsr_done4abort_postqueue for protect doneq_index. 2. fix spinlock area in

Re: [PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-15 Thread Ching Huang
On Mon, 2014-09-15 at 13:50 +0200, Tomas Henzl wrote: > On 09/15/2014 12:36 PM, Ching Huang wrote: > > On Mon, 2014-09-15 at 12:25 +0200, Tomas Henzl wrote: > >> On 09/15/2014 04:56 AM, Ching Huang wrote: > >>> On Fri, 2014-09-12 at 15:34 +0200, Tomas Henzl wrote:

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-15 Thread Ching Huang
On Mon, 2014-09-15 at 10:05 -0700, Christoph Hellwig wrote: > On Mon, Sep 15, 2014 at 03:23:36PM +0200, Tomas Henzl wrote: > > Christoph, > > > > you may add my 'reviewed-by' to the arcmsr series > > http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr > > wi

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-26 Thread Ching Huang
On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: > On 08/25/2014 07:59 PM, Ching Huang wrote: > > On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote: > >> On 08/19/2014 09:17 AM, Ching Huang wrote: > >>> From: Ching Huang > >>> > >>> R

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-27 Thread Ching Huang
On Tue, 2014-08-26 at 15:20 +0200, Tomas Henzl wrote: > On 08/26/2014 10:27 PM, Ching Huang wrote: > > On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote: > >> On 08/25/2014 07:59 PM, Ching Huang wrote: > >>> On Fri, 2014-08-22 at 18:00 +0200, Tomas Henzl wrote:

Re: [PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-27 Thread Ching Huang
On Wed, 2014-08-27 at 14:29 +0200, Tomas Henzl wrote: > On 08/27/2014 10:19 PM, Ching Huang wrote: > > On Tue, 2014-08-26 at 15:20 +0200, Tomas Henzl wrote: > >> On 08/26/2014 10:27 PM, Ching Huang wrote: > >>> On Mon, 2014-08-25 at 12:29 +0200, Tomas Henzl wrote:

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-08-28 Thread Ching Huang
On Wed, 2014-08-27 at 16:00 +0200, Tomas Henzl wrote: > On 08/19/2014 09:25 AM, Ching Huang wrote: > > From: Ching Huang > > > > Add code for supporting Areca new Raid adapter ARC12x4 series. > > > > Signed-off-by: Ching Huang > > --- > >

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-10 Thread Ching Huang
On Wed, 2014-09-10 at 11:58 +0200, Tomas Henzl wrote: > On 09/09/2014 06:30 PM, Christoph Hellwig wrote: > > Ching, > > > > do you have a chance to address Thomas second concern below? As > > far as I can tell (Thomas, please correct me) that's the last > > outstanding concern, and I'd really like

Re: [PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-09-11 Thread Ching Huang
On Thu, 2014-09-11 at 16:21 +0200, Tomas Henzl wrote: > On 09/11/2014 05:59 AM, Ching Huang wrote: > > On Wed, 2014-09-10 at 11:58 +0200, Tomas Henzl wrote: > >> On 09/09/2014 06:30 PM, Christoph Hellwig wrote: > >>> Ching, > >>> > >>> do yo

[PATCH v4 1/2] arcmsr: simplify ioctl data read/write

2014-09-12 Thread Ching Huang
From: Ching Huang This patch is to modify previous patch 13/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr change in v4: 1. for readability, rename firstindex to getIndex, rename lastindex to putIndex 2. define

[PATCH v4 2/2] arcmsr: simplify of updating doneq_index and postq_index

2014-09-12 Thread Ching Huang
From: Ching Huang This patch is to modify previous patch 16/17 and it is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/arcmsr-for-3.18:/drivers/scsi/arcmsr change in v4: 1. clean up of duplicate variable declaration in switch. 2. simplify of updating doneq_index and

[PATCH 1/1] arcmsr: Notify has sense data report

2014-11-27 Thread Ching Huang
From: Ching Huang This patch is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/heads/drivers-for-3.18:/drivers/scsi/arcmsr Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we have sense data. Signed-off-by: Ching Huang ---

Re: [PATCH 1/1] arcmsr: Notify has sense data report

2014-11-28 Thread Ching Huang
Thanks to Dan's advice and Hannes' suggestion. I will revise and resubmit it later. On Fri, 2014-11-28 at 12:17 +0300, Dan Carpenter wrote: > On Fri, Nov 28, 2014 at 12:20:44PM +0800, Ching Huang wrote: > > This patch is relative to > > http://git.infradead.org/users/hch

[PATCH 1.1 1/1] arcmsr: Notify has sense data report

2014-11-28 Thread Ching Huang
From: Ching Huang Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we have sense data. Signed-off-by: Ching Huang --- This patch is relative to http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/heads/drivers-for-3.18:/drivers/scsi/a

[PATCH v1.3 0/18] arcmsr: bugfix, new features and support new adapters

2014-08-01 Thread Ching Huang
Hi Christoph, This patches are made against the git://git.infradead.org/users/hch/scsi-queue.git/tree/drivers/scsi/arcmsr/ This patches series address following issues. 1. Bugfix for command timeout, abort and ioctl error. 2. Add new feature of support MSI-X interrupt and system hibernation.

[PATCH v1.3 1/18] arcmsr: Revised interrupt service routine relate function to fix bug

2014-08-01 Thread Ching Huang
This patch rewrite the interrupt service routine relate function to fix command timeout when controller has very heavy loading. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-07-30 10:33:02.

[PATCH v1.3 2/18] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-01 Thread Ching Huang
This patch adds code to support MSI, MSI-X interrupt. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:24:36.

[PATCH v1.3 3/18] arcmsr: Add code to support system hibernation

2014-08-01 Thread Ching Huang
This patch adds code to support system hibernation. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-01 11:03:00.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-01 11:04:28.00

[PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

2014-08-01 Thread Ching Huang
This patch limits the max. number of SCSI command request to avoid command overflow. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:24:06.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h

[PATCH v1.3 5/18] arcmsr: bugfix - return status of abort command

2014-08-01 Thread Ching Huang
This patch fixes the wrong return status of abort command. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-01 11:05:44.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-01 11:0

[PATCH v1.3 6/18] arcmsr: precise checking adapter ID

2014-08-01 Thread Ching Huang
This patch rewrites the arcmsr_define_adapter_type function to precisely check Areca adapter's ID. This can prevent an unknown adapter being used as a default adapter type by driver. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a

Re: [PATCH v1.3 2/18] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-01 Thread Ching Huang
Hi Alexander, Thanks for your advice. This patch was revised according to your comment. Signed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h

[PATCH v2 2/18] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-03 Thread Ching Huang
From: Ching Huang Changes in v2 of 2/18: * remove the checking of capability of MSI-X, MSI. * correct the wrong IRQ vector of request_irq failed. * replace pci_enable_msi_range() by pci_enable_msi_exact(). Signed-off-by: Ching Huang --- Thanks for Dan's advice. diff -uprN a/drivers

Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request

2014-08-03 Thread Ching Huang
On Fri, 2014-08-01 at 05:35 -0700, Christoph Hellwig wrote: > > @@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru > > arcmsr_handle_virtual_command(acb, cmd); > > return 0; > > } > > - if (atomic_read(&acb->ccboutstandingcount) >= > > - A

[PATCH v2 6/18] arcmsr: precise checking adapter ID

2014-08-04 Thread Ching Huang
From: Ching Huang This patch rewrites the arcmsr_define_adapter_type function to precisely check Areca adapter's ID. This can prevent an unknown adapter being used as a default adapter type by driver. Signed-off-by: Ching Huang --- Thanks for Christoph advice. diff -uprN a/drivers

[PATCH v1.3 7/18] arcmsr: revise messages_isr_bh_fn to remove duplicate code

2014-08-04 Thread Ching Huang
From: Ching Huang Revise message_isr_bh_fn to remove the duplicate code for each adapter type. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16:43:16.0 +0800 +++ b

[PATCH v1.3 8/18] arcmsr: remove calling arcmsr_hbb_enable_driver_mode

2014-08-04 Thread Ching Huang
From: Ching Huang Remove calling arcmsr_hbb_enable_driver_mode by in-line code. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16:43:06.0 +0800 +++ b/drivers/scsi/arcmsr

[PATCH v1.3 9/18] arcmsr: modify printing adapter model number and F/W messages

2014-08-04 Thread Ching Huang
From: Ching Huang Adjust printing order of adapter model name and firmware version. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16:44:44.0 +0800 +++ b/drivers/scsi

[PATCH v1.3 10/18] arcmsr: clear outbound doorbell buffer completely

2014-08-04 Thread Ching Huang
From: Ching Huang Clear outbound doorbell buffer completely for adapter type C. This is to prevent getting bad data input from IOP before ioctl command beginning. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers

[PATCH v1.3 11/18] arcmsr: rename function and variable

2014-08-04 Thread Ching Huang
From: Ching Huang Rename some variable and function name for readability and consistency. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:27:14.0 +0800 +++ b/drivers/scsi

[PATCH v1.3 12/18] arcmsr: revise allocation of second dma_coherent_handle for type B adapter

2014-08-04 Thread Ching Huang
From: Ching Huang This modification is for consistency with up-coming adapter type D. They have similar H/W and S/W structure. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:27

[PATCH v1.3 13/18] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-04 Thread Ching Huang
From: Ching Huang Rewrite ioctl entry and its relate functions. This patch fix ioctl data read/write error and change data I/O access from byte to Dword. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c --- a/drivers/scsi

[PATCH v1.3 14/18] arcmsr: fix sparse waring and error

2014-08-04 Thread Ching Huang
From: Ching Huang Fix sparse utility checking error and warning. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16:46:30.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v1.3 15/18] arcmsr: modify some character string

2014-08-04 Thread Ching Huang
From: Ching Huang Revise comment and some character strings. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16:45:46.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014

[PATCH v1.3 16/18] arcmsr: support new adapter ARC12x4 series

2014-08-04 Thread Ching Huang
From: Ching Huang Add code for supporting Areca new Raid adapter ARC12x4 series. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:29:54.0 +0800 +++ b/drivers/scsi/arcmsr

[PATCH v1.3 17/18] arcmsr: modify calling scsi_scan_host after all initialization done

2014-08-04 Thread Ching Huang
From: Ching Huang Modify calling scsi_scan_host until all initialization done. And fix error path of free allocated resource. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16

[PATCH v1.3 18/18] arcmsr: replace flush_scheduled_work() by flush_work()

2014-08-04 Thread Ching Huang
From: Ching Huang To prevent flushing entire workqueue, replace flush_scheduled_work() by flush_work(). Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-04 16:47:02.0 +0800

[PATCH v3 0/17] arcmsr: change note since v13 or v2

2014-08-18 Thread Ching Huang
Change note: 1,5,7~17/17 since v1.3 are not change. 2,3,4/17 since v2 are not change. 6/17 since v2: 1. pre-define adapter_type value in private data of pci_device_id. 2. remove the arcmsr_define_adapter_type function. Ching Huang -- To unsubscribe from this list: send the line "unsubs

[PATCH v3 1/17] arcmsr: Revised interrupt service routine relate function to fix bug

2014-08-18 Thread Ching Huang
From: Ching Huang This patch rewrite the interrupt service routine relate function to fix command timeout when controller has very heavy loading. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h

[PATCH v3 2/17] arcmsr: Add code to support MSI-X, MSI interrupt

2014-08-18 Thread Ching Huang
From: Ching Huang This patch adds code to support MSI, MSI-X interrupt. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-04-28 16:02:46.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h

[PATCH v3 3/17] arcmsr: Add code to support hibernation

2014-08-18 Thread Ching Huang
From: Ching Huang This patch adds code to support system hibernation. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-01 17:54:46.0 +0800 +++ b/drivers/scsi/arcmsr

[PATCH v4 4/17] arcmsr: limit max. number of SCSI command request

2014-08-18 Thread Ching Huang
From: Ching Huang This patch limits the max. number of SCSI commmand request to avoid command overflow. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:24:06.0 +0800 +++ b

Ignore the [PATCH v4 4/17]

2014-08-18 Thread Ching Huang
Please ignore the patch [PATCH v4 4/17], I will resend the patch [PATCH v3 4/17]. Regards, Ching Huang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH v3 4/17] arcmsr: limit max. number of SCSI command request

2014-08-18 Thread Ching Huang
From: Ching Huang This patch limits the max. number of SCSI command request to avoid command overflow. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:24:06.0 +0800 +++ b

[PATCH v3 5/17] arcmsr: bugfix - return status of abort command

2014-08-18 Thread Ching Huang
From: Ching Huang This patch fixed the wrong return status of abort command. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-08 19:35:46.0 +0800 +++ b/drivers/scsi/arcmsr

[PATCH v3 6/17] arcmsr: precise checking adapter ID

2014-08-18 Thread Ching Huang
From: Ching Huang change since v2: 1. This patch pre-define the adapter->type in private data of struct pci_device_id. 2. Remove arcmsr_define_adapter_type function. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/driv

[PATCH v3 7/17] arcmsr: revise message_isr_bh_fn to remove duplicate code

2014-08-19 Thread Ching Huang
From: Ching Huang Revise message_isr_bh_fn to remove the duplicate code for each adapter type. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:36:38.0 +0800 +++ b

[PATCH v3 8/17] arcmsr: remove calling arcmsr_hbb_enable_driver_mode

2014-08-19 Thread Ching Huang
From: Ching Huang Remove calling arcmsr_hbb_enable_driver_mode by in-line code. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:39:06.0 +0800 +++ b/drivers/scsi/arcmsr

[PATCH v3 9/17] arcmsr: modify printing adapter model number and F/W messages

2014-08-19 Thread Ching Huang
From: Ching Huang Adjust printing order of adapter model name and firmware version. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:39:48.0 +0800 +++ b/drivers/scsi

[PATCH v3 10/17] arcmsr: clear outbound doorbell buffer completely

2014-08-19 Thread Ching Huang
From: Ching Huang Clear outbound doorbell buffer completely for adapter type C. This is to prevent getting bad data input from IOP before ioctl command beginning. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers

[PATCH v3 11/17] arcmsr: rename function and variable

2014-08-19 Thread Ching Huang
From: Ching Huang Rename some variable and function name for readability and consistency. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:27:14.0 +0800 +++ b/drivers/scsi

[PATCH v3 12/17] arcmsr: revise allocation of second dma_coherent_handle for type B

2014-08-19 Thread Ching Huang
From: Ching Huang This modification is for consistency with upcoming adapter type D. Both adapter type B and D have similar H/W and S/W structure. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h

[PATCH v3 13/17] arcmsr: fix ioctl data read/write error for adapter type C

2014-08-19 Thread Ching Huang
From: Ching Huang Rewrite ioctl entry and its relate function. This patch fix ioctl data read/write error and change data I/O access from byte to Dword. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c --- a/drivers/scsi

[PATCH v3 14/17] arcmsr: fix sparse warning and error

2014-08-19 Thread Ching Huang
From: Ching Huang Fix sparse utility checking error and warning. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:40:48.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v3 15/17] arcmsr: modify some character string

2014-08-19 Thread Ching Huang
From: Ching Huang Revise comment and some character strings. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18:41:02.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014

[PATCH v3 16/17] arcmsr: support new adapter ARC12x4 series

2014-08-19 Thread Ching Huang
From: Ching Huang Add code for supporting Areca new Raid adapter ARC12x4 series. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-05-06 15:29:54.0 +0800 +++ b/drivers/scsi/arcmsr

[PATCH v3 17/17] arcmsr: modify calling scsi_scan_host after all initialization done

2014-08-19 Thread Ching Huang
From: Ching Huang Modify calling scsi_scan_host until all initialization done. And fix error path of free allocation resource. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-08-14 18

Re: [PATCH v3 0/17] arcmsr: change note since v13 or v2

2014-08-20 Thread Ching Huang
Hi Christoph, Thanks for your effort to fix up errors and apply the patches of arcmsr to a branch. It is great. Regards, Ching Huang On Tue, 2014-08-19 at 08:02 -0700, Christoph Hellwig wrote: > Hi Ching, > > I've fixed up various checkpatch errors and fixed up some descriptions

[PATCH v2 3/17] arcmsr: Add code to support system hibernation

2014-08-08 Thread Ching Huang
From: Ching Huang This patch adds code to support system hibernation. Changes in v2 of 3/17: * merge patch 18/18 to this patch Signed-off-by: Ching Huang --- Thanks to Tomas's advice. diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/a

[PATCH v2 4/17] arcmsr: limit max. number of SCSI command request

2014-08-08 Thread Ching Huang
From: Ching Huang This patch limits the max. number of SCSI command request to avoid command overflow. Changes in v2 4/17: * set the correct host->can_queue value after read adapter's limitation. Signed-off-by: Ching Huang --- Thanks to Tomas's advice. diff -uprN a/driver

Re: [PATCH v2 3/17] arcmsr: Add code to support system hibernation

2014-08-11 Thread Ching Huang
Yes. 18/18 is obsolete. Thanks to Tomas's advice. Ching On Fri, 2014-08-08 at 16:23 +0200, Tomas Henzl wrote: > On 08/08/2014 02:05 PM, Ching Huang wrote: > > From: Ching Huang > > > > This patch adds code to support system hibernation. > > > > Changes in

[PATCH 0/1] scsi: arcmsr: fix warning: right shift count >= width of type

2020-10-06 Thread ching Huang
This patch is against to mkp's 5.10/scsi-staging. 1. fix warning: right shift count >= width of type. ---

PATCH 1/1] scsi: arcmsr: fix warning: right shift count >= width of type

2020-10-06 Thread ching Huang
From: ching Huang Fix warning: right shift count >= width of type. Reported-by: kernel test robot Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index be6fb72..d13d672 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/driv

[PATCH v2 0/2] scsi: arcmsr: fix warning: right shift count >= width of type

2020-10-06 Thread ching Huang
This patch is against to mkp's 5.10/scsi-staging. 1. fix warning: right shift count >= width of type. 2. use round_up() instead of logical operation. ---

[PATCH v2 1/2] scsi: arcmsr: fix warning: right shift count >= width of type

2020-10-06 Thread ching Huang
From: ching Huang Fix warning: right shift count >= width of type. Reported-by: kernel test robot Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index be6fb72..55d85c9 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/driv

[PATCH v2 2/2] scsi: arcmsr: use round_up() instead of logical operation

2020-10-06 Thread ching Huang
From: ching Huang Use round_up() instead of logical operation. Reported-by: Martin K. Petersen Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 55d85c9..1e358d9 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers

[PATCH 0/1] scsi: arcmsr: configure the default SCSI device command timeout value

2020-10-15 Thread ching Huang
This patch is against to mkp's 5.10/scsi-queue. 1. Configure the default SCSI device command timeout value. ---

[PATCH 1/1] scsi: arcmsr: Configure the default SCSI device command timeout value

2020-10-15 Thread ching Huang
From: ching Huang Configure the default SCSI device command timeout value. Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index 5d054d5..0f6abd2 100644 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -83,6 +83,7

[PATCH v3 0/2] scsi: arcmsr: use upper_32_bits() instead of dma_addr_hi32()

2020-10-07 Thread ching Huang
This patch is against to mkp's 5.10/scsi-staging. 1. Use upper_32_bits() instead of dma_addr_hi32(). 2. Use round_up() instead of logical operation. ---

[PATCH v3 1/2] scsi: arcmsr: Use upper_32_bits() instead of dma_addr_hi32()

2020-10-07 Thread ching Huang
From: ching Huang Use upper_32_bits() instead of dma_addr_hi32(). Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index d13d672..55d85c9 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH v3 2/2] scsi: arcmsr: use round_up() instead of logical operation

2020-10-07 Thread ching Huang
From: ching Huang Use round_up() instead of logical operation. Reported-by: Martin K. Petersen Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 55d85c9..1e358d9 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers

[PATCH 0/2] scsi: arcmsr: fix SCSI command timeout on ARC-1886

2021-04-15 Thread ching Huang
This patch is against to mkp's 5.13/scsi-staging. This patch fixed the wrong cdb payload report to IOP, that cause scsi command timeout when scatter-gather count is large than some number. ---

[PATCH 1/2] scsi: arcmsr: fixed the wrong cdb payload report to IOP

2021-04-15 Thread ching Huang
From: ching Huang This patch fixed the wrong cdb payload report to IOP. Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 4b79661..930972c 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c

[PATH 2/2] scsi: arcmsr: update driver version to v1.50.00.04-20210414

2021-04-15 Thread ching Huang
From: ching Huang Update driver version to v1.50.00.04-20210414. Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index 0f6abd2..eb0ef73 100644 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -49,7 +49,7 @@ struct

[PATCH 2/2] scsi: arcmsr: update driver version to v1.50.00.04-20210414

2021-04-15 Thread ching Huang
From: ching Huang Update driver version to v1.50.00.04-20210414. Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index 0f6abd2..eb0ef73 100644 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -49,7 +49,7 @@ struct

Re: [PATCH] scsi: arcmsr: avoid do_gettimeofday

2018-01-22 Thread Ching Huang
On Mon, 2018-01-22 at 00:12 +0100, Arnd Bergmann wrote: > The arcmsr uses its own implementation of time_to_tm(), along with > do_gettimeofday() > to read the current time. While the algoritm used here is fine in principle, > it > suffers from two problems: > > - it assigns the seconds portion o

Re: [PATCH 2/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-22 Thread Ching Huang
On Tue, 2019-01-22 at 10:48 +0300, Dan Carpenter wrote: > On Thu, Jan 17, 2019 at 05:52:28PM +0800, Ching Huang wrote: > > On Thu, 2019-01-17 at 12:16 +0300, Dan Carpenter wrote: > > > On Thu, Jan 17, 2019 at 04:47:07PM +0800, Ching Huang wrote: > > > > On Thu,

Re: [PATCH v2 0/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-22 Thread Ching Huang
On Tue, 2019-01-22 at 21:41 -0500, Martin K. Petersen wrote: > Ching, > > > This patch series are against to mkp's 5.1/scsi-queue. > > Applied to 5.1/scsi-queue. Thank you. > > PS. Your file permissions are odd. I always have to change your diffs > from 755 to 644 before applying. > Thanks Mart

Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-16 Thread Ching Huang
This patch series are against to mkp's 5.1/scsi-queue. 1. Due to dma_zalloc_coherent will be phase out, so use dma_alloc_coherent to replace it. 2. Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2. 3. Update driver version to v1.40.00.10-20190116 ---

[PATCH 1/3] scsi: arcmsr: Use dma_alloc_coherent to replace dma_zalloc_coherent

2019-01-16 Thread Ching Huang
>From Ching Huang Due to dma_zalloc_coherent will be phase out, so use dma_alloc_coherent to replace it. Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 9f85d5a..5736434 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c ++

[PATCH 2/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-16 Thread Ching Huang
>From Ching Huang Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2. Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index a94c513..b98c632 100755 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -508,9 +50

[PATCH 3/3] scsi: arcmsr: Update driver version to v1.40.00.10-20190116

2019-01-16 Thread Ching Huang
>From Ching Huang Update driver version to v1.40.00.10-20190116. Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index b98c632..6033bcc 100755 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -49,7 +49,7 @@ str

[PATCH 0/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-16 Thread Ching Huang
This patch series are against to mkp's 5.1/scsi-queue. 1. Due to dma_zalloc_coherent will be phase out, so use dma_alloc_coherent to replace it. 2. Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2. 3. Update driver version to v1.40.00.10-20190116 ---

Re: [PATCH 2/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-17 Thread Ching Huang
On Thu, 2019-01-17 at 10:59 +0300, Dan Carpenter wrote: > On Thu, Jan 17, 2019 at 11:45:03AM +0800, Ching Huang wrote: > > >From Ching Huang > > > > Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2. > > > > What does this look like from a user perspective?

Re: [PATCH 2/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-17 Thread Ching Huang
On Thu, 2019-01-17 at 12:16 +0300, Dan Carpenter wrote: > On Thu, Jan 17, 2019 at 04:47:07PM +0800, Ching Huang wrote: > > On Thu, 2019-01-17 at 10:59 +0300, Dan Carpenter wrote: > > > On Thu, Jan 17, 2019 at 11:45:03AM +0800, Ching Huang wrote: > > > > >From

[PATCH v2 0/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-17 Thread Ching Huang
This patch series are against to mkp's 5.1/scsi-queue. 1. Due to dma_zalloc_coherent will be phase out, so use dma_alloc_coherent instead. 2. For ACB_ADAPTER_TYPE_B controller, the read/write after hibernate and resume may got 'isr get an illegal ccb command' in log/messages sometimes. This patc

[PATCH v2 1/3] scsi: arcmsr: Use dma_alloc_coherent to replace dma_zalloc_coherent

2019-01-17 Thread Ching Huang
>From Ching Huang Due to dma_zalloc_coherent will be phase out, so use dma_alloc_coherent instead. Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 9f85d5a..5736434 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c ++

[PATCH v2 2/3] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B part 2

2019-01-17 Thread Ching Huang
>From Ching Huang For ACB_ADAPTER_TYPE_B controller, the read/write after hibernate and resume may got 'isr get an illegal ccb command' in log/messages sometimes. This patch fix it. Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/driver

[PATCH v2 3/3] scsi: arcmsr: Update driver version to v1.40.00.10-20190116

2019-01-17 Thread Ching Huang
>From Ching Huang Update driver version to v1.40.00.10-20190116. Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index a94c513..9220bcf 100755 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -49,7 +49,7 @@ str

[PATCH 0/12] scsi: arcmsr: update for ccb structure address can above 4GB

2018-12-19 Thread Ching Huang
>From Ching Huang This patch series are against to mkp's 4.21/scsi-queue. 1. Rename acb structure member roundup_ccbsize to ioqueue_size 2. Rename arcmsr_free_mu to arcmsr_free_io_queue 3. Merge arcmsr_alloc_io_queue to arcmsr_alloc_ccb_pool 4. Update arcmsr_alloc_ccb_pool for cc

[PATCH 1/12] scsi: arcmsr: Rename acb structure member roundup_ccbsize to ioqueue_size

2018-12-19 Thread Ching Huang
>From Ching Huang Rename acb structure member roundup_ccbsize to ioqueue_size Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index 9c397a2..256fe9a 100755 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -73

[PATCH 2/12] scsi: arcmsr: Rename arcmsr_free_mu to arcmsr_free_io_queue

2018-12-19 Thread Ching Huang
>From Ching Huang Rename arcmsr_free_mu to arcmsr_free_io_queue Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index f3a7855..f831c13 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -22

[PATCH 3/12] scsi: arcmsr: Merge arcmsr_alloc_io_queue to arcmsr_alloc_ccb_pool

2018-12-19 Thread Ching Huang
>From Ching Huang Merge arcmsr_alloc_io_queue to arcmsr_alloc_ccb_pool Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index f831c13..e1c75ca 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hb

  1   2   3   >