On Fri, 2020-10-23 at 15:13 +0530, Dwaipayan Ray wrote:
> It is generally preferred that the macros from
> include/linux/compiler_attributes.h are used, unless there
> is a reason not to.
>
> Checkpatch currently checks __attribute__ for each of
checkpatch, no need for capitalization
and
On Fri, 2020-10-23 at 08:08 +0200, Miguel Ojeda wrote:
> On Thu, Oct 22, 2020 at 4:36 AM Joe Perches wrote:
> >
> > Use a more generic form for __section that requires quotes to avoid
> > complications with clang and gcc differences.
>
> I performed vi
On Fri, 2020-10-23 at 02:35 +0530, Aditya wrote:
> On 23/10/20 1:03 am, Joe Perches wrote:
> > On Fri, 2020-10-23 at 00:44 +0530, Aditya wrote:
> > > On 22/10/20 9:40 pm, Joe Perches wrote:
> > > > On Thu, 2020-10-22 at 20:20 +0530, Aditya Srivastava wrote:
>
On Thu, 2020-10-22 at 13:42 -0700, Nick Desaulniers wrote:
> .On Wed, Oct 21, 2020 at 7:36 PM Joe Perches wrote:
> > Use a more generic form for __section that requires quotes to avoid
> > complications with clang and gcc differences.
[]
> > a quick test of x86_64 and s390 w
On Fri, 2020-10-23 at 00:44 +0530, Aditya wrote:
> On 22/10/20 9:40 pm, Joe Perches wrote:
> > On Thu, 2020-10-22 at 20:20 +0530, Aditya Srivastava wrote:
> > > Presence of hexadecimal address or symbol results in false warning
> > > message by checkpatch.pl.
> &
On Thu, 2020-10-22 at 20:49 +0200, Łukasz Stelmach wrote:
> Ignore autogenerated CamelCase-like defines and enum values like
> DRM_MODE_CONNECTOR_Unknown or ETHTOOL_LINK_MODE_Asym_Pause_BIT.
>
> Syggested-by: Joe Perches
> Signed-off-by: Łukasz Stelmach
> ---
> Changes
On Thu, 2020-10-22 at 20:14 +0200, Lukasz Stelmach wrote:
> It was <2020-10-22 czw 04:57>, when Joe Perches wrote:
> > On Thu, 2020-10-22 at 13:01 +0200, Łukasz Stelmach wrote:
> > > Ignore CamelCase constants describing Ethernet link parameters defined
> > >
On Thu, 2020-10-22 at 09:33 +0200, Peter Zijlstra wrote:
> On Wed, Oct 21, 2020 at 11:58:25AM -0700, Joe Perches wrote:
> > Like the __section macro, the __alias macro uses
> > macro # stringification to create quotes around
> > the section name used in the __attribu
On Thu, 2020-10-22 at 20:29 +0530, Dwaipayan Ray wrote:
> On Thu, Oct 22, 2020 at 8:22 PM Dwaipayan Ray wrote:
> > It is generally preferred that the macros from
> > include/linux/compiler_attributes.h are used, unless there
> > is a reason not to.
[]
> I am a bit worried about the code size
On Thu, 2020-10-22 at 20:20 +0530, Aditya Srivastava wrote:
> Presence of hexadecimal address or symbol results in false warning
> message by checkpatch.pl.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3051,7 +3051,10 @@ sub process {
> }
>
> # check
On Thu, 2020-10-22 at 15:59 +0200, Christophe Leroy wrote:
> Hi,
>
> Runnning ./scripts/checkpatch.pl -g HEAD, I get the following error:
>
> Global symbol "$gitroot" requires explicit package name at
> ./scripts/checkpatch.pl line 980.
> Execution of ./scripts/checkpatch.pl aborted due to
On Thu, 2020-10-22 at 19:51 +0530, Aditya wrote:
> > > Alright Sir.
Joe is fine, sir isn't necessary.
> Hi Sir
> I have implemented my solution. Should I send the patch in reply to
> this mail or as a different mail? Also should I label it as v2? I have
> also addressed the
On Thu, 2020-10-22 at 13:01 +0200, Łukasz Stelmach wrote:
> Ignore CamelCase constants describing Ethernet link parameters defined
> in include/uapi/linux/ethtool.h.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -5295,6 +5295,10 @@ sub process {
> #CamelCase
>
ction("foo"))) uses to __section("foo")
even if the __attribute__ has multiple list entry forms.
Conversion done using a script:
Link:
https://lore.kernel.org/lkml/75393e5ddc272dc7403de74d645e6c6e0f4e70eb.ca...@perches.com/2-convert_section.pl
Signed-off-by: Joe Perches
---
On Wed, 2020-10-21 at 14:35 -0700, Linus Torvalds wrote:
> On Wed, Oct 21, 2020 at 2:20 PM Joe Perches wrote:
> > While secure solutions are useful, I really wonder if
> > "George Spelvin" is a real person.
>
> It's not his real name, no, but he's a real person.
&g
On Wed, 2020-10-21 at 13:52 -0700, Marc Plumb wrote:
> As one of the participants, I mostly backed off when Spelvin seemed to
> be more aggressively driving a secure solution.
While secure solutions are useful, I really wonder if
"George Spelvin" is a real person.
On Wed, 2020-10-21 at 12:26 -0700, Joe Perches wrote:
> Perhaps a regex for permissions is good enough
> $line !~ /\b[cbdl-][rwxs-]{9,9}\b/
Maybe not completely correct...
>From info ls:
The file type is one of the following characters:
‘-’
regular fil
On Thu, 2020-10-22 at 00:40 +0530, Aditya wrote:
> On 21/10/20 8:48 pm, Joe Perches wrote:
> > On Wed, 2020-10-21 at 20:31 +0530, Aditya Srivastava wrote:
> > > Presence of hexadecimal address or symbol results in false warning
> > > message by checkpatch.pl.
> &
On Wed, 2020-10-21 at 21:02 +0200, Ard Biesheuvel wrote:
> On Wed, 21 Oct 2020 at 20:58, Joe Perches wrote:
> > Like the __section macro, the __alias macro uses
> > macro # stringification to create quotes around
> > the section name used in the __attribute__.
> >
>
Like the __section macro, the __alias macro uses
macro # stringification to create quotes around
the section name used in the __attribute__.
Remove the stringification and add quotes or a
stringification to the uses instead.
Signed-off-by: Joe Perches
---
There is a script that might
(adding cc's of kernel-mentees and a few checkpatch contributors)
On Wed, 2020-10-21 at 19:54 +0200, Miguel Ojeda wrote:
> On Wed, Oct 21, 2020 at 7:42 PM Nick Desaulniers
> wrote:
> > If you used some of the macros from
> > include/linux/compiler_attributes.h like __section and __aligned, I
> >
On Wed, 2020-10-21 at 23:25 +0530, Aditya wrote:
> Thanks for your feedback. I ran a manual check using this approach
> over v5.6..v5.8.
> The negatives occurring with this approach are for the word 'be'
> (Frequency 5) and 'add'(Frequency 1). For eg.
>
> WARNING:REPEATED_WORD: Possible repeated
On Wed, 2020-10-21 at 22:29 +0530, Dwaipayan Ray wrote:
> Can it be considered that the Hex numbers occur
> mostly in pairs or groups of 8, like "FF" or ""?
>
> I think it might reduce the negative side further.
Maybe. This already looks for pairs.
Combined with your previous patch,
On Wed, 2020-10-21 at 08:28 -0700, Joe Perches wrote:
> On Wed, 2020-10-21 at 08:18 -0700, Joe Perches wrote:
> > I might add that check to the line below where
> > the repeated words are checked against long
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatc
On Wed, 2020-10-21 at 08:18 -0700, Joe Perches wrote:
> I might add that check to the line below where
> the repeated words are checked against long
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3062,6 +3062,7 @@ sub process {
>
>
On Wed, 2020-10-21 at 20:31 +0530, Aditya Srivastava wrote:
> Presence of hexadecimal address or symbol results in false warning
> message by checkpatch.pl.
>
> For example, running checkpatch on commit b8ad540dd4e4 ("mptcp: fix
> memory leak in mptcp_subflow_create_socket()") results in warning:
On Wed, 2020-10-21 at 07:25 +, Vaittinen, Matti wrote:
> Hello Joe & All,
> On Tue, 2020-10-20 at 11:36 -0700, Joe Perches wrote:
> > On Tue, 2020-10-20 at 11:48 +, Vaittinen, Matti wrote:
[]
> > > And for peeps who have not been following - following function
>
On Tue, 2020-10-20 at 11:51 -0700, Nick Desaulniers wrote:
> On Tue, Oct 20, 2020 at 11:42 AM Joe Perches wrote:
> > On Mon, 2020-10-19 at 12:42 -0700, Nick Desaulniers wrote:
> > > We probably should add all 3 to W=2 builds (wrapped in cc-option).
> > > I'
On Mon, 2020-10-19 at 12:42 -0700, Nick Desaulniers wrote:
> On Sat, Oct 17, 2020 at 10:43 PM Greg KH wrote:
> > On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote:
> > > From: Tom Rix
> > >
> > > This is a upcoming change to clean up a new warning treewide.
> > > I am wondering if
On Tue, 2020-10-20 at 11:48 +, Vaittinen, Matti wrote:
> On Tue, 2020-10-20 at 13:07 +0300, Matti Vaittinen wrote:
> > Thanks Tom,
> >
> > On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote:
> > > From: Tom Rix
> > >
> > > A break is not needed if it is preceded by a return
> > >
> >
On Tue, 2020-10-20 at 08:00 +, David Laight wrote:
> From: Joe Perches
> > Sent: 19 October 2020 16:47
> > On Mon, 2020-10-19 at 03:13 +0800, kernel test robot wrote:
> > > Hi Ard,
> > >
> > > First bad commit (maybe != root cause):
> > >
es-ce-glue.c:75: WARNING: Move const after static - use
'static const u8'
#75: FILE: arch/arm/crypto/aes-ce-glue.c:75:
+ static u8 const rcon[] = {
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 12
1 file changed, 12 insertions(+)
diff --git a/scripts/checkpatch.pl
On Mon, 2020-10-19 at 16:40 +, Srinivasan Raju wrote:
> > Overall, there are many magic numbers without comments, this makes it hard
> > to
> > understand the code. Using defines with proper naming helps and for 802.11
> > stuff
> > can use ieee80211_*/IEEE80211_* should be used.
>
> Thanks
On Mon, 2020-10-19 at 10:54 -0500, Gustavo A. R. Silva wrote:
> On 10/19/20 10:21, Joe Perches wrote:
> > On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote:
> > > On 19/10/2020 17:05, t...@redhat.com wrote:
> > > > From: Tom Rix
> > > >
>
On Mon, 2020-10-19 at 03:13 +0800, kernel test robot wrote:
> Hi Ard,
>
> First bad commit (maybe != root cause):
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 9d9af1007bc08971953ae915d88dc9bb21344b53
> commit:
switch/case use of break after a return, goto or break is unnecessary.
There is an existing warning for the return and goto uses, so add
break and a --fix option too.
Signed-off-by: Joe Perches
---
v2: Add break to matched keyword
and change the message to show the matched keyword
On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote:
> On 19/10/2020 17:05, t...@redhat.com wrote:
> > From: Tom Rix
> >
> > A break is not needed if it is preceded by a return or goto
> >
> > Signed-off-by: Tom Rix
> > diff --git a/drivers/net/wireless/intersil/p54/eeprom.c
> >
On Mon, 2020-10-19 at 05:55 -0700, Tom Rix wrote:
> On 10/18/20 1:19 PM, Joe Perches wrote:
> > On Sun, 2020-10-18 at 13:07 -0700, Tom Rix wrote:
> > > I like!
> > []
> > > could add a '|break' here to catch the couple
> > []
> > > break;
> > &
On Mon, 2020-10-19 at 08:47 +0530, Srinivasan Raju wrote:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
Mostly trivial comments:
> diff --git a/drivers/net/wireless/purelifi/chip.c
> b/drivers/net/wireless/purelifi/chip.c
[]
> +int
On Sun, 2020-10-18 at 13:07 -0700, Tom Rix wrote:
> I like!
[]
> could add a '|break' here to catch the couple
[]
> break;
>
> break;
Unfortunately, checkpatch is really stupid and it
wouldn't catch those
cases as there are blank lines
between the existing consecutive break
statements.
It would
switch/case use of break after a return or goto is unnecessary.
There is an existing warning for these uses, so add a --fix option too.
Signed-off-by: Joe Perches
---
For today's next, this would remove ~300 instances like:
case FOO:
return bar;
break
On Sun, 2020-10-18 at 19:59 +0100, Matthew Wilcox wrote:
> On Sat, Oct 17, 2020 at 09:09:28AM -0700, t...@redhat.com wrote:
> > clang has a number of useful, new warnings see
> >
If set, use the environment variable GIT_DIR to change the
default .git location of the kernel git tree.
If GIT_DIR is unset, keep using the current ".git" default.
Signed-off-by: Joe Perches
---
V2: learn to type my own email address...
commit f5f613259f3f ("checkpatch: all
If set, use the environment variable GIT_DIR to change the
default .git location of the kernel git tree.
If GIT_DIR is unset, keep using the current ".git" default.
Signed-off-by: Joe Perches
---
commit f5f613259f3f ("checkpatch: allow not using -f with files that are in
git&q
On Sun, 2020-10-18 at 20:15 +0200, Geert Uytterhoeven wrote:
> Hi Joe,
rehi Geert
> On Sun, Oct 18, 2020 at 6:07 PM Joe Perches wrote:
> > On Sun, 2020-10-18 at 16:03 +0200, Geert Uytterhoeven wrote:
[]
> > > This is now commit f5f613259f3fea81 ("checkpatch: allow not
w warnings of the type:
Andrew, can you pick this up please?
Acked-by: Joe Perches
> WARNING: Possible repeated word: 'git'
>
> For example:
> WARNING: Possible repeated word: 'git'
> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git
>
> So, the pattern "
On Sun, 2020-10-18 at 16:03 +0200, Geert Uytterhoeven wrote:
> Hi Joe,
>
> On Tue, Aug 25, 2020 at 2:12 AM Joe Perches wrote:
> > If a file exists in git and checkpatch is used without the -f
> > flag for scanning a file, then checkpatch will scan the file
> > ass
d_char to ' ' ?
> or perhaps change both start_char and end_char to a ' ' to maintain
> uniformity?
It seems it's fine even back to perl 5.6, so it's fine as is.
cheers, Joe
On Sat, 2020-10-17 at 22:19 +0530, Dwaipayan Ray wrote:
> On Sat, Oct 17, 2020 at 10:03 PM Joe Perches wrote:
> > On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote:
> > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> > >
On Sat, 2020-10-17 at 20:21 +0200, Julia Lawall wrote:
> On Sat, 17 Oct 2020, Joe Perches wrote:
> > On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote:
> > > From: Tom Rix
> > >
> > > This is a upcoming change to clean up a new warning treewide.
>
On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote:
> Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> moved the repeated word test to check for more file types. But after
> this, if checkpatch.pl is run on MAINTAINERS, it generates several
> new warnings of the type:
On Sat, 2020-10-17 at 09:09 -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> This is a upcoming change to clean up a new warning treewide.
> I am wondering if the change could be one mega patch (see below) or
> normal patch per file about 100 patches or somewhere half way by collecting
> early
On Sat, 2020-10-17 at 13:21 +0530, Dwaipayan Ray wrote:
> Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> moved the repeated word test to check for more file types. But after
> this, if checkpatch.pl is run on MAINTAINERS, it generates several
> new warnings of the type:
>
On Sat, 2020-10-17 at 07:25 -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> Remove the trailing error message from the fixed lines
>
> Signed-off-by: Tom Rix
> ---
> v2: fix whitespace
Thanks Tom. Andrew can you pick this up please?
> ---
> scripts/checkpatch.pl | 7 +--
> 1 file
On Sat, 2020-10-17 at 11:32 +0530, Dwaipayan Ray wrote:
> > Why include a + character here?
> >
> Hi,
> I tried it without + first, but then lines like
> "The the repeated word."
> didn't register a warning.
>
> I think checkpatch adds a + to the line when used on
> files. Am not sure but my
On Wed, 2020-10-14 at 11:35 -0700, Joe Perches wrote:
> On Wed, 2020-10-14 at 23:42 +0530, Dwaipayan Ray wrote:
> > On Wed, Oct 14, 2020 at 11:33 PM Joe Perches wrote:
> > > On Wed, 2020-10-14 at 22:07 +0530, Dwaipayan Ray wrote:
> > > > Recently, commit 4f6ad8aa1e
On Fri, 2020-10-16 at 23:33 +0100, Colin King wrote:
> From: Colin Ian King
>
> Don't populate const array filter_ies on the stack but instead
> make it static. Makes the object code smaller by 261 bytes.
>
> Before:
>text data bss dec hex filename
> 21674
On Sat, 2020-10-17 at 10:02 +0530, Dwaipayan Ray wrote:
> On Sat, Oct 17, 2020 at 8:26 AM Joe Perches wrote:
> > On Wed, 2020-10-14 at 11:35 -0700, Joe Perches wrote:
> > > On Wed, 2020-10-14 at 23:42 +0530, Dwaipayan Ray wrote:
> > > > On Wed, Oct 14, 2020
ceeding character
> belongs to the exception list, the warning is avoided.
>
> Link:
> https://lore.kernel.org/linux-kernel-mentees/81b6a0bb2c7b9256361573f7a13201ebcd4876f1.ca...@perches.com/
> Suggested-by: Joe Perches
> Suggested-by: Lukas Bulwahn
> Signed-off-by: Dwaipayan Ray
> -
On Fri, 2020-10-16 at 12:04 +0530, Srinivasan Raju wrote:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
Suggested neatening patch on top of this:
o Use include "usb.h" instead of direct extern
o Prefix purelifi to speed and send_packet_from_data_queue
On Fri, 2020-10-16 at 04:38 +0530, Bhaskar Chowdhury wrote:
> On 16:06 Thu 15 Oct 2020, Joe Perches wrote:
> > On Fri, 2020-10-16 at 04:25 +0530, Bhaskar Chowdhury wrote:
> > > You have all flawed understanding...please stay away ..
> > > if you don't understand som
On Fri, 2020-10-16 at 04:25 +0530, Bhaskar Chowdhury wrote:
> You have all flawed understanding...please stay away ..
> if you don't understand something...
You're funny.
You're wrong, but you're still funny.
On Fri, 2020-10-16 at 04:19 +0530, Bhaskar Chowdhury wrote:
> On 14:10 Thu 15 Oct 2020, Joe Perches wrote:
> > On Thu, 2020-10-15 at 19:24 +0530, Bhaskar Chowdhury wrote:
> > > On 06:38 Thu 15 Oct 2020, Joe Perches wrote:
> > > > On Thu, 2020-10-15 at 18:53
On Wed, 2020-10-14 at 11:49 +0530, Srinivasan Raju wrote:
> This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC
> and LiFi-XL USB devices.
trivia: netdev_ might be better than dev_.
> diff --git a/drivers/net/wireless/purelifi/chip.c
> b/drivers/net/wireless/purelifi/chip.c
[]
> +int
On Thu, 2020-10-15 at 19:24 +0530, Bhaskar Chowdhury wrote:
> On 06:38 Thu 15 Oct 2020, Joe Perches wrote:
> > On Thu, 2020-10-15 at 18:53 +0530, Bhaskar Chowdhury wrote:
> > > Fix the space in the middle in below entry.
> > >
> > > memry||memory
> > []
On Thu, 2020-10-15 at 18:53 +0530, Bhaskar Chowdhury wrote:
> Fix the space in the middle in below entry.
>
> memry||memory
[]
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
[]
> @@ -885,7 +885,7 @@ meetign||meeting
> memeory||memory
> memmber||member
> memoery||memory
> -memry
On Thu, 2020-10-15 at 18:35 +0530, Bhaskar Chowdhury wrote:
> s/memry/memory/p
[]
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
[]
> @@ -885,6 +885,7 @@ meetign||meeting
> memeory||memory
> memmber||member
> memoery||memory
> +memry ||memory
Spaces are not used in these entries.
On Thu, 2020-10-08 at 08:41 +0300, Leon Romanovsky wrote:
> On Wed, Oct 07, 2020 at 07:36:23PM -0700, Joe Perches wrote:
> > A recent commit added a sysfs_emit and sysfs_emit_at to allow various
> > sysfs show functions to ensure that the PAGE_SIZE buffer argument is
> > nev
On Wed, 2020-10-14 at 14:15 -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> Remove the trailing error message from the fixed lines
Hi Tom.
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3393,8 +3393,11 @@ sub process {
>
> # check for adding lines without a newline.
On Wed, 2020-10-14 at 20:48 +, Moore, Robert wrote:
> I'm afraid that the macro does not compile under MSVC:
>
> warning C4067: unexpected tokens following preprocessor directive - expected
> a newline (compiling source file ..\..\source\tools\acpiexec\aetests.c)
>
> It looks like
On Wed, 2020-10-14 at 22:44 +0300, Sergey Shtylyov wrote:
> On 10/14/20 11:35 AM, Joe Perches wrote:
>
> [...]
> > > > > Here are 2 patches against the 'modules-next' branch of Jessica Yu's
> > > > > 'linux.git' repo.
> > > > >
"RMT Load Hit"
>
> tools/perf/builtin-c2c.c | 83 +-----------
> 1 file changed, 18 insertions(+), 65 deletions(-)
Hi Leo:
I ran your patches through some perf c2c tests and it all looks good.
I agree the new format of the "Shared Data Cache Line Table" makes more sense
now. And it still holds together nicely when sorted on local HitMs (-d lcl).
Thank you for doing this.
Joe
Tested-by: Joe Mario
On Wed, 2020-10-14 at 20:32 +0200, Miguel Ojeda wrote:
> On Wed, Oct 14, 2020 at 8:05 PM Joe Perches wrote:
> > Any 'formatting off/on' marker should be tool agnostic.
>
> Agreed, they should have used a compiler-agnostic name for the marker.
It means to me that linux has to inv
On Wed, 2020-10-14 at 23:42 +0530, Dwaipayan Ray wrote:
> On Wed, Oct 14, 2020 at 11:33 PM Joe Perches wrote:
> > On Wed, 2020-10-14 at 22:07 +0530, Dwaipayan Ray wrote:
> > > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> > >
On Wed, 2020-10-14 at 19:45 +0200, Miguel Ojeda wrote:
> - Code that should be specially-formatted should be in a
> clang-format-off section to begin with, so it doesn't count.
clang-format is not the end-all tool.
Any 'formatting off/on' marker should be tool agnostic.
On Wed, 2020-10-14 at 22:07 +0530, Dwaipayan Ray wrote:
> Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> moved the repeated word test to check for more file types. But after
> this, if checkpatch.pl is run on MAINTAINERS, it generates several
> new warnings of the type:
On Wed, 2020-10-14 at 19:26 +0530, Dwaipayan Ray wrote:
> Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> moved the repeated word test to check for more file types. But after
> this, if checkpatch.pl is run on MAINTAINERS, it generates several
> new warnings of the type:
>
On Wed, 2020-10-14 at 11:18 +0300, Sergey Shtylyov wrote:
> Hello!
>
> On 14.10.2020 1:44, Joe Perches wrote:
>
> > > Here are 2 patches against the 'modules-next' branch of Jessica Yu's
> > > 'linux.git' repo.
> > > I'm doing some little refactoring in
On Wed, 2020-10-14 at 09:17 +0200, Lukas Bulwahn wrote:
> $ clang-format-10 --version
> Ubuntu clang-format version
> 10.0.1-++20200928083909+ef32c611aa2-1~exp1~20200928185400.194
>
> $ clang-format-10 --help | grep 'dry-run'
> --dry-run - If set, do not actually make the
On Wed, 2020-10-14 at 08:47 +0200, Lukas Bulwahn wrote:
>
> On Tue, 13 Oct 2020, Joe Perches wrote:
>
> > On Wed, 2020-10-14 at 08:36 +0200, Lukas Bulwahn wrote:
> > > On Tue, 13 Oct 2020, Joe Perches wrote:
> > >
> > > > On Wed, 2020-10-14 at 08:
On Wed, 2020-10-14 at 08:36 +0200, Lukas Bulwahn wrote:
>
> On Tue, 13 Oct 2020, Joe Perches wrote:
>
> > On Wed, 2020-10-14 at 08:21 +0200, Lukas Bulwahn wrote:
> > > What does checkpatch.pl warn about and what does clang-format still warn
> > > about, which is
On Wed, 2020-10-14 at 08:21 +0200, Lukas Bulwahn wrote:
> What does checkpatch.pl warn about and what does clang-format still warn
> about, which is generally accepted okay as style in the kernel?
clang-format doesn't warn at all, it just reformats.
checkpatch using the --in-place can reformat
On Wed, 2020-10-14 at 07:46 +0200, Lukas Bulwahn wrote:
> Just one bigger project example: Comparing clang-format suggestions on
> patches against checkpatch.pl suggestions are fine-tuning both of them to fit
> to
> the actual kernel style.
Eek no.
Mindless use of either tool isn't a great
commit 64fa3aff89785b5a924ce3934f6595c35b4dffee
Author: Sharon Dvir
Date: Wed Aug 17 15:35:09 2016 +0300
iwlwifi: pcie: give a meaningful name to interrupt request
perhaps unintentionally for file:
drivers/net/wireless/intel/iwlwifi/pcie/internal.h
in function static inline const char
On Tue, 2020-10-13 at 23:32 +0300, Sergey Shtylyov wrote:
> Here are 2 patches against the 'modules-next' branch of Jessica Yu's
> 'linux.git' repo.
> I'm doing some little refactoring in module_sig_check()...
>
> [1/2] module: merge repetitive strings in module_sig_check()
> [2/2] module:
On Tue, 2020-10-13 at 19:17 +0200, Pavel Machek wrote:
> On Mon 2020-10-05 19:41:15, Joe Perches wrote:
> > This doesn't seem like a great idea to me.
> >
> > For my system I've got:
> >
> > /sys/devices/platform/Fixed MDIO bus.0/
> > /sys/bus/platfor
On Tue, 2020-10-13 at 22:25 +0300, Jarkko Sakkinen wrote:
> On Tue, Oct 13, 2020 at 08:30:38AM -0700, Joe Perches wrote:
> > On Tue, 2020-10-13 at 13:46 +0300, Jarkko Sakkinen wrote:
> > > Use korg address as the main communications end point. Update the
> > &
On Tue, 2020-10-13 at 13:46 +0300, Jarkko Sakkinen wrote:
> Use korg address as the main communications end point. Update the
> corresponding M-entries.
Maybe add an equivalent entry to .mailmap?
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> -M: Jarkko Sakkinen
> +M: Jarkko Sakkinen
On Tue, 2020-10-13 at 17:43 +0530, Ujjwal Kumar wrote:
> Consider the following case:
> a python script file with '.py' filename extension but without
> a shebang line. Would it be meaningful to allow execute permission
> on such a file?
More the question I think is for a patch to
that file, how
On Tue, 2020-10-13 at 12:06 +0530, Dwaipayan Ray wrote:
> Commit 0c01921e56f9 ("checkpatch: add new warnings to author signoff
> checks.") introduced new checks for author sign off. The format_email
> procedure was modified to add comment blocks to the formatted email. But
> no space was added
commit 4d8e5cd233db ("locking/atomics: Fix scripts/atomic/ script permissions")
set all files in this directory executable.
But this file is an input to those scripts and does not need to be executable.
Signed-off-by: Joe Perches
---
scripts/atomic/atomics.tbl | 0
1 file changed, 0
On Mon, 2020-10-12 at 15:02 -0400, Sasha Levin wrote:
> From: Anant Thazhemadam
>
> [ Upstream commit f45a4248ea4cc13ed50618ff066849f9587226b2 ]
>
> When get_registers() fails in set_ethernet_addr(),the uninitialized
> value of node_id gets copied over as the address.
> So, check the return
On Mon, 2020-10-12 at 13:51 -0400, Mimi Zohar wrote:
> On Wed, 2020-10-07 at 11:27 -0700, Joe Perches wrote:
> > On Wed, 2020-10-07 at 12:02 +0100, Colin King wrote:
> > > An incorrect sizeof is being used, sizeof(*fields) is not correct,
> > > it should be sizeof(**f
On Mon, 2020-10-12 at 19:55 +0200, Borislav Petkov wrote:
> On Mon, Oct 12, 2020 at 10:40:07AM -0700, Joe Perches wrote:
> > Why? I think it unnecessary.
>
> Joe, I'm sick'n'tired of debating with you what needs to happen.
>
> Please forget that patch altogether
Fine
On Mon, 2020-10-12 at 19:31 +0200, Borislav Petkov wrote:
> On Mon, Oct 12, 2020 at 10:17:56AM -0700, Joe Perches wrote:
> > Workie here. This is against -next.
>
> Nevermind - I had an old version in that branch.
>
> What I mind to, however, is:
>
> "
On Mon, 2020-10-12 at 19:15 +0200, Borislav Petkov wrote:
> On Mon, Oct 12, 2020 at 10:09:44AM -0700, Joe Perches wrote:
> > From: Borislav Petkov
> >
> > Instruction opcode bytes spelled using the gas directive .byte should
> > carry a comment above them stating which
the
minimum-supported version by the kernel.
Add a check for that.
Requested-by: Peter Zijlstra
Signed-off-by: Borislav Petkov
Signed-off-by: Joe Perches
---
v4: trivial neatening of $Hex_byte and adding a mechanism to
only emit the message once per patched file (Joe)
scripts/checkpatch.pl
On Mon, 2020-10-12 at 16:16 +0200, Lukas Bulwahn wrote:
> On Mon, 12 Oct 2020, Ujjwal Kumar wrote:
> > On 12/10/20 11:47 am, Joe Perches wrote:
> > > On Mon, 2020-10-12 at 11:19 +0530, Ujjwal Kumar wrote:
> > > > checkpatch.pl checks for invalid EXECUTE_PERMI
On Mon, 2020-10-12 at 19:22 +0530, Ujjwal Kumar wrote:
> On 12/10/20 11:47 am, Joe Perches wrote:
> > On Mon, 2020-10-12 at 11:19 +0530, Ujjwal Kumar wrote:
> > > checkpatch.pl checks for invalid EXECUTE_PERMISSIONS on source
> > > files. The script leverages filen
On Mon, 2020-10-12 at 16:23 +0200, Borislav Petkov wrote:
> From: Borislav Petkov
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -408,6 +408,7 @@ our $Lval = qr{$Ident(?:$Member)*};
> our $Int_type= qr{(?i)llu|ull|ll|lu|ul|l|u};
> our $Binary =
601 - 700 of 21637 matches
Mail list logo
