Re: [PATCH 1/1] sched/fair:Reduce unnecessary check preempt in the sched tick

2021-04-13 Thread jun qian
Peter Zijlstra 于2021年4月13日周二 下午10:24写道: > > On Tue, Apr 13, 2021 at 09:18:42PM +0800, qianjun.ker...@gmail.com wrote: > > From: jun qian > > > > If it has been determined that the current cpu need resched in the > > early stage of for_each_sched_entity, then there i

Re: [PATCH V2 1/1] mm:improve the performance during fork

2021-04-05 Thread jun qian
Andrew Morton 于2021年3月31日周三 下午1:44写道: > > On Mon, 29 Mar 2021 20:36:35 +0800 qianjun.ker...@gmail.com wrote: > > > From: jun qian > > > > In our project, Many business delays come from fork, so > > we started looking for the reason why fork is time-cons

Re: [PATCH 1/1] mm:improve the performance during fork

2020-12-22 Thread jun qian
David Laight 于2020年12月23日周三 上午2:42写道: > > From: qianjun > > Sent: 22 December 2020 12:19 > > > > In our project, Many business delays come from fork, so > > we started looking for the reason why fork is time-consuming. > > I used the ftrace with function_graph to trace the fork, found > > that the

Re: [PATCH 1/1] mm:improve the performance during fork

2020-12-22 Thread jun qian
Souptick Joarder 于2020年12月22日周二 下午11:08写道: > > On Tue, Dec 22, 2020 at 5:49 PM wrote: > > > > From: jun qian > > > > In our project, Many business delays come from fork, so > > we started looking for the reason why fork is time-consuming. > > I used t

Re: [RFC PATCH 4/4] sched, rt: support schedstat for RT sched class

2020-11-19 Thread jun qian
Yafang Shao 于2020年11月19日周四 上午11:55写道: > > We want to measure the latency of RT tasks in our production > environment with schedstat facility, but currently schedstat is only > supported for fair sched class. This patch enable it for RT sched class > as well. > > The schedstat statistics are define

[tip: sched/core] sched/fair: Improve the accuracy of sched_stat_wait statistics

2020-10-29 Thread tip-bot2 for jun qian
The following commit has been merged into the sched/core branch of tip: Commit-ID: b9c88f752268383beff0d56e50d52b8ae62a02f8 Gitweb: https://git.kernel.org/tip/b9c88f752268383beff0d56e50d52b8ae62a02f8 Author:jun qian AuthorDate:Thu, 15 Oct 2020 14:48:46 +08:00 Committer

Re: [PATCH] sched/cputime: correct account of irqtime

2020-10-12 Thread jun qian
Pingfan Liu 于2020年10月12日周一 下午9:54写道: > > __do_softirq() may be interrupted by hardware interrupts. In this case, > irqtime_account_irq() will account the time slice as CPUTIME_SOFTIRQ by > mistake. > > By passing irqtime_account_irq() an extra param about either hardirq or > softirq, irqtime_accou

Re: [PATCH 1/1] sched/fair: Fix the wrong sched_stat_wait time

2020-10-09 Thread jun qian
jun qian 于2020年9月30日周三 下午9:08写道: > > Peter Zijlstra 于2020年9月30日周三 下午5:57写道: > > > > On Wed, Sep 30, 2020 at 05:16:29PM +0800, jun qian wrote: > > > Peter Zijlstra 于2020年9月30日周三 下午4:20写道: > > > > > > > > On Wed, Sep 30, 2020 at 10:47:

Re: [PATCH 1/1] sched/fair: Fix the wrong sched_stat_wait time

2020-09-30 Thread jun qian
Peter Zijlstra 于2020年9月30日周三 下午5:57写道: > > On Wed, Sep 30, 2020 at 05:16:29PM +0800, jun qian wrote: > > Peter Zijlstra 于2020年9月30日周三 下午4:20写道: > > > > > > On Wed, Sep 30, 2020 at 10:47:12AM +0800, qianjun.ker...@gmail.com wrote: > > > > From: jun qian

Re: [PATCH 1/1] sched/fair: Fix the wrong sched_stat_wait time

2020-09-30 Thread jun qian
Peter Zijlstra 于2020年9月30日周三 下午4:20写道: > > On Wed, Sep 30, 2020 at 10:47:12AM +0800, qianjun.ker...@gmail.com wrote: > > From: jun qian > > > > When the sched_schedstat changes from 0 to 1, some sched se maybe > > already in the runqueue, the se->statistics.wai

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-28 Thread jun qian
Peter Zijlstra 于2020年9月28日周一 下午5:20写道: > > On Tue, Sep 15, 2020 at 07:56:09PM +0800, qianjun.ker...@gmail.com wrote: > > From: jun qian > > > > Allow terminating the softirq processing loop without finishing the vectors. > > > > Signed-off-by: jun qian

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-28 Thread jun qian
Frederic Weisbecker 于2020年9月25日周五 上午8:42写道: > > On Thu, Sep 24, 2020 at 05:37:42PM +0200, Thomas Gleixner wrote: > > Subject: softirq; Prevent starvation of higher softirq vectors > [...] > > + /* > > + * Word swap pending to move the not yet handled bits of the previous > > + * run

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-25 Thread jun qian
Thomas Gleixner 于2020年9月24日周四 下午11:37写道: > > On Tue, Sep 15 2020 at 19:56, qianjun kernel wrote: > > > > +#define SOFTIRQ_PENDING_MASK ((1UL << NR_SOFTIRQS) - 1) > > > > +/* > > + * The pending_next_bit is recorded for the next processing order when > > + * the loop is broken. This per cpu variabl

Re: [PATCH V4] Softirq:avoid large sched delay from the pending softirqs

2020-09-14 Thread jun qian
Thomas Gleixner 于2020年7月27日周一 下午11:41写道: > > Qian, > > qianjun.ker...@gmail.com writes: > > /* > > * We restart softirq processing for at most MAX_SOFTIRQ_RESTART times, > > * but break the loop if need_resched() is set or after 2 ms. > > - * The MAX_SOFTIRQ_TIME provides a nice upper bound i

Re: [PATCH V6 1/1] Softirq:avoid large sched delay from the pending softirqs

2020-09-12 Thread jun qian
于2020年9月11日周五 下午11:55写道: > > On Wed, Sep 09, 2020 at 05:09:31PM +0800, qianjun.ker...@gmail.com wrote: > > From: jun qian > > > > When get the pending softirqs, it need to process all the pending > > softirqs in the while loop. If the processing time of each pending

Re: [PATCH V4] Softirq:avoid large sched delay from the pending softirqs

2020-09-09 Thread jun qian
Thomas Gleixner 于2020年7月29日周三 下午8:16写道: > > Qian, > > jun qian writes: > > On Mon, Jul 27, 2020 at 11:41 PM Thomas Gleixner wrote: > >> > + or_softirq_pending(pending << (vec_nr + 1)); > >> > >> To or the value in

Re: [PATCH V4] Softirq:avoid large sched delay from the pending softirqs

2020-07-29 Thread jun qian
On Wed, Jul 29, 2020 at 8:16 PM Thomas Gleixner wrote: > > Qian, > > jun qian writes: > > On Mon, Jul 27, 2020 at 11:41 PM Thomas Gleixner wrote: > >> > + or_softirq_pending(pending << (vec_nr + 1)); > >> > >> To or the

Re: [PATCH V4] Softirq:avoid large sched delay from the pending softirqs

2020-07-28 Thread jun qian
On Mon, Jul 27, 2020 at 11:41 PM Thomas Gleixner wrote: > > Qian, > > qianjun.ker...@gmail.com writes: > > /* > > * We restart softirq processing for at most MAX_SOFTIRQ_RESTART times, > > * but break the loop if need_resched() is set or after 2 ms. > > - * The MAX_SOFTIRQ_TIME provides a nic

Re: [PATCH V4] Softirq:avoid large sched delay from the pending softirqs

2020-07-27 Thread jun qian
On Mon, Jul 27, 2020 at 11:41 PM Thomas Gleixner wrote: > > Qian, > > qianjun.ker...@gmail.com writes: > > /* > > * We restart softirq processing for at most MAX_SOFTIRQ_RESTART times, > > * but break the loop if need_resched() is set or after 2 ms. > > - * The MAX_SOFTIRQ_TIME provides a nic

Re: [Softirq] a76eadba0d: WARNING:at_net/mac80211/rx.c:#ieee80211_rx_napi[mac80211]

2020-07-23 Thread jun qian
On Thu, Jul 23, 2020 at 10:35 PM Thomas Gleixner wrote: > > jun qian writes: > > On Thu, Jul 23, 2020 at 6:58 PM Thomas Gleixner wrote: > >> That drops everything which has not yet been processed and the above > >> warning is due to this. > >> > >

Re: [PATCH V3] Softirq:avoid large sched delay from the pending softirqs

2020-07-23 Thread jun qian
On Thu, Jul 23, 2020 at 9:41 PM Thomas Gleixner wrote: > > qianjun.ker...@gmail.com writes: > > From: jun qian > > + /* > > + * the softirq's action has been running for too much time > > + * so

Re: [Softirq] a76eadba0d: WARNING:at_net/mac80211/rx.c:#ieee80211_rx_napi[mac80211]

2020-07-23 Thread jun qian
On Thu, Jul 23, 2020 at 6:58 PM Thomas Gleixner wrote: > > kernel test robot writes: > > [ 106.856151] WARNING: CPU: 5 PID: 4569 at net/mac80211/rx.c:4708 > > ieee80211_rx_napi+0x44d/0x560 [mac80211] > > Bah. I clearly should have noticed when looking at the patch. > > pending = softirq_pe

Re: [RFC PATCH v2] Softirq:avoid large sched delay from the pending softirqs

2020-07-22 Thread jun qian
On Thu, Jul 23, 2020 at 2:05 AM Thomas Gleixner wrote: > > qianjun.ker...@gmail.com writes: > > + > > + end = ktime_get(); > > + delta = ktime_to_us(end - start); > > What's the point of this conversion? That's a division for no value > because you can simply define the max

Re: [PATCH] perf-c2c: Fix the wrong description.

2020-07-21 Thread jun qian
On Thu, Jul 9, 2020 at 9:07 PM qianjun wrote: > > From: qianjun > > Use L1Miss to replace L1Hit to describe the correct scene > > Signed-off-by: qianjun > --- > tools/perf/Documentation/perf-c2c.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Documentatio

Re: [RFC PATCH v2] Softirq:avoid large sched delay from the pending softirqs

2020-07-21 Thread jun qian
Hi Peter & Uladzislau Are there any issues that have not been considered in this patch? Can you give me some suggestions on this issue. If the situation I described is indeed a problem,how about this modification. Thanks a lot. On Mon, Jul 20, 2020 at 9:09 PM wrote: > > From: jun qian

Re: [RFC PATCH 1/1] Softirq:avoid large sched delay from the pending softirqs

2020-07-20 Thread jun qian
On Sat, Jul 18, 2020 at 6:07 AM Uladzislau Rezki wrote: > > > From: jun qian > > > > When get the pending softirqs, it need to process all the pending > > softirqs in the while loop. If the processing time of each pending > > softirq is need more than 2 msec in

[PATCH] mm:slab: Adjust the print format for the slabinfo

2018-10-01 Thread jun qian
Header and the corresponding information is not aligned, adjust the printing format helps us to understand the slabinfo better. Signed-off-by: jun qian Cc: Barry song <21cn...@gmail.com> --- mm/slab_common.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff -

[PATCH] i2c: i2c-tegra: replace spin_lock_irqsave with spin_lock in ISR

2018-09-11 Thread jun qian
As you are already in ISR, it is unnecessary to call spin_lock_irqsave. Signed-off-by: jun qian --- drivers/i2c/busses/i2c-tegra.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 60c8561fbe65

[PATCH] mmc: mxcmmc: replace spin_lock_irqsave with spin_lock in ISR

2018-09-11 Thread jun qian
As you are already in ISR, it is unnecessary to call spin_lock_irqsave. Signed-off-by: jun qian --- drivers/mmc/host/mxcmmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c index de4e6e5bf304..4d17032d15ee 100644

[PATCH] dmaengine: idma64: replace spin_lock_irqsave with spin_lock in ISR

2018-09-11 Thread jun qian
As you are already in ISR, it is unnecessary to call spin_lock_irqsave. Signed-off-by: jun qian Cc: Barry song <21cn...@gmail.com> --- drivers/dma/idma64.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c index 1fbf9c

[PATCH] dmaengine: zx-dma: replace spin_lock_irqsave with spin_lock in ISR

2018-09-11 Thread jun qian
As you are already in ISR, it is unnecessary to call spin_lock_irqsave. Signed-off-by: jun qian Cc: Barry song <21cn...@gmail.com> --- drivers/dma/zx_dma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c index 2571bc

[PATCH] dmaengine: k3dma: replace spin_lock_irqsave with spin_lock in ISR

2018-09-11 Thread jun qian
As you are already in ISR, it is unnecessary to call spin_lock_irqsave. Signed-off-by: jun qian Cc: Barry song <21cn...@gmail.com> --- drivers/dma/k3dma.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c index 6bfa21

[PATCH] dmaengine: moxart-dma: replace spin_lock_irqsave with spin_lock in ISR

2018-09-11 Thread jun qian
As you are already in ISR, it is unnecessary to call spin_lock_irqsave. Signed-off-by: jun qian Cc: Barry song <21cn...@gmail.com> --- drivers/dma/moxart-dma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c

[PATCH] drivers:s390:char:move spin_lock_bh to spin_lock in tasklet

2018-09-07 Thread jun qian
As you are already in a tasklet, it is unnecessary to call spin_lock_bh. Signed-off-by: jun qian Cc: Barry song <21cn...@gmail.com> --- drivers/s390/char/tty3270.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s390/char/tty3270.c b/drivers/s390/char/tty

[PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr

2018-08-27 Thread jun qian
Before the program enters the uart ISR, the local interrupt has been disabled by the system, so it's not appropriate to use spin_lock_irqsave interface in the ISR. Signed-off-by: jun qian --- drivers/tty/serial/imx.c | 21 - 1 file changed, 8 insertions(+), 13 dele