[PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code

From: Rickard Strandqvist Removes unnecessary code that does not do anything useful. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |8 +--- 1 file changed, 1 insertion(+),

[PATCH 11/13] staging: rtl8188eu: HalPhyRf_8188e.c: Remove unnecessary comments

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 37 1 file changed, 6 insertions(+), 31 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c index 5afaad2..c951616

[PATCH 07/13] staging: rtl8188eu: Remove unused function _rtw_write_mem()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_io.c | 14 -- drivers/staging/rtl8188eu/hal/usb_ops_linux.c|1 - drivers/staging/rtl8188eu/include/rtw_io.h |5 - drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |4 4

[PATCH 08/13] staging: rtl8188eu: Remove unused function declaration and macro

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/rtw_io.h |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_io.h b/drivers/staging/rtl8188eu/include/rtw_io.h index 958fc52..e30b84b 100644 --- a/drivers/staging/rtl8188eu/include

[PATCH 05/13] staging: rtl8188eu: Remove unused struct intf_priv

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_intf.h | 33 1 file changed, 33 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_intf.h b/drivers/staging/rtl8188eu/include/osdep_intf.h index a5b3bd3..523141a 100644 --- a

[PATCH 03/13] staging: rtl8188eu: Remove rtw_init_intf_priv()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index f874270..a84ee97 100644 --- a

[PATCH 02/13] staging: rtl8188eu: Remove rtw_deinit_intf_priv()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index c2e5276..f874270 100644 --- a/drivers

[PATCH 04/13] staging: rtl8188eu:Move rtw_hw_[suspend,resume]() to rtw_pwrctrl.c

rtw_hw_[suspend,resume]() functions are used only in rtw_pwrctrl.c, so move these functions there. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 103 drivers/staging/rtl8188eu/include/osdep_intf.h |2 - drivers/staging/rtl8188eu

[PATCH 03/26] staging: rtl8188eu: Remove header file rtw_version.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_debug.c |1 - drivers/staging/rtl8188eu/include/rtw_debug.h |2 +- drivers/staging/rtl8188eu/include/rtw_version.h |1 - drivers/staging/rtl8188eu/os_dep/ioctl_linux.c |1 - drivers/staging/rtl8188eu

[PATCH 22/26] staging: rtl8188eu:Remove EepromAddressSize from struct adapter

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |3 --- drivers/staging/rtl8188eu/include/drv_types.h |1 - 2 files changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index

[PATCH 24/26] staging: rtl8188eu: Remove bCardDisableWOHSM from struct adapter

driver doesn't use value stored in bCardDisableWOHSM. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c |1 - drivers/staging/rtl8188eu/include/drv_types.h |1 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |4 3 files changed, 6 deletions(-)

[PATCH 26/26] staging: rtl8188eu: Remove function with empty defination()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_br_ext.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_br_ext.c b/drivers/staging/rtl8188eu/core/rtw_br_ext.c index 3f602bc..70b8f07 100644 --- a/drivers/staging

[PATCH 20/26] staging: rtl8188eu: Remove hal_data_sz from struct adapter

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |1 - drivers/staging/rtl8188eu/include/drv_types.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 141f85a

[PATCH 19/26] staging: rtl8188eu: Remove unused function rtl8188e_clone_haldata()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |5 - drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 - 2 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal

[PATCH 25/26] staging: rtl8188eu: Remove unused function nat25_handle_frame()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile | 32 ++--- drivers/staging/rtl8188eu/core/rtw_br_ext.c| 61 drivers/staging/rtl8188eu/include/recv_osdep.h |1 - 3 files changed, 16 insertions(+), 78 deletions(-) diff

[PATCH 23/26] staging: rtl8188eu: Remove pbuddy_adapter from struct adapter

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 19 --- drivers/staging/rtl8188eu/include/drv_types.h |1 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |4 3 files changed, 24 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH 21/26] staging: rtl8188eu: Remove unused member variable of struct adapter

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index 9cdab6a..a459206 100644 --- a/drivers/staging

[PATCH 15/26] staging: rtl8188eu: Remove unused enum _ADAPTER_TYPE

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index 7586de71..f7db553 100644 --- a/drivers/staging

[PATCH 18/26] staging: rtl8188eu: Remove DriverState from struct adapter

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index 5fa2e17..de3b70c 100644 --- a/drivers/staging/rtl8188eu

[PATCH 17/26] staging: rtl8188eu: Remove enum driver_state

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |6 -- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 10 -- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging

[PATCH 13/26] staging: rtl8188eu: Remove usb_suspend_sema from struct dvobj_priv

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |1 - drivers/staging/rtl8188eu/os_dep/usb_intf.c |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index

[PATCH 16/26] staging: rtl8188eu: Remove unused enum _IFACE_TYPE

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index f7db553..9195cf3 100644 --- a/drivers/staging/rtl8188eu

[PATCH 14/26] staging: rtl8188eu: Remove usb_alloc_vendor_req_buf from struct dvobj_priv

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |1 - drivers/staging/rtl8188eu/os_dep/usb_intf.c | 17 + 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging

[PATCH 10/26] staging: rtl8188eu: Remove unused stucture defination struct specific_device_id

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index f40db1a..8cbdab5 100644 --- a/drivers/staging/rtl8188eu

[PATCH 12/26] staging: rtl8188eu: Remove unused members of struct dvobj_priv

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index d38f861..3181418 100644 --- a/drivers/staging/rtl8188eu

[PATCH 08/26] staging: rtl8188eu: Use module_usb_driver() macro

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index d33aeb9..21bf74d 100644 --- a

[PATCH 09/26] staging: rtl8188eu: Remove function declarations in usb_intf.c

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 28 ++- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index 21bf74d..45d2608

[PATCH 07/26] staging: rtl8188eu: Remove struct rtw_usb_drv

struct rtw_usb_drv contains only one member usb_driver structure, so no use of keeping it. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH 05/26] staging: rtl8188eu: Use unregistering flag from struct usb_interface

Use unregistering flag from struct usb_interface to find driver registration status. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging

[PATCH 11/26] staging: rtl8188eu: Remove unused enum

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/drv_types.h b/drivers/staging/rtl8188eu/include/drv_types.h index 8cbdab5..d38f861 100644 --- a/drivers/staging/rtl8188eu

[PATCH 04/26] staging: rtl8188eu: Remove hw_init_mutex from struct rtw_usb_drv

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/drv_types.h |2 +- drivers/staging/rtl8188eu/os_dep/os_intfs.c |6 -- drivers/staging/rtl8188eu/os_dep/usb_intf.c |6 +- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging

[PATCH 06/26] staging : rtl8188eu: Remove drv_registered from struct rtw_usb_drv

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index 1841d54..c99b9c2 100644 --- a/drivers/staging/rtl8188eu/os_dep

[PATCH 02/26] staging :rtl8188eu: Remove HalPhyRf.[h|c] files.

Move ODM_GetRightChnlPlaceforIQK() from HalPhyRf.c to HalPhyRf_8188e.c. Move ODM_TARGET_CHNL_NUM_2G_5G from HalPhyRf.h to HalPhyRf_8188e.h. After the movement of function and macro HalPhyRf.[h|c] files are redundant. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile

[PATCH 01/26] staging: rtl8188eu: Remove function with empty defination ODM_ResetIQKResult()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalPhyRf.c |8 drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |2 -- drivers/staging/rtl8188eu/include/HalPhyRf.h |2 -- 3 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH 18/18] staging: rtl8188eu: Remove usb_vendor_req.h header file

driver doesn't need usb_vendor_req.h. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/usb_osintf.h |1 - drivers/staging/rtl8188eu/include/usb_vendor_req.h | 52 drivers/staging/rtl8188eu/os_dep/usb_intf.c|1 - 3 files change

[PATCH 17/18] staging: rtl8188eu: Remove unused function declaration

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/usb_osintf.h |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/usb_osintf.h b/drivers/staging/rtl8188eu/include/usb_osintf.h index 9de99ca..2dce3bf 100644 --- a/drivers/staging/rtl8188eu

[PATCH 12/18] staging: rtl8188eu: Remove function rtl8188e_silentreset_for_specific_platform()

Remove rtl8188e_silentreset_for_specific_platform() and function pointer ->silentreset pointing to it. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/hal/rtl8188e_sreset.c |3 --- drivers/staging/rtl8188eu/incl

[PATCH 14/18] staging: rtl8188eu: Remove "last_tx_time" from struct sreset_priv

value stored in variable last_tx_time isn't being used by driver. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_sreset.c |1 - drivers/staging/rtl8188eu/include/rtw_sreset.h |1 - drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |6 +- 3

[PATCH 15/18] staging: rtl8188eu: Remove "last_tx_complete_time" from struct sreset_priv

value stored in variable last_tx_complete_time isn't being used by driver. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_sreset.c |1 - drivers/staging/rtl8188eu/include/rtw_sreset.h |1 - drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c |5 ---

[PATCH 11/18] staging: rtl8188eu: Remove function rtw_hal_sreset_reset()

rtw_hal_sreset_reset() is a wrapper to call rtl8188e_silentreset_for_specific_platform(), which has empty defination. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c |2 -- drivers/staging/rtl8188eu/hal/hal_intf.c |6 -- drivers/staging

[PATCH 16/18] staging: rtl8188eu: Remove Hal8188EReg.h file

Driver doesn't need Hal8188EReg.h file. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/Hal8188EReg.h | 46 --- drivers/staging/rtl8188eu/include/odm_precomp.h |1 - 2 files changed, 47 deletions(-) delete mode 100644 drivers/staging/rtl8

[PATCH 13/18] staging: rtl8188eu: Remove empty files rtl8188e_sreset.[c|h]

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile |1 - drivers/staging/rtl8188eu/hal/rtl8188e_sreset.c| 25 - drivers/staging/rtl8188eu/include/rtl8188e_hal.h |3 +-- .../staging/rtl8188eu/include/rtl8188e_sreset.h| 28

[PATCH 10/18] staging:rtl8188eu: Remove function rtl8188e_sreset_linked_status_check()

Remove rtl8188e_sreset_linked_status_check() and function pointer ->sreset_linked_status_check pointing to it. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/hal/rtl8188e_sreset.c | 17 - driv

[PATCH 09/18] staging:rtl8188eu: Remove function rtw_hal_sreset_linked_status_check()

rtw_hal_sreset_linked_status_check() is a wrapper to call rtl8188e_sreset_linked_status_check(), which doesn't do anything useful. rtl8188e_sreset_linked_status_check() will also be removed later. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c |2 -- dr

[PATCH 05/18] staging: rtl8188eu: Remove unused function pointer ->sreset_reset_value

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/include/hal_intf.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal

[PATCH 07/18] staging: rtl8188eu: Remove function rtw_hal_sreset_xmit_status_check()

defination, so we can remove rtw_hal_sreset_xmit_status_check() because it doesn't serve its purpose. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_cmd.c |2 -- drivers/staging/rtl8188eu/hal/hal_intf.c |6 -- drivers/staging/rtl8188eu/include/hal_i

[PATCH 08/18] staging: rtl8188eu: Remove unused function rtl8188e_sreset_xmit_status_check()

Remove rtl8188e_sreset_xmit_status_check() and function pointer ->sreset_xmit_status_check pointing to it. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/hal/rtl8188e_sreset.c| 35 driv

[PATCH 06/18] staging: rtl8188eu: Remove unused function reset_reset_value()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_sreset.c|9 - drivers/staging/rtl8188eu/include/rtw_sreset.h |1 - 2 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c b/drivers/staging/rtl8188eu/core/rtw_sreset.c

[PATCH 03/18] staging: rtl8188eu: Use rtw_hal_sreset_init() in rtw_reset_drv_sw()

We can replace rtw_hal_sreset_reset_value() with rtw_hal_sreset_init() because both function call sreset_reset_value() and sreset_init_value() respectively at the end of code path, and function defination of sreset_reset_value() and sreset_init_value() is identical. Signed-off-by: navin patidar

[PATCH 02/18] staging: rtl8188eu:Remove "silent_reset_inprogress" from struct sreset_priv

psrtpriv->silent_reset_inprogress is always false. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_sreset.c|4 drivers/staging/rtl8188eu/include/rtw_sreset.h |1 - 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c

[PATCH 04/18] staging: rtl8188eu: Remove unused function rtw_hal_sreset_reset_value()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c |6 -- drivers/staging/rtl8188eu/include/hal_intf.h |1 - 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c index d0ac4a1

[PATCH 01/18] staging: rtl8188eu: Remove "silentreset_mutex" from struct sreset_priv

silentreset_mutex initialized but not being used. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_sreset.c|1 - drivers/staging/rtl8188eu/include/rtw_sreset.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_sreset.c b

Re: [PATCH 03/15] staging: rtl8188eu:Remove unused macro _init_queue()

On Wed, May 28, 2014 at 12:32 AM, Greg KH wrote: > On Tue, May 27, 2014 at 09:05:43PM +0530, navin patidar wrote: >> Signed-off-by: navin patidar >> --- >> drivers/staging/rtl8712/osdep_service.h |6 -- >> 1 file changed, 6 deletions(-) > > This is the

[PATCH 14/15] staging: rtl8188eu:Remove unused inline function res_to_status()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h index 9d32bb2..b500991 100644 --- a/drivers/staging

[PATCH 11/15] staging: rtl8188eu:Remove inline function rtw_netif_wake_queue()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging

[PATCH 13/15] staging: rtl8188eu:Remove inline function rtw_netif_stop_queue()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |4 ++-- drivers/staging/rtl8188eu/os_dep/usb_intf.c |4 ++-- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH 10/15] staging: rtl8188eu:Remove unused variable struct adapter *pbuddy_padapter

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c index c1195a0..6fb8caa 100644 --- a/drivers/staging/rtl8188eu

[PATCH 12/15] staging: rtl8188eu:Remove inline function rtw_netif_start_queue()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h |5 - drivers/staging/rtl8188eu/os_dep/os_intfs.c |2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging

[PATCH 09/15] staging: rtl8188eu:Remove unused function rtw_handle_dualmac()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c index 6c9e9a1..c1195a0 100644 --- a/drivers

[PATCH 15/15] staging: rtl8188eu:Remove unused macros defined in osdep_service.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/osdep_service.h | 39 - 1 file changed, 39 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h index b500991..3859acd 100644

[PATCH 07/15] staging: rtl8188eu:Drop rtw_handle_dualmac() function calls in rtw_usb_if1_init()

rtw_usb_if1_init() initializes pbuddy_padapter variable which is not being used. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers

[PATCH 02/15] staging:rtl8188eu:Remove code specific to kernel version < 2.6.35

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/xmit_linux.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c index 6089bae..9172380 100644 --- a/drivers/staging/rtl8188eu

[PATCH 08/15] staging: rtl8188eu:Drop rtw_handle_dualmac() function calls in rtw_usb_if1_deinit()

rtw_usb_if1_init() assign NULL to pbuddy_padapter variable which is not being used. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep

[PATCH 03/15] staging: rtl8188eu:Remove unused macro _init_queue()

Signed-off-by: navin patidar --- drivers/staging/rtl8712/osdep_service.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h index 09e1561..66ed7f1 100644 --- a/drivers/staging/rtl8712/osdep_service.h

[PATCH 06/15] staging: rtl8188eu:Remove unused function rtl8188eu_set_hw_type()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_ops_linux.c |6 -- drivers/staging/rtl8188eu/include/usb_ops.h |1 - 2 files changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c b/drivers/staging/rtl8188eu/hal/usb_ops_linux.c index

[PATCH 05/15] staging: rtl8188eu:Remove unused function chip_by_usb_id()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index fbf967d..1e62713 100644 --- a/drivers/staging/rtl8188eu

[PATCH 04/15] staging: rtl8188eu:Assign RTL8188E to padapter->chip_type directly

Assign RTL8188E to padapter->chip_type directly instead of calling chip_by_usb_id() function to do same. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/usb_intf.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_

[PATCH 01/15] staging: rtl8188eu:Remove function rtw_set_tx_chksum_offload()

rtw_set_tx_chksum_offload() has empty defination. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_xmit.c |2 -- drivers/staging/rtl8188eu/include/xmit_osdep.h |2 -- drivers/staging/rtl8188eu/os_dep/xmit_linux.c |4 3 files changed, 8 deletions

[PATCH 07/24] staging: rtl8188eu: Remove function with empty defination dm_CheckStatistics()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index cf88bf2..4e9f797 100644 --- a/drivers/staging/rtl8188eu

[PATCH 13/24] staging: rtl8188eu: Remove unused structure "rtl8192cd_priv"

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm.h |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm.h b/drivers/staging/rtl8188eu/include/odm.h index 9d1a79c..e83812f 100644 --- a/drivers/staging/rtl8188eu/include/odm.h

[PATCH 11/24] staging: rtl8188eu: remove unused header inclusion from rtw_mp.c

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mp.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mp.c b/drivers/staging/rtl8188eu/core/rtw_mp.c index 705f666..17427a6 100644 --- a/drivers/staging/rtl8188eu/core/rtw_mp.c +++ b

[PATCH 16/24] staging: rtl8188eu: Remove unused function declaration.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 5338290..ba58a67 100644 --- a/drivers/staging

[PATCH 17/24] staging: rtl8188eu: Use "ODM_REG_CCK_CCA_11N" in ODM_Write_CCK_CCA_Thres()

Use "ODM_REG_CCK_CCA_11N" directly instead of using ODM_REG(CCK_CCA, pDM_Odm) which produces same after preprocessing. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu

[PATCH 19/24] staging: rtl8188eu: Remove unnecessary debugging message from ODM_Write_DIG()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c index 2bd68aa..205ba7f 100644 --- a/drivers/staging/rtl8188eu/hal/odm.c +++ b/drivers

[PATCH 24/24] staging: rtl8188eu: Remove empty file odm_interface.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h | 24 - drivers/staging/rtl8188eu/include/odm_precomp.h |1 - 2 files changed, 25 deletions(-) delete mode 100644 drivers/staging/rtl8188eu/include/odm_interface.h diff --git a

[PATCH 21/24] staging: rtl8188eu: Remove unused macros defined in odm_interface.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h | 30 - 1 file changed, 30 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index ba58a67..2c2991e 100644

[PATCH 20/24] staging: rtl8188eu: Use ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N in ODM_Write_DIG()

ODM_REG(IGI_A, pDM_Odm) and ODM_BIT(IGI, pDM_Odm) macros produce ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N respectively after preprocessing. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 23/24] staging: rtl8188eu: Remove unused enum odm_h2c_cmd.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index e29ac79..dc6b1c2 100644 --- a/drivers

[PATCH 12/24] staging: rtl8188eu: Remove unused macros and enum defined in odm_types.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_types.h | 25 - 1 file changed, 25 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_types.h b/drivers/staging/rtl8188eu/include/odm_types.h index 78ee2ba..c1355b9 100644 --- a

[PATCH 14/24] staging: rtl8188eu: Remove unused macros in odm_interface.h

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 548a309..3fc3e3c 100644 --- a/drivers

[PATCH 18/24] staging: rtl8188eu: Use ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N in odm_DIGInit()

ODM_REG(IGI_A, pDM_Odm) and ODM_BIT(IGI, pDM_Odm) macros produce ODM_REG_IGI_A_11N and ODM_BIT_IGI_11N respectively after preprocessing. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 15/24] staging: rtl8188eu: Remove unused function pointer declaration.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 3fc3e3c..5338290 100644 --- a/drivers

[PATCH 22/24] staging: rtl8188eu: Remove unused function declaration.

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/odm_interface.h |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/odm_interface.h b/drivers/staging/rtl8188eu/include/odm_interface.h index 2c2991e..e29ac79 100644 --- a/drivers

[PATCH 08/24] staging: rtl8188eu: Remove function rtw_hal_dm_deinit()

rtw_hal_dm_deinit() calls rtl8188e_deinit_dm_priv() using funtion pointer. rtl8188e_deinit_dm_priv() has empty defination, so we can remove rtw_hal_dm_deinit() and later rtl8188e_deinit_dm_priv() also will be removed. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c

[PATCH 10/24] staging: rtl8188eu: Remove unused function rtl8188e_deinit_dm_priv()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c |4 drivers/staging/rtl8188eu/include/rtl8188e_dm.h |1 - 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index

[PATCH 09/24] staging: rtl8188eu: Remove unused function pointer ->dm_init

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/include/hal_intf.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal

[PATCH 06/24] staging: rtl8188eu: Remove unused function odm_Init_RSSIForDM()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_HWConfig.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c index 0145a11..f2e1d02 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 04/24] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 9020129..141f85a 100644 --- a/drivers/staging/rtl8188eu/hal

[PATCH 05/24] staging: rtl8188eu: Remove unused function ODM_MacStatusQuery()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_HWConfig.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_HWConfig.c b/drivers/staging/rtl8188eu/hal/odm_HWConfig.c index a755df3..0145a11 100644 --- a/drivers/staging/rtl8188eu

[PATCH 02/24] staging: rtl8188eu: Remove unused function rtw_hal_intf_ps_func()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c |9 - drivers/staging/rtl8188eu/include/hal_intf.h |3 --- 2 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c index

[PATCH 03/24] staging: rtl8188eu: Remove unused function pointer ->interface_ps_func

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/usb_halinit.c |2 -- drivers/staging/rtl8188eu/include/hal_intf.h |3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 0cb84ae

[PATCH 01/24] staging: rtl8188eu: Remove unused function rtw_interface_ps_func()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c|9 - drivers/staging/rtl8188eu/include/rtw_pwrctrl.h |2 -- 2 files changed, 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core

Re: [PATCH 00/13]staging: rtl8188eu: Remove unused functions and variables

Hi Greg, Please merge this patchset, It has been pending for some time. regards, navin patidar On Wed, May 7, 2014 at 9:27 AM, wrote: > From: navin patidar > > Following patches remove unused functions, variables and functions with empty > definition. > > navin patidar

Re: [PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

On Tue, May 20, 2014 at 12:34 AM, Dan Carpenter wrote: > On Mon, May 19, 2014 at 09:19:07PM +0530, navin patidar wrote: >> > You have changed it to return _FAIL instead of true. Perhaps that is ok >> > but you need to explain it in the changelog. >> > >> oops

Re: [PATCH 05/28] staging: rtl8188eu: Remove unused function rtl8188eu_ps_func()

On Mon, May 19, 2014 at 4:22 PM, Dan Carpenter wrote: > On Sun, May 18, 2014 at 08:48:58PM +0530, navin patidar wrote: >> Signed-off-by: navin patidar >> --- >> drivers/staging/rtl8188eu/hal/usb_halinit.c |8 >> 1 file changed, 8 deletions(-) >>

Re: [PATCH 13/28] staging: rtl8188eu: Remove unused funtion phy_TxPwrIdxToDbm()

Subject line of this patch isn't correct, so please ignore it. I've submitted new patch with "[PATCH 13/28] staging: rtl8188eu: Remove unused funtion PHY_ScanOperationBackup8188E()" subject line. regards, navin patidar On Sun, May 18, 2014 at 8:49 PM, navin patidar wrote: &g

[PATCH 13/28] staging: rtl8188eu: Remove unused funtion PHY_ScanOperationBackup8188E()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c index a7872c8..941ff74 100644 --- a/drivers/staging

[PATCH 28/28] staging: rtl8188eu:Remove function with empty defination odm_DynamicPrimaryCCA()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm.c |1 - drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |5 - drivers/staging/rtl8188eu/include/odm_RTL8188E.h |2 -- 3 files changed, 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm.c

[PATCH 26/28] staging: rtl8188eu: Remove unused function DM_DIG_LowerBound_88E()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c index 323eb93..7c1043c 100644 --- a/drivers/staging

[PATCH 27/28] staging: rtl8188eu: Remove unused function ODM_DynamicPrimaryCCA_DupRTS()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/odm_RTL8188E.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c b/drivers/staging/rtl8188eu/hal/odm_RTL8188E.c index 7c1043c..a90b2c5 100644 --- a/drivers/staging/rtl8188eu

<    1   2   3   4   5   6   >