Re: [PATCH] ext4: add a configurable parameter to prevent endless loop in ext4_mb_discard_group_p

2021-04-09 Thread riteshh
On 21/04/09 12:18PM, Jan Kara wrote: > On Fri 09-04-21 11:17:33, riteshh wrote: > > On 21/04/09 02:50AM, Wen Yang wrote: > > > > On Apr 7, 2021, at 5:16 AM, riteshh wrote: > > > >> > > > >> On 21/04/07 03:01PM, Wen Yang wrote: > > > >

Re: [PATCH] ext4: add a configurable parameter to prevent endless loop in ext4_mb_discard_group_p

2021-04-08 Thread riteshh
On 21/04/09 02:50AM, Wen Yang wrote: > > On Apr 7, 2021, at 5:16 AM, riteshh wrote: > >> > >> On 21/04/07 03:01PM, Wen Yang wrote: > >>> From: Wen Yang > >>> > >>> The kworker has occupied 100% of the CPU for several days: >

Re: [PATCH 0/5] close various race windows for swap

2021-04-08 Thread riteshh
On 21/04/08 09:08AM, Miaohe Lin wrote: > Hi all, > When I was investigating the swap code, I found some possible race > windows. This series aims to fix all these races. But using current > get/put_swap_device() to guard against concurrent swapoff for > swap_readpage() looks terrible because

Re: [PATCH] ext4: add a configurable parameter to prevent endless loop in ext4_mb_discard_group_preallocations

2021-04-07 Thread riteshh
On 21/04/07 03:01PM, Wen Yang wrote: > From: Wen Yang > > The kworker has occupied 100% of the CPU for several days: > PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND > 68086 root 20 0 00 0 R 100.0 0.0 9718:18 kworker/u64:11 > > And the stack obtained through sysrq is as

Re: [PATCH 2/3] fsdax: Factor helper: dax_fault_actor()

2021-04-07 Thread riteshh
On 21/04/07 02:32PM, Shiyang Ruan wrote: > The core logic in the two dax page fault functions is similar. So, move > the logic into a common helper function. Also, to facilitate the > addition of new features, such as CoW, switch-case is no longer used to > handle different iomap types. > >

Re: [PATCH 3/3] fsdax: Output address in dax_iomap_pfn() and rename it

2021-04-07 Thread riteshh
On 21/04/07 02:32PM, Shiyang Ruan wrote: > Add address output in dax_iomap_pfn() in order to perform a memcpy() in > CoW case. Since this function both output address and pfn, rename it to > dax_iomap_direct_access(). > > Signed-off-by: Shiyang Ruan > Reviewed-by: Christoph Hellwig >

Re: [PATCH 1/3] fsdax: Factor helpers to simplify dax fault code

2021-04-07 Thread riteshh
On 21/04/07 02:32PM, Shiyang Ruan wrote: > The dax page fault code is too long and a bit difficult to read. And it > is hard to understand when we trying to add new features. Some of the > PTE/PMD codes have similar logic. So, factor them as helper functions to > simplify the code. > >