Re: [PATCH 04/12] ARM: pxa: stargate2: Constify the software node

2021-04-10 Thread Robert Jarzmik
ed-off-by: Heikki Krogerus >> Cc: Jonathan Cameron >> Cc: Daniel Mack >> Cc: Haojian Zhuang >> Cc: Robert Jarzmik > > I like to apply it soon. Can we get an ack, please? Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH] ARM: pxa: mainstone: avoid -Woverride-init warning

2021-04-10 Thread Robert Jarzmik
ote: in expansion of macro >> 'MAINSTONE_S0_CD_IRQ' >> 506 | [5] = MAINSTONE_S0_CD_IRQ, >> | ^~~ >> >> [...] > > Applied to arm/fixes. Too late, but ... Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH 06/32] usb: gadget: udc: pxa27x_udc: Fix a bunch of kerneldoc issues

2020-07-08 Thread Robert Jarzmik
rivers/usb/gadget/udc/pxa27x_udc.c:1800: warning: Function parameter or > member 'g' not described in 'pxa27x_udc_stop' > drivers/usb/gadget/udc/pxa27x_udc.c:1800: warning: Excess function parameter > 'driver' description in 'pxa27x_udc_stop' > d

Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken

2020-06-01 Thread Robert Jarzmik
wever, the corresponding 'pinctrl_unregister()' call in > 'pxa2xx_pinctrl_exit()' has not been removed. > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. > Remove it now to avoid some wondering in the future and save a few LoC. > > Signed-off-by: C

Re: [PATCH 2/3] gpio: pxa: Fix return value of pxa_gpio_probe()

2020-05-27 Thread Robert Jarzmik
Tiezhu Yang writes: > On 05/23/2020 03:07 AM, Robert Jarzmik wrote: >> Tiezhu Yang writes: >> >>> When call function devm_platform_ioremap_resource(), we should use IS_ERR() >>> to check the return value and return PTR_ERR() if failed. >>> >>

Re: [PATCH 2/3] gpio: pxa: Fix return value of pxa_gpio_probe()

2020-05-22 Thread Robert Jarzmik
Tiezhu Yang writes: > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. > > Fixes: 542c25b7a209 ("drivers: gpio: pxa: use > devm_platform_ioremap_resource()") > Signed-off-by: Tiezhu Yang > --- > drivers/gpio

[PATCH v3 2/3] MAINTAINERS: pxa: remove Compulab arm/pxa support

2020-05-21 Thread Robert Jarzmik
These boards support is removed from the kernel, so remove the MAINTAINERS entry for them. Signed-off-by: Robert Jarzmik Acked-by: Mike Rapoport Acked-by: Arnd Bergmann --- MAINTAINERS | 5 - 1 file changed, 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 091ec22c1a23

[PATCH v3 3/3] ASoC: pxa: remove Compulab pxa2xx boards

2020-05-21 Thread Robert Jarzmik
As these boards have been removed from the pxa tree, amend accordingly the sound subsystem. Signed-off-by: Robert Jarzmik Acked-by: Mike Rapoport Acked-by: Arnd Bergmann --- sound/soc/pxa/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/soc/pxa/Kconfig b

[PATCH v3 1/3] ARM: pxa: remove Compulab pxa2xx boards

2020-05-21 Thread Robert Jarzmik
As these boards have no more users nor testers, and patching them has become a burden, be that because of the PCI part or the MTD NAND support, let's remove them. The cm-x300 will for now remain and represent Compulab boards at its best in the PXA department. Signed-off-by: Robert Jarzmik

Re: [PATCH 00/46] ARM: pxa: towards multiplatform support

2019-10-19 Thread Robert Jarzmik
Arnd Bergmann writes: > On Fri, Oct 18, 2019 at 9:17 PM Arnd Bergmann wrote: >> On Fri, Oct 18, 2019 at 9:04 PM Robert Jarzmik >> wrote: >> > Arnd Bergmann writes: >> > >> > > Hi PXA maintainers, >> > > >> > > I'

Re: [PATCH 00/46] ARM: pxa: towards multiplatform support

2019-10-18 Thread Robert Jarzmik
Arnd Bergmann writes: > Hi PXA maintainers, > > I'm in the process of getting the old ARM platforms to all build > in a single kernel. The largest part of that work is changing all > the device drivers to no longer require mach/*.h header files. > > This series does it for arch/pxa/. > > As with

Re: [PATCH 4/6] dma: pxa_dma: no need to check return value of debugfs_create functions

2019-08-13 Thread Robert Jarzmik
Greg Kroah-Hartman writes: > On Sat, Aug 10, 2019 at 09:27:26PM +0200, Robert Jarzmik wrote: >> Greg Kroah-Hartman writes: >> >> This is not strictly equivalent. >> Imagine that the debugfs_create_dir() fails and returns NULL : > How can that happen? Well

Re: [PATCH 4/6] dma: pxa_dma: no need to check return value of debugfs_create functions

2019-08-10 Thread Robert Jarzmik
try, remove the > variable that was saving it as it was never even being used once set. > > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Cc: Vinod Koul > Cc: Dan Williams > Cc: linux-arm-ker...@lists.infradead.org > Cc: dmaeng...@vger.kernel.org > Cc:

Re: [PATCH] media: mt9m111: fix fw-node refactoring

2019-06-24 Thread Robert Jarzmik
Sakari Ailus writes: > On Thu, Jun 20, 2019 at 01:17:17PM +0300, Sakari Ailus wrote: >> diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c >> index bd3a51c3b081..9761a6105407 100644 >> --- a/drivers/media/i2c/mt9m111.c >> +++ b/drivers/media/i2c/mt9m111.c >> @@ -1263,9 +1263,1

Re: [PATCH 5/6] ARM: pxa: Switch to SPDX header

2019-06-11 Thread Robert Jarzmik
Lubomir Rintel writes: > The original license text had a typo ("publishhed") which would be > likely to confuse automated licensing auditing tools. Let's just switch > to SPDX instead of fixing the wording. > > Signed-off-by: Lubomir Rintel Acked-by: Robert Jarzmik Cheers. -- Robert

[PATCH] media: mt9m111: fix fw-node refactoring

2019-06-03 Thread Robert Jarzmik
such platforms, what this patch fixes. Fixes: 98480d65c48c ("media: mt9m111: allow to setup pixclk polarity") Signed-off-by: Robert Jarzmik --- drivers/media/i2c/mt9m111.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/mt9m111.c b/drivers

Re: [PATCH] lib: scatterlist: Fix to support no mapped sg

2019-04-19 Thread Robert Jarzmik
> original sgl. > > Signed-off-by: Zhou Wang That's right. May I know what is the usecase which led you to this fix ? Acked-by: Robert Jarzmik -- Robert

Re: Removing pcap? (EZX support in mainline linux)

2019-04-08 Thread Robert Jarzmik
Arnd Bergmann writes: > On Mon, Apr 8, 2019 at 8:58 AM Antonio Ospite wrote: >> On Sun, 7 Apr 2019 16:07:41 +0200 >> Alexandre Belloni wrote: >> adding Robert to CC as he is listed as the current maintainer of >> ARM/EZX SMARTPHONES in the MAINTAINERS file. >> >> > I've had a look at the PCAP R

Re: [PATCH 1/7] thermal/drivers/core: Remove the module Kconfig's option

2019-04-04 Thread Robert Jarzmik
he plugs are as module. > > Remove the module option. The removal of the module related dead code will > come after this patch gets in or is acked. > > Signed-off-by: Daniel Lezcano > Acked-by: Guenter Roeck > For mini2440: > Acked-by: Krzysztof Kozlowski For pxa: Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH] cpufreq: pxa2xx: remove incorrect __init annotation

2019-03-07 Thread Robert Jarzmik
acks a __init > annotation or the annotation of pxa_cpufreq_init_voltages is wrong. > > Fixes: 50e77fcd790e ("ARM: pxa: remove __init from cpufreq_driver->init()") > Signed-off-by: Arnd Bergmann Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH] mmc: pxamci: fix enum type confusion

2019-03-07 Thread Robert Jarzmik
_prep_slave_sg(chan, data->sg, host->dma_len, >> direction, >> >> The behavior is correct, so this must be a simply typo from >> dma_data_direction and dma_transfer_direction being similarly named >> types with a similar purpose. >> >> Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use") >> Signed-off-by: Arnd Bergmann > > Reviewed-by: Nathan Chancellor Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH] ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig

2019-02-27 Thread Robert Jarzmik
nd we get > the drivers that are selectively enabled here. > > Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies") > Signed-off-by: Arnd Bergmann Yes, most certainly. Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH -next] ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data"

2019-02-15 Thread Robert Jarzmik
YueHaibing writes: > Since commit 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") > kfree, iounmap, clk_put etc no need do any more in remove path. > > Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") > Signed-off-by: YueHaibing Sorry for the late reply, I had forgotten to answer.

Re: [PATCH v3 -next] mtd: docg3: Fix a possible memory leak of mtd->name

2019-01-23 Thread Robert Jarzmik
t; --- > v3: use devm_kasprintf > --- > drivers/mtd/devices/docg3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH -next] mtd: docg3: Fix passing zero to 'PTR_ERR' warning in doc_probe_device

2019-01-23 Thread Robert Jarzmik
;> nomem1: >> >> - return ERR_PTR(ret); >> >> + return ret ? ERR_PTR(ret) : NULL; >> >> } >> >> >> > >> > This is not the right fix, you should instead set ret to -EINVAL: >> >> Thanks , will fix it in v2. >

Re: [PATCH] pxa2xx: replace spi_master with spi_controller

2019-01-18 Thread Robert Jarzmik
Lubomir Rintel writes: > It's also a slave controller driver now, calling it "master" is slightly > misleading. I think the patch subject's prefix is not correct, should be : "spi: pxa2xx: replace spi_master with spi_controller". Apart from that, for th

Re: [PATCH 2/2] arm/plat-pxa/ssp : unneeded to free devm_ allocated data

2019-01-03 Thread Robert Jarzmik
Peng Hao writes: > devm_ allocated data will be automatically freed. The free > of devm_ allocated data is invalid. > > Signed-off-by: Peng Hao Hi Peng Hao, Thanks for the patch. I changed your title to fit my tree, ie. : "ARM: pxa: ssp: unneeded to free devm_ allocated data" If you have othe

Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL()

2018-11-30 Thread Robert Jarzmik
>> drivers/dma/amba-pl08x.c | 14 ++ >> drivers/dma/mic_x100_dma.c | 22 +++--- >> drivers/dma/pxa_dma.c| 24 >> drivers/dma/qcom/hidma_dbg.c | 33 ++--- For pxa_dma: Acked-by: Robert Jarzmik Cheers. -- Robert

[PATCH] gpio: pxa: fix legacy non pinctrl aware builds again

2018-11-15 Thread Robert Jarzmik
ng this direction. Yet in Gregory's case, the matrix-keypad driver changes back and forth the direction dynamically, and this is why he's the first to report it. Fixes: c4e5ffb6f224 ("gpio: pxa: fix legacy non pinctrl aware builds") Tested-by: Greg Signed-off-by: Robert Jarz

Re: [PATCH] spi: pxa2xx: Fix '"CONFIG_OF" is not defined' warning

2018-11-14 Thread Robert Jarzmik
Lubomir Rintel writes: > A careless oversight. Sorry. > > Fixes: 0a897143b7c9 ("spi: pxa2xx: Add slave mode support") > Signed-off-by: Lubomir Rintel > --- > drivers/spi/spi-pxa2xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/

Re: [PATCH v3 17/18] USB: phy-mv-usb: use phy-pxa-usb

2018-11-13 Thread Robert Jarzmik
Lubomir Rintel writes: > Use a proper PHY driver, instead of hooks to a board support package. Hi Lubomir, This specific patch caught my attention, because of its title : I don't see what phy-pxa-usb stands for, is it a typo ? I don't think anybody implemented so far a proper phy support for pxa

Re: [PATCH v4] ARM: dts: pxa: add mioa701 board description

2018-11-11 Thread Robert Jarzmik
Robert Jarzmik writes: > Add device-tree description of the Mitac MIO A701 board. > This is aimed at replacing mioa701.c board file, and once stabilized, > the leftover, such as the suspend resume mechanics will rely on a new > IPL, and not the legacy Windows CE one. > > Sig

Re: [PATCH v4] ARM: dts: pxa: add mioa701 board description

2018-11-11 Thread Robert Jarzmik
Robert Jarzmik writes: > Add device-tree description of the Mitac MIO A701 board. > This is aimed at replacing mioa701.c board file, and once stabilized, > the leftover, such as the suspend resume mechanics will rely on a new > IPL, and not the legacy Windows CE one. > > Sig

Re: linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste error

2018-11-10 Thread Robert Jarzmik
Russell King - ARM Linux writes: >> Interestingly, more of the same in file >> linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c >> >> [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:84]: (warning) Redundant >> assignment of 'ASCR' to itself. >> [linux-4.20-rc1/arch/arm/mach-pxa/pxa3xx.c:85]: (warning) Red

Re: [PATCH 3/5] spi: pxa2xx: use an enum for type

2018-09-21 Thread Robert Jarzmik
Lubomir Rintel writes: > That seems to be the correct type. Okay, but what happens here when adev_id->driver_data is a value out of enum range ? Does the following assignment make sense ? > + type = (enum pxa_ssp_type)adev_id->driver_data; As a side note, could you join for the next

[PATCH v4] ARM: dts: pxa: add mioa701 board description

2018-09-15 Thread Robert Jarzmik
Add device-tree description of the Mitac MIO A701 board. This is aimed at replacing mioa701.c board file, and once stabilized, the leftover, such as the suspend resume mechanics will rely on a new IPL, and not the legacy Windows CE one. Signed-off-by: Robert Jarzmik --- Since v1: fix lcd_supply

Re: [PATCH v3] ARM: dts: pxa: add mioa701 board description

2018-09-13 Thread Robert Jarzmik
Marcel Ziswiler writes: > Hi Robert >> arch/arm/boot/dts/Makefile| 2 + >> arch/arm/boot/dts/mioa701.dts | 558 > > Isn't that one supposed to be prefixed by pxa270-? Good point, for v4. >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile ... >> +dtb-$(CONFIG_ARCH_PXA)

Re: [PATCH] Input: wm97xx: only unregister wm97xx_driver if it has been registered

2018-09-09 Thread Robert Jarzmik
t supported. >> >> Fixes: ae9d1b5fbd7b ("Input: wm97xx: add new AC97 bus support") >> Signed-off-by: Colin Ian King >> --- > > Acked-by: Charles Keepax Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH] ARM: dts: pxa: add pincontrol helpers

2018-08-31 Thread Robert Jarzmik
Robert Jarzmik writes: > Add 3 helpers so that pincontrol definitions for pxa25x and pxa27x are > easier, and can be easily converted from old mfp mach-pxa code to > devicetree. As this is exactly the same patch sent out for review July the 7th, queued to pxa/dt. -- Robert

Re: [PATCH] ARM: dts: pxa: fix power i2c base address

2018-08-31 Thread Robert Jarzmik
Marcel Ziswiler writes: > There is one too many zeroes in the Power I2C base address. Fix this. > > Signed-off-by: Marcel Ziswiler Queued to pxa/dt, thanks. Cheers. -- Robert

Re: [PATCH v3] ARM: dts: pxa: add mioa701 board description

2018-08-31 Thread Robert Jarzmik
kbuild test robot writes: > Hi Robert, > > I love your patch! Yet something to improve: This is because you are missing at least this patch submitted earlier : - [PATCH] ARM: dts: pxa: add pincontrol helpers You're also missing the previous patches in the pxa/dt tree, which are already on the t

[PATCH v3] ARM: dts: pxa: add mioa701 board description

2018-08-30 Thread Robert Jarzmik
Add device-tree description of the Mitac MIO A701 board. This is aimed at replacing mioa701.c board file, and once stabilized, the leftover, such as the suspend resume mechanics will rely on a new IPL, and not the legacy Windows CE one. Signed-off-by: Robert Jarzmik --- Since v1: fix lcd_supply

[PATCH] ARM: dts: pxa: add pincontrol helpers

2018-08-30 Thread Robert Jarzmik
l once booted in debugfs. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa2xx.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi index a520b4c14ea9..81312a9813f6 100644 --- a/arch/arm/boot/dts/pxa2xx.dtsi

Re: [PATCH] ARM: dts: pxa: change serial node names

2018-08-30 Thread Robert Jarzmik
Robert Jarzmik writes: > Change from xxuart to serial to normalize the devicetree pxa serial > support. > > Signed-off-by: Robert Jarzmik > --- > arch/arm/boot/dts/pxa2xx.dtsi | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Queued to pxa/dt. -- Robert

[PATCH v9] ASoC: pxa: switch to new ac97 bus support

2018-08-25 Thread Robert Jarzmik
Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik --- Since v8: fixed the trivial compilation error v7 was in https://patchwork.kernel.org/patch/9951919/ --- sound/arm/Kconfig | 1 - sound/soc/pxa/Kconfig

[PATCH] gpio: pxa: handle corner case of unprobed device

2018-08-25 Thread Robert Jarzmik
: https://bugzilla.kernel.org/show_bug.cgi?id=200905 Therefore, add a failsafe in these function, and test if a proper probe succeeded and the driver is functional. Signed-off-by: Robert Jarzmik Reported-by: Nicolas Chauvet --- drivers/gpio/gpio-pxa.c | 6 ++ 1 file changed, 6 insertions

Re: linux-next: build failure after merge of the arm-soc tree

2018-07-15 Thread Robert Jarzmik
Olof Johansson writes: > It's a known issue due to dependencies with a driver tree. :( > > Robert, this is unfortunate. What's the dependent patches? We can pick > them up in our tree as duplicates if needed. I'd rather postpone one of the patches, as I explained in the pull request. As Stephen n

[PATCH] ARM: dts: pxa: change serial node names

2018-07-15 Thread Robert Jarzmik
Change from xxuart to serial to normalize the devicetree pxa serial support. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa2xx.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi index

Re: [PATCH 2/2] ARM: dts: pxa: add mioa701 board description

2018-07-14 Thread Robert Jarzmik
Rob Herring writes: Hi Rob, >> + /* compatible = "mitac,mioa701"; */ >> + compatible = "marvell,pxa270"; > > Why the comment? Leftover, I'll remove it. >> + pstore_region:region@0xa200 { > > Drop the 0x Done. >> + compatible =

[PATCH v2 1/2] ARM: dts: pxa: add pincontrol helpers

2018-07-07 Thread Robert Jarzmik
l once booted in debugfs. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa2xx.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi index e4ebcde17837..f609dbb86abf 100644 --- a/arch/arm/boot/dts/pxa2xx.dtsi

[PATCH v2 2/2] ARM: dts: pxa: add mioa701 board description

2018-07-07 Thread Robert Jarzmik
Add device-tree description of the Mitac MIO A701 board. This is aimed at replacing mioa701.c board file, and once stabilized, the leftover, such as the suspend resume mechanics will rely on a new IPL, and not the legacy Windows CE one. Signed-off-by: Robert Jarzmik --- Since v1: fix lcd_supply

Re: [PATCH v4 1/2] clk: pxa: export 32kHz PLL

2018-07-07 Thread Robert Jarzmik
Stephen Boyd writes: > Quoting Robert Jarzmik (2018-07-04 22:34:10) >> Robert Jarzmik writes: >> >> > This clock is especially used by the RTC driver, so export it so that >> > devicetree users can use it. >> > >> > Signed-off-by: Robert Jarzm

Re: linux-next: Tree for Jul 2 (sound/soc/pxa/)

2018-07-02 Thread Robert Jarzmik
Randy Dunlap writes: > [add other maintainers] > on i386 or x86_64: > > builtin: > sound/soc/pxa/pxa-ssp.o:(.rodata+0x228): undefined reference to > `pxa2xx_soc_pcm_new' > sound/soc/pxa/pxa-ssp.o:(.rodata+0x22c): undefined reference to > `pxa2xx_pcm_free_dma_buffers' > sound/soc/pxa/pxa-ssp.o:(

[PATCH 1/2] ARM: dts: pxa: add pincontrol helpers

2018-07-01 Thread Robert Jarzmik
l once booted in debugfs. Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa2xx.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi index e4ebcde17837..f609dbb86abf 100644 --- a/arch/arm/boot/dts/pxa2xx.dtsi

[PATCH 2/2] ARM: dts: pxa: add mioa701 board description

2018-07-01 Thread Robert Jarzmik
Add device-tree description of the Mitac MIO A701 board. This is aimed at replacing mioa701.c board file, and once stabilized, the leftover, such as the suspend resume mechanics will rely on a new IPL, and not the legacy Windows CE one. Signed-off-by: Robert Jarzmik --- This patch deserves some

[PATCH v4 2/2] ARM: dts: pxa: fix the rtc controller

2018-06-27 Thread Robert Jarzmik
nd working. Signed-off-by: Robert Jarzmik --- Since v1: change the dummy clock by the actual 32.768kHz Since v3: remove spurious bracket --- arch/arm/boot/dts/pxa25x.dtsi | 4 arch/arm/boot/dts/pxa27x.dtsi | 4 2 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/pxa25x.dtsi

[PATCH v4 1/2] clk: pxa: export 32kHz PLL

2018-06-27 Thread Robert Jarzmik
This clock is especially used by the RTC driver, so export it so that devicetree users can use it. Signed-off-by: Robert Jarzmik --- Since v2: fix missing parenthesis in clk-pxa25x.c and clk-pxa3xx.c --- drivers/clk/pxa/clk-pxa25x.c | 6 -- drivers/clk/pxa/clk-pxa27x.c | 7

Re: [PATCH v3 2/2] ARM: dts: pxa: fix the rtc controller

2018-06-27 Thread Robert Jarzmik
Thomas Petazzoni writes: > Hello, >> +rtc@4090 { >> +clocks = <&clks CLK_OSC32k768>>; > > Double closing bracket, doesn't look good. Rrrr you're right ... I swear this patchset is cursed ... Thanks for spotting that, I'll send a v4. Cheers. -- Robert

Re: [PATCH v3 00/14] ARM: pxa: switch to DMA slave maps

2018-06-27 Thread Robert Jarzmik
Mark Brown writes: > On Mon, Jun 18, 2018 at 09:56:20PM +0200, Robert Jarzmik wrote: > >> I must insist on "Wednesday", as I need to have one last pass from 0-day >> kernel >> checker to be fully covered, and I'd like as well to know which tree the ASoC

[PATCH v3 2/2] ARM: dts: pxa: fix the rtc controller

2018-06-27 Thread Robert Jarzmik
nd working. Signed-off-by: Robert Jarzmik --- Since v1: change the dummy clock by the actual 32.768kHz --- arch/arm/boot/dts/pxa25x.dtsi | 4 arch/arm/boot/dts/pxa27x.dtsi | 4 2 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.

[PATCH v3 1/2] clk: pxa: export 32kHz PLL

2018-06-27 Thread Robert Jarzmik
This clock is especially used by the RTC driver, so export it so that devicetree users can use it. Signed-off-by: Robert Jarzmik --- Since v2: fix missing parenthesis in clk-pxa25x.c and clk-pxa3xx.c --- drivers/clk/pxa/clk-pxa25x.c | 6 -- drivers/clk/pxa/clk-pxa27x.c | 7

Re: [PATCH v2 1/2] clk: pxa: export 32kHz PLL

2018-06-27 Thread Robert Jarzmik
kbuild test robot writes: > All errors (new ones prefixed by >>): > >drivers/clk/pxa/clk-pxa25x.c: In function 'pxa25x_register_plls': >>> drivers/clk/pxa/clk-pxa25x.c:298:17: error: expected ')' before ';' token > 32768); > ^ >>> drivers/clk/pxa/clk-pxa25x.c

[PATCH v2 1/2] clk: pxa: export 32kHz PLL

2018-06-26 Thread Robert Jarzmik
This clock is especially used by the RTC driver, so export it so that devicetree users can use it. Signed-off-by: Robert Jarzmik --- drivers/clk/pxa/clk-pxa25x.c | 6 -- drivers/clk/pxa/clk-pxa27x.c | 7 --- drivers/clk/pxa/clk-pxa3xx.c | 7 --- include/dt

[PATCH v2 2/2] ARM: dts: pxa: fix the rtc controller

2018-06-26 Thread Robert Jarzmik
nd working. Signed-off-by: Robert Jarzmik --- Since v1: change the dummy clock by the actual 32.768kHz --- arch/arm/boot/dts/pxa25x.dtsi | 4 arch/arm/boot/dts/pxa27x.dtsi | 4 2 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.

[PATCH] ARM: dts: pxa: fix the rtc controller

2018-06-26 Thread Robert Jarzmik
Signed-off-by: Robert Jarzmik --- arch/arm/boot/dts/pxa25x.dtsi | 4 arch/arm/boot/dts/pxa27x.dtsi | 4 2 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.dtsi index 95d59be97213..c6ca07e4626b 100644 --- a/arch/arm/boot/dts/pxa25x.dtsi

[PATCH v2 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-22 Thread Robert Jarzmik
Add a devicetree binding for codecs. This is especially useful if the AC97 bitclk clock is provided by the codec, as it has to be described in the devicetree description for the ac97 bus code to aquire it. Signed-off-by: Robert Jarzmik --- Since v1: handle of_put_node() in codec removal

[PATCH v2 1/2] ALSA: ac97: add bus binding for codecs

2018-06-22 Thread Robert Jarzmik
Add the generic ac97 bus binding, especially for ac97 codecs discovered by ac97 hardware probing. Signed-off-by: Robert Jarzmik --- .../devicetree/bindings/sound/ac97-bus.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-22 Thread Robert Jarzmik
Takashi Iwai writes: >> Special review query: review the "return of_node_get(node)", which >> assumes that upon device removal, of_put_node(dev.of_node) will be >> called... > > Is it really done automagically? I couldn't spot it. Neither could I ... I based this on device_set_of_node_from_dev(

[PATCH 2/2] ALSA: ac97: add codecs devicetree binding

2018-06-21 Thread Robert Jarzmik
Add a devicetree binding for codecs. This is especially useful if the AC97 bitclk clock is provided by the codec, as it has to be described in the devicetree description for the ac97 bus code to aquire it. Signed-off-by: Robert Jarzmik --- Special review query: review the "return of_nod

[PATCH 1/2] ALSA: ac97: add bus binding for codecs

2018-06-21 Thread Robert Jarzmik
Add the generic ac97 bus binding, especially for ac97 codecs discovered by ac97 hardware probing. Signed-off-by: Robert Jarzmik --- .../devicetree/bindings/sound/ac97-bus.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH] ARM: pxa: zylonite: use the new ac97 bus support

2018-06-20 Thread Robert Jarzmik
Robert Jarzmik writes: > Now the PXA is converted to new ac97 bus support, the wm9713 is > automatically detected and probed. Remove it from the platform bus. > > Signed-off-by: Robert Jarzmik > --- > arch/arm/mach-pxa/zylonite.c | 11 --- > 1 file changed, 11 d

Re: [PATCH] ARM: pxa: add the missing AC97 clocks

2018-06-20 Thread Robert Jarzmik
Robert Jarzmik writes: > The AC97 bit clock is added as the pxa internally generated 13MHz > clock. This is a consequence of the new ac97 framework. > > Signed-off-by: Robert Jarzmik > --- > arch/arm/mach-pxa/devices.c | 13 + > 1 file changed, 13 insertions

Re: [PATCH] ARM: pxa: mioa701 convert to the new AC97 bus

2018-06-20 Thread Robert Jarzmik
Robert Jarzmik writes: > This migration implies : > - wm9713 device is removed, it will be auto-probed > > Signed-off-by: Robert Jarzmik > --- > arch/arm/mach-pxa/mioa701.c | 2 -- > 1 file changed, 2 deletions(-) Queued to pxa/for-next. -- Robert

Re: [PATCH] ARM: pxa: hx4700: fix the usb client

2018-06-20 Thread Robert Jarzmik
Robert Jarzmik writes: > The usb client of the hx4700 is not working because no platform data is > declared. Fix it by adding the missing call. > > Signed-off-by: Robert Jarzmik Queued to pxa/for-next. -- Robert

Re: [PATCH v3 00/14] ARM: pxa: switch to DMA slave maps

2018-06-20 Thread Robert Jarzmik
Boris Brezillon writes: > Don't worry, we're not planning to merge it unless it happens to be > required (Stephen Rothwell reporting a merge conflict in next), and we > don't have conflicting changes in the pipeline so far. Ok, great. We're good to go, no screaming from 0-day, my internal testbe

Re: [PATCH v3 00/14] ARM: pxa: switch to DMA slave maps

2018-06-18 Thread Robert Jarzmik
Boris Brezillon writes: > Hi Robert, > > On Sun, 17 Jun 2018 19:02:03 +0200 > Robert Jarzmik wrote: > >> As I gathered almost all the required acks, this is an information only post >> before queuing to the PXA tree. > > We'll need an immutable branch

[PATCH v2 2/2] ASoC: pxa: add devicetree support

2018-06-17 Thread Robert Jarzmik
Add the devicetree support, so that the driver can be used in a devictree platform. Signed-off-by: Robert Jarzmik --- Since v1: changed compatible string to pxa250-ac97, pxa270-ac97... --- sound/arm/pxa2xx-ac97-lib.c | 12 sound/soc/pxa/pxa2xx-ac97.c | 12 2 files

[PATCH v2 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-17 Thread Robert Jarzmik
This adds a binding for the Marvell PXA audio complex, available in pxa2xx and pxa3xx variants. Signed-off-by: Robert Jarzmik --- Since v1: Rob's review, compatible string, reset-gpios, status --- .../bindings/sound/marvell,pxa2xx-ac97.txt | 27 ++ 1 file change

Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-13 Thread Robert Jarzmik
Rob Herring writes: > On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: >> This adds a binding for the Marvell PXA audio complex, available in >> pxa2xx and pxa3xx variants. >> +Required properties: >> + - compatible: "marvell,pxa2xx-ac97"

[PATCH 2/2] ASoC: pxa: add devicetree support

2018-06-11 Thread Robert Jarzmik
Add the devicetree support, so that the driver can be used in a devictree platform. Signed-off-by: Robert Jarzmik --- sound/arm/pxa2xx-ac97-lib.c | 11 +++ sound/soc/pxa/pxa2xx-ac97.c | 10 ++ 2 files changed, 21 insertions(+) diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound

[PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex

2018-06-11 Thread Robert Jarzmik
This adds a binding for the Marvell PXA audio complex, available in pxa2xx and pxa3xx variants. Signed-off-by: Robert Jarzmik --- .../bindings/sound/marvell,pxa2xx-ac97.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree

Re: [RESEND v2] dmaengine: pxa: add a default requestor policy

2018-06-11 Thread Robert Jarzmik
Vinod Koul writes: > On 09-06-18, 14:43, Robert Jarzmik wrote: >> Robert Jarzmik writes: >> >> > As what former drcmr -1 value meant, add a this as a default to each >> > channel, ie. that by default no requestor line is used. >> > >> > This

Re: [RESEND v2] dmaengine: pxa: add a default requestor policy

2018-06-09 Thread Robert Jarzmik
Robert Jarzmik writes: > As what former drcmr -1 value meant, add a this as a default to each > channel, ie. that by default no requestor line is used. > > This is specifically used for network drivers smc91x and smc911x, and > needed for their port to slave maps. > > Cc: Ar

[PATCH] ARM: pxa: zylonite: use the new ac97 bus support

2018-06-03 Thread Robert Jarzmik
Now the PXA is converted to new ac97 bus support, the wm9713 is automatically detected and probed. Remove it from the platform bus. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/zylonite.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/arch/arm/mach-pxa/zylonite.c b/arch

[PATCH] mfd: wm97xx-core: platform data can be NULL

2018-06-03 Thread Robert Jarzmik
t;mfd: wm97xx-core: core support for wm97xx Codec") Signed-off-by: Robert Jarzmik --- drivers/mfd/wm97xx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/wm97xx-core.c b/drivers/mfd/wm97xx-core.c index 4141ee52a70b..f5a8347f837f 100644 --- a/drivers/mfd/wm9

[PATCH] ARM: pxa: add the missing AC97 clocks

2018-06-03 Thread Robert Jarzmik
The AC97 bit clock is added as the pxa internally generated 13MHz clock. This is a consequence of the new ac97 framework. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/mach-pxa/devices.c b/arch/arm/mach

[PATCH v9] ASoC: pxa: switch to new ac97 bus support

2018-06-03 Thread Robert Jarzmik
Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik --- Since v8: fixed the trivial compilation error v7 was in https://patchwork.kernel.org/patch/9951919/ --- sound/arm/Kconfig | 1 - sound/soc/pxa/Kconfig

Re: [PATCH v8] ASoC: pxa: switch to new ac97 bus support

2018-06-02 Thread Robert Jarzmik
Robert Jarzmik writes: > Switch to the new ac97 bus support in sound/ac97 instead of the legacy > snd_ac97 one. > + codecs_pdata = pdata ? pdata->codecs_pdata : NULL; It's a shame my automated build and test system didn't catch that : it should have been pdata->

[PATCH v8] ASoC: pxa: switch to new ac97 bus support

2018-06-02 Thread Robert Jarzmik
Switch to the new ac97 bus support in sound/ac97 instead of the legacy snd_ac97 one. Signed-off-by: Robert Jarzmik --- Since v7: added a NULL pointer check v7 was in https://patchwork.kernel.org/patch/9951919/ --- sound/arm/Kconfig | 1 - sound/soc/pxa/Kconfig | 5

[RESEND v2] dmaengine: pxa: add a default requestor policy

2018-05-30 Thread Robert Jarzmik
As what former drcmr -1 value meant, add a this as a default to each channel, ie. that by default no requestor line is used. This is specifically used for network drivers smc91x and smc911x, and needed for their port to slave maps. Cc: Arnd Bergmann Signed-off-by: Robert Jarzmik --- Since v1

[PATCH v2] dmaengine: pxa: add a default requestor policy

2018-05-30 Thread Robert Jarzmik
As what former drcmr -1 value meant, add a this as a default to each channel, ie. that by default no requestor line is used. This is specifically used for network drivers smc91x and smc911x, and needed for their port to slave maps. Cc: Arnd Bergmann Signed-off-by: Robert Jarzmik --- Since v1

Re: [RESEND PATCH] dmaengine: pxa: add a default requestor policy

2018-05-29 Thread Robert Jarzmik
Vinod writes: > On 26-05-18, 11:54, Robert Jarzmik wrote: >> @@ -762,6 +762,8 @@ static void pxad_free_chan_resources(struct dma_chan >> *dchan) >> dma_pool_destroy(chan->desc_pool); >> chan->desc_pool = NULL; >> >> +chan->drcmr

[PATCH] ARM: pxa: add the missing AC97 clocks

2018-05-27 Thread Robert Jarzmik
The AC97 bit clock is added as the pxa internally generated 13MHz clock. This is a consequence of the new ac97 framework. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/mach-pxa/devices.c b/arch/arm/mach

[PATCH] ARM: pxa: mioa701 convert to the new AC97 bus

2018-05-27 Thread Robert Jarzmik
This migration implies : - wm9713 device is removed, it will be auto-probed Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/mioa701.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c index 9b6c7ea45a40..04dc78d0809f 100644 --- a

[RESEND PATCH] dmaengine: pxa: add a default requestor policy

2018-05-26 Thread Robert Jarzmik
As what former drcmr -1 value meant, add a this as a default to each channel, ie. that by default no requestor line is used. This is specifically used for network drivers smc91x and smc911x, and needed for their port to slave maps. Cc: Arnd Bergmann Signed-off-by: Robert Jarzmik --- drivers

[PATCH] ARM: pxa: hx4700: fix the usb client

2018-05-26 Thread Robert Jarzmik
The usb client of the hx4700 is not working because no platform data is declared. Fix it by adding the missing call. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/hx4700.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-pxa/hx4700.c b/arch/arm/mach-pxa/hx4700.c index

[PATCH] mfd: asic3: Fix the broken MMC card detection

2018-05-26 Thread Robert Jarzmik
The MMC framework requires the ocr_mask to be provided. Without it, the SD card is not detected, especially on the hx4700 platform. Signed-off-by: Robert Jarzmik --- drivers/mfd/asic3.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c index

[PATCH] dmaengine: pxa: add a default requestor policy

2018-05-25 Thread Robert Jarzmik
As what former drcmr -1 value meant, add a this as a default to each channel, ie. that by default no requestor line is used. This is specifically used for network drivers smc91x and smc911x, and needed for their port to slave maps. Cc: Arnd Bergmann Signed-off-by: Robert Jarzmik --- drivers

Re: [PATCH v2 02/13] ARM: pxa: add dma slave map

2018-05-24 Thread Robert Jarzmik
Robert Jarzmik writes: > In order to remove the specific knowledge of the dma mapping from PXA > drivers, add a default slave map for pxa architectures. > > This is the first step, and once all drivers are converted, > pxad_filter_fn() will be made static, and the DMA resourc

Re: [PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need

2018-05-24 Thread Robert Jarzmik
Miquel Raynal writes: > Hi Robert, Actually, a last time error slipped in this patch here (I'm really doing poorly on the copy paste side): + nfc->dma_chan = dma_request_slave_channel(&nfc->dev, "data"); This should rather be : + nfc->dma_chan = dma_request_slave_channel(nfc->dev, "

  1   2   3   4   5   6   7   8   9   10   >