Fix 'and' typo (PT_WRITE_OK is defined 2)
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/block/paride/pt.c b/drivers/block/paride/pt.c
index 9f4e67e..b91accf 100644
--- a/drivers/block/paride/pt.c
+++ b/drivers/block/paride/pt.c
@@ -664,7 +664,7 @@ static int pt_open(struct
This includes some that I think I have reported earlier:
in drivers/media/dvb/dvb-usb/au6610.c
and drivers/media/dvb/dvb-usb/gl861.c
--
Some more unlocking issues
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/char/drm/sis_mm.c b/drivers/char/drm/sis_mm.c
Several unlocking issues
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/net/9p/mux.c b/net/9p/mux.c
index f140147..c9f0805 100644
--- a/net/9p/mux.c
+++ b/net/9p/mux.c
@@ -222,8 +222,10 @@ static int p9_mux_poll_start(struct p9_conn *m)
}
Several unlocking issues
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/net/9p/mux.c b/net/9p/mux.c
index f140147..c9f0805 100644
--- a/net/9p/mux.c
+++ b/net/9p/mux.c
@@ -222,8 +222,10 @@ static int p9_mux_poll_start(struct p9_conn *m)
}
if (i
This includes some that I think I have reported earlier:
in drivers/media/dvb/dvb-usb/au6610.c
and drivers/media/dvb/dvb-usb/gl861.c
--
Some more unlocking issues
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/char/drm/sis_mm.c b/drivers/char/drm/sis_mm.c
index
Fix unlock on error
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c
index a0a9105..a6e6e78 100644
--- a/arch/mips/kernel/irixsig.c
+++ b/arch/mips/kernel/irixsig.c
@@ -426,6 +426,7 @@ asmlinkage int irix_sigprocma
Unlock when sn_oemdata can't be extended
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/ia64/sn/kernel/mca.c b/arch/ia64/sn/kernel/mca.c
index 3db62f2..868c9aa 100644
--- a/arch/ia64/sn/kernel/mca.c
+++ b/arch/ia64/sn/kernel/mca.c
@@ -98,6
Fix unlocking before return in gpio
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/cris/arch-v10/drivers/gpio.c
b/arch/cris/arch-v10/drivers/gpio.c
index f389ed6..0d347a7 100644
--- a/arch/cris/arch-v10/drivers/gpio.c
+++ b/arch/cris/arch-v10/drivers/gpio.c
@@
Unlock when ssp tries to close an invalid port
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/arm/mach-pxa/ssp.c b/arch/arm/mach-pxa/ssp.c
index 71766ac..422afee 100644
--- a/arch/arm/mach-pxa/ssp.c
+++ b/arch/arm/mach-pxa/ssp.c
@@ -309,6 +309,7 @@ void ssp_exit(
.
--
Move check before lock
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/media/dvb/dvb-usb/au6610.c
b/drivers/media/dvb/dvb-usb/au6610.c
index 18e0b16..f3ff813 100644
--- a/drivers/media/dvb/dvb-usb/au6610.c
+++ b/drivers/media/dvb/dvb-usb/au6610.c
@@ -79,12 +79,12 @@
Andreas Schwab wrote:
-if (num 2)
+if (num 2) {
+mutex_unlock(d-i2c_mutex);
return -EINVAL;
How about moving the check before the lock?
Good suggestion. Patch below covers both previous patches.
--
Move check before lock
Signed-off-by: Roel Kluin
Unlock when ssp tries to close an invalid port
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/arm/mach-pxa/ssp.c b/arch/arm/mach-pxa/ssp.c
index 71766ac..422afee 100644
--- a/arch/arm/mach-pxa/ssp.c
+++ b/arch/arm/mach-pxa/ssp.c
@@ -309,6 +309,7 @@ void ssp_exit(struct
Fix unlocking before return in gpio
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/cris/arch-v10/drivers/gpio.c
b/arch/cris/arch-v10/drivers/gpio.c
index f389ed6..0d347a7 100644
--- a/arch/cris/arch-v10/drivers/gpio.c
+++ b/arch/cris/arch-v10/drivers/gpio.c
@@ -297,8
Unlock when sn_oemdata can't be extended
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/ia64/sn/kernel/mca.c b/arch/ia64/sn/kernel/mca.c
index 3db62f2..868c9aa 100644
--- a/arch/ia64/sn/kernel/mca.c
+++ b/arch/ia64/sn/kernel/mca.c
@@ -98,6 +98,7
Fix unlock on error
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/mips/kernel/irixsig.c b/arch/mips/kernel/irixsig.c
index a0a9105..a6e6e78 100644
--- a/arch/mips/kernel/irixsig.c
+++ b/arch/mips/kernel/irixsig.c
@@ -426,6 +426,7 @@ asmlinkage int irix_sigprocmask(int
I think we should keep the lmc_tracing. Use this patch instead.
--
Several returns before unlocking in lmc_ioctl
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
index 5ea8772..64eb578 100644
--- a/d
commit 9f822afc65cc094c905901f9d92bf25042f9ed22
Author: Roel Kluin <[EMAIL PROTECTED]>
Date: Tue Oct 23 03:15:55 2007 +0200
Unlock before return in p9_mux_poll_start
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
diff --git a/net/9p/mux.c b/net/9p/mux.c
index f140
commit 61c31efe4e9c34531666a6c5857ecd19c8db
Author: Roel Kluin <[EMAIL PROTECTED]>
Date: Tue Oct 23 03:08:27 2007 +0200
Unlock in iTCO_wdt_start when reboot is disabled
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
diff --git a/drivers/watchdog/iTCO_wdt.c b/driv
Several returns before unlocking in lmc_ioctl
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
index 5ea8772..af7b3e4 100644
--- a/drivers/net/wan/lmc/lmc_main.c
+++ b/drivers/net/wan/lmc/lmc_
And a similar one in drivers/media/dvb/dvb-usb/gl861.c
--
unlock 12c_mutex before return -EINVAL
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/media/dvb/dvb-usb/gl861.c
b/drivers/media/dvb/dvb-usb/gl861.c
index f01d99c..20c340a 100644
--- a/drivers/med
unlock 12c_mutex before return -EINVAL
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/media/dvb/dvb-usb/au6610.c
b/drivers/media/dvb/dvb-usb/au6610.c
index 18e0b16..31f47c7 100644
--- a/drivers/media/dvb/dvb-usb/au6610.c
+++ b/drivers/media/dvb/dvb-usb/
the "return;" delete from your
> original patch changes behaviour for !CONFIG_BUG, and probably not for
> the better).
>
> Rene.
Thanks for your comments. A patch containing this suggestion is:
[PATCH retry] return hidden bug and unlock bugs.
Roel
-
To unsubscribe from this list:
Roel Kluin wrote:
> This patches shouldn't alter behavior when CONFIG_BUG is disabled. It is meant
> as a replacement for the previous patches.
>
> Concerning the patch changing fs/buffer.c, I am still wondering whether
> "page_cache_release(page)" should be place
se you're risking turning what was a
> working system into one that doesn't.
No, I haven't and, I will change it, but it's included with my other
changes. see the reply that I'll write shortly for.
[PATCH retry] return hidden bug and unlock bugs.
Roel
-
To unsubscribe from this list: send th
Ray Lee wrote:
> I'm sorry, perhaps I poured myself a cup of stupid this morning, but
> isn't the above patch effectively introducing a BUG where none could
> be reached before? In other words, for the patch to have zero
> behavioral change, wouldn't it have to remove the BUG() altogether?
True,
before BUG(), but don't change behavior in the case when
CONFIG_BUG is disabled
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c
index e1c4707..6a69425 100644
--- a/arch/alpha/kernel/pci_iommu.c
+++ b/a
ome cases where it was attempted to free after BUG().
should that occur before BUG() as well?
--
Unlock before BUG()
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index 88629a3..679c8b4 100644
--- a/drivers/mtd/ubi
that occur before BUG() as well?
--
Unlock before BUG()
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index 88629a3..679c8b4 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -100,8 +100,10 @@ static ssize_t
(), but don't change behavior in the case when
CONFIG_BUG is disabled
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c
index e1c4707..6a69425 100644
--- a/arch/alpha/kernel/pci_iommu.c
+++ b/arch/alpha/kernel/pci_iommu.c
Ray Lee wrote:
I'm sorry, perhaps I poured myself a cup of stupid this morning, but
isn't the above patch effectively introducing a BUG where none could
be reached before? In other words, for the patch to have zero
behavioral change, wouldn't it have to remove the BUG() altogether?
True, but
will change it, but it's included with my other
changes. see the reply that I'll write shortly for.
[PATCH retry] return hidden bug and unlock bugs.
Roel
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Roel Kluin wrote:
This patches shouldn't alter behavior when CONFIG_BUG is disabled. It is meant
as a replacement for the previous patches.
Concerning the patch changing fs/buffer.c, I am still wondering whether
page_cache_release(page) should be placed before or after the BUG
changes behaviour for !CONFIG_BUG, and probably not for
the better).
Rene.
Thanks for your comments. A patch containing this suggestion is:
[PATCH retry] return hidden bug and unlock bugs.
Roel
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
unlock 12c_mutex before return -EINVAL
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/media/dvb/dvb-usb/au6610.c
b/drivers/media/dvb/dvb-usb/au6610.c
index 18e0b16..31f47c7 100644
--- a/drivers/media/dvb/dvb-usb/au6610.c
+++ b/drivers/media/dvb/dvb-usb/au6610.c
And a similar one in drivers/media/dvb/dvb-usb/gl861.c
--
unlock 12c_mutex before return -EINVAL
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/media/dvb/dvb-usb/gl861.c
b/drivers/media/dvb/dvb-usb/gl861.c
index f01d99c..20c340a 100644
--- a/drivers/media/dvb
Several returns before unlocking in lmc_ioctl
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
index 5ea8772..af7b3e4 100644
--- a/drivers/net/wan/lmc/lmc_main.c
+++ b/drivers/net/wan/lmc/lmc_main.c
@@ -142,9
commit 61c31efe4e9c34531666a6c5857ecd19c8db
Author: Roel Kluin [EMAIL PROTECTED]
Date: Tue Oct 23 03:08:27 2007 +0200
Unlock in iTCO_wdt_start when reboot is disabled
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog
commit 9f822afc65cc094c905901f9d92bf25042f9ed22
Author: Roel Kluin [EMAIL PROTECTED]
Date: Tue Oct 23 03:15:55 2007 +0200
Unlock before return in p9_mux_poll_start
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
diff --git a/net/9p/mux.c b/net/9p/mux.c
index f140147..c9f0805 100644
I think we should keep the lmc_tracing. Use this patch instead.
--
Several returns before unlocking in lmc_ioctl
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
index 5ea8772..64eb578 100644
--- a/drivers
Roel Kluin wrote:
> unlock before bug returns
> if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) {
> printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs);
> - BUG();
> spin_unlock(_mem_lock);
> -
I think the unlock should be before bugging?
--
unlock before bug returns
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 5a4cc20..c910170 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach
Rik van Riel wrote:
> On Mon, 22 Oct 2007 03:05:05 +0200
> Roel Kluin <[EMAIL PROTECTED]> wrote:
>
>> return hidden bug
>>
>> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
>>
>> diff --git a/arch/alpha/kernel/pci_iommu.c
>&g
return hidden bug
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c
index e1c4707..6a69425 100644
--- a/arch/alpha/kernel/pci_iommu.c
+++ b/arch/alpha/kernel/pci_iommu.c
@@ -365,8 +365,8 @@ pci_unmap_single(
Roel Kluin wrote:
> I am not entirely certain about the third one:
>
> from fs/udf/udf_sb.h:
>
> #define UDF_SB_VAT(X) ( UDF_SB(X)->s_vat )
>
> if it's the desired behavior then I think this should at least be changed to
>
> UDF
ors with assignments in ifs
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index d9af436..e6e85b7 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -651,7 +651,7 @@ static u32 omap2_get_c
with assignments in ifs
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index d9af436..e6e85b7 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -651,7 +651,7 @@ static u32 omap2_get_clksel(u32
Roel Kluin wrote:
I am not entirely certain about the third one:
from fs/udf/udf_sb.h:
#define UDF_SB_VAT(X) ( UDF_SB(X)-s_vat )
if it's the desired behavior then I think this should at least be changed to
UDF_SB_VAT(sb) = udf_iget(sb, ino);
if (!(UDF_SB_VAT
return hidden bug
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c
index e1c4707..6a69425 100644
--- a/arch/alpha/kernel/pci_iommu.c
+++ b/arch/alpha/kernel/pci_iommu.c
@@ -365,8 +365,8 @@ pci_unmap_single(struct
Rik van Riel wrote:
On Mon, 22 Oct 2007 03:05:05 +0200
Roel Kluin [EMAIL PROTECTED] wrote:
return hidden bug
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
diff --git a/arch/alpha/kernel/pci_iommu.c
b/arch/alpha/kernel/pci_iommu.c index e1c4707..6a69425 100644
--- a/arch/alpha
I think the unlock should be before bugging?
--
unlock before bug returns
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
index 5a4cc20..c910170 100644
--- a/arch/arm/mach-omap2/gpmc.c
+++ b/arch/arm/mach-omap2
Roel Kluin wrote:
unlock before bug returns
if (cs = GPMC_CS_NUM || !gpmc_cs_reserved(cs)) {
printk(KERN_ERR Trying to free non-reserved GPMC CS%d\n, cs);
- BUG();
spin_unlock(gpmc_mem_lock);
- return;
+ BUG
Gregory Haskins wrote:
> We can avoid dirtying a rq related cacheline with a simple check, so why not.
>
> Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]>
> ---
>
> 0 files changed, 0 insertions(+), 0 deletions(-)
I think you wanted a patch here?
-
To unsubscribe from this list: send the
Gregory Haskins wrote:
We can avoid dirtying a rq related cacheline with a simple check, so why not.
Signed-off-by: Gregory Haskins [EMAIL PROTECTED]
---
0 files changed, 0 insertions(+), 0 deletions(-)
I think you wanted a patch here?
-
To unsubscribe from this list: send the line
previously applied changes removed and changed as suggested.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
index 7dce318..752ae26 100644
--- a/drivers/misc/asus-laptop.c
+++ b/drivers/misc/asus-laptop.c
@@ -322,7
Al Viro wrote:
> On Wed, Oct 17, 2007 at 03:46:43PM +0200, Roel Kluin wrote:
>> +++ b/drivers/misc/asus-laptop.c
>> @@ -322,7 +322,7 @@ static void write_status(acpi_handle handle, int out,
>> int mask)
>>
>> switch (mask) {
>> case ML
Thanks for comments, here a second version with previously covered commits
removed
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c
index 5cd3cad..7229319 100644
--- a/arch/arm/mach-pxa/mfp.c
+++ b/arch/arm/ma
Thanks for comments, here a second version with previously covered commits
removed
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c
index 5cd3cad..7229319 100644
--- a/arch/arm/mach-pxa/mfp.c
+++ b/arch/arm/mach-pxa/mfp.c
Al Viro wrote:
On Wed, Oct 17, 2007 at 03:46:43PM +0200, Roel Kluin wrote:
+++ b/drivers/misc/asus-laptop.c
@@ -322,7 +322,7 @@ static void write_status(acpi_handle handle, int out,
int mask)
switch (mask) {
case MLED_ON:
-out = !out 0x1;
+out = !(out
previously applied changes removed and changed as suggested.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
index 7dce318..752ae26 100644
--- a/drivers/misc/asus-laptop.c
+++ b/drivers/misc/asus-laptop.c
@@ -322,7 +322,7
if(!x & y) should either be if(!(x & y)) or if(!x && y)
I made changes as seemed appropriate, but please review
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c
index 5cd3cad..7229319 100644
-
Roel Kluin wrote:
> if(!x & y) should either be if(!(x & y)) or if(!x && y)
> I made changes as seemed appropriate, but please review
>
> several changes to drivers/net/
>
> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
>
hmmm
commit 568f9787e58b4d24be50ab2abf1c7dab12a9ef2c
Author: Roel Kluin <[EMAIL PROTECTED]>
Date: Wed Oct 17 15:16:44 2007 +0200
if(!x & y) should either be if(!(x & y)) or if(!x && y)
I made changes as seemed appropriate, but please review
several c
if(!x & y) should either be if(!(x & y)) or if(!x && y)
I made changes as seemed appropriate, but please review
several changes to drivers/net/
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
diff --git a/drivers/net/e1000e/82571.c b/drivers/ne
if(!x & y) should either be if(!(x & y)) or if(!x && y)
I made changes as seemed appropriate, but please review
this is against current git.
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/drivers/media/video/pvrusb2/pvrusb2-ctrl.c
b/drive
if(!x y) should either be if(!(x y)) or if(!x y)
I made changes as seemed appropriate, but please review
this is against current git.
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/drivers/media/video/pvrusb2/pvrusb2-ctrl.c
b/drivers/media/video/pvrusb2
Roel Kluin wrote:
if(!x y) should either be if(!(x y)) or if(!x y)
I made changes as seemed appropriate, but please review
several changes to drivers/net/
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
hmmm forgot to place '---' here, should I resend?
diff --git
if(!x y) should either be if(!(x y)) or if(!x y)
I made changes as seemed appropriate, but please review
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/arm/mach-pxa/mfp.c b/arch/arm/mach-pxa/mfp.c
index 5cd3cad..7229319 100644
--- a/arch/arm/mach-pxa/mfp.c
if(!x y) should either be if(!(x y)) or if(!x y)
I made changes as seemed appropriate, but please review
several changes to drivers/net/
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c
index cf70522
commit 568f9787e58b4d24be50ab2abf1c7dab12a9ef2c
Author: Roel Kluin [EMAIL PROTECTED]
Date: Wed Oct 17 15:16:44 2007 +0200
if(!x y) should either be if(!(x y)) or if(!x y)
I made changes as seemed appropriate, but please review
several changes to drivers/isdn/
Signed
Since you were sending a fix, possibly I shouldn't comment on this. If so
please disregard my
suggestion for a trivial cleanup.
Roel
Maciej W. Rozycki wrote:
> +void tty_termios_encode_baud_rate(struct ktermios *termios,
> + speed_t ibaud, speed_t
Since you were sending a fix, possibly I shouldn't comment on this. If so
please disregard my
suggestion for a trivial cleanup.
Roel
Maciej W. Rozycki wrote:
+void tty_termios_encode_baud_rate(struct ktermios *termios,
+ speed_t ibaud, speed_t obaud
Bryan Wu wrote:
> +static int ad7142_i2c_read(struct i2c_client *client, unsigned short offset,
> + unsigned short *data, unsigned int len)
> +{
> + int ret = -1;
> + int i;
> + u8 block_data[32];
> +
> + if (len < 1 && len > 16) {
you want || here
> +
Bryan Wu wrote:
+static int ad7142_i2c_read(struct i2c_client *client, unsigned short offset,
+ unsigned short *data, unsigned int len)
+{
+ int ret = -1;
+ int i;
+ u8 block_data[32];
+
+ if (len 1 len 16) {
you want || here
+ printk(KERN_ERR
It is very well possible that I misunderstand the locking order here,
but FWIW:
David Howells wrote:
> diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c
> index f346eb1..76798c9 100644
> --- a/fs/bfs/inode.c
> +++ b/fs/bfs/inode.c
> @@ -32,25 +32,29 @@ MODULE_LICENSE("GPL");
>
> void
It is very well possible that I misunderstand the locking order here,
but FWIW:
David Howells wrote:
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c
index f346eb1..76798c9 100644
--- a/fs/bfs/inode.c
+++ b/fs/bfs/inode.c
@@ -32,25 +32,29 @@ MODULE_LICENSE(GPL);
void dump_imap(const char
Mark M. Hoffman wrote:
>> +static void ibmpex_register_bmc(int iface, struct device *dev)
>> +{
>> +struct ibmpex_bmc_data *data;
>> +int err;
>> +
>> +data = kzalloc(sizeof(*data), GFP_KERNEL);
>> +if (!data) {
>> +printk(KERN_ERR DRVNAME ": Insufficient memory for BMC
Mark M. Hoffman wrote:
+static void ibmpex_register_bmc(int iface, struct device *dev)
+{
+struct ibmpex_bmc_data *data;
+int err;
+
+data = kzalloc(sizeof(*data), GFP_KERNEL);
+if (!data) {
+printk(KERN_ERR DRVNAME : Insufficient memory for BMC
+
Greg KH wrote:
@@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp,
if (block == NULL) {
struct file_lock *conf = kzalloc(sizeof(*conf), GFP_KERNEL);
+ struct nlm_host *host;
if (conf == NULL)
return
Greg KH wrote:
@@ -477,10 +479,15 @@ nlmsvc_testlock(struct svc_rqst *rqstp,
if (block == NULL) {
struct file_lock *conf = kzalloc(sizeof(*conf), GFP_KERNEL);
+ struct nlm_host *host;
if (conf == NULL)
return
Jeff Dike wrote:
> On Fri, Sep 28, 2007 at 12:56:31PM +0200, Roel Kluin wrote:
>> arch/um/kernel/tt/ptproxy/ptrace.c | 12 ++--
>
> I don't know what you're diffing against, but this file is history in
> -mm, and will be gone in mainline after 2.6.23.
>
> J
Please use this one instead. it also removes an unnecessary #define.
This patch changes code to use the ARRAY_SIZE macro. This patch is the result
of:
find -name *.[chsS] | xargs sed -i "s/sizeof(\(\w*\))[ \t]*\/[
\t]*sizeof(\1\[0\])/ARRAY_SIZE(\1)/g"
Signed-off-by: Roel Klu
This patch changes code to use the ARRAY_SIZE macro. This patch is the result
of:
find -name *.[chsS] | xargs sed -i "s/sizeof(\(\w*\))[ \t]*\/[
\t]*sizeof(\1\[0\])/ARRAY_SIZE(\1)/g"
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/arm/kernel/dma-isa.c b/arc
Please use this one instead. it also removes an unnecessary #define.
This patch changes code to use the ARRAY_SIZE macro. This patch is the result
of:
find -name *.[chsS] | xargs sed -i s/sizeof(\(\w*\))[ \t]*\/[
\t]*sizeof(\1\[0\])/ARRAY_SIZE(\1)/g
Signed-off-by: Roel Kluin [EMAIL PROTECTED
This patch changes code to use the ARRAY_SIZE macro. This patch is the result
of:
find -name *.[chsS] | xargs sed -i s/sizeof(\(\w*\))[ \t]*\/[
\t]*sizeof(\1\[0\])/ARRAY_SIZE(\1)/g
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/arm/kernel/dma-isa.c b/arch/arm/kernel/dma-isa.c
Jeff Dike wrote:
On Fri, Sep 28, 2007 at 12:56:31PM +0200, Roel Kluin wrote:
arch/um/kernel/tt/ptproxy/ptrace.c | 12 ++--
I don't know what you're diffing against, but this file is history in
-mm, and will be gone in mainline after 2.6.23.
Jeff
Thanks for noting me. I
-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
Documentation/spi/spidev_test.c|2 --
arch/i386/boot/compressed/relocs.c |1 -
arch/m68k/amiga/amisound.c |3 +--
arch/powerpc/boot/types.h |2 --
arch/sparc64/kernel/pci.c |6 ++
drivers/acpi/uti
Replace some SPIN_LOCK_UNLOCKED with DEFINE_SPINLOCK
Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
---
diff --git a/arch/mips/pci/ops-pmcmsp.c b/arch/mips/pci/ops-pmcmsp.c
index 09fa007..059eade 100644
--- a/arch/mips/pci/ops-pmcmsp.c
+++ b/arch/mips/pci/ops-pmcmsp.c
@@ -206,7 +206,7 @@
s_lock is held */
>>> +static void update_target(int i)
>> I'd prefer a better arg name than 'i'.
>
> I do too, but i in this case is an Index.
I think in many cases you could use a pointer to qos_array[i] instead of
passing this index 'i' as a function argument.
Roel
-
To un
in many cases you could use a pointer to qos_array[i] instead of
passing this index 'i' as a function argument.
Roel
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Replace some SPIN_LOCK_UNLOCKED with DEFINE_SPINLOCK
Signed-off-by: Roel Kluin [EMAIL PROTECTED]
---
diff --git a/arch/mips/pci/ops-pmcmsp.c b/arch/mips/pci/ops-pmcmsp.c
index 09fa007..059eade 100644
--- a/arch/mips/pci/ops-pmcmsp.c
+++ b/arch/mips/pci/ops-pmcmsp.c
@@ -206,7 +206,7 @@ static void
-off-by: Roel Kluin [EMAIL PROTECTED]
---
Documentation/spi/spidev_test.c|2 --
arch/i386/boot/compressed/relocs.c |1 -
arch/m68k/amiga/amisound.c |3 +--
arch/powerpc/boot/types.h |2 --
arch/sparc64/kernel/pci.c |6 ++
drivers/acpi/utilities
Erez Zadok wrote:
> @@ -194,7 +194,7 @@ int check_empty(struct dentry *dentry, struct
> unionfs_dir_state **namelist)
>
> BUG_ON(!S_ISDIR(dentry->d_inode->i_mode));
>
> - if ((err = unionfs_partial_lookup(dentry)))
> + if (unlikely((err = unionfs_partial_lookup(dentry
>
Erez Zadok wrote:
> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>
> ---
> fs/unionfs/debug.c | 108 +++
> 1 files changed, 57 insertions(+), 51 deletions(-)
>
> diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c
> index 9546a41..09b52ce 100644
>
Matthew Wilcox wrote:
> On Wed, Sep 26, 2007 at 09:47:41PM +0200, roel wrote:
>> The brackets in the first if/else are not required, and you could combine
>> the two statements:
>
> You mean braces, not brackets. And I find this little fetish of yours
> highly dist
Guillaume Chazarain wrote:
[...]
> @@ -65,13 +65,15 @@ void bacct_add_tsk(struct taskstats *stats, struct
> task_struct *tsk)
> void bacct_fill_threadgroup(struct taskstats *stats, struct task_struct *tsk,
> bool tg_stats)
> {
> + int group_exit_code;
> +
>
Matthew Wilcox wrote:
[...]
> @@ -142,14 +144,13 @@ struct dma_pool *dma_pool_create(const char *name,
> struct device *dev,
> if ((size % align) != 0)
> size = ALIGN(size, align);
>
> - if (allocation == 0) {
> - if (PAGE_SIZE < size)
> -
Matthew Wilcox wrote:
[...]
> @@ -113,9 +133,12 @@ struct dma_pool *dma_pool_create(const char *name,
> struct device *dev,
> return NULL;
> }
>
> - if (size == 0)
> + if (size == 0) {
> return NULL;
> -
> + } else if (size < 4) {
> +
Matthew Wilcox wrote:
> Check that 'align' is a power of two, like the API specifies.
> Align 'size' to 'align' correctly -- the current code has an off-by-one.
> The ALIGN macro in kernel.h doesn't.
>
> Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
> ---
> mm/dmapool.c | 15
e rc is
returned anyway...
> + } else {
> + printk(KERN_INFO "No iBFT detected.\n");
> + }
these brackets are not required either
> + return rc;
... here
> +}
[...]
Roel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
in file ./drivers/net/forcedeth.c
line 2142 of current git I have a
for (i=0;i<=np->register_size;i+= 32) {
^
shouldn't this be a '<'
In the same file on line 4015:
for (i = 0;i <= np->register_size/sizeof(u32); i++)
shouldn't the "<=" be a '<'?
Roel
201 - 300 of 335 matches
Mail list logo