Re: next: s390 crash due to 's390: move sys_call_table and last_break from thread_info to thread_struct'

2016-11-15 Thread Martin Schwidefsky
On Tue, 15 Nov 2016 07:35:54 -0800 Guenter Roeck wrote: > Hi Martin, > > my s390 qemu boot test crashes in -next as follows. > > Kernel stack overflow. > CPU: 0 PID: 923 Comm: modprobe Not tainted 4.9.0-rc5-next-20161115 #1 > Hardware name: QEMU QEMU

Re: next: s390 crash due to 's390: move sys_call_table and last_break from thread_info to thread_struct'

2016-11-15 Thread Martin Schwidefsky
On Tue, 15 Nov 2016 07:35:54 -0800 Guenter Roeck wrote: > Hi Martin, > > my s390 qemu boot test crashes in -next as follows. > > Kernel stack overflow. > CPU: 0 PID: 923 Comm: modprobe Not tainted 4.9.0-rc5-next-20161115 #1 > Hardware name: QEMU QEMU QEMU

Re: [PATCHv2 0/2] THREAD_INFO_IN_TASK prep work for arm64+s390

2016-11-11 Thread Martin Schwidefsky
On Fri, 11 Nov 2016 10:16:22 +0100 Heiko Carstens wrote: > Hi Mark, > > > On Wed, Nov 02, 2016 at 03:56:26PM +, Mark Rutland wrote: > > > On Wed, Oct 26, 2016 at 06:43:05PM +0100, Mark Rutland wrote: > > > > Heiko and I have been working on THREAD_INFO_IN_TASK for

Re: [PATCHv2 0/2] THREAD_INFO_IN_TASK prep work for arm64+s390

2016-11-11 Thread Martin Schwidefsky
On Fri, 11 Nov 2016 10:16:22 +0100 Heiko Carstens wrote: > Hi Mark, > > > On Wed, Nov 02, 2016 at 03:56:26PM +, Mark Rutland wrote: > > > On Wed, Oct 26, 2016 at 06:43:05PM +0100, Mark Rutland wrote: > > > > Heiko and I have been working on THREAD_INFO_IN_TASK for s390 and arm64 > > > >

[PATCH] sched/cpuacct: avoid %lld seq_printf warning

2016-11-11 Thread Martin Schwidefsky
lld\n", Silence the warning by adding an explicit cast. Cc: Peter Zijlstra <pet...@infradead.org> Signed-off-by: Martin Schwidefsky <schwidef...@de.ibm.com> --- kernel/sched/cpuacct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/cpuacct.c b/

[PATCH] sched/cpuacct: avoid %lld seq_printf warning

2016-11-11 Thread Martin Schwidefsky
lld\n", Silence the warning by adding an explicit cast. Cc: Peter Zijlstra Signed-off-by: Martin Schwidefsky --- kernel/sched/cpuacct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/cpuacct.c b/kernel/sched/cpuacct.c index bc0b309c..21072bb 100644 --- a/ke

[GIT PULL] two bug fixes for 4.9-rc5

2016-11-09 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: Two bug fixes * A memory alignment fix in the s390 only hypfs code * A fix for the generic percpu code that caused ftrace to

[GIT PULL] two bug fixes for 4.9-rc5

2016-11-09 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: Two bug fixes * A memory alignment fix in the s390 only hypfs code * A fix for the generic percpu code that caused ftrace to

Re: [PATCH] percpu: use notrace variant of preempt_disable/preempt_enable

2016-11-08 Thread Martin Schwidefsky
On Mon, 7 Nov 2016 12:27:16 -0500 Steven Rostedt wrote: > On Thu, 3 Nov 2016 14:58:38 +0100 > Heiko Carstens wrote: > > > Commit 345ddcc882d8 ("ftrace: Have set_ftrace_pid use the bitmap like > > events do") added a couple of this_cpu_read calls

Re: [PATCH] percpu: use notrace variant of preempt_disable/preempt_enable

2016-11-08 Thread Martin Schwidefsky
On Mon, 7 Nov 2016 12:27:16 -0500 Steven Rostedt wrote: > On Thu, 3 Nov 2016 14:58:38 +0100 > Heiko Carstens wrote: > > > Commit 345ddcc882d8 ("ftrace: Have set_ftrace_pid use the bitmap like > > events do") added a couple of this_cpu_read calls to the ftrace code. > > > > On x86 this is not

Re: [PATCH] s390: remove unneeded dependency for gen_facilities

2016-11-08 Thread Martin Schwidefsky
On Tue, 8 Nov 2016 08:45:28 +0100 Heiko Carstens wrote: > On Tue, Nov 08, 2016 at 10:55:47AM +0900, Masahiro Yamada wrote: > > The dependency between the object and the source is handled by > > scripts/Makefile.host, so only "hostprogs-y += gen_facilities" > > is fine.

Re: [PATCH] s390: remove unneeded dependency for gen_facilities

2016-11-08 Thread Martin Schwidefsky
On Tue, 8 Nov 2016 08:45:28 +0100 Heiko Carstens wrote: > On Tue, Nov 08, 2016 at 10:55:47AM +0900, Masahiro Yamada wrote: > > The dependency between the object and the source is handled by > > scripts/Makefile.host, so only "hostprogs-y += gen_facilities" > > is fine. > > > > Signed-off-by:

[PATCH] x86/preempt: do not clear PREEMPT_NEED_RESCHED on preempt count reset

2016-11-07 Thread Martin Schwidefsky
of the reset, the preemption indication is lost. Use raw_cpu_cmpxchg_4 to reset only the count part and leave the PREEMPT_NEED_RESCHED bit as it is. Signed-off-by: Martin Schwidefsky <schwidef...@de.ibm.com> --- arch/x86/include/asm/preempt.h | 8 +++- 1 file changed, 7 insertions

[PATCH] x86/preempt: do not clear PREEMPT_NEED_RESCHED on preempt count reset

2016-11-07 Thread Martin Schwidefsky
of the reset, the preemption indication is lost. Use raw_cpu_cmpxchg_4 to reset only the count part and leave the PREEMPT_NEED_RESCHED bit as it is. Signed-off-by: Martin Schwidefsky --- arch/x86/include/asm/preempt.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-07 Thread Martin Schwidefsky
On Mon, 7 Nov 2016 08:03:22 +0100 Heiko Carstens wrote: > On Sun, Nov 06, 2016 at 12:45:28PM +0900, Masahiro Yamada wrote: > > We generally expect headers in arch/$(ARCH)/include/asm directory > > are included from kernel sources, but facilities_src.h is not; > > it is

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

2016-11-07 Thread Martin Schwidefsky
On Mon, 7 Nov 2016 08:03:22 +0100 Heiko Carstens wrote: > On Sun, Nov 06, 2016 at 12:45:28PM +0900, Masahiro Yamada wrote: > > We generally expect headers in arch/$(ARCH)/include/asm directory > > are included from kernel sources, but facilities_src.h is not; > > it is included from the

Re: [PATCH 3/4] cputime/powerpc/s390: make scaled cputime arch specific

2016-11-02 Thread Martin Schwidefsky
On Wed, 2 Nov 2016 10:38:20 +0100 Stanislaw Gruszka wrote: > On Wed, Nov 02, 2016 at 10:11:22AM +0100, Christian Borntraeger wrote: > > On 10/31/2016 01:36 PM, Stanislaw Gruszka wrote: > > > Only s390 and powerpc have hardware facilities allowing to measure > > > cputimes

Re: [PATCH 3/4] cputime/powerpc/s390: make scaled cputime arch specific

2016-11-02 Thread Martin Schwidefsky
On Wed, 2 Nov 2016 10:38:20 +0100 Stanislaw Gruszka wrote: > On Wed, Nov 02, 2016 at 10:11:22AM +0100, Christian Borntraeger wrote: > > On 10/31/2016 01:36 PM, Stanislaw Gruszka wrote: > > > Only s390 and powerpc have hardware facilities allowing to measure > > > cputimes scaled by frequency. On

Re: [PATCH 3/3] s390: char: make slp_ctl explicitly non-modular

2016-10-30 Thread Martin Schwidefsky
sage, so that when reading > the driver there is no doubt it is builtin-only. > > Since module_misc_device translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > Cc: Martin Schwidefsky <schwidef...@de.ibm.com> >

Re: [PATCH 3/3] s390: char: make slp_ctl explicitly non-modular

2016-10-30 Thread Martin Schwidefsky
> the driver there is no doubt it is builtin-only. > > Since module_misc_device translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Paul Gortmaker > Cc: Michael Ho

[GIT PULL] s390 patches for 4.9-rc3

2016-10-25 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: A few more s390 patches for 4.9: - A fix for an overflow in the dasd driver reported by UBSAN - Fix a regression and add

[GIT PULL] s390 patches for 4.9-rc3

2016-10-25 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: A few more s390 patches for 4.9: - A fix for an overflow in the dasd driver reported by UBSAN - Fix a regression and add

Re: [PATCH 25/28] s390: pci: don't print uninitialized data for debugging

2016-10-18 Thread Martin Schwidefsky
On Tue, 18 Oct 2016 00:16:13 +0200 Arnd Bergmann wrote: > gcc correctly warns about an incorrect use of the 'pa' variable > in case we pass an empty scatterlist to __s390_dma_map_sg: > > arch/s390/pci/pci_dma.c: In function '__s390_dma_map_sg': > arch/s390/pci/pci_dma.c:309:13:

Re: [PATCH 25/28] s390: pci: don't print uninitialized data for debugging

2016-10-18 Thread Martin Schwidefsky
On Tue, 18 Oct 2016 00:16:13 +0200 Arnd Bergmann wrote: > gcc correctly warns about an incorrect use of the 'pa' variable > in case we pass an empty scatterlist to __s390_dma_map_sg: > > arch/s390/pci/pci_dma.c: In function '__s390_dma_map_sg': > arch/s390/pci/pci_dma.c:309:13: warning: 'pa'

[GIT PULL] s390 patches for 4.9 merge window #1

2016-10-04 Thread Martin Schwidefsky
facility mask from readable list Markus Elfring (1): s390/tape: Use memdup_user() rather than duplicating its implementation Martin Schwidefsky (16): s390/mm: no local TLB flush for clearing-by-ASCE IDTE s390/mm,kvm: flush gmap address space with IDTE s390/mm: merge local / non

[GIT PULL] s390 patches for 4.9 merge window #1

2016-10-04 Thread Martin Schwidefsky
facility mask from readable list Markus Elfring (1): s390/tape: Use memdup_user() rather than duplicating its implementation Martin Schwidefsky (16): s390/mm: no local TLB flush for clearing-by-ASCE IDTE s390/mm,kvm: flush gmap address space with IDTE s390/mm: merge local / non

Re: [PATCH -resend 6/6] frv, mn10300, s390, sh: remove empty vga.h

2016-10-03 Thread Martin Schwidefsky
; Signed-off-by: Jiri Slaby <jsl...@suse.cz> > Cc: David Howells <dhowe...@redhat.com> > Cc: Martin Schwidefsky <schwidef...@de.ibm.com> > Cc: Heiko Carstens <heiko.carst...@de.ibm.com> > Cc: Yoshinori Sato <ys...@users.sourceforge.jp> > Cc: Rich Felke

Re: [PATCH -resend 6/6] frv, mn10300, s390, sh: remove empty vga.h

2016-10-03 Thread Martin Schwidefsky
by > Cc: David Howells > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: linux-am33-l...@redhat.com > Cc: linux-s...@vger.kernel.org > Cc: linux...@vger.kernel.org Acked-by: Martin Schwidefsky -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.

Re: [PATCH] s390x/spinlock: Provide vcpu_is_preempted globally

2016-09-29 Thread Martin Schwidefsky
On Thu, 29 Sep 2016 13:54:16 +0200 Christian Borntraeger wrote: > this implements the s390 backend for commit > "kernel/sched: introduce vcpu preempted check interface" > by simply reusing the existing cpu_is_preempted function. > > Signed-off-by: Christian Borntraeger

Re: [PATCH] s390x/spinlock: Provide vcpu_is_preempted globally

2016-09-29 Thread Martin Schwidefsky
On Thu, 29 Sep 2016 13:54:16 +0200 Christian Borntraeger wrote: > this implements the s390 backend for commit > "kernel/sched: introduce vcpu preempted check interface" > by simply reusing the existing cpu_is_preempted function. > > Signed-off-by: Christian Borntraeger > --- > Martin, Heiko, >

Re: [PATCH] s390/dasd: add missing \n to end of dev_err messages

2016-09-28 Thread Martin Schwidefsky
On Tue, 27 Sep 2016 12:13:18 -0700 Colin King wrote: > From: Colin Ian King > > Trival fix, dev_err messages are missing a \n, so add it. > > Signed-off-by: Colin Ian King > --- > drivers/s390/block/dasd_erp.c | 4

Re: [PATCH] s390/lcs: remove trailing space at end of dev_err message

2016-09-28 Thread Martin Schwidefsky
On Tue, 27 Sep 2016 12:57:01 -0700 Colin King wrote: > From: Colin Ian King > > There is a trailing white space at the end of a dev_err > message that does nothing useful - remove it. > > Signed-off-by: Colin Ian King

Re: [PATCH] s390/dasd: add missing \n to end of dev_err messages

2016-09-28 Thread Martin Schwidefsky
On Tue, 27 Sep 2016 12:13:18 -0700 Colin King wrote: > From: Colin Ian King > > Trival fix, dev_err messages are missing a \n, so add it. > > Signed-off-by: Colin Ian King > --- > drivers/s390/block/dasd_erp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. --

Re: [PATCH] s390/lcs: remove trailing space at end of dev_err message

2016-09-28 Thread Martin Schwidefsky
On Tue, 27 Sep 2016 12:57:01 -0700 Colin King wrote: > From: Colin Ian King > > There is a trailing white space at the end of a dev_err > message that does nothing useful - remove it. > > Signed-off-by: Colin Ian King Applied, thanks. -- blue skies, Martin. "Reality continues to ruin

Re: [PATCH] s390: migrate exception table users off module.h and onto extable.h

2016-09-20 Thread Martin Schwidefsky
icit declaration of function > 'extable_fixup' [-Werror=implicit-function-declaration] > arch/s390/kernel/traps.c: In function 'illegal_op': > arch/s390/kernel/traps.c:173:3: error: implicit declaration of function > 'get_user' [-Werror=implicit-function-declaration] > > Cc:

Re: [PATCH] s390: migrate exception table users off module.h and onto extable.h

2016-09-20 Thread Martin Schwidefsky
'extable_fixup' [-Werror=implicit-function-declaration] > arch/s390/kernel/traps.c: In function 'illegal_op': > arch/s390/kernel/traps.c:173:3: error: implicit declaration of function > 'get_user' [-Werror=implicit-function-declaration] > > Cc: Martin Schwidefsky > Cc: Heiko Car

Re: [PATCH] s390/crypto: initialize ret to zero to avoid returning garbage value

2016-09-06 Thread Martin Schwidefsky
On Mon, 5 Sep 2016 17:21:18 +0100 Colin King wrote: > From: Colin Ian King > > static analysis with cppcheck detected that ret is not initialized > and hence garbage is potentially being returned in the case where >

Re: [PATCH] s390/crypto: initialize ret to zero to avoid returning garbage value

2016-09-06 Thread Martin Schwidefsky
On Mon, 5 Sep 2016 17:21:18 +0100 Colin King wrote: > From: Colin Ian King > > static analysis with cppcheck detected that ret is not initialized > and hence garbage is potentially being returned in the case where > prng_data->ppnows.reseed_counter <= prng_reseed_limit. > > Signed-off-by:

Re: [PATCH 00/17] s390/debug: Fine-tuning for several function implementations

2016-09-05 Thread Martin Schwidefsky
On Sat, 3 Sep 2016 14:04:18 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 3 Sep 2016 13:54:32 +0200 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring

Re: [PATCH 00/17] s390/debug: Fine-tuning for several function implementations

2016-09-05 Thread Martin Schwidefsky
On Sat, 3 Sep 2016 14:04:18 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 3 Sep 2016 13:54:32 +0200 > > Several update suggestions were taken into account > from static source code analysis. > > Markus Elfring (17): > Use kmalloc_array() in debug_areas_alloc() >

Re: linux-next: build warning after merge of the crypto tree

2016-08-25 Thread Martin Schwidefsky
On Thu, 25 Aug 2016 11:38:24 +1000 Stephen Rothwell wrote: > Hi Herbert, > > After merging the crypto tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > crypto/xor.c: In function 'calibrate_xor_blocks': > crypto/xor.c:156:1: warning:

Re: linux-next: build warning after merge of the crypto tree

2016-08-25 Thread Martin Schwidefsky
On Thu, 25 Aug 2016 11:38:24 +1000 Stephen Rothwell wrote: > Hi Herbert, > > After merging the crypto tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > crypto/xor.c: In function 'calibrate_xor_blocks': > crypto/xor.c:156:1: warning: label 'out' defined but

Re: [PATCH] s390/tape: Use memdup_user() rather than duplicating its implementation

2016-08-22 Thread Martin Schwidefsky
On Sat, 20 Aug 2016 19:32:03 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 19:25:34 +0200 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > This

Re: [PATCH] s390/tape: Use memdup_user() rather than duplicating its implementation

2016-08-22 Thread Martin Schwidefsky
On Sat, 20 Aug 2016 19:32:03 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 19:25:34 +0200 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > This issue was detected by using the Coccinelle software. > >

[GIT PULL] s390 patches for 4.8-rc3

2016-08-16 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: A couple of bug fixes, minor cleanup and a change to the default config. Christian Borntraeger (3): s390/crc32-vx: Fix

[GIT PULL] s390 patches for 4.8-rc3

2016-08-16 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: A couple of bug fixes, minor cleanup and a change to the default config. Christian Borntraeger (3): s390/crc32-vx: Fix

Re: [GIT PULL] KVM changes for 4.8 merge window

2016-08-02 Thread Martin Schwidefsky
On Tue, 2 Aug 2016 16:17:39 -0400 Linus Torvalds wrote: > On Tue, Aug 2, 2016 at 2:42 PM, Linus Torvalds > wrote: > > > > No, I don't use the merge from linux-next directly. I just re-generate > > the merge myself, and if the pull

Re: [GIT PULL] KVM changes for 4.8 merge window

2016-08-02 Thread Martin Schwidefsky
On Tue, 2 Aug 2016 16:17:39 -0400 Linus Torvalds wrote: > On Tue, Aug 2, 2016 at 2:42 PM, Linus Torvalds > wrote: > > > > No, I don't use the merge from linux-next directly. I just re-generate > > the merge myself, and if the pull request then includes a merge > > resolution (either as just a

[GIT PULL] s390 patches for the 4.8 merge window #2

2016-08-02 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: - Some cleanup for the hugetlbfs pte/pmd conversion functions - The code to check for the minimum CPU type is converted from

[GIT PULL] s390 patches for the 4.8 merge window #2

2016-08-02 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: - Some cleanup for the hugetlbfs pte/pmd conversion functions - The code to check for the minimum CPU type is converted from

Re: [PATCH] ftrace/jprobes/s390: Fix conflict between jprobes and function graph tracing

2016-07-31 Thread Martin Schwidefsky
On Sun, 31 Jul 2016 14:21:14 +0200 Jiri Olsa wrote: > On Thu, Jul 28, 2016 at 02:39:33PM -0400, Steven Rostedt wrote: > > On Mon, 18 Jul 2016 15:26:41 +0200 > > Jiri Olsa wrote: > > > > > This fixes the same issue Steven already fixed for x86 > > > in

Re: [PATCH] ftrace/jprobes/s390: Fix conflict between jprobes and function graph tracing

2016-07-31 Thread Martin Schwidefsky
On Sun, 31 Jul 2016 14:21:14 +0200 Jiri Olsa wrote: > On Thu, Jul 28, 2016 at 02:39:33PM -0400, Steven Rostedt wrote: > > On Mon, 18 Jul 2016 15:26:41 +0200 > > Jiri Olsa wrote: > > > > > This fixes the same issue Steven already fixed for x86 > > > in following commit: > > > > > >

Re: [PATCH 4/5] s390: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO

2016-07-31 Thread Martin Schwidefsky
modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to > date. > > Fixes: b020632e40c3 ("[S390] introduce vdso on s390") > Signed-off-by: James Hogan <james.ho...@imgtec.com> > Cc: Martin Schwidefsky <schwidef...@de.ibm.com> > Cc: Heiko Carstens <heiko.car

Re: [PATCH 4/5] s390: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO

2016-07-31 Thread Martin Schwidefsky
CTOR_SIZE_ARCH up to > date. > > Fixes: b020632e40c3 ("[S390] introduce vdso on s390") > Signed-off-by: James Hogan > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: linux-s...@vger.kernel.org The patch makes sense. I not quite sure about the checkpoint-rest

[GIT PULL] s390 patches for 4.8 merge window

2016-07-25 Thread Martin Schwidefsky
cessary check before the function call "pci_dev_put" Martin Schwidefsky (9): s390/time: STP sync clock correction s390/time: move PTFF definitions s390/time: LPAR offset handling s390/time: add leap seconds to initial system time s390/time: remove ETR suppor

[GIT PULL] s390 patches for 4.8 merge window

2016-07-25 Thread Martin Schwidefsky
cessary check before the function call "pci_dev_put" Martin Schwidefsky (9): s390/time: STP sync clock correction s390/time: move PTFF definitions s390/time: LPAR offset handling s390/time: add leap seconds to initial system time s390/time: remove ETR suppor

Re: [patch] s390/smp: clean up a condition

2016-07-18 Thread Martin Schwidefsky
On Thu, 14 Jul 2016 13:40:22 +0300 Dan Carpenter wrote: > I can never remember precedence rules. Let's add some parenthesis so > this code is more clear. > > Signed-off-by: Dan Carpenter > --- > The original code is correct right? We didn't

Re: [patch] s390/smp: clean up a condition

2016-07-18 Thread Martin Schwidefsky
On Thu, 14 Jul 2016 13:40:22 +0300 Dan Carpenter wrote: > I can never remember precedence rules. Let's add some parenthesis so > this code is more clear. > > Signed-off-by: Dan Carpenter > --- > The original code is correct right? We didn't intend to say: > > sclp_max = sclp.max_cores

Re: [PATCH] s390/pci: Delete an unnecessary check before the function call "pci_dev_put"

2016-07-18 Thread Martin Schwidefsky
On Sat, 16 Jul 2016 20:40:23 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 20:15:17 +0200 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the

Re: [PATCH] s390/pci: Delete an unnecessary check before the function call "pci_dev_put"

2016-07-18 Thread Martin Schwidefsky
On Sat, 16 Jul 2016 20:40:23 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 20:15:17 +0200 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected

Re: [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries

2016-07-06 Thread Martin Schwidefsky
On Wed, 06 Jul 2016 17:26:08 +0800 "Hillf Danton" wrote: > > > > You are still a bit cryptic, > > > Sorry, Sir, simply because I'm not native English speaker. > > > are you trying to tell me that your hint is > > about trying to avoid the preempt_enable() call? > >

Re: [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries

2016-07-06 Thread Martin Schwidefsky
On Wed, 06 Jul 2016 17:26:08 +0800 "Hillf Danton" wrote: > > > > You are still a bit cryptic, > > > Sorry, Sir, simply because I'm not native English speaker. > > > are you trying to tell me that your hint is > > about trying to avoid the preempt_enable() call? > > > Yes, since we are

Re: [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries

2016-07-06 Thread Martin Schwidefsky
On Wed, 06 Jul 2016 14:42:16 +0800 "Hillf Danton" wrote: > > > > > > > > +void ptep_invalidate_range(struct mm_struct *mm, unsigned long start, > > > > + unsigned long end, pte_t *ptep) > > > > +{ > > > > + unsigned long nr; > > > > + > >

Re: [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries

2016-07-06 Thread Martin Schwidefsky
On Wed, 06 Jul 2016 14:42:16 +0800 "Hillf Danton" wrote: > > > > > > > > +void ptep_invalidate_range(struct mm_struct *mm, unsigned long start, > > > > + unsigned long end, pte_t *ptep) > > > > +{ > > > > + unsigned long nr; > > > > + > > > > + if

Re: [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries

2016-07-06 Thread Martin Schwidefsky
On Wed, 06 Jul 2016 12:03:28 +0800 "Hillf Danton" wrote: > > > > +void ptep_invalidate_range(struct mm_struct *mm, unsigned long start, > > + unsigned long end, pte_t *ptep) > > +{ > > + unsigned long nr; > > + > > + if (!MACHINE_HAS_IPTE_RANGE

Re: [PATCH 2/2] s390/mm: use ipte range to invalidate multiple page table entries

2016-07-06 Thread Martin Schwidefsky
On Wed, 06 Jul 2016 12:03:28 +0800 "Hillf Danton" wrote: > > > > +void ptep_invalidate_range(struct mm_struct *mm, unsigned long start, > > + unsigned long end, pte_t *ptep) > > +{ > > + unsigned long nr; > > + > > + if (!MACHINE_HAS_IPTE_RANGE || mm_has_pgste(mm)) > >

[GIT PULL] s390 patches for 4.7-rc6

2016-06-29 Thread Martin Schwidefsky
kernel, e.g. the SLES12 grub setup. - A fix for an incorrect inline assembly constraint that causes broken code to be generated with gcc 4.8.5. Martin Schwidefsky (1): s390: fix test_fp_ctl inline assembly contraints Michael Holzheu (1): Revert "s390/kdump: Clear subchann

[GIT PULL] s390 patches for 4.7-rc6

2016-06-29 Thread Martin Schwidefsky
kernel, e.g. the SLES12 grub setup. - A fix for an incorrect inline assembly constraint that causes broken code to be generated with gcc 4.8.5. Martin Schwidefsky (1): s390: fix test_fp_ctl inline assembly contraints Michael Holzheu (1): Revert "s390/kdump: Clear subchann

[GIT PULL] s390 patches for 4.7-rc5

2016-06-20 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: Two more bugs fixes for 4.7: - A KVM regression introduced with the pgtable.c code split - A perf issue with two hardware PMUs

[GIT PULL] s390 patches for 4.7-rc5

2016-06-20 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: Two more bugs fixes for 4.7: - A KVM regression introduced with the pgtable.c code split - A perf issue with two hardware PMUs

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Martin Schwidefsky
On Mon, 13 Jun 2016 15:53:02 +0200 Peter Zijlstra <pet...@infradead.org> wrote: > On Mon, Jun 13, 2016 at 03:19:42PM +0200, Martin Schwidefsky wrote: > > On Mon, 13 Jun 2016 15:06:47 +0200 > > Peter Zijlstra <pet...@infradead.org> wrote: > > > > > On Mo

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Martin Schwidefsky
On Mon, 13 Jun 2016 15:53:02 +0200 Peter Zijlstra wrote: > On Mon, Jun 13, 2016 at 03:19:42PM +0200, Martin Schwidefsky wrote: > > On Mon, 13 Jun 2016 15:06:47 +0200 > > Peter Zijlstra wrote: > > > > > On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko Carstens wrote

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Martin Schwidefsky
On Mon, 13 Jun 2016 15:06:47 +0200 Peter Zijlstra wrote: > On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko Carstens wrote: > > Yes, and actually we are all virt/LPAR always, so this is unfortunately not > > very easy to do. And yes, I do agree that for the 1:1 case it most

Re: [PATCH 2/2] s390/topology: add drawer scheduling domain level

2016-06-13 Thread Martin Schwidefsky
On Mon, 13 Jun 2016 15:06:47 +0200 Peter Zijlstra wrote: > On Mon, Jun 13, 2016 at 01:22:30PM +0200, Heiko Carstens wrote: > > Yes, and actually we are all virt/LPAR always, so this is unfortunately not > > very easy to do. And yes, I do agree that for the 1:1 case it most likely > > would make

Re: [PATCH 11/14] s390/ptrace: run seccomp after ptrace

2016-06-10 Thread Martin Schwidefsky
On Thu, 9 Jun 2016 14:02:01 -0700 Kees Cook <keesc...@chromium.org> wrote: > Close the hole where ptrace can change a syscall out from under seccomp. > > Signed-off-by: Kees Cook <keesc...@chromium.org> > Cc: Heiko Carstens <heiko.carst...@de.ibm.com> >

Re: [PATCH 11/14] s390/ptrace: run seccomp after ptrace

2016-06-10 Thread Martin Schwidefsky
On Thu, 9 Jun 2016 14:02:01 -0700 Kees Cook wrote: > Close the hole where ptrace can change a syscall out from under seccomp. > > Signed-off-by: Kees Cook > Cc: Heiko Carstens > Cc: Martin Schwidefsky > Cc: linux-s...@vger.kernel.org > --- > arch/s

Re: [PATCH] bitmap_equal memcmp optimization for s390

2016-06-09 Thread Martin Schwidefsky
On Thu, 09 Jun 2016 15:26:47 +0100 David Howells <dhowe...@redhat.com> wrote: > Martin Schwidefsky <schwidef...@de.ibm.com> wrote: > > > I hesitate to put another CONFIG_S390 into common code, alternatively > > __HAVE_ARCH_MEMCMP could be used. There are 7 architec

Re: [PATCH] bitmap_equal memcmp optimization for s390

2016-06-09 Thread Martin Schwidefsky
On Thu, 09 Jun 2016 15:26:47 +0100 David Howells wrote: > Martin Schwidefsky wrote: > > > I hesitate to put another CONFIG_S390 into common code, alternatively > > __HAVE_ARCH_MEMCMP could be used. There are 7 architectures with the > > define: arc, arm64, blac

Re: [PATCH] bitmap: bitmap_equal memcmp optimization

2016-06-09 Thread Martin Schwidefsky
On Wed, 8 Jun 2016 13:42:12 -0700 Andrew Morton <a...@linux-foundation.org> wrote: > On Tue, 7 Jun 2016 10:37:41 +0200 Martin Schwidefsky > <schwidef...@de.ibm.com> wrote: > > > The bitmap_equal function has optimized code for small bitmaps with less > > th

Re: [PATCH] bitmap: bitmap_equal memcmp optimization

2016-06-09 Thread Martin Schwidefsky
On Wed, 8 Jun 2016 13:42:12 -0700 Andrew Morton wrote: > On Tue, 7 Jun 2016 10:37:41 +0200 Martin Schwidefsky > wrote: > > > The bitmap_equal function has optimized code for small bitmaps with less > > than BITS_PER_LONG bits. For larger bitmaps the out-of-line functi

Re: [PATCH] KVM: s390: fix build failure

2016-06-08 Thread Martin Schwidefsky
On Tue, 7 Jun 2016 22:49:30 +0100 Sudip Mukherjee wrote: > etr_ptff definitions are moved and renamed but we missed updating them > here and as a result s390 defconfig and allmodconfig was failing with > the error: > arch/s390/kvm/kvm-s390.c:230:45: error:

Re: [PATCH] KVM: s390: fix build failure

2016-06-08 Thread Martin Schwidefsky
On Tue, 7 Jun 2016 22:49:30 +0100 Sudip Mukherjee wrote: > etr_ptff definitions are moved and renamed but we missed updating them > here and as a result s390 defconfig and allmodconfig was failing with > the error: > arch/s390/kvm/kvm-s390.c:230:45: error: 'ETR_PTFF_QAF' undeclared > > Fixes:

[PATCH] bitmap: bitmap_equal memcmp optimization

2016-06-07 Thread Martin Schwidefsky
this function, memcmp calls with up to 256 bytes / 2048 bits are translated into a single instruction. Reviewed-by: David Hildenbrand <d...@linux.vnet.ibm.com> Signed-off-by: Martin Schwidefsky <schwidef...@de.ibm.com> --- include/linux/bitmap.h | 4 1 file changed, 4 insertions(+)

[PATCH] bitmap: bitmap_equal memcmp optimization

2016-06-07 Thread Martin Schwidefsky
this function, memcmp calls with up to 256 bytes / 2048 bits are translated into a single instruction. Reviewed-by: David Hildenbrand Signed-off-by: Martin Schwidefsky --- include/linux/bitmap.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h

[PATCH] bitmap_equal memcmp optimization for s390

2016-06-07 Thread Martin Schwidefsky
Servus, while working on an improved TLB flush logic for s390 I noticed that for s390 cpumask_equal() alias bitmap_equal() can be improved for the special case "(nbits % BITS_PER_LONG) == 0". The memcmp function can be used in this case and we have an instruction for that .. Trouble is that the

[PATCH] bitmap_equal memcmp optimization for s390

2016-06-07 Thread Martin Schwidefsky
Servus, while working on an improved TLB flush logic for s390 I noticed that for s390 cpumask_equal() alias bitmap_equal() can be improved for the special case "(nbits % BITS_PER_LONG) == 0". The memcmp function can be used in this case and we have an instruction for that .. Trouble is that the

[GIT PULL] s390 patches for 4.7-rc2

2016-05-31 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: Three bugs fixes and an update for the default configuration. Heiko Carstens (1): s390/config: update default

[GIT PULL] s390 patches for 4.7-rc2

2016-05-31 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: Three bugs fixes and an update for the default configuration. Heiko Carstens (1): s390/config: update default

Re: [PATCH -v2 4/6] locking, arch: Update spin_unlock_wait()

2016-05-27 Thread Martin Schwidefsky
On Thu, 26 May 2016 16:19:26 +0200 Peter Zijlstra wrote: > This patch updates/fixes all spin_unlock_wait() implementations. > > The update is in semantics; where it previously was only a control > dependency, we now upgrade to a full load-acquire to match the >

Re: [PATCH -v2 4/6] locking, arch: Update spin_unlock_wait()

2016-05-27 Thread Martin Schwidefsky
On Thu, 26 May 2016 16:19:26 +0200 Peter Zijlstra wrote: > This patch updates/fixes all spin_unlock_wait() implementations. > > The update is in semantics; where it previously was only a control > dependency, we now upgrade to a full load-acquire to match the > store-release from the

Re: [PATCH] s390: fix info leak in do_sigsegv

2016-05-23 Thread Martin Schwidefsky
On Mon, 23 May 2016 15:43:20 +0200 Michal Hocko wrote: > OK, Martin would prefer a simple patch so here we go. > --- > From de1ad037f3181e795ef0e66a61b8fbe1157f66cc Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Mon, 23 May 2016 15:35:51 +0200 >

Re: [PATCH] s390: fix info leak in do_sigsegv

2016-05-23 Thread Martin Schwidefsky
On Mon, 23 May 2016 15:43:20 +0200 Michal Hocko wrote: > OK, Martin would prefer a simple patch so here we go. > --- > From de1ad037f3181e795ef0e66a61b8fbe1157f66cc Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Mon, 23 May 2016 15:35:51 +0200 > Subject: [PATCH] s390: fix info leak in

Re: siginfo memory leak?

2016-05-23 Thread Martin Schwidefsky
On Mon, 23 May 2016 15:05:38 +0200 Michal Hocko <mho...@kernel.org> wrote: > On Mon 23-05-16 14:43:19, Martin Schwidefsky wrote: > > On Mon, 23 May 2016 13:16:30 +0200 > [...] > > > diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c > > > ind

Re: siginfo memory leak?

2016-05-23 Thread Martin Schwidefsky
On Mon, 23 May 2016 15:05:38 +0200 Michal Hocko wrote: > On Mon 23-05-16 14:43:19, Martin Schwidefsky wrote: > > On Mon, 23 May 2016 13:16:30 +0200 > [...] > > > diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c > > > index 791a4146052c..41913fac14e4 1

Re: siginfo memory leak?

2016-05-23 Thread Martin Schwidefsky
On Mon, 23 May 2016 13:16:30 +0200 Michal Hocko wrote: > Hi, > Aleksa has reported that strace tells a bogus si_errno while debugging > something on s390: > [pid 20799] --- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, > si_errno=2510266, si_addr=0x100} That is

Re: siginfo memory leak?

2016-05-23 Thread Martin Schwidefsky
On Mon, 23 May 2016 13:16:30 +0200 Michal Hocko wrote: > Hi, > Aleksa has reported that strace tells a bogus si_errno while debugging > something on s390: > [pid 20799] --- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, > si_errno=2510266, si_addr=0x100} That is a bug. > A quick

[GIT PULL] s390 patches for 4.7 merge window

2016-05-18 Thread Martin Schwidefsky
s390/vmem: remove unused function parameter Jan Höppner (1): s390/dasd: Add new ioctl BIODASDCHECKFMT Martin Schwidefsky (10): s390/crypto: cleanup and move the header with the cpacf definitions s390/fpu: allocate 'struct fpu' with the task_struct s390/sclp: avoid

[GIT PULL] s390 patches for 4.7 merge window

2016-05-18 Thread Martin Schwidefsky
s390/vmem: remove unused function parameter Jan Höppner (1): s390/dasd: Add new ioctl BIODASDCHECKFMT Martin Schwidefsky (10): s390/crypto: cleanup and move the header with the cpacf definitions s390/fpu: allocate 'struct fpu' with the task_struct s390/sclp: avoid

Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call

2016-05-03 Thread Martin Schwidefsky
ntion, interrupts are > > explicitly disabled around the call. > > > > Cc: Martin Schwidefsky <schwidef...@de.ibm.com> > > Cc: Heiko Carstens <heiko.carst...@de.ibm.com> > > Cc: linux-s...@vger.kernel.org > > Signed-off-by: Anna-Maria Gleixner <anna-ma

Re: [PATCH v2] s390/cpum_sf: Remove superfluous SMP function call

2016-05-03 Thread Martin Schwidefsky
> explicitly disabled around the call. > > > > Cc: Martin Schwidefsky > > Cc: Heiko Carstens > > Cc: linux-s...@vger.kernel.org > > Signed-off-by: Anna-Maria Gleixner > > --- > > Changes in v2: > > - Adapt referenced commit in commit message

<    1   2   3   4   5   6   7   8   9   10   >