Re: [PATCH v2] selftests: ir_decoder: Convert header comment to proper multi-line block

2025-06-09 Thread Shuah
check for read + * readiness. + */ #include #include #include I don't think this patch is necessary. We have files that use // style comments. How did you find this issue. thanks, -- Shuah

Re: [PATCH] selftests: Add version file to kselftest installation dir

2025-06-03 Thread Shuah Khan
On 6/2/25 19:13, Tianyi Cui wrote: On 6/2/25 3:48 PM, Shuah Khan wrote: On 5/28/25 18:33, Tianyi Cui wrote: As titled, adding version file to kselftest installation dir, so the user of the tarball can know which kernel version the tarball belongs to. Signed-off-by: Tianyi Cui <1

Re: [PATCH] selftests: firmware: Add details in error logging

2025-06-02 Thread Shuah Khan
On 5/25/25 12:26, Harshal Wadhwa wrote: On Fri, 23 May 2025 at 03:49, Shuah Khan wrote: On 5/16/25 09:39, Harshal wrote: Specify details in logs of failed cases Use die() instead of exit() when write to sys_path fails Please explain why this change is needed? Signed-off-by: Harshal

Re: [PATCH v2] selftests: Add functional test for the abort file in fusectl

2025-06-02 Thread Shuah Khan
On 5/25/25 19:41, Chen Linxuan wrote: On Fri, May 23, 2025 at 6:50 AM Shuah Khan wrote: Also if this test requires root previlege, add check for it. Currently, this test does not require root privileges. Thanks, Chen Linxuan Thanks. Looks good to me. Acked-by: Shuah Khan thanks

Re: [PATCH] selftests: Add version file to kselftest installation dir

2025-06-02 Thread Shuah Khan
ersion saved to $(INSTALL_PATH)/VERSION\n"; \ + else \ + printf "Unable to get version from git describe\n"; \ + fi else $(error Error: set INSTALL_PATH to use install) endif Why not use "make kernelrelease" to get the version? thanks, -- Shuah

Re: [PATCH v2] selftests/filesystems: Fix build of anon_inode_test

2025-06-02 Thread Shuah Khan
anches got merged there. - Link to v1: https://lore.kernel.org/r/20250518-selftests-anon-inode-build-v1-1-71eff8183...@kernel.org Looks this will have to go directly to Linu's tree or vfs tree. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests: ipc: Replace fail print statements with ksft_test_result_fail

2025-06-02 Thread Shuah Khan
++-- 1 file changed, 23 insertions(+), 24 deletions(-) Looks good to me. I will apply this after merge window closes. thanks, -- Shuah

Re: [PATCH v2] selftests/ptrace/get_syscall_info: fix for MIPS n32

2025-06-02 Thread Shuah Khan
ll_info) has been merged, so there are two similar tests in the tree now, but only one of them is permitted to use this approach, creating inconsistency. Taking all of the above into consideration, please approve this fix. Acked-by: Shuah Khan thanks, -- Shuah

Re: [RFC] selftests/mm: Skip tests dependent on a binary not built

2025-05-23 Thread Shuah Khan
stand the change. thanks, -- Shuah

[GIT PULL] Kselftest next update for Linux 6.16-rc1

2025-05-23 Thread Shuah Khan
testcases. - ftrace to add poll to a gen_file so test can find it at run-time. - spelling errors in perf_events test. diff is attached. thanks, -- Shuah The following changes since commit b4432656b36e5cc1d50a1f2dc15357543add530e

[GIT PULL] kunit next update for Linux 6.16-rc1

2025-05-23 Thread Shuah Khan
clearly differentiate between powerpc LE and BE configurations. - Adds feature to list available architectures to kunit tool. - Fixes to bugs and changes to documentation. diff is attached. thanks, -- Shuah The following changes

Re: [PATCH v2] kselftest: x86: Improve MOV SS test result message

2025-05-23 Thread Shuah Khan
usually is in imperative - e.g: "Change test result message to be more descriptive and grammatically correct.." There are no changes in v2. I'm resending this patch because I addressed it to the wrong email for Shuah. Version change information goes under the --- after the Signed-o

Re: [PATCH v2] selftests: timers: valid-adjtimex: fix coding style issues

2025-05-23 Thread Shuah Khan
reported by checkpatch.pl and do not affect functionality. changes in v2 : - Resubmitted the patch with a properly formatted commit message, following patch submission guidelines, as suggested by Shuah Khan. Signed-off-by: Rujra Bhatt Sorry - I didn't realize these are all coding style re

Re: [PATCH] selftests: net: fix spelling and grammar mistakes

2025-05-22 Thread Shuah Khan
-off-by: Praveen Balakrishnan This patch is missing net maintainers. RUn get_maintainers.pl for complete list recipients for this patch. thanks, -- Shuah

Re: [PATCH v2] selftests: Add functional test for the abort file in fusectl

2025-05-22 Thread Shuah Khan
rt summary should include the test name: selftests: filesystems: Add functional test for the abort file in fusectl Also if this test requires root previlege, add check for it. The rest looks good to me. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 1/1] Fix typo in cpu-on-off-test selftest script:

2025-05-22 Thread Shuah Khan
uggable_offline_cpus() { hotpluggable_cpus 0 } @@ -151,7 +151,7 @@ offline_cpu_expect_fail() online_all_hot_pluggable_cpus() { - for cpu in `hotplaggable_offline_cpus`; do + for cpu in `hotpluggable_offline_cpus`; do online_cpu_expect_success $cpu done } thanks, -- Shuah

Re: [PATCH] [PATCH] Change pidns to pid namespace

2025-05-22 Thread Shuah Khan
join_thread(pid); Please run get_maintainers.pl to find the complete list of recipients for this patch. thanks, -- Shuah

Re: [PATCH v2] selftests: Improve test output grammar, code style

2025-05-22 Thread Shuah Khan
ksft_exit_skip("Cannot access RTC file %s - exiting\n", rtc_file); I don't see any reason for this change either. return ret; thanks, -- Shuah

Re: [PATCH] selftests: firmware: Add details in error logging

2025-05-22 Thread Shuah Khan
29,8 +130,8 @@ int main(int argc, char **argv) die("error: failed to build full fw_path\n"); setup_fw(fw_path); - setvbuf(stdout, NULL, _IONBF, 0); + /* Positive case: firmware in PID1 mount namespace */ printf("Testing with firmware in parent namespace (assumed to be same file system as PID1)\n"); if (!test_fw_in_ns(fw_name, sys_path, false)) The rest look fine. thanks, -- Shuah

Re: Fwd: [PATCH] selftests : timers : valid-adjtimex.c : Fixed style checks

2025-05-22 Thread Shuah Khan
el documentation on submitting patches. thanks, -- Shuah

Re: [PATCH] selftests: timers: Fix grammar and clarify comments in nanosleep.c

2025-05-22 Thread Shuah Khan
On 5/14/25 16:21, Rahul Kumar wrote: Improved the clarity and grammar in the header comment of nanosleep.c for better readability and consistency with kernel documentation style. This patch isn't really fixing anything. I won't be taking this one. Sorry. thanks, -- Shuah

Re: [PATCH] selftests/eventfd: correct test name and improve messages

2025-05-22 Thread Shuah Khan
ksft_print_msg("eventfd semaphore flag check failed: %s\n", err.msg); What's the reason for this change? EXPECT_EQ(ret, 0); close(fd); thanks, -- Shuah

Re: [PATCH] selftests: fix "memebers" typo in filesystems/mount-notify

2025-05-22 Thread Shuah Khan
e is how the correct format looks like: selftests: filesystems: fix "memebers" typo in mount-notify SZend v2 with this correction. thanks, -- Shuah

Re: [PATCH] selftests: ir_decoder: Convert header comment to proper multi-line block

2025-05-22 Thread Shuah Khan
hitespace #137: FILE: tools/testing/selftests/ir/ir_loopback.c:4: + * Selftest for IR decoder $ Please fix it and send v2. thanks, -- Shuah

Re: [PATCH] selftests: size: fix grammar and align output formatting

2025-05-22 Thread Shuah Khan
ility. Signed-off-by: Abdelrahman Fekry Did you run checkpatch on this patch? I am seeing CHECK: From:/Signed-off-by: email comments mismatch: 'From: Abdelrahman Fekry ' != 'Signed-off-by: Abdelrahman Fekry ' Please fix it and send v2. thanks, -- Shuah

Re: [PATCH] selftests: acct: fix grammar and clarify output messages

2025-05-22 Thread Shuah Khan
ckpatch on this patch? I am seeing CHECK: From:/Signed-off-by: email comments mismatch: 'From: Abdelrahman Fekry ' != 'Signed-off-by: Abdelrahman Fekry ' Please fix it and send v2. thanks, -- Shuah

Re: [PATCH] selftests/cpufreq: Fix cpufreq basic read and update testcases

2025-05-22 Thread Shuah Khan
! -z $rfile ]; then + cat $1/$file + else + printf "$file is not readable\n" + fi What about: if [ -r $1/$file ]; then cat $1/$file else printf "$file is not readable\n" fi thanks, -- Shuah

Re: [PATCH v4 00/14] kselftest harness and nolibc compatibility

2025-05-12 Thread Shuah Khan
On 5/10/25 00:54, Thomas Weißschuh wrote: Hi Shuah and Kees, On 2025-05-05 17:15:18+0200, Thomas Weißschuh wrote: Nolibc is useful for selftests as the test programs can be very small, and compiled with just a kernel crosscompiler, without userspace support. Currently nolibc is only usable

Re: [PATCH 1/3] selftests/timens: Print TAP headers

2025-05-09 Thread Shuah Khan
On 5/9/25 09:41, Thomas Weißschuh wrote: +Cc Kees On Wed, May 07, 2025 at 03:06:16PM -0600, Shuah Khan wrote: On 5/2/25 06:03, Thomas Weißschuh wrote: The TAP specification requires that the output begins with a header line. These headers lines are missing in the timens tests. Print such a

Re: The "make headers" requirement, revisited: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2025-05-08 Thread Shuah Khan
On 5/8/25 08:04, Sean Christopherson wrote: On Wed, May 07, 2025, Shuah Khan wrote: The issues Peter is seeing regarding KHDR_INCLUDES in the following tests can be easily fixed by simply changing the test Makefile. These aren't framework related. kvm/Makefile.kvm:-I ../rs

Re: [PATCH] kbuild: use ARCH from compile.h in unclean source tree msg

2025-05-07 Thread Shuah Khan
On 5/7/25 16:21, Shuah Khan wrote: On 5/7/25 01:23, Masahiro Yamada wrote: On Wed, May 7, 2025 at 7:07 AM Shuah Khan wrote: On 5/6/25 05:12, Nicolas Schier wrote: On Fri, 02 May 2025, Shuah Khan wrote: When make finds the source tree unclean, it prints a message to run "make ARCH=x

Re: [PATCH] kbuild: use ARCH from compile.h in unclean source tree msg

2025-05-07 Thread Shuah Khan
On 5/7/25 01:23, Masahiro Yamada wrote: On Wed, May 7, 2025 at 7:07 AM Shuah Khan wrote: On 5/6/25 05:12, Nicolas Schier wrote: On Fri, 02 May 2025, Shuah Khan wrote: When make finds the source tree unclean, it prints a message to run "make ARCH=x86_64 mrproper" message using the

Re: [PATCH 1/3] selftests/timens: Print TAP headers

2025-05-07 Thread Shuah Khan
rs still a problem. Even if they aren't there is the issue of multiple TAP headers for each test when we run the test using framework. thanks, -- Shuah

Re: The "make headers" requirement, revisited: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2025-05-07 Thread Shuah Khan
On 10/17/24 10:47, John Hubbard wrote: On 10/17/24 9:33 AM, Shuah Khan wrote: On 10/16/24 20:01, John Hubbard wrote: On 10/16/24 1:00 PM, Shuah Khan wrote: On 10/16/24 04:20, Lorenzo Stoakes wrote: ... The requirement to do "make headers" is not a keeper. Really. The reason we

Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2025-05-07 Thread Shuah Khan
On 5/6/25 15:34, John Hubbard wrote: On 5/6/25 2:18 PM, Shuah Khan wrote: On 5/1/25 05:42, Peter Zijlstra wrote: On Wed, Oct 16, 2024 at 07:14:34PM -0700, John Hubbard wrote: On 10/16/24 3:06 PM, Lorenzo Stoakes wrote: On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: On 10/16/24

Re: [PATCH] kbuild: use ARCH from compile.h in unclean source tree msg

2025-05-06 Thread Shuah Khan
On 5/6/25 16:07, Shuah Khan wrote: On 5/6/25 05:12, Nicolas Schier wrote: On Fri, 02 May 2025, Shuah Khan wrote: When make finds the source tree unclean, it prints a message to run "make ARCH=x86_64 mrproper" message using the ARCH from the command line. The ARCH specified in the co

Re: [PATCH] kbuild: use ARCH from compile.h in unclean source tree msg

2025-05-06 Thread Shuah Khan
On 5/6/25 05:12, Nicolas Schier wrote: On Fri, 02 May 2025, Shuah Khan wrote: When make finds the source tree unclean, it prints a message to run "make ARCH=x86_64 mrproper" message using the ARCH from the command line. The ARCH specified in the command line could be different from t

Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_*

2025-05-06 Thread Shuah Khan
On 5/1/25 05:42, Peter Zijlstra wrote: On Wed, Oct 16, 2024 at 07:14:34PM -0700, John Hubbard wrote: On 10/16/24 3:06 PM, Lorenzo Stoakes wrote: On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: On 10/16/24 04:20, Lorenzo Stoakes wrote: ... diff --git a/tools/testing/selftests

[PATCH] kbuild: use ARCH from compile.h in unclean source tree msg

2025-05-02 Thread Shuah Khan
mrproper' *** in /linux/linux_6.15 *** Signed-off-by: Shuah Khan --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 5aa9ee52a765..7ee29136b4da 100644 --- a/Makefile +++ b/Makefile @@ -674,7 +674,7 @@ ifeq ($(KBUIL

Re: [PATCH v3 00/32] kselftest harness and nolibc compatibility

2025-04-29 Thread Shuah Khan
On 4/24/25 14:06, Shuah Khan wrote: On 4/22/25 02:51, Willy Tarreau wrote: Hi Thomas, On Tue, Apr 22, 2025 at 10:48:28AM +0200, Thomas Weißschuh wrote: Hi, On Fri, Apr 11, 2025 at 11:00:24AM +0200, Thomas Weißschuh wrote: Nolibc is useful for selftests as the test programs can be very small

Re: [PATCH v3 00/32] kselftest harness and nolibc compatibility

2025-04-24 Thread Shuah Khan
this series through the nolibc tree. They got Acks from Willy. Any objections? No objection on my side! Thanks. Kees, do you have any comments on this series? If you are okay with it, I would like to apply this for next. thanks, -- Shuah

[GIT PULL] kunit fixes update for Linux 6.15-rc3

2025-04-18 Thread Shuah Khan
Hi Linus, Please pull the following kunit fixes update for Linux 6.15-rc3. Fixes arch sh kunit qemu_configs script sh.py to honor kunit cmdline. diff is attached. thanks, -- Shuah The following changes since commit

[GIT PULL] Kselftest fixes update for Linux 6.15-rc3

2025-04-18 Thread Shuah Khan
Hi Linus, Please pull the following kselftest fixes update for Linux 6.15-rc3. Fixes dynevent_limitations.tc test failure on dash by detecting and handling bash and dash differences in evaluating \\. diff is attached. thanks, -- Shuah

Re: [PATCH v2 00/32] kselftest harness and nolibc compatibility

2025-04-10 Thread Shuah Khan
On 4/10/25 09:19, Shuah Khan wrote: On 4/7/25 00:52, Thomas Weißschuh wrote: Nolibc is useful for selftests as the test programs can be very small, and compiled with just a kernel crosscompiler, without userspace support. Currently nolibc is only usable with kselftest.h, not the more convenient

Re: [PATCH v2 03/32] selftests: harness: Ignore unused variant argument warning

2025-04-10 Thread Shuah Khan
__fixture_variant_metadata *variant) \ + struct __fixture_variant_metadata __attribute__((unused)) *variant) \ { \ _metadata->setup_completed = true; \ if (setjmp(_metadata->env) == 0) \ thanks, -- Shuah

Re: [PATCH v2 02/32] selftests: harness: Use C89 comment style

2025-04-10 Thread Shuah Khan
/kselftest_harness.h @@ -983,7 +983,7 @@ static void __timeout_handler(int sig, siginfo_t *info, void *ucontext) } t->timed_out = true; - // signal process group + /* signal process group */ kill(-(t->pid), SIGKILL); } Looks good to me. thanks, -- Shuah

Re: [PATCH v2 00/32] kselftest harness and nolibc compatibility

2025-04-10 Thread Shuah Khan
ests.sh|2 +- 18 files changed, 635 insertions(+), 1860 deletions(-) --- base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8 change-id: 20250130-nolibc-kselftest-harness-8b2c8cac43bf thanks, -- Shuah

Re: [PATCH v2 01/32] selftests: harness: Add harness selftest

2025-04-10 Thread Shuah Khan
sts/kselftest/harness-selftest.sh new file mode 100755 index ..bf691adf0b41aaedb2fbc5f06add9fd1d5689044 --- /dev/null +++ b/tools/testing/selftests/kselftest/harness-selftest.sh @@ -0,0 +1,14 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# +# Selftest for kselftest_harness.h +# + +DIR="$(dirname $(readlink -f "$0"))" + +TMPFILE="$(mktemp)" +trap 'rm "$TMPFILE"' EXIT + +$DIR/harness-selftest > "$TMPFILE" + +diff -u "$DIR"/harness-selftest.expected "$TMPFILE" This TMPFILE needs to be removed from make clean thanks, -- Shuah

[GIT PULL] Kselftest fixes update for Linux 6.15-rc2

2025-04-09 Thread Shuah Khan
selftests: tpm2: create a dedicated .gitignore selftests/mincore: Allow read-ahead pages to reach the end of the file diff is attached. thanks, -- Shuah The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8

[GIT PULL] kunit fixes update for Linux 6.15-rc2

2025-04-08 Thread Shuah Khan
Hi Linus, Please pull the following kunit fixes update for Linux 6.15-rc2 Fixes tool to report test count in case of a late test plan when tests are specified before the test plan. Fixes spelling error in the commit that went into 6.15-rc1. diff is attached. thanks, -- Shuah

Re: [PATCH v2] selftests/ptrace/get_syscall_info: fix for MIPS n32

2025-04-08 Thread Shuah Khan
one? Can't this be solved with ifdef? thanks, -- Shuah

Re: [PATCH 1/1] selftests/mincore: Allow read-ahead pages to reach the end of the file

2025-04-08 Thread Shuah Khan
On 4/7/25 20:42, Zhuo, Qiuxu wrote: Hi Shuah Khan, Just a gentle ping regarding this patch. If you have any questions, please feel free to let me know. Thanks! -Qiuxu From: Zhuo, Qiuxu [...] Subject: [PATCH 1/1] selftests/mincore: Allow read-ahead pages to reach the end of the file When

Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail

2025-04-08 Thread Shuah Khan
Test sys_futex_waitv() wouldblock") Signed-off-by: Edward Liaw Reviewed-by: André Almeida Thank you. Applied for Linux 6.15-rc2 https://web.git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=fixes thanks, -- Shuah

Re: [PATCH] tests/pid_namespace: Add missing sys/mount.h

2025-04-08 Thread Shuah Khan
he subsystem. Send v2 with this change. selftests: pid_namespace: Add missing sys/mount.h thanks, -- Shuah

Re: [PATCH v2 12/16] selftests: vDSO: parse_vdso: Use UAPI headers instead of libc headers

2025-03-30 Thread Shuah Khan
nal report: https://lore.kernel.org/r/20250321-uapi-consistency-v1-1-439070118...@linutronix.de but it has apparently slipped through the cracks. If this is going through tip Acked-by: Shuah Khan Otherwise, I can send this up thanks, -- Shuah

Re: [PATCH v2] selftests/ptrace/get_syscall_info: fix for MIPS n32

2025-03-28 Thread Shuah Khan
fo))) { LOG_KILL_TRACEE("PTRACE_GET_SYSCALL_INFO: %m"); } switch (ptrace_stop) { thanks, -- Shuah

Re: bug report for linux-6.14/tools/testing/selftests/mm/pagemap_ioctl.c

2025-03-28 Thread Shuah Khan
. [truncLongCastAssignment] The source code of the first one is mem_size = 10 * page_size; Maybe better code: mem_size = 10ULL * page_size; Regards David Binderman Can you send a patch for us to review? thanks, -- Shuah

Re: [PATCH] selftests/nolibc: drop unnecessary sys/io.h include

2025-03-28 Thread Shuah Khan
--- base-commit: bceb73904c855c78402dca94c82915f078f259dd change-id: 20250324-nolibc-ioperm-155646560b95 Best regards, Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests/run_kselftest.sh: Use readlink if realpath is not available

2025-03-28 Thread Shuah Khan
th is not available +if which realpath > /dev/null; then +BASE_DIR=$(realpath $(dirname $0)) +else +BASE_DIR=$(readlink -f $(dirname $0)) +fi + cd $BASE_DIR TESTS="$BASE_DIR"/kselftest-list.txt if [ ! -r "$TESTS" ] ; then thanks, -- Shuah

[GIT PULL] kunit next update for Linux 6.15-rc1

2025-03-26 Thread Shuah Khan
;Kunit to check the longest symbol length") The commit c104c16073b7 conflicts with the mainline now with 62f3802332ed ("vdso: add generic time data storage") from kspp is now in the mainline. Stephen has the fixes for these two conflicts in next. (Thank you Stephen) diff

[GIT PULL] Kselftest next update for Linux 6.15-rc1

2025-03-26 Thread Shuah Khan
Hi Linus, Please pull the following kselftest next update for Linux 6.15-rc1. Fixes bugs and cleans up code in tracing, ftrace, and user_events tests. Adds missing executables to ftrace gitignore. diff is attached. thanks, -- Shuah

Re: Error during --arch x86_64 kunit test run

2025-03-15 Thread Shuah Khan
On 3/12/25 16:52, David Gow wrote: Hi Shuah, On Thu, 13 Mar 2025 at 05:14, Shuah Khan wrote: David, Brendan, Rae, I am seeing the following error when I run ./tools/testing/kunit/kunit.py run --arch x86_64 ERROR:root:ld:arch/x86/realmode/rm/realmode.lds:236: undefined symbol

Re: Error during --arch x86_64 kunit test run

2025-03-13 Thread Shuah Khan
On 3/12/25 20:21, David Gow wrote: On Thu, 13 Mar 2025 at 07:51, Shuah Khan wrote: On 3/12/25 16:52, David Gow wrote: Hi Shuah, On Thu, 13 Mar 2025 at 05:14, Shuah Khan wrote: David, Brendan, Rae, I am seeing the following error when I run ./tools/testing/kunit/kunit.py run --arch

Error during --arch x86_64 kunit test run

2025-03-12 Thread Shuah Khan
ssing: CONFIG_AMD_MEM_ENCRYPT=y Is there a better way to fix the dependencies? Does kunit default config need changing for x86_64? thanks, -- Shuah

Re: [PATCH v3 0/2 RESEND] update kselftest framework to check for required configs

2025-02-27 Thread Shuah Khan
insertions(+), 2 deletions(-) create mode 100755 tools/testing/selftests/check_kselftest_deps.pl thanks, -- Shuah

Re: [PATCH] selftests/dma: Fix bad array reference.

2025-02-26 Thread Shuah Khan
map latency(us):%.1f standard deviation:%.1f\n", map.avg_map_100ns/10.0, map.map_stddev/10.0); printf("average unmap latency(us):%.1f standard deviation:%.1f\n", How did you find this problem? thanks, -- Shuah

Re: [PATCH v2 2/2] Revert "selftests: kselftest: Fix build failure with NOLIBC"

2025-02-26 Thread Shuah Khan
d int min_major, ksft_exit_fail_msg("Can't parse kernel version\n"); return major > min_major || (major == min_major && minor >= min_minor); -#endif } #endif /* __KSELFTEST_H */ Looks good to me. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v2] selftests/vDSO: fix GNU hash table entry size for s390x

2025-02-26 Thread Shuah Khan
warnings and runtime crashes. I would rephrase it as follows: On s390, this caused the GNU hash algorithm to access its 32-bit entries as if they were 64-bit, triggering compiler warnings (assignment between "Elf64_Xword *" and "Elf64_Word *") and runtime crashes. And take it

Re: [PATCH v2 00/16] selftests: vDSO: parse_vdso: Make compatible with nolibc

2025-02-26 Thread Shuah Khan
7ff48 Best regards, Here is my Ack for this series to go through vDSO or x86 tree Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

2025-02-24 Thread Shuah Khan
On 2/24/25 12:26, Steven Rostedt wrote: On Mon, 24 Feb 2025 19:21:26 + Beau Belgrave wrote: Beau? I applied it locally and ensured it passed (seems timing related). Acked-by: Beau Belgrave Thanks Beau, Shuah, Please apply this patch: Acked-by: Steven Rostedt (Google

Re: [PATCH v1] selftests/user_events: Fix failures caused by test code

2025-02-21 Thread Shuah Khan
take this through my tree. thanks, -- Shuah

Re: [PATCH] selftests: pid_namespace and pidfd missing include

2025-02-18 Thread Shuah Khan
h" -- 2.43.0 Hello, I'm reaching out to know if you have any comments or feedbacks about this patch. Christian, would you like me to pick this patch up? thanks, -- Shuah

Re: [PATCH v5 3/3] rseq/selftests: Add test for mm_cid compaction

2025-02-18 Thread Shuah Khan
Please send v6 with the suggested changes. Also change the commit summary to "selftests/rseq" thanks, -- Shuah

Re: [PATCH v5 0/3] selftests/lam: get_user additions and LAM enabled check

2025-01-23 Thread Shuah Khan
On 1/15/25 02:06, Maciej Wieczor-Retman wrote: Hello Shuah, I'd like to bump this series for visibility and ask if you still consider these patches okay to merge? Just checked and there were no conflicts after applying it on the newest kselftest-next. This is x86 test and usually

[GIT PULL] kunit next update for Linux 6.14-rc1

2025-01-21 Thread Shuah Khan
the driver-core tree. diff is attached. thanks, -- Shuah The following changes since commit 40384c840ea1944d7c5a392e8975ed088ecf0b37: Linux 6.13-rc1 (2024-12-01 14:28:56 -0800) are available in the Git repository at: git:/

[GIT PULL] kselftest next update for Linux 6.14-rc1

2025-01-21 Thread Shuah Khan
: 912d6f669725 ("selftests/net: packetdrill: report benign debug flakes as xfail") from the net-next tree and commit: 279e9403c5bd ("selftests: Warn about skipped tests in result summary") from the kselftest tree. diff is attache

Re: [PATCH] selftests/.gitignore include missing log file

2025-01-20 Thread Shuah Khan
/AsyncTest.log tpm2/SpaceTest.log Please move both tmp2 ones to gitignore under tpm2 test and send me v2 patch. thanks, -- Shuah

Re: [PATCH] selftests/rseq: Fix handling of glibc without rseq support

2025-01-15 Thread Shuah Khan
On 1/14/25 17:45, Mathieu Desnoyers wrote: On 2025-01-14 19:14, Shuah Khan wrote: On 1/14/25 07:51, Mathieu Desnoyers wrote: When porting librseq commit: commit c7b45750fa85 ("Adapt to glibc __rseq_size feature detection") from librseq to the kernel selftests, the following line

Re: [PATCH] selftests/rseq: Fix handling of glibc without rseq support

2025-01-14 Thread Shuah Khan
commit id" warnings on all of these - my repo is at 6.13 rc7 Also would you like to add Reported-by for Raghavendra Rao Ananta? thanks, -- Shuah

Re: [PATCH v8 0/2] selftests/resctrl: SNC kernel support discovery

2025-01-14 Thread Shuah Khan
On 1/14/25 16:28, Reinette Chatre wrote: On 1/14/25 3:25 PM, Shuah Khan wrote: Thank you for bumping it up to top of my Inbox. I will apply these for 6.14-rc1 now. Thank you very much Shuah. Reinette Done. These two patches are now in linux-kselftest next. thanks, -- Shuah

Re: [PATCH v8 0/2] selftests/resctrl: SNC kernel support discovery

2025-01-14 Thread Shuah Khan
On 1/14/25 15:30, Reinette Chatre wrote: Hi Shuah, On 12/19/24 10:35 AM, Reinette Chatre wrote: Hi Shuah, On 12/16/24 7:18 AM, Maciej Wieczor-Retman wrote: Sub-Numa Clustering (SNC) allows splitting CPU cores, caches and memory into multiple NUMA nodes. When enabled, NUMA-aware applications

Re: [PATCH] selftests/rseq: Fix rseq for cases without glibc support

2025-01-14 Thread Shuah Khan
On 1/14/25 07:27, Mathieu Desnoyers wrote: On 2025-01-14 09:07, Mathieu Desnoyers wrote: On 2025-01-13 18:06, Shuah Khan wrote: On 12/10/24 15:44, Raghavendra Rao Ananta wrote: Currently the rseq constructor, rseq_init(), assumes that glibc always has the support for rseq symbols (__rseq_size

Re: [PATCH] selftests/rseq: Fix rseq for cases without glibc support

2025-01-13 Thread Shuah Khan
l.org Fixes: 73a4f5a704a2 ("selftests/rseq: Fix mm_cid test failure") Signed-off-by: Raghavendra Rao Ananta --- Applied to linux_kselftest next for Linux 6.14-rc1 after fixing the commit if for Fixes tag thanks, -- Shuah

Re: [PATCH] rseq/selftests: Fix riscv rseq_offset_deref_addv inline asm

2025-01-13 Thread Shuah Khan
x86 port.  Fix this by just using an "r" constraint. I have compile tested this only for riscv.  However, the same fixes I use in the OpenRISC rseq selftests and everything passes with no issues. Signed-off-by: Stafford Horne Reviewed-by: Mathieu Desnoyers If these are going throu

Re: [PATCH 3/3] rseq/selftests: Add support for OpenRISC

2025-01-13 Thread Shuah Khan
! Reviewed-by: Mathieu Desnoyers If these are going through risc repo Acked-by: Shuah Khan If you would like me to take this, let me know. thanks, -- Shuah

Re: [PATCH v8 0/2] selftests: tmpfs: Add kselftest support

2025-01-08 Thread Shuah Khan
simply exits without any warning or message. This series of patch adds: Applied to linux-kselftest next for Linux 6.14-rc1. thanks, -- Shuah

Re: [PATCH] selftests: harness: fix printing of mismatch values in __EXPECT()

2025-01-08 Thread Shuah Khan
) == info.entry.args[1] (18446744072548908753) Fixes: b5bb6d3068ea ("selftests/seccomp: fix 32-bit build warnings") Signed-off-by: Dmitry V. Levin Ah nice, thanks! Reviewed-by: Kees Cook Thank you. Applied to linux-kselftest next for Linux 6.14-rc1. thanks, -- Shuah

Re: [PATCH] selftests/nolibc: start qemu with 1 GiB of memory

2025-01-06 Thread Shuah Khan
ctory. --- base-commit: 8cf0b93919e13d1e8d4466eb4080a4c4d9d66d7b change-id: 20241007-nolibc-qemu-mem-5ed605520472 Best regards, Did we take care of this one? Apologies if I didn't. We can include this in 6.14 pr. thanks, -- Shuah

Re: [PATCH v7 1/2] selftests: tmpfs: Add Test-skip if not run as root

2025-01-03 Thread Shuah Khan
On 1/3/25 09:36, Shivam Chaudhary wrote: On 03/01/25 3:24 AM, Shuah Khan wrote: On 1/2/25 03:04, Shivam Chaudhary wrote: Add 'ksft_exit_skip()', if  not run as root, with an appropriate Warning. Add 'ksft_print_header()' and 'ksft_set_plan()' to structure test o

Re: [PATCH v7 1/2] selftests: tmpfs: Add Test-skip if not run as root

2025-01-02 Thread Shuah Khan
are, errno 1 - With root No, output After change: - Without root TAP version 13 1..1 ok 2 # SKIP This test needs root to run! Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0 - With root TAP version 13 1..1 How are you running this test to see the before ad after results? thanks, -- Shuah

Re: [PATCH v7 2/2] selftests: tmpfs: Add kselftest support to tmpfs

2025-01-02 Thread Shuah Khan
} close(fd); fd = openat(AT_FDCWD, "/tmp", O_WRONLY|O_TMPFILE, 0600); if (fd == -1) { - fprintf(stderr, "error: open 2, errno %d\n", errno); - return 1; + ksft_exit_fail_msg("openat() error: Opening the second temporary file: Fail %d\n", errno); } + ksft_test_result_pass("Test : Success\n"); There is no need to print success here. + ksft_exit_pass(); return 0; } thanks, -- Shuah

Re: [PATCH v3 3/3] drivers: base: test: Add ...find_device_by...(... NULL) tests

2024-12-20 Thread Shuah Khan
This one also can go through Greg's drivers tree: Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v3 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc

2024-12-20 Thread Shuah Khan
these to return 0 (false). Reviewed-by: Rob Herring (Arm) Acked-by: Rafael J. Wysocki Signed-off-by: Brian Norris --- Seems sensible enough to me. Acked-by: David Gow I assume this series (including the KUnit test changes) will go in via Greg. Works for me. Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests/run_kselftest.sh: Fix help string for --per-test-log

2024-12-20 Thread Shuah
ank you for the patch. Applied to linux-kselftest next for Linux 6.14-rc1 thanks, -- Shuah

Re: [PATCH v6 2/2] selftests: tmpfs: Add kselftest support to tmpfs

2024-12-20 Thread Shuah
return 4; + ksft_test_result_skip("unshare() error: unshare, errno %d\n", errno); ksft_exit_skip_msg() is a better choice here. The rest looks good. thanks, -- Shuah

Re: [PATCH v2] selftests: acct: Add ksft_exit_skip if not running as root

2024-12-17 Thread Shuah Khan
needs root to run!\n"); return 1; } Applied to linux-kselftest next for Linux 6.14-rc1 thanks, -- Shuah

Re: [PATCH] selftests: kselftest: Fix the wrong format specifier

2024-12-17 Thread Shuah Khan
KIP "); } Applied to linux-kselftest next for Linux 6.14-rc1 thanks, -- Shuah

Re: [PATCH v2 resend] selftests: timers: clocksource-switch: Adapt progress to kselftest framework

2024-12-16 Thread Shuah Khan
- printf("Running Asynchronous Switching Tests...\n"); + ksft_print_msg("Running Asynchronous Switching Tests...\n"); pid = fork(); if (!pid) return run_tests(runtime); Applied to linux-kselftest next for Linux 6.14-rc1. thanks, -- Shuah

[GIT PULL] Kselftest fixes for Linux 6.13-rc3

2024-12-11 Thread Shuah Khan
rebase this morning. diff is attached. thanks, -- Shuah The following changes since commit 40384c840ea1944d7c5a392e8975ed088ecf0b37: Linux 6.13-rc1 (2024-12-01 14:28:56 -0800) are available in the Git repository at: git

Re: [PATCH for-next v3] selftests/filesystems: Add missing gitignore file

2024-12-10 Thread Shuah Khan
On 11/22/24 00:37, Li Zhijian wrote: Compiled binary files should be added to .gitignore 'git status' complains: Untracked files: (use "git add ..." to include in what will be committed) filesystems/statmount/statmount_test_ns Cc: Shuah Khan Cc: Christian Brauner Cc

  1   2   3   4   5   6   7   8   9   10   >