On 4/3/24 19:10, Shuah Khan wrote:
Fix the following -Wformat-security compile warnings adding missing
format arguments:
latency-collector.c: In function ‘show_available’:
latency-collector.c:938:17: warning: format not a string literal and
no format arguments [-Wformat-security]
938
literal and
no format arguments [-Wformat-security]
1881 | errx(EXIT_FAILURE, no_tracer_msg);
| ^~~~
Signed-off-by: Shuah Khan
---
tools/tracing/latency/latency-collector.c | 8
1 file changed, 4 insertions(+), 4 deletions
is tools?
A mention coccicheck scripts and mention of smatch?
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.11.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
On 4/16/21 1:33 PM, Igor Torrente wrote:
On 4/15/21 2:25 PM, Shuah Khan wrote:
On 4/15/21 8:07 AM, Igor Matheus Andrade Torrente wrote:
Fixes a race condition - for lack of a more precise term - between
em28xx_v4l2_open and em28xx_v4l2_init, by detaching the v4l2_dev,
media_pad and vdev
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
rivers: net: fix memory leak in atusb_probe
Phillip Potter
net: tun: set tun->dev->addr_len during TUNSETLINK processing
Du Cheng
cfg80211: remove WARN_ON() in cfg80211_sme_connect
Shuah Khan
usbip: fix vudc usbip_sockfd_store races leading to gpf
Samuel Mendoza-Jonas
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.14.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.11.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
8xx-video.c | 300 +++
drivers/media/usb/em28xx/em28xx.h| 6 +-
3 files changed, 209 insertions(+), 101 deletions(-)
The changes looks good to me. Have you tried building as a modules and
running modprobes and rmmods? You can do that without a device.
thanks,
-- Shuah
On 4/14/21 9:26 AM, Shuah Khan wrote:
On 4/14/21 6:55 AM, Luis Chamberlain wrote:
Shuah, a question for you toward the end here.
On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote:
This use-after-free happens when a fw_priv object has been freed but
hasn't been removed from
On 4/14/21 6:55 AM, Luis Chamberlain wrote:
Shuah, a question for you toward the end here.
On Wed, Apr 14, 2021 at 02:24:05PM +0530, Anirudh Rayabharam wrote:
This use-after-free happens when a fw_priv object has been freed but
hasn't been removed from the pending list (pending_fw_head
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions. No problems
with wifi this time. I will be on the lookout for this in the future.
Tested-by: Shuah Khan
thanks
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.11.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
e8cb49d2
RDX: 0689 RSI: 0006e8cb49d2 RDI:
RBP: b11e01a77e90 R08: 0006e8cb505b R09: 0e29
R10: 0f04 R11: 8d81bf061528 R12: 0003
R13: 8df9e860 R14: 8df9e980 R15: 0006e8cb505b
cpuidle_enter+0x17/0x20
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.11.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
On 4/9/21 2:00 PM, Shuah Khan wrote:
On 4/9/21 2:58 AM, Suravee Suthikulpanit wrote:
In early AMD desktop/mobile platforms (during 2013), when the IOMMU
Performance Counter (PMC) support was first introduced in
commit 30861ddc9cca ("perf/x86/amd: Add IOMMU Performance Counter
res
30935570.3...@monopod.intra.ispras.ru/
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201753
Cc: Tj (Elloe Linux)
Cc: Shuah Khan
Cc: Alexander Monakov
Cc: David Coe
Cc: Paul Menzel
Signed-off-by: Suravee Suthikulpanit
---
Tested-by: Shuah Khan
thanks,
-- Shuah
Results with this patch on AMD Ryzen 5 PR
On 4/9/21 10:37 AM, Shuah Khan wrote:
On 4/9/21 2:58 AM, Suravee Suthikulpanit wrote:
In early AMD desktop/mobile platforms (during 2013), when the IOMMU
Performance Counter (PMC) support was first introduced in
commit 30861ddc9cca ("perf/x86/amd: Add IOMMU Performance Counter
res
to removing the pre-init
test.
Link:
https://lore.kernel.org/linux-iommu/alpine.lnx.3.20.13.2006030935570.3...@monopod.intra.ispras.ru/
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201753
Cc: Tj (Elloe Linux)
Cc: Shuah Khan
Cc: Alexander Monakov
Cc: David Coe
Signed-off-by: Paul Menzel
d
in use
be relatively safe to remove this legacy logic.
Link:
https://lore.kernel.org/linux-iommu/alpine.lnx.3.20.13.2006030935570.3...@monopod.intra.ispras.ru/
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=201753
Cc: Tj (Elloe Linux)
Cc: Shuah Khan
Cc: Alexander Monakov
Cc: David Coe
Cc: P
video_unregister_device(>vdev);
+video_device_node_name(v4l2->vdev));
+ video_unregister_device(v4l2->vdev);
}
v4l2_ctrl_handler_free(>ctrl_handler);
- v4l2_device_unregister(>v4l2_dev);
-err:
+ v4l2_device_unregister(v4l2->v4l2_dev);
+
+v4l2_device_register_error:
+ v4l2_device_put(v4l2->v4l2_dev);
+v4l2_dev_error:
dev->v4l2 = NULL;
kref_put(>ref, em28xx_free_v4l2);
+v4l2_error:
mutex_unlock(>lock);
return ret;
}
diff --git a/drivers/media/usb/em28xx/em28xx.h
b/drivers/media/usb/em28xx/em28xx.h
index 6648e11f1271..dbcc297b5a0d 100644
--- a/drivers/media/usb/em28xx/em28xx.h
+++ b/drivers/media/usb/em28xx/em28xx.h
@@ -552,10 +552,10 @@ struct em28xx_v4l2 {
struct kref ref;
struct em28xx *dev;
- struct v4l2_device v4l2_dev;
+ struct v4l2_device *v4l2_dev;
struct v4l2_ctrl_handler ctrl_handler;
- struct video_device vdev;
+ struct video_device *vdev;
struct video_device vbi_dev;
struct video_device radio_dev;
@@ -601,7 +601,7 @@ struct em28xx_v4l2 {
unsigned int field_count;
#ifdef CONFIG_MEDIA_CONTROLLER
- struct media_pad video_pad, vbi_pad;
+ struct media_pad *video_pad, vbi_pad;
struct media_entity *decoder;
#endif
};
thanks,
-- Shuah
On 3/31/21 5:23 AM, Muhammad Usama Anjum wrote:
On Fri, 2021-03-26 at 14:24 -0600, Shuah Khan wrote:
On 3/25/21 5:46 AM, Muhammad Usama Anjum wrote:
The driver was assuming that all the parameters would be valid. But it
is possible that parameters are sent from userspace. For those cases
On 4/7/21 1:57 PM, Fenghua Yu wrote:
Change a few printed messages to report test progress more clearly.
Add a missing "\n" at the end of one printed message.
Suggested-by: Shuah Khan
Signed-off-by: Fenghua Yu
---
Change log:
v2:
- Add "Pass:" and "Fail:
API docs and leave filling in the blanks as an exercise to
the reader.
Also give an example of kunit_fail_current_test().
Signed-off-by: Daniel Latypov
Reviewed-by: Brendan Higgins
Thank you. Applied to linux-kseftest kunit branch for 5.13-rc1
thanks,
-- Shuah
On 4/7/21 11:12 AM, Fenghua Yu wrote:
Hi, Shuah,
On Wed, Apr 07, 2021 at 08:33:23AM -0600, Shuah Khan wrote:
On 4/5/21 6:52 PM, Fenghua Yu wrote:
- ksft_print_msg("%s cache miss rate within %d%%\n",
- ret ? "Fail:" : "
On 4/5/21 6:52 PM, Fenghua Yu wrote:
A few printed messages contain pass/fail strings which should be shown
in test results. Remove the pass/fail strings in the messages to avoid
confusion.
Add "\n" at the end of one printed message.
Suggested-by: Shuah Khan
Signed-off-by:
faddr()")
Reported-by: Pavel Machek
Signed-off-by: Shuah Khan
---
drivers/net/wireless/ath/ath10k/wmi-tlv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
index d97b33f789e4..7efbe03fb
y: Brendan Higgins
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
(struct ath10k
*ar, struct sk_buff *skb)
GFP_ATOMIC
);
break;
+ default:
+ kfree(tb);
+ return;
}
exit:
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.11.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
ue : false;
This looks right to me. test_fw_in_ns() returns true or false and
test_fw_in_ns() callers print appropriate message.
I don't think this patch is necessary.
thanks,
-- Shuah
On 4/2/21 3:44 PM, Shuah Khan wrote:
On 4/2/21 3:25 PM, Daniel Latypov wrote:
On Fri, Apr 2, 2021 at 10:53 AM Shuah Khan
wrote:
On 4/2/21 2:55 AM, Brendan Higgins wrote:
On Thu, Mar 11, 2021 at 7:23 AM Daniel Latypov
wrote:
From: Uriel Guajardo
Add a kunit_fail_current_test() function
On 4/2/21 3:25 PM, Daniel Latypov wrote:
On Fri, Apr 2, 2021 at 10:53 AM Shuah Khan wrote:
On 4/2/21 2:55 AM, Brendan Higgins wrote:
On Thu, Mar 11, 2021 at 7:23 AM Daniel Latypov wrote:
From: Uriel Guajardo
Add a kunit_fail_current_test() function to fail the currently running
test
On 4/2/21 12:18 PM, Fenghua Yu wrote:
Hi, Shuah,
On Fri, Apr 02, 2021 at 12:17:17PM -0600, Shuah Khan wrote:
On 3/26/21 1:45 PM, Fenghua Yu wrote:
Hi, Shuah,
On Wed, Mar 17, 2021 at 02:22:34AM +, Fenghua Yu wrote:
This patch set has several miscellaneous fixes to resctrl selftest tool
a bit confusing. Please change this to read
and send a follow-on patch on top of linux-kselftest next
"Check kernel support for resctrl filesystem"
thanks,
-- Shuah
On 4/2/21 1:27 PM, Daniel Latypov wrote:
On Fri, Apr 2, 2021 at 11:00 AM Shuah Khan wrote:
On 4/2/21 3:32 AM, Brendan Higgins wrote:
TL;DR
$ ./tools/testing/kunit/kunit.py run --kunitconfig=lib/kunit
Per suggestion from Ted [1], we can reduce the amount of typing by
assuming a convention
On 4/2/21 1:09 PM, Daniel Latypov wrote:
On Fri, Apr 2, 2021 at 10:47 AM Shuah Khan wrote:
On 4/2/21 3:35 AM, Brendan Higgins wrote:
On Fri, Feb 5, 2021 at 2:18 PM Daniel Latypov wrote:
Before:
Expected str == "world", but
str == hello
"world&qu
On 3/26/21 1:45 PM, Fenghua Yu wrote:
Hi, Shuah,
On Wed, Mar 17, 2021 at 02:22:34AM +, Fenghua Yu wrote:
This patch set has several miscellaneous fixes to resctrl selftest tool
that are easily visible to user. V1 had fixes to CAT test and CMT test
but they were dropped in V2 because having
in the series and address your
comments.
Thank you for your review!
Looks like a few patches in this series needs updates. Do you plan to
send the new revision for consideration for 5.13?
thanks,
-- Shuah
-by: Brendan Higgins
Should this be captured in documentation. Especially since this
is file is .* file.
Do you want to include doc in this patch? Might be better that way.
thanks,
-- Shuah
run checkpatch on your patches in the future. I am seeing
a few checkpatch readability type improvements that can be made.
Please make changes and send v2 with Brendan's Reviewed-by.
thanks,
-- Shuah
ou'd get:
Expected "hello" == "world", but
Signed-off-by: Daniel Latypov
Reviewed-by: Brendan Higgins
Hi Daniel,
Please run checkpatch on your patches in the future. I am seeing
a few checkpatch readability type improvements that can be made.
Please make changes and send v2 with Brendan's Reviewed-by.
thanks,
-- Shuah
and uses it in vhci_hcd in the first
patch. Subsequent patches fix usbip_host, vudc and the last patch fixes
the common event handler code path.
Shuah Khan (4):
usbip: add sysfs_lock to synchronize sysfs code paths
usbip: stub-dev synchronize sysfs code paths
usbip: vudc synchronize sysfs code paths
-and-tested-by: syzbot+a93fba6d384346a76...@syzkaller.appspotmail.com
Cc: sta...@vger.kernel.org
Signed-off-by: Shuah Khan
---
drivers/usb/usbip/usbip_common.h | 3 +++
drivers/usb/usbip/vhci_hcd.c | 1 +
drivers/usb/usbip/vhci_sysfs.c | 30 +-
3 files changed, 29
+a93fba6d384346a76...@syzkaller.appspotmail.com
Cc: sta...@vger.kernel.org
Signed-off-by: Shuah Khan
---
drivers/usb/usbip/vudc_dev.c | 1 +
drivers/usb/usbip/vudc_sysfs.c | 5 +
2 files changed, 6 insertions(+)
diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c
index
-by: syzbot+a93fba6d384346a76...@syzkaller.appspotmail.com
Cc: sta...@vger.kernel.org
Signed-off-by: Shuah Khan
---
drivers/usb/usbip/stub_dev.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/usbip/stub_dev.c b/drivers/usb/usbip/stub_dev.c
index 8f1de1fbbeed
.
Reported-and-tested-by: syzbot+a93fba6d384346a76...@syzkaller.appspotmail.com
Cc: sta...@vger.kernel.org
Signed-off-by: Shuah Khan
---
drivers/usb/usbip/usbip_event.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/usbip/usbip_event.c b/drivers/usb/usbip/usbip_event.c
index
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.11.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
patches. Accepting
feedback and working with the community will ensure that your work
will be taken seriously now and in the future.
Your responses go against the CoC. If this continues, we will take
action to add you to the kernel wide blacklist.
Please refer to:
https://www.kernel.org/doc/h
? Is there a
scenario where vhci_hcd will receive these values from userspace?
Is there a way to reproduce the problem?
thanks,
-- Shuah
t line and it is becoming hard to tell
them apart.
thanks,
-- Shuah
you both. Applied now for 5.13-rc1
thanks,
-- Shuah
vudc\n";
void usbip_list_usage(void)
{
Thank you. Looks good.
Acked-by: Shuah Khan
thanks,
-- Shuah
torage
+- Unbind a gadget from usbip-vudc.
+- in this example, the previous mass storage gadget is unbound.
+
.SH "SEE ALSO"
\fBusbip\fP\fB(8)\fB\fP
Thank you. Looks good.
Acked-by: Shuah Khan
thanks,
-- Shuah
Dunlap
Cc: Valentina Manea
Cc: Shuah Khan
Cc: Shuah Khan
Cc: linux-...@vger.kernel.org
---
tools/usb/usbip/libsrc/list.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
--- linux-next-20210323.orig/tools/usb/usbip/libsrc/list.h
+++ linux-next-20210323/tools/usb/usbip/libsrc
-by: Shuah Khan
---
drivers/usb/usbip/vhci_hcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index 3209b5ddd30c..a20a8380ca0c 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -594,6 +594,8 @@ static
ue,
pr_err("invalid port number %d\n", wIndex);
goto error;
}
+ if (wValue >= 32)
+ goto error;
if (hcd->speed == HCD_USB3) {
if ((vhci_hcd->port_status[rhport] &
USB_SS_PORT_STAT_POWER) != 0) {
--
2.27.0
thanks,
-- Shuah
=/tmp/tmp.img
+- Bind a gadget to usbip-vudc
+- in this example, a mass storage gadget is bound
+
+server:# usbip list --device
+- Note this is the server side
+
.SH "SEE ALSO"
\fBusbip\fP\fB(8)\fB\fP
thanks,
-- Shuah
Hi Linus,
Please pull the following KUnit fixes update for Linux 5.12-rc5.
This KUnit update for Linux 5.12-rc5 consists of two fixes to kunit
tool from David Gow.
diff is attached.
thanks,
-- Shuah
The following changes since
t;-d, --device List the local USB gadgets bound to
usbip-vudc\n";
void usbip_list_usage(void)
{
Looks good to me. Thanks for adding this.
Acked-by: Shuah Khan
thanks,
-- Shuah
On 3/17/21 9:06 AM, Shuah Khan wrote:
On 3/17/21 12:21 AM, Tetsuo Handa wrote:
Shuah, this driver is getting more and more cryptic and buggy.
Please explain the strategy for serialization before you write patches.
- Fix attach_store() to check usbip_event_happened() before
waking up
On 3/17/21 9:38 AM, Tetsuo Handa wrote:
On 2021/03/18 0:06, Shuah Khan wrote:
Yes. I haven't sent the patch for that reason. I am trying to test a
solution. I haven't come up with a solution yet.
Holding event_lock isn't the right solution. I am not going to accept
that. This is a window
On 3/17/21 12:21 AM, Tetsuo Handa wrote:
Shuah, this driver is getting more and more cryptic and buggy.
Please explain the strategy for serialization before you write patches.
- Fix attach_store() to check usbip_event_happened() before
waking up threads.
No, this helps nothing.
diff
On 3/12/21 12:08 AM, Hillf Danton wrote:
On Thu, 11 Mar 2021 19:27:37 -0700 Shuah Khan wrote:
vhci_shutdown_connection() references connection state (tcp_socket,
tcp_rx, tcp_tx, sockfd) saved in usbpip_device without holding the
lock.
Current connection tear down sequence:
Step 1: shutdown
On 3/12/21 3:45 AM, Johan Hovold wrote:
On Thu, Mar 11, 2021 at 07:27:37PM -0700, Shuah Khan wrote:
vhci_shutdown_connection() references connection state (tcp_socket,
tcp_rx, tcp_tx, sockfd) saved in usbpip_device without holding the
lock.
Current connection tear down sequence:
Step 1
.
Reported-and-tested-by: syzbot+a93fba6d384346a76...@syzkaller.appspotmail.com
Signed-off-by: Shuah Khan
---
drivers/usb/usbip/usbip_common.h | 1 +
drivers/usb/usbip/vhci_hcd.c | 55 +++-
drivers/usb/usbip/vhci_sysfs.c | 4 +++
3 files changed, 45 insertions(+), 15
On 3/11/21 7:16 AM, Shuah Khan wrote:
On 3/11/21 3:44 AM, Colin King wrote:
From: Colin Ian King
Currently udc->ud.tcp_rx is being assigned twice, the second assignment
is incorrect, it should be to udc->ud.tcp_tx instead of rx. Fix this.
Addresses-Coverity: ("Unused va
d.tcp_tx = tcp_tx;
udc->ud.status = SDEV_ST_USED;
spin_unlock_irq(>ud.lock);
Thank you for finding and fixing this. This is my bad.
Acked-by: Shuah Khan
thanks,
-- Shuah
at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-4.9.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.4.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.11.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by: Shuah Khan
thanks,
-- Shuah
'GENERIC_EE_CHANNEL_NOT_RUNNING_FVAL'
case GENERIC_EE_CHANNEL_NOT_RUNNING_FVAL:
^
1 error generated.
make[4]: *** [scripts/Makefile.build:279: drivers/net/ipa/gsi.o] Error 1
Offending patch dropped, thanks.
Thanks. Saw the same error on my system. Moving on to rc2.
thanks,
-- Shuah
On 3/4/21 4:12 PM, Shuah Khan wrote:
On 3/3/21 9:35 PM, Lucas Stankus wrote:
On Wed, Mar 03, 2021 at 12:56:05PM -0800, Brendan Higgins wrote:
Did you change anything other than fixing the Signed-off-by that Shuah
requested?
No, I only fixed the Signed-off-by warning.
Generally when you
On 3/9/21 6:02 PM, Tetsuo Handa wrote:
On 2021/03/10 9:29, Shuah Khan wrote:
It is not a large grain lock. Since event_handler() is exclusively executed,
this lock
does _NOT_ block event_handler() unless attach/detach operations run
concurrently.
event handler queues the events
On 3/9/21 5:03 PM, Tetsuo Handa wrote:
On 2021/03/10 8:52, Shuah Khan wrote:
On 3/9/21 4:40 PM, Tetsuo Handa wrote:
On 2021/03/10 4:50, Shuah Khan wrote:
On 3/9/21 4:04 AM, Tetsuo Handa wrote:
On 2021/03/09 1:27, Shuah Khan wrote:
Yes. We might need synchronization between events, threads
1 - 100 of 8581 matches
Mail list logo
